From nobody Mon Feb 9 05:41:16 2026 Received: from sender4-pp-e106.zoho.com (sender4-pp-e106.zoho.com [136.143.188.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4A80215055 for ; Mon, 12 Jan 2026 14:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.106 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768228708; cv=pass; b=UyjuDZrYhaERNTRuf4mBiXKzGEPucwWXzA21XftqoE3XUPep5DVFPV3XhivirjAec24Ov5Cu0pGbqFvEkvo4lBFDiR9tm7RhaLjQmlb2e6pwnZrvAVCcVE7uSEJ7zkT+KEEYSTOCHWKQmCEzO33r4vTOZTsQEW9ndszzie23dR0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768228708; c=relaxed/simple; bh=cC6PIn5SxNVe+H+q81vYYKHvw0FdREHDmf7/kI8GUs8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S0ckITkWgGLarKgLbxMATv9jncEMDGfwIXA3a3AFZkadQYjuxPRoCa8UZRtI7IxZyziM0e8woNCK7ROHme3y/Z0pLfq/x2wJBk+Nkws5M9LxZ8bm1tyCNKuef+Ued4YFPntReYat2EY09/ejhtGpv/7JC1tRgfWeQ//oYOfN/F4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=R1MLRlSC; arc=pass smtp.client-ip=136.143.188.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="R1MLRlSC" ARC-Seal: i=1; a=rsa-sha256; t=1768228691; cv=none; d=zohomail.com; s=zohoarc; b=XQcPBRY9U/HgGn4ofXPMCHUAL7N3O1Xb+RsjVZyZz0bVTx7qcAyTnAwMoKAUk1QaT26aXwG+Ea7H+KNjOg2Ih7xV/OMmRz9Ov62aCqVWp8XWJWqtMxfzkL6OSFRcxM51Yq2vobXLZwCGAYzBOVZfQ+5ODcFpqU84/OaFVTpKlws= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768228691; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=kyZugTXf+rUFTPVUDiiwoLpAlyvPI6hD3B1xvQW8heU=; b=Ccjws1ggRoNuhdfCk+bSCE32LEBEtqxAuij3SlkLrH8m5cpitw+cpc+7zHoik521lXI51MXB8f82FjkWef5XzHsBYz8prIJ72cnTe2YAZG9xAViOZ9HXZ2Zxst/clsHioeC65IwvS4/ZMWJcinP3de5Fmd/7pEg7CSiw0YkE69I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768228691; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=kyZugTXf+rUFTPVUDiiwoLpAlyvPI6hD3B1xvQW8heU=; b=R1MLRlSCS/JE4VIq1BFcGZcq2t1E2R8bG9tqejWz9WFbKmkT1DzdI/ZBvs4dL2al rfpWeBc0hn/hqjZ9c+hmvn2vU/hqnEahOEptRmyyRuPFI+fH/DGc72OZBIisYQji60b +e6msdwCC7M0wMLgVJl1PtYOSefn/BaEtfRQHgGY= Received: by mx.zohomail.com with SMTPS id 1768228689093450.02470310151125; Mon, 12 Jan 2026 06:38:09 -0800 (PST) From: Nicolas Frattaroli Date: Mon, 12 Jan 2026 15:37:49 +0100 Subject: [PATCH v8 1/4] drm/panthor: Rework panthor_irq::suspended into panthor_irq::state Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260112-panthor-tracepoints-v8-1-63efcb421d22@collabora.com> References: <20260112-panthor-tracepoints-v8-0-63efcb421d22@collabora.com> In-Reply-To: <20260112-panthor-tracepoints-v8-0-63efcb421d22@collabora.com> To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chia-I Wu , Karunika Choo Cc: kernel@collabora.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 To deal with the threaded interrupt handler and a suspend action overlapping, the boolean panthor_irq::suspended is not sufficient. Rework it into taking several different values depending on the current state, and check it and set it within the IRQ helper functions. Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/panthor/panthor_device.h | 40 +++++++++++++++++++++++++---= ---- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/pan= thor/panthor_device.h index f35e52b9546a..424f6cd1a814 100644 --- a/drivers/gpu/drm/panthor/panthor_device.h +++ b/drivers/gpu/drm/panthor/panthor_device.h @@ -61,6 +61,17 @@ enum panthor_device_pm_state { PANTHOR_DEVICE_PM_STATE_SUSPENDING, }; =20 +enum panthor_irq_state { + /** @PANTHOR_IRQ_STATE_ACTIVE: IRQ is active and ready to process events.= */ + PANTHOR_IRQ_STATE_ACTIVE =3D 0, + /** @PANTHOR_IRQ_STATE_PROCESSING: IRQ is currently processing events. */ + PANTHOR_IRQ_STATE_PROCESSING, + /** @PANTHOR_IRQ_STATE_SUSPENDED: IRQ is suspended. */ + PANTHOR_IRQ_STATE_SUSPENDED, + /** @PANTHOR_IRQ_STATE_SUSPENDING: IRQ is being suspended. */ + PANTHOR_IRQ_STATE_SUSPENDING, +}; + /** * struct panthor_irq - IRQ data * @@ -76,8 +87,8 @@ struct panthor_irq { /** @mask: Current mask being applied to xxx_INT_MASK. */ u32 mask; =20 - /** @suspended: Set to true when the IRQ is suspended. */ - atomic_t suspended; + /** @state: one of &enum panthor_irq_state reflecting the current state. = */ + atomic_t state; }; =20 /** @@ -409,8 +420,10 @@ static irqreturn_t panthor_ ## __name ## _irq_raw_hand= ler(int irq, void *data) { \ struct panthor_irq *pirq =3D data; \ struct panthor_device *ptdev =3D pirq->ptdev; \ + enum panthor_irq_state state; \ \ - if (atomic_read(&pirq->suspended)) \ + state =3D atomic_read(&pirq->state); \ + if (state =3D=3D PANTHOR_IRQ_STATE_SUSPENDED || state =3D=3D PANTHOR_IRQ_= STATE_SUSPENDING) \ return IRQ_NONE; \ if (!gpu_read(ptdev, __reg_prefix ## _INT_STAT)) \ return IRQ_NONE; \ @@ -423,8 +436,11 @@ static irqreturn_t panthor_ ## __name ## _irq_threaded= _handler(int irq, void *da { \ struct panthor_irq *pirq =3D data; \ struct panthor_device *ptdev =3D pirq->ptdev; \ + enum panthor_irq_state state; \ irqreturn_t ret =3D IRQ_NONE; \ \ + atomic_cmpxchg(&pirq->state, PANTHOR_IRQ_STATE_ACTIVE, PANTHOR_IRQ_STATE_= PROCESSING); \ + \ while (true) { \ u32 status =3D gpu_read(ptdev, __reg_prefix ## _INT_RAWSTAT) & pirq->mas= k; \ \ @@ -435,8 +451,13 @@ static irqreturn_t panthor_ ## __name ## _irq_threaded= _handler(int irq, void *da ret =3D IRQ_HANDLED; \ } \ \ - if (!atomic_read(&pirq->suspended)) \ - gpu_write(ptdev, __reg_prefix ## _INT_MASK, pirq->mask); \ + state =3D atomic_read(&pirq->state); \ + if (state !=3D PANTHOR_IRQ_STATE_SUSPENDED && state !=3D PANTHOR_IRQ_STAT= E_SUSPENDING) { \ + /* Only restore the bits that were used and are still enabled */ \ + gpu_write(ptdev, __reg_prefix ## _INT_MASK, \ + gpu_read(ptdev, __reg_prefix ## _INT_MASK) | (mask & pirq->mask)); \ + atomic_set(&pirq->state, PANTHOR_IRQ_STATE_ACTIVE); \ + } \ \ return ret; \ } \ @@ -445,16 +466,17 @@ static inline void panthor_ ## __name ## _irq_suspend= (struct panthor_irq *pirq) { \ pirq->mask =3D 0; \ gpu_write(pirq->ptdev, __reg_prefix ## _INT_MASK, 0); \ + atomic_set(&pirq->state, PANTHOR_IRQ_STATE_SUSPENDING); \ synchronize_irq(pirq->irq); \ - atomic_set(&pirq->suspended, true); \ + atomic_set(&pirq->state, PANTHOR_IRQ_STATE_SUSPENDED); \ } \ \ static inline void panthor_ ## __name ## _irq_resume(struct panthor_irq *p= irq, u32 mask) \ { \ - atomic_set(&pirq->suspended, false); \ pirq->mask =3D mask; \ - gpu_write(pirq->ptdev, __reg_prefix ## _INT_CLEAR, mask); \ - gpu_write(pirq->ptdev, __reg_prefix ## _INT_MASK, mask); \ + atomic_set(&pirq->state, PANTHOR_IRQ_STATE_ACTIVE); \ + gpu_write(pirq->ptdev, __reg_prefix ## _INT_CLEAR, pirq->mask); \ + gpu_write(pirq->ptdev, __reg_prefix ## _INT_MASK, pirq->mask); \ } \ \ static int panthor_request_ ## __name ## _irq(struct panthor_device *ptdev= , \ --=20 2.52.0