From nobody Sun Feb 8 19:40:00 2026 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ED8C34B19F for ; Mon, 12 Jan 2026 09:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768210876; cv=none; b=DXV4rrpAcFwGVCGMscFvw9M76pQmGzDSuAL6g7oGRKeYn/qe2rUfgSRmNefdXCL8T/W6v1TMgTXW6Ce6v6YiJPCNdpcSy4TvZ8WWsLA/WUXQTwFDm0vzm4GOeBgmsfxr3cY3pPwgOspvGNLgJoWd6RASP2g5BBwbedPFyNM0j4c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768210876; c=relaxed/simple; bh=oZlSrKc5HSf8OTgk8Y9zCO1ND/6B7m7anVTBiZTQDCE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NRyUDSd6bL5wrvVBnZxfAMbqBToQuZqAQdjYLMcK2GVPAbyrKJCNJgm7BjHK7M+I6zAGHo2s0n0VwDeCDBKBpPuMsCyj28lNsoUhaCUzqdQYAROQlxqIYtlp8i03mWW2yqMtiMJNfm9FmfZx1l01W9Q10gI7HJPNlMokJ7fVJKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hQaZ/Iy6; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hQaZ/Iy6" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-64c893f3a94so8163640a12.0 for ; Mon, 12 Jan 2026 01:41:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768210868; x=1768815668; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J4d7URFdeCPYu3U6zdfTOnUzmMHd/kT6rS033v+6Sa8=; b=hQaZ/Iy6Dl5sfj5+mmauSTFRztpCLtxoD9hULpPz3qNgL+UIDZn0s6bTLSxwvwrPCI 0jrwlx7a5RR7C2JoaztGTEEXwZQHWK/bOtlCYpynYSFBPmVjJ8RAk+6YKv4vR3XZ+5oM pvcm54a+N1khUkf+mo/+Hclh2iz7rZ0zc1aY8XZ4qh157bC1h7eQDpGWE5okbyhVSfP8 ekT9nbeeO3+sHuQ8zydFJrESDxJQrHi39xF5CeuFqvQ3ZEi7CC+7gtV3kcWzKgSrp72W goKlClZGhtK658aZYtCQ4oH412UqPj35jOOWfbs3Kq6v4n4Du0a52rVae884ch6Rmqgj HPZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768210868; x=1768815668; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=J4d7URFdeCPYu3U6zdfTOnUzmMHd/kT6rS033v+6Sa8=; b=VWJm68UkQc8drlGmKPzhArE7lbpz/e2P1qbSFrsi9n5kCnMpt2lys4WE2kfKWXlYcf Rnj0/M1a6NU71LLUQ/hA6T6a1Xs02ziwSEa3p4C+1uA4sLJrfcUrPVyfcCi8exmv2C9U 1+O3QHVBVLcBY6uBdzPbe8aHSb0czsOmgLOSHu0cjuZgywJthuGfm/4OPpW0t66IizUP vPunq64lR6vR2EgkoM9m1n4P4+L3RFYvcPgsz1uEtSxwW4bHCkEVjcaBsuIwAS9dVBTO cqv0fqw/Of0OSLnHZudl01BtBP5PPY8IgapjbiO/emqHl4BbEM8Q68cw+znFn9uONyVJ ltFw== X-Forwarded-Encrypted: i=1; AJvYcCUw6f7l9YoLM9C9iFzyGuyjRKONJpIs3ew8k0lS16BsZ7g+q29VAuRMdFbzsIxZc5HHZ3Ci83nEFXrBjmU=@vger.kernel.org X-Gm-Message-State: AOJu0YwS79lNHlmXq8o1AK4Zsbml6nY+W+7dbtGg0O9PKB9ZyXQPQLhF nVbgG/xaNio16qTg5ziKgEUHPHI6HYItaWkZEH1flZIPyNH6wgKlXMUy X-Gm-Gg: AY/fxX4eLaEcPFUpwdO0TbM4WXEsEjWSYIvve3QLifpe2rUwsoO/8U/tvuJuuYeOKxx Q9br1o4Dvs6AuOnhycc0De1hk3PUZylKwb6PFTg5usAgAHl85CjLBM0pYF+lpnY3IH6K3oHIP8E pAhpeytmwJ+/hJvOdIEXvoyss3O3Cy9AWNjQo5aCldlLaJUIaOjLLVHToT003lHRbZB0O+8KsOv LHSJWYw4IBAk7e3rZG3buRn+fGuri3iEcPFcKxDKbdCodGVl+wVxMOL9rzB9x9dYCYfzP3S4yTw WxjvMiSqutjtLZR7ECyQvac2lDA2tWHXHZoI86oJOoilV40x4zf2qDRZ06u9Fvsr/+J8thQaZQ8 eK0IO7c8hyAlMnw8QMoQXIGeEvxIKrkLgZak4Pe2ILBXvUgwwlW+HFrsZbqrwDwXEHK2JZBCswm GKiYtDVMj0CrE28RQqgPTsGrn9 X-Google-Smtp-Source: AGHT+IE7196ejl7yFzSqk+olKRAYnC2uk75Y2D533VodUBlVEhIaeYQfNJUulVJjCL8VsWOCEwYsAA== X-Received: by 2002:a17:907:d64a:b0:b80:48f6:9cc6 with SMTP id a640c23a62f3a-b844500df90mr1559904666b.32.1768210867980; Mon, 12 Jan 2026 01:41:07 -0800 (PST) Received: from [192.168.1.243] ([143.58.192.3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b870bcd342bsm410828766b.56.2026.01.12.01.41.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 01:41:07 -0800 (PST) From: Andre Carvalho Date: Mon, 12 Jan 2026 09:40:54 +0000 Subject: [PATCH net-next v10 3/7] netconsole: add STATE_DEACTIVATED to track targets disabled by low level Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260112-netcons-retrigger-v10-3-d82ebfc2503e@gmail.com> References: <20260112-netcons-retrigger-v10-0-d82ebfc2503e@gmail.com> In-Reply-To: <20260112-netcons-retrigger-v10-0-d82ebfc2503e@gmail.com> To: Breno Leitao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Andre Carvalho X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768210863; l=2409; i=asantostc@gmail.com; s=20250807; h=from:subject:message-id; bh=Bc0ee9DYK1oiSRrahxYGeDv2Y4gYudwUsG3FQq7nt2Y=; b=dlucml7NE6QKov7VCIJKrbKl4nY7P7ygZT0UdSvjY2SvFgYTxYH1Iq9sObh2A0E1ovc8n6xTw wvyp5z1BJvmCxctm7jBsrYjDXJcEvmZxerynakzqwbN8JVznlQkw3AH X-Developer-Key: i=asantostc@gmail.com; a=ed25519; pk=eWre+RwFHCxkiaQrZLsjC67mZ/pZnzSM/f7/+yFXY4Q= From: Breno Leitao When the low level interface brings a netconsole target down, record this using a new STATE_DEACTIVATED state. This allows netconsole to distinguish between targets explicitly disabled by users and those deactivated due to interface state changes. It also enables automatic recovery and re-enabling of targets if the underlying low-level interfaces come back online. From a code perspective, anything that is not STATE_ENABLED is disabled. Devices (de)enslaving are marked STATE_DISABLED to prevent automatically resuming as enslaved interfaces cannot have netconsole enabled. Signed-off-by: Breno Leitao Signed-off-by: Andre Carvalho --- drivers/net/netconsole.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index b21ecea60d52..7a1e5559fc0d 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -122,6 +122,7 @@ enum sysdata_feature { enum target_state { STATE_DISABLED, STATE_ENABLED, + STATE_DEACTIVATED, }; =20 /** @@ -580,6 +581,14 @@ static ssize_t enabled_store(struct config_item *item, if (ret) goto out_unlock; =20 + /* When the user explicitly enables or disables a target that is + * currently deactivated, reset its state to disabled. The DEACTIVATED + * state only tracks interface-driven deactivation and should _not_ + * persist when the user manually changes the target's enabled state. + */ + if (nt->state =3D=3D STATE_DEACTIVATED) + nt->state =3D STATE_DISABLED; + ret =3D -EINVAL; current_enabled =3D nt->state =3D=3D STATE_ENABLED; if (enabled =3D=3D current_enabled) { @@ -1445,10 +1454,19 @@ static int netconsole_netdev_event(struct notifier_= block *this, break; case NETDEV_RELEASE: case NETDEV_JOIN: - case NETDEV_UNREGISTER: + /* transition target to DISABLED instead of + * DEACTIVATED when (de)enslaving devices as + * their targets should not be automatically + * resumed when the interface is brought up. + */ nt->state =3D STATE_DISABLED; list_move(&nt->list, &target_cleanup_list); stopped =3D true; + break; + case NETDEV_UNREGISTER: + nt->state =3D STATE_DEACTIVATED; + list_move(&nt->list, &target_cleanup_list); + stopped =3D true; } } netconsole_target_put(nt); --=20 2.52.0