From nobody Mon Feb 9 01:29:57 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E95BC352921 for ; Sun, 11 Jan 2026 18:37:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156623; cv=none; b=syBUdhvBpWvF2ekV0x/s4TUsX6Wyr+4bfI+FbEZQIKKYGJDHrhIQu1lkOSTsm4m9lbOk/X1kOfGDV9MmE2iY1a66AhkcX+DL2friyPqhSKppCeiLvjj8xHbLRiYjznI6AChTScujLrHFX93xLz3pZUxdRrB902Q4xfjM9PFA8mA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156623; c=relaxed/simple; bh=kEwZiPUFrXyVTfLQuCVH7NR6bHJ5ULh6nxDKa5Y/yGg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QXCDLYC68ovBlSrKaDvbg7scY0Pqmbq4nP7gA5s84cUKcdMpkR8ZXOY2Dv3BWxG/BdMGK+6Yzs+ZCfIuOoenjPjnRzJIn/jgWmBZT0ODBF6Eu7cwaf74fUcr9gCh1YIR3Tk/tv8xJR0qY9/yjw4X4hTdbspUAzjS301PoXlm3mg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V3qLBATV; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V3qLBATV" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a0f3f74587so43666015ad.2 for ; Sun, 11 Jan 2026 10:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768156620; x=1768761420; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LQZSC/Rrg9Yg1EfbvaC7JoYAicHnfitzRP5DtHj1big=; b=V3qLBATVF4fdzy2hjnDJNesOVw5dvn588wKZmhwvIVORK0svTOAvnNJk2Hx1f20MYD XJV2dT2WUznPfehSraMZBYn1lydZnCZXHFicOKeayoX6601pA0obFkOb5aWDHTBWJxhk YeGZ28UM9Pf/lcWZMoTDpg4KpeiawTqPzmJOBsRVKqmCJ9WqSAzR1DdlYhH6p8iwMw2g k4+qUJnSTR3T54BKKboLW6lOQ3EvUZol4uGQp58pGGPvQef2c9xlSe71agisWZvAzaLa yl1/SicYRJA4IH0K9A5XTtutyp5+wCdHSYl7N1C9gOWUXRnfKhYmoEXCs05o2NyNcZ2K GRzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768156620; x=1768761420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LQZSC/Rrg9Yg1EfbvaC7JoYAicHnfitzRP5DtHj1big=; b=bVoi1fy/xBx5/CGJBCjY3dbbvS3zVNZhPiQpQSEw/j9glZ0GLGO5FdmB1XGWuxRIbb b8WvbTlhpaD7TtRz7LUt1wXIHFdcilUfsPSnTAH5TzHOXId/nt32AymF7PSASC6BZSue v5REQM9E5uS1AbjRd9AFgcs5ULVoZ8dcbJHSUVhMtzGj6z1ir+zPoM/6uGHWy47dGRBP 8YPf3kZ8PVrT05k/mhYq/ZE2zTv/8BOBkT1MYw5A3rRYheN+4UTTT1wY9qOBIUlUHqcD MQnV/UUV4wExi1TD9iud6MUyPCHYzjYDfktRpc+D/MZ9N0VO+J47Td4c7nLN6ocAGXLg Wl7A== X-Forwarded-Encrypted: i=1; AJvYcCXfzyxXgmo8BBXAUNSRxks3sbi7iKnBfBO+2FSofEoJ8HExOwuC7PUqHB7SCFGvYw1BOeuPpQEo1gFif6M=@vger.kernel.org X-Gm-Message-State: AOJu0YztY/26TdaP+3AH5uhMhrvMGd3IbU281zLbdhI6i5hBIqYWg0uE hE0j275JrK+NWS9KQ3ZAGmpkRZaz4b55FsVMxaDD+cxM99yCwc7hPVtbmfDVjBqooC0= X-Gm-Gg: AY/fxX6UBy/lYibgBeBkV3PqPXNAR/dpDYZ2GybKjb5+ENozqPEFZZtlE4poRFvxT1c /a8ASxqKiOewjneEAvkHMUDSD+3DnZP5ptaan4YxI4+rVgy6hczsBHQY2YglH0CeiScg08XhsoB u+EVrAdLxY43aopRFPxzYC4TTRQ5Kra27SU/03ikKKLcomzezm0IfrKWqMhyA05QcypLAzz5B6i Mld2xf68DJfeIJJKE/qqggjgD9+lbTzwkSYdNlZHm437AfQeGpl67+2MgB9T8IaipYwDerWs+C4 UYog5HxLeu5exEaS2PBieaaeza6qwQio12OkN20Z2ioTzXjYIA69Lyf40cwqgZMt5wcJjRvvl/d jY1CeSe2OCHjGn5NRhT3HYHG1M9ixQHgoUk0vuNfCf5jyQDERwtqiG/cmPAgaS3ejkiHt5d4fpH 6Z4V3AtEbhyN0WlQOQsSgyxbQE X-Google-Smtp-Source: AGHT+IEGqCaGQ14ckEcZ5sTiLa0Zi3xvfCRfTt9I/wBNx1nKepif/5yc5g5wiDHSrnuQN/y1xcnzlQ== X-Received: by 2002:a17:902:c945:b0:2a3:6b54:5d42 with SMTP id d9443c01a7336-2a3ee5072a4mr162188095ad.59.1768156620151; Sun, 11 Jan 2026 10:37:00 -0800 (PST) Received: from snowman.bbrouter ([43.241.121.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd2953sm152220415ad.86.2026.01.11.10.36.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 10:36:59 -0800 (PST) From: Khushal Chitturi To: Greg Kroah-Hartman Cc: Michael Straube , Hans de Goede , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 3/9] staging: rtl8723bs: simplify boolean expressions Date: Mon, 12 Jan 2026 00:06:24 +0530 Message-ID: <20260111183630.12816-4-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260111183630.12816-1-khushalchitturi@gmail.com> References: <20260111183630.12816-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify boolean expressions in rtw_xmit.c to comply with the kernel coding style Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 36 +++++++++++------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index cf7d92a85d6c..b0a16130a883 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -380,7 +380,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * } else { while (true) { /* IOT action */ - if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && (pattrib= ->ampdu_en =3D=3D true) && + if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && (pattrib= ->ampdu_en) && (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_)) { pattrib->vcs_mode =3D CTS_TO_SELF; break; @@ -416,7 +416,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * /* to do list: check MIMO power save condition. */ =20 /* check AMPDU aggregation for TXOP */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -478,10 +478,10 @@ static s32 update_attrib_sec_info(struct adapter *pad= apter, struct pkt_attrib *p memset(pattrib->dot11tkiptxmickey.skey, 0, 16); pattrib->mac_id =3D psta->mac_id; =20 - if (psta->ieee8021x_blocked =3D=3D true) { + if (psta->ieee8021x_blocked) { pattrib->encrypt =3D 0; =20 - if ((pattrib->ether_type !=3D 0x888e) && (check_fwstate(pmlmepriv, WIFI_= MP_STATE) =3D=3D false)) { + if ((pattrib->ether_type !=3D 0x888e) && !(check_fwstate(pmlmepriv, WIFI= _MP_STATE))) { res =3D _FAIL; goto exit; } @@ -635,8 +635,8 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p memcpy(pattrib->dst, ðerhdr.h_dest, ETH_ALEN); memcpy(pattrib->src, ðerhdr.h_source, ETH_ALEN); =20 - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) || + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { memcpy(pattrib->ra, pattrib->dst, ETH_ALEN); memcpy(pattrib->ta, pattrib->src, ETH_ALEN); } else if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { @@ -700,7 +700,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (!psta) { /* if we cannot get psta =3D> drop the pkt */ res =3D _FAIL; goto exit; - } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) && (!(p= sta->state & _FW_LINKED))) { + } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE)) && (!(psta->state &= _FW_LINKED))) { res =3D _FAIL; goto exit; } @@ -872,7 +872,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr SetFrameSubType(fctrl, pattrib->subtype); =20 if (pattrib->subtype & WIFI_DATA_TYPE) { - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { /* to_ds =3D 1, fr_ds =3D 0; */ =20 { @@ -886,7 +886,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pqospriv->qos_option) qos_option =3D true; - } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { /* to_ds =3D 0, fr_ds =3D 1; */ SetFrDs(fctrl); memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); @@ -895,8 +895,8 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pattrib->qos_en) qos_option =3D true; - } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) || + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); memcpy(pwlanhdr->addr2, pattrib->src, ETH_ALEN); memcpy(pwlanhdr->addr3, get_bssid(pmlmepriv), ETH_ALEN); @@ -954,7 +954,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr pattrib->ampdu_en =3D true; =20 /* re-check if enable ampdu by BA_starting_seqctrl */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { u16 tx_seq; =20 tx_seq =3D psta->BA_starting_seqctrl[pattrib->priority & 0x0f]; @@ -1105,7 +1105,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 frg_inx++; =20 - if (bmcst || (rtw_endofpktfile(&pktfile) =3D=3D true)) { + if (bmcst || (rtw_endofpktfile(&pktfile))) { pattrib->nr_frags =3D frg_inx; =20 pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + ((pattrib= ->nr_frags =3D=3D 1) ? llc_sz : 0) + @@ -1129,7 +1129,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 xmitframe_swencrypt(padapter, pxmitframe); =20 - if (bmcst =3D=3D false) + if (!bmcst) update_attrib_vcs_info(padapter, pxmitframe); else pattrib->vcs_mode =3D NONE_VCS; @@ -1965,14 +1965,14 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_bu= ff **ppkt) do_queue_select(padapter, &pxmitframe->attrib); =20 spin_lock_bh(&pxmitpriv->lock); - if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe) =3D=3D true)= { + if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe)) { spin_unlock_bh(&pxmitpriv->lock); return 1; } spin_unlock_bh(&pxmitpriv->lock); =20 /* pre_xmitframe */ - if (rtw_hal_xmit(padapter, pxmitframe) =3D=3D false) + if (rtw_hal_xmit(padapter, pxmitframe)) return 1; =20 return 0; @@ -2016,7 +2016,7 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x signed int bmcst =3D is_multicast_ether_addr(pattrib->ra); bool update_tim =3D false; =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D false) + if (!check_fwstate(pmlmepriv, WIFI_AP_STATE)) return ret; psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta !=3D psta) @@ -2141,7 +2141,7 @@ static void dequeue_xmitframes_to_sleeping_queue(stru= ct adapter *padapter, struc =20 ret =3D xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe); =20 - if (true =3D=3D ret) { + if (ret) { ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8= *)(&ac_index)); =20 ptxservq->qcnt--; --=20 2.52.0