From nobody Sun Feb 8 02:56:12 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BEE422F755 for ; Sun, 11 Jan 2026 18:36:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156610; cv=none; b=OfuldidwWX3+u9UlvFtTJEyud+rqwUruk5iFqpi4ceiPrBk9JdPXwUfy2ULz0++J5wbRCet20xJYLTq8xH6EdkpOK+9wt2BZDFiyAMB4DJML69kqktbmC9f/pSFBTgwpPEuW0S8IsFPQS8cyUuhBMNI0i+0+c3qK6G4VqRYUl4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156610; c=relaxed/simple; bh=d6C/dia0qGxeSDOXk6Hxgv9NMkIPmeQmTrn7QidYSrQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i9dJcf9yOXvKYMkjCksdMCbBVZJuNneAMmETikqQuBxZmXr+ksA9eCEdYQX+85TjdEp7vxJ72B61N+6/6it2lEroaFVB7FwB+Crv9pP7JhEhb3zgFzCF/qEAtTsRhtNLgglDxMkcfcYaKUDvIjNrTvdBE27mGEXapZnpVxMzmHI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ch3Zta0g; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ch3Zta0g" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c227206e6dcso3745079a12.2 for ; Sun, 11 Jan 2026 10:36:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768156609; x=1768761409; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I8mkfx/tVoOUsfABu5Q990K51/MRrsUFb3XWiRKeDdI=; b=ch3Zta0gqy62svxJKGUzYY5RAPBUmtM+7/Kw46jYCfKN82sARgz0kj4oQQ+GzZ2Utn 4PM141F4VRQBqSm6maPLtpChx9odnqIqOe6l5tbVZeHt1TEGOUbnJtjfuTwybgVb93CZ pJSWnqWXDbjejlpJgRnheD1OXxhj1Rx54i3zWPtjXVMFdmfoGYcNJseMNkbRB33MsFkE oQuvtRAzdbRegE5ONE27yBpnxE1h16Y+snPgUUUnv4ziQdMI25JwVUi6tB/Uv4g6NkjR T8+XcprrFsC7SzuFbeSG2qNMFf6acMZpoW/BWp4cUFBIt2JhP8abDg0ps9BPkjdY2J5d QPhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768156609; x=1768761409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I8mkfx/tVoOUsfABu5Q990K51/MRrsUFb3XWiRKeDdI=; b=iG63tKIDt7Rcrj/QaBa/+rqvk9Fak9+fusLKpG+PiNncGSU2ZnQlDvbTEdmUNX3zQl bWlkPevd4JzcizJPTDpAjQFbFsi+8Kq3CgJRFODMQYyQfLnBSutXqOCT4nQLpK86z1NY cU29fQYyZhW0DH7idoXOYMmzDdXaZJuCOXh1LaewSf25hf4TqZi56dKiHvbVelUGNXUO 8TPr7+I9gb7+8xZ9HSL7Gy+qUAtTBb9J8mWX0t0RvtuKSOea14+agvWkVnY4c/U297WO GBBriyTWZVEbP/NQ4onC/qvRXPe4e+lPN2dzKAhAxQxJsHihefX1bHILC/CDwYFxNi9v xstQ== X-Forwarded-Encrypted: i=1; AJvYcCWdzN71cbTQ0/Lh2jaSnmwKPMrxIZP5XJUJwFGCsgmqwDqSpEWXrm5rx9ILiJPq7XqR2Jd5UjvlcxslqOA=@vger.kernel.org X-Gm-Message-State: AOJu0YwYc8Ug30sh6418K21PE/7n6O8YOMH+ikIws//icdxU0K5KZWdc Yk/q8FptQOIk0bH6MuVBuB9T9sJe048L5GnjB3c1E/VnipyzPC8soWT1 X-Gm-Gg: AY/fxX5I0vLE1LvaSxfS9Qq84zZRBUqVCq48pnCaAQJfjuVgLvywYbpIKuOR5KJiQyp 00AGtmqQeaIjQmnHMnWiUIG2jxbMi+4WqBGBVOuHCZXz/ulg9e5SPb508lgeJ5XkXIDc+1c5N2H hMzuJYdmnAWGcOr0UiMQkQbKXBizKdKrO1asOP0JdQ+k4njTvCFNSA7iNQvcTbwfbiLKEzsDGy3 +ferroNyx3dhLSWlc+1iyQrzMf8eOQ0uCvceC/mzAL56sfbAD5rWWrFH5vnmxEYCqcyfw1IkdBd OlSvlBIFaiUmggW176JDgCOwMgP4apbl5Y5DFF/T2AURRLVFSSyc89JCvA2Dzl1CW5EgitnT8IK DVQwf3i/ga3Mo4XAspLdNpfPSWr9JLllUgUKGw/IExpU/25tIcvL/qHdH/QAEonss6nY8HlSStU 1nIVPvTIXZNF0pPW1X4ITk3Igi X-Google-Smtp-Source: AGHT+IHBeaN9Ve7eKGrK9bYR2KOFgKPEBKFQvqQ1eh0w5zA5cxq2BUB4KK9iVsoYYpmZAyW3QMCzRg== X-Received: by 2002:a17:902:c407:b0:2a1:14dd:573 with SMTP id d9443c01a7336-2a3ee429d3amr138295615ad.23.1768156608600; Sun, 11 Jan 2026 10:36:48 -0800 (PST) Received: from snowman.bbrouter ([43.241.121.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd2953sm152220415ad.86.2026.01.11.10.36.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 10:36:48 -0800 (PST) From: Khushal Chitturi To: Greg Kroah-Hartman Cc: Michael Straube , Hans de Goede , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 1/9] staging: rtl8723bs: fix operator and type cast spacing Date: Mon, 12 Jan 2026 00:06:22 +0530 Message-ID: <20260111183630.12816-2-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260111183630.12816-1-khushalchitturi@gmail.com> References: <20260111183630.12816-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix spacing around operators and type casts in rtw_xmit.c to comply with the kernel coding style. Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 76 +++++++++++------------ 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 21690857fd62..b0d7e59e492d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -78,7 +78,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, stru= ct adapter *padapter) } pxmitpriv->pxmit_frame_buf =3D (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv= ->pallocated_frame_buf), 4); =20 - pxframe =3D (struct xmit_frame *) pxmitpriv->pxmit_frame_buf; + pxframe =3D (struct xmit_frame *)pxmitpriv->pxmit_frame_buf; =20 for (i =3D 0; i < NR_XMITFRAME; i++) { INIT_LIST_HEAD(&pxframe->list); @@ -238,7 +238,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->padapter =3D padapter; pxmitbuf->buf_tag =3D XMITBUF_CMD; =20 - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_CMDBUF_SZ+XM= ITBUF_ALIGN_SZ, true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_CMDBUF_SZ + = XMITBUF_ALIGN_SZ, true); if (res =3D=3D _FAIL) { res =3D _FAIL; goto exit; @@ -248,7 +248,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->pend =3D pxmitbuf->pbuf + MAX_CMDBUF_SZ; pxmitbuf->len =3D 0; pxmitbuf->pdata =3D pxmitbuf->ptail =3D pxmitbuf->phead; - pxmitbuf->alloc_sz =3D MAX_CMDBUF_SZ+XMITBUF_ALIGN_SZ; + pxmitbuf->alloc_sz =3D MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ; } } =20 @@ -274,7 +274,7 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) { int i; struct adapter *padapter =3D pxmitpriv->adapter; - struct xmit_frame *pxmitframe =3D (struct xmit_frame *) pxmitpriv->pxmit_= frame_buf; + struct xmit_frame *pxmitframe =3D (struct xmit_frame *)pxmitpriv->pxmit_f= rame_buf; struct xmit_buf *pxmitbuf =3D (struct xmit_buf *)pxmitpriv->pxmitbuf; =20 rtw_hal_free_xmit_priv(padapter); @@ -321,7 +321,7 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) for (i =3D 0; i < CMDBUF_MAX; i++) { pxmitbuf =3D &pxmitpriv->pcmd_xmitbuf[i]; if (pxmitbuf) - rtw_os_xmit_resource_free(padapter, pxmitbuf, MAX_CMDBUF_SZ+XMITBUF_ALI= GN_SZ, true); + rtw_os_xmit_resource_free(padapter, pxmitbuf, MAX_CMDBUF_SZ + XMITBUF_A= LIGN_SZ, true); } =20 rtw_free_hwxmits(padapter); @@ -736,7 +736,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p pattrib->subtype =3D WIFI_DATA_TYPE; pattrib->priority =3D 0; =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE|WIFI_ADHOC_STATE|WIFI_ADHOC_MA= STER_STATE)) { + if (check_fwstate(pmlmepriv, WIFI_AP_STATE | WIFI_ADHOC_STATE | WIFI_ADHO= C_MASTER_STATE)) { if (pattrib->qos_en) set_qos(&pktfile, pattrib); } else { @@ -787,15 +787,15 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr rtw_secmicsetkey(&micdata, &pattrib->dot11tkiptxmickey.skey[0]); } =20 - if (pframe[1]&1) { /* ToDS =3D=3D 1 */ + if (pframe[1] & 1) { /* ToDS =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[16], 6); /* DA */ - if (pframe[1]&2) /* From Ds =3D=3D 1 */ + if (pframe[1] & 2) /* From Ds =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[24], 6); else rtw_secmicappend(&micdata, &pframe[10], 6); } else { /* ToDS =3D=3D 0 */ rtw_secmicappend(&micdata, &pframe[4], 6); /* DA */ - if (pframe[1]&2) /* From Ds =3D=3D 1 */ + if (pframe[1] & 2) /* From Ds =3D=3D 1 */ rtw_secmicappend(&micdata, &pframe[16], 6); else rtw_secmicappend(&micdata, &pframe[10], 6); @@ -810,16 +810,16 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr =20 for (curfragnum =3D 0; curfragnum < pattrib->nr_frags; curfragnum++) { payload =3D (u8 *)round_up((SIZE_PTR)(payload), 4); - payload =3D payload+pattrib->hdrlen+pattrib->iv_len; + payload =3D payload + pattrib->hdrlen + pattrib->iv_len; =20 - if ((curfragnum+1) =3D=3D pattrib->nr_frags) { - length =3D pattrib->last_txcmdsz-pattrib->hdrlen-pattrib->iv_len-((pa= ttrib->bswenc) ? pattrib->icv_len : 0); + if ((curfragnum + 1) =3D=3D pattrib->nr_frags) { + length =3D pattrib->last_txcmdsz - pattrib->hdrlen - pattrib->iv_len = - ((pattrib->bswenc) ? pattrib->icv_len : 0); rtw_secmicappend(&micdata, payload, length); - payload =3D payload+length; + payload =3D payload + length; } else { - length =3D pxmitpriv->frag_len-pattrib->hdrlen-pattrib->iv_len-((patt= rib->bswenc) ? pattrib->icv_len : 0); + length =3D pxmitpriv->frag_len - pattrib->hdrlen - pattrib->iv_len - = ((pattrib->bswenc) ? pattrib->icv_len : 0); rtw_secmicappend(&micdata, payload, length); - payload =3D payload+length+pattrib->icv_len; + payload =3D payload + length + pattrib->icv_len; } } rtw_secgetmic(&micdata, &mic[0]); @@ -1108,7 +1108,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct if (bmcst || (rtw_endofpktfile(&pktfile) =3D=3D true)) { pattrib->nr_frags =3D frg_inx; =20 - pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + ((pattrib= ->nr_frags =3D=3D 1) ? llc_sz:0) + + pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + ((pattrib= ->nr_frags =3D=3D 1) ? llc_sz : 0) + ((pattrib->bswenc) ? pattrib->icv_len : 0) + mem_sz; =20 ClearMFrag(mem_start); @@ -1158,7 +1158,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s mem_start =3D pframe =3D (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET; pwlanhdr =3D (struct ieee80211_hdr *)pframe; =20 - ori_len =3D BIP_AAD_SIZE+pattrib->pktlen; + ori_len =3D BIP_AAD_SIZE + pattrib->pktlen; tmp_buf =3D BIP_AAD =3D rtw_zmalloc(ori_len); subtype =3D GetFrameSubType(pframe); /* bit(7)~bit(2) */ =20 @@ -1211,14 +1211,14 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s /* conscruct AAD, copy address 1 to address 3 */ memcpy(BIP_AAD + 2, &pwlanhdr->addrs, sizeof(pwlanhdr->addrs)); /* copy management fram body */ - memcpy(BIP_AAD+BIP_AAD_SIZE, MGMT_body, frame_body_len); + memcpy(BIP_AAD + BIP_AAD_SIZE, MGMT_body, frame_body_len); /* calculate mic */ if (omac1_aes_128(padapter->securitypriv.dot11wBIPKey[padapter->security= priv.dot11wBIPKeyid].skey - , BIP_AAD, BIP_AAD_SIZE+frame_body_len, mic)) + , BIP_AAD, BIP_AAD_SIZE + frame_body_len, mic)) goto xmitframe_coalesce_fail; =20 /* copy right BIP mic value, total is 128bits, we use the 0~63 bits */ - memcpy(pframe-8, mic, 8); + memcpy(pframe - 8, mic, 8); } else { /* unicast mgmt frame TX */ /* start to encrypt mgmt frame */ if (subtype =3D=3D WIFI_DEAUTH || subtype =3D=3D WIFI_DISASSOC || @@ -1267,9 +1267,9 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s memcpy(pframe, pattrib->iv, pattrib->iv_len); pframe +=3D pattrib->iv_len; /* copy mgmt data portion after CCMP header */ - memcpy(pframe, tmp_buf+pattrib->hdrlen, pattrib->pktlen-pattrib->hdrlen= ); + memcpy(pframe, tmp_buf + pattrib->hdrlen, pattrib->pktlen - pattrib->hd= rlen); /* move pframe to end of mgmt pkt */ - pframe +=3D pattrib->pktlen-pattrib->hdrlen; + pframe +=3D pattrib->pktlen - pattrib->hdrlen; /* add 8 bytes CCMP IV header to length */ pattrib->pktlen +=3D pattrib->iv_len; if ((pattrib->icv_len > 0) && (pattrib->bswenc)) { @@ -1375,7 +1375,7 @@ void rtw_count_tx_stats(struct adapter *padapter, str= uct xmit_frame *pxmitframe, struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; u8 pkt_num =3D 1; =20 - if ((pxmitframe->frame_tag&0x0f) =3D=3D DATA_FRAMETAG) { + if ((pxmitframe->frame_tag & 0x0f) =3D=3D DATA_FRAMETAG) { pkt_num =3D pxmitframe->agg_num; =20 pmlmepriv->LinkDetectInfo.NumTxOkInPeriod +=3D pkt_num; @@ -2070,7 +2070,7 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x =20 spin_lock_bh(&psta->sleep_q.lock); =20 - if (psta->state&WIFI_SLEEP_STATE) { + if (psta->state & WIFI_SLEEP_STATE) { u8 wmmps_ac =3D 0; =20 if (pstapriv->sta_dz_bitmap & BIT(psta->aid)) { @@ -2083,20 +2083,20 @@ signed int xmitframe_enqueue_for_sleeping_sta(struc= t adapter *padapter, struct x switch (pattrib->priority) { case 1: case 2: - wmmps_ac =3D psta->uapsd_bk&BIT(0); + wmmps_ac =3D psta->uapsd_bk & BIT(0); break; case 4: case 5: - wmmps_ac =3D psta->uapsd_vi&BIT(0); + wmmps_ac =3D psta->uapsd_vi & BIT(0); break; case 6: case 7: - wmmps_ac =3D psta->uapsd_vo&BIT(0); + wmmps_ac =3D psta->uapsd_vo & BIT(0); break; case 0: case 3: default: - wmmps_ac =3D psta->uapsd_be&BIT(0); + wmmps_ac =3D psta->uapsd_be & BIT(0); break; } =20 @@ -2214,20 +2214,20 @@ void wakeup_sta_to_xmit(struct adapter *padapter, s= truct sta_info *psta) switch (pxmitframe->attrib.priority) { case 1: case 2: - wmmps_ac =3D psta->uapsd_bk&BIT(1); + wmmps_ac =3D psta->uapsd_bk & BIT(1); break; case 4: case 5: - wmmps_ac =3D psta->uapsd_vi&BIT(1); + wmmps_ac =3D psta->uapsd_vi & BIT(1); break; case 6: case 7: - wmmps_ac =3D psta->uapsd_vo&BIT(1); + wmmps_ac =3D psta->uapsd_vo & BIT(1); break; case 0: case 3: default: - wmmps_ac =3D psta->uapsd_be&BIT(1); + wmmps_ac =3D psta->uapsd_be & BIT(1); break; } =20 @@ -2259,7 +2259,7 @@ void wakeup_sta_to_xmit(struct adapter *padapter, str= uct sta_info *psta) =20 pstapriv->tim_bitmap &=3D ~BIT(psta->aid); =20 - if (psta->state&WIFI_SLEEP_STATE) + if (psta->state & WIFI_SLEEP_STATE) psta->state ^=3D WIFI_SLEEP_STATE; =20 if (psta->state & WIFI_STA_ALIVE_CHK_STATE) { @@ -2274,7 +2274,7 @@ void wakeup_sta_to_xmit(struct adapter *padapter, str= uct sta_info *psta) if (!psta_bmc) goto _exit; =20 - if ((pstapriv->sta_dz_bitmap&0xfffe) =3D=3D 0x0) { /* no any sta in ps mo= de */ + if ((pstapriv->sta_dz_bitmap & 0xfffe) =3D=3D 0x0) { /* no any sta in ps = mode */ xmitframe_phead =3D get_list_head(&psta_bmc->sleep_q); list_for_each_safe(xmitframe_plist, tmp, xmitframe_phead) { pxmitframe =3D list_entry(xmitframe_plist, @@ -2327,20 +2327,20 @@ void xmit_delivery_enabled_frames(struct adapter *p= adapter, struct sta_info *pst switch (pxmitframe->attrib.priority) { case 1: case 2: - wmmps_ac =3D psta->uapsd_bk&BIT(1); + wmmps_ac =3D psta->uapsd_bk & BIT(1); break; case 4: case 5: - wmmps_ac =3D psta->uapsd_vi&BIT(1); + wmmps_ac =3D psta->uapsd_vi & BIT(1); break; case 6: case 7: - wmmps_ac =3D psta->uapsd_vo&BIT(1); + wmmps_ac =3D psta->uapsd_vo & BIT(1); break; case 0: case 3: default: - wmmps_ac =3D psta->uapsd_be&BIT(1); + wmmps_ac =3D psta->uapsd_be & BIT(1); break; } =20 --=20 2.52.0 From nobody Sun Feb 8 02:56:12 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F1B034CFDB for ; Sun, 11 Jan 2026 18:36:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156617; cv=none; b=fOA968LXi28ajf2cJ4j3Gpzze16eUpFmqzBAxeGwVqeieM2IFhSLpqRqH8bfLNz9gYdhJuBUhvgBIokBLCPp6KPOQGl8XVM5N3lmvDPcPCFKNfHWy7k034mS7rbuBCnT8FJXwUk5JCoz3Otoa4a9Jl4i+0eNYMtFJII1bOzW6gw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156617; c=relaxed/simple; bh=RfoR3xMJW+uLzSIimYsSVR3bUQmRz/kr4vXkyIqbvM8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TpddRkvnf+OExojDuA3kJ0iD/9ji/v/lZG9ljak3GQ/1yusUHkeFmXmvPneCI5to/TaIk8R3zjKhmu7IwF/SUDxTzSuIBmlsOitZueIi/FdXElW4W+LqOxCSEDlA06Ir7AMmNLJtP7ODQyKUIpE5BD/Xrz8C8jQwcroNhOIy4vo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OLq+Fa3Q; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OLq+Fa3Q" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2a0bae9aca3so37639195ad.3 for ; Sun, 11 Jan 2026 10:36:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768156615; x=1768761415; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T2bYFsTaRn2xRwgOpRbSAT236NvK7vIan+IE9pLqpfU=; b=OLq+Fa3QdTXWnD3uZCPbfP5cqnn0oJMmU6oHX3RT6z2V/Uopq1ucjD0maO6V6XSE8Z tkG7nAS2PonFbT40urjb330mZRiH+Bjoe3xW2Vn4NfAq/0awnFuz03RR3YJIlqyicTwf ZJNIgBuZyo3BCMDBXqqDf8cJRHeQbcwvmmjS7Uww5Z27sJfzVUMF3/8S1thCe0UBLosQ I7OiENcywTRtvEdEKy/T1k5hMEPBtRvlH+gN9PJs4o3HGREF/9z7PzFsNzmUAN6+WIMd 7wAFkOb2mvOwdPeQMfO87OZL4rab67rH2PLPWdSh6zdM3VXW38rurIASHc2Z/mFYR8xI vVww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768156615; x=1768761415; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T2bYFsTaRn2xRwgOpRbSAT236NvK7vIan+IE9pLqpfU=; b=Kp1eQDR1i/V/qABWg/esTz5r6Jkym9uyPrGnSyJEGn6a9ZznAN0xEWGOTrecJejTEO pZCt7dqv6flZuJypsFcu496PmoAMo+iaN5vC/N+Wpg3uQcmDrjHETZN2j1BtSlTOZObe 7ucwFE9K7m9wBI1aGZuQ1CYvhV1+fv+LJSLvoly97ITWsVrWHeJSK+CH4kH62YgwE08k R//T55X6vMFd/fFR8MVxS0OsYb0lsUV+7PBVT7/xiA+0d9VxwxeE5/4cG/Dh2kVtVH3k PAJ3XRi/YH9g97sn+YvDvNcDqF8TH6JDN2Q7iozSQUQT6LxGcvIQaIAlfAx1tWgkSXXi qc0Q== X-Forwarded-Encrypted: i=1; AJvYcCWUCkP4pPNRLrSzV6xz3N/NdzhJWhJjdAGr73in8CTrKuOHFt4n6H1CRSNkMT2mgJ1GxnOra4uQkIy3DhM=@vger.kernel.org X-Gm-Message-State: AOJu0YySli9PfTEkQ1HSKcO/L3PzOsfrgj8CBKhdfrLFZ2ViXPzPMd8G sfMHft1TWLFW8Vyyr5n2cq04GdYTMAWtUqx2SzDkEh5kFhyljK7kzsqr6JAn4mCEta0= X-Gm-Gg: AY/fxX6R28kBRANJXtmbC7YR36RlJxYD6JRbfxmTfAaXoQS/SCzgEXEUvFgh9iQxqDC flwmcWl5xVJc2h57dD7UsR/F+iCJLd28TTxMquv5fyMbDWJ5ezPRz4VfgtnvAPAoEH17Yq1OpnP zmWPNLMNmXmWBKyoiAvkhb9DVqmT6Pm7gQTlOv/uh9guvhxIXInCG8JJRnWkXbO5gyMzjRcs6DX +Q1TbLL6yVcXCFsgSK925p1ho1tgi80sH3sSFEnu2/9iuOF1enYEGzDthvDC1KtUeo/UyAKo3tX gj8WI9VPHnZNdi7eKVJ6YDwx8E1KrLSby4MrD3UHeA8njO+jVI97Tqe76qIUlir51uqpl846f03 C0KfTVCeiR0V1Lcoz4td5m7KtzdUy8ZxJrYKewtD6A0fFBJkn9twRzVPrcTCQClks2wtzeb0/2p 5zLdGk25aZFPfssuyU7Opb78pj X-Google-Smtp-Source: AGHT+IEDbYtHRruwP0zfxe5VoMray2gU36CUATh2bXwLrTEuDy8sEz8rRVhQFSHTPqf7kqY065ro3A== X-Received: by 2002:a17:903:2ec5:b0:297:f527:a38f with SMTP id d9443c01a7336-2a3ee452d90mr149596415ad.18.1768156614601; Sun, 11 Jan 2026 10:36:54 -0800 (PST) Received: from snowman.bbrouter ([43.241.121.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd2953sm152220415ad.86.2026.01.11.10.36.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 10:36:54 -0800 (PST) From: Khushal Chitturi To: Greg Kroah-Hartman Cc: Michael Straube , Hans de Goede , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 2/9] staging: rtl8723bs: remove empty branches Date: Mon, 12 Jan 2026 00:06:23 +0530 Message-ID: <20260111183630.12816-3-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260111183630.12816-1-khushalchitturi@gmail.com> References: <20260111183630.12816-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove empty else blocks in rtw_xmit.c to improve readability and follow the kernel coding style. Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index b0d7e59e492d..cf7d92a85d6c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1707,8 +1707,6 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, s= truct xmit_frame *pxmitfram queue =3D &pxmitpriv->free_xmit_queue; else if (pxmitframe->ext_tag =3D=3D 1) queue =3D &pxmitpriv->free_xframe_ext_queue; - else { - } =20 spin_lock_bh(&queue->lock); =20 @@ -1999,11 +1997,11 @@ inline bool xmitframe_hiq_filter(struct xmit_frame = *xmitframe) ) allow =3D true; =20 - } else if (registry->hiq_filter =3D=3D RTW_HIQ_FILTER_ALLOW_ALL) + } else if (registry->hiq_filter =3D=3D RTW_HIQ_FILTER_ALLOW_ALL) { allow =3D true; - else if (registry->hiq_filter =3D=3D RTW_HIQ_FILTER_DENY_ALL) { - } else + } else { rtw_warn_on(1); + } =20 return allow; } --=20 2.52.0 From nobody Sun Feb 8 02:56:12 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E95BC352921 for ; Sun, 11 Jan 2026 18:37:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156623; cv=none; b=syBUdhvBpWvF2ekV0x/s4TUsX6Wyr+4bfI+FbEZQIKKYGJDHrhIQu1lkOSTsm4m9lbOk/X1kOfGDV9MmE2iY1a66AhkcX+DL2friyPqhSKppCeiLvjj8xHbLRiYjznI6AChTScujLrHFX93xLz3pZUxdRrB902Q4xfjM9PFA8mA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156623; c=relaxed/simple; bh=kEwZiPUFrXyVTfLQuCVH7NR6bHJ5ULh6nxDKa5Y/yGg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QXCDLYC68ovBlSrKaDvbg7scY0Pqmbq4nP7gA5s84cUKcdMpkR8ZXOY2Dv3BWxG/BdMGK+6Yzs+ZCfIuOoenjPjnRzJIn/jgWmBZT0ODBF6Eu7cwaf74fUcr9gCh1YIR3Tk/tv8xJR0qY9/yjw4X4hTdbspUAzjS301PoXlm3mg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V3qLBATV; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V3qLBATV" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a0f3f74587so43666015ad.2 for ; Sun, 11 Jan 2026 10:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768156620; x=1768761420; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LQZSC/Rrg9Yg1EfbvaC7JoYAicHnfitzRP5DtHj1big=; b=V3qLBATVF4fdzy2hjnDJNesOVw5dvn588wKZmhwvIVORK0svTOAvnNJk2Hx1f20MYD XJV2dT2WUznPfehSraMZBYn1lydZnCZXHFicOKeayoX6601pA0obFkOb5aWDHTBWJxhk YeGZ28UM9Pf/lcWZMoTDpg4KpeiawTqPzmJOBsRVKqmCJ9WqSAzR1DdlYhH6p8iwMw2g k4+qUJnSTR3T54BKKboLW6lOQ3EvUZol4uGQp58pGGPvQef2c9xlSe71agisWZvAzaLa yl1/SicYRJA4IH0K9A5XTtutyp5+wCdHSYl7N1C9gOWUXRnfKhYmoEXCs05o2NyNcZ2K GRzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768156620; x=1768761420; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LQZSC/Rrg9Yg1EfbvaC7JoYAicHnfitzRP5DtHj1big=; b=bVoi1fy/xBx5/CGJBCjY3dbbvS3zVNZhPiQpQSEw/j9glZ0GLGO5FdmB1XGWuxRIbb b8WvbTlhpaD7TtRz7LUt1wXIHFdcilUfsPSnTAH5TzHOXId/nt32AymF7PSASC6BZSue v5REQM9E5uS1AbjRd9AFgcs5ULVoZ8dcbJHSUVhMtzGj6z1ir+zPoM/6uGHWy47dGRBP 8YPf3kZ8PVrT05k/mhYq/ZE2zTv/8BOBkT1MYw5A3rRYheN+4UTTT1wY9qOBIUlUHqcD MQnV/UUV4wExi1TD9iud6MUyPCHYzjYDfktRpc+D/MZ9N0VO+J47Td4c7nLN6ocAGXLg Wl7A== X-Forwarded-Encrypted: i=1; AJvYcCXfzyxXgmo8BBXAUNSRxks3sbi7iKnBfBO+2FSofEoJ8HExOwuC7PUqHB7SCFGvYw1BOeuPpQEo1gFif6M=@vger.kernel.org X-Gm-Message-State: AOJu0YztY/26TdaP+3AH5uhMhrvMGd3IbU281zLbdhI6i5hBIqYWg0uE hE0j275JrK+NWS9KQ3ZAGmpkRZaz4b55FsVMxaDD+cxM99yCwc7hPVtbmfDVjBqooC0= X-Gm-Gg: AY/fxX6UBy/lYibgBeBkV3PqPXNAR/dpDYZ2GybKjb5+ENozqPEFZZtlE4poRFvxT1c /a8ASxqKiOewjneEAvkHMUDSD+3DnZP5ptaan4YxI4+rVgy6hczsBHQY2YglH0CeiScg08XhsoB u+EVrAdLxY43aopRFPxzYC4TTRQ5Kra27SU/03ikKKLcomzezm0IfrKWqMhyA05QcypLAzz5B6i Mld2xf68DJfeIJJKE/qqggjgD9+lbTzwkSYdNlZHm437AfQeGpl67+2MgB9T8IaipYwDerWs+C4 UYog5HxLeu5exEaS2PBieaaeza6qwQio12OkN20Z2ioTzXjYIA69Lyf40cwqgZMt5wcJjRvvl/d jY1CeSe2OCHjGn5NRhT3HYHG1M9ixQHgoUk0vuNfCf5jyQDERwtqiG/cmPAgaS3ejkiHt5d4fpH 6Z4V3AtEbhyN0WlQOQsSgyxbQE X-Google-Smtp-Source: AGHT+IEGqCaGQ14ckEcZ5sTiLa0Zi3xvfCRfTt9I/wBNx1nKepif/5yc5g5wiDHSrnuQN/y1xcnzlQ== X-Received: by 2002:a17:902:c945:b0:2a3:6b54:5d42 with SMTP id d9443c01a7336-2a3ee5072a4mr162188095ad.59.1768156620151; Sun, 11 Jan 2026 10:37:00 -0800 (PST) Received: from snowman.bbrouter ([43.241.121.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd2953sm152220415ad.86.2026.01.11.10.36.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 10:36:59 -0800 (PST) From: Khushal Chitturi To: Greg Kroah-Hartman Cc: Michael Straube , Hans de Goede , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 3/9] staging: rtl8723bs: simplify boolean expressions Date: Mon, 12 Jan 2026 00:06:24 +0530 Message-ID: <20260111183630.12816-4-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260111183630.12816-1-khushalchitturi@gmail.com> References: <20260111183630.12816-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify boolean expressions in rtw_xmit.c to comply with the kernel coding style Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 36 +++++++++++------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index cf7d92a85d6c..b0a16130a883 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -380,7 +380,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * } else { while (true) { /* IOT action */ - if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && (pattrib= ->ampdu_en =3D=3D true) && + if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && (pattrib= ->ampdu_en) && (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_)) { pattrib->vcs_mode =3D CTS_TO_SELF; break; @@ -416,7 +416,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * /* to do list: check MIMO power save condition. */ =20 /* check AMPDU aggregation for TXOP */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -478,10 +478,10 @@ static s32 update_attrib_sec_info(struct adapter *pad= apter, struct pkt_attrib *p memset(pattrib->dot11tkiptxmickey.skey, 0, 16); pattrib->mac_id =3D psta->mac_id; =20 - if (psta->ieee8021x_blocked =3D=3D true) { + if (psta->ieee8021x_blocked) { pattrib->encrypt =3D 0; =20 - if ((pattrib->ether_type !=3D 0x888e) && (check_fwstate(pmlmepriv, WIFI_= MP_STATE) =3D=3D false)) { + if ((pattrib->ether_type !=3D 0x888e) && !(check_fwstate(pmlmepriv, WIFI= _MP_STATE))) { res =3D _FAIL; goto exit; } @@ -635,8 +635,8 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p memcpy(pattrib->dst, ðerhdr.h_dest, ETH_ALEN); memcpy(pattrib->src, ðerhdr.h_source, ETH_ALEN); =20 - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) || + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { memcpy(pattrib->ra, pattrib->dst, ETH_ALEN); memcpy(pattrib->ta, pattrib->src, ETH_ALEN); } else if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { @@ -700,7 +700,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (!psta) { /* if we cannot get psta =3D> drop the pkt */ res =3D _FAIL; goto exit; - } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) && (!(p= sta->state & _FW_LINKED))) { + } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE)) && (!(psta->state &= _FW_LINKED))) { res =3D _FAIL; goto exit; } @@ -872,7 +872,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr SetFrameSubType(fctrl, pattrib->subtype); =20 if (pattrib->subtype & WIFI_DATA_TYPE) { - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { /* to_ds =3D 1, fr_ds =3D 0; */ =20 { @@ -886,7 +886,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pqospriv->qos_option) qos_option =3D true; - } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) { + } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { /* to_ds =3D 0, fr_ds =3D 1; */ SetFrDs(fctrl); memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); @@ -895,8 +895,8 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 if (pattrib->qos_en) qos_option =3D true; - } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true)) { + } else if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) || + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); memcpy(pwlanhdr->addr2, pattrib->src, ETH_ALEN); memcpy(pwlanhdr->addr3, get_bssid(pmlmepriv), ETH_ALEN); @@ -954,7 +954,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr pattrib->ampdu_en =3D true; =20 /* re-check if enable ampdu by BA_starting_seqctrl */ - if (pattrib->ampdu_en =3D=3D true) { + if (pattrib->ampdu_en) { u16 tx_seq; =20 tx_seq =3D psta->BA_starting_seqctrl[pattrib->priority & 0x0f]; @@ -1105,7 +1105,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 frg_inx++; =20 - if (bmcst || (rtw_endofpktfile(&pktfile) =3D=3D true)) { + if (bmcst || (rtw_endofpktfile(&pktfile))) { pattrib->nr_frags =3D frg_inx; =20 pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + ((pattrib= ->nr_frags =3D=3D 1) ? llc_sz : 0) + @@ -1129,7 +1129,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 xmitframe_swencrypt(padapter, pxmitframe); =20 - if (bmcst =3D=3D false) + if (!bmcst) update_attrib_vcs_info(padapter, pxmitframe); else pattrib->vcs_mode =3D NONE_VCS; @@ -1965,14 +1965,14 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_bu= ff **ppkt) do_queue_select(padapter, &pxmitframe->attrib); =20 spin_lock_bh(&pxmitpriv->lock); - if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe) =3D=3D true)= { + if (xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe)) { spin_unlock_bh(&pxmitpriv->lock); return 1; } spin_unlock_bh(&pxmitpriv->lock); =20 /* pre_xmitframe */ - if (rtw_hal_xmit(padapter, pxmitframe) =3D=3D false) + if (rtw_hal_xmit(padapter, pxmitframe)) return 1; =20 return 0; @@ -2016,7 +2016,7 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x signed int bmcst =3D is_multicast_ether_addr(pattrib->ra); bool update_tim =3D false; =20 - if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D false) + if (!check_fwstate(pmlmepriv, WIFI_AP_STATE)) return ret; psta =3D rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta !=3D psta) @@ -2141,7 +2141,7 @@ static void dequeue_xmitframes_to_sleeping_queue(stru= ct adapter *padapter, struc =20 ret =3D xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe); =20 - if (true =3D=3D ret) { + if (ret) { ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8= *)(&ac_index)); =20 ptxservq->qcnt--; --=20 2.52.0 From nobody Sun Feb 8 02:56:12 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A776352923 for ; Sun, 11 Jan 2026 18:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156628; cv=none; b=muTiEJ8MeyNBBzC7XBAO+YRpsnS9RrurOrbW1uieBs0vZ+LFOYNGUHdQ+pHE9JS6EQxBtmyLiPFnuEwTwtcJ/o9Pe4sVoOis3RbhdZJ58RgmlN6IC15731Ko3T9fPCDLKbqvEkHG+BZKIo79H7Picgj7kAG5AIfR1oWq4OfXZQM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156628; c=relaxed/simple; bh=WiDfx2+xHVXgQ1jHU8NIPBmhoM0mVs5YH/1n60lx/t4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gmtx5w+T9o0T80ZZZjdUK+HYiFJKBkvCzPM492zC6suBAx/sk8UCtkmqlO7ohn79mfJ2FN5eeZ3DDWjuLrkQAXS777y/DaoUJojuR/4/7HSDp78CVwSpMbeZWNTQsb7oIeYtLu4LE7ap2BGupar9Q9bfxIDpaEa5G54ICsbt4Rw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ba9rYIA9; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ba9rYIA9" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2a0a95200e8so32721795ad.0 for ; Sun, 11 Jan 2026 10:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768156626; x=1768761426; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EG9bdI7JKr/mXXkYZf2TaV7kk43PmvfkD2O46Op3A/o=; b=ba9rYIA9s1LEq8KjXLb9BfKzsO0SYtAo9mg6lZZ7c8DTwRZE2uRVfh6srEIdHaDNif oowPaiEVKzbFrhWliqQNUv0PIwQjZINuulyzu74l1D7ujA+y+HyM2rxzr0k/51uoE6/H SioVIb/Zdt+G0OQAULNrXjDi1U5v9yjUq07GaC/lWsLBdmRglwX6sbE5QtMY5SZfqiVr DgwQ/ps7gTcBlYNbBV/24j91YaiLjcIDHL0R1J+y8/pw47wjMq4ocpvGcVu1DbV3M08B 1TZAQi1SLd0g+hBMUKqutPlU56LnuVcw6dDWUrlyzJ39MA3NFWBEidvKdU0LD2iKUbf2 5QRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768156626; x=1768761426; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EG9bdI7JKr/mXXkYZf2TaV7kk43PmvfkD2O46Op3A/o=; b=RRHGCqDBHUbLrXOKE4tf+2RmELgpqR4JhE2hUSHUIxNtaw/0M60PbKtUv8NBbHZksM EVdFx6x9flldXPgNOmHrO+PNpDTsMANNS1F+SrJaAFRATY6lAvZKYkeN+zEDMVCZuJ4z m1e3q6lRoVscEJ2cRkk4Vlne1ntptCgAe2+6wr9flUOEZChJblJyF8Yur8cuLL/5pW4N CvthjXZ4dSeb9DhJ9WiT5nHF+dKLJHdcl6G/JP9wOwuNaVqBohay6jiDGF1lm1ytN26a ZAip2CjHjnitQdrBQ/4LV3zhfCUVyuDwQnq98ImW2Q3aYhrDS78Om6zG1szGL8tSDN+A bTmg== X-Forwarded-Encrypted: i=1; AJvYcCUSsmBJ+4p/aCy160iwS6xtn+XZ8eE8xLQLdUY45UpMMoICe9ZF55x6FzHPXVo8LprQTpUP/SXDDtbxMaY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/vfQgbj7EM3XUimfAvtEMdwJAm95LZfXrdpWtKz7onDSRnNmS mEGSedL9EfzeRUiia3zOwbgBH99UglQm+ALqWYKJgkp9stFsNm3Z+1zv X-Gm-Gg: AY/fxX5KaDdZoPT5sWCfuqkiRqTXTZUpZD0UGK+va3nSumfQrUf9RlP1/8/nlNqUtpS cw22t+Nqb8dzGOekLCSo1wTUBLZjSBYvvziCeZvvK/Exht+410pik35N6aYO/AT9jtplkl7uJHe IJpuBXQ8W6Ohm2GU9CC3Uam13vSkQN+E8wGDslOjsn8HH/AIOEQWsltSlps7rqC5r3isJ2TE2+t atksgyp5HRTWr/shYTzSxZ+kiC7n7z0j0do2eCbLOsZvWoiPL2ZoTAKGoNC+OZ743aSvOTvljGW ERkzfBFsy1c9P+4bbFp6Qnx0MINqTX8JiUYYHtyCgcK7bMZ0TFMu+Ki5uPSatN/nivZZiBcr6/g URuKLPA5WPtGX79x9LtcKyTSG9AtBwPRM16EBYtPGn+53W2ZGZ2zjzQPjWuKJt1hb8fFEwZeCa1 ZwO6CWVxG+bLREZyUaObPF6p/R X-Google-Smtp-Source: AGHT+IGxQwO6oswqfRcYdwp83ClGBVifgsK74s8oNb+HIUlNTaakjy3C210X41ZiYTWEz7XcxcvHVQ== X-Received: by 2002:a17:903:1a6f:b0:2a3:ee53:d201 with SMTP id d9443c01a7336-2a3ee53d218mr162357255ad.12.1768156625704; Sun, 11 Jan 2026 10:37:05 -0800 (PST) Received: from snowman.bbrouter ([43.241.121.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd2953sm152220415ad.86.2026.01.11.10.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 10:37:05 -0800 (PST) From: Khushal Chitturi To: Greg Kroah-Hartman Cc: Michael Straube , Hans de Goede , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 4/9] staging: rtl8723bs: replace msleep with usleep_range in rtw_xmit.c Date: Mon, 12 Jan 2026 00:06:25 +0530 Message-ID: <20260111183630.12816-5-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260111183630.12816-1-khushalchitturi@gmail.com> References: <20260111183630.12816-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace msleep(10) with usleep_range(10000,11000) during xmit buffer reallocation, as msleep() is not suitable for short delays below 20ms. Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index b0a16130a883..3767302362d2 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -128,7 +128,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) /* Tx buf allocation may fail sometimes, so sleep and retry. */ res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ += XMITBUF_ALIGN_SZ), true); if (res =3D=3D _FAIL) { - msleep(10); + usleep_range(10000, 11000); res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ = + XMITBUF_ALIGN_SZ), true); if (res =3D=3D _FAIL) goto exit; --=20 2.52.0 From nobody Sun Feb 8 02:56:12 2026 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32E8E350D42 for ; Sun, 11 Jan 2026 18:37:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156633; cv=none; b=M6nkczyJrzHPIRAi5Gy6it0isHiYD0K/unk6TwluuguBPGLpnqqWFcU6T0TuqajfwS+g4VDOZNdrlcWX33hzpOvKe7o6TfzYISukYfsydSrwEOic59c1w5g/rYzTX7IhopG9iuU7Z0CqkL+NGsirVwE/RcY3a4Sh2xF0xQjNOso= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156633; c=relaxed/simple; bh=1w8rbuilqcZz4xJsF1OtzNeoricMeFQjDbNpafii61o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XDI/etStxuL77KC5t2+J8qLUpKb0aFK9crTv6Oi14tCuR5eeC85/XnYlV2zzi8JFHH4uLhpu7xC4cIEeP9zdpyZGAIssflz+6IFJq86qfb+2rUdA5bTduLxutjislnFC+GATDIHVRXmeh2vBSwp6Rnjwsz/djvfHqOiNph48meA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TQ2qut0a; arc=none smtp.client-ip=209.85.214.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TQ2qut0a" Received: by mail-pl1-f196.google.com with SMTP id d9443c01a7336-2a0fe77d141so42941465ad.1 for ; Sun, 11 Jan 2026 10:37:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768156631; x=1768761431; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hQ0f+RLTwflfmfQxVO5jGTci6f7c5EC6D5hyMz+jnOg=; b=TQ2qut0arfWukxKJ8JKMa6IfNg20pKLAfIL8sPhql8UnUUmi3VOuqlQZODSaHiLXqA W94uBk543UvrdE1ymVrXUtEeP3vNQvcdNXFG+WUYostMTv3NPPhDx0KBZiiDBiKWWn1W UTvTh2f1swx6Yd5OUWIMoN7VUzg0R7l7I4KI52VXzMPQGiLG7Z4J2+P9qQERWBns+gie 3AQzifBLPErSuivy2LMrRkdUiafSB4bnrgmZZac0t2/E/EXylmkDwDzQx7RYpsfeMvi9 mwpnfyXG8mnyjqRQj/zzOmeDCoDYyj9ytjbC14qk1HVC/YD0rS86hRq1FDqOcTYCdCT9 /1bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768156631; x=1768761431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hQ0f+RLTwflfmfQxVO5jGTci6f7c5EC6D5hyMz+jnOg=; b=Bc6bngvVxzj6zN5nRoGDfWhwkOtFLr/3xNYPifOe+i51JPaiJCfk+jQ8cKZF+6kU34 388jyPZ8ECg+oAfZlo7y5QGeT8XXuQvogKRi+dh1K8zdEW6R6qEdWC4YJzFdRhRB6vp9 /tewzp0wfwxWTC3nxpj+y1CYB07C3IiQ4N/ksfUwe9ImCl0uLIGWH0WGlBf++f33Kcde 1/mZsK0p0r2FgqDdOqbXbq0I151UPhz5pllWT+KjknHZ/nYt5i9KqXRqwwj0zu/RRMC2 7cD+3haGAUriU092xiiXBPnw2X5foADO+PP5I/NSpysacjKZfC6fiyP9LByj8KI8rMDI PNhA== X-Forwarded-Encrypted: i=1; AJvYcCVT2G/vOWKEFw92DEq6outff2QiJ067clIsjd+DeXbIYmPkgGWitkZQ/MhvStbYAxNEananyYIMuX6ARFM=@vger.kernel.org X-Gm-Message-State: AOJu0YyB07FGGRxQMiEEQjcvc8sB1+bOW8y0fmHO0FW1++G5eL4AIzvj PFjdZZUrDztYVIJNSOQN0/TcCbj2Z+NLBAj69TzV9BflF2PBTN0Kl3u5 X-Gm-Gg: AY/fxX6hHwzs59e51tG8h5zwdsTy9eL6xSwWP/7kMy0rPIPbz7ZNpnM50vT3Bg2D6s1 864MBYEEErLESqbTlIeuJfUxxTJAxyogMJsZ9ajXJ3gMaXqj8HrSEt9frRoGtuN3l66Khc10yib t/6meUmwljdto2eWXQbfo+bVmUuGbd0oWjNfCgkNWtSr544PrA+Of634Lm+wgYbESE5b4hAoy0j vXlIBGNGEDVJdBnm75u3/zLbKU+oRhvALCW+2VRWHWfFsRjtb0Yb2ulfvW12FgcFArStNUjeKi3 2XvGjFuDhC+D6POgyaauVxCm1VlV4oNIB+MkQywSVvE0O3wetHRT+sxBykGnTzZzgHHT9QhBAuH Yo0WpAjHeWU1uRFytgMqWXP1P/RdQ0DtO9t0hcIBJAEO2nciF+gJILb0b6wUZ8AkbMVHyRjLgpM zt9zE75be5UXY2XPSEnlMQ+y6j X-Google-Smtp-Source: AGHT+IG/MXJ3d2Wm9exETKgL5vgeolbnIBkSjXEDW/nhmfwrAYj0wcoR2DW6fzBnna5Vk76CGaVJfA== X-Received: by 2002:a17:903:178b:b0:295:fc0:5a32 with SMTP id d9443c01a7336-2a3ee438532mr146354355ad.3.1768156631499; Sun, 11 Jan 2026 10:37:11 -0800 (PST) Received: from snowman.bbrouter ([43.241.121.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd2953sm152220415ad.86.2026.01.11.10.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 10:37:11 -0800 (PST) From: Khushal Chitturi To: Greg Kroah-Hartman Cc: Michael Straube , Hans de Goede , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 5/9] staging: rtl8723bs: split chained assignments Date: Mon, 12 Jan 2026 00:06:26 +0530 Message-ID: <20260111183630.12816-6-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260111183630.12816-1-khushalchitturi@gmail.com> References: <20260111183630.12816-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Split chained assignments in rtw_xmit.c into separate statements to improve readability and comply with the kernel coding style. Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 3767302362d2..fd25289111e3 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -137,7 +137,8 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->phead =3D pxmitbuf->pbuf; pxmitbuf->pend =3D pxmitbuf->pbuf + MAX_XMITBUF_SZ; pxmitbuf->len =3D 0; - pxmitbuf->pdata =3D pxmitbuf->ptail =3D pxmitbuf->phead; + pxmitbuf->pdata =3D pxmitbuf->phead; + pxmitbuf->ptail =3D pxmitbuf->phead; =20 pxmitbuf->flags =3D XMIT_VO_QUEUE; =20 @@ -217,7 +218,8 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->phead =3D pxmitbuf->pbuf; pxmitbuf->pend =3D pxmitbuf->pbuf + MAX_XMIT_EXTBUF_SZ; pxmitbuf->len =3D 0; - pxmitbuf->pdata =3D pxmitbuf->ptail =3D pxmitbuf->phead; + pxmitbuf->pdata =3D pxmitbuf->phead; + pxmitbuf->ptail =3D pxmitbuf->phead; =20 list_add_tail(&pxmitbuf->list, &pxmitpriv->free_xmit_extbuf_queue.queue); @@ -247,7 +249,8 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->phead =3D pxmitbuf->pbuf; pxmitbuf->pend =3D pxmitbuf->pbuf + MAX_CMDBUF_SZ; pxmitbuf->len =3D 0; - pxmitbuf->pdata =3D pxmitbuf->ptail =3D pxmitbuf->phead; + pxmitbuf->pdata =3D pxmitbuf->phead; + pxmitbuf->ptail =3D pxmitbuf->phead; pxmitbuf->alloc_sz =3D MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ; } } @@ -1155,11 +1158,13 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s u8 MME[_MME_IE_LENGTH_]; u32 ori_len; =20 - mem_start =3D pframe =3D (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET; + mem_start =3D (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET; + pframe =3D (u8 *)(pxmitframe->buf_addr) + TXDESC_OFFSET; pwlanhdr =3D (struct ieee80211_hdr *)pframe; =20 ori_len =3D BIP_AAD_SIZE + pattrib->pktlen; - tmp_buf =3D BIP_AAD =3D rtw_zmalloc(ori_len); + tmp_buf =3D rtw_zmalloc(ori_len); + BIP_AAD =3D rtw_zmalloc(ori_len); subtype =3D GetFrameSubType(pframe); /* bit(7)~bit(2) */ =20 if (!BIP_AAD) @@ -1405,7 +1410,8 @@ static struct xmit_buf *__rtw_alloc_cmd_xmitbuf(struc= t xmit_priv *pxmitpriv, pxmitbuf->priv_data =3D NULL; =20 pxmitbuf->len =3D 0; - pxmitbuf->pdata =3D pxmitbuf->ptail =3D pxmitbuf->phead; + pxmitbuf->pdata =3D pxmitbuf->phead; + pxmitbuf->ptail =3D pxmitbuf->phead; pxmitbuf->agg_num =3D 0; pxmitbuf->pg_num =3D 0; =20 --=20 2.52.0 From nobody Sun Feb 8 02:56:12 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF1F34B682 for ; Sun, 11 Jan 2026 18:37:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156643; cv=none; b=TZWm8ip7JvqikQ2NZ+AocgRjgXKGARzMxbZ5iNeRHNabCm1gqQEDxMWtwZa5HIetc7n+bD1TX7doOtvfwXbzvbstgODTfmlhPLGWfhIYA58P9H6pSBHcJpPtmkcnrxry1EtenXo3clbgmIM88NcUUzqz3FxicKRe4aIqo/bv/uI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156643; c=relaxed/simple; bh=fl8LZYS9qeWPoNGE1qp2A78T4rOc3z+bF+PvxBl8lbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IyHE+0J2xFEEGZVD+WrGW7RnCyGmxfZCsjXkrOaLpiShbuAJDH9HMKUHybSmcG6cHCU8CZVRZhEyOwmzBtS304Jna2njg+5Wgd8KMIDYuOFCmRrukQmgb1UcIc+KF5bIRRxkTcNu2JmAOii8Al3zt20ZdSvyl7SHxVKtRW4bXQk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PXE9er+D; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PXE9er+D" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-29f1bc40b35so65125955ad.2 for ; Sun, 11 Jan 2026 10:37:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768156639; x=1768761439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ASoHbVsowmDQYZYqADnm8elWQSiSQB3UuKMUV0ANdcc=; b=PXE9er+DofV9u5txBU6bZ0UlgqqnAO6+QqqWWrEjD3oXaTnCQSkFXdY0kKX1gduCrN if23RIqSM2iEpnoBqHU4/WCB6p7l9AqE4cLLSltY88odm4LcdJKlOc67uF4UFWkU1y2s IXAoffgo9eGZHxpDYqY5qGC2iyIUmwXMn66et+I59goei8tlrqTWdXZbby8B/WqX5jkn 55C7CJevIAAynRZvRa8Pp2p3r78eIZBCLaMyVxhB0jcfp21lEnPiPVt7UK7HkcrTdMgJ zd8LbRNcoL1iBq7PiGbxRFexYih4VqgFz0zqb4lM2U/XJ4Da/HkkkYWRiyCPYY1zmvRx ckbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768156639; x=1768761439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ASoHbVsowmDQYZYqADnm8elWQSiSQB3UuKMUV0ANdcc=; b=OQYdTuLxtqthdyu0Z8bG2ZhR58pSiaEIbfyt5DUCXvNQKyGIf31hcr6SQsxryvPi8q vHkWob8ED8/NE2dMFck2gX3Yx82YGh9ONmn/WTLJE6gUlx9E3M9XitGPX4X+yMCu0KJp 9aHMg7SDe0vfdoEpAoXmfjdXohBHwWK2H/tMTeC+lItLetktgj7aQFBJMcO17iRhNmFn 9BrzmKQOUOD6NdCWUA810nUrzFb+xgtHe6OJTFUqEIigyDAmjBte7662PG8o9wvVV2v2 10e9aSpkFIRhW9a3dPa8AfesyooRVBdmWOjaU4VqQ7fN+F+TdBdUXvK6mkQ4PKgfND21 niZA== X-Forwarded-Encrypted: i=1; AJvYcCVM65UWXVtu6PKFJ8YQBL5nw/LzsGkznWVJ7pVcpmKGZQJtTsxodhszY1pSefPYLLY5qEjxgFDu/5VWyu8=@vger.kernel.org X-Gm-Message-State: AOJu0YxAp98CpF4wlTYSuhaa7gnIgJz5MsuxYmKtqZexv69w32ixASft JD6Ii1njmcR+hSMIBbPMoblYHyI/pZ8P03XLbRAqD9P8X8j+dbtkf7aT X-Gm-Gg: AY/fxX6GzO+zI3g7BRT3raeswjcRqRahDwhUSxNJ7RFYLmABWamvW9ToF5hsxLJOMKB UIo38Gmlh8jcUAk/U4ME5w1LfMleUpaIB18ppUlMvIfTl2hhskde/hc7QvUS0hULuryPJ55p7mX ozlL09G3XJw2P01Ia9x96BpMVfaXgww7q4vbtXqs5f8mXsOyekcCCgV3bWQUTKQ9okW1Y76eSpj lHN629ZjfSJke4Iy5lURFckdtHrqaxQRqp6FycTX+zpVylrjGt2b0DKaCYL0xcyf73x+fYbhPWr 6BqN0wlkqaR7MecjSwKb7Y1fPca0umRxhsqkxghCvycsIWmoVbqtheZzgp4h6McBeqv6/FQq3x4 M7V/noICoQSY9VMLokTN1vPVNstuxCz395oAwILw6VUG/pE/MEl9NryVUmioJHuEvGq1zIunqW6 Gb8Q3NjS0BWTQN+vlObFkHoICf X-Google-Smtp-Source: AGHT+IF8tzZ+0FHPjI8wnjH8brVBrar+nwhsLYOL6P00hMAPP/Hw/IkqNdC8OyKbXb+MBmIHrn8KFQ== X-Received: by 2002:a17:902:dace:b0:294:d953:6ff9 with SMTP id d9443c01a7336-2a3ee49b44dmr171632285ad.47.1768156637992; Sun, 11 Jan 2026 10:37:17 -0800 (PST) Received: from snowman.bbrouter ([43.241.121.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd2953sm152220415ad.86.2026.01.11.10.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 10:37:17 -0800 (PST) From: Khushal Chitturi To: Greg Kroah-Hartman Cc: Michael Straube , Hans de Goede , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 6/9] staging: rtl8723bs: rename struct members to snake_case Date: Mon, 12 Jan 2026 00:06:27 +0530 Message-ID: <20260111183630.12816-7-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260111183630.12816-1-khushalchitturi@gmail.com> References: <20260111183630.12816-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename CamelCase struct members in rtw_xmit.c and related files to snake_case to follow the kernel naming conventions. These identifiers are used across multiple files, so this patch ensures consistent naming throughout the driver. Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_ap.c | 26 +-- drivers/staging/rtl8723bs/core/rtw_cmd.c | 66 +++---- .../staging/rtl8723bs/core/rtw_ioctl_set.c | 16 +- drivers/staging/rtl8723bs/core/rtw_mlme.c | 48 ++--- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 106 +++++------ drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 +- drivers/staging/rtl8723bs/core/rtw_recv.c | 34 ++-- drivers/staging/rtl8723bs/core/rtw_security.c | 38 ++-- .../staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- drivers/staging/rtl8723bs/core/rtw_xmit.c | 70 +++---- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 8 +- drivers/staging/rtl8723bs/hal/hal_com.c | 2 +- drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 32 ++-- drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 2 +- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +- .../staging/rtl8723bs/hal/rtl8723bs_recv.c | 2 +- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 +- drivers/staging/rtl8723bs/include/rtw_mlme.h | 16 +- .../staging/rtl8723bs/include/rtw_security.h | 36 ++-- drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +- drivers/staging/rtl8723bs/include/sta_info.h | 2 +- drivers/staging/rtl8723bs/include/wifi.h | 30 +-- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 176 +++++++++--------- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 +- 25 files changed, 373 insertions(+), 373 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8= 723bs/core/rtw_ap.c index 67197c7d4a4d..b443f441c8cf 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -462,7 +462,7 @@ void update_sta_info_apmode(struct adapter *padapter, s= truct sta_info *psta) /* ap mode */ rtw_hal_set_odm_var(padapter, HAL_ODM_STA_INFO, psta, true); =20 - if (psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_8021X) + if (psecuritypriv->dot11_auth_algrthm =3D=3D dot11_auth_algrthm_8021x) psta->ieee8021x_blocked =3D true; else psta->ieee8021x_blocked =3D false; @@ -682,8 +682,8 @@ void start_bss_network(struct adapter *padapter) if (!pmlmepriv->cur_network.join_res) { /* setting only at first time */ =20 /* WEP Key will be set before this function, do not clear CAM. */ - if ((psecuritypriv->dot11PrivacyAlgrthm !=3D _WEP40_) && - (psecuritypriv->dot11PrivacyAlgrthm !=3D _WEP104_)) + if ((psecuritypriv->dot11_privacy_algrthm !=3D _WEP40_) && + (psecuritypriv->dot11_privacy_algrthm !=3D _WEP104_)) flush_all_cam_entry(padapter); /* clear CAM */ } =20 @@ -705,8 +705,8 @@ void start_bss_network(struct adapter *padapter) rtw_hal_set_hwreg(padapter, HW_VAR_AC_PARAM_BK, (u8 *)(&acparm)); =20 /* Set Security */ - val8 =3D (psecuritypriv->dot11AuthAlgrthm =3D=3D - dot11AuthAlgrthm_8021X) ? 0xcc : 0xcf; + val8 =3D (psecuritypriv->dot11_auth_algrthm =3D=3D + dot11_auth_algrthm_8021x) ? 0xcc : 0xcf; rtw_hal_set_hwreg(padapter, HW_VAR_SEC_CFG, (u8 *)(&val8)); =20 /* Beacon Control related register */ @@ -925,7 +925,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 = *pbuf, int len) &group_cipher, &pairwise_cipher, NULL) =3D=3D _SUCCESS) { - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_8021x; =20 psecuritypriv->dot8021xalg =3D 1;/* psk, todo:802.1x */ psecuritypriv->wpa_psk |=3D BIT(1); @@ -951,7 +951,7 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 = *pbuf, int len) &group_cipher, &pairwise_cipher, NULL) =3D=3D _SUCCESS) { - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_8021x; =20 psecuritypriv->dot8021xalg =3D 1;/* psk, todo:802.1x */ =20 @@ -1249,7 +1249,7 @@ u8 rtw_ap_set_pairwise_key(struct adapter *padapter, = struct sta_info *psta) =20 memcpy(psetstakey_para->addr, psta->hwaddr, ETH_ALEN); =20 - memcpy(psetstakey_para->key, &psta->dot118021x_UncstKey, 16); + memcpy(psetstakey_para->key, &psta->dot11_8021x_uncst_key, 16); =20 res =3D rtw_enqueue_cmd(pcmdpriv, ph2c); =20 @@ -1972,12 +1972,12 @@ void rtw_ap_restore_network(struct adapter *padapte= r) =20 start_bss_network(padapter); =20 - if ((padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _TKIP_) || - (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_)) { + if ((padapter->securitypriv.dot11_privacy_algrthm =3D=3D _TKIP_) || + (padapter->securitypriv.dot11_privacy_algrthm =3D=3D _AES_)) { /* restore group key, WEP keys is restored in ips_leave() */ rtw_set_key(padapter, psecuritypriv, - psecuritypriv->dot118021XGrpKeyid, + psecuritypriv->dot11_8021x_grp_key_id, 0, false); } @@ -2008,8 +2008,8 @@ void rtw_ap_restore_network(struct adapter *padapter) Update_RA_Entry(padapter, psta); /* pairwise key */ /* per sta pairwise key and settings */ - if ((psecuritypriv->dot11PrivacyAlgrthm =3D=3D _TKIP_) || - (psecuritypriv->dot11PrivacyAlgrthm =3D=3D _AES_)) { + if ((psecuritypriv->dot11_privacy_algrthm =3D=3D _TKIP_) || + (psecuritypriv->dot11_privacy_algrthm =3D=3D _AES_)) { rtw_setstakey_cmd(padapter, psta, true, false); } } diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index ef2d92b5588a..874d31bf12fd 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -756,9 +756,9 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wl= an_network *pnetwork) /* Added by Albert 2010/06/23 */ /* For the WEP mode, we will use the bg mode to do the connection to avo= id some IOT issue. */ /* Especially for Realtek 8192u SoftAP. */ - if ((padapter->securitypriv.dot11PrivacyAlgrthm !=3D _WEP40_) && - (padapter->securitypriv.dot11PrivacyAlgrthm !=3D _WEP104_) && - (padapter->securitypriv.dot11PrivacyAlgrthm !=3D _TKIP_)) { + if ((padapter->securitypriv.dot11_privacy_algrthm !=3D _WEP40_) && + (padapter->securitypriv.dot11_privacy_algrthm !=3D _WEP104_) && + (padapter->securitypriv.dot11_privacy_algrthm !=3D _TKIP_)) { rtw_ht_use_default_setting(padapter); =20 rtw_build_wmm_ie_ht(padapter, &psecnetwork->ies[12], &psecnetwork->ie_l= ength); @@ -877,14 +877,14 @@ u8 rtw_setstakey_cmd(struct adapter *padapter, struct= sta_info *sta, u8 unicast_ memcpy(psetstakey_para->addr, sta->hwaddr, ETH_ALEN); =20 if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) - psetstakey_para->algorithm =3D (unsigned char)psecuritypriv->dot11Privac= yAlgrthm; + psetstakey_para->algorithm =3D (unsigned char)psecuritypriv->dot11_priva= cy_algrthm; else GET_ENCRY_ALGO(psecuritypriv, sta, psetstakey_para->algorithm, false); =20 if (unicast_key) - memcpy(&psetstakey_para->key, &sta->dot118021x_UncstKey, 16); + memcpy(&psetstakey_para->key, &sta->dot11_8021x_uncst_key, 16); else - memcpy(&psetstakey_para->key, &psecuritypriv->dot118021XGrpKey[psecurity= priv->dot118021XGrpKeyid].skey, 16); + memcpy(&psetstakey_para->key, &psecuritypriv->dot118021XGrpKey[psecurity= priv->dot11_8021x_grp_key_id].skey, 16); =20 /* jeff: set this because at least sw key is ready */ padapter->securitypriv.busetkipkey =3D true; @@ -1144,51 +1144,51 @@ u8 traffic_status_watchdog(struct adapter *padapter= , u8 from_timer) if ((check_fwstate(pmlmepriv, _FW_LINKED)) /*&& !MgntInitAdapterInProgress(pMgntInfo)*/) { /* if we raise bBusyTraffic in last watchdog, using lower threshold. */ - if (pmlmepriv->LinkDetectInfo.bBusyTraffic) + if (pmlmepriv->link_detect_info.bBusyTraffic) BusyThreshold =3D BusyThresholdLow; =20 - if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold || - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) { + if (pmlmepriv->link_detect_info.NumRxOkInPeriod > BusyThreshold || + pmlmepriv->link_detect_info.num_tx_ok_in_period > BusyThreshold) { bBusyTraffic =3D true; =20 - if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > pmlmepriv->LinkDetectIn= fo.NumTxOkInPeriod) + if (pmlmepriv->link_detect_info.NumRxOkInPeriod > pmlmepriv->link_detec= t_info.num_tx_ok_in_period) bRxBusyTraffic =3D true; else bTxBusyTraffic =3D true; } =20 /* Higher Tx/Rx data. */ - if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > 4000 || - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > 4000) { + if (pmlmepriv->link_detect_info.NumRxOkInPeriod > 4000 || + pmlmepriv->link_detect_info.num_tx_ok_in_period > 4000) { bHigherBusyTraffic =3D true; =20 - if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > pmlmepriv->LinkDetectIn= fo.NumTxOkInPeriod) + if (pmlmepriv->link_detect_info.NumRxOkInPeriod > pmlmepriv->link_detec= t_info.num_tx_ok_in_period) bHigherBusyRxTraffic =3D true; else bHigherBusyTxTraffic =3D true; } =20 /* check traffic for powersaving. */ - if (((pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod + pmlmepriv->Link= DetectInfo.NumTxOkInPeriod) > 8) || - (pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 2)) { + if (((pmlmepriv->link_detect_info.NumRxUnicastOkInPeriod + pmlmepriv->li= nk_detect_info.num_tx_ok_in_period) > 8) || + (pmlmepriv->link_detect_info.NumRxUnicastOkInPeriod > 2)) { bEnterPS =3D false; =20 if (bBusyTraffic) { - if (pmlmepriv->LinkDetectInfo.TrafficTransitionCount <=3D 4) - pmlmepriv->LinkDetectInfo.TrafficTransitionCount =3D 4; + if (pmlmepriv->link_detect_info.TrafficTransitionCount <=3D 4) + pmlmepriv->link_detect_info.TrafficTransitionCount =3D 4; =20 - pmlmepriv->LinkDetectInfo.TrafficTransitionCount++; + pmlmepriv->link_detect_info.TrafficTransitionCount++; =20 - if (pmlmepriv->LinkDetectInfo.TrafficTransitionCount > 30/*TrafficTran= sitionLevel*/) - pmlmepriv->LinkDetectInfo.TrafficTransitionCount =3D 30; + if (pmlmepriv->link_detect_info.TrafficTransitionCount > 30/*TrafficTr= ansitionLevel*/) + pmlmepriv->link_detect_info.TrafficTransitionCount =3D 30; } } else { - if (pmlmepriv->LinkDetectInfo.TrafficTransitionCount >=3D 2) - pmlmepriv->LinkDetectInfo.TrafficTransitionCount -=3D 2; + if (pmlmepriv->link_detect_info.TrafficTransitionCount >=3D 2) + pmlmepriv->link_detect_info.TrafficTransitionCount -=3D 2; else - pmlmepriv->LinkDetectInfo.TrafficTransitionCount =3D 0; + pmlmepriv->link_detect_info.TrafficTransitionCount =3D 0; =20 - if (pmlmepriv->LinkDetectInfo.TrafficTransitionCount =3D=3D 0) + if (pmlmepriv->link_detect_info.TrafficTransitionCount =3D=3D 0) bEnterPS =3D true; } =20 @@ -1213,15 +1213,15 @@ u8 traffic_status_watchdog(struct adapter *padapter= , u8 from_timer) LPS_Leave(padapter, "NON_LINKED"); } =20 - pmlmepriv->LinkDetectInfo.NumRxOkInPeriod =3D 0; - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod =3D 0; - pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod =3D 0; - pmlmepriv->LinkDetectInfo.bBusyTraffic =3D bBusyTraffic; - pmlmepriv->LinkDetectInfo.bTxBusyTraffic =3D bTxBusyTraffic; - pmlmepriv->LinkDetectInfo.bRxBusyTraffic =3D bRxBusyTraffic; - pmlmepriv->LinkDetectInfo.bHigherBusyTraffic =3D bHigherBusyTraffic; - pmlmepriv->LinkDetectInfo.bHigherBusyRxTraffic =3D bHigherBusyRxTraffic; - pmlmepriv->LinkDetectInfo.bHigherBusyTxTraffic =3D bHigherBusyTxTraffic; + pmlmepriv->link_detect_info.NumRxOkInPeriod =3D 0; + pmlmepriv->link_detect_info.num_tx_ok_in_period =3D 0; + pmlmepriv->link_detect_info.NumRxUnicastOkInPeriod =3D 0; + pmlmepriv->link_detect_info.bBusyTraffic =3D bBusyTraffic; + pmlmepriv->link_detect_info.bTxBusyTraffic =3D bTxBusyTraffic; + pmlmepriv->link_detect_info.bRxBusyTraffic =3D bRxBusyTraffic; + pmlmepriv->link_detect_info.bHigherBusyTraffic =3D bHigherBusyTraffic; + pmlmepriv->link_detect_info.bHigherBusyRxTraffic =3D bHigherBusyRxTraffic; + pmlmepriv->link_detect_info.bHigherBusyTxTraffic =3D bHigherBusyTxTraffic; =20 return bEnterPS; =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ioctl_set.c index 587a87fbffeb..adc568a3a95c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -61,7 +61,7 @@ u8 rtw_do_join(struct adapter *padapter) /* when set_ssid/set_bssid for rtw_do_join(), but scanning queue is empt= y */ /* we try to issue sitesurvey firstly */ =20 - if (pmlmepriv->LinkDetectInfo.bBusyTraffic =3D=3D false + if (pmlmepriv->link_detect_info.bBusyTraffic =3D=3D false || rtw_to_roam(padapter) > 0 ) { /* submit site_survey_cmd */ @@ -113,7 +113,7 @@ u8 rtw_do_join(struct adapter *padapter) =20 /* when set_ssid/set_bssid for rtw_do_join(), but there are no desired= bss in scanning queue */ /* we try to issue sitesurvey firstly */ - if (pmlmepriv->LinkDetectInfo.bBusyTraffic =3D=3D false + if (pmlmepriv->link_detect_info.bBusyTraffic =3D=3D false || rtw_to_roam(padapter) > 0 ) { ret =3D rtw_sitesurvey_cmd(padapter, &pmlmepriv->assoc_ssid, 1, NULL,= 0); @@ -380,7 +380,7 @@ u8 rtw_set_802_11_bssid_list_scan(struct adapter *padap= ter, struct ndis_802_11_s } =20 if ((check_fwstate(pmlmepriv, _FW_UNDER_SURVEY|_FW_UNDER_LINKING) =3D=3D = true) || - (pmlmepriv->LinkDetectInfo.bBusyTraffic =3D=3D true)) { + (pmlmepriv->link_detect_info.bBusyTraffic =3D=3D true)) { /* Scan or linking is in progress, do nothing. */ res =3D true; =20 @@ -408,7 +408,7 @@ u8 rtw_set_802_11_authentication_mode(struct adapter *p= adapter, enum ndis_802_11 psecuritypriv->ndisauthtype =3D authmode; =20 if (psecuritypriv->ndisauthtype > 3) - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_8021x; =20 res =3D rtw_set_auth(padapter, psecuritypriv); =20 @@ -436,13 +436,13 @@ u8 rtw_set_802_11_add_wep(struct adapter *padapter, s= truct ndis_802_11_wep *wep) =20 switch (wep->key_length) { case 5: - psecuritypriv->dot11PrivacyAlgrthm =3D _WEP40_; + psecuritypriv->dot11_privacy_algrthm =3D _WEP40_; break; case 13: - psecuritypriv->dot11PrivacyAlgrthm =3D _WEP104_; + psecuritypriv->dot11_privacy_algrthm =3D _WEP104_; break; default: - psecuritypriv->dot11PrivacyAlgrthm =3D _NO_PRIVACY_; + psecuritypriv->dot11_privacy_algrthm =3D _NO_PRIVACY_; break; } =20 @@ -450,7 +450,7 @@ u8 rtw_set_802_11_add_wep(struct adapter *padapter, str= uct ndis_802_11_wep *wep) =20 psecuritypriv->dot11DefKeylen[keyid] =3D wep->key_length; =20 - psecuritypriv->dot11PrivacyKeyIndex =3D keyid; + psecuritypriv->dot11_privacy_key_index =3D keyid; =20 res =3D rtw_set_key(padapter, psecuritypriv, keyid, 1, true); =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 98704179ad35..0d09145d7ea0 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -335,10 +335,10 @@ int rtw_is_same_ibss(struct adapter *adapter, struct = wlan_network *pnetwork) int ret =3D true; struct security_priv *psecuritypriv =3D &adapter->securitypriv; =20 - if ((psecuritypriv->dot11PrivacyAlgrthm !=3D _NO_PRIVACY_) && + if ((psecuritypriv->dot11_privacy_algrthm !=3D _NO_PRIVACY_) && (pnetwork->network.privacy =3D=3D 0)) ret =3D false; - else if ((psecuritypriv->dot11PrivacyAlgrthm =3D=3D _NO_PRIVACY_) && + else if ((psecuritypriv->dot11_privacy_algrthm =3D=3D _NO_PRIVACY_) && (pnetwork->network.privacy =3D=3D 1)) ret =3D false; else @@ -998,15 +998,15 @@ static struct sta_info *rtw_joinbss_update_stainfo(st= ruct adapter *padapter, str rtw_hal_set_odm_var(padapter, HAL_ODM_STA_INFO, psta, true); =20 /* security related */ - if (padapter->securitypriv.dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_8021= X) { + if (padapter->securitypriv.dot11_auth_algrthm =3D=3D dot11_auth_algrthm_= 8021x) { padapter->securitypriv.binstallGrpkey =3D false; padapter->securitypriv.busetkipkey =3D false; padapter->securitypriv.bgrpkey_handshake =3D false; =20 psta->ieee8021x_blocked =3D true; - psta->dot118021XPrivacy =3D padapter->securitypriv.dot11PrivacyAlgrthm; + psta->dot118021XPrivacy =3D padapter->securitypriv.dot11_privacy_algrth= m; =20 - memset((u8 *)&psta->dot118021x_UncstKey, 0, sizeof(union Keytype)); + memset((u8 *)&psta->dot11_8021x_uncst_key, 0, sizeof(union Keytype)); =20 memset((u8 *)&psta->dot11tkiprxmickey, 0, sizeof(union Keytype)); memset((u8 *)&psta->dot11tkiptxmickey, 0, sizeof(union Keytype)); @@ -1109,7 +1109,7 @@ void rtw_reset_securitypriv(struct adapter *adapter) =20 spin_lock_bh(&adapter->security_key_mutex); =20 - if (adapter->securitypriv.dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_8021X)= { + if (adapter->securitypriv.dot11_auth_algrthm =3D=3D dot11_auth_algrthm_80= 21x) { /* 802.1x */ /* Added by Albert 2009/02/18 */ /* We have to backup the PMK information for WiFi PMK Caching test item= . */ @@ -1143,12 +1143,12 @@ void rtw_reset_securitypriv(struct adapter *adapter) /* */ struct security_priv *psec_priv =3D &adapter->securitypriv; =20 - psec_priv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_Open; /* open system */ - psec_priv->dot11PrivacyAlgrthm =3D _NO_PRIVACY_; - psec_priv->dot11PrivacyKeyIndex =3D 0; + psec_priv->dot11_auth_algrthm =3D dot11_auth_algrthm_open; /* open syst= em */ + psec_priv->dot11_privacy_algrthm =3D _NO_PRIVACY_; + psec_priv->dot11_privacy_key_index =3D 0; =20 - psec_priv->dot118021XGrpPrivacy =3D _NO_PRIVACY_; - psec_priv->dot118021XGrpKeyid =3D 1; + psec_priv->dot11_8021x_grp_privacy =3D _NO_PRIVACY_; + psec_priv->dot11_8021x_grp_key_id =3D 1; =20 psec_priv->ndisauthtype =3D Ndis802_11AuthModeOpen; psec_priv->ndisencryptstatus =3D Ndis802_11WEPDisabled; @@ -1185,8 +1185,8 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) =20 spin_lock_bh(&pmlmepriv->lock); =20 - pmlmepriv->LinkDetectInfo.TrafficTransitionCount =3D 0; - pmlmepriv->LinkDetectInfo.LowPowerTransitionCount =3D 0; + pmlmepriv->link_detect_info.TrafficTransitionCount =3D 0; + pmlmepriv->link_detect_info.LowPowerTransitionCount =3D 0; =20 if (pnetwork->join_res > 0) { spin_lock_bh(&pmlmepriv->scanned_queue.lock); @@ -1379,8 +1379,8 @@ void rtw_stassoc_event_callback(struct adapter *adapt= er, u8 *pbuf) =20 rtw_sta_media_status_rpt(adapter, psta, 1); =20 - if (adapter->securitypriv.dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_8021X) - psta->dot118021XPrivacy =3D adapter->securitypriv.dot11PrivacyAlgrthm; + if (adapter->securitypriv.dot11_auth_algrthm =3D=3D dot11_auth_algrthm_80= 21x) + psta->dot118021XPrivacy =3D adapter->securitypriv.dot11_privacy_algrthm; =20 psta->ieee8021x_blocked =3D false; =20 @@ -1627,7 +1627,7 @@ static void rtw_auto_scan_handler(struct adapter *pad= apter) if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING) =3D= =3D true) goto exit; =20 - if (pmlmepriv->LinkDetectInfo.bBusyTraffic) + if (pmlmepriv->link_detect_info.bBusyTraffic) goto exit; } =20 @@ -1900,7 +1900,7 @@ signed int rtw_set_auth(struct adapter *adapter, stru= ct security_priv *psecurity goto exit; } =20 - psetauthparm->mode =3D (unsigned char)psecuritypriv->dot11AuthAlgrthm; + psetauthparm->mode =3D (unsigned char)psecuritypriv->dot11_auth_algrthm; =20 pcmd->cmdcode =3D _SetAuth_CMD_; pcmd->parmbuf =3D (unsigned char *)psetauthparm; @@ -1930,10 +1930,10 @@ signed int rtw_set_key(struct adapter *adapter, str= uct security_priv *psecurityp goto exit; } =20 - if (psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_8021X) - psetkeyparm->algorithm =3D (unsigned char)psecuritypriv->dot118021XGrpPr= ivacy; + if (psecuritypriv->dot11_auth_algrthm =3D=3D dot11_auth_algrthm_8021x) + psetkeyparm->algorithm =3D (unsigned char)psecuritypriv->dot11_8021x_grp= _privacy; else - psetkeyparm->algorithm =3D (u8)psecuritypriv->dot11PrivacyAlgrthm; + psetkeyparm->algorithm =3D (u8)psecuritypriv->dot11_privacy_algrthm; =20 psetkeyparm->keyid =3D (u8)keyid;/* 0~3 */ psetkeyparm->set_tx =3D set_tx; @@ -2161,7 +2161,7 @@ void rtw_update_registrypriv_dev_network(struct adapt= er *adapter) struct security_priv *psecuritypriv =3D &adapter->securitypriv; struct wlan_network *cur_network =3D &adapter->mlmepriv.cur_network; =20 - pdev_network->privacy =3D (psecuritypriv->dot11PrivacyAlgrthm > 0 ? 1 : 0= ) ; /* adhoc no 802.1x */ + pdev_network->privacy =3D (psecuritypriv->dot11_privacy_algrthm > 0 ? 1 := 0) ; /* adhoc no 802.1x */ =20 pdev_network->rssi =3D 0; =20 @@ -2401,7 +2401,7 @@ unsigned int rtw_restructure_ht_ie(struct adapter *pa= dapter, u8 *in_ie, u8 *out_ =20 ht_capie.ampdu_params_info =3D (max_rx_ampdu_factor&0x03); =20 - if (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_) + if (padapter->securitypriv.dot11_privacy_algrthm =3D=3D _AES_) ht_capie.ampdu_params_info |=3D (IEEE80211_HT_CAP_AMPDU_DENSITY&(0x07<<2= )); else ht_capie.ampdu_params_info |=3D (IEEE80211_HT_CAP_AMPDU_DENSITY&0x00); @@ -2517,8 +2517,8 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr struct pkt_attrib *pattrib =3D &pxmitframe->attrib; s32 bmcst =3D is_multicast_ether_addr(pattrib->ra); =20 - /* if (bmcst || (padapter->mlmepriv.LinkDetectInfo.bTxBusyTraffic =3D=3D = false)) */ - if (bmcst || (padapter->mlmepriv.LinkDetectInfo.NumTxOkInPeriod < 100)) + /* if (bmcst || (padapter->mlmepriv.link_detect_info.bTxBusyTraffic =3D= =3D false)) */ + if (bmcst || (padapter->mlmepriv.link_detect_info.num_tx_ok_in_period < 1= 00)) return; =20 priority =3D pattrib->priority; diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index ac49bfbaa5bb..3219d234e3ce 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -236,7 +236,7 @@ static void init_mlme_ext_priv_value(struct adapter *pa= dapter) pmlmeinfo->reassoc_count =3D 0; pmlmeinfo->link_count =3D 0; pmlmeinfo->auth_seq =3D 0; - pmlmeinfo->auth_algo =3D dot11AuthAlgrthm_Open; + pmlmeinfo->auth_algo =3D dot11_auth_algrthm_open; pmlmeinfo->key_index =3D 0; pmlmeinfo->iv =3D 0; =20 @@ -452,7 +452,7 @@ void mgt_dispatcher(struct adapter *padapter, union rec= v_frame *precv_frame) =20 ptable =3D mlme_sta_tbl; =20 - index =3D GetFrameSubType(pframe) >> 4; + index =3D get_frame_sub_type(pframe) >> 4; =20 if (index >=3D ARRAY_SIZE(mlme_sta_tbl)) return; @@ -470,7 +470,7 @@ void mgt_dispatcher(struct adapter *padapter, union rec= v_frame *precv_frame) psta->RxMgmtFrameSeqNum =3D precv_frame->u.hdr.attrib.seq_num; } =20 - switch (GetFrameSubType(pframe)) { + switch (get_frame_sub_type(pframe)) { case WIFI_AUTH: if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) ptable->func =3D &OnAuth; @@ -691,7 +691,7 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) =20 sa =3D GetAddr2Ptr(pframe); =20 - auth_mode =3D psecuritypriv->dot11AuthAlgrthm; + auth_mode =3D psecuritypriv->dot11_auth_algrthm; =20 if (GetPrivacy(pframe)) { u8 *iv; @@ -715,8 +715,8 @@ unsigned int OnAuth(struct adapter *padapter, union rec= v_frame *precv_frame) seq =3D le16_to_cpu(*(__le16 *)((SIZE_PTR)pframe + WLAN_HDR_A3_LEN + offs= et + 2)); =20 if (auth_mode =3D=3D 2 && - psecuritypriv->dot11PrivacyAlgrthm !=3D _WEP40_ && - psecuritypriv->dot11PrivacyAlgrthm !=3D _WEP104_) + psecuritypriv->dot11_privacy_algrthm !=3D _WEP40_ && + psecuritypriv->dot11_privacy_algrthm !=3D _WEP104_) auth_mode =3D 0; =20 if ((algorithm > 0 && auth_mode =3D=3D 0) || /* rx a shared-key auth but= shared not enabled */ @@ -875,11 +875,11 @@ unsigned int OnAuthClient(struct adapter *padapter, u= nion recv_frame *precv_fram status =3D le16_to_cpu(*(__le16 *)((SIZE_PTR)pframe + WLAN_HDR_A3_LEN + o= ffset + 4)); =20 if (status !=3D 0) { - if (status =3D=3D 13) { /* pmlmeinfo->auth_algo =3D=3D dot11AuthAlgrthm= _Auto) */ - if (pmlmeinfo->auth_algo =3D=3D dot11AuthAlgrthm_Shared) - pmlmeinfo->auth_algo =3D dot11AuthAlgrthm_Open; + if (status =3D=3D 13) { /* pmlmeinfo->auth_algo =3D=3D dot11_auth_algrt= hm_auto) */ + if (pmlmeinfo->auth_algo =3D=3D dot11_auth_algrthm_shared) + pmlmeinfo->auth_algo =3D dot11_auth_algrthm_open; else - pmlmeinfo->auth_algo =3D dot11AuthAlgrthm_Shared; + pmlmeinfo->auth_algo =3D dot11_auth_algrthm_shared; /* pmlmeinfo->reauth_count =3D 0; */ } =20 @@ -888,7 +888,7 @@ unsigned int OnAuthClient(struct adapter *padapter, uni= on recv_frame *precv_fram } =20 if (seq =3D=3D 2) { - if (pmlmeinfo->auth_algo =3D=3D dot11AuthAlgrthm_Shared) { + if (pmlmeinfo->auth_algo =3D=3D dot11_auth_algrthm_shared) { /* legendary shared system */ p =3D rtw_get_ie(pframe + WLAN_HDR_A3_LEN + _AUTH_IE_OFFSET_, WLAN_EID_= CHALLENGE, (int *)&len, pkt_len - WLAN_HDR_A3_LEN - _AUTH_IE_OFFSET_); @@ -906,7 +906,7 @@ unsigned int OnAuthClient(struct adapter *padapter, uni= on recv_frame *precv_fram /* open system */ go2asoc =3D 1; } else if (seq =3D=3D 4) { - if (pmlmeinfo->auth_algo =3D=3D dot11AuthAlgrthm_Shared) + if (pmlmeinfo->auth_algo =3D=3D dot11_auth_algrthm_shared) go2asoc =3D 1; else goto authclnt_fail; @@ -953,7 +953,7 @@ unsigned int OnAssocReq(struct adapter *padapter, union= recv_frame *precv_frame) if ((pmlmeinfo->state&0x03) !=3D WIFI_FW_AP_STATE) return _FAIL; =20 - frame_type =3D GetFrameSubType(pframe); + frame_type =3D get_frame_sub_type(pframe); if (frame_type =3D=3D WIFI_ASSOCREQ) ie_offset =3D _ASOCREQ_IE_OFFSET_; else /* WIFI_REASSOCREQ */ @@ -1523,7 +1523,7 @@ unsigned int OnDeAuth(struct adapter *padapter, union= recv_frame *precv_frame) if (ignore_received_deauth =3D=3D 0) receive_disconnect(padapter, GetAddr3Ptr(pframe), reason); =20 - pmlmepriv->LinkDetectInfo.bBusyTraffic =3D false; + pmlmepriv->link_detect_info.bBusyTraffic =3D false; return _SUCCESS; } =20 @@ -1575,7 +1575,7 @@ unsigned int OnDisassoc(struct adapter *padapter, uni= on recv_frame *precv_frame) =20 receive_disconnect(padapter, GetAddr3Ptr(pframe), reason); =20 - pmlmepriv->LinkDetectInfo.bBusyTraffic =3D false; + pmlmepriv->link_detect_info.bBusyTraffic =3D false; return _SUCCESS; =20 } @@ -2142,9 +2142,9 @@ void issue_beacon(struct adapter *padapter, int timeo= ut_ms) memcpy(pwlanhdr->addr2, myid(&(padapter->eeprompriv)), ETH_ALEN); memcpy(pwlanhdr->addr3, get_my_bssid(cur_network), ETH_ALEN); =20 - SetSeqNum(pwlanhdr, 0/*pmlmeext->mgnt_seq*/); + set_seq_num(pwlanhdr, 0/*pmlmeext->mgnt_seq*/); /* pmlmeext->mgnt_seq++; */ - SetFrameSubType(pframe, WIFI_BEACON); + set_frame_sub_type(pframe, WIFI_BEACON); =20 pframe +=3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D sizeof(struct ieee80211_hdr_3addr); @@ -2292,9 +2292,9 @@ void issue_probersp(struct adapter *padapter, unsigne= d char *da, u8 is_valid_p2p memcpy(pwlanhdr->addr2, mac, ETH_ALEN); memcpy(pwlanhdr->addr3, bssid, ETH_ALEN); =20 - SetSeqNum(pwlanhdr, pmlmeext->mgnt_seq); + set_seq_num(pwlanhdr, pmlmeext->mgnt_seq); pmlmeext->mgnt_seq++; - SetFrameSubType(fctrl, WIFI_PROBERSP); + set_frame_sub_type(fctrl, WIFI_PROBERSP); =20 pattrib->hdrlen =3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D pattrib->hdrlen; @@ -2491,9 +2491,9 @@ static int _issue_probereq(struct adapter *padapter, =20 memcpy(pwlanhdr->addr2, mac, ETH_ALEN); =20 - SetSeqNum(pwlanhdr, pmlmeext->mgnt_seq); + set_seq_num(pwlanhdr, pmlmeext->mgnt_seq); pmlmeext->mgnt_seq++; - SetFrameSubType(pframe, WIFI_PROBEREQ); + set_frame_sub_type(pframe, WIFI_PROBEREQ); =20 pframe +=3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D sizeof(struct ieee80211_hdr_3addr); @@ -2605,9 +2605,9 @@ void issue_auth(struct adapter *padapter, struct sta_= info *psta, unsigned short fctrl =3D &(pwlanhdr->frame_control); *(fctrl) =3D 0; =20 - SetSeqNum(pwlanhdr, pmlmeext->mgnt_seq); + set_seq_num(pwlanhdr, pmlmeext->mgnt_seq); pmlmeext->mgnt_seq++; - SetFrameSubType(pframe, WIFI_AUTH); + set_frame_sub_type(pframe, WIFI_AUTH); =20 pframe +=3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D sizeof(struct ieee80211_hdr_3addr); @@ -2651,7 +2651,7 @@ void issue_auth(struct adapter *padapter, struct sta_= info *psta, unsigned short memcpy(pwlanhdr->addr3, get_my_bssid(&pmlmeinfo->network), ETH_ALEN); =20 /* setting auth algo number */ - val16 =3D (pmlmeinfo->auth_algo =3D=3D dot11AuthAlgrthm_Shared) ? 1 : 0;= /* 0:OPEN System, 1:Shared key */ + val16 =3D (pmlmeinfo->auth_algo =3D=3D dot11_auth_algrthm_shared) ? 1 : = 0;/* 0:OPEN System, 1:Shared key */ if (val16) use_shared_key =3D 1; le_tmp =3D cpu_to_le16(val16); @@ -2682,7 +2682,7 @@ void issue_auth(struct adapter *padapter, struct sta_= info *psta, unsigned short if ((pmlmeinfo->auth_seq =3D=3D 3) && (pmlmeinfo->state & WIFI_FW_AUTH_S= TATE) && (use_shared_key =3D=3D 1)) { pframe =3D rtw_set_ie(pframe, WLAN_EID_CHALLENGE, 128, pmlmeinfo->chg_t= xt, &(pattrib->pktlen)); =20 - SetPrivacy(fctrl); + set_privacy(fctrl); =20 pattrib->hdrlen =3D sizeof(struct ieee80211_hdr_3addr); =20 @@ -2741,10 +2741,10 @@ void issue_asocrsp(struct adapter *padapter, unsign= ed short status, struct sta_i memcpy((void *)GetAddr3Ptr(pwlanhdr), get_my_bssid(&(pmlmeinfo->network))= , ETH_ALEN); =20 =20 - SetSeqNum(pwlanhdr, pmlmeext->mgnt_seq); + set_seq_num(pwlanhdr, pmlmeext->mgnt_seq); pmlmeext->mgnt_seq++; if ((pkt_type =3D=3D WIFI_ASSOCRSP) || (pkt_type =3D=3D WIFI_REASSOCRSP)) - SetFrameSubType(pwlanhdr, pkt_type); + set_frame_sub_type(pwlanhdr, pkt_type); else return; =20 @@ -2868,9 +2868,9 @@ void issue_assocreq(struct adapter *padapter) memcpy(pwlanhdr->addr2, myid(&(padapter->eeprompriv)), ETH_ALEN); memcpy(pwlanhdr->addr3, get_my_bssid(&(pmlmeinfo->network)), ETH_ALEN); =20 - SetSeqNum(pwlanhdr, pmlmeext->mgnt_seq); + set_seq_num(pwlanhdr, pmlmeext->mgnt_seq); pmlmeext->mgnt_seq++; - SetFrameSubType(pframe, WIFI_ASSOCREQ); + set_frame_sub_type(pframe, WIFI_ASSOCREQ); =20 pframe +=3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D sizeof(struct ieee80211_hdr_3addr); @@ -3044,9 +3044,9 @@ static int _issue_nulldata(struct adapter *padapter, = unsigned char *da, *(fctrl) =3D 0; =20 if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) - SetFrDs(fctrl); + set_fr_ds(fctrl); else if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) - SetToDs(fctrl); + set_to_ds(fctrl); =20 if (power_mode) SetPwrMgt(fctrl); @@ -3055,9 +3055,9 @@ static int _issue_nulldata(struct adapter *padapter, = unsigned char *da, memcpy(pwlanhdr->addr2, myid(&(padapter->eeprompriv)), ETH_ALEN); memcpy(pwlanhdr->addr3, get_my_bssid(&(pmlmeinfo->network)), ETH_ALEN); =20 - SetSeqNum(pwlanhdr, pmlmeext->mgnt_seq); + set_seq_num(pwlanhdr, pmlmeext->mgnt_seq); pmlmeext->mgnt_seq++; - SetFrameSubType(pframe, WIFI_DATA_NULL); + set_frame_sub_type(pframe, WIFI_DATA_NULL); =20 pframe +=3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D sizeof(struct ieee80211_hdr_3addr); @@ -3188,25 +3188,25 @@ static int _issue_qos_nulldata(struct adapter *pada= pter, unsigned char *da, *(fctrl) =3D 0; =20 if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_AP_STATE) - SetFrDs(fctrl); + set_fr_ds(fctrl); else if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) - SetToDs(fctrl); + set_to_ds(fctrl); =20 qc =3D (unsigned short *)(pframe + pattrib->hdrlen - 2); =20 - SetPriority(qc, tid); + set_priority(qc, tid); =20 - SetEOSP(qc, pattrib->eosp); + set_eosp(qc, pattrib->eosp); =20 - SetAckpolicy(qc, pattrib->ack_policy); + set_ack_policy(qc, pattrib->ack_policy); =20 memcpy(pwlanhdr->addr1, da, ETH_ALEN); memcpy(pwlanhdr->addr2, myid(&(padapter->eeprompriv)), ETH_ALEN); memcpy(pwlanhdr->addr3, get_my_bssid(&(pmlmeinfo->network)), ETH_ALEN); =20 - SetSeqNum(pwlanhdr, pmlmeext->mgnt_seq); + set_seq_num(pwlanhdr, pmlmeext->mgnt_seq); pmlmeext->mgnt_seq++; - SetFrameSubType(pframe, WIFI_QOS_DATA_NULL); + set_frame_sub_type(pframe, WIFI_QOS_DATA_NULL); =20 pframe +=3D sizeof(struct ieee80211_qos_hdr); pattrib->pktlen =3D sizeof(struct ieee80211_qos_hdr); @@ -3296,9 +3296,9 @@ static int _issue_deauth(struct adapter *padapter, un= signed char *da, memcpy(pwlanhdr->addr2, myid(&(padapter->eeprompriv)), ETH_ALEN); memcpy(pwlanhdr->addr3, get_my_bssid(&(pmlmeinfo->network)), ETH_ALEN); =20 - SetSeqNum(pwlanhdr, pmlmeext->mgnt_seq); + set_seq_num(pwlanhdr, pmlmeext->mgnt_seq); pmlmeext->mgnt_seq++; - SetFrameSubType(pframe, WIFI_DEAUTH); + set_frame_sub_type(pframe, WIFI_DEAUTH); =20 pframe +=3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D sizeof(struct ieee80211_hdr_3addr); @@ -3391,9 +3391,9 @@ void issue_action_SA_Query(struct adapter *padapter, = unsigned char *raddr, unsig memcpy(pwlanhdr->addr2, myid(&(padapter->eeprompriv)), ETH_ALEN); memcpy(pwlanhdr->addr3, get_my_bssid(&(pmlmeinfo->network)), ETH_ALEN); =20 - SetSeqNum(pwlanhdr, pmlmeext->mgnt_seq); + set_seq_num(pwlanhdr, pmlmeext->mgnt_seq); pmlmeext->mgnt_seq++; - SetFrameSubType(pframe, WIFI_ACTION); + set_frame_sub_type(pframe, WIFI_ACTION); =20 pframe +=3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D sizeof(struct ieee80211_hdr_3addr); @@ -3465,9 +3465,9 @@ void issue_action_BA(struct adapter *padapter, unsign= ed char *raddr, unsigned ch memcpy(pwlanhdr->addr2, myid(&(padapter->eeprompriv)), ETH_ALEN); memcpy(pwlanhdr->addr3, get_my_bssid(&(pmlmeinfo->network)), ETH_ALEN); =20 - SetSeqNum(pwlanhdr, pmlmeext->mgnt_seq); + set_seq_num(pwlanhdr, pmlmeext->mgnt_seq); pmlmeext->mgnt_seq++; - SetFrameSubType(pframe, WIFI_ACTION); + set_frame_sub_type(pframe, WIFI_ACTION); =20 pframe +=3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D sizeof(struct ieee80211_hdr_3addr); @@ -3620,9 +3620,9 @@ static void issue_action_BSSCoexistPacket(struct adap= ter *padapter) memcpy(pwlanhdr->addr2, myid(&(padapter->eeprompriv)), ETH_ALEN); memcpy(pwlanhdr->addr3, get_my_bssid(&(pmlmeinfo->network)), ETH_ALEN); =20 - SetSeqNum(pwlanhdr, pmlmeext->mgnt_seq); + set_seq_num(pwlanhdr, pmlmeext->mgnt_seq); pmlmeext->mgnt_seq++; - SetFrameSubType(pframe, WIFI_ACTION); + set_frame_sub_type(pframe, WIFI_ACTION); =20 pframe +=3D sizeof(struct ieee80211_hdr_3addr); pattrib->pktlen =3D sizeof(struct ieee80211_hdr_3addr); @@ -3923,7 +3923,7 @@ u8 collect_bss_info(struct adapter *padapter, union r= ecv_frame *precv_frame, str =20 memset(bssid, 0, sizeof(struct wlan_bssid_ex)); =20 - subtype =3D GetFrameSubType(pframe); + subtype =3D get_frame_sub_type(pframe); =20 if (subtype =3D=3D WIFI_BEACON) { bssid->reserved[0] =3D 1; @@ -4130,7 +4130,7 @@ void start_clnt_join(struct adapter *padapter) if (caps&WLAN_CAPABILITY_ESS) { Set_MSR(padapter, WIFI_FW_STATION_STATE); =20 - val8 =3D (pmlmeinfo->auth_algo =3D=3D dot11AuthAlgrthm_8021X) ? 0xcc : 0= xcf; + val8 =3D (pmlmeinfo->auth_algo =3D=3D dot11_auth_algrthm_8021x) ? 0xcc := 0xcf; =20 rtw_hal_set_hwreg(padapter, HW_VAR_SEC_CFG, (u8 *)(&val8)); =20 @@ -4775,9 +4775,9 @@ static void rtw_mlmeext_disconnect(struct adapter *pa= dapter) =20 timer_delete_sync(&pmlmeext->link_timer); =20 - /* pmlmepriv->LinkDetectInfo.TrafficBusyState =3D false; */ - pmlmepriv->LinkDetectInfo.TrafficTransitionCount =3D 0; - pmlmepriv->LinkDetectInfo.LowPowerTransitionCount =3D 0; + /* pmlmepriv->link_detect_info.TrafficBusyState =3D false; */ + pmlmepriv->link_detect_info.TrafficTransitionCount =3D 0; + pmlmepriv->link_detect_info.LowPowerTransitionCount =3D 0; =20 } =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging= /rtl8723bs/core/rtw_pwrctrl.c index 0ef788abf403..b2e367d3c1e7 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -210,7 +210,7 @@ void traffic_check_for_leave_lps(struct adapter *padapt= er, u8 tx, u32 tx_packets } =20 } else { /* from rx path */ - if (pmlmepriv->LinkDetectInfo.NumRxUnicastOkInPeriod > 4/*2*/) { + if (pmlmepriv->link_detect_info.NumRxUnicastOkInPeriod > 4/*2*/) { if (adapter_to_pwrctl(padapter)->bLeisurePs && (adapter_to_pwrctl(padapter)->pwr_mode !=3D PS_MODE_ACTIVE) && !(hal_btcoex_IsBtControlLps(padapter))) @@ -325,7 +325,7 @@ static u8 PS_RDY_CHECK(struct adapter *padapter) ) return false; =20 - if (padapter->securitypriv.dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_8021X= && + if (padapter->securitypriv.dot11_auth_algrthm =3D=3D dot11_auth_algrthm_8= 021x && !padapter->securitypriv.binstallGrpkey) return false; =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index e893cb6fa273..eb590a28f673 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -380,7 +380,7 @@ static signed int recvframe_chkmic(struct adapter *adap= ter, union recv_frame *p /* rxdata_key_idx =3D(((iv[3])>>6)&0x3) ; */ mickey =3D &psecuritypriv->dot118021XGrprxmickey[prxattrib->key_index]= .skey[0]; =20 - /* psecuritypriv->dot118021XGrpKeyid, pmlmeinfo->key_index, rxdata_key= _idx); */ + /* psecuritypriv->dot11_8021x_grp_key_id, pmlmeinfo->key_index, rxdata= _key_idx); */ =20 if (psecuritypriv->binstallGrpkey =3D=3D false) { res =3D _FAIL; @@ -408,7 +408,7 @@ static signed int recvframe_chkmic(struct adapter *adap= ter, union recv_frame *p =20 if (bmic_err =3D=3D true) { /* double check key_index for some timing issue , */ - /* cannot compare with psecuritypriv->dot118021XGrpKeyid also cause t= iming issue */ + /* cannot compare with psecuritypriv->dot11_8021x_grp_key_id also cau= se timing issue */ if ((is_multicast_ether_addr(prxattrib->ra) =3D=3D true) && (prxattri= b->key_index !=3D pmlmeinfo->key_index)) brpt_micerror =3D false; =20 @@ -452,12 +452,12 @@ static union recv_frame *decryptor(struct adapter *pa= dapter, union recv_frame *p switch (prxattrib->encrypt) { case _WEP40_: case _WEP104_: - prxattrib->key_index =3D psecuritypriv->dot11PrivacyKeyIndex; + prxattrib->key_index =3D psecuritypriv->dot11_privacy_key_index; break; case _TKIP_: case _AES_: default: - prxattrib->key_index =3D psecuritypriv->dot118021XGrpKeyid; + prxattrib->key_index =3D psecuritypriv->dot11_8021x_grp_key_id; break; } } @@ -512,7 +512,7 @@ static union recv_frame *portctrl(struct adapter *adapt= er, union recv_frame *pre =20 pstapriv =3D &adapter->stapriv; =20 - auth_alg =3D adapter->securitypriv.dot11AuthAlgrthm; + auth_alg =3D adapter->securitypriv.dot11_auth_algrthm; =20 ptr =3D precv_frame->u.hdr.rx_data; pfhdr =3D &precv_frame->u.hdr; @@ -680,10 +680,10 @@ static void count_rx_stats(struct adapter *padapter, = union recv_frame *prframe, sz =3D get_recvframe_len(prframe); precvpriv->rx_bytes +=3D sz; =20 - padapter->mlmepriv.LinkDetectInfo.NumRxOkInPeriod++; + padapter->mlmepriv.link_detect_info.NumRxOkInPeriod++; =20 if ((!is_broadcast_ether_addr(pattrib->dst)) && (!is_multicast_ether_addr= (pattrib->dst))) - padapter->mlmepriv.LinkDetectInfo.NumRxUnicastOkInPeriod++; + padapter->mlmepriv.link_detect_info.NumRxUnicastOkInPeriod++; =20 if (sta) psta =3D sta; @@ -840,7 +840,7 @@ static signed int ap2sta_data_frame(struct adapter *ada= pter, union recv_frame *p goto exit; } =20 - if (GetFrameSubType(ptr) & BIT(6)) { + if (get_frame_sub_type(ptr) & BIT(6)) { /* No data, will not indicate to upper layer, temporily count it here */ count_rx_stats(adapter, precv_frame, *psta); ret =3D RTW_RX_HANDLED; @@ -920,10 +920,10 @@ static signed int sta2ap_data_frame(struct adapter *a= dapter, union recv_frame *p =20 process_pwrbit_data(adapter, precv_frame); =20 - if ((GetFrameSubType(ptr) & WIFI_QOS_DATA_TYPE) =3D=3D WIFI_QOS_DATA_TYP= E) + if ((get_frame_sub_type(ptr) & WIFI_QOS_DATA_TYPE) =3D=3D WIFI_QOS_DATA_= TYPE) process_wmmps_data(adapter, precv_frame); =20 - if (GetFrameSubType(ptr) & BIT(6)) { + if (get_frame_sub_type(ptr) & BIT(6)) { /* No data, will not indicate to upper layer, temporily count it here */ count_rx_stats(adapter, precv_frame, *psta); ret =3D RTW_RX_HANDLED; @@ -968,7 +968,7 @@ static signed int validate_recv_ctrl_frame(struct adapt= er *padapter, union recv_ psta->sta_stats.rx_ctrl_pkts++; =20 /* only handle ps-poll */ - if (GetFrameSubType(pframe) =3D=3D WIFI_PSPOLL) { + if (get_frame_sub_type(pframe) =3D=3D WIFI_PSPOLL) { u16 aid; u8 wmmps_ac =3D 0; =20 @@ -1261,11 +1261,11 @@ static signed int validate_recv_mgnt_frame(struct a= dapter *padapter, union recv_ =20 if (psta) { psta->sta_stats.rx_mgnt_pkts++; - if (GetFrameSubType(precv_frame->u.hdr.rx_data) =3D=3D WIFI_BEACON) + if (get_frame_sub_type(precv_frame->u.hdr.rx_data) =3D=3D WIFI_BEACON) psta->sta_stats.rx_beacon_pkts++; - else if (GetFrameSubType(precv_frame->u.hdr.rx_data) =3D=3D WIFI_PROBER= EQ) + else if (get_frame_sub_type(precv_frame->u.hdr.rx_data) =3D=3D WIFI_PRO= BEREQ) psta->sta_stats.rx_probereq_pkts++; - else if (GetFrameSubType(precv_frame->u.hdr.rx_data) =3D=3D WIFI_PROBER= SP) { + else if (get_frame_sub_type(precv_frame->u.hdr.rx_data) =3D=3D WIFI_PRO= BERSP) { if (!memcmp(padapter->eeprompriv.mac_addr, GetAddr1Ptr(precv_frame->u.= hdr.rx_data), ETH_ALEN)) psta->sta_stats.rx_probersp_pkts++; else if (is_broadcast_mac_addr(GetAddr1Ptr(precv_frame->u.hdr.rx_data)= ) || @@ -1405,11 +1405,11 @@ static signed int validate_80211w_mgmt(struct adapt= er *adapter, union recv_frame u8 *ptr =3D precv_frame->u.hdr.rx_data; u8 subtype; =20 - subtype =3D GetFrameSubType(ptr); /* bit(7)~bit(2) */ + subtype =3D get_frame_sub_type(ptr); /* bit(7)~bit(2) */ =20 /* only support station mode */ if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) && check_fwstate(pmlmepr= iv, _FW_LINKED) && - adapter->securitypriv.binstallBIPkey =3D=3D true) { + adapter->securitypriv.b_install_bip_key =3D=3D true) { /* unicast management frame decrypt */ if (pattrib->privacy && !(is_multicast_ether_addr(GetAddr1Ptr(ptr))) && (subtype =3D=3D WIFI_DEAUTH || subtype =3D=3D WIFI_DISASSOC || subtype = =3D=3D WIFI_ACTION)) { @@ -1497,7 +1497,7 @@ static signed int validate_recv_frame(struct adapter = *adapter, union recv_frame } =20 type =3D GetFrameType(ptr); - subtype =3D GetFrameSubType(ptr); /* bit(7)~bit(2) */ + subtype =3D get_frame_sub_type(ptr); /* bit(7)~bit(2) */ =20 pattrib->to_fr_ds =3D get_tofr_ds(ptr); =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/stagin= g/rtl8723bs/core/rtw_security.c index 2f941ffbd465..32a5512d87e9 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -57,12 +57,12 @@ void rtw_wep_encrypt(struct adapter *padapter, u8 *pxmi= tframe) =20 /* start to encrypt each fragment */ if ((pattrib->encrypt =3D=3D _WEP40_) || (pattrib->encrypt =3D=3D _WEP104= _)) { - keylength =3D psecuritypriv->dot11DefKeylen[psecuritypriv->dot11PrivacyK= eyIndex]; + keylength =3D psecuritypriv->dot11DefKeylen[psecuritypriv->dot11_privacy= _key_index]; =20 for (curfragnum =3D 0; curfragnum < pattrib->nr_frags; curfragnum++) { iv =3D pframe + pattrib->hdrlen; memcpy(&wepkey[0], iv, 3); - memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[psecuritypriv->dot11Priv= acyKeyIndex].skey[0], keylength); + memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[psecuritypriv->dot11_pri= vacy_key_index].skey[0], keylength); payload =3D pframe + pattrib->iv_len + pattrib->hdrlen; =20 if ((curfragnum + 1) =3D=3D pattrib->nr_frags) { /* the last fragment */ @@ -110,7 +110,7 @@ void rtw_wep_decrypt(struct adapter *padapter, u8 *pre= cvframe) keyindex =3D prxattrib->key_index; keylength =3D psecuritypriv->dot11DefKeylen[keyindex]; memcpy(&wepkey[0], iv, 3); - /* memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[psecuritypriv->dot11Pr= ivacyKeyIndex].skey[0], keylength); */ + /* memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[psecuritypriv->dot11_p= rivacy_key_index].skey[0], keylength); */ memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[keyindex].skey[0], keylen= gth); length =3D ((union recv_frame *)precvframe)->u.hdr.len - prxattrib->hdrl= en - prxattrib->iv_len; =20 @@ -479,9 +479,9 @@ u32 rtw_tkip_encrypt(struct adapter *padapter, u8 *pxmi= tframe) =20 { if (is_multicast_ether_addr(pattrib->ra)) - prwskey =3D psecuritypriv->dot118021XGrpKey[psecuritypriv->dot118021XG= rpKeyid].skey; + prwskey =3D psecuritypriv->dot118021XGrpKey[psecuritypriv->dot11_8021x= _grp_key_id].skey; else - prwskey =3D pattrib->dot118021x_UncstKey.skey; + prwskey =3D pattrib->dot11_8021x_uncst_key.skey; =20 for (curfragnum =3D 0; curfragnum < pattrib->nr_frags; curfragnum++) { iv =3D pframe + pattrib->hdrlen; @@ -590,7 +590,7 @@ u32 rtw_tkip_decrypt(struct adapter *padapter, u8 *prec= vframe) =20 prwskey =3D psecuritypriv->dot118021XGrpKey[prxattrib->key_index].skey; } else { - prwskey =3D &stainfo->dot118021x_UncstKey.skey[0]; + prwskey =3D &stainfo->dot11_8021x_uncst_key.skey[0]; } =20 iv =3D pframe + prxattrib->hdrlen; @@ -829,7 +829,7 @@ static signed int aes_cipher(u8 *key, uint hdrlen, u8 padded_buffer[16] =3D {}; u8 mic[8]; uint frtype =3D GetFrameType(pframe); - uint frsubtype =3D GetFrameSubType(pframe); + uint frsubtype =3D get_frame_sub_type(pframe); =20 frsubtype =3D frsubtype >> 4; =20 @@ -993,9 +993,9 @@ u32 rtw_aes_encrypt(struct adapter *padapter, u8 *pxmit= frame) /* 4 start to encrypt each fragment */ if (pattrib->encrypt =3D=3D _AES_) { if (is_multicast_ether_addr(pattrib->ra)) - prwskey =3D psecuritypriv->dot118021XGrpKey[psecuritypriv->dot118021XGr= pKeyid].skey; + prwskey =3D psecuritypriv->dot118021XGrpKey[psecuritypriv->dot11_8021x_= grp_key_id].skey; else - prwskey =3D pattrib->dot118021x_UncstKey.skey; + prwskey =3D pattrib->dot11_8021x_uncst_key.skey; =20 for (curfragnum =3D 0; curfragnum < pattrib->nr_frags; curfragnum++) { if ((curfragnum + 1) =3D=3D pattrib->nr_frags) { /* 4 the last fragment= */ @@ -1034,7 +1034,7 @@ static signed int aes_decipher(u8 *key, uint hdrlen, u8 mic[8]; =20 uint frtype =3D GetFrameType(pframe); - uint frsubtype =3D GetFrameSubType(pframe); + uint frsubtype =3D get_frame_sub_type(pframe); =20 frsubtype =3D frsubtype >> 4; =20 @@ -1282,12 +1282,12 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *p= recvframe) no_gkey_mc_cnt =3D 0; =20 prwskey =3D psecuritypriv->dot118021XGrpKey[prxattrib->key_index].skey; - if (psecuritypriv->dot118021XGrpKeyid !=3D prxattrib->key_index) { + if (psecuritypriv->dot11_8021x_grp_key_id !=3D prxattrib->key_index) { res =3D _FAIL; goto exit; } } else { - prwskey =3D &stainfo->dot118021x_UncstKey.skey[0]; + prwskey =3D &stainfo->dot11_8021x_uncst_key.skey[0]; } =20 length =3D ((union recv_frame *)precvframe)->u.hdr.len - prxattrib->hdr= len - prxattrib->iv_len; @@ -1343,7 +1343,7 @@ u32 rtw_BIP_verify(struct adapter *padapter, u8 *prec= vframe) /* copy key index */ memcpy(&le_tmp, p + 2, 2); keyid =3D le16_to_cpu(le_tmp); - if (keyid !=3D padapter->securitypriv.dot11wBIPKeyid) + if (keyid !=3D padapter->securitypriv.dot11w_bip_key_id) goto BIP_exit; =20 /* clear the MIC field of MME to zero */ @@ -1351,13 +1351,13 @@ u32 rtw_BIP_verify(struct adapter *padapter, u8 *pr= ecvframe) =20 /* conscruct AAD, copy frame control field */ memcpy(BIP_AAD, &pwlanhdr->frame_control, 2); - ClearRetry(BIP_AAD); - ClearPwrMgt(BIP_AAD); - ClearMData(BIP_AAD); + clear_retry(BIP_AAD); + clear_pwr_mgt(BIP_AAD); + clear_m_data(BIP_AAD); /* conscruct AAD, copy address 1 to address 3 */ memcpy(BIP_AAD + 2, &pwlanhdr->addrs, sizeof(pwlanhdr->addrs)); =20 - if (omac1_aes_128(padapter->securitypriv.dot11wBIPKey[padapter->security= priv.dot11wBIPKeyid].skey + if (omac1_aes_128(padapter->securitypriv.dot11w_bip_key[padapter->securi= typriv.dot11w_bip_key_id].skey , BIP_AAD, ori_len, mic)) goto BIP_exit; =20 @@ -1488,10 +1488,10 @@ void rtw_sec_restore_wep_key(struct adapter *adapte= r) struct security_priv *securitypriv =3D &(adapter->securitypriv); signed int keyid; =20 - if ((_WEP40_ =3D=3D securitypriv->dot11PrivacyAlgrthm) || (_WEP104_ =3D= =3D securitypriv->dot11PrivacyAlgrthm)) { + if ((_WEP40_ =3D=3D securitypriv->dot11_privacy_algrthm) || (_WEP104_ =3D= =3D securitypriv->dot11_privacy_algrthm)) { for (keyid =3D 0; keyid < 4; keyid++) { if (securitypriv->key_mask & BIT(keyid)) { - if (keyid =3D=3D securitypriv->dot11PrivacyKeyIndex) + if (keyid =3D=3D securitypriv->dot11_privacy_key_index) rtw_set_key(adapter, securitypriv, keyid, 1, false); else rtw_set_key(adapter, securitypriv, keyid, 0, false); diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 5ffefa50699e..4366f5c2b930 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -1141,7 +1141,7 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *p= frame, u32 packet_len) pmlmepriv->NumOfBcnInfoChkFail =3D 0; } =20 - subtype =3D GetFrameSubType(pframe) >> 4; + subtype =3D get_frame_sub_type(pframe) >> 4; =20 if (subtype =3D=3D WIFI_BEACON) bssid->reserved[0] =3D 1; diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index fd25289111e3..418ca141e656 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -384,7 +384,7 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * while (true) { /* IOT action */ if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && (pattrib= ->ampdu_en) && - (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_)) { + (padapter->securitypriv.dot11_privacy_algrthm =3D=3D _AES_)) { pattrib->vcs_mode =3D CTS_TO_SELF; break; } @@ -477,7 +477,7 @@ static s32 update_attrib_sec_info(struct adapter *padap= ter, struct pkt_attrib *p struct security_priv *psecuritypriv =3D &padapter->securitypriv; signed int bmcast =3D is_multicast_ether_addr(pattrib->ra); =20 - memset(pattrib->dot118021x_UncstKey.skey, 0, 16); + memset(pattrib->dot11_8021x_uncst_key.skey, 0, 16); memset(pattrib->dot11tkiptxmickey.skey, 0, 16); pattrib->mac_id =3D psta->mac_id; =20 @@ -491,15 +491,15 @@ static s32 update_attrib_sec_info(struct adapter *pad= apter, struct pkt_attrib *p } else { GET_ENCRY_ALGO(psecuritypriv, psta, pattrib->encrypt, bmcast); =20 - switch (psecuritypriv->dot11AuthAlgrthm) { - case dot11AuthAlgrthm_Open: - case dot11AuthAlgrthm_Shared: - case dot11AuthAlgrthm_Auto: - pattrib->key_idx =3D (u8)psecuritypriv->dot11PrivacyKeyIndex; + switch (psecuritypriv->dot11_auth_algrthm) { + case dot11_auth_algrthm_open: + case dot11_auth_algrthm_shared: + case dot11_auth_algrthm_auto: + pattrib->key_idx =3D (u8)psecuritypriv->dot11_privacy_key_index; break; - case dot11AuthAlgrthm_8021X: + case dot11_auth_algrthm_8021x: if (bmcast) - pattrib->key_idx =3D (u8)psecuritypriv->dot118021XGrpKeyid; + pattrib->key_idx =3D (u8)psecuritypriv->dot11_8021x_grp_key_id; else pattrib->key_idx =3D 0; break; @@ -558,7 +558,7 @@ static s32 update_attrib_sec_info(struct adapter *padap= ter, struct pkt_attrib *p } =20 if (pattrib->encrypt > 0) - memcpy(pattrib->dot118021x_UncstKey.skey, psta->dot118021x_UncstKey.skey= , 16); + memcpy(pattrib->dot11_8021x_uncst_key.skey, psta->dot11_8021x_uncst_key.= skey, 16); =20 if (pattrib->encrypt && ((padapter->securitypriv.sw_encrypt) || (!psecuritypriv->hw_decrypted))) @@ -779,10 +779,10 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr pframe =3D pxmitframe->buf_addr + hw_hdr_offset; =20 if (bmcst) { - if (!memcmp(psecuritypriv->dot118021XGrptxmickey[psecuritypriv->dot118= 021XGrpKeyid].skey, null_key, 16)) + if (!memcmp(psecuritypriv->dot11_8021x_grp_tx_mickey[psecuritypriv->do= t11_8021x_grp_key_id].skey, null_key, 16)) return _FAIL; /* start to calculate the mic code */ - rtw_secmicsetkey(&micdata, psecuritypriv->dot118021XGrptxmickey[psecur= itypriv->dot118021XGrpKeyid].skey); + rtw_secmicsetkey(&micdata, psecuritypriv->dot11_8021x_grp_tx_mickey[ps= ecuritypriv->dot11_8021x_grp_key_id].skey); } else { if (!memcmp(&pattrib->dot11tkiptxmickey.skey[0], null_key, 16)) return _FAIL; @@ -872,7 +872,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr =20 memset(hdr, 0, WLANHDR_OFFSET); =20 - SetFrameSubType(fctrl, pattrib->subtype); + set_frame_sub_type(fctrl, pattrib->subtype); =20 if (pattrib->subtype & WIFI_DATA_TYPE) { if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { @@ -881,7 +881,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr { /* 1.Data transfer to AP */ /* 2.Arp pkt will relayed by AP */ - SetToDs(fctrl); + set_to_ds(fctrl); memcpy(pwlanhdr->addr1, get_bssid(pmlmepriv), ETH_ALEN); memcpy(pwlanhdr->addr2, pattrib->src, ETH_ALEN); memcpy(pwlanhdr->addr3, pattrib->dst, ETH_ALEN); @@ -891,7 +891,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr qos_option =3D true; } else if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { /* to_ds =3D 0, fr_ds =3D 1; */ - SetFrDs(fctrl); + set_fr_ds(fctrl); memcpy(pwlanhdr->addr1, pattrib->dst, ETH_ALEN); memcpy(pwlanhdr->addr2, get_bssid(pmlmepriv), ETH_ALEN); memcpy(pwlanhdr->addr3, pattrib->src, ETH_ALEN); @@ -912,20 +912,20 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hd= r, struct pkt_attrib *pattr } =20 if (pattrib->mdata) - SetMData(fctrl); + set_m_data(fctrl); =20 if (pattrib->encrypt) - SetPrivacy(fctrl); + set_privacy(fctrl); =20 if (qos_option) { qc =3D (unsigned short *)(hdr + pattrib->hdrlen - 2); =20 if (pattrib->priority) - SetPriority(qc, pattrib->priority); + set_priority(qc, pattrib->priority); =20 - SetEOSP(qc, pattrib->eosp); + set_eosp(qc, pattrib->eosp); =20 - SetAckpolicy(qc, pattrib->ack_policy); + set_ack_policy(qc, pattrib->ack_policy); } =20 /* TODO: fill HT Control Field */ @@ -949,7 +949,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr,= struct pkt_attrib *pattr psta->sta_xmitpriv.txseq_tid[pattrib->priority] %=3D 4096u; pattrib->seqnum =3D psta->sta_xmitpriv.txseq_tid[pattrib->priority]; =20 - SetSeqNum(hdr, pattrib->seqnum); + set_seq_num(hdr, pattrib->seqnum); =20 /* check if enable ampdu */ if (pattrib->ht_en && psta->htpriv.ampdu_enable) @@ -1069,7 +1069,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct =20 pframe =3D mem_start; =20 - SetMFrag(mem_start); + set_m_frag(mem_start); =20 pframe +=3D pattrib->hdrlen; mpdu_len -=3D pattrib->hdrlen; @@ -1114,7 +1114,7 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + ((pattrib= ->nr_frags =3D=3D 1) ? llc_sz : 0) + ((pattrib->bswenc) ? pattrib->icv_len : 0) + mem_sz; =20 - ClearMFrag(mem_start); + clear_m_frag(mem_start); =20 break; } @@ -1165,7 +1165,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s ori_len =3D BIP_AAD_SIZE + pattrib->pktlen; tmp_buf =3D rtw_zmalloc(ori_len); BIP_AAD =3D rtw_zmalloc(ori_len); - subtype =3D GetFrameSubType(pframe); /* bit(7)~bit(2) */ + subtype =3D get_frame_sub_type(pframe); /* bit(7)~bit(2) */ =20 if (!BIP_AAD) return _FAIL; @@ -1177,7 +1177,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s goto xmitframe_coalesce_success; =20 /* IGTK key is not install, it may not support 802.11w */ - if (!padapter->securitypriv.binstallBIPkey) + if (!padapter->securitypriv.b_install_bip_key) goto xmitframe_coalesce_success; =20 /* station mode doesn't need TX BIP, just ready the code */ @@ -1188,14 +1188,14 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s memset(MME, 0, 18); =20 /* other types doesn't need the BIP */ - if (GetFrameSubType(pframe) !=3D WIFI_DEAUTH && GetFrameSubType(pframe) = !=3D WIFI_DISASSOC) + if (get_frame_sub_type(pframe) !=3D WIFI_DEAUTH && get_frame_sub_type(pf= rame) !=3D WIFI_DISASSOC) goto xmitframe_coalesce_fail; =20 MGMT_body =3D pframe + sizeof(struct ieee80211_hdr_3addr); pframe +=3D pattrib->pktlen; =20 /* octent 0 and 1 is key index , BIP keyid is 4 or 5, LSB only need octe= nt 0 */ - MME[0] =3D padapter->securitypriv.dot11wBIPKeyid; + MME[0] =3D padapter->securitypriv.dot11w_bip_key_id; /* copy packet number */ memcpy(&MME[2], &pmlmeext->mgnt_80211w_IPN, 6); /* increase the packet number */ @@ -1210,15 +1210,15 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s =20 /* conscruct AAD, copy frame control field */ memcpy(BIP_AAD, &pwlanhdr->frame_control, 2); - ClearRetry(BIP_AAD); - ClearPwrMgt(BIP_AAD); - ClearMData(BIP_AAD); + clear_retry(BIP_AAD); + clear_pwr_mgt(BIP_AAD); + clear_m_data(BIP_AAD); /* conscruct AAD, copy address 1 to address 3 */ memcpy(BIP_AAD + 2, &pwlanhdr->addrs, sizeof(pwlanhdr->addrs)); /* copy management fram body */ memcpy(BIP_AAD + BIP_AAD_SIZE, MGMT_body, frame_body_len); /* calculate mic */ - if (omac1_aes_128(padapter->securitypriv.dot11wBIPKey[padapter->security= priv.dot11wBIPKeyid].skey + if (omac1_aes_128(padapter->securitypriv.dot11w_bip_key[padapter->securi= typriv.dot11w_bip_key_id].skey , BIP_AAD, BIP_AAD_SIZE + frame_body_len, mic)) goto xmitframe_coalesce_fail; =20 @@ -1249,7 +1249,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s goto xmitframe_coalesce_fail; /* before encrypt dump the management packet content */ if (pattrib->encrypt > 0) - memcpy(pattrib->dot118021x_UncstKey.skey, psta->dot118021x_UncstKey.sk= ey, 16); + memcpy(pattrib->dot11_8021x_uncst_key.skey, psta->dot11_8021x_uncst_ke= y.skey, 16); /* bakeup original management packet */ memcpy(tmp_buf, pframe, pattrib->pktlen); /* move to data portion */ @@ -1287,7 +1287,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s pattrib->last_txcmdsz =3D pattrib->pktlen; =20 /* set protected bit must be beofre SW encrypt */ - SetPrivacy(mem_start); + set_privacy(mem_start); /* software encrypt */ xmitframe_swencrypt(padapter, pxmitframe); } @@ -1383,7 +1383,7 @@ void rtw_count_tx_stats(struct adapter *padapter, str= uct xmit_frame *pxmitframe, if ((pxmitframe->frame_tag & 0x0f) =3D=3D DATA_FRAMETAG) { pkt_num =3D pxmitframe->agg_num; =20 - pmlmepriv->LinkDetectInfo.NumTxOkInPeriod +=3D pkt_num; + pmlmepriv->link_detect_info.num_tx_ok_in_period +=3D pkt_num; =20 pxmitpriv->tx_pkts +=3D pkt_num; =20 @@ -2451,7 +2451,7 @@ struct xmit_buf *dequeue_pending_xmitbuf_under_survey= (struct xmit_priv *pxmitpri =20 pxmitbuf =3D container_of(plist, struct xmit_buf, list); =20 - type =3D GetFrameSubType(pxmitbuf->pbuf + TXDESC_OFFSET); + type =3D get_frame_sub_type(pxmitbuf->pbuf + TXDESC_OFFSET); =20 if ((type =3D=3D WIFI_PROBEREQ) || (type =3D=3D WIFI_DATA_NULL) || diff --git a/drivers/staging/rtl8723bs/hal/hal_btcoex.c b/drivers/staging/r= tl8723bs/hal/hal_btcoex.c index 9105594d2dde..47aabfc527f4 100644 --- a/drivers/staging/rtl8723bs/hal/hal_btcoex.c +++ b/drivers/staging/rtl8723bs/hal/hal_btcoex.c @@ -167,7 +167,7 @@ static u8 halbtcoutsrc_IsWifiBusy(struct adapter *padap= ter) if (check_fwstate(pmlmepriv, WIFI_ASOC_STATE) =3D=3D true) { if (check_fwstate(pmlmepriv, WIFI_AP_STATE) =3D=3D true) return true; - if (pmlmepriv->LinkDetectInfo.bBusyTraffic) + if (pmlmepriv->link_detect_info.bBusyTraffic) return true; } =20 @@ -325,7 +325,7 @@ static u8 halbtcoutsrc_Get(void *pBtcContext, u8 getTyp= e, void *pOutBuf) break; =20 case BTC_GET_BL_WIFI_ENABLE_ENCRYPTION: - *pu8 =3D padapter->securitypriv.dot11PrivacyAlgrthm !=3D 0; + *pu8 =3D padapter->securitypriv.dot11_privacy_algrthm !=3D 0; break; =20 case BTC_GET_BL_WIFI_UNDER_B_MODE: @@ -364,9 +364,9 @@ static u8 halbtcoutsrc_Get(void *pBtcContext, u8 getTyp= e, void *pOutBuf) case BTC_GET_U4_WIFI_TRAFFIC_DIRECTION: { struct rt_link_detect_t *plinkinfo; - plinkinfo =3D &padapter->mlmepriv.LinkDetectInfo; + plinkinfo =3D &padapter->mlmepriv.link_detect_info; =20 - if (plinkinfo->NumTxOkInPeriod > plinkinfo->NumRxOkInPeriod) + if (plinkinfo->num_tx_ok_in_period > plinkinfo->NumRxOkInPeriod) *pU4Tmp =3D BTC_WIFI_TRAFFIC_TX; else *pU4Tmp =3D BTC_WIFI_TRAFFIC_RX; diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 70b5b289f9cb..ab65bd2ae2b3 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -593,7 +593,7 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 = *val) =20 if (val) { /* Enable default key related setting */ reg_scr |=3D SCR_TXBCUSEDK; - if (sec->dot11AuthAlgrthm !=3D dot11AuthAlgrthm_8021X) + if (sec->dot11_auth_algrthm !=3D dot11_auth_algrthm_8021x) reg_scr |=3D (SCR_RxUseDK|SCR_TxUseDK); } else /* Disable default key related setting */ reg_scr &=3D ~(SCR_RXBCUSEDK|SCR_TXBCUSEDK|SCR_RxUseDK|SCR_TxUseDK); diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 462553d296ff..97dcb9a84cf8 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -160,7 +160,7 @@ s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct = xmit_frame *pmgntframe) /* pwlanhdr =3D (struct rtw_ieee80211_hdr *)pframe; */ /* memcpy(pmgntframe->attrib.ra, pwlanhdr->addr1, ETH_ALEN); */ =20 - if (padapter->securitypriv.binstallBIPkey =3D=3D true) { + if (padapter->securitypriv.b_install_bip_key =3D=3D true) { if (is_multicast_ether_addr(pmgntframe->attrib.ra)) { pmgntframe->attrib.encrypt =3D _BIP_; /* pmgntframe->attrib.bswenc =3D true; */ diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging= /rtl8723bs/hal/rtl8723b_cmd.c index af6cdda8238d..be2755e6059a 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c @@ -121,9 +121,9 @@ static void ConstructBeacon(struct adapter *padapter, u= 8 *pframe, u32 *pLength) ether_addr_copy(pwlanhdr->addr2, myid(&(padapter->eeprompriv))); ether_addr_copy(pwlanhdr->addr3, get_my_bssid(cur_network)); =20 - SetSeqNum(pwlanhdr, 0/*pmlmeext->mgnt_seq*/); + set_seq_num(pwlanhdr, 0/*pmlmeext->mgnt_seq*/); /* pmlmeext->mgnt_seq++; */ - SetFrameSubType(pframe, WIFI_BEACON); + set_frame_sub_type(pframe, WIFI_BEACON); =20 pframe +=3D sizeof(struct ieee80211_hdr_3addr); pktlen =3D sizeof(struct ieee80211_hdr_3addr); @@ -204,7 +204,7 @@ static void ConstructPSPoll(struct adapter *padapter, u= 8 *pframe, u32 *pLength) fctrl =3D &(pwlanhdr->frame_control); *(fctrl) =3D 0; SetPwrMgt(fctrl); - SetFrameSubType(pframe, WIFI_PSPOLL); + set_frame_sub_type(pframe, WIFI_PSPOLL); =20 /* AID. */ SetDuration(pframe, (pmlmeinfo->aid | 0xc000)); @@ -246,13 +246,13 @@ static void ConstructNullFunctionData( =20 switch (cur_network->network.infrastructure_mode) { case Ndis802_11Infrastructure: - SetToDs(fctrl); + set_to_ds(fctrl); ether_addr_copy(pwlanhdr->addr1, get_my_bssid(&(pmlmeinfo->network))); ether_addr_copy(pwlanhdr->addr2, myid(&(padapter->eeprompriv))); ether_addr_copy(pwlanhdr->addr3, StaAddr); break; case Ndis802_11APMode: - SetFrDs(fctrl); + set_fr_ds(fctrl); ether_addr_copy(pwlanhdr->addr1, StaAddr); ether_addr_copy(pwlanhdr->addr2, get_my_bssid(&(pmlmeinfo->network))); ether_addr_copy(pwlanhdr->addr3, myid(&(padapter->eeprompriv))); @@ -265,20 +265,20 @@ static void ConstructNullFunctionData( break; } =20 - SetSeqNum(pwlanhdr, 0); + set_seq_num(pwlanhdr, 0); =20 if (bQoS) { struct ieee80211_qos_hdr *pwlanqoshdr; =20 - SetFrameSubType(pframe, WIFI_QOS_DATA_NULL); + set_frame_sub_type(pframe, WIFI_QOS_DATA_NULL); =20 pwlanqoshdr =3D (struct ieee80211_qos_hdr *)pframe; - SetPriority(&pwlanqoshdr->qos_ctrl, AC); - SetEOSP(&pwlanqoshdr->qos_ctrl, bEosp); + set_priority(&pwlanqoshdr->qos_ctrl, AC); + set_eosp(&pwlanqoshdr->qos_ctrl, bEosp); =20 pktlen =3D sizeof(struct ieee80211_qos_hdr); } else { - SetFrameSubType(pframe, WIFI_DATA_NULL); + set_frame_sub_type(pframe, WIFI_DATA_NULL); =20 pktlen =3D sizeof(struct ieee80211_hdr_3addr); } @@ -765,26 +765,26 @@ static void ConstructBtNullFunctionData( if (bForcePowerSave) SetPwrMgt(fctrl); =20 - SetFrDs(fctrl); + set_fr_ds(fctrl); ether_addr_copy(pwlanhdr->addr1, StaAddr); ether_addr_copy(pwlanhdr->addr2, myid(&padapter->eeprompriv)); ether_addr_copy(pwlanhdr->addr3, myid(&padapter->eeprompriv)); =20 SetDuration(pwlanhdr, 0); - SetSeqNum(pwlanhdr, 0); + set_seq_num(pwlanhdr, 0); =20 if (bQoS) { struct ieee80211_qos_hdr *pwlanqoshdr; =20 - SetFrameSubType(pframe, WIFI_QOS_DATA_NULL); + set_frame_sub_type(pframe, WIFI_QOS_DATA_NULL); =20 pwlanqoshdr =3D (struct ieee80211_qos_hdr *)pframe; - SetPriority(&pwlanqoshdr->qos_ctrl, AC); - SetEOSP(&pwlanqoshdr->qos_ctrl, bEosp); + set_priority(&pwlanqoshdr->qos_ctrl, AC); + set_eosp(&pwlanqoshdr->qos_ctrl, bEosp); =20 pktlen =3D sizeof(struct ieee80211_qos_hdr); } else { - SetFrameSubType(pframe, WIFI_DATA_NULL); + set_frame_sub_type(pframe, WIFI_DATA_NULL); =20 pktlen =3D sizeof(struct ieee80211_hdr_3addr); } diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c b/drivers/staging/= rtl8723bs/hal/rtl8723b_dm.c index 928226679ab4..fd1b8d383ca4 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_dm.c @@ -88,7 +88,7 @@ static void Update_ODM_ComInfo_8723b(struct adapter *Adap= ter) ODM_CmnInfoHook(pDM_Odm, ODM_CMNINFO_RX_UNI, &(dvobj->traffic_stat.rx_byt= es)); ODM_CmnInfoHook(pDM_Odm, ODM_CMNINFO_WM_MODE, &(pmlmeext->cur_wireless_mo= de)); ODM_CmnInfoHook(pDM_Odm, ODM_CMNINFO_SEC_CHNL_OFFSET, &(pHalData->nCur40M= hzPrimeSC)); - ODM_CmnInfoHook(pDM_Odm, ODM_CMNINFO_SEC_MODE, &(Adapter->securitypriv.do= t11PrivacyAlgrthm)); + ODM_CmnInfoHook(pDM_Odm, ODM_CMNINFO_SEC_MODE, &(Adapter->securitypriv.do= t11_privacy_algrthm)); ODM_CmnInfoHook(pDM_Odm, ODM_CMNINFO_BW, &(pHalData->CurrentChannelBW)); ODM_CmnInfoHook(pDM_Odm, ODM_CMNINFO_CHNL, &(pHalData->CurrentChannel)); ODM_CmnInfoHook(pDM_Odm, ODM_CMNINFO_NET_CLOSED, &(Adapter->net_closed)); diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 57c83f332e74..f1b9b58ad26b 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1906,7 +1906,7 @@ void rtl8723b_fill_fake_txdesc( /* Encrypt the data frame if under security mode excepct null data. Sugg= ested by CCW. */ /* */ if (bDataFrame) { - u32 EncAlg =3D padapter->securitypriv.dot11PrivacyAlgrthm; + u32 EncAlg =3D padapter->securitypriv.dot11_privacy_algrthm; =20 switch (EncAlg) { case _NO_PRIVACY_: diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_recv.c index 399edfbf8ec6..554b6e64844f 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c @@ -112,7 +112,7 @@ static void update_recvframe_phyinfo(union recv_frame *= precvframe, =20 =20 pkt_info.is_beacon =3D pkt_info.bssid_match && - (GetFrameSubType(wlanhdr) =3D=3D WIFI_BEACON); + (get_frame_sub_type(wlanhdr) =3D=3D WIFI_BEACON); =20 sa =3D get_ta(wlanhdr); =20 diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index abb6fdfe7e1f..3eded093fcf4 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -202,7 +202,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, st= ruct xmit_priv *pxmitpriv =20 if ( (check_pending_xmitbuf(pxmitpriv)) && - (padapter->mlmepriv.LinkDetectInfo.bHigherBusyTxTraffic) + (padapter->mlmepriv.link_detect_info.bHigherBusyTxTraffic) ) { if ((phwxmit->accnt > 0) && (phwxmit->accnt < 5)) { err =3D -2; @@ -445,7 +445,7 @@ s32 rtl8723bs_mgnt_xmit( =20 pxmitbuf->priv_data =3D NULL; =20 - if (GetFrameSubType(pframe) =3D=3D WIFI_BEACON) { /* dump beacon directly= */ + if (get_frame_sub_type(pframe) =3D=3D WIFI_BEACON) { /* dump beacon direc= tly */ ret =3D rtw_write_port(padapter, pdvobjpriv->Queue2Pipe[pxmitbuf->ff_hwa= ddr], pxmitbuf->len, (u8 *)pxmitbuf); if (ret !=3D _SUCCESS) rtw_sctx_done_err(&pxmitbuf->sctx, RTW_SCTX_DONE_WRITE_PORT_ERR); @@ -482,7 +482,7 @@ s32 rtl8723bs_hal_xmit( (pxmitframe->attrib.ether_type !=3D 0x888e) && (pxmitframe->attrib.dhcp_pkt !=3D 1) ) { - if (padapter->mlmepriv.LinkDetectInfo.bBusyTraffic) + if (padapter->mlmepriv.link_detect_info.bBusyTraffic) rtw_issue_addbareq_cmd(padapter, pxmitframe); } =20 diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging= /rtl8723bs/include/rtw_mlme.h index 2a128568c6df..80500084031c 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme.h @@ -44,12 +44,12 @@ =20 =20 enum { - dot11AuthAlgrthm_Open =3D 0, - dot11AuthAlgrthm_Shared, - dot11AuthAlgrthm_8021X, - dot11AuthAlgrthm_Auto, - dot11AuthAlgrthm_WAPI, - dot11AuthAlgrthm_MaxNum + dot11_auth_algrthm_open =3D 0, + dot11_auth_algrthm_shared, + dot11_auth_algrthm_8021x, + dot11_auth_algrthm_auto, + dot11_auth_algrthm_wapi, + dot11_auth_algrthm_maxnum }; =20 /* Scan type including active and passive scan. */ @@ -93,7 +93,7 @@ struct sitesurvey_ctrl { }; =20 struct rt_link_detect_t { - u32 NumTxOkInPeriod; + u32 num_tx_ok_in_period; u32 NumRxOkInPeriod; u32 NumRxUnicastOkInPeriod; bool bBusyTraffic; @@ -171,7 +171,7 @@ struct mlme_priv { =20 struct ht_priv htpriv; =20 - struct rt_link_detect_t LinkDetectInfo; + struct rt_link_detect_t link_detect_info; struct timer_list dynamic_chk_timer; /* dynamic/periodic check timer */ =20 u8 acm_mask; /* for wmm acm mask */ diff --git a/drivers/staging/rtl8723bs/include/rtw_security.h b/drivers/sta= ging/rtl8723bs/include/rtw_security.h index 32f6d3a5e309..e51820fe6f30 100644 --- a/drivers/staging/rtl8723bs/include/rtw_security.h +++ b/drivers/staging/rtl8723bs/include/rtw_security.h @@ -91,24 +91,24 @@ struct rt_pmkid_list { =20 =20 struct security_priv { - u32 dot11AuthAlgrthm; /* 802.11 auth, could be open, shared, 8021x an= d authswitch */ - u32 dot11PrivacyAlgrthm; /* This specify the privacy for shared auth. = algorithm. */ + u32 dot11_auth_algrthm; /* 802.11 auth, could be open, shared, 8021x = and authswitch */ + u32 dot11_privacy_algrthm; /* This specify the privacy for shared auth= . algorithm. */ =20 /* WEP */ - u32 dot11PrivacyKeyIndex; /* this is only valid for legendary wep, 0~3= for key id. (tx key index) */ + u32 dot11_privacy_key_index; /* this is only valid for legendary wep, = 0~3 for key id. (tx key index) */ union Keytype dot11DefKey[4]; /* this is only valid for def. key */ u32 dot11DefKeylen[4]; u8 key_mask; /* use to restore wep key after hal_init */ =20 - u32 dot118021XGrpPrivacy; /* This specify the privacy algthm. used for G= rp key */ - u32 dot118021XGrpKeyid; /* key id used for Grp Key (tx key index) */ + u32 dot11_8021x_grp_privacy; /* This specify the privacy algthm. used fo= r Grp key */ + u32 dot11_8021x_grp_key_id; /* key id used for Grp Key (tx key index) */ union Keytype dot118021XGrpKey[BIP_MAX_KEYID + 1]; /* 802.1x Group Key, = for inx0 and inx1 */ - union Keytype dot118021XGrptxmickey[BIP_MAX_KEYID + 1]; + union Keytype dot11_8021x_grp_tx_mickey[BIP_MAX_KEYID + 1]; union Keytype dot118021XGrprxmickey[BIP_MAX_KEYID + 1]; union pn48 dot11Grptxpn; /* PN48 used for Grp Key xmit. */ union pn48 dot11Grprxpn; /* PN48 used for Grp Key recv. */ - u32 dot11wBIPKeyid; /* key id used for BIP Key (tx key index) */ - union Keytype dot11wBIPKey[BIP_MAX_KEYID + 1]; /* BIP Key, for index4 an= d index5 */ + u32 dot11w_bip_key_id; /* key id used for BIP Key (tx key index) */ + union Keytype dot11w_bip_key[BIP_MAX_KEYID + 1]; /* BIP Key, for index4 = and index5 */ union pn48 dot11wBIPtxpn; /* PN48 used for Grp Key xmit. */ union pn48 dot11wBIPrxpn; /* PN48 used for Grp Key recv. */ =20 @@ -127,7 +127,7 @@ struct security_priv { struct arc4_ctx recv_arc4_ctx; =20 u8 binstallGrpkey; - u8 binstallBIPkey; + u8 b_install_bip_key; u8 busetkipkey; /* _timer tkip_timer; */ u8 bcheck_grpkey; @@ -170,20 +170,20 @@ struct security_priv { =20 #define GET_ENCRY_ALGO(psecuritypriv, psta, encry_algo, bmcst)\ do {\ - switch (psecuritypriv->dot11AuthAlgrthm) {\ - case dot11AuthAlgrthm_Open:\ - case dot11AuthAlgrthm_Shared:\ - case dot11AuthAlgrthm_Auto:\ - encry_algo =3D (u8)psecuritypriv->dot11PrivacyAlgrthm;\ + switch (psecuritypriv->dot11_auth_algrthm) {\ + case dot11_auth_algrthm_open:\ + case dot11_auth_algrthm_shared:\ + case dot11_auth_algrthm_auto:\ + encry_algo =3D (u8)psecuritypriv->dot11_privacy_algrthm;\ break;\ - case dot11AuthAlgrthm_8021X:\ + case dot11_auth_algrthm_8021x:\ if (bmcst)\ - encry_algo =3D (u8)psecuritypriv->dot118021XGrpPrivacy;\ + encry_algo =3D (u8)psecuritypriv->dot11_8021x_grp_privacy;\ else\ encry_algo =3D (u8)psta->dot118021XPrivacy;\ break;\ - case dot11AuthAlgrthm_WAPI:\ - encry_algo =3D (u8)psecuritypriv->dot11PrivacyAlgrthm;\ + case dot11_auth_algrthm_wapi:\ + encry_algo =3D (u8)psecuritypriv->dot11_privacy_algrthm;\ break;\ } \ } while (0) diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging= /rtl8723bs/include/rtw_xmit.h index 544468f57692..a26d23cff3da 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -181,7 +181,7 @@ struct pkt_attrib { u8 cts2self; union Keytype dot11tkiptxmickey; /* union Keytype dot11tkiprxmickey; */ - union Keytype dot118021x_UncstKey; + union Keytype dot11_8021x_uncst_key; =20 u8 icmp_pkt; =20 diff --git a/drivers/staging/rtl8723bs/include/sta_info.h b/drivers/staging= /rtl8723bs/include/sta_info.h index 63343998266a..1f15cba25de3 100644 --- a/drivers/staging/rtl8723bs/include/sta_info.h +++ b/drivers/staging/rtl8723bs/include/sta_info.h @@ -90,7 +90,7 @@ struct sta_info { uint dot118021XPrivacy; /* aes, tkip... */ union Keytype dot11tkiptxmickey; union Keytype dot11tkiprxmickey; - union Keytype dot118021x_UncstKey; + union Keytype dot11_8021x_uncst_key; union pn48 dot11txpn; /* PN48 used for Unicast xmit */ union pn48 dot11wtxpn; /* PN48 used for Unicast mgmt xmit. */ union pn48 dot11rxpn; /* PN48 used for Unicast recv. */ diff --git a/drivers/staging/rtl8723bs/include/wifi.h b/drivers/staging/rtl= 8723bs/include/wifi.h index 230b2c4ffd3b..ba2872f8482f 100644 --- a/drivers/staging/rtl8723bs/include/wifi.h +++ b/drivers/staging/rtl8723bs/include/wifi.h @@ -70,29 +70,29 @@ enum { #define _PRIVACY_ BIT(14) #define _ORDER_ BIT(15) =20 -#define SetToDs(pbuf) \ +#define set_to_ds(pbuf) \ (*(__le16 *)(pbuf) |=3D cpu_to_le16(_TO_DS_)) =20 #define GetToDs(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_TO_DS_)) !=3D 0) =20 -#define SetFrDs(pbuf) \ +#define set_fr_ds(pbuf) \ (*(__le16 *)(pbuf) |=3D cpu_to_le16(_FROM_DS_)) =20 #define GetFrDs(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_FROM_DS_)) !=3D= 0) =20 #define get_tofr_ds(pframe) ((GetToDs(pframe) << 1) | GetFrDs(pframe)) =20 -#define SetMFrag(pbuf) \ +#define set_m_frag(pbuf) \ (*(__le16 *)(pbuf) |=3D cpu_to_le16(_MORE_FRAG_)) =20 #define GetMFrag(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_MORE_FRAG_)) != =3D 0) =20 -#define ClearMFrag(pbuf) \ +#define clear_m_frag(pbuf) \ (*(__le16 *)(pbuf) &=3D (~cpu_to_le16(_MORE_FRAG_))) =20 #define GetRetry(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_RETRY_)) !=3D = 0) =20 -#define ClearRetry(pbuf) \ +#define clear_retry(pbuf) \ (*(__le16 *)(pbuf) &=3D (~cpu_to_le16(_RETRY_))) =20 #define SetPwrMgt(pbuf) \ @@ -100,18 +100,18 @@ enum { =20 #define GetPwrMgt(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_PWRMGT_)) != =3D 0) =20 -#define ClearPwrMgt(pbuf) \ +#define clear_pwr_mgt(pbuf) \ (*(__le16 *)(pbuf) &=3D (~cpu_to_le16(_PWRMGT_))) =20 -#define SetMData(pbuf) \ +#define set_m_data(pbuf) \ (*(__le16 *)(pbuf) |=3D cpu_to_le16(_MORE_DATA_)) =20 #define GetMData(pbuf) (((*(__le16 *)(pbuf)) & cpu_to_le16(_MORE_DATA_)) != =3D 0) =20 -#define ClearMData(pbuf) \ +#define clear_m_data(pbuf) \ (*(__le16 *)(pbuf) &=3D (~cpu_to_le16(_MORE_DATA_))) =20 -#define SetPrivacy(pbuf) \ +#define set_privacy(pbuf) \ (*(__le16 *)(pbuf) |=3D cpu_to_le16(_PRIVACY_)) =20 #define GetPrivacy(pbuf) \ @@ -129,10 +129,10 @@ enum { *(unsigned short *)(pbuf) |=3D cpu_to_le16(type); \ } while (0) =20 -#define GetFrameSubType(pbuf) (le16_to_cpu(*(__le16 *)(pbuf)) & (BIT(7) |\ +#define get_frame_sub_type(pbuf) (le16_to_cpu(*(__le16 *)(pbuf)) & (BIT(7)= |\ BIT(6) | BIT(5) | BIT(4) | BIT(3) | BIT(2))) =20 -#define SetFrameSubType(pbuf, type) \ +#define set_frame_sub_type(pbuf, type) \ do { \ *(__le16 *)(pbuf) &=3D cpu_to_le16(~(BIT(7) | BIT(6) | \ BIT(5) | BIT(4) | BIT(3) | BIT(2))); \ @@ -153,7 +153,7 @@ enum { cpu_to_le16(0x0f & (num)); \ } while (0) =20 -#define SetSeqNum(pbuf, num) \ +#define set_seq_num(pbuf, num) \ do { \ *(__le16 *)((size_t)(pbuf) + 22) =3D \ ((*(__le16 *)((size_t)(pbuf) + 22)) & cpu_to_le16((unsigned short)0x000= f)) | \ @@ -164,15 +164,15 @@ enum { (*(__le16 *)((size_t)(pbuf) + 2) =3D cpu_to_le16(0xffff & (dur))) =20 =20 -#define SetPriority(pbuf, tid) \ +#define set_priority(pbuf, tid) \ (*(__le16 *)(pbuf) |=3D cpu_to_le16(tid & 0xf)) =20 #define GetPriority(pbuf) ((le16_to_cpu(*(__le16 *)(pbuf))) & 0xf) =20 -#define SetEOSP(pbuf, eosp) \ +#define set_eosp(pbuf, eosp) \ (*(__le16 *)(pbuf) |=3D cpu_to_le16((eosp & 1) << 4)) =20 -#define SetAckpolicy(pbuf, ack) \ +#define set_ack_policy(pbuf, ack) \ (*(__le16 *)(pbuf) |=3D cpu_to_le16((ack & 3) << 5)) =20 #define GetAckpolicy(pbuf) (((le16_to_cpu(*(__le16 *)pbuf)) >> 5) & 0x3) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 60edeae1cffe..c1719326aefd 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -289,15 +289,15 @@ struct cfg80211_bss *rtw_cfg80211_inform_bss(struct a= dapter *padapter, struct wl fctrl =3D &(pwlanhdr->frame_control); *(fctrl) =3D 0; =20 - SetSeqNum(pwlanhdr, 0/*pmlmeext->mgnt_seq*/); + set_seq_num(pwlanhdr, 0/*pmlmeext->mgnt_seq*/); /* pmlmeext->mgnt_seq++; */ =20 if (pnetwork->network.reserved[0] =3D=3D 1) { /* WIFI_BEACON */ eth_broadcast_addr(pwlanhdr->addr1); - SetFrameSubType(pbuf, WIFI_BEACON); + set_frame_sub_type(pbuf, WIFI_BEACON); } else { memcpy(pwlanhdr->addr1, myid(&(padapter->eeprompriv)), ETH_ALEN); - SetFrameSubType(pbuf, WIFI_PROBERSP); + set_frame_sub_type(pbuf, WIFI_PROBERSP); } =20 memcpy(pwlanhdr->addr2, pnetwork->network.mac_address, ETH_ALEN); @@ -500,7 +500,7 @@ static int rtw_cfg80211_ap_set_encryption(struct net_de= vice *dev, struct ieee_pa struct security_priv *psecuritypriv =3D &(padapter->securitypriv); struct sta_priv *pstapriv =3D &padapter->stapriv; char *grpkey =3D padapter->securitypriv.dot118021XGrpKey[param->u.crypt.i= dx].skey; - char *txkey =3D padapter->securitypriv.dot118021XGrptxmickey[param->u.cry= pt.idx].skey; + char *txkey =3D padapter->securitypriv.dot11_8021x_grp_tx_mickey[param->u= .crypt.idx].skey; char *rxkey =3D padapter->securitypriv.dot118021XGrprxmickey[param->u.cry= pt.idx].skey; =20 param->u.crypt.err =3D 0; @@ -543,17 +543,17 @@ static int rtw_cfg80211_ap_set_encryption(struct net_= device *dev, struct ieee_pa if (psecuritypriv->bWepDefaultKeyIdxSet =3D=3D 0) { /* wep default key has not been set, so use this key index as default k= ey. */ =20 - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_Auto; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_auto; psecuritypriv->ndisencryptstatus =3D Ndis802_11Encryption1Enabled; - psecuritypriv->dot11PrivacyAlgrthm =3D _WEP40_; - psecuritypriv->dot118021XGrpPrivacy =3D _WEP40_; + psecuritypriv->dot11_privacy_algrthm =3D _WEP40_; + psecuritypriv->dot11_8021x_grp_privacy =3D _WEP40_; =20 if (wep_key_len =3D=3D 13) { - psecuritypriv->dot11PrivacyAlgrthm =3D _WEP104_; - psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; + psecuritypriv->dot11_privacy_algrthm =3D _WEP104_; + psecuritypriv->dot11_8021x_grp_privacy =3D _WEP104_; } =20 - psecuritypriv->dot11PrivacyKeyIndex =3D wep_key_idx; + psecuritypriv->dot11_privacy_key_index =3D wep_key_idx; } =20 memcpy(&(psecuritypriv->dot11DefKey[wep_key_idx].skey[0]), param->u.cryp= t.key, wep_key_len); @@ -572,12 +572,12 @@ static int rtw_cfg80211_ap_set_encryption(struct net_= device *dev, struct ieee_pa if (strcmp(param->u.crypt.alg, "WEP") =3D=3D 0) { memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 := param->u.crypt.key_len)); =20 - psecuritypriv->dot118021XGrpPrivacy =3D _WEP40_; + psecuritypriv->dot11_8021x_grp_privacy =3D _WEP40_; if (param->u.crypt.key_len =3D=3D 13) - psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; + psecuritypriv->dot11_8021x_grp_privacy =3D _WEP104_; =20 } else if (strcmp(param->u.crypt.alg, "TKIP") =3D=3D 0) { - psecuritypriv->dot118021XGrpPrivacy =3D _TKIP_; + psecuritypriv->dot11_8021x_grp_privacy =3D _TKIP_; =20 memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 := param->u.crypt.key_len)); =20 @@ -588,35 +588,35 @@ static int rtw_cfg80211_ap_set_encryption(struct net_= device *dev, struct ieee_pa psecuritypriv->busetkipkey =3D true; =20 } else if (strcmp(param->u.crypt.alg, "CCMP") =3D=3D 0) { - psecuritypriv->dot118021XGrpPrivacy =3D _AES_; + psecuritypriv->dot11_8021x_grp_privacy =3D _AES_; =20 memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 := param->u.crypt.key_len)); } else { - psecuritypriv->dot118021XGrpPrivacy =3D _NO_PRIVACY_; + psecuritypriv->dot11_8021x_grp_privacy =3D _NO_PRIVACY_; } =20 - psecuritypriv->dot118021XGrpKeyid =3D param->u.crypt.idx; + psecuritypriv->dot11_8021x_grp_key_id =3D param->u.crypt.idx; =20 psecuritypriv->binstallGrpkey =3D true; =20 - psecuritypriv->dot11PrivacyAlgrthm =3D psecuritypriv->dot118021XGrpPriv= acy;/* */ + psecuritypriv->dot11_privacy_algrthm =3D psecuritypriv->dot11_8021x_grp= _privacy;/* */ =20 - rtw_ap_set_group_key(padapter, param->u.crypt.key, psecuritypriv->dot11= 8021XGrpPrivacy, param->u.crypt.idx); + rtw_ap_set_group_key(padapter, param->u.crypt.key, psecuritypriv->dot11= _8021x_grp_privacy, param->u.crypt.idx); =20 pbcmc_sta =3D rtw_get_bcmc_stainfo(padapter); if (pbcmc_sta) { pbcmc_sta->ieee8021x_blocked =3D false; - pbcmc_sta->dot118021XPrivacy =3D psecuritypriv->dot118021XGrpPrivacy;/= * rx will use bmc_sta's dot118021XPrivacy */ + pbcmc_sta->dot118021XPrivacy =3D psecuritypriv->dot11_8021x_grp_privac= y;/* rx will use bmc_sta's dot118021XPrivacy */ } } =20 goto exit; } =20 - if (psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_8021X && psta= ) { /* psk/802_1x */ + if (psecuritypriv->dot11_auth_algrthm =3D=3D dot11_auth_algrthm_8021x && = psta) { /* psk/802_1x */ if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) { if (param->u.crypt.set_tx =3D=3D 1) { /* pairwise key */ - memcpy(psta->dot118021x_UncstKey.skey, param->u.crypt.key, (param->u.c= rypt.key_len > 16 ? 16 : param->u.crypt.key_len)); + memcpy(psta->dot11_8021x_uncst_key.skey, param->u.crypt.key, (param->u= .crypt.key_len > 16 ? 16 : param->u.crypt.key_len)); =20 if (strcmp(param->u.crypt.alg, "WEP") =3D=3D 0) { psta->dot118021XPrivacy =3D _WEP40_; @@ -647,11 +647,11 @@ static int rtw_cfg80211_ap_set_encryption(struct net_= device *dev, struct ieee_pa if (strcmp(param->u.crypt.alg, "WEP") =3D=3D 0) { memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 = : param->u.crypt.key_len)); =20 - psecuritypriv->dot118021XGrpPrivacy =3D _WEP40_; + psecuritypriv->dot11_8021x_grp_privacy =3D _WEP40_; if (param->u.crypt.key_len =3D=3D 13) - psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; + psecuritypriv->dot11_8021x_grp_privacy =3D _WEP104_; } else if (strcmp(param->u.crypt.alg, "TKIP") =3D=3D 0) { - psecuritypriv->dot118021XGrpPrivacy =3D _TKIP_; + psecuritypriv->dot11_8021x_grp_privacy =3D _TKIP_; =20 memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 = : param->u.crypt.key_len)); =20 @@ -662,25 +662,25 @@ static int rtw_cfg80211_ap_set_encryption(struct net_= device *dev, struct ieee_pa psecuritypriv->busetkipkey =3D true; =20 } else if (strcmp(param->u.crypt.alg, "CCMP") =3D=3D 0) { - psecuritypriv->dot118021XGrpPrivacy =3D _AES_; + psecuritypriv->dot11_8021x_grp_privacy =3D _AES_; =20 memcpy(grpkey, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 = : param->u.crypt.key_len)); } else { - psecuritypriv->dot118021XGrpPrivacy =3D _NO_PRIVACY_; + psecuritypriv->dot11_8021x_grp_privacy =3D _NO_PRIVACY_; } =20 - psecuritypriv->dot118021XGrpKeyid =3D param->u.crypt.idx; + psecuritypriv->dot11_8021x_grp_key_id =3D param->u.crypt.idx; =20 psecuritypriv->binstallGrpkey =3D true; =20 - psecuritypriv->dot11PrivacyAlgrthm =3D psecuritypriv->dot118021XGrpPri= vacy;/* */ + psecuritypriv->dot11_privacy_algrthm =3D psecuritypriv->dot11_8021x_gr= p_privacy;/* */ =20 - rtw_ap_set_group_key(padapter, param->u.crypt.key, psecuritypriv->dot1= 18021XGrpPrivacy, param->u.crypt.idx); + rtw_ap_set_group_key(padapter, param->u.crypt.key, psecuritypriv->dot1= 1_8021x_grp_privacy, param->u.crypt.idx); =20 pbcmc_sta =3D rtw_get_bcmc_stainfo(padapter); if (pbcmc_sta) { pbcmc_sta->ieee8021x_blocked =3D false; - pbcmc_sta->dot118021XPrivacy =3D psecuritypriv->dot118021XGrpPrivacy;= /* rx will use bmc_sta's dot118021XPrivacy */ + pbcmc_sta->dot118021XPrivacy =3D psecuritypriv->dot11_8021x_grp_priva= cy;/* rx will use bmc_sta's dot118021XPrivacy */ } } } @@ -741,15 +741,15 @@ static int rtw_cfg80211_set_encryption(struct net_dev= ice *dev, struct ieee_param wep_key_len =3D wep_key_len <=3D 5 ? 5 : 13; =20 psecuritypriv->ndisencryptstatus =3D Ndis802_11Encryption1Enabled; - psecuritypriv->dot11PrivacyAlgrthm =3D _WEP40_; - psecuritypriv->dot118021XGrpPrivacy =3D _WEP40_; + psecuritypriv->dot11_privacy_algrthm =3D _WEP40_; + psecuritypriv->dot11_8021x_grp_privacy =3D _WEP40_; =20 if (wep_key_len =3D=3D 13) { - psecuritypriv->dot11PrivacyAlgrthm =3D _WEP104_; - psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; + psecuritypriv->dot11_privacy_algrthm =3D _WEP104_; + psecuritypriv->dot11_8021x_grp_privacy =3D _WEP104_; } =20 - psecuritypriv->dot11PrivacyKeyIndex =3D wep_key_idx; + psecuritypriv->dot11_privacy_key_index =3D wep_key_idx; } =20 memcpy(&(psecuritypriv->dot11DefKey[wep_key_idx].skey[0]), param->u.cryp= t.key, wep_key_len); @@ -761,7 +761,7 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param goto exit; } =20 - if (padapter->securitypriv.dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_8021X= ) { /* 802_1x */ + if (padapter->securitypriv.dot11_auth_algrthm =3D=3D dot11_auth_algrthm_8= 021x) { /* 802_1x */ struct sta_info *psta, *pbcmc_sta; struct sta_priv *pstapriv =3D &padapter->stapriv; =20 @@ -774,12 +774,12 @@ static int rtw_cfg80211_set_encryption(struct net_dev= ice *dev, struct ieee_param =20 if ((padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypt= ion2Enabled) || (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encryp= tion3Enabled)) { - psta->dot118021XPrivacy =3D padapter->securitypriv.dot11PrivacyAlgrth= m; + psta->dot118021XPrivacy =3D padapter->securitypriv.dot11_privacy_algr= thm; } =20 if (param->u.crypt.set_tx =3D=3D 1) { /* pairwise key */ =20 - memcpy(psta->dot118021x_UncstKey.skey, param->u.crypt.key, (param->u.= crypt.key_len > 16 ? 16 : param->u.crypt.key_len)); + memcpy(psta->dot11_8021x_uncst_key.skey, param->u.crypt.key, (param->= u.crypt.key_len > 16 ? 16 : param->u.crypt.key_len)); =20 if (strcmp(param->u.crypt.alg, "TKIP") =3D=3D 0) { /* set mic key */ memcpy(psta->dot11tkiptxmickey.skey, &(param->u.crypt.key[16]), 8); @@ -793,17 +793,17 @@ static int rtw_cfg80211_set_encryption(struct net_dev= ice *dev, struct ieee_param } else { /* group key */ if (strcmp(param->u.crypt.alg, "TKIP") =3D=3D 0 || strcmp(param->u.cr= ypt.alg, "CCMP") =3D=3D 0) { memcpy(padapter->securitypriv.dot118021XGrpKey[param->u.crypt.idx].s= key, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt= .key_len)); - memcpy(padapter->securitypriv.dot118021XGrptxmickey[param->u.crypt.i= dx].skey, &(param->u.crypt.key[16]), 8); + memcpy(padapter->securitypriv.dot11_8021x_grp_tx_mickey[param->u.cry= pt.idx].skey, &(param->u.crypt.key[16]), 8); memcpy(padapter->securitypriv.dot118021XGrprxmickey[param->u.crypt.i= dx].skey, &(param->u.crypt.key[24]), 8); padapter->securitypriv.binstallGrpkey =3D true; =20 - padapter->securitypriv.dot118021XGrpKeyid =3D param->u.crypt.idx; + padapter->securitypriv.dot11_8021x_grp_key_id =3D param->u.crypt.idx; rtw_set_key(padapter, &padapter->securitypriv, param->u.crypt.idx, 1= , true); } else if (strcmp(param->u.crypt.alg, "BIP") =3D=3D 0) { /* save the IGTK key, length 16 bytes */ - memcpy(padapter->securitypriv.dot11wBIPKey[param->u.crypt.idx].skey,= param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt.key= _len)); - padapter->securitypriv.dot11wBIPKeyid =3D param->u.crypt.idx; - padapter->securitypriv.binstallBIPkey =3D true; + memcpy(padapter->securitypriv.dot11w_bip_key[param->u.crypt.idx].ske= y, param->u.crypt.key, (param->u.crypt.key_len > 16 ? 16 : param->u.crypt.k= ey_len)); + padapter->securitypriv.dot11w_bip_key_id =3D param->u.crypt.idx; + padapter->securitypriv.b_install_bip_key =3D true; } } } @@ -816,7 +816,7 @@ static int rtw_cfg80211_set_encryption(struct net_devic= e *dev, struct ieee_param =20 if ((padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encrypt= ion2Enabled) || (padapter->securitypriv.ndisencryptstatus =3D=3D Ndis802_11Encryp= tion3Enabled)) { - pbcmc_sta->dot118021XPrivacy =3D padapter->securitypriv.dot11PrivacyA= lgrthm; + pbcmc_sta->dot118021XPrivacy =3D padapter->securitypriv.dot11_privacy= _algrthm; } } } else if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { /* adhoc mode */ @@ -924,7 +924,7 @@ static int cfg80211_rtw_del_key(struct wiphy *wiphy, st= ruct net_device *ndev, struct adapter *padapter =3D rtw_netdev_priv(ndev); struct security_priv *psecuritypriv =3D &padapter->securitypriv; =20 - if (key_index =3D=3D psecuritypriv->dot11PrivacyKeyIndex) { + if (key_index =3D=3D psecuritypriv->dot11_privacy_key_index) { /* clear the flag of wep default key set. */ psecuritypriv->bWepDefaultKeyIdxSet =3D 0; } @@ -940,16 +940,16 @@ static int cfg80211_rtw_set_default_key(struct wiphy = *wiphy, struct adapter *padapter =3D rtw_netdev_priv(ndev); struct security_priv *psecuritypriv =3D &padapter->securitypriv; =20 - if ((key_index < WEP_KEYS) && ((psecuritypriv->dot11PrivacyAlgrthm =3D=3D= _WEP40_) || (psecuritypriv->dot11PrivacyAlgrthm =3D=3D _WEP104_))) { /* se= t wep default key */ + if ((key_index < WEP_KEYS) && ((psecuritypriv->dot11_privacy_algrthm =3D= =3D _WEP40_) || (psecuritypriv->dot11_privacy_algrthm =3D=3D _WEP104_))) { = /* set wep default key */ psecuritypriv->ndisencryptstatus =3D Ndis802_11Encryption1Enabled; =20 - psecuritypriv->dot11PrivacyKeyIndex =3D key_index; + psecuritypriv->dot11_privacy_key_index =3D key_index; =20 - psecuritypriv->dot11PrivacyAlgrthm =3D _WEP40_; - psecuritypriv->dot118021XGrpPrivacy =3D _WEP40_; + psecuritypriv->dot11_privacy_algrthm =3D _WEP40_; + psecuritypriv->dot11_8021x_grp_privacy =3D _WEP40_; if (psecuritypriv->dot11DefKeylen[key_index] =3D=3D 13) { - psecuritypriv->dot11PrivacyAlgrthm =3D _WEP104_; - psecuritypriv->dot118021XGrpPrivacy =3D _WEP104_; + psecuritypriv->dot11_privacy_algrthm =3D _WEP104_; + psecuritypriv->dot11_8021x_grp_privacy =3D _WEP104_; } =20 psecuritypriv->bWepDefaultKeyIdxSet =3D 1; /* set the flag to represent = that wep default key has been set */ @@ -1231,7 +1231,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy goto check_need_indicate_scan_done; } =20 - if (pmlmepriv->LinkDetectInfo.bBusyTraffic =3D=3D true) { + if (pmlmepriv->link_detect_info.bBusyTraffic =3D=3D true) { static unsigned long lastscantime; unsigned long passtime; =20 @@ -1323,26 +1323,26 @@ static int rtw_cfg80211_set_auth_type(struct securi= ty_priv *psecuritypriv, switch (sme_auth_type) { case NL80211_AUTHTYPE_AUTOMATIC: =20 - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_Auto; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_auto; =20 break; case NL80211_AUTHTYPE_OPEN_SYSTEM: =20 - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_Open; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_open; =20 if (psecuritypriv->ndisauthtype > Ndis802_11AuthModeWPA) - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_8021x; =20 break; case NL80211_AUTHTYPE_SHARED_KEY: =20 - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_Shared; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_shared; =20 psecuritypriv->ndisencryptstatus =3D Ndis802_11Encryption1Enabled; =20 break; default: - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_Open; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_open; /* return -ENOTSUPP; */ } =20 @@ -1353,8 +1353,8 @@ static int rtw_cfg80211_set_cipher(struct security_pr= iv *psecuritypriv, u32 ciph { u32 ndisencryptstatus =3D Ndis802_11EncryptionDisabled; =20 - u32 *profile_cipher =3D ucast ? &psecuritypriv->dot11PrivacyAlgrthm : - &psecuritypriv->dot118021XGrpPrivacy; + u32 *profile_cipher =3D ucast ? &psecuritypriv->dot11_privacy_algrthm : + &psecuritypriv->dot11_8021x_grp_privacy; =20 if (!cipher) { *profile_cipher =3D _NO_PRIVACY_; @@ -1390,7 +1390,7 @@ static int rtw_cfg80211_set_cipher(struct security_pr= iv *psecuritypriv, u32 ciph if (ucast) { psecuritypriv->ndisencryptstatus =3D ndisencryptstatus; =20 - /* if (psecuritypriv->dot11PrivacyAlgrthm >=3D _AES_) */ + /* if (psecuritypriv->dot11_privacy_algrthm >=3D _AES_) */ /* psecuritypriv->ndisauthtype =3D Ndis802_11AuthModeWPA2PSK; */ } =20 @@ -1401,9 +1401,9 @@ static int rtw_cfg80211_set_key_mgt(struct security_p= riv *psecuritypriv, u32 key { if (key_mgt =3D=3D WLAN_AKM_SUITE_8021X) /* auth_type =3D UMAC_AUTH_TYPE_8021X; */ - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_8021x; else if (key_mgt =3D=3D WLAN_AKM_SUITE_PSK) { - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_8021x; } =20 return 0; @@ -1446,7 +1446,7 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *pa= dapter, u8 *pie, size_t iel pwpa =3D rtw_get_wpa_ie(buf, &wpa_ielen, ielen); if (pwpa && wpa_ielen > 0) { if (rtw_parse_wpa_ie(pwpa, wpa_ielen + 2, &group_cipher, &pairwise_ciphe= r, NULL) =3D=3D _SUCCESS) { - padapter->securitypriv.dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; + padapter->securitypriv.dot11_auth_algrthm =3D dot11_auth_algrthm_8021x; padapter->securitypriv.ndisauthtype =3D Ndis802_11AuthModeWPAPSK; memcpy(padapter->securitypriv.supplicant_ie, &pwpa[0], wpa_ielen + 2); } @@ -1455,7 +1455,7 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *pa= dapter, u8 *pie, size_t iel pwpa2 =3D rtw_get_wpa2_ie(buf, &wpa2_ielen, ielen); if (pwpa2 && wpa2_ielen > 0) { if (rtw_parse_wpa2_ie(pwpa2, wpa2_ielen + 2, &group_cipher, &pairwise_ci= pher, NULL) =3D=3D _SUCCESS) { - padapter->securitypriv.dot11AuthAlgrthm =3D dot11AuthAlgrthm_8021X; + padapter->securitypriv.dot11_auth_algrthm =3D dot11_auth_algrthm_8021x; padapter->securitypriv.ndisauthtype =3D Ndis802_11AuthModeWPA2PSK; memcpy(padapter->securitypriv.supplicant_ie, &pwpa2[0], wpa2_ielen + 2); } @@ -1469,46 +1469,46 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *= padapter, u8 *pie, size_t iel =20 switch (group_cipher) { case WPA_CIPHER_NONE: - padapter->securitypriv.dot118021XGrpPrivacy =3D _NO_PRIVACY_; + padapter->securitypriv.dot11_8021x_grp_privacy =3D _NO_PRIVACY_; padapter->securitypriv.ndisencryptstatus =3D Ndis802_11EncryptionDisable= d; break; case WPA_CIPHER_WEP40: - padapter->securitypriv.dot118021XGrpPrivacy =3D _WEP40_; + padapter->securitypriv.dot11_8021x_grp_privacy =3D _WEP40_; padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption1Enable= d; break; case WPA_CIPHER_TKIP: - padapter->securitypriv.dot118021XGrpPrivacy =3D _TKIP_; + padapter->securitypriv.dot11_8021x_grp_privacy =3D _TKIP_; padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption2Enable= d; break; case WPA_CIPHER_CCMP: - padapter->securitypriv.dot118021XGrpPrivacy =3D _AES_; + padapter->securitypriv.dot11_8021x_grp_privacy =3D _AES_; padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption3Enable= d; break; case WPA_CIPHER_WEP104: - padapter->securitypriv.dot118021XGrpPrivacy =3D _WEP104_; + padapter->securitypriv.dot11_8021x_grp_privacy =3D _WEP104_; padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption1Enable= d; break; } =20 switch (pairwise_cipher) { case WPA_CIPHER_NONE: - padapter->securitypriv.dot11PrivacyAlgrthm =3D _NO_PRIVACY_; + padapter->securitypriv.dot11_privacy_algrthm =3D _NO_PRIVACY_; padapter->securitypriv.ndisencryptstatus =3D Ndis802_11EncryptionDisable= d; break; case WPA_CIPHER_WEP40: - padapter->securitypriv.dot11PrivacyAlgrthm =3D _WEP40_; + padapter->securitypriv.dot11_privacy_algrthm =3D _WEP40_; padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption1Enable= d; break; case WPA_CIPHER_TKIP: - padapter->securitypriv.dot11PrivacyAlgrthm =3D _TKIP_; + padapter->securitypriv.dot11_privacy_algrthm =3D _TKIP_; padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption2Enable= d; break; case WPA_CIPHER_CCMP: - padapter->securitypriv.dot11PrivacyAlgrthm =3D _AES_; + padapter->securitypriv.dot11_privacy_algrthm =3D _AES_; padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption3Enable= d; break; case WPA_CIPHER_WEP104: - padapter->securitypriv.dot11PrivacyAlgrthm =3D _WEP104_; + padapter->securitypriv.dot11_privacy_algrthm =3D _WEP104_; padapter->securitypriv.ndisencryptstatus =3D Ndis802_11Encryption1Enable= d; break; } @@ -1528,9 +1528,9 @@ static int rtw_cfg80211_set_wpa_ie(struct adapter *pa= dapter, u8 *pie, size_t iel } =20 /* TKIP and AES disallow multicast packets until installing group key */ - if (padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _TKIP_ - || padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _TKIP_WTMIC_ - || padapter->securitypriv.dot11PrivacyAlgrthm =3D=3D _AES_) + if (padapter->securitypriv.dot11_privacy_algrthm =3D=3D _TKIP_ + || padapter->securitypriv.dot11_privacy_algrthm =3D=3D _TKIP_WTMIC_ + || padapter->securitypriv.dot11_privacy_algrthm =3D=3D _AES_) /* WPS open need to enable multicast */ /* check_fwstate(&padapter->mlmepriv, WIFI_UNDER_WPS) =3D=3D true) */ rtw_hal_set_hwreg(padapter, HW_VAR_OFF_RCR_AM, null_addr); @@ -1576,9 +1576,9 @@ static int cfg80211_rtw_join_ibss(struct wiphy *wiphy= , struct net_device *ndev, memcpy(ndis_ssid.ssid, (u8 *)params->ssid, params->ssid_len); =20 psecuritypriv->ndisencryptstatus =3D Ndis802_11EncryptionDisabled; - psecuritypriv->dot11PrivacyAlgrthm =3D _NO_PRIVACY_; - psecuritypriv->dot118021XGrpPrivacy =3D _NO_PRIVACY_; - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_Open; /* open system= */ + psecuritypriv->dot11_privacy_algrthm =3D _NO_PRIVACY_; + psecuritypriv->dot11_8021x_grp_privacy =3D _NO_PRIVACY_; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_open; /* open sy= stem */ psecuritypriv->ndisauthtype =3D Ndis802_11AuthModeOpen; =20 ret =3D rtw_cfg80211_set_auth_type(psecuritypriv, NL80211_AUTHTYPE_OPEN_S= YSTEM); @@ -1672,9 +1672,9 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, = struct net_device *ndev, rtw_scan_abort(padapter); =20 psecuritypriv->ndisencryptstatus =3D Ndis802_11EncryptionDisabled; - psecuritypriv->dot11PrivacyAlgrthm =3D _NO_PRIVACY_; - psecuritypriv->dot118021XGrpPrivacy =3D _NO_PRIVACY_; - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_Open; /* open system= */ + psecuritypriv->dot11_privacy_algrthm =3D _NO_PRIVACY_; + psecuritypriv->dot11_8021x_grp_privacy =3D _NO_PRIVACY_; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_open; /* open sy= stem */ psecuritypriv->ndisauthtype =3D Ndis802_11AuthModeOpen; =20 ret =3D rtw_cfg80211_set_wpa_version(psecuritypriv, sme->crypto.wpa_versi= ons); @@ -1697,8 +1697,8 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, = struct net_device *ndev, } =20 /* For WEP Shared auth */ - if ((psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_Shared || - psecuritypriv->dot11AuthAlgrthm =3D=3D dot11AuthAlgrthm_Auto) && sme= ->key) { + if ((psecuritypriv->dot11_auth_algrthm =3D=3D dot11_auth_algrthm_shared || + psecuritypriv->dot11_auth_algrthm =3D=3D dot11_auth_algrthm_auto) &&= sme->key) { u32 wep_key_idx, wep_key_len, wep_total_len; struct ndis_802_11_wep *pwep =3D NULL; =20 @@ -1726,8 +1726,8 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, = struct net_device *ndev, pwep->length =3D wep_total_len; =20 if (wep_key_len =3D=3D 13) { - padapter->securitypriv.dot11PrivacyAlgrthm =3D _WEP104_; - padapter->securitypriv.dot118021XGrpPrivacy =3D _WEP104_; + padapter->securitypriv.dot11_privacy_algrthm =3D _WEP104_; + padapter->securitypriv.dot11_8021x_grp_privacy =3D _WEP104_; } } else { ret =3D -EINVAL; @@ -1920,7 +1920,7 @@ void rtw_cfg80211_indicate_sta_assoc(struct adapter *= padapter, u8 *pmgmt_frame, struct station_info sinfo =3D {}; u8 ie_offset; =20 - if (GetFrameSubType(pmgmt_frame) =3D=3D WIFI_ASSOCREQ) + if (get_frame_sub_type(pmgmt_frame) =3D=3D WIFI_ASSOCREQ) ie_offset =3D _ASOCREQ_IE_OFFSET_; else /* WIFI_REASSOCREQ */ ie_offset =3D _REASOCREQ_IE_OFFSET_; diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 6ca6dc548805..738a0a9529a9 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -525,13 +525,13 @@ static void rtw_init_default_value(struct adapter *pa= dapter) psecuritypriv->sw_encrypt =3D pregistrypriv->software_encrypt; psecuritypriv->sw_decrypt =3D pregistrypriv->software_decrypt; =20 - psecuritypriv->dot11AuthAlgrthm =3D dot11AuthAlgrthm_Open; /* open system= */ - psecuritypriv->dot11PrivacyAlgrthm =3D _NO_PRIVACY_; + psecuritypriv->dot11_auth_algrthm =3D dot11_auth_algrthm_open; /* open sy= stem */ + psecuritypriv->dot11_privacy_algrthm =3D _NO_PRIVACY_; =20 - psecuritypriv->dot11PrivacyKeyIndex =3D 0; + psecuritypriv->dot11_privacy_key_index =3D 0; =20 - psecuritypriv->dot118021XGrpPrivacy =3D _NO_PRIVACY_; - psecuritypriv->dot118021XGrpKeyid =3D 1; + psecuritypriv->dot11_8021x_grp_privacy =3D _NO_PRIVACY_; + psecuritypriv->dot11_8021x_grp_key_id =3D 1; =20 psecuritypriv->ndisauthtype =3D Ndis802_11AuthModeOpen; psecuritypriv->ndisencryptstatus =3D Ndis802_11WEPDisabled; @@ -610,11 +610,11 @@ void rtw_reset_drv_sw(struct adapter *padapter) padapter->xmitpriv.tx_pkts =3D 0; padapter->recvpriv.rx_pkts =3D 0; =20 - pmlmepriv->LinkDetectInfo.bBusyTraffic =3D false; + pmlmepriv->link_detect_info.bBusyTraffic =3D false; =20 - /* pmlmepriv->LinkDetectInfo.TrafficBusyState =3D false; */ - pmlmepriv->LinkDetectInfo.TrafficTransitionCount =3D 0; - pmlmepriv->LinkDetectInfo.LowPowerTransitionCount =3D 0; + /* pmlmepriv->link_detect_info.TrafficBusyState =3D false; */ + pmlmepriv->link_detect_info.TrafficTransitionCount =3D 0; + pmlmepriv->link_detect_info.LowPowerTransitionCount =3D 0; =20 _clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING); =20 --=20 2.52.0 From nobody Sun Feb 8 02:56:12 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D919D34C830 for ; Sun, 11 Jan 2026 18:37:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156646; cv=none; b=RG/HRcZmB2oRWmCBGoq7L4Ms0R3XbwgC6aqyOniyo89bGlAcxkTaBugRHlrxzQvK1WojDmaBwYGHTe6hYumMpvNzxk24+NPKu/61FGNGxvKYLJo8mhnTDd7DrX1ucuwzs7U/Mm00S0CWCYkxnLgjnFEudYkifVbk3NG3u9iLr+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156646; c=relaxed/simple; bh=w8McxZgAmJ5kY6yzWHrQrbxiKWvgGFbEdycBC3TzNOM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=utNTa1TAQlVm12b2MQgAXKUIskW6n2pAGwwvdV4P3fKI7KCfoTEMhSKn3bDMrwWz3HEqDd8A7iRb4phnbtpUWz24qrvi8TQ32bHk52hZPhvt3cXl0VgbtL1Hnlo2yQGkulpnrgNbi3MfXdttUlBjf3XYM/77JnSoAWyDes2dw/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hkM+Wm4Z; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hkM+Wm4Z" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2a09a3bd9c5so39616825ad.3 for ; Sun, 11 Jan 2026 10:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768156644; x=1768761444; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x6Jameo3+/nnme15NzTiR41yWGBTy740AQjZBOzHmF4=; b=hkM+Wm4ZxBL0KKr/y+j7ggIeIGRT9BYtvgPGKjC/PuqaCERENB2v/X7E0DQgu/0YXE nSOZPUeGaCquFghXPE7TaFdBkFIuMP9fqd7UKiRC+REFzxYqs/qLTuu2dSRQkFsibipj qQYeRzqPinG2+IZMW9UxGsaYSx4ccAGsBSY0uI4F1pvbilq9ugIt1Ul8vo6wwnxK2/be 2neWaaBIxGlDvHf+UUPnlcJHcaOeblmMP4cmoQEh6LyCK9VtRL3Rtt28Jp0j2kUK5bYw xU+4F2tchrheuwcCW9+VJMlppUw/7KnpZs0P7rIaptmOF+AiK+s+Z2fufsefjtRTxzgg g/2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768156644; x=1768761444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=x6Jameo3+/nnme15NzTiR41yWGBTy740AQjZBOzHmF4=; b=koXP4BDtOamArEdJoFMoqzcn9Qlo1OwfN7idZhYD2IIr+2B/Mzfn1CMJu4bgy10M0I CDvZ7n61CqlqSTk+EnhpR4Rs7Afz9qwWcg4DxHvj11/u2a0CY5Q2uOxl/rP7sgx17NlR nu2qFfV6u0+aHt6Sj+Q/H8ceWCyDlXR2i8uHk/g+kMAGDajXJH9EWpeUvBZ/xfsAvGiV ChTucYuMtPasaSOuWGO+ebCCZKuWfuHlnDHBoBZdvJr8iTZJ2IxL1cEWO8RH6ItKVGIX pKAp2RaHRqOIodsEugMdIz3TK7GBrbhxAl+ywAaPGwpZGe+z1DFz0sQLKf4SZbxe70Um a6sg== X-Forwarded-Encrypted: i=1; AJvYcCVKjX9xBAuvWVukKVQWbRAa11jaIMnxFUHLJHM6JQnHK8z0yZlnlqM3wGsH8K7jY4Wieu2Gf4AFiAmKUVY=@vger.kernel.org X-Gm-Message-State: AOJu0YwaAnb1DRkjsR9IgXOdwu5y/hoiL1YRjIrLnHCs9zkhdW56pLeq 5DkQlh2XVn0FwnQfofGiXdQ3ZiQAPioA98y64l3Cn8u/UpbDEkd1bZS9 X-Gm-Gg: AY/fxX4N2eCwpeedZxs4+YWR/ez6GHpuh1lr5Gff2i2AjHCZeFym84o5lru1GaJYUAH 4aJpI4arfSFNog1kfV6qIW5Hjb0FaPTdN3JOQPrPDOahr0qhQA4xReLFO6RD4PX5NUn9R6oeKHT spg2mL5COW6Oa/PcSyzyHY54m/NYNPevBdVmO8Tt3Q+9nopJ9Ae+msz5OCopQGxQiJLPVcU49ed gSQcrrJmHZETy2GhbVOyogNGBVKhIRwDlLPqR0N3sYS2wG2PKpvm3y+vPp3R7xYyGwuBheShEj0 8zlX4cuCWEmV1zle2E3eoxb0cTZMiGSOzQecFU3/SGG6UvqGCms0lSs0yMr9VoacjhnXXnc2tVz EZY/tReYAuQe1NJ1lg1U70/2Uyz9ImQatsUUG/Q1yGZmnwOle8UmCdzHjFozPayfUzmGX8A8eDJ +YxLH9F2BIfsziu0ZbILCoNuDlzJNZSMvXvzc= X-Google-Smtp-Source: AGHT+IE42+urqLAp87x3CNbPPmR98e2ft6TqH+1trqp/YTc4v93NAdWSSv4QOD3ldzPnHfaHmwzaLg== X-Received: by 2002:a17:902:d507:b0:2a0:9081:8a6 with SMTP id d9443c01a7336-2a3ee437d3dmr158737505ad.20.1768156644190; Sun, 11 Jan 2026 10:37:24 -0800 (PST) Received: from snowman.bbrouter ([43.241.121.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd2953sm152220415ad.86.2026.01.11.10.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 10:37:23 -0800 (PST) From: Khushal Chitturi To: Greg Kroah-Hartman Cc: Michael Straube , Hans de Goede , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 7/9] staging: rtl8723bs: rename local variables to snake_case Date: Mon, 12 Jan 2026 00:06:28 +0530 Message-ID: <20260111183630.12816-8-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260111183630.12816-1-khushalchitturi@gmail.com> References: <20260111183630.12816-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename local CamelCase variables in rtw_xmit.c to follow the kernel naming conventions. Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 418ca141e656..5852209c702b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -401,10 +401,10 @@ static void update_attrib_vcs_info(struct adapter *pa= dapter, struct xmit_frame * =20 /* check HT op mode */ if (pattrib->ht_en) { - u8 HTOpMode =3D pmlmeinfo->HT_protection; + u8 ht_op_mode =3D pmlmeinfo->HT_protection; =20 - if ((pmlmeext->cur_bwmode && (HTOpMode =3D=3D 2 || HTOpMode =3D=3D 3))= || - (!pmlmeext->cur_bwmode && HTOpMode =3D=3D 3)) { + if ((pmlmeext->cur_bwmode && (ht_op_mode =3D=3D 2 || ht_op_mode =3D=3D= 3)) || + (!pmlmeext->cur_bwmode && ht_op_mode =3D=3D 3)) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -603,17 +603,17 @@ static void set_qos(struct pkt_file *ppktfile, struct= pkt_attrib *pattrib) { struct ethhdr etherhdr; struct iphdr ip_hdr; - s32 UserPriority =3D 0; + s32 user_priority =3D 0; =20 _rtw_open_pktfile(ppktfile->pkt, ppktfile); _rtw_pktfile_read(ppktfile, (unsigned char *)ðerhdr, ETH_HLEN); =20 - /* get UserPriority from IP hdr */ + /* get user_priority from IP hdr */ if (pattrib->ether_type =3D=3D 0x0800) { _rtw_pktfile_read(ppktfile, (u8 *)&ip_hdr, sizeof(ip_hdr)); - UserPriority =3D ip_hdr.tos >> 5; + user_priority =3D ip_hdr.tos >> 5; } - pattrib->priority =3D UserPriority; + pattrib->priority =3D user_priority; pattrib->hdrlen =3D WLAN_HDR_A3_QOS_LEN; pattrib->subtype =3D WIFI_QOS_DATA_TYPE; } --=20 2.52.0 From nobody Sun Feb 8 02:56:12 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 711E334C9B5 for ; Sun, 11 Jan 2026 18:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156653; cv=none; b=n8tzWxx3itLVltSUMi3DMsz727iofmrmxGClkVVgTBbxCgC+96vmC+JE0czPL/5rP9A1If/TphI7z7lxj47oJAWAJ23MaNGA4tqUqdKsC2wlVJFVs2D+HnkWG/Lb6ZF6hEsCCS55lBDje/goSsyLjpoCOZkvfKOYvOAzMXZATrI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156653; c=relaxed/simple; bh=jVSTaA91lLj+ywa4ZspLRO/8Kg/2FZkPNVEAsqgppbo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E0d+wwNLYr7y3wCYWyY+5Bvmol1UOiHBl4LLw5ec4LLrTVQNnIMnZU1FGBCrzzpFKqcRg7KlPXBr/Z3V688RwEngCZjbbGdxD14Ss+So5Wh15VyztPSwXvobbOQYCgDQye9NGCOzkmNfrMXHcTxdoGeouMW0jVlNQvDOWvuT15w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gzTsW384; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gzTsW384" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2a3e76d0f64so20931145ad.1 for ; Sun, 11 Jan 2026 10:37:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768156652; x=1768761452; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N/qoRaPpM4dzF5RloA49kaRCQLu6cSnTLbckqvDNtgw=; b=gzTsW384FaGkIGuLtgRl8ZifOLoBEphD9YuHT+DVZY5eMC4oYdOvzoBhHFnQFA7V/0 7kX3aggXFDDNfAHXrHFtuT7QpGLrWDfbLWPPHsC7eU69HgE1/D7bDpmqQoTkm4xKDMgc D+mnP/0lhJLETZVoz5cjBRXL+/xXe/sck8UTVaMnbOm4SwSpoUTCnwhZ9GdoNS7JxbKz Ta32UA6A2vU+AkL8h4mqSt+dbuxA3/fEcVNeH2DbmbOFVcAwYZR4euDMDxrMwcbXlugz JnIE2vjomxVZNHZiVA1LOXr5Dwk9ReyoqnSw1Lx3z44u00539BTBawKO6/5TjoCQZPCe xkgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768156652; x=1768761452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=N/qoRaPpM4dzF5RloA49kaRCQLu6cSnTLbckqvDNtgw=; b=t0QJQuLyfC5X4yqshevP1mXVT2CbHu2XXHy9jrsI7VYkmqdGCS1uL1y63RETmDjhm/ 4rMRWNzAgt450uNgvEkgIEc+/ZthK7qM9banPUDGCuFmXISXR1rwcRhSPKcAamOyO8Je 2VJu/7M4yhHMTvxQImeQEWhqk4Y7WAtn8GsjhNrKztPSmIppZTukF2p/mfcSFqRBymE2 LsTqd9bNhZjHocmI0D86ocmNxqnRrluOs05pG31hXv93Z5gjZ/K+Rfg4rwq7EOq+o9ge DwvpdmpJcLKQturxgDorqOe3+xJFf2f2WKiI7+6tF3lNf0jVXWhVK4IEi5rMzj4BLI9u GrgQ== X-Forwarded-Encrypted: i=1; AJvYcCWQrwiWuL3Q+JP21AGcJrzOtszVFCcRgdOLdqreUx5vQdO502SoK4BUhrCMJyfdFWKYkwummn97pW5Z5NE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+AWSEI+LEj9nreFaLwPUQnnFh3UncLa98ywf90rtiGQAaAbdT yL+6GseFZC06CEEs5fGCW5VZEme7gtt29gXjEIWduO/OEav49cfwrdizL+Twwb1iqJI= X-Gm-Gg: AY/fxX5yk1FWcOOCtj9uyC6hSV2WHzQ9LBHWn8xnpDD1Z24+NMvq7A75fj5zlvGfPO8 dd7gpbHe0vCSWD2gioZUhjik76tyN2hvdHXJY3AHGUsP8Im6kooK5R/MPocPzQrx5tRmyynqPGr R1PG0YOVNPnbLl6m/Ykr45Q7/eilNItOW1puTdYmY5K3M46k0JeKdQlhoUQMDuoCzGShA2kZTD+ 516gd9+D+CNDcA496/lUmnQ4XWWdY9Vqr74XrluoVgzPsSe1Vnrm52ttXQATu0B70oAD/Q5JxRk EfEcI7qjXb1toGdYgj1OyQGOhtXYuVHmzzyn8bOtXd+cuGqrZ5F5Prhovytle66RRe6z0nuhcrf 4GKQNaf34G3eqGZxOyQOgwD808/5VrV7k73pQ7hycERcYXnC5qJRMQ+S5HuTQNXzzSVn+LfsZXx XV+A41/c0gfr+vgIIqiq59YRc8oEcTndpYGR0= X-Google-Smtp-Source: AGHT+IESobB7HLvLZ+7PvJHzBnQZzTqj2jp/S2AdIiJYUA40wWqZRGFmDbFrTRBEXyMUlqEc2NGfmQ== X-Received: by 2002:a17:902:e545:b0:298:639b:a64f with SMTP id d9443c01a7336-2a3edb0de06mr174216155ad.6.1768156651744; Sun, 11 Jan 2026 10:37:31 -0800 (PST) Received: from snowman.bbrouter ([43.241.121.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd2953sm152220415ad.86.2026.01.11.10.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 10:37:31 -0800 (PST) From: Khushal Chitturi To: Greg Kroah-Hartman Cc: Michael Straube , Hans de Goede , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 8/9] staging: rtl8723bs: replace N_BYTE_ALIGMENT with PTR_ALIGN Date: Mon, 12 Jan 2026 00:06:29 +0530 Message-ID: <20260111183630.12816-9-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260111183630.12816-1-khushalchitturi@gmail.com> References: <20260111183630.12816-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the custom N_BYTE_ALIGMENT macro with the standard PTR_ALIGN macro in rtw_init_xmit_priv. This improves unnecessary casting and improves readability without any functional change. Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 5852209c702b..a800547f2f01 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -76,8 +76,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, stru= ct adapter *padapter) res =3D _FAIL; goto exit; } - pxmitpriv->pxmit_frame_buf =3D (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv= ->pallocated_frame_buf), 4); - + pxmitpriv->pxmit_frame_buf =3D PTR_ALIGN(pxmitpriv->pallocated_frame_buf,= 4); pxframe =3D (struct xmit_frame *)pxmitpriv->pxmit_frame_buf; =20 for (i =3D 0; i < NR_XMITFRAME; i++) { @@ -114,7 +113,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) goto exit; } =20 - pxmitpriv->pxmitbuf =3D (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv->pallo= cated_xmitbuf), 4); + pxmitpriv->pxmitbuf =3D PTR_ALIGN(pxmitpriv->pallocated_xmitbuf, 4); =20 pxmitbuf =3D (struct xmit_buf *)pxmitpriv->pxmitbuf; =20 @@ -164,7 +163,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) res =3D _FAIL; goto exit; } - pxmitpriv->xframe_ext =3D (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv->xfr= ame_ext_alloc_addr), 4); + pxmitpriv->xframe_ext =3D PTR_ALIGN(pxmitpriv->xframe_ext_alloc_addr, 4); pxframe =3D (struct xmit_frame *)pxmitpriv->xframe_ext; =20 for (i =3D 0; i < NR_XMIT_EXTBUFF; i++) { @@ -198,7 +197,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) goto exit; } =20 - pxmitpriv->pxmit_extbuf =3D (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv->p= allocated_xmit_extbuf), 4); + pxmitpriv->pxmit_extbuf =3D PTR_ALIGN(pxmitpriv->pallocated_xmit_extbuf, = 4); =20 pxmitbuf =3D (struct xmit_buf *)pxmitpriv->pxmit_extbuf; =20 --=20 2.52.0 From nobody Sun Feb 8 02:56:12 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 332CC23183F for ; Sun, 11 Jan 2026 18:37:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156662; cv=none; b=UOG47hecckhu/30Hb/TjJTQM0J8sY3lA7JUdxj9lwnOOqhubiAHljTKmbuv+jSl/2cSp4rSH6U5WEFTT1wHUh0tsrgmAgSJ/OA6ew0uCPMs9NCgMfWzOVGrU4gFA/3nKwy3XySKR/V6sjL7+6bukoRVCf4H6qJidKbrN7bGB/AE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768156662; c=relaxed/simple; bh=PiU/yfqR0EaY67xKBn3HiBizwFWWuNX72Ur0SeMJ3uk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OhiZE5RHlV5YCiJn+V5bAe7Q/Ho7Z0uapdBVnJfDOWiN2fZKU2jDe9RCsuhWKPFEtN2dIx3OwKhvOb3AdkLjwtzOHCetUgBLZ2qvryPHxoi8GdRHSkAZETGLd46rEMCOwhIpxFbyTxQ18cBtllTEucmBOQxjxpZGn3DV+YQBTVo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LtXiFY37; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LtXiFY37" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2a0a95200e8so32722575ad.0 for ; Sun, 11 Jan 2026 10:37:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768156657; x=1768761457; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q0lLxKb8bj1oGcqDwzVMK/D1NpEacU7JoXhpDJTmkFM=; b=LtXiFY37rA0V7s9COBkw1MVIniLvV67aBTFI+buNTX2ihXEmeIYHAy17UJaA7rw92T 7LHvvq6IT6uYgQyI9mycsC4vEg9op/sbZoSqTwFchqbUKfZ//LduvmNyK9Sc4VPPqq/h 3RcgX1AfVH0JakxEsEpqXoZcSJJAIfwRVBN5hfx8gqoVUCiK62h4kecnqlxy1OOJdzJU sSbF7QAfA6NVRcU02oJyp/ftMwySOWNB5p4kUVgtFQNFpA2RzIAlnxYwuy8CztpAeDwL gVpeXnqSX8jot3Vz5sV8hbkf8Gwi39IRupkjm0aOuolPFswg72mT1isJm437uJUQUAEt ZwlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768156657; x=1768761457; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=q0lLxKb8bj1oGcqDwzVMK/D1NpEacU7JoXhpDJTmkFM=; b=URIXc6awSJoyGym0qkCSvsQQVZomRwVs9GHLIiC8vhDUc2PRZ2eJ0avcwSjwAq/k33 Arajv0B+Za6Qz0gVhhQw443oQacnStGosAX8uh85OMdgXcbgbSCbsiSaGG0DPMP+3DTH nG39ifZOvDPe29yI/duJRkTuxHLDR2fRE/p1CRxJBHQsQ39KZ1+FTex+yG6qDZr5G1I/ SxXVbcQcyrZJMOzPln1LTY737uOUzvSanMCc3TNIkI1rKfciliyCNB4a6QqtixF0bZc1 rPm+fMjnziSHkxSolNPuuZa47+DJUKgjMRqzNbrUHnLJhEE4emd02O1svwjgix5aQGCn 5eWQ== X-Forwarded-Encrypted: i=1; AJvYcCVNhL2hHNpfJMe8SGc/iViEEXVU/Ga8vW5R+OA56g8QDXpU8akGo1KH33JTXgFEwdtE4BB5RP6/I+o3MEI=@vger.kernel.org X-Gm-Message-State: AOJu0YxhTBOwqbjMkZG88za904ZIYYxKrkMqIoAHRH2CGlF2Z0ZQkGFp upz3RrK1GwDuM8ygP3q9QI+qARXkQxNvE1mx7iTlYCZDSJbMPhy4213o X-Gm-Gg: AY/fxX6golHWPvrnJIBoJ8DLcPqcmqqKDSTGarD0d4nTVYgiyf01ZobxKYGHDpC9fLH L2Kstd1wo+7kSGZKv7AGYWby535gFDIilN08wjiagafmM137sDebNBezyH17wveYH7Zhy8VtVIw vK15WgyjlP/5uhv6wnYzy63iFKRxG2X1suTtXiWtc1ZwU6qTuXbf9ZI6xv3hLFHNfcd5ObuXoaN HNXk3lUewm5jjOGpLK1dfyUDYeTIbymMO9pNhFr+4J3v7vxVsN1iyDYLa2MRsfbDssd26Z+0kzY AXkmJyQMmULoJPY0RffP8r565PzluW+ffsZK4jZT9Ln2HpTUnOaHUA0m6F87JeA0oEHPGkEEpLw C2ChCCekvB5+qMDpvDXnbNI95/ewGJkUTM6y8LaYxcOGEJpc8k2UdK8PpmHYtJIKH+uG0a8hGhV fXkxzPigqz3wTtMn8FP7J5v9ZI X-Google-Smtp-Source: AGHT+IEWMomKo5ZK9Gixh1Em2vQ8A2UoZe3kprhkc62oWhXFrlFJ5JRhxKef3M51FGVk++Vk/FYn2Q== X-Received: by 2002:a17:902:ce08:b0:2a0:34ee:3725 with SMTP id d9443c01a7336-2a3ee4456c1mr158288805ad.14.1768156657332; Sun, 11 Jan 2026 10:37:37 -0800 (PST) Received: from snowman.bbrouter ([43.241.121.48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd2953sm152220415ad.86.2026.01.11.10.37.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 10:37:36 -0800 (PST) From: Khushal Chitturi To: Greg Kroah-Hartman Cc: Michael Straube , Hans de Goede , Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH 9/9] staging: rtl8723bs: fix line length and alignment issues Date: Mon, 12 Jan 2026 00:06:30 +0530 Message-ID: <20260111183630.12816-10-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260111183630.12816-1-khushalchitturi@gmail.com> References: <20260111183630.12816-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix multiple coding style issues in rtw_xmit.c to comply with the kernel coding style by splitting expressions and adjusting alignment. This patch resolves checkpatch.pl warnings caused by lines exceeding the 100-column limit. Signed-off-by: Khushal Chitturi --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 135 ++++++++++++++-------- 1 file changed, 85 insertions(+), 50 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index a800547f2f01..e4dd3b2b4882 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -125,10 +125,12 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, = struct adapter *padapter) pxmitbuf->buf_tag =3D XMITBUF_DATA; =20 /* Tx buf allocation may fail sometimes, so sleep and retry. */ - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ += XMITBUF_ALIGN_SZ), true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ, true); if (res =3D=3D _FAIL) { usleep_range(10000, 11000); - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ = + XMITBUF_ALIGN_SZ), true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ, true); if (res =3D=3D _FAIL) goto exit; } @@ -141,8 +143,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) =20 pxmitbuf->flags =3D XMIT_VO_QUEUE; =20 - list_add_tail(&pxmitbuf->list, - &pxmitpriv->free_xmitbuf_queue.queue); + list_add_tail(&pxmitbuf->list, &pxmitpriv->free_xmitbuf_queue.queue); #ifdef DBG_XMIT_BUF pxmitbuf->no =3D i; #endif @@ -208,7 +209,8 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->padapter =3D padapter; pxmitbuf->buf_tag =3D XMITBUF_MGNT; =20 - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_XMIT_EXTBUF_S= Z + XMITBUF_ALIGN_SZ, true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + MAX_XMIT_EXTBUF_SZ + XMITBUF_ALIGN_SZ, true); if (res =3D=3D _FAIL) { res =3D _FAIL; goto exit; @@ -239,7 +241,9 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitbuf->padapter =3D padapter; pxmitbuf->buf_tag =3D XMITBUF_CMD; =20 - res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_CMDBUF_SZ + = XMITBUF_ALIGN_SZ, true); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, + MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, + true); if (res =3D=3D _FAIL) { res =3D _FAIL; goto exit; @@ -291,7 +295,8 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) } =20 for (i =3D 0; i < NR_XMITBUFF; i++) { - rtw_os_xmit_resource_free(padapter, pxmitbuf, (MAX_XMITBUF_SZ + XMITBUF_= ALIGN_SZ), true); + rtw_os_xmit_resource_free(padapter, pxmitbuf, + MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ, true); =20 pxmitbuf++; } @@ -313,7 +318,8 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) /* free xmit extension buff */ pxmitbuf =3D (struct xmit_buf *)pxmitpriv->pxmit_extbuf; for (i =3D 0; i < NR_XMIT_EXTBUFF; i++) { - rtw_os_xmit_resource_free(padapter, pxmitbuf, (MAX_XMIT_EXTBUF_SZ + XMIT= BUF_ALIGN_SZ), true); + rtw_os_xmit_resource_free(padapter, pxmitbuf, + MAX_XMIT_EXTBUF_SZ + XMITBUF_ALIGN_SZ, true); =20 pxmitbuf++; } @@ -323,7 +329,8 @@ void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) for (i =3D 0; i < CMDBUF_MAX; i++) { pxmitbuf =3D &pxmitpriv->pcmd_xmitbuf[i]; if (pxmitbuf) - rtw_os_xmit_resource_free(padapter, pxmitbuf, MAX_CMDBUF_SZ + XMITBUF_A= LIGN_SZ, true); + rtw_os_xmit_resource_free(padapter, pxmitbuf, + MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, true); } =20 rtw_free_hwxmits(padapter); @@ -365,7 +372,9 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * sz =3D pattrib->last_txcmdsz; =20 /* (1) RTS_Threshold is compared to the MPDU, not MSDU. */ - /* (2) If there are more than one frag in this MSDU, only the first fra= g uses protection frame. */ + /* (2) If there are more than one frag in this MSDU, + * only the first frag uses protection frame. + */ /* Other fragments are protected by previous fragment. */ /* So we only need to check the length of first fragment. */ if (pmlmeext->cur_wireless_mode < WIRELESS_11_24N || padapter->registryp= riv.wifi_spec) { @@ -382,7 +391,8 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * } else { while (true) { /* IOT action */ - if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && (pattrib= ->ampdu_en) && + if ((pmlmeinfo->assoc_AP_vendor =3D=3D HT_IOT_PEER_ATHEROS) && + (pattrib->ampdu_en) && (padapter->securitypriv.dot11_privacy_algrthm =3D=3D _AES_)) { pattrib->vcs_mode =3D CTS_TO_SELF; break; @@ -402,8 +412,9 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * if (pattrib->ht_en) { u8 ht_op_mode =3D pmlmeinfo->HT_protection; =20 - if ((pmlmeext->cur_bwmode && (ht_op_mode =3D=3D 2 || ht_op_mode =3D=3D= 3)) || - (!pmlmeext->cur_bwmode && ht_op_mode =3D=3D 3)) { + if ((pmlmeext->cur_bwmode && + (ht_op_mode =3D=3D 2 || ht_op_mode =3D=3D 3)) || + (!pmlmeext->cur_bwmode && ht_op_mode =3D=3D 3)) { pattrib->vcs_mode =3D RTS_CTS; break; } @@ -433,7 +444,8 @@ static void update_attrib_vcs_info(struct adapter *pada= pter, struct xmit_frame * pattrib->vcs_mode =3D padapter->driver_vcs_type; } =20 -static void update_attrib_phy_info(struct adapter *padapter, struct pkt_at= trib *pattrib, struct sta_info *psta) +static void update_attrib_phy_info(struct adapter *padapter, struct pkt_at= trib *pattrib, + struct sta_info *psta) { struct mlme_ext_priv *mlmeext =3D &padapter->mlmeextpriv; =20 @@ -461,7 +473,8 @@ static void update_attrib_phy_info(struct adapter *pada= pter, struct pkt_attrib * pattrib->ch_offset =3D psta->htpriv.ch_offset; pattrib->ampdu_en =3D false; =20 - if (padapter->driver_ampdu_spacing !=3D 0xFF) /* driver control AMPDU Den= sity for peer sta's rx */ + /* driver control AMPDU Density for peer sta's rx */ + if (padapter->driver_ampdu_spacing !=3D 0xFF) pattrib->ampdu_spacing =3D padapter->driver_ampdu_spacing; else pattrib->ampdu_spacing =3D psta->htpriv.rx_ampdu_min_spacing; @@ -469,7 +482,8 @@ static void update_attrib_phy_info(struct adapter *pada= pter, struct pkt_attrib * pattrib->retry_ctrl =3D false; } =20 -static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_att= rib *pattrib, struct sta_info *psta) +static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_att= rib *pattrib, + struct sta_info *psta) { signed int res =3D _SUCCESS; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -508,7 +522,8 @@ static s32 update_attrib_sec_info(struct adapter *padap= ter, struct pkt_attrib *p } =20 /* For WPS 1.0 WEP, driver should not encrypt EAPOL Packet for WPS hands= hake. */ - if (((pattrib->encrypt =3D=3D _WEP40_) || (pattrib->encrypt =3D=3D _WEP1= 04_)) && (pattrib->ether_type =3D=3D 0x888e)) + if (((pattrib->encrypt =3D=3D _WEP40_) || (pattrib->encrypt =3D=3D _WEP1= 04_)) && + (pattrib->ether_type =3D=3D 0x888e)) pattrib->encrypt =3D _NO_PRIVACY_; } =20 @@ -560,7 +575,7 @@ static s32 update_attrib_sec_info(struct adapter *padap= ter, struct pkt_attrib *p memcpy(pattrib->dot11_8021x_uncst_key.skey, psta->dot11_8021x_uncst_key.= skey, 16); =20 if (pattrib->encrypt && - ((padapter->securitypriv.sw_encrypt) || (!psecuritypriv->hw_decrypted))) + ((padapter->securitypriv.sw_encrypt) || (!psecuritypriv->hw_decrypted= ))) pattrib->bswenc =3D true; else pattrib->bswenc =3D false; @@ -638,7 +653,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p memcpy(pattrib->src, ðerhdr.h_source, ETH_ALEN); =20 if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) || - (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { + (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE))) { memcpy(pattrib->ra, pattrib->dst, ETH_ALEN); memcpy(pattrib->ta, pattrib->src, ETH_ALEN); } else if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { @@ -652,7 +667,9 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p pattrib->pktlen =3D pktfile.pkt_len; =20 if (pattrib->ether_type =3D=3D ETH_P_IP) { - /* The following is for DHCP and ARP packet, we use cck1M to tx these p= ackets and let LPS awake some time */ + /* The following is for DHCP and ARP packet, + * we use cck1M to tx these packets and let LPS awake some time + */ /* to prevent DHCP protocol fail */ =20 u8 tmp[24]; @@ -663,7 +680,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (pktfile.pkt_len > 282) {/* MINIMUM_DHCP_PACKET_SIZE) { */ if (pattrib->ether_type =3D=3D ETH_P_IP) {/* IP header */ if (((tmp[21] =3D=3D 68) && (tmp[23] =3D=3D 67)) || - ((tmp[21] =3D=3D 67) && (tmp[23] =3D=3D 68))) { + ((tmp[21] =3D=3D 67) && (tmp[23] =3D=3D 68))) { /* 68 : UDP BOOTP client */ /* 67 : UDP BOOTP server */ pattrib->dhcp_pkt =3D 1; @@ -702,7 +719,8 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p if (!psta) { /* if we cannot get psta =3D> drop the pkt */ res =3D _FAIL; goto exit; - } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE)) && (!(psta->state &= _FW_LINKED))) { + } else if ((check_fwstate(pmlmepriv, WIFI_AP_STATE)) && + (!(psta->state & _FW_LINKED))) { res =3D _FAIL; goto exit; } @@ -759,7 +777,7 @@ static s32 update_attrib(struct adapter *padapter, stru= ct sk_buff *pkt, struct p static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *p= xmitframe) { signed int curfragnum, length; - u8 *pframe, *payload, mic[8]; + u8 *pframe, *payload, mic[8], *skey; struct mic_data micdata; struct pkt_attrib *pattrib =3D &pxmitframe->attrib; struct security_priv *psecuritypriv =3D &padapter->securitypriv; @@ -773,15 +791,17 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr if (pattrib->encrypt =3D=3D _TKIP_) { /* encode mic code */ { - u8 null_key[16] =3D {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, = 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}; - + u8 null_key[16] =3D {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, + 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}; + skey =3D psecuritypriv->dot11_8021x_grp_tx_mickey[ + psecuritypriv->dot11_8021x_grp_key_id].skey; pframe =3D pxmitframe->buf_addr + hw_hdr_offset; =20 if (bmcst) { - if (!memcmp(psecuritypriv->dot11_8021x_grp_tx_mickey[psecuritypriv->do= t11_8021x_grp_key_id].skey, null_key, 16)) + if (!memcmp(skey, null_key, 16)) return _FAIL; /* start to calculate the mic code */ - rtw_secmicsetkey(&micdata, psecuritypriv->dot11_8021x_grp_tx_mickey[ps= ecuritypriv->dot11_8021x_grp_key_id].skey); + rtw_secmicsetkey(&micdata, skey); } else { if (!memcmp(&pattrib->dot11tkiptxmickey.skey[0], null_key, 16)) return _FAIL; @@ -815,11 +835,15 @@ static s32 xmitframe_addmic(struct adapter *padapter,= struct xmit_frame *pxmitfr payload =3D payload + pattrib->hdrlen + pattrib->iv_len; =20 if ((curfragnum + 1) =3D=3D pattrib->nr_frags) { - length =3D pattrib->last_txcmdsz - pattrib->hdrlen - pattrib->iv_len = - ((pattrib->bswenc) ? pattrib->icv_len : 0); + length =3D pattrib->last_txcmdsz - pattrib->hdrlen - + pattrib->iv_len - + ((pattrib->bswenc) ? pattrib->icv_len : 0); rtw_secmicappend(&micdata, payload, length); payload =3D payload + length; } else { - length =3D pxmitpriv->frag_len - pattrib->hdrlen - pattrib->iv_len - = ((pattrib->bswenc) ? pattrib->icv_len : 0); + length =3D pxmitpriv->frag_len - pattrib->hdrlen - + pattrib->iv_len - + ((pattrib->bswenc) ? pattrib->icv_len : 0); rtw_secmicappend(&micdata, payload, length); payload =3D payload + length + pattrib->icv_len; } @@ -990,7 +1014,7 @@ s32 rtw_txframes_pending(struct adapter *padapter) struct xmit_priv *pxmitpriv =3D &padapter->xmitpriv; =20 return ((!list_empty(&pxmitpriv->be_pending.queue)) || - (!list_empty(&pxmitpriv->bk_pending.queue)) || + (!list_empty(&pxmitpriv->bk_pending.queue)) || (!list_empty(&pxmitpriv->vi_pending.queue)) || (!list_empty(&pxmitpriv->vo_pending.queue))); } @@ -1022,7 +1046,8 @@ u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pk= t_attrib *pattrib) * 5. move frag chunk from pframe to pxmitframe->mem * 6. apply sw-encrypt, if necessary. */ -s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, = struct xmit_frame *pxmitframe) +s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, + struct xmit_frame *pxmitframe) { struct pkt_file pktfile; =20 @@ -1110,7 +1135,8 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct if (bmcst || (rtw_endofpktfile(&pktfile))) { pattrib->nr_frags =3D frg_inx; =20 - pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + ((pattrib= ->nr_frags =3D=3D 1) ? llc_sz : 0) + + pattrib->last_txcmdsz =3D pattrib->hdrlen + pattrib->iv_len + + ((pattrib->nr_frags =3D=3D 1) ? llc_sz : 0) + ((pattrib->bswenc) ? pattrib->icv_len : 0) + mem_sz; =20 clear_m_frag(mem_start); @@ -1141,7 +1167,8 @@ s32 rtw_xmitframe_coalesce(struct adapter *padapter, = struct sk_buff *pkt, struct } =20 /* broadcast or multicast management pkt use BIP, unicast management pkt u= se CCMP encryption */ -s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *= pkt, struct xmit_frame *pxmitframe) +s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *= pkt, + struct xmit_frame *pxmitframe) { u8 *pframe, *mem_start =3D NULL, *tmp_buf =3D NULL; u8 subtype; @@ -1187,7 +1214,8 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s memset(MME, 0, 18); =20 /* other types doesn't need the BIP */ - if (get_frame_sub_type(pframe) !=3D WIFI_DEAUTH && get_frame_sub_type(pf= rame) !=3D WIFI_DISASSOC) + if ((get_frame_sub_type(pframe) !=3D WIFI_DEAUTH) && + (get_frame_sub_type(pframe) !=3D WIFI_DISASSOC)) goto xmitframe_coalesce_fail; =20 MGMT_body =3D pframe + sizeof(struct ieee80211_hdr_3addr); @@ -1226,7 +1254,7 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s } else { /* unicast mgmt frame TX */ /* start to encrypt mgmt frame */ if (subtype =3D=3D WIFI_DEAUTH || subtype =3D=3D WIFI_DISASSOC || - subtype =3D=3D WIFI_REASSOCREQ || subtype =3D=3D WIFI_ACTION) { + subtype =3D=3D WIFI_REASSOCREQ || subtype =3D=3D WIFI_ACTION) { if (pattrib->psta) psta =3D pattrib->psta; else @@ -1240,15 +1268,16 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *pad= apter, struct sk_buff *pkt, s =20 /* according 802.11-2012 standard, these five types are not robust type= s */ if (subtype =3D=3D WIFI_ACTION && - (pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_PUBLIC || - pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_HT || - pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_UNPROTECTED_WNM || - pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_SELF_PROTECTED || - pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_P2P)) + (pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_PUBLIC || + pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_HT || + pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_UNPROTECTED_WNM || + pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_SELF_PROTECTED || + pframe[WLAN_HDR_A3_LEN] =3D=3D RTW_WLAN_CATEGORY_P2P)) goto xmitframe_coalesce_fail; /* before encrypt dump the management packet content */ if (pattrib->encrypt > 0) - memcpy(pattrib->dot11_8021x_uncst_key.skey, psta->dot11_8021x_uncst_ke= y.skey, 16); + memcpy(pattrib->dot11_8021x_uncst_key.skey, + psta->dot11_8021x_uncst_key.skey, 16); /* bakeup original management packet */ memcpy(tmp_buf, pframe, pattrib->pktlen); /* move to data portion */ @@ -1271,7 +1300,8 @@ s32 rtw_mgmt_xmitframe_coalesce(struct adapter *padap= ter, struct sk_buff *pkt, s memcpy(pframe, pattrib->iv, pattrib->iv_len); pframe +=3D pattrib->iv_len; /* copy mgmt data portion after CCMP header */ - memcpy(pframe, tmp_buf + pattrib->hdrlen, pattrib->pktlen - pattrib->hd= rlen); + memcpy(pframe, tmp_buf + pattrib->hdrlen, + pattrib->pktlen - pattrib->hdrlen); /* move pframe to end of mgmt pkt */ pframe +=3D pattrib->pktlen - pattrib->hdrlen; /* add 8 bytes CCMP IV header to length */ @@ -1400,7 +1430,7 @@ void rtw_count_tx_stats(struct adapter *padapter, str= uct xmit_frame *pxmitframe, } =20 static struct xmit_buf *__rtw_alloc_cmd_xmitbuf(struct xmit_priv *pxmitpri= v, - enum cmdbuf_type buf_type) + enum cmdbuf_type buf_type) { struct xmit_buf *pxmitbuf =3D NULL; =20 @@ -1422,7 +1452,7 @@ static struct xmit_buf *__rtw_alloc_cmd_xmitbuf(struc= t xmit_priv *pxmitpriv, } =20 struct xmit_frame *__rtw_alloc_cmdxmitframe(struct xmit_priv *pxmitpriv, - enum cmdbuf_type buf_type) + enum cmdbuf_type buf_type) { struct xmit_frame *pcmdframe; struct xmit_buf *pxmitbuf; @@ -1757,7 +1787,8 @@ s32 rtw_xmitframe_enqueue(struct adapter *padapter, s= truct xmit_frame *pxmitfram return _SUCCESS; } =20 -struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, signed int up, u8 *ac) +struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_= info *psta, + signed int up, u8 *ac) { struct tx_servq *ptxservq =3D NULL; =20 @@ -2011,7 +2042,8 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *x= mitframe) return allow; } =20 -signed int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, st= ruct xmit_frame *pxmitframe) +signed int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, + struct xmit_frame *pxmitframe) { signed int ret =3D false; struct sta_info *psta =3D NULL; @@ -2106,7 +2138,8 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x if (wmmps_ac) psta->sleepq_ac_len++; =20 - if (((psta->has_legacy_ac) && (!wmmps_ac)) || ((!psta->has_legacy_ac) &= & (wmmps_ac))) { + if (((psta->has_legacy_ac) && (!wmmps_ac)) || + ((!psta->has_legacy_ac) && (wmmps_ac))) { if (!(pstapriv->tim_bitmap & BIT(psta->aid))) update_tim =3D true; =20 @@ -2126,7 +2159,8 @@ signed int xmitframe_enqueue_for_sleeping_sta(struct = adapter *padapter, struct x return ret; } =20 -static void dequeue_xmitframes_to_sleeping_queue(struct adapter *padapter,= struct sta_info *psta, struct __queue *pframequeue) +static void dequeue_xmitframes_to_sleeping_queue(struct adapter *padapter,= struct sta_info *psta, + struct __queue *pframequeue) { signed int ret; struct list_head *plist, *phead, *tmp; @@ -2147,7 +2181,8 @@ static void dequeue_xmitframes_to_sleeping_queue(stru= ct adapter *padapter, struc ret =3D xmitframe_enqueue_for_sleeping_sta(padapter, pxmitframe); =20 if (ret) { - ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8= *)(&ac_index)); + ptxservq =3D rtw_get_sta_pending(padapter, psta, pattrib->priority, + (u8 *)(&ac_index)); =20 ptxservq->qcnt--; phwxmits[ac_index].accnt--; @@ -2453,7 +2488,7 @@ struct xmit_buf *dequeue_pending_xmitbuf_under_survey= (struct xmit_priv *pxmitpri type =3D get_frame_sub_type(pxmitbuf->pbuf + TXDESC_OFFSET); =20 if ((type =3D=3D WIFI_PROBEREQ) || - (type =3D=3D WIFI_DATA_NULL) || + (type =3D=3D WIFI_DATA_NULL) || (type =3D=3D WIFI_QOS_DATA_NULL)) { list_del_init(&pxmitbuf->list); break; --=20 2.52.0