From nobody Sun Feb 8 06:04:30 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A37F33D6EA for ; Sun, 11 Jan 2026 18:06:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768154807; cv=none; b=NF8BAdjz+DnDnV/2e6Uk83MC8h8GERJgk39oIwmHc36oUx86wYr2r0av+MF5T+vNll/NwVbi2FB25yBgzbzmqx1uPqYYm4AhyjVwcq1etOMll0f0wcSFxHqu+/DUU6mJmLefPfhGCl1VJlO78PwplTQ+zURqap/bpedICOEQRRs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768154807; c=relaxed/simple; bh=FDy6DiIUtdj3HazIJHrGjFR6nGpMmHKZl/UdYEKiJSE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BtCjfcx0xjl9swD/TFh2K0/BTCJ2/t434jvQPUjtwQ8Kkz2QbBVxodMqXDYKSL9zuigLbrujG6mu7nzwpdtmM1wZ0LTcE/9/RJw2IRtkvqRGHhcg1tdYKCXtj48FYB2LCv4QjPvWLuxUcPZSzpsG8x2CuIwjcH2O29CvEdLVvr8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jCk1VyZ5; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jCk1VyZ5" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-bc0d7255434so2594965a12.0 for ; Sun, 11 Jan 2026 10:06:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768154806; x=1768759606; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sfG+4C/4nUvYvetsovlctcQX7Cc0vxQvTyUECITJ4mc=; b=jCk1VyZ5IzIC047v6fHtu73mlZBGjx5kDRSjmNa8vMj3qHcHWnLHlIN+Qz6kMuud7i GtAqTZc4NhZXPdOkjjHCvSN+5guIKc02pbm6xGvPH+Td9RNZjhisc5yvoGeM9kT/Uc+7 WoaxvXLqHRxtyoAAB/l0RL7lsrB9Ka6W8zsCYoRU0Kqb5MQw6Hl84g4ps4xPfafJin/D M+O57TZ8es4TotP05QCcy4VqD5ofqLxBBGo9tZan/YMGRn//HPuVlFa/vqENxmU0SvBq ttyAbopmkZDJJFcVeT+Cs8hm5B2mbq3jFwozdZfsJT3bINiqLtlXs/rh4Hn++mtApzx3 yOjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768154806; x=1768759606; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sfG+4C/4nUvYvetsovlctcQX7Cc0vxQvTyUECITJ4mc=; b=aa2OwvIEOSu3IK81dEoWfp1wi2tLhSSBBeClf5Ofioz8wBmAjlVK42QbUwnOBbOep3 tMYK5nEST/E158/T0Ue2dFxqdOnJtT5oBKhEtL8TW9hNC+hbiYIbIgDjTC5plj4T248+ cAqqVrSKlQlo/VhJ40HVgV8lMPO7+y5d8Z03J0L28SHNAUP7h1ZiFyQPM599iPuVfc9d gLadzi6KMn6PEm0BMou2aRw0O8OowCHKF+XyXRMn2vnfyIFfM8Rp2h9i8Qxf8u/F2fnt adsXy9IMV5tyK1ONFaE7VAbVsxLCxKkF3zj0VEbst9RKWfAT1L2Erw4P1RCni5CMQopt X2mw== X-Forwarded-Encrypted: i=1; AJvYcCXlldNCuHw5uKlbk21WmuqwM1p9W3EjGImp0ry8N3BwwPxI7qxmfNgFixX3PKa/0cx8NPrcXCqHe0kQA8s=@vger.kernel.org X-Gm-Message-State: AOJu0YwcP9c8tgbmm2i3L3kuHsNkBJo9RHrxcIGAElCr0sjoTWObWOqU Yg7Ma7q81DJWA3ISJdFS6PTnQGQShqfmmlyvQrl6RZ9AgSOFML6NWlHSm5wHsQ== X-Gm-Gg: AY/fxX5oYghgeh+9aUvo43TeraY1Yim0k0Lq+n88Slpqk5Xi1bYzkQjCZ0msXxQqkEG piA3sMMoAc1Vy+WO0O6YsFPDMzdTTmBmCRXJv2aBvCR2OTImPv7yBfdCUHlGzEM+UgZrodCptZm n3MdtOscL9eCjzY9MRNR/IMd6UkbC7ijoHyZarmMI0kh3GV7t92q0K4V13veTeSRRncTtdu3zmj lX4VsAjrNbcK0daOUJw04NqoYCbKmyb+gV6QBon+oktYOE3kj1dJMWeaGDkpyKEPGe7e4Sz4gd8 6YOE5GAZNnoaZt4hfwy1ywtjz4MT3sitFRO3hzdSWV3oI30q9KYF7rNeFA3XQK1O51eoZmMihJ3 KPLNzz4OiMJep/cTSQfOkallz88Xt2MuoBpAsu6P26kbmy2wCTsaKm4CJ08bfrYtw//lop78Bkg e7fzEGFy1D X-Google-Smtp-Source: AGHT+IFtA18blBIi2dpVQ48ZjkidDMw9k6G0knM4Dw5qZO12I3PJD9STkdMSaqrchwd7FBu+DfKeFg== X-Received: by 2002:a05:6a20:a128:b0:35f:68d:430e with SMTP id adf61e73a8af0-3898f8f45bemr13925297637.9.1768154805457; Sun, 11 Jan 2026 10:06:45 -0800 (PST) Received: from cong ([112.197.171.165]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f6b064243sm6172937a91.2.2026.01.11.10.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 10:06:44 -0800 (PST) From: Vo Thanh Cong To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, anac.amplar@gmail.com, Vo Thanh Cong Subject: [PATCH] staging: rtl8723bs: remove unnecessary else after break Date: Mon, 12 Jan 2026 01:06:35 +0700 Message-ID: <20260111180635.198615-1-thanhcongvo079@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes the checkpatch.pl warning: "WARNING: else is not generally useful after a break or return" In sdio_ops_linux.c, the else blocks after break statements are redundant. Removing them reduces indentation level and improves code readability. Signed-off-by: Vo Thanh Cong --- .../staging/rtl8723bs/os_dep/sdio_ops_linux.c | 30 +++++++++---------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c b/drivers/st= aging/rtl8723bs/os_dep/sdio_ops_linux.c index 5dc00e9117ae..87444d36c502 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c @@ -219,14 +219,14 @@ u32 sd_read32(struct intf_hdl *pintfhdl, u32 addr, s3= 2 *err) if (*err =3D=3D 0) { rtw_reset_continual_io_error(psdiodev); break; - } else { - if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) - padapter->bSurpriseRemoved =3D true; - - if (rtw_inc_and_chk_continual_io_error(psdiodev) =3D=3D true) { - padapter->bSurpriseRemoved =3D true; - break; - } + } + + if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) + padapter->bSurpriseRemoved =3D true; + + if (rtw_inc_and_chk_continual_io_error(psdiodev) =3D=3D true) { + padapter->bSurpriseRemoved =3D true; + break; } } } @@ -295,14 +295,12 @@ void sd_write32(struct intf_hdl *pintfhdl, u32 addr, = u32 v, s32 *err) if (*err =3D=3D 0) { rtw_reset_continual_io_error(psdiodev); break; - } else { - if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) - padapter->bSurpriseRemoved =3D true; - - if (rtw_inc_and_chk_continual_io_error(psdiodev) =3D=3D true) { - padapter->bSurpriseRemoved =3D true; - break; - } + } + if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) + padapter->bSurpriseRemoved =3D true; + if (rtw_inc_and_chk_continual_io_error(psdiodev) =3D=3D true) { + padapter->bSurpriseRemoved =3D true; + break; } } } --=20 2.52.0