From nobody Sun Feb 8 09:27:20 2026 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9D2034A3DA for ; Sun, 11 Jan 2026 17:12:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768151571; cv=none; b=XIelzmVv6glDHL3bk1hNpB3SqoA7YH5vKUoCzvwxK4zGVNQnd/dKldzAW2+SbNspJ528qdyDD4R0nY6+0PznmgzbgB1KDsxl1MCvXHwa7zSLHyIhnddrD8tkKdMawhZs2Q7qOGd6PnxEFQd2OVKCgKw7h0LW4CNNCRHlXLBs+tQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768151571; c=relaxed/simple; bh=FRikw+aH/EFNHxXdSeRa4aNnHKkYpt++u6s/L69FKJc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=GO+/JBJVeNoeFTlygHCUdlq5Qi/cGwhbj+i63TrigKdZUp/7QCB8w8ZxemQYgr9Bu0V8oMv2ucQfLPmzsNIYPZCaE+/nrxNCw+C0URQCwamr6mNOthIBuEy9fveoul0gy1jAS3L9acp5ixcw152mrhVuQe0C8lWKBA02Q2jTGx0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yw97zs8F; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yw97zs8F" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-455749af2e1so3067738b6e.1 for ; Sun, 11 Jan 2026 09:12:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768151569; x=1768756369; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MyzJdRsgxqDp5cdZgjxReGtTIZkUf+41udKNUBqMXvg=; b=Yw97zs8FfKWBSGEPCnClWgoTFZzumj6z85ni+a+EhyFUuGaHogc9OHbxzQAHMgv022 ptEhV66ENNRxouGNPEKcdYIZbryrwG42xlRY95FYvf8BAYEjw1/cWU3EloOrs2nx12WQ nnWPkOotwWqBolF1OYtBECUd/lWT99c0tIZW/06dzSVCDqn7tzAblMwhh+3HvUq1Iq0S LZO3Lf+w5/PCEbmQHt98zjfmBzOw+7QQq5T0KD6CuKjKKFfx6gEPJIvSlxF1rt0gNn/H W5zV2qJpDQwmlqVl3nz7TjJNKdOPvd28j3dr3YgnItQvdK0875lvWuUzxi7iRmIre5zx bDxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768151569; x=1768756369; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MyzJdRsgxqDp5cdZgjxReGtTIZkUf+41udKNUBqMXvg=; b=rCcIt08HP1Bc4L4A7k58qoEJAe1oAPPsBY8CVpWxtrDxDS0f3ol44t4G8Ct6REoPK7 rjm/qRjiLaFicjkyQ1KFej5s+bbjofClrsfzuzoIgyxCZ6bjMp1lSxRA5GcFxwqjJJpU sY7jzlCz9sKL6zE2M8RjIFGfUQPKCWblTHS/b3k20L/KxECtdZKR55skShJRJRG57QKD /dXxoabjBUa2NzOTigvRRUhpUVHlWtWYMQrv7i9qjnDkeVctb1CYY+gR0MM2sWNFmL1F fE2d35/+3UaeFgnNOrGKDyhIg9fhoyzi9P/qmTNCm7tTkI4XR7Ukdg8jw9P2dc43TRZG n3/Q== X-Forwarded-Encrypted: i=1; AJvYcCXsdgt5TT2IftpqAqJezVaCQ86qzEnx52FjCQSgh7rMmzJoc+Im8bejX6hTwLqkNYMWn5f8icds5ZL7dsg=@vger.kernel.org X-Gm-Message-State: AOJu0YykjIfcu+vPN9/BLRGqnJm8Tui58P5UXVm4sK+DYH2s0tGf24y4 tNoQqiCXCMUDHVW72Mb55WBnUj5d/ypIUP/3hx2Vvf8/W45sLxQ3uvd3 X-Gm-Gg: AY/fxX50/3rSqom8gz5nx/NE1NWvXumJ5mtdXf6T01fuO1loHHbR9yBSS86gNvpjaBl hipRHc76m+e5u+9yGagpf7SHGYL621ecCEhqHrGX/8BMyrQRdTziP+owghNbELoTrNGz3wbB87+ HMscs22aLSC5wDJRw4qrI1KlhuM2/7h7xUI60CsxkJuaqBMn7fLhMuBXHVY84MtktrsSCzZk1O4 n88Y5iVV+FYLO8XMfMFXyFgckDokvR5oDBByJUuqjMOntMH6JDxHgJ6j1/e9HulSrNSuue7vqez LQCnQ9GhUOn/tsf+O2UzeN9m2PBjl4tQpL+lp8y5DQGBom3PS/9qz0X0UWpUIpbwK4ivFXUFOu1 b/Y2JsCk6a6WpVLBGNaLPHLm2joCTrvBCcwzNT8HiN9V863W3+cjM6zW6LJKQwFbzGnFQNHe2Sa A/hoMat6/Bdwd5HZJNqFD5ncgXpt2bgeTx2PJOW/dDKvQ= X-Google-Smtp-Source: AGHT+IGa8yfFS4/HioCoj5atiTDTumfJ0esnn6ABbbVVb4gFSnBkvjfvN1XVEejawK8KmayDSq77mg== X-Received: by 2002:a05:6808:22ac:b0:450:bc8e:cfcd with SMTP id 5614622812f47-45a5c93f323mr10372985b6e.4.1768151568761; Sun, 11 Jan 2026 09:12:48 -0800 (PST) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3ffa4de8cbfsm10664316fac.3.2026.01.11.09.12.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 09:12:48 -0800 (PST) From: Jiasheng Jiang To: Zhu Yanjun , Jason Gunthorpe , Leon Romanovsky Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] RDMA/rxe: Fix double free in rxe_srq_from_init Date: Sun, 11 Jan 2026 17:12:45 +0000 Message-Id: <20260111171245.17759-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In rxe_srq_from_init(), the queue pointer 'q' is assigned to 'srq->rq.queue' before copying the SRQ number to user space. If copy_to_user() fails, the function calls rxe_queue_cleanup() to free the queue, but leaves the now-invalid pointer in 'srq->rq.queue'. The caller of rxe_srq_from_init() (rxe_create_srq) eventually calls rxe_srq_cleanup() upon receiving the error, which triggers a second rxe_queue_cleanup() on the same memory, leading to a double free. Fix this by setting 'srq->rq.queue' to NULL after the initial cleanup in the error path. Fixes: aae0484e15f0 ("IB/rxe: avoid srq memory leak") Signed-off-by: Jiasheng Jiang Reviewed-by: Zhu Yanjun --- drivers/infiniband/sw/rxe/rxe_srq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/sw/rxe/rxe_srq.c b/drivers/infiniband/sw/rx= e/rxe_srq.c index 2a234f26ac10..c527c1cbd4ec 100644 --- a/drivers/infiniband/sw/rxe/rxe_srq.c +++ b/drivers/infiniband/sw/rxe/rxe_srq.c @@ -84,6 +84,7 @@ int rxe_srq_from_init(struct rxe_dev *rxe, struct rxe_srq= *srq, if (copy_to_user(&uresp->srq_num, &srq->srq_num, sizeof(uresp->srq_num))) { rxe_queue_cleanup(q); + srq->rq.queue =3D NULL; return -EFAULT; } } --=20 2.25.1