From nobody Sun Feb 8 11:44:16 2026 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72752346AE3 for ; Sun, 11 Jan 2026 17:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768151497; cv=none; b=CG2P45/v3lS7JFaUjxyQE+llQI0v+pcAYKxn8hK9Vu18oymGiPJKKlqdcRTDLm7ACbMY8uXlurgcMC/WS1kYDRjPOx7TJTCS6ywe6eEbQeorJHEOY6C65akGDITl15uBVolg/SED4sc6nAaBc/ja6ul4vl/mPA6ujyU/ulg864k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768151497; c=relaxed/simple; bh=1X4/mgD8i46cgaYtzD7T7tQWYglvatsNfrnjhmeWS04=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YsysM0nRw+er/N3j2W13TYqEWV3kiZ9r2/O7QGBTBqUOOnK9dGJK0jsrWZTVe97p9hJDLZPS2xo3ji9Of4m/dN6LyqYDHkCmy0bH3qULkHCceC3GxzdJ7DhbyeEg38dTyVMnXhhV5k7z1Q5uEuoc6lSK/KspjPS/OVfn7ECwd5w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bf4MnstP; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bf4MnstP" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-34c1d84781bso3197705a91.2 for ; Sun, 11 Jan 2026 09:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768151496; x=1768756296; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LAqq3UaflZMTR4kV8l/Zp3RcDFexgnKsLUUbdPELkew=; b=bf4MnstPqALvGivrguOmcLqcNhAO5B5jiJ8uAxRW5mvkZJf0fXkV8Lzyf6ENwi5FCc 3sRJvUoFV+ekmw1/fqJIqmu7iIgOTyBxITMw10Nb87ZSPHPICx0gflFP72pPNsbWbJ17 mVi3UilkCcVOaGtGXBKY9dCRvOlgY12RPn5MAg5WFEBC6BD00LW+joePYLATGdHVDGJF UEYnKBVWOizbi0y9xU6Z2ZT0vyUT0afIHVTjogNnX32wbZSeyetKg3MW9Edf1IkBneD/ HxnhdGlwulqh6t0oMrZiF6Ou0N2ugx9aMEg/rBdpoa/53CrNapDUZ4iCkPmKJictotAG QvLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768151496; x=1768756296; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LAqq3UaflZMTR4kV8l/Zp3RcDFexgnKsLUUbdPELkew=; b=w6u8exZU1ra8Lxczhxp7RGPJXVhTa/+LYAk7pH70Ighco30EzfIUqwTE10AXHCl8Eu WAVxwU1FSW4OzcB2hBoUyqNGGuEdrB1pFSgiKhYFCwAR+051BBlPqgYoGCv2ZvtIRQhw 2Kdk2hp68Tg+8T6VpVCWj5dlNdFE09IcDZqLJyUxHT109itWQdRmpguAysg8akGlt3iL 2dgRd0X+ruSBBnEJ5E7mfO5F4L0aHhaiGXcPTQJRSj4KlCUmdON4ggXtQBHUlOrYM2Tu K1AT/av7bmGviooJoOdrPxT5GwvrFelRJYnr39VeCIC7oXjez25CAagNNyOwohOqo9bY ciOw== X-Forwarded-Encrypted: i=1; AJvYcCUitQFOI8zq52T5rgvRWVJUsxsKf4LEobB8sgEkfllX+7/TiOud7J4ej+C4pDdLgz4lKi9V4KhVYkX0PXU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1JMpUFjXS09I6gZJ83XLO8f5ZHEha7eujFKED4R7KL84el7Gv CnfSohMoQQaK79gLSdwRIjaOGhXWKkxdQ/TET922FyqaCaqZu1Wc+K79 X-Gm-Gg: AY/fxX5QOCpelkMXe/WOw8atVAm7RoNLB5+CuTM4LfLakgE3vyJGpix26gLiEzB3nyF luA3CUesaRx9SVJdEZVnjlb/773d+mRDkYkilMBAjaJ5FoCtwxo/iENOlPvETY1Jgi5vT+ZOa1P xHNlP0ZxO0kLEVfecFeekGcWeM7/7Puohp43mePiZcjjdu6hJEGMx2FMFQbh+MB58E0n2Eadf2x /zNkjKYmlJjRYaSVxrg4wxe8pX7OG9RStRELGPdjSmK4bygkByQDHL7/chcCP01T74kdut81+XF FpG3e1ZAuZb5LH4bhsi/61yl/X8u90m03q9XM/g2Vk1XL7XyxqYIUjG7MouYd+xyuKqSw+YWSIs q2dQUebvgimdZ8fOUoFovW9OrlAztwHVMp1Fu5wmi5I2IgMTzo6fXdpQeLWq2iBa32RVQT6qXAJ e49U24yQ== X-Google-Smtp-Source: AGHT+IGkXAkN3Q14kO3huY9VOxkyFSlcXlgRN073mJecj/ahL42LaFJfICnOJ/iZcIbqx83xpsQf0A== X-Received: by 2002:a17:90b:4f48:b0:34c:c50e:9b80 with SMTP id 98e67ed59e1d1-34f68cb900fmr14009150a91.27.1768151495670; Sun, 11 Jan 2026 09:11:35 -0800 (PST) Received: from oslab.. ([2402:f000:4:1006:809:0:a77:18ea]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f5f7b1cc1sm15454063a91.2.2026.01.11.09.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 09:11:35 -0800 (PST) From: Tuo Li To: stf_xl@wp.pl Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tuo Li Subject: [PATCH v4] wifi: iwlegacy: 3945-rs: remove redundant pointer check in il3945_rs_tx_status() and il3945_rs_get_rate() Date: Mon, 12 Jan 2026 01:11:18 +0800 Message-ID: <20260111171118.203249-1-islituo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable il_sta passed into these two functions cannot be NULL, so remove the related null checks. Signed-off-by: Tuo Li Acked-by: Stanislaw Gruszka --- v4: * Remove the redundant NULL check instead of using WARN_ON_ONCE(), and update the subject accordingly. Thanks to Stanislaw Gruszka for helpful advice. v3: * Replace plain NULL check with WARN_ON_ONCE() and update subject to better reflect defensive nature of the check. Thanks to Johannes Berg and Stanislaw Gruszka for helpful advice. v2: * Return early for uninitialized STA il data and align D_RATE messages with il3945_rs_tx_status(). Add a wifi: prefix to the patch title. Thanks to Stanislaw Gruszka for the helpful advice. --- drivers/net/wireless/intel/iwlegacy/3945-rs.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/wireless/intel/iwlegacy/3945-rs.c b/drivers/net/wi= reless/intel/iwlegacy/3945-rs.c index 1826c37c090c..ecc6c8d2a4c5 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945-rs.c +++ b/drivers/net/wireless/intel/iwlegacy/3945-rs.c @@ -448,11 +448,6 @@ il3945_rs_tx_status(void *il_rate, struct ieee80211_su= pported_band *sband, return; } =20 - if (!il_sta) { - D_RATE("leave: No STA il data to update!\n"); - return; - } - /* Treat uninitialized rate scaling data same as non-existing. */ if (!rs_sta->il) { D_RATE("leave: STA il data uninitialized!\n"); @@ -627,7 +622,7 @@ il3945_rs_get_rate(void *il_r, struct ieee80211_sta *st= a, void *il_sta, D_RATE("enter\n"); =20 /* Treat uninitialized rate scaling data same as non-existing. */ - if (rs_sta && !rs_sta->il) { + if (!rs_sta->il) { D_RATE("Rate scaling information not initialized yet.\n"); il_sta =3D NULL; } --=20 2.43.0