From nobody Sun Feb 8 07:14:55 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43F733242D2; Sun, 11 Jan 2026 15:08:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768144139; cv=none; b=R7O+VJIud7qBf6InOdXVVlSSNLxhtw7+iRmZjBWtEqhLXMB6krnNGvNAxk5SM8bc0LiWPDTEgRB8tSzFnCdE7ai/Zd1GyJog5qpT1c6ljczBiNSmG/3utUtD3tMlHoP3ed1jQja0V0mz0o/NCxtXwyOE50OgOm3yMxKtZ+G2wkE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768144139; c=relaxed/simple; bh=1IvWH/Mj9ciASTXZ0msJfLzixE5NQiJWfQmENHb3U7s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pLG9k/gflsQmy3ukR3v3Vc06ELKVclVMT5HG2EfbumwrNTRWG23BD/y0jeMCg3cOPSjeBWrw/ScvikJ51A91Qhir6sOrN8tXk1K9HpAo9BC0RWynv20hNIbQIqd3VYdQKvit0Hcn2MNq78uaCcTgbB/ZTNCNq67/vt3zMT4HFQ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KU52g+ZQ; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KU52g+ZQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768144136; x=1799680136; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1IvWH/Mj9ciASTXZ0msJfLzixE5NQiJWfQmENHb3U7s=; b=KU52g+ZQzrb3NEn9UkF1MANK3raciniaWz40tQRjh/N1DmNq3SpsJfSE NChcwflPEWSqAFv6Ket2KKstKRx13WgblMVmqsuf+uBypmsvaHzR3fwKp 2poDnDsJtsMLKJZvgIGSVNaw4lfCS5aQpRCy4kgyh9JSnYPBW03tMKnwU yyQmpEt3zF31JreD3YjTw/cl4LqtQ6ApBETAQoIlbnVDyK122l6AgjQ/S nGpE1sfeXLCOxs8vScna/+cQb9e0QJ9jKMYTGohqJsTq2FlPn85xa9IOR z/bvDzxnAB0EvwS/J3HUxiQYP3Vpy1mnnMpkcPZYg5obze0S5hjMqpZD8 g==; X-CSE-ConnectionGUID: Dz8jcOm6RLGQqjH54mZ92Q== X-CSE-MsgGUID: rNpv3dr0QbGFy3GmdTyapw== X-IronPort-AV: E=McAfee;i="6800,10657,11668"; a="94915098" X-IronPort-AV: E=Sophos;i="6.21,218,1763452800"; d="scan'208";a="94915098" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2026 07:08:56 -0800 X-CSE-ConnectionGUID: gLthFed6TY6QMKWjERKRdA== X-CSE-MsgGUID: pYYDOS/JS8mi4xijA0YbJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,218,1763452800"; d="scan'208";a="203691152" Received: from sannilnx-dsk.jer.intel.com ([10.12.231.107]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2026 07:08:54 -0800 From: Alexander Usyskin To: Greg Kroah-Hartman Cc: Reuven Abliyev , Alexander Usyskin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [char-misc v3] mei: trace: treat reg parameter as string Date: Sun, 11 Jan 2026 16:51:25 +0200 Message-ID: <20260111145125.1754912-1-alexander.usyskin@intel.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The commit afd2627f727b ("tracing: Check "%s" dereference via the field and not the TP= _printk format") forbids to emit event with a plain char* without a wrapper. The reg parameter always passed as static string and wrapper is not strictly required, contrary to dev parameter. Use the string wrapper anyway to check sanity of the reg parameters, store it value independently and prevent internal kernel data leaks. Since some code refactoring has taken place, explicit backporting may be needed for kernels older than 6.10. Cc: # v6.11+ Fixes: a0a927d06d79 ("mei: me: add io register tracing") Signed-off-by: Alexander Usyskin --- V3: reword commit message limit Fixes to 6.11+ V2: reword commit message add Fixes and stable drivers/misc/mei/mei-trace.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/misc/mei/mei-trace.h b/drivers/misc/mei/mei-trace.h index 5312edbf5190..24fa321d88bd 100644 --- a/drivers/misc/mei/mei-trace.h +++ b/drivers/misc/mei/mei-trace.h @@ -21,18 +21,18 @@ TRACE_EVENT(mei_reg_read, TP_ARGS(dev, reg, offs, val), TP_STRUCT__entry( __string(dev, dev_name(dev)) - __field(const char *, reg) + __string(reg, reg) __field(u32, offs) __field(u32, val) ), TP_fast_assign( __assign_str(dev); - __entry->reg =3D reg; + __assign_str(reg); __entry->offs =3D offs; __entry->val =3D val; ), TP_printk("[%s] read %s:[%#x] =3D %#x", - __get_str(dev), __entry->reg, __entry->offs, __entry->val) + __get_str(dev), __get_str(reg), __entry->offs, __entry->val) ); =20 TRACE_EVENT(mei_reg_write, @@ -40,18 +40,18 @@ TRACE_EVENT(mei_reg_write, TP_ARGS(dev, reg, offs, val), TP_STRUCT__entry( __string(dev, dev_name(dev)) - __field(const char *, reg) + __string(reg, reg) __field(u32, offs) __field(u32, val) ), TP_fast_assign( __assign_str(dev); - __entry->reg =3D reg; + __assign_str(reg); __entry->offs =3D offs; __entry->val =3D val; ), TP_printk("[%s] write %s[%#x] =3D %#x", - __get_str(dev), __entry->reg, __entry->offs, __entry->val) + __get_str(dev), __get_str(reg), __entry->offs, __entry->val) ); =20 TRACE_EVENT(mei_pci_cfg_read, @@ -59,18 +59,18 @@ TRACE_EVENT(mei_pci_cfg_read, TP_ARGS(dev, reg, offs, val), TP_STRUCT__entry( __string(dev, dev_name(dev)) - __field(const char *, reg) + __string(reg, reg) __field(u32, offs) __field(u32, val) ), TP_fast_assign( __assign_str(dev); - __entry->reg =3D reg; + __assign_str(reg); __entry->offs =3D offs; __entry->val =3D val; ), TP_printk("[%s] pci cfg read %s:[%#x] =3D %#x", - __get_str(dev), __entry->reg, __entry->offs, __entry->val) + __get_str(dev), __get_str(reg), __entry->offs, __entry->val) ); =20 #endif /* _MEI_TRACE_H_ */ --=20 2.43.0