From nobody Sat Feb 7 17:55:28 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1925341AB1 for ; Sun, 11 Jan 2026 14:12:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768140773; cv=none; b=okogde/PaTXDuAxW5YPHI/o4qUdbM8e+nN0bTfjXW0bKqT0fhk7+GKgdMrxdEdpgGnVWC7G2GQGnFnfEKcvDQoRFP7jxAxRicECoTfghnGjAk8BBPIEfkGj3/Hi0VuWwUTTYfZi7pPhFRgA5acUS3mTYplkB92ueqA0CJg0RDD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768140773; c=relaxed/simple; bh=eVpkNiFVHfH0/sNd7362yHUpEuHM+9miY/Q47hr5Zts=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tb+RpKdm7J3105gtLrodgBy9tNtvPd0UwcAY5D+eK8bW+WbwImD4JllwjVvvpJ1Jci26jBE2VHHhW2reLEcdKFnNbsEq8Vd/edOV+JW1HzMJc8xx4HFC81+z4jL7II7SPvXUkEfB60k0p4uVhCPQVGeOuTEYXnchJiKtQmp1eBU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KUVNQW0J; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KUVNQW0J" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-29efd139227so40028965ad.1 for ; Sun, 11 Jan 2026 06:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768140771; x=1768745571; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zLgHxTzKOaGHrCs2i3lpveP4dS7RixUlZ8uZ0dmDPaw=; b=KUVNQW0JD/FoDD1xAWrqNN3Ch0O7++bXc8f08jFHGbbpsZ3IsLraflEesHKm06t+nw MieMwGdQiUi7ahRHDlEsHvFHJ9o90tHodUM4PkwwQx4Fqf2O4lOZXG7/j1wmKbYjMOpw mcgRFzbSNiokYgDZsrEec3mdwLsUAQEL7lmv56nPtK7nH0QIr7HJSkzuXgX8CW/k/nL3 AY+w270xsb1JMzwJ+xOoqkD2UMKhHWd+a7lFa3bdK52KAgn2mfnWsTBXxQUDhw8CxhMQ vlX2atXx/SH4MF3xNRaXzghSohFjMVFMOPJzM6/e1AUOh0LLQDp0aj3/GMjfBmKbCu23 Y34A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768140771; x=1768745571; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zLgHxTzKOaGHrCs2i3lpveP4dS7RixUlZ8uZ0dmDPaw=; b=njI8/bx+MTpXaLicH0YSh148rnKYZep0kND3XbG1IjM1mFwaaBl8ZeFxEQP+aLEumJ mJ2VrjRYZIpc+sb6pA97l0wJTNSF/m3oF7kLFT/RwITDi/Poe2cdYGPVkxa5ZafeAVdP uAv+OmqAJAdCqR5pZVcR9I/c4PUzbynUbqi0HdJ+QkyiG0/Oi0Bodb5d6qj//u4FvMtU vLpNuxitmT56RprjKRlieOojGkblm5t7882QPd3DhX1GoXJ7Zy+zr2/g2HrYcqLICMsM FRWyzoLYooI8AUCxqf9p+M1NwXjaEPCouCM28J4makhi1OJU0jYWu4ZwOpx3mEBjCmy/ hw+Q== X-Gm-Message-State: AOJu0Ywqj79PCmtYzTpnFybT26rZHn24rhljn+4+RkesCaeSTR0+kInd 5+c+AdV7hUjq9RmmlzyCNVz9J2zbMAp1Ltod0D79yUdNmYofXxxHvbEp X-Gm-Gg: AY/fxX56OsnAQn7iAZiYvLmzi7d3cUoSXWrCcsGEVM4FOMFQ/Z7LPOrXib2Mk3quie3 Qr0M9BgB2dw4sqmu63Wbvnt8lxb2U9HshPaMcZCYxqbSVZsJsHN8wdAKK2aUGm1pbsNSpGECncL vVxsbyskhVokmr5GIu4kyokpJe+kIymzvZrWJ0+Pm8IVh77Xmcy5NUZFYRjAq2m0h7knaGkFow3 sgAOuZCmCsVVDGIUR28hs53mm1XezjxP/0CkhBNg91bVIWMmfsDBdie2vWhv9P3zPXuiPLVOwh5 fqR8lAdsyH8735CHzV6yY+bQbm5CxHNbT4vs8z041+zkrmp2R+DPQaXhDUsvn9V901Du2d/gf2k kkehE2vs5JbHu+Xk4/L9eqJU7M2x1vMUTQnii0v/ZqFCCnMvv44R0CqrDqxHnnhAipFswjpbCPv 7hEZ8jUYkmWnpjoWFQkiY6KkPASA== X-Google-Smtp-Source: AGHT+IGbFJmJOYDLuNja261zZ8Hot4TyrJjHnokveJphC1DV4zTURdk7VUWhK+csfOHK3cfpvEaRVw== X-Received: by 2002:a17:903:1c8:b0:29e:97a1:76bc with SMTP id d9443c01a7336-2a3ee458f0dmr164155395ad.21.1768140771023; Sun, 11 Jan 2026 06:12:51 -0800 (PST) Received: from gmail.com ([2402:e280:3e9b:22f:df65:ffa4:d9b6:3e58]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cc794asm150766705ad.70.2026.01.11.06.12.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 06:12:50 -0800 (PST) From: Sumeet Pawnikar To: rafael@kernel.org, linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, sumeet4linux@gmail.com Subject: [PATCH] powercap: Replace sprintf() with sysfs_emit() in sysfs show functions Date: Sun, 11 Jan 2026 19:42:36 +0530 Message-ID: <20260111141237.12340-1-sumeet4linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace all sprintf() calls with sysfs_emit() in sysfs show functions. sysfs_emit() is preferred over sprintf() for formatting sysfs output as it provides better bounds checking and prevents potential buffer overflows. Also, replace sprintf() with sysfs_emit() in show_constraint_name() and simplify the code by removing the redundant strlen() call since sysfs_emit() returns the length. Signed-off-by: Sumeet Pawnikar --- drivers/powercap/powercap_sys.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sy= s.c index 1ff369880beb..f3b2ae635305 100644 --- a/drivers/powercap/powercap_sys.c +++ b/drivers/powercap/powercap_sys.c @@ -27,7 +27,7 @@ static ssize_t _attr##_show(struct device *dev, \ \ if (power_zone->ops->get_##_attr) { \ if (!power_zone->ops->get_##_attr(power_zone, &value)) \ - len =3D sprintf(buf, "%lld\n", value); \ + len =3D sysfs_emit(buf, "%lld\n", value); \ } \ \ return len; \ @@ -75,7 +75,7 @@ static ssize_t show_constraint_##_attr(struct device *dev= , \ pconst =3D &power_zone->constraints[id]; \ if (pconst && pconst->ops && pconst->ops->get_##_attr) { \ if (!pconst->ops->get_##_attr(power_zone, id, &value)) \ - len =3D sprintf(buf, "%lld\n", value); \ + len =3D sysfs_emit(buf, "%lld\n", value); \ } \ \ return len; \ @@ -171,9 +171,8 @@ static ssize_t show_constraint_name(struct device *dev, if (pconst && pconst->ops && pconst->ops->get_name) { name =3D pconst->ops->get_name(power_zone, id); if (name) { - sprintf(buf, "%.*s\n", POWERCAP_CONSTRAINT_NAME_LEN - 1, - name); - len =3D strlen(buf); + len =3D sysfs_emit(buf, "%.*s\n", + POWERCAP_CONSTRAINT_NAME_LEN - 1, name); } } =20 @@ -350,7 +349,7 @@ static ssize_t name_show(struct device *dev, { struct powercap_zone *power_zone =3D to_powercap_zone(dev); =20 - return sprintf(buf, "%s\n", power_zone->name); + return sysfs_emit(buf, "%s\n", power_zone->name); } =20 static DEVICE_ATTR_RO(name); @@ -438,7 +437,7 @@ static ssize_t enabled_show(struct device *dev, mode =3D false; } =20 - return sprintf(buf, "%d\n", mode); + return sysfs_emit(buf, "%d\n", mode); } =20 static ssize_t enabled_store(struct device *dev, --=20 2.43.0