From nobody Sat Feb 7 21:11:54 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E4482147F9 for ; Sun, 11 Jan 2026 09:00:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768122056; cv=none; b=HZgbEHxWa/4bSFSvWeVOoWBlvrPGKi83w67PpsjmXJyZ4w9KMMsk/bQ7fFzBYvsxjt22sz9wpUWKjXi8SvbCoP+4lhEZUc6PPhUUgsDTcyghAw3ita0ki9Vdv7YWFL63KciqQnqueKd1htfD66Dz+FhbOLr5I0duM1sLgYSan08= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768122056; c=relaxed/simple; bh=Y4vCL0OdjuIIqRuEVYRP3TW8r2JvKvHJbNaCBR+2KLw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=vEtmD/n3q8PpfYJjO/Th/R1xb9Hgo8y5qKvmNz6hXSZ6cT4ZU2Eggy75/K8q3jfbFn5fgc2NJQptfccPvbxg+iMzpXosfHR+uqC9i21AYIC2kkpdoI2y3hXHtCi8ROnQLgKvGxdVE4KDZugjQ+3nWXUvREnVORM25JVWaH2QE5o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fm8yogzp; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fm8yogzp" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2a3e89aa5d0so41695125ad.1 for ; Sun, 11 Jan 2026 01:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768122055; x=1768726855; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qlGMuJxryxU2LDg8VqPoXHjOSQMsoQxzQvU3EG1Fpac=; b=Fm8yogzpormyMoipLtQLNvWgRZBXB6BMLEf/FeQ1A5sdLSe66OLzyMbqng9m5wzd6T tzWeexILnH+6/vTPZFOEUBZwdX+VnsjcyKlz/L0eHPlF3puqdIivpK5BYrdCuYkqRtoO dQOEOtmSiCfLvCVQa6r+nf05AgpE9JSq7g+yR61Tyn7e9YQOxvOOaIA5WnbvcVhdRtCP GKQZqof86dpjac9uuaV7pSL+qUyi8D5beQx3pa5VAFJdSP9f2ObDZwDAvvvcwnNaEBk+ /F3ObFd7/9JfHfUNDihF7gCyjGd+re1fUL/ihRmacM1n5v9wG83yLhivNttcNSSx81oo uB+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768122055; x=1768726855; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qlGMuJxryxU2LDg8VqPoXHjOSQMsoQxzQvU3EG1Fpac=; b=I1Olr1zZ/1k5WumzMnIgfIFRlv25KzcWf27APSpwccBqU9A7+QerClvezyRCSBL1/K JhSgWP23GOA9TIPD+ACylOQfoxrqXVfpyFY0vnCVzRMpzdRzWQc0D8EmrnZfSGRZIXMj WKfKF6XyWvMsz6p+Fb5HTXylW+qn+ybLHGTkSPEQ6SzyKWRea0wJIvt5W6Mum9Hlitd7 Rx/5N7vd6PE0VRSEvYdFVgKQhzY0tI7gk10Oh7ijv+CQJL+4z9NHZ+zseM4noQ9G6arf tY3yVta0BIRQiw1kreHvSFqRMJ2Rjyg0Q3TUYwnI5g2mQR+kmXHBjkchxFdktjiJFdi9 YLnw== X-Forwarded-Encrypted: i=1; AJvYcCXNQZ3NtP3Kc1iNPY0RTxjC49H7zHVHIP+SqiWcfWVMhRLF6hsTCD9kViBPInIdlctH3IGd//KJoClM2co=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2l528qcp5Sq7w3FuX241Csu6fVJCEnspi6VG58ObcdMwneZRg D53StrodxRJAK9LP6VbPBR7y0+9Uf9T9G70IfpuAUfNEuqYe1YYnf/ZwZzeYBg== X-Gm-Gg: AY/fxX4zVNMiLpoZU+23ZgSNaiiJBVF0u8HUXofEE7VqNDE+WccpWcJVKmZlnBiZ6LM FS3NETkOM37XmsuWBLuKqMZWuFb8yQq4uhhziMHHrCZjHhghzayB+xQthbn7MYozyBtMbR5zj+N Lvbvj+oNDjzrbYiJdzIaIJM1DjqLg5AadjxwtXrBsKGl43IYnd88HUpJyeBVN9gW93yBj6FgJwZ YhA8Oq3GUnKJBkdZJS7xpw+jmXuS33jX3e+5CjU79x1D1Pm7iQE3kMYWjyasYCaOl7pi/k5A09+ J0CW1capntHOwvkP0Wr/a7ssN1HfweWvQHTHp1+0G0Mam+/hZoLywFb2SHdxqRIrjYY401p1uN4 UM57lSVPBi0yUFM0gMgFWnJfsStS79G4j3jEiclNIi2QR+ZkzYckeZ1LJMMKTXU05Rc2dhY0aOU zbnqCIwUiZVzqtWCFJkR8s1VMOq1IwCzE3UqkA X-Google-Smtp-Source: AGHT+IGIBfievlyhlC6c3vxyTuM6NL3sYbtm1b6AEZrGT8edzCveVLripArVSNzPdlyJeW9v3fdAhw== X-Received: by 2002:a17:903:2385:b0:2a2:bff6:42f2 with SMTP id d9443c01a7336-2a3ee415695mr139274195ad.6.1768122054907; Sun, 11 Jan 2026 01:00:54 -0800 (PST) Received: from LAPTOP-PJU7MKF4.localdomain ([157.34.27.242]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cb2c0fsm145486185ad.66.2026.01.11.01.00.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 01:00:54 -0800 (PST) From: Anubhav Kokane To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Anubhav Kokane Subject: [PATCH] staging: rtl8723bs: fix comparison order in rtw_ieee80211.c Date: Sun, 11 Jan 2026 09:00:34 +0000 Message-ID: <20260111090034.9323-1-dev.anubhavk@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch warning: "Comparisons should place the constant on the right side of the test". Move the constant _SUCCESS to the right side of the comparison operator. Also fix whitespace around binary operator '+' and wrap lines to fit coding style limits. Signed-off-by: Anubhav Kokane --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ieee80211.c index 8fdeeda88..f45ae5d5f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -1009,7 +1009,8 @@ static int rtw_get_cipher_info(struct wlan_network *p= network) pbuf =3D rtw_get_wpa_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwork-= >network.ie_length-12); =20 if (pbuf && (wpa_ielen > 0)) { - if (_SUCCESS =3D=3D rtw_parse_wpa_ie(pbuf, wpa_ielen+2, &group_cipher, &= pairwise_cipher, &is8021x)) { + if (rtw_parse_wpa_ie(pbuf, wpa_ielen + 2, &group_cipher, + &pairwise_cipher, &is8021x) =3D=3D _SUCCESS) { pnetwork->bcn_info.pairwise_cipher =3D pairwise_cipher; pnetwork->bcn_info.group_cipher =3D group_cipher; pnetwork->bcn_info.is_8021x =3D is8021x; @@ -1019,7 +1020,8 @@ static int rtw_get_cipher_info(struct wlan_network *p= network) pbuf =3D rtw_get_wpa2_ie(&pnetwork->network.ies[12], &wpa_ielen, pnetwor= k->network.ie_length-12); =20 if (pbuf && (wpa_ielen > 0)) { - if (_SUCCESS =3D=3D rtw_parse_wpa2_ie(pbuf, wpa_ielen+2, &group_cipher,= &pairwise_cipher, &is8021x)) { + if (rtw_parse_wpa2_ie(pbuf, wpa_ielen + 2, &group_cipher, + &pairwise_cipher, &is8021x) =3D=3D _SUCCESS) { pnetwork->bcn_info.pairwise_cipher =3D pairwise_cipher; pnetwork->bcn_info.group_cipher =3D group_cipher; pnetwork->bcn_info.is_8021x =3D is8021x; --=20 2.43.0