From nobody Sat Feb 7 17:56:17 2026 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31E511A254E for ; Sun, 11 Jan 2026 08:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768120431; cv=none; b=drZqvqfNRgRodHpr/E32dedOTrxVF1opBGWLAU8uQK5uR4I/MRDNgp6U8rXJVIyS73hQ9Gm4sZNNFvm74M+Mr5Lz1+tJ4gG2Ktbga4/R3TsAakaRAhIOYmiiU/gS+9Ip/yiEGYhvWIlxweoIMm2gr1Fud8m4JsPCb19CQqiFIa8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768120431; c=relaxed/simple; bh=6wvpO0lYKIGisoGjhW0e60XMj9sd2cj2UORY3Q9xLcI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=POEtgr27foiL08WCoEKIOQPPQ25ijD9wBjNgPJ2slOTGYdRgu/mFCmrlR+oQCXpma79yOTUS5vb/IwcY68POEpbSRUNEtXbu4ZCalLMn7I9vy72wKjpp/xs1nRFxFRfbj+Zrc07jVE4OlrBHcnkQ9l8kkCcpTgHegNFsYShvUhA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool; spf=pass smtp.mailfrom=packett.cool; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b=qoGoe48T; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=packett.cool Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=packett.cool Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=packett.cool header.i=@packett.cool header.b="qoGoe48T" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=packett.cool; s=key1; t=1768120418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Ux7+L8GdWa+BGmZjE13E9fDY0FV4tnAQh5DK+4QXmOI=; b=qoGoe48TTGICHppYaaIy9R8DzUEq+cadvlhdJQ3Fna6nOBAsyouOTIHTPIz4nAEupqOe8A ZxCyefoGq1D/gA089uX21uJcL2qkWGSRiT1+4iYD9w9yw7Zi2udPJ/8bCSe8FPtjzWOeGG Jb5pZO1DkMcufNkbvEu4g2NfAo9GcAsmRKL94ob/gkwOZzRbW0E4sLETldWvIjviYiiEe4 f0qBjzgiOeGMEHDaXyNsC403+n0ocwxupUQun6gzX9Q6aOIVdT3y26LluRI3JSF/QMQ0Xl xfK8HQ/FSC+NfHZy6d19JFawgZL3UdiDzM75kFvwyMEGzNHcZxJlIamlQ+8+wA== From: Val Packett To: Vinod Koul , Neil Armstrong , Abel Vesa , Dmitry Baryshkov Cc: Val Packett , Abel Vesa , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100) Date: Sun, 11 Jan 2026 05:25:59 -0300 Message-ID: <20260111083317.604754-1-val@packett.cool> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" For Glymur SoC support, the com_clk_fwd_cfg callback was added, and a stub implementation was added for the v4 of the hardware. However it was omitted for the v6, causing a NULL pointer dereference oops on Hamoa/Purwa (X1E/X1P) SoC devices. Fix by adding the appropriate stub. Fixes: add66a6673bc ("phy: qcom: edp: Add Glymur platform support") Reviewed-by: Abel Vesa Signed-off-by: Val Packett Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Reviewed-by: Neil Armstrong Tested-by: Yijie Yang # Purwa-IoT-EVK --- v2: pull R-b, reuse v4 function as suggested by Konrad v1: https://lore.kernel.org/all/20260109045214.5983-1-val@packett.cool/ drivers/phy/qualcomm/phy-qcom-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy= -qcom-edp.c index 13feab99feec..7372de05a0b8 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -758,6 +758,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v6 =3D= { .com_power_on =3D qcom_edp_phy_power_on_v6, .com_resetsm_cntrl =3D qcom_edp_phy_com_resetsm_cntrl_v6, .com_bias_en_clkbuflr =3D qcom_edp_com_bias_en_clkbuflr_v6, + .com_clk_fwd_cfg =3D qcom_edp_com_clk_fwd_cfg_v4, .com_configure_pll =3D qcom_edp_com_configure_pll_v6, .com_configure_ssc =3D qcom_edp_com_configure_ssc_v6, }; --=20 2.51.2