From nobody Sat Feb 7 17:04:24 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 345852D5432 for ; Sun, 11 Jan 2026 07:45:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768117515; cv=none; b=AItsdLHlAuCMMo0q3HQg+fK9jBUKjJzRJaLhtMBr66FBiQeo1fwxkox3DT0F3wCSXbIvjufusAiXz0NULK0RaqmNMP3xXd/M9BbrJRaVBWLOvTu94HGEiq/XKua7aonyVty7j1A7z4SUrCcVMCKHEGUoFyDZBXhzwLhBgSQzkNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768117515; c=relaxed/simple; bh=Gs3m8L2qq+QH3AO0+Vqw9/jrUEa9x5rhE92DShVyB+E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HP09/gXcGrNWT12M3ngE3W8CtmqC2eZvFiRQMcssMF+Er6g/okHr34YtAhS+gn8gsTzvscIZzmHbwYyO03iEoFg2h9dchRjvjYhUdpGwvuHzTIYtedQDdAYr5N3+PlXbbGGtRuaEEucVtNSfjXQl3e1QkJvfWhgYdHC2HU9IoiM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HnCVInmT; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HnCVInmT" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a09757004cso51204115ad.3 for ; Sat, 10 Jan 2026 23:45:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768117513; x=1768722313; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ErDkSB/YcKlAv/NjNwMo8qsmxcHYpWxJ6GLrwPIMkds=; b=HnCVInmTiCeFJcLdA+Ev/0bWjSL+1wUb+QaZVvW3RAHd8xk/kPZr+J18LExTGwH3as EVDc6KyTxwGKdgewnMC2g+2KmYyo1gC5btpxtoQ8SwujsLrxdYx60ls8WuS5ike+Xia4 3yEUJsR+/Wmh7tyJ63QvMReZGDchkJNKUyzfBed/Ir6qiM6px2Ooo/4lTrsER5P40fZ2 LoS6Cuyu5BnlQMAjpG4U5t7TwlUMC3Mpf/1POtU8EMQc/QQw8sKSP1OwcGtos8NNHqsV D4aYABSia4fxZqfC+sEmhrBiet43+ED3PzYHF+sr177FCnq297HOQ3DS3ERWKi0uKF1/ 5nuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768117513; x=1768722313; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ErDkSB/YcKlAv/NjNwMo8qsmxcHYpWxJ6GLrwPIMkds=; b=Jm7b0tsmUH7ZJtTwrzowmhLZdBePTGdTI4QG5NhKWR+2mDXXiKQhDJ4p2v6Q9TsU1i awGOdoPtctpsivA4Upqthn3YY0ZOEnCd8RNo5YFIeX7hpjczMTcZSvMMOOEogmY74MYc 4zDcdbvv60noD3xLxZwjX2kbo8n168t4+56g1+FgBHbK1N7VAY8RG12DKZrjEeOFRSDz stMgcoxf9SsJbV9KU9O7z8UiZ0t9Nl0ZaOtKeSGQfEcBHPGnwWKIa+4KhBmBLj8l8k7X gMJQ/g7g9gER84rj9geEC2o1sRZxLOzDRgxB6UM7p2i+0t9s1fna8oI3sqCVekz1bsey K9uQ== X-Forwarded-Encrypted: i=1; AJvYcCX/MeJvyr3HtbmhoQaDNgBDv4ovawHUU2Ksrm66e9aoo5IRAkGlkzLirHvYE61febVhtOiHadxmnKr52UE=@vger.kernel.org X-Gm-Message-State: AOJu0YxiovQxhDa7YgmHiwuD3T9MOEDDT/8qUz/0yjWKXlaGyZf8XAme 7JqY4XkbUEgje6gK3+RrV5dsUnkjLwctZQB77slyDG69ETMSYGF0fRKl X-Gm-Gg: AY/fxX62m7mDEIaN/wnhzLR1//dy5o6YhhqTUMb5q/LSJZbc8GDHl5jsjpwAKqWh2I2 sLMpDlMgcoc6BZ8MhzY9LcxijuQYDuKzR7K5Txt1eT6oYs6SeOZUQt3J9KOPO6qMKG8Ds+zfdZH mMtIyqZVpLvsUOe/4TgWE0Hyp6K9ubHklgKkMWcEF5vsQA06d3HSc71gs2VFCcRHqEM3Jg5NAa4 KXEToum0QuUc3EzIf3y0mTEm0ghI9WOhiKPDJ6hqOaAvNBc+on5TM28b+TJ6VH7U+MDGxO0bwjs tZiPXA5CKba0HMxZZMnvlmGUANoY3qCgY3qLbTDH0ezoDYYHjSoorzmyxi9VMKhsOM1X2uCJrj0 m1DHelnHQaiIlwmFhrASXKfCnNOWRt/iAuEE8PyVhdri+5SHdSHLyKQFRiXKI5RcxbxLN/BxPwm 10GH3Rh2VasKFTJQWsKQLq9Ztzgj5b0rWgnNd/RO6t X-Google-Smtp-Source: AGHT+IHEY2L02vHLsHgqVo8Ud9CELmE+U6IhLRIOoCjAfiREzCyIRITc84zZTfAj9tRvsfC/hMJRLg== X-Received: by 2002:a17:903:1b4f:b0:2a3:bf5f:9269 with SMTP id d9443c01a7336-2a3ee4151f0mr155587325ad.3.1768117513511; Sat, 10 Jan 2026 23:45:13 -0800 (PST) Received: from localhost.localdomain ([113.218.252.40]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cb2f8asm145284015ad.57.2026.01.10.23.45.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 10 Jan 2026 23:45:13 -0800 (PST) From: chengkaitao To: davem@davemloft.net, andreas@gaisler.com, akpm@linux-foundation.org, david@kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com Cc: kevin.brodsky@arm.com, dave.hansen@linux.intel.com, ziy@nvidia.com, chengkaitao@kylinos.cn, willy@infradead.org, zhengqi.arch@bytedance.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v5 1/2] sparc: Use vmemmap_populate_hugepages for vmemmap_populate Date: Sun, 11 Jan 2026 15:44:52 +0800 Message-ID: <20260111074453.66728-2-pilgrimtao@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260111074453.66728-1-pilgrimtao@gmail.com> References: <20260111074453.66728-1-pilgrimtao@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chengkaitao 1. In the SPARC architecture, reimplemented vmemmap_populate using vmemmap_populate_hugepages. 2. Allow the SPARC arch to fallback to vmemmap_populate_basepages(), when vmemmap_alloc_block returns NULL. Signed-off-by: Chengkaitao Acked-by: Mike Rapoport (Microsoft) --- arch/sparc/mm/init_64.c | 47 ++++++++++++++--------------------------- 1 file changed, 16 insertions(+), 31 deletions(-) diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index df9f7c444c39..858eaa6615ea 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c @@ -2581,8 +2581,8 @@ unsigned long _PAGE_CACHE __read_mostly; EXPORT_SYMBOL(_PAGE_CACHE); =20 #ifdef CONFIG_SPARSEMEM_VMEMMAP -int __meminit vmemmap_populate(unsigned long vstart, unsigned long vend, - int node, struct vmem_altmap *altmap) +void __meminit vmemmap_set_pmd(pmd_t *pmd, void *p, int node, + unsigned long addr, unsigned long next) { unsigned long pte_base; =20 @@ -2595,39 +2595,24 @@ int __meminit vmemmap_populate(unsigned long vstart= , unsigned long vend, =20 pte_base |=3D _PAGE_PMD_HUGE; =20 - vstart =3D vstart & PMD_MASK; - vend =3D ALIGN(vend, PMD_SIZE); - for (; vstart < vend; vstart +=3D PMD_SIZE) { - pgd_t *pgd =3D vmemmap_pgd_populate(vstart, node); - unsigned long pte; - p4d_t *p4d; - pud_t *pud; - pmd_t *pmd; - - if (!pgd) - return -ENOMEM; - - p4d =3D vmemmap_p4d_populate(pgd, vstart, node); - if (!p4d) - return -ENOMEM; - - pud =3D vmemmap_pud_populate(p4d, vstart, node); - if (!pud) - return -ENOMEM; + pmd_val(*pmd) =3D pte_base | __pa(p); +} =20 - pmd =3D pmd_offset(pud, vstart); - pte =3D pmd_val(*pmd); - if (!(pte & _PAGE_VALID)) { - void *block =3D vmemmap_alloc_block(PMD_SIZE, node); +int __meminit vmemmap_check_pmd(pmd_t *pmdp, int node, + unsigned long addr, unsigned long next) +{ + int large =3D pmd_leaf(*pmdp); =20 - if (!block) - return -ENOMEM; + if (large) + vmemmap_verify((pte_t *)pmdp, node, addr, next); =20 - pmd_val(*pmd) =3D pte_base | __pa(block); - } - } + return large; +} =20 - return 0; +int __meminit vmemmap_populate(unsigned long vstart, unsigned long vend, + int node, struct vmem_altmap *altmap) +{ + return vmemmap_populate_hugepages(vstart, vend, node, altmap); } #endif /* CONFIG_SPARSEMEM_VMEMMAP */ =20 --=20 2.50.1 (Apple Git-155) From nobody Sat Feb 7 17:04:24 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5BD12D7DD9 for ; Sun, 11 Jan 2026 07:45:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768117522; cv=none; b=O6ZzeNU1r+TJb1f2V0oS/gQpob7oQqUWMSizOmVRqBmEddV96xNB0x5EMsvmrqra7rfFYvoxT6CoOlU3VU/lVUwBeguVkQ8uIi8SED/rTVNlDeCt+ImuGuyFyd36SgPbGg4ZwPxAy8Xbnkf6wm5ecsqdNyp2JTZkIfQXPwzM9RA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768117522; c=relaxed/simple; bh=ftOvATG5TQoFVZofhRiW6lDAK89ZL2/+jXBI/hCnadc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TBtgq6U232NwWi/Ej6vL1CQekw8f/H92LyZFGQSaDUdxqbuPYINxcp0xMt4HJs+An0eu1YRV46TiL8Lkj/lX0g5l6tY7GBEfNUnF1omz7nm9HIaaB5eYcPTlTn7UeHrYnBj6GlQ8VQM5lvHFbfOctIheOPdF5spXnSwV83rhVrU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j9R44GW5; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j9R44GW5" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-29f102b013fso53391925ad.2 for ; Sat, 10 Jan 2026 23:45:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768117520; x=1768722320; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3W1VRgdJWZtP/35+X4BFxHc1/Q/0kqoYu2dyr3n8ICY=; b=j9R44GW54bTdBJlOS7ugf86EmDN5T0FczdON3ei7DmBmCQ24z3cLzgkaG93tHtDDUs mMb5KlKa3kHS6c4YR8CyrFhNdKVZkmVbaVxppphY8puyO5I2/SPrgZxfXCAuPJhK9lrZ yYriOlsXGw+ivLrFSdjoild6xoRIoiZE9eA14TStoRky0bRt4Fjasez7l2Zerc/dJ31e VLOXWc6A89fc8t1asC6IISaGnsEyNdJAR+5BSjoOTDfrVzYry7x718GrqSjHs9JPR22A id2IfMydryFhtmmEAeVYM0K4SQU6FS5HevIEoZnHwOMRqc4io8NTMtol1suQyiOIwt/o h/ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768117520; x=1768722320; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3W1VRgdJWZtP/35+X4BFxHc1/Q/0kqoYu2dyr3n8ICY=; b=VtUJv4JbKPe8GIeROnmYIEBm1PG/pRfWNTzP/UZeIPjP7RoRvdLnHR2fkA6mzsPhrW QGSR1jfcwaFcqfi3liJ/8ErYKRJT7oUevu8FwLVPBhIDmzH0nVp/IOcbhTuCNsC5SGIj GrJdZqjXCZcX3c5nA98DX/P9jGuupicbmVOEBK4ulrYZmrlAWOngH1k5Ui7+PVhCyzXJ 5mTRq/w9hnaoIonp/qFir5VCVAVdUd1HEV5yYWYiu1xTL6FyjIaUqJ+tDBlIpL44b3T2 it34PXG6tF6rDED0mNYuMstmdByf9XnKdL3cK4INN4LHBLsncgVVVsqdYkT8bWrPV27R MPWw== X-Forwarded-Encrypted: i=1; AJvYcCUNUIjZDTuLePn//gow63su4oT+SkOfSf+2vcJn0nzO1sxuqQnI/OoTsy4HNm8GLuJf26fvNZGaKlcvGHs=@vger.kernel.org X-Gm-Message-State: AOJu0YwZz5ZnjtuL/qROsXGHjCwMTJtvFKNiHuOWNBTrbC5IqITXOfMI lECZsYAqmxrQx2vMGdP188bxU9TB8TaMjFHtFlvKIL3lzYoqN28YJYAl X-Gm-Gg: AY/fxX6KR9zDbPHQsspbdlwDh5OOW2nV+pQZsIs8iTEZS9G4azPuEceGOaWaWlgO/KW eyJ16bM+Li10Bv54yMJsdbD5UUvq/SPfeQ/W4Y3QZ/VTjmUsLfO8XgaUlHubx1UES7YkB7tZ8ls dCmSvVPoh2GYmUTdq5gm8JahMWDdnwzBLQ1S+AdFYh1OcmwctVYydudhlP5KqAu7JhVSiLVqpxS vdYAvU3+BnVieIQwFRGmGZ3+BPwu9ALhsMzvraSBQXLV+KbJZtr2mS/HVFt29AYlbzvyy6WuO5I A0UYubfquco7GgsIrH8YigxXqVgN1aN3obLeLlPgX1pTDAxlYlT0MPVrhO9zIdG8BiranKV/UeV E2XXigMy9bQoRBbJ5dT6oFs3zXkO/BXWyam3PRCO1fcZrfmFzAoHo7fXB+4buZ4kZJr3aUVsqBx H1uiXlALueLVQFQ29ZkyHP42YsAjnhjTp521rHe4Ci X-Google-Smtp-Source: AGHT+IFOxUt1YWvqb3kir1Ky7DSpkYbp7DHua/UbMFooiLjcrZeFDAph0g0fbWDK+tgumDDxk8azBQ== X-Received: by 2002:a17:903:2348:b0:2a0:d431:930 with SMTP id d9443c01a7336-2a3ee4b244dmr150938675ad.47.1768117520166; Sat, 10 Jan 2026 23:45:20 -0800 (PST) Received: from localhost.localdomain ([113.218.252.40]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cb2f8asm145284015ad.57.2026.01.10.23.45.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 10 Jan 2026 23:45:19 -0800 (PST) From: chengkaitao To: davem@davemloft.net, andreas@gaisler.com, akpm@linux-foundation.org, david@kernel.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com Cc: kevin.brodsky@arm.com, dave.hansen@linux.intel.com, ziy@nvidia.com, chengkaitao@kylinos.cn, willy@infradead.org, zhengqi.arch@bytedance.com, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v5 2/2] mm: Convert vmemmap_p?d_populate() to static functions Date: Sun, 11 Jan 2026 15:44:53 +0800 Message-ID: <20260111074453.66728-3-pilgrimtao@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260111074453.66728-1-pilgrimtao@gmail.com> References: <20260111074453.66728-1-pilgrimtao@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chengkaitao Since the vmemmap_p?d_populate functions are unused outside the mm subsystem, we can remove their external declarations and convert them to static functions. Signed-off-by: Chengkaitao Acked-by: Mike Rapoport (Microsoft) --- include/linux/mm.h | 7 ------- mm/sparse-vmemmap.c | 10 +++++----- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 6f959d8ca4b4..322fe72b6ebd 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -4234,13 +4234,6 @@ unsigned long section_map_size(void); struct page * __populate_section_memmap(unsigned long pfn, unsigned long nr_pages, int nid, struct vmem_altmap *altmap, struct dev_pagemap *pgmap); -pgd_t *vmemmap_pgd_populate(unsigned long addr, int node); -p4d_t *vmemmap_p4d_populate(pgd_t *pgd, unsigned long addr, int node); -pud_t *vmemmap_pud_populate(p4d_t *p4d, unsigned long addr, int node); -pmd_t *vmemmap_pmd_populate(pud_t *pud, unsigned long addr, int node); -pte_t *vmemmap_pte_populate(pmd_t *pmd, unsigned long addr, int node, - struct vmem_altmap *altmap, unsigned long ptpfn, - unsigned long flags); void *vmemmap_alloc_block(unsigned long size, int node); struct vmem_altmap; void *vmemmap_alloc_block_buf(unsigned long size, int node, diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c index 37522d6cb398..67f9a08c2376 100644 --- a/mm/sparse-vmemmap.c +++ b/mm/sparse-vmemmap.c @@ -151,7 +151,7 @@ void __meminit vmemmap_verify(pte_t *pte, int node, start, end - 1); } =20 -pte_t * __meminit vmemmap_pte_populate(pmd_t *pmd, unsigned long addr, int= node, +static pte_t * __meminit vmemmap_pte_populate(pmd_t *pmd, unsigned long ad= dr, int node, struct vmem_altmap *altmap, unsigned long ptpfn, unsigned long flags) { @@ -195,7 +195,7 @@ static void * __meminit vmemmap_alloc_block_zero(unsign= ed long size, int node) return p; } =20 -pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsigned long addr, int= node) +static pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsigned long ad= dr, int node) { pmd_t *pmd =3D pmd_offset(pud, addr); if (pmd_none(*pmd)) { @@ -208,7 +208,7 @@ pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsi= gned long addr, int node) return pmd; } =20 -pud_t * __meminit vmemmap_pud_populate(p4d_t *p4d, unsigned long addr, int= node) +static pud_t * __meminit vmemmap_pud_populate(p4d_t *p4d, unsigned long ad= dr, int node) { pud_t *pud =3D pud_offset(p4d, addr); if (pud_none(*pud)) { @@ -221,7 +221,7 @@ pud_t * __meminit vmemmap_pud_populate(p4d_t *p4d, unsi= gned long addr, int node) return pud; } =20 -p4d_t * __meminit vmemmap_p4d_populate(pgd_t *pgd, unsigned long addr, int= node) +static p4d_t * __meminit vmemmap_p4d_populate(pgd_t *pgd, unsigned long ad= dr, int node) { p4d_t *p4d =3D p4d_offset(pgd, addr); if (p4d_none(*p4d)) { @@ -234,7 +234,7 @@ p4d_t * __meminit vmemmap_p4d_populate(pgd_t *pgd, unsi= gned long addr, int node) return p4d; } =20 -pgd_t * __meminit vmemmap_pgd_populate(unsigned long addr, int node) +static pgd_t * __meminit vmemmap_pgd_populate(unsigned long addr, int node) { pgd_t *pgd =3D pgd_offset_k(addr); if (pgd_none(*pgd)) { --=20 2.50.1 (Apple Git-155)