From nobody Sun Feb 8 21:28:05 2026 Received: from mail-dy1-f201.google.com (mail-dy1-f201.google.com [74.125.82.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB2B9221554 for ; Sun, 11 Jan 2026 04:13:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768104844; cv=none; b=N2OzcHcyp3ioOOAdvjIZmOYm6kjGkP/V3/XgQ6WiX+rnKOrpT+L0NJxN6INvWkyC6gsLL2egdL1ci4R2knQiVif94C+VZ1zVtAKQZL1XiDHh3fGn+7nqbONJGxWko9U2byLCxoe7obeqyqcPiKDNZPnCh9kiJMxPe0RdNeiSbMA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768104844; c=relaxed/simple; bh=8YxkvOf7iZLK/BeDOIUdVZ3lYPXO263sBiceaqqTHTI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=eniyQUhIpvD/iS8SMv/EvQ2IjfLv6yXzPu6rsyz7T16I3ggwNkCGJ2sZjshSwlepllt4+454AP6LbjlvHmeeDK9jEGFKL32e/h7VFSeY7qPcWKmpaytAal6zh+2/3Xff7oSIOGSB431yibnkrPo0hzIt+1rzNnuuv/lueeq0GLw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Rd9nDtWm; arc=none smtp.client-ip=74.125.82.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Rd9nDtWm" Received: by mail-dy1-f201.google.com with SMTP id 5a478bee46e88-2b04f8c5e84so5623443eec.1 for ; Sat, 10 Jan 2026 20:13:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1768104833; x=1768709633; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=5BNHEFhnGGjed5J/YPDOkQnS/Jo2dAvhTiC7ye+dE4c=; b=Rd9nDtWmyE464BjjZcFJiK8Z4DS+jtqaNLPQUKVfKibIv0gGbUtYBZd253pAg0awLt 27BC0gypPxsWb5kM9cKFIxmR3fr+87/knrgXfbSi8GfskH9HT8/8SziMFTP6D2kvz5lc cMOifWM5CuAPk+/6DyP2dhKuqZovJdbZx+ow0Z4Hpk/6WSOsTMxiSLHfrFDVCl8fdWs8 0Pg2CW788RbeZx0vIg9+MNKMNwsfX5+yQgDVhpC7ybanPoPTOJDAwRuB6ud7GkeZx7HB SpziN4+reFUav4HbN4/92Mne3H2ioDiUZKJW3MoR39wqBcTBXQ+yNqz9wyvvaIpb34dR 5Xjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768104833; x=1768709633; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5BNHEFhnGGjed5J/YPDOkQnS/Jo2dAvhTiC7ye+dE4c=; b=wo5Xdj4ahI2aFyeWHpya3/pCQyJtPDIUyLk6csvpURR2RgfGGfL6GdjBsMv1XehpRe xCfOuLxQn+n6aaExooWS0B5CCfDZeea6D5EM70pC+CgHR8oIKyreYv454XI0SFOYlnXf BaZ3pm3nFx51QynQ0ZULxZAkBixl5Yh8w5agDF+yWWdafsQQ2nL19zOCf/BhmbY8p4Gs 0k8SClXzSCTJeLMu6H/G+M5DuedE7p4pq+UvLFt8zveXaqD2x3dJ9y8EAHuZ7sAtSc1a mvsDfVhgPDChcH53Vn3hhpGqJerX0eArI+lE3XvEKoBlFGUyTaGBRprWjfxmitg7zkvS kYaw== X-Forwarded-Encrypted: i=1; AJvYcCUTHU9ME20cGkIFyp2y++AWK+N2VfevcJ6y9gOswrTVxliBqai7m7VcoE1uvhqFiCnXGZVxwtBfGfcsYHg=@vger.kernel.org X-Gm-Message-State: AOJu0YywNaXxbBUHo/AgYAZP0ADmR7Iq3s9IFVKaH7zzNSMH0dcOYLnv HNiQqwQwa8/AZ0+tWplM9CZegYHP491efFzqPhJ7B4nBGLJZdGDQNLuXrrijmhq6LX/MobUvi64 BeVr6og7g8w== X-Google-Smtp-Source: AGHT+IG3oJQa/osDAx4C4yoEYcgK5DMss7382VSjjjmLSJIiUVO5dapkoO2JxUJjE0I+441HEDp++UOmFH6O X-Received: from dybhf13.prod.google.com ([2002:a05:7301:2a0d:b0:2b0:4a35:713f]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7301:1e8f:b0:2ae:5d3b:e1c6 with SMTP id 5a478bee46e88-2b17d31c5a3mr17709461eec.21.1768104832844; Sat, 10 Jan 2026 20:13:52 -0800 (PST) Date: Sat, 10 Jan 2026 20:13:36 -0800 In-Reply-To: <20260111041338.1817056-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260111041338.1817056-1-irogers@google.com> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260111041338.1817056-6-irogers@google.com> Subject: [PATCH v3 5/7] perf callchain: Fix srcline printing with inlines From: Ian Rogers To: Tony Jones , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Howard Chu , Stephen Brennan , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sample__fprintf_callchain was using map__fprintf_srcline which won't report inline line numbers. Fix by using the srcline from the callchain and falling back to the map variant. Signed-off-by: Ian Rogers Fixes: 25da4fab5f66 ("perf evsel: Move fprintf methods to separate source f= ile") --- tools/perf/util/evsel_fprintf.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprint= f.c index 10f1a03c2860..5521d00bff2c 100644 --- a/tools/perf/util/evsel_fprintf.c +++ b/tools/perf/util/evsel_fprintf.c @@ -185,8 +185,12 @@ int sample__fprintf_callchain(struct perf_sample *samp= le, int left_alignment, if (print_dso && (!sym || !sym->inlined)) printed +=3D map__fprintf_dsoname_dsoff(map, print_dsoff, addr, fp); =20 - if (print_srcline) - printed +=3D map__fprintf_srcline(map, addr, "\n ", fp); + if (print_srcline) { + if (node->srcline) + printed +=3D fprintf(fp, "\n %s", node->srcline); + else + printed +=3D map__fprintf_srcline(map, addr, "\n ", fp); + } =20 if (sym && sym->inlined) printed +=3D fprintf(fp, " (inlined)"); --=20 2.52.0.457.g6b5491de43-goog