From nobody Sun Feb 8 17:36:29 2026 Received: from mail-dy1-f202.google.com (mail-dy1-f202.google.com [74.125.82.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0FB42DAFA8 for ; Sat, 10 Jan 2026 08:27:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768033636; cv=none; b=mv7wIe9Ohy4Re44B3Mz6Of9vhIqtADs45fenSp7HPshQyXtgik+ueGC/CohkB9lJcFpNxgMUZchG5sY6wq0mQCGQJbcI3W5Y2RbEzBxK+S1BOi1kir/9NtqTpSJ4nL6SDo+zRVsjop05mSsLwVB5WDxbpXajrGpHt3lmXQLvzw8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768033636; c=relaxed/simple; bh=maJyLYZB2FWx2e0vl8zLnRWKAaYapuD0B5sWshQY2lA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=XJe097aUblNgDMTpu+q+Sbe2KKp+lkIYT+UpffCcaGQ355QUEO8mu6a0/HqglLzk0McwXWg1ixJNsB8qkv4c9o1uR7jjLA7eCvOKV7XGZgUHQ40VM4hg8JcQn1VH6pHKE1N3iiieR5tF+IoTca/a9Sg8SbISt9oteOEKCzagExU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=r4vlv/72; arc=none smtp.client-ip=74.125.82.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="r4vlv/72" Received: by mail-dy1-f202.google.com with SMTP id 5a478bee46e88-2ae51ce0642so4274243eec.0 for ; Sat, 10 Jan 2026 00:27:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1768033630; x=1768638430; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=wBuF0YhhsuNCPdotB4FjlRI1J5nXeTBdLsus5/rNBYw=; b=r4vlv/72J7RCGTsh3SwLtP8gs847NvBPSeyF+ZvXGlTx7GtomouBAln/0b+BTJFUkZ egUD0tJ0PsJmCMAp8Dpd477l1sszdPmHABRWygwihJ0OM7fRDZWFcl2DFl31Z1AheRb9 W/+SB0+ADRvRl71IyScq6mDw3xkZu7T/xJ7mq0OIAK8RcRoJcIjcsEDyOYy09h9Ks0h6 3TCrHEhZwBoPbwCmwrE4VnThg/OvJYkNAYft1QiHbZWQlR2R7+lY5U81Q16g+mowTDA9 stg/8zAYUeNmBtfb99i71PGRFYmXafKB45GyTgmxG8MWzqs/xxuN/zhGk1cUFXzrmYVn ZNSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768033630; x=1768638430; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wBuF0YhhsuNCPdotB4FjlRI1J5nXeTBdLsus5/rNBYw=; b=fkAp3MH/D2BaYNq7+y83ANkoCuQY9AX7g2D1EVeS0tUgEor+rI7x5o7H6cbgpD1EOT 4FglYgpOjjMNBQG7xtfCtwyzo4EoqLjSyBgOaG1OmWCLXWud2NtKLjtaJenj5eJRLyAg fRXW6HbRthjFD9UI+RSx7rzIfviGvnGPSmXONkhlaBW52jcbmIYzCcrwX9wUKKuivpf/ aYqohgCGdeE/wj8ZsqiVUwtU7gD7DYbYX6IPBYGqD0WY+68a+7sdwkNkI/VgNV+BE3pp MOFge10gNA1dEowmB4bMgaYD74wfCIMvR7gjdxMxWe8krPdtWgCBx4vf89MUvnsGyrGR lWag== X-Forwarded-Encrypted: i=1; AJvYcCVeLJzffL+vKmiTYL1zVHYpiV/a4tDPmuPOM7veNCrWYdJIjct+ymvXra9dusU+zioRhN/AtPQrPNE0vPA=@vger.kernel.org X-Gm-Message-State: AOJu0YynJNzEkRZMJfGmo50+WKJ4EMkBn7FBnIyy5Q/EBE3xDvdbLCKl CqPugrV7xlboEkR3jOw0J92o6cZJobwBYO2hEU6ayrWxxZtlRXFtL0U+rswpRIOvPZpo5UrGxFg eXMhaHbsghQ== X-Google-Smtp-Source: AGHT+IGYojtwJBo4BOFYANV+ARAGrhYAgkvu3KCkGq68x1ht0dKFHVggr0YcEyQRIZ7/cPkkOkikzpTGiGl1 X-Received: from dlbqi1.prod.google.com ([2002:a05:7022:ebc1:b0:11b:8174:bf47]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:24a3:b0:119:e56b:91f6 with SMTP id a92af1059eb24-121f8b656c7mr11354434c88.39.1768033629805; Sat, 10 Jan 2026 00:27:09 -0800 (PST) Date: Sat, 10 Jan 2026 00:26:45 -0800 In-Reply-To: <20260110082647.1487574-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260110082647.1487574-1-irogers@google.com> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260110082647.1487574-5-irogers@google.com> Subject: [PATCH v2 4/6] perf callchain: Fix srcline printing with inlines From: Ian Rogers To: Tony Jones , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Howard Chu , Stephen Brennan , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sample__fprintf_callchain was using map__fprintf_srcline which won't report inline line numbers. Fix by using the srcline from the callchain and falling back to the map variant. Signed-off-by: Ian Rogers --- tools/perf/util/evsel_fprintf.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprint= f.c index 10f1a03c2860..5521d00bff2c 100644 --- a/tools/perf/util/evsel_fprintf.c +++ b/tools/perf/util/evsel_fprintf.c @@ -185,8 +185,12 @@ int sample__fprintf_callchain(struct perf_sample *samp= le, int left_alignment, if (print_dso && (!sym || !sym->inlined)) printed +=3D map__fprintf_dsoname_dsoff(map, print_dsoff, addr, fp); =20 - if (print_srcline) - printed +=3D map__fprintf_srcline(map, addr, "\n ", fp); + if (print_srcline) { + if (node->srcline) + printed +=3D fprintf(fp, "\n %s", node->srcline); + else + printed +=3D map__fprintf_srcline(map, addr, "\n ", fp); + } =20 if (sym && sym->inlined) printed +=3D fprintf(fp, " (inlined)"); --=20 2.52.0.457.g6b5491de43-goog