From nobody Sun Feb 8 04:17:43 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ABF72E413 for ; Fri, 9 Jan 2026 17:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767981309; cv=none; b=c+AewpQwEvv/QBG+pEGqUFfrqIYS0IpaRJVwDa4bVUcm0pp+lVJAw5QU/7EDbv/UuWxZ2D5G/usw8E+g6eIwjX5RbKzr0HCT3yWVeyMjuVpEDXM/p4Ca3N1SINkQlqU8952YgpbyNlIqJU7V94bbzyEzwbNvW8uOsh8wZhVy5XA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767981309; c=relaxed/simple; bh=8ovwN7QRqNqFB3CSLnmNtwGDDzueaj5rcVSrlfQLlps=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uMfLIlcBPf6CtcqcPT9iOlRaAMxu9dQsWB9wvgTQQaLui+rnLJUXHUM5f/GSy8HLvApz1PBhGLREOHPxtitvHuOxaEmyZQT6mhYzJzsrAuzPyvsyRAIQbG+EH/wfgvRZx9efvMu8hn9Q1mrY3baI+q2o+KnIzQu8xS57Pl1JIq8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=YwhkS0Sv; arc=none smtp.client-ip=117.135.210.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="YwhkS0Sv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=Gl SIEkH9iMErWH5BcxZYXm6uX7o06WHwR2s03YkV0xo=; b=YwhkS0SvpW8z6jRAFX E3UHwsap69ht4JoJY1uA3QU3w2kVh0izFygz/5YWhFi+9V6DgsclnZIstXjcqHLe O9F6gT9eZz9u15gHft73Roj/vySBPGG7YUShporMECSOr1wNKGMwmW/7Gc6VN1Xf XEftPArsEjp1CfZnhmOm0yfTY= Received: from haiyue-pc.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wBnolbtQGFpjvRxFA--.1825S2; Sat, 10 Jan 2026 01:54:55 +0800 (CST) From: Haiyue Wang To: linux-kernel@vger.kernel.org, Greg Kroah-Hartman Cc: Haiyue Wang , Yaxing Guo Subject: [PATCH v1] uio: pci_sva: correct '-ENODEV' check logic Date: Sat, 10 Jan 2026 01:54:25 +0800 Message-ID: <20260109175448.34309-1-haiyuewa@163.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wBnolbtQGFpjvRxFA--.1825S2 X-Coremail-Antispam: 1Uf129KBjvJXoWrury5ZFy8Kr15Cw4fAryfXrb_yoW8Jr4DpF 4rW3W5JrWfKF48GF4UAFW8Za4FqFZFqrZ7t347A3sxtrnxAr40gry8ZryS9ryF9FWfCa12 y3s7t3Z8WF48ta7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0JU0_MxUUUUU= X-CM-SenderInfo: 5kdl53xhzdqiywtou0bp/xtbC7w-9aWlhQO+NEgAA3M Content-Type: text/plain; charset="utf-8" The current '-ENODEV' check uses '&&', which can lead to a NULL pointer dereference when udev is NULL. Fix the condition to return -ENODEV if either udev or its pdev is NULL. Fixes: 3397c3cd859a ("uio: Add SVA support for PCI devices via uio_pci_gene= ric_sva.c") Signed-off-by: Haiyue Wang --- drivers/uio/uio_pci_generic_sva.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/uio/uio_pci_generic_sva.c b/drivers/uio/uio_pci_generi= c_sva.c index 97e9ab9a081a..4a46acd994a8 100644 --- a/drivers/uio/uio_pci_generic_sva.c +++ b/drivers/uio/uio_pci_generic_sva.c @@ -29,7 +29,7 @@ static int uio_pci_sva_open(struct uio_info *info, struct= inode *inode) struct uio_pci_sva_dev *udev =3D info->priv; struct iommu_domain *domain; =20 - if (!udev && !udev->pdev) + if (!udev || !udev->pdev) return -ENODEV; =20 domain =3D iommu_get_domain_for_dev(&udev->pdev->dev); @@ -51,7 +51,7 @@ static int uio_pci_sva_release(struct uio_info *info, str= uct inode *inode) { struct uio_pci_sva_dev *udev =3D info->priv; =20 - if (!udev && !udev->pdev) + if (!udev || !udev->pdev) return -ENODEV; =20 iommu_sva_unbind_device(udev->sva_handle); --=20 2.52.0