From nobody Fri Apr 17 06:36:36 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A19426E71E for ; Fri, 9 Jan 2026 10:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767956163; cv=none; b=c7fPOMA3AGOtWB+z5NJlgKwZhYVcGWmtgIvm+37J/ObigoKjAmDIz+e6ou2H89ZZGB0z9fLH3hJux3mmPD3hQmC0C35XOvqMEjhgTp+gDuopOkHASfsHK1541frExIX4+JYqortP7VaSXdL+ICNIbkjXt9wJg1/x2qE3bOOcROY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767956163; c=relaxed/simple; bh=pUNQ4yKbuQi+rnEdBpvCZxkVWVPxJUSAqxvcLO+D94M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=texviqIMPxM3s98F5DT3nLVkZ06dUdSLa3qg/wY61rIsH9RQ2c95K5mgObC6i/NGIVY6Y2uaro0E5h+TLjJsyJL8fF9GfTsSAINw4Z1E63DTdohcaA+1P9TnJBKuf93zxHCKktI3L/5qqdEt0zuyDtV4Q99Zme9HjPJk+ociHd4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lFJODdu5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D81hq07R; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lFJODdu5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D81hq07R" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6099UfAG3324799 for ; Fri, 9 Jan 2026 10:56:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=x3hvM0pQwYpTkNdxivaou3G2IyHbIV9X09z rP1OOdEU=; b=lFJODdu5BWoBIdbwJ3z7335OCLDWpEtK9OUYbyJyFRTojUO6tSj F1hSeHz6Orf6raEKZWIq9DWPk1Qf+QVnEUy6g1OJ6zQ7F9tYWJx0dMg1jBM0gciU F6WHR6pfj6Bdg1KKkjNlE/pzkhAJNnzObq1gJWAAlvnz1ssnSHyG4WlN21i9+MOr VHjQwTqyEIah/uhQvc3GloQGLlgM1Y7IEredvHCSHPpdnqLW2riVCNFFY7+SrO4B utpm3I1IkJyk/VO9Hrt2ssizYoQNaJlE5tIJcXmN1wUVJ+zJisZj7AIgyApfRA4a G9h28J9Zbisrpqzv9IPtA3rzzw7usqNvmYg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bjrd6hgjm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Jan 2026 10:56:01 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b259f0da04so1029104985a.0 for ; Fri, 09 Jan 2026 02:56:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767956161; x=1768560961; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=x3hvM0pQwYpTkNdxivaou3G2IyHbIV9X09zrP1OOdEU=; b=D81hq07R0Llsg2X37wcFT9AUAKvL86D9bcVycKx03qxTjOoYpLWyalqaEac121rigL rIAxfQBvVI0yzsSj6gFestZFQtRlpNEZVLpJ11e8NrNzdAEpoMDRzxkqDqXl/e568ldx tZ5YvyF95UJCrn+h7VpA3ZLNedubhoLLEo3sQrLkidF6+p0jkMtluwZRWxj7404rW9w4 BVzLPs4AfB15MpKisJ6TZe2ITKxjiMXp1a/tNOm+I7hOm5NhSbL4fCc9/YqFJtH7ZV1F vg3KHNiLUSBkmeruirqJMxVuYrIsFde8LofhLNlBuKd6kjCWr4kQ1IEgb9O5N4CMEnQl GHjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767956161; x=1768560961; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x3hvM0pQwYpTkNdxivaou3G2IyHbIV9X09zrP1OOdEU=; b=Se4rv9OOyHKVxuJR+mXVtHa8KC77ZhBhZPSGv2Kc/i8u+54Xkm3jtgNuBX2y/f+0CW OtY49Z3L3R9Pt9CFkAz97R4OeJkFNyNXMA0e34Soouo6eESJLTJ+djAxJtsea+oRxwR2 xUknwPN86yXROWxET3tSqj59nxOOekxXA0ZNoAyqOPQlUGpcJVeYWkvKZC1IYDs+0opo /yXPiaU8KXq5iHD1x1x0/Iczafb0iDdwMQXDAtgrqaXgwn2Du4US+V6PY7BI0Y68rbLo O5SFbFkMgoZtNJrCceRqA+Ck0G3rz4NAtSkAYFdu3gkP8JcHZpoK5Vu7q65HkYvQWoxG 0wjA== X-Gm-Message-State: AOJu0YyujdFRZltfzkVna7dRXJmMUAM5Wv4a0oiX9qR6OC7vhGrQJ0CI MD8lSopCxO2JzZGyzZgvO5aYYxXYRTmWLwO5D1RN+KyxkIJviqAeUJ1mnuxKXSaM7WwwPjO3pv/ J3QbYonHMZzckjvrMCosV/GGJn3AS9oHgWns7Qch44GRmTlCiz/ZTq9XtkHAACWBoO7M= X-Gm-Gg: AY/fxX4U6UKNdzpZUH5101aTsorkfkBxfOFXkVnrEITRXQxygE4kTOtp7meUlkeQnOe R8xD1Kpns0uCZ4ckVRIc8KIK1rCphzSNb4dxjGaNjfBf+JfDJBFxB71Lg9VR7BwJTSk2DL1fonC wAs+bVSmyYs4Jv6s9LZ/sEri1MXMM8Ohwea9SYe/HvbSQzQ4e/g1cdDUhhCuVgNG+NF0ZQ56R4h Ix69svR8FBzk5mtL4Q55bbcMcm1yAfVRzvFlgV8Njr5SLMswkmnSBjgoTfqXTOM4fUnPs+ucfVz pbfZTfWOSgsTuiaAdral8C78qtLF7O/FdQS3SaX1tmEvtSgfy6zoY52Y+E5FyBG19E2gCzIg+qU ha5TP0O9m7bLBPTSsOegs5Yk1suIOfyfRhVva5Q== X-Received: by 2002:a05:620a:7101:b0:8b2:eea5:3324 with SMTP id af79cd13be357-8c389392555mr1272845085a.27.1767956160786; Fri, 09 Jan 2026 02:56:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IGETBlW0rXG+obctkdor0XxgffcWzuQHjfo4r27SFgGxgsvTHt8XNBEM6bHhvHK1AAuXK01Fg== X-Received: by 2002:a05:620a:7101:b0:8b2:eea5:3324 with SMTP id af79cd13be357-8c389392555mr1272842385a.27.1767956160311; Fri, 09 Jan 2026 02:56:00 -0800 (PST) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:5b0:5859:6099:b45c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee893sm21445709f8f.37.2026.01.09.02.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jan 2026 02:55:59 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Bartosz Golaszewski Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski , Michael Walle Subject: [PATCH] gpiolib: remove redundant callback check Date: Fri, 9 Jan 2026 11:55:56 +0100 Message-ID: <20260109105557.20024-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA5MDA4MCBTYWx0ZWRfX+BJLtFK5kr4K bTh3zaiRwe1VcoCT6gFPoxNXmN7t33SGf4smLP/1ueb3y/5vxEmV0QPnh1U9w6xirF1CcDA+h0T q+qIDI6hqxhfAMskucTFZCHbyRg0umLKIvo4r74Y+vZbuS1qTbIR2SstVjhdCOzINuoW0VFM69Z S7BUnOTb1rtDnSkWbHgQeMLh0t26+fkbUc1LJDtXXhhtlQQeVkMdj1rHmkqE2GFQCVaLE7PR30V sqYldVVwSvOshR3IRkVYxOfUvS2boXEhXLwON44DXwUrVmL5rquoMU7kctJF90QlhIQn2xCtN1V qAZNaTSm3twp05fFnF4N6m0oCIgUcgIGAt5XhQgN7Y80WOI6OwIw/dPd9k+19SJn/7BIryGSMiF s9t1WHbHwfTPZPWXLEQIFqK5Y2MIQ6NC1HDTr+Hd3bm+s4MVB4DGij++X0hPmsrN6qj/IMQPDeg v1vnIgyqCh4ySi2oeTg== X-Proofpoint-GUID: Ldfx6Gc-o0GrmdedFXQxfeAQHcgaHv0y X-Proofpoint-ORIG-GUID: Ldfx6Gc-o0GrmdedFXQxfeAQHcgaHv0y X-Authority-Analysis: v=2.4 cv=Xtf3+FF9 c=1 sm=1 tr=0 ts=6960dec1 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=UaC_jXYBCyrhuv0RKjMA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-09_03,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601090080 Content-Type: text/plain; charset="utf-8" The presence of the .get_direction() callback is already checked in gpiochip_get_direction(). Remove the duplicated check which also returns the wrong error code to user-space. Fixes: e623c4303ed1 ("gpiolib: sanitize the return value of gpio_chip::get_= direction()") Reported-by: Michael Walle Closes: https://lore.kernel.org/all/DFJAFK3DTBOZ.3G2P3A5IH34GF@kernel.org/ Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpiolib.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 0a14085f3871..5eb918da7ea2 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -468,9 +468,6 @@ int gpiod_get_direction(struct gpio_desc *desc) test_bit(GPIOD_FLAG_IS_OUT, &flags)) return 0; =20 - if (!guard.gc->get_direction) - return -ENOTSUPP; - ret =3D gpiochip_get_direction(guard.gc, offset); if (ret < 0) return ret; --=20 2.47.3