From nobody Sat Feb 7 22:21:33 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3AB626B742 for ; Fri, 9 Jan 2026 06:19:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767939553; cv=none; b=oDcGwvR3Tf4LThHcnwKZZPJxAVFZf5VHPXAjD54jsbWPQVxuDSDhkh5BLO3oYDu9gvDQQjmYUE2ao48Uego3jJcnLc0U6VjIl96Lo4ymZTwwgS+fnRykLuxAPLAdsAkcPYrUTGANzWPQ0H5TXoD+VV6KcBGh8C9nuTINBr+/+Bc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767939553; c=relaxed/simple; bh=b/3huWzi5fH5yfmWBVLBG0clk1xwuF28Qcz+cqEDEds=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=j+5nUvKN/dQ8NxOQBiguZdeVgrrGT6oK57gHVT4wHUsx57DdXonS63GEEeReirPOV2IuJOucwFiE5oHT391vSkh2JeiaGoLe4FFieH8wzolZ3jUa5yDxUMnhoIMwTVqF3wDzrNAv0Xo4YJSQ6E489VSBSgtUX1l9EpnkWc9/Dsk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dMbwam1g; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dMbwam1g" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a12ebe4b74so39884155ad.0 for ; Thu, 08 Jan 2026 22:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767939551; x=1768544351; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mxcIAZdi8DSHabnzsxkENQYm/KIvgyHbwki+UOtqU4s=; b=dMbwam1g4FQd4hPWaAvnKL4WMv3mgao0NHJzDuaHYZgIJqavPeEAD8rMLSFKm3kOBP n2czKPQ/A/LpjomLuH6BsnDxcqgFUY9Y8z3EPBhEVmAKoBegZjfjnmH/f416jmewhJ/E gUwQFFOGnFgyB9rCWKX6BlYGC+VjtoAqmXGN1IvoTj5/X1nfB+H3erOYJb3lWmbclsNR 9nhd6jniR+jcPWo+rfe4TqPWAp5W0TDsUvaiIDlucgz5eUaWGqESsjD5cPlc8un8C2IQ +SETE5fBuxn5SzuCRh1hJ3r1E6K2G3PA2deM62AiFp9pUNWmWiRnvy5caK7sJSLddyqO F60w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767939551; x=1768544351; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mxcIAZdi8DSHabnzsxkENQYm/KIvgyHbwki+UOtqU4s=; b=M7rivzsJhLSqPCEUwYUJ0JhY+o/ln6JZxU20ERjpW5UszJgII5kpAhPxfeD2XbM5MY 33uBszEavBZV3IvLxa9Ls3qbQcK0gba/cBTvZppXpdosz8OoU7p8KyzEIsARtwikk5kU zZ3oMPK+I6A394hdAHocmzqILjHKd5Qcg28WcobDffwxDgSnQlp1x6c5WblHsY/JBl4D C72qdQX7t5jX6+kJ5Ym8vULKRwF7UkXuX4cdgAD71y2yg8DtoPFqmrdL/jbIutey35xX Qs4QqVvX3nTjpwl/7Fsd/bog4g9bH7es95W+tYnVWEiSqYrOLZnyZzX1qYUOdw7neqm+ ECCw== X-Forwarded-Encrypted: i=1; AJvYcCVHXjoDtK9BZvU3TBY+psI52aYMYO9tCfVNrBEu+uHI+YycalaQqrU5nPSlJTHfwdfEemmmDtiwSyd914g=@vger.kernel.org X-Gm-Message-State: AOJu0Yyvhm/hrEaK4dOSldpSK40azWJcJZhZtDcXYD8H4csHjpDjX7Ms uxcfkZ4HK+ZdMX0Hz3s+FvJqX+UKuRI0akFs+UEE4sGApUsUC95LU8g= X-Gm-Gg: AY/fxX4dNczlVvUI14PFL1UX8ilHSTPCJ4hm/HE8wmWDom00ven3IAZuNkw8b4uowx1 XTJsCkpYhcJmct5eLW77h/9o5keg+ihPFYXfwnaUct5Eg2TWuFNRIybd6CiHcKACg4l4n4C1jLY u4FeU/NWcHp1ybIuxj0ZK2fIRO5Zo3q1wGivn5KO1W6xBIyCXFZtuHh00se1psZjHj9Il1xhgtY s9qPbocf70RSJI0UUDm3DvuHsZf6BaMwDo5wfe6tWA9HmSRVlaWuljtJQluBqhLldN2UdzYO4XL 4CI+SjNManHSrccGXGivCP9BVg/u/umyQt8sKw2asV6GHEv4vQ1aGl6zUdhc8AmHVFPiOEonR6E Q9vBS/YiwAzr8TSvqdZzMtUcToffIdnoVV4bwORQeSfO/eCvmwqu/YkGPhjE+yggaImLr6ddTow r8KPtzr/071cZ59w4= X-Google-Smtp-Source: AGHT+IGN1WYQT2EKc4h3GaCwKE2jZCARir0K7jCaV93K9/r5xtWTUECgPBy7LokTrS9Cz97x/QdO2A== X-Received: by 2002:a17:902:ccd0:b0:298:2cdf:56c8 with SMTP id d9443c01a7336-2a3ee4c46d4mr71063545ad.60.1767939551278; Thu, 08 Jan 2026 22:19:11 -0800 (PST) Received: from at.. ([171.61.163.202]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c530133csm9272546b3a.31.2026.01.08.22.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 22:19:10 -0800 (PST) From: Atharva Tiwari To: Cc: Atharva Tiwari , Bjorn Helgaas , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Mahesh J Salgaonkar , "Oliver O'Halloran" , Andreas Noever , Mika Westerberg , Yehezkel Bernat , Lukas Wunner , Kuppuswamy Sathyanarayanan , Giovanni Cabiddu , Feng Tang , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org Subject: [PATCH v5] PCI/portdev: Disable AER for Titan Ridge 4C 2018 Date: Fri, 9 Jan 2026 06:18:53 +0000 Message-ID: <20260109061901.3127-1-atharvatiwarilinuxdev@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Disable AER for Intel Titan Ridge 4C 2018 (used in T2 iMacs, where the warnings appear) that generate continuous pcieport warnings. such as: pcieport 0000:00:1c.4: AER: Correctable error message received from 0000:07= :00.0 pcieport 0000:07:00.0: PCIe Bus Error: severity=3DCorrectable, type=3DData = Link Layer, (Receiver ID) pcieport 0000:07:00.0: device [8086:15ea] error status/mask=3D00000080/00= 002000 pcieport 0000:07:00.0: [ 7] BadDLLP macOS also disables AER for Thunderbolt devices and controllers in their dr= ivers. Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D220651 Signed-off-by: Atharva Tiwari --- Changes since v4: - Used lowercase hex letters - Used DMI_BOARD_VENDOR instead of DMI_SYS_VENDOR Chnages since v3: - Fixed Grammer mistakes Changes since v2: - Transferred logic to arch/x86/pci/fixup.c to only target x86 - Added DMI quirk to only target Apple=C2=A0Systems Changes since v1: - Transferred logic to drivers/pci/quicks.c --- --- arch/x86/pci/fixup.c | 12 ++++++++++++ drivers/pci/pcie/aer.c | 3 +++ drivers/pci/pcie/portdrv.c | 2 +- include/linux/pci.h | 1 + 4 files changed, 17 insertions(+), 1 deletion(-) diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c index 25076a5acd96..850bfe03a685 100644 --- a/arch/x86/pci/fixup.c +++ b/arch/x86/pci/fixup.c @@ -1081,3 +1081,15 @@ static void quirk_tuxeo_rp_d3(struct pci_dev *pdev) } DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, 0x1502, quirk_tuxeo_rp_d3); #endif /* CONFIG_SUSPEND */ + +#ifdef CONFIG_PCIEAER + +static void quirk_disable_aer(struct pci_dev *pdev) +{ + if (dmi_match(DMI_BOARD_VENDOR, "Apple")) + pdev->no_aer =3D 1; +} +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x15ea, quirk_disable_aer); +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x15eb, quirk_disable_aer); +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x15ec, quirk_disable_aer); +#endif /* CONFIG_PCIEAER */ diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index e0bcaa896803..45604564ce6f 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -389,6 +389,9 @@ void pci_aer_init(struct pci_dev *dev) { int n; =20 + if (dev->no_aer) + return; + dev->aer_cap =3D pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR); if (!dev->aer_cap) return; diff --git a/drivers/pci/pcie/portdrv.c b/drivers/pci/pcie/portdrv.c index 38a41ccf79b9..ab904a224296 100644 --- a/drivers/pci/pcie/portdrv.c +++ b/drivers/pci/pcie/portdrv.c @@ -240,7 +240,7 @@ static int get_port_device_capability(struct pci_dev *d= ev) if ((pci_pcie_type(dev) =3D=3D PCI_EXP_TYPE_ROOT_PORT || pci_pcie_type(dev) =3D=3D PCI_EXP_TYPE_RC_EC) && dev->aer_cap && pci_aer_available() && - (pcie_ports_native || host->native_aer)) + (pcie_ports_native || host->native_aer) && !dev->no_aer) services |=3D PCIE_PORT_SERVICE_AER; #endif =20 diff --git a/include/linux/pci.h b/include/linux/pci.h index 864775651c6f..f447f86c6bdf 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -440,6 +440,7 @@ struct pci_dev { unsigned int multifunction:1; /* Multi-function device */ =20 unsigned int is_busmaster:1; /* Is busmaster */ + unsigned int no_aer:1; /* May not use AER */ unsigned int no_msi:1; /* May not use MSI */ unsigned int no_64bit_msi:1; /* May only use 32-bit MSIs */ unsigned int block_cfg_access:1; /* Config space access blocked */ --=20 2.43.0