From nobody Sun Feb 8 00:11:35 2026 Received: from mail-dy1-f201.google.com (mail-dy1-f201.google.com [74.125.82.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6748B2737EB for ; Fri, 9 Jan 2026 06:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767938785; cv=none; b=eXXOvXT6e1RLB2UEQNc0maSU/C3jIXWs7IRrihu8qfr71GxbA3CTqOwE7rCYrTd5JE05dNtmI1JayLBIoiQAomP9sKCOkPbI096P2VeGY2aIrCmAFbc0JFh5oRHAX3fdoitXHTj1SF7RHEA8QUoDHMvaOe0+YJbRZ5RDoiawIns= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767938785; c=relaxed/simple; bh=rSHje72qn06YSDOtcZUV8BYiUZSgBsyRvTaWkavkFR8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=REVZDApgWYpp9yj8gEOfyFeEQuOapRqob1mYCE9LLxt06hzmQTl3/seox+a4Zgdh1fcSVA2ON849SPoBK+oC+/DFR/5NfEnceVIhYDb5OFAVAAi9Djhc+7OfEEsDdG0Od4mJ24aeRZ0EzPASC2f7lGkIclaVN3lSkU14Iz6eBXI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--bingjiao.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=4CSoOWuB; arc=none smtp.client-ip=74.125.82.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--bingjiao.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="4CSoOWuB" Received: by mail-dy1-f201.google.com with SMTP id 5a478bee46e88-2ae546fa935so18101112eec.1 for ; Thu, 08 Jan 2026 22:06:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1767938783; x=1768543583; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=VJ52X8DJw4332ZGcvwO1T13NvF/pxnQEOtkap7ms7B8=; b=4CSoOWuB8T6YO4WcBFjMf/hZjkc1i7QZF+MSBfS0jE4Z+3jPswiZcfSK6anGUBIbo1 ZDwTbR5FV46dNEBfGysA1RLr5VNqWo0GQM2ck2RP72eYSDnoCYtIIOVPRebw3f6/EF8a ciz/S1b/TL5SMzzet3/VaVNzrbJjv4Hkvc7eDEkQNcGL6MumTrQkYue55hF5m7JS21ij XGV8lyOQ7gNY6Qf0GwaaUULh68AtYCnjmGPPw/Xjr6CdTXCsq2+mbO5ciwMnHHM0T3MC Zw+hdzB2jNaBbMligR7AFzGXLfJNh3BsVY6+QxtmRSZia7R1MYb02JoqXRs3JxmZX4Ud lCjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767938783; x=1768543583; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VJ52X8DJw4332ZGcvwO1T13NvF/pxnQEOtkap7ms7B8=; b=EY/rE3IqeGzyPgFYXP77twh6lnZzMfMv+7JuZtzFieAycXUc91yHUYoricAnoMKbB5 OiD6HykESsb5O9im9cvvt4H+VAor/B6v45A3yIvXskYNX1XqBioXEkOy1OEWeB06pGim uvkfwkbFojmnOY/HhrWD9v84GHFeOVuoyCmv4szvqW5OYfGcE5U3XF3Bu88zpooUj9Eb SP3Q/ht1GVQmgqqSmH1F6jL8KMF6hXcm4KABHC6ah0n82oY6YHezHQUn2jouIK3IUKpT pL9bkFv3ngGjN+OKqtsQ7hHJI/0/255kND/5wIVqCpQ6TfwD6flQdAryvWLdAlPprjAc lwQw== X-Forwarded-Encrypted: i=1; AJvYcCXHFUj+VrVsIEblyqQEANZ0ZtBsayMAMIIruLk8y7fuyrZiX1fCewU+kZlQNHfhHLcleVUfLVtLIm+B/BE=@vger.kernel.org X-Gm-Message-State: AOJu0YxcCwvMZGuOw9QYLmPhXCVeZ6ImjnU/OyEma1PA6t54MonBJ9av OFOkg/gyxgUiUALPxpkLYk9zy7wb0oUxzBnzBv4bP9ruhj3FICK1d7BYeAT2kWn7goOva21K4zY seNSp4L+iICKC/g== X-Google-Smtp-Source: AGHT+IEycexvcYOpULS4uIaacG6moaZkSgb3dQTA8rE3yW1sudxFNh0OQhIfvC5qfjuWshh86gDgGyyMyAafWA== X-Received: from dlbdd42.prod.google.com ([2002:a05:7022:aaa:b0:11f:3e3f:a2f]) (user=bingjiao job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:384a:b0:121:a01a:8e2f with SMTP id a92af1059eb24-121f8b69552mr8048147c88.42.1767938783235; Thu, 08 Jan 2026 22:06:23 -0800 (PST) Date: Fri, 9 Jan 2026 06:06:21 +0000 In-Reply-To: <20260109055937.3739860-1-bingjiao@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260109055937.3739860-1-bingjiao@google.com> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260109060622.3742262-1-bingjiao@google.com> Subject: [PATCH v1] mm/vmscan: fix uninitialized variable in demote_folio_list() From: Bing Jiao To: linux-mm@kvack.org Cc: Bing Jiao , Andrew Morton , Axel Rasmussen , Yuanchu Xie , Wei Xu , Johannes Weiner , David Hildenbrand , Michal Hocko , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit d92027a5f30a6c ("mm/vmscan: select the closest preferred node in demote_folio_list()") refactored the selection logic for demotion target nodes. However, it removed the initial assignment of 'target_nid' while leaving a premature check for 'NUMA_NO_NODE' in place. Since 'target_nid' is now assigned further down in the function based on preferred and allowed node masks, the initial check at line 1046 is redundant. Remove the redundant check to resolve the compiler warning. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202601091037.vUSHeJCH-lkp@int= el.com/ Fixes: d92027a5f30a6c ("mm/vmscan: select the closest preferred node in dem= ote_folio_list()") Signed-off-by: Bing Jiao --- mm/vmscan.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 213ee75b3306..590ab3ec1998 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1044,10 +1044,6 @@ static unsigned int demote_folio_list(struct list_he= ad *demote_folios, if (list_empty(demote_folios)) return 0; - if (target_nid =3D=3D NUMA_NO_NODE) - /* No lower-tier nodes or nodes were hot-unplugged. */ - return 0; - node_get_allowed_targets(pgdat, &allowed_mask); mem_cgroup_node_filter_allowed(memcg, &allowed_mask); if (nodes_empty(allowed_mask)) -- 2.52.0.457.g6b5491de43-goog