From nobody Sat Feb 7 17:48:50 2026 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE2542D5A19 for ; Fri, 9 Jan 2026 04:13:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767931988; cv=none; b=UrzAbgwEy0F6Sj8gGV6WryVcvBOWA46rMr+tbPjOhAo1syses8cZgJrOqpV3q/P3q/YI0Wuqb9h/hTQ64hEalNzdLHLGMlf3TSXKk1FNgVH8jY8taLAjhM2tZVM+uvJcYj9ockcv1yQxQE0ckqdSlbgfF9DhthgC96EiFQqp3WM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767931988; c=relaxed/simple; bh=H++lTitq6oekXCav1VVAZYLyr9W5/vUCmY94hXL/vtM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lPd38aVRAa7N/b6jDOvnqHOwXMbIJjkK11JnI49UaEruqBP9ZcYb/2PE7TX+tI9Ov5M074WH4udVNmpiQ+FxYpERPMv060jSDaBdTY3ltQS/qAFT04x/9bACryYACfPu/4q4NXNxZunxn9MUGNYL376jU8eoUjQ85z4xgjEM3uI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=Es2ZF2N7; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="Es2ZF2N7" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 52BD010D779; Fri, 9 Jan 2026 05:13:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1767931984; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=15Tft0MKWHeSgiHGMgE7x5wajiU0tsytqfAb9UUXxVY=; b=Es2ZF2N7uCMUZtu8PL+qlx4n6RmYlhLKIDnbDVh7EIUZEePRClinjYkfCpNAUIVFE/M+R5 8U6YhLmqkZh5KBUIIiM3ofIV1jqPHa6XwV5byjudGDNwi8ZhXN3a79w/VNzjN8wKa0C4BG FeoU42BuPoh1t9g094Wu+c5pKyHeYjLU3qCRr6stDCB7vijvsn88K2pTJWD19bFGgV0idJ wAT1+M5qTX0ydMPJXWzx4s80zgthtBmKdqe8rxkKncK1PHsB74iq6oGhAcCMl/0h913WKC 4lCLEsUgnqQzbibirlIdna3L3eQQB81NPEU/8BLmUMG3NqOhLyQWzhn5KrjGWw== From: Marek Vasut To: linux-kernel@vger.kernel.org Cc: Marek Vasut , Lee Jones , Pascal PAILLET-LME , Paul Cercueil , Sean Nyekjaer , kernel@dh-electronics.com Subject: [PATCH] mfd: stpmic1: Attempt system shutdown twice in case PMIC is confused Date: Fri, 9 Jan 2026 05:12:09 +0100 Message-ID: <20260109041301.1344783-1-marex@nabladev.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" Attempt to shut down again, in case the first attempt failed. The STPMIC1 might get confused and the first regmap_update_bits() returns with -ETIMEDOUT / -110 . If that or similar transient failure occurs, try to shut down again. If the second attempt fails, there is some bigger problem, report it to user. Fixes: 6e9df38f359a ("mfd: stpmic1: Add PMIC poweroff via sys-off handler") Signed-off-by: Marek Vasut Reviewed-by: Sean Nyekjaer --- Cc: Lee Jones Cc: Pascal PAILLET-LME Cc: Paul Cercueil Cc: Sean Nyekjaer Cc: kernel@dh-electronics.com --- drivers/mfd/stpmic1.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/stpmic1.c b/drivers/mfd/stpmic1.c index 081827bc05961..9ef4049d7db10 100644 --- a/drivers/mfd/stpmic1.c +++ b/drivers/mfd/stpmic1.c @@ -121,9 +121,23 @@ static const struct regmap_irq_chip stpmic1_regmap_irq= _chip =3D { static int stpmic1_power_off(struct sys_off_data *data) { struct stpmic1 *ddata =3D data->cb_data; + int ret; + + ret =3D regmap_update_bits(ddata->regmap, MAIN_CR, SOFTWARE_SWITCH_OFF, S= OFTWARE_SWITCH_OFF); + if (!ret) + return NOTIFY_DONE; + + /* + * Attempt to shut down again, in case the first attempt failed. + * The STPMIC1 might get confused and the first regmap_update_bits() + * returns with -ETIMEDOUT / -110 . If that or similar transient + * failure occurs, try to shut down again. If the second attempt + * fails, there is some bigger problem, report it to user. + */ + ret =3D regmap_update_bits(ddata->regmap, MAIN_CR, SOFTWARE_SWITCH_OFF, S= OFTWARE_SWITCH_OFF); + if (ret) + dev_err(ddata->dev, "Failed to access PMIC I2C bus (%d)\n", ret); =20 - regmap_update_bits(ddata->regmap, MAIN_CR, - SOFTWARE_SWITCH_OFF, SOFTWARE_SWITCH_OFF); =20 return NOTIFY_DONE; } --=20 2.51.0