From nobody Sat Feb 7 20:38:57 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47269226863 for ; Fri, 9 Jan 2026 03:40:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767930034; cv=none; b=BG0mQmcjym1wYQK3dh+jSyfuFp3ya4sSb38us5RXiveonIgsAFV603x/OvhDO8snqxNdemwmssZHq67pWlNDGHY3YryO8zM9yqbrb9BrLXscCEyxhvAPTBHl8ex9GEFvxqL1kio0cmKXSUJS0jJbyR9ldQNlnoDbJDo7wgk4WFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767930034; c=relaxed/simple; bh=ZngBZOuyEiiYCDmUGPUbp507lvGhb4UKwkiVQ+s/3BQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FY1Dsvdeo/TZX/AbeEKgYN13h6WOwRdoGIIkNycYbGpxMVIRlpV+yDdeVfRgrimcvRnmsuOCHUm6CFABIy1cro3rq+BNgoXRFl2Stl/+jjtupTQc6byNvBUwflm0KNlUtzLoHQAxt0ZOboT9v+ZWr7ecY9lYeFytAqQaOt/q3fI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZA2NHhqf; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZA2NHhqf" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a0d5c365ceso28149075ad.3 for ; Thu, 08 Jan 2026 19:40:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767930033; x=1768534833; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6YIIoHMbWWMEgNdY0LTR9KPrDSBdoV9NydkT9nhfA8k=; b=ZA2NHhqfmnQ2e1jprkXQx3r+8pD9xoPyONWvVlJAk5zjl/SOJBiIQMZRZu+6Jdk4co S1oXKslWune1p5DbOQX8fT0qIwxKgUTaogUreOAO+PW8j//nWsoLRm3uVMvyMl6TroV+ sKuegO5N7hMmmc0JUyW41gWbYWWo4eEA8Yxj0cYHlaCjvS8MuR8Cngqk52oOjbaGAwfq 6I99x6jUCbjwTkSZW5XBUsTY6s/Pw0+T6XcSA6cgbHhW0Emn3/rqfv2wawLZbH0s3SoU Cb5VERgBHyUlolaNcX/Slr8bK09Jo1BdAj5gT5CTV4JTjRM+SwJYHxQh7KAxA0683Ioa VTVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767930033; x=1768534833; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6YIIoHMbWWMEgNdY0LTR9KPrDSBdoV9NydkT9nhfA8k=; b=SgyQ6aAB/Mwq00YCrhcwu6qZQvTV5q+6N5aGyYGvYpULyD9spPtCVI3GUp/uJEIdMv tI49/fUTt3BNn4iyt/9NplQ9vlnEpgA7CknD2D9e5GlCTYEYceoddzpCSVR3CCaqAdQS AlGw8n70LdW5f8G9GMNxiHogPpqDfDW/IrRlvZvlhne9vhc+cgkwoKr9AKxBrSvJ0UsG bTTub9nxw4ozYU94N8ll9e31ypNFpxz5L2VIzTo2/dPT4rAg+w0pRCJvD6GiEb7ZxO6B VOoxi4Wddb63QXMEuc4SWLWbNU/jO9/xVyrdfVwMYEwpI8fMI0khArFGjWktiDmBt7Po qtPg== X-Forwarded-Encrypted: i=1; AJvYcCVlKhntzNQK5oZ1qKALtfAcnB3/gzdT/SPcsw6xSWE/XbHOl+bOs7t9q1r6UcKCRkAJ39oBYkS0grigfAg=@vger.kernel.org X-Gm-Message-State: AOJu0YzKOcNHZUV4/kMFzGA3heXKUQKtAJicR9fNGIURKNiuw04GYUR2 eEVtHRfb3zCoVIdIoqhNoXhFX0j1IJ+U+F9hL8aabjpPj6KhCvKi3qqV X-Gm-Gg: AY/fxX730cXIgsO/fEGJldba6AmsyA61rNSyjbfMCp1PFYJhtctr96PkDV1GpX/RsNV uRDFK3ozZSuEfETgXp1s0HFjnBIqITT6k3qYvJ2D7PMHQNIKdjEmgJRlUbmx2YwofSuUbe2msIQ OUXxpgoRYl2ZAm/53imI7IdB0SFdoYLo6P5jISbxPKlDfUF/k8rkWOLx+FtZP5qjQDy/uLJho4I ZKoTkop5Hbabsc1zXqLv12l4itwf+XhnE9FUWicLmDI96mM8WBPbuylwuIx+0M8lvUP5T3PpI+q QZCAWFusaJDIDaVVXrzj+w+eZePHh5td4zEgGvhSpI3fW6BUYxY/qCESTtJ+v0YcH5gcK20lSHn quF8lhYFsJXwI7aIYmA6hW369gtGNx9W4GRgVrYznUhSfV/F5xfjru+Ty89XJKQx5JIO43Wc= X-Google-Smtp-Source: AGHT+IGccHsxtGGAaNFfQO5IjD+5zUxmXgt0wLSTK0XmhDfTjED7T5x5SGhShSFCeCHtkyUfMBlCoA== X-Received: by 2002:a17:902:fc43:b0:2a0:ccdb:218d with SMTP id d9443c01a7336-2a3ee442824mr85400445ad.17.1767930032516; Thu, 08 Jan 2026 19:40:32 -0800 (PST) Received: from oslab.. ([2402:f000:4:1006:809:0:a77:18ea]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c4cc02ecfccsm9116494a12.13.2026.01.08.19.40.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 19:40:32 -0800 (PST) From: Tuo Li To: stf_xl@wp.pl Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tuo Li Subject: [PATCH v3] wifi: iwlegacy: 3945-rs: add a defensive WARN_ON_ONCE for il_sta in il3945_rs_get_rate() Date: Fri, 9 Jan 2026 11:40:14 +0800 Message-ID: <20260109034014.187124-1-islituo@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In this function, il_sta is not expected to be NULL. Add a defensive WARN_ON_ONCE() to catch this unexpected condition and aid debugging. Signed-off-by: Tuo Li --- v3: * Replace plain NULL check with WARN_ON_ONCE() and update subject to better reflect defensive nature of the check. Thanks to Johannes Berg and Stanislaw Gruszka for helpful advice. v2: * Return early for uninitialized STA il data and align D_RATE messages with il3945_rs_tx_status(). Add a wifi: prefix to the patch title. Thanks to Stanislaw Gruszka for the helpful advice. --- drivers/net/wireless/intel/iwlegacy/3945-rs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/intel/iwlegacy/3945-rs.c b/drivers/net/wi= reless/intel/iwlegacy/3945-rs.c index 1826c37c090c..463565ce14af 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945-rs.c +++ b/drivers/net/wireless/intel/iwlegacy/3945-rs.c @@ -626,6 +626,9 @@ il3945_rs_get_rate(void *il_r, struct ieee80211_sta *st= a, void *il_sta, =20 D_RATE("enter\n"); =20 + if (WARN_ON_ONCE(!il_sta)) + return; + /* Treat uninitialized rate scaling data same as non-existing. */ if (rs_sta && !rs_sta->il) { D_RATE("Rate scaling information not initialized yet.\n"); --=20 2.43.0