From nobody Tue Feb 10 01:30:20 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D3D2366572 for ; Fri, 9 Jan 2026 17:18:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767979115; cv=none; b=kQZX8Pyd/vWcjrMwbfyRoGTeuUrX6KTPW0pQMfbBXCkd/aeZqjj3FV47ed4pjIvSPosSRZ0AsabMoVmJqnuxHxy/YPuCFcNdoB+K8L8quGyvEpfklEl0e42T9cmvIrcpqP/T7Hv35tW/WhxyGZvVGkuxrUZT5QdrrIMahbcJdJk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767979115; c=relaxed/simple; bh=3cnZl6iBYq20G1oigmirIZU3zYFeD3CzrUt2kAf0RZE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q4UFlC5tkOFHvnlcksADuklfY/Xmxo+nCqq9l3+YMYcQMLk2qN/83nBVnA72YCHGTdY7QgaJh2Qmf3spyOfVphF3U68Y1/5E5NDCHA2nZJnA44acfyjs1lD3Yfs1qRov7cXxaTIcPQO88Bj7jlctxSZWFpuD/2TA7miPtuLQVhI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=anUYVoSF; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="anUYVoSF" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id E332B1A2752; Fri, 9 Jan 2026 17:18:28 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id B8A2D606C6; Fri, 9 Jan 2026 17:18:28 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 23A93103C89B0; Fri, 9 Jan 2026 18:18:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1767979108; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=+jxMeS1xeb2E/hPVCFWCVOrKjIjBVGxQ/ROrL992r1Q=; b=anUYVoSF/XEgcDp6AyMCYYU4XpfSBdPg8hGKre023w+RWt7yJh0T0Nd3i3Kr5jrdQta2v4 WT+2Dk3YY0Wboj3L4MyE5Cm2Jb/9YwErd6zxfLmhN9VtXuEd9awgxsAZ3gwieFmbRWih5t Es1nOOTSXTrZl7ySmeGZjK7/EjVyn2PpFyUgudVh76nTzgKeDBYWy/1ZNEkhHaCDlHCHcE XdxgTiVJQlt0ONb3wwDPi43vIShbeXHyxRIEmJTMDv2A/Npvx36Gem/YWTZ13ESZdwW34c RXvo2YVvlIelwY8Rc8M9YP6Yi2CDBouoenRzxJrPhlpU4kgBqzksa/i1q+iAog== From: Miquel Raynal Date: Fri, 09 Jan 2026 18:18:06 +0100 Subject: [PATCH v2 08/27] mtd: spinand: Decouple write enable and write disable operations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260109-winbond-v6-17-rc1-oddr-v2-8-1fff6a2ddb80@bootlin.com> References: <20260109-winbond-v6-17-rc1-oddr-v2-0-1fff6a2ddb80@bootlin.com> In-Reply-To: <20260109-winbond-v6-17-rc1-oddr-v2-0-1fff6a2ddb80@bootlin.com> To: Mark Brown , Richard Weinberger , Vignesh Raghavendra Cc: Tudor Ambarus , Pratyush Yadav , Thomas Petazzoni , Steam Lin , Santhosh Kumar K , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Miquel Raynal X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 In order to introduce templates for all operations and not only for page helpers (in order to introduce octal DDR support), decouple the WR_EN and WR_DIS operations into two separate macros. Adapt the callers accordingly. There is no functional change. Reviewed-by: Tudor Ambarus Signed-off-by: Miquel Raynal --- drivers/mtd/nand/spi/core.c | 2 +- drivers/mtd/nand/spi/esmt.c | 2 +- drivers/mtd/nand/spi/micron.c | 2 +- include/linux/mtd/spinand.h | 10 ++++++++-- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index 3abc56e4d23f..b6613f2651bd 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -362,7 +362,7 @@ static void spinand_ondie_ecc_save_status(struct nand_d= evice *nand, u8 status) =20 int spinand_write_enable_op(struct spinand_device *spinand) { - struct spi_mem_op op =3D SPINAND_WR_EN_DIS_1S_0_0_OP(true); + struct spi_mem_op op =3D SPINAND_WR_EN_1S_0_0_OP; =20 return spi_mem_exec_op(spinand->spimem, &op); } diff --git a/drivers/mtd/nand/spi/esmt.c b/drivers/mtd/nand/spi/esmt.c index e60e4ac1fd6f..adadc01e8f2f 100644 --- a/drivers/mtd/nand/spi/esmt.c +++ b/drivers/mtd/nand/spi/esmt.c @@ -138,7 +138,7 @@ static int f50l1g41lb_user_otp_info(struct spinand_devi= ce *spinand, size_t len, static int f50l1g41lb_otp_lock(struct spinand_device *spinand, loff_t from, size_t len) { - struct spi_mem_op write_op =3D SPINAND_WR_EN_DIS_1S_0_0_OP(true); + struct spi_mem_op write_op =3D SPINAND_WR_EN_1S_0_0_OP; struct spi_mem_op exec_op =3D SPINAND_PROG_EXEC_1S_1S_0_OP(0); u8 status; int ret; diff --git a/drivers/mtd/nand/spi/micron.c b/drivers/mtd/nand/spi/micron.c index a49d7cb6a96d..b8130e04e8e7 100644 --- a/drivers/mtd/nand/spi/micron.c +++ b/drivers/mtd/nand/spi/micron.c @@ -251,7 +251,7 @@ static int mt29f2g01abagd_user_otp_info(struct spinand_= device *spinand, static int mt29f2g01abagd_otp_lock(struct spinand_device *spinand, loff_t = from, size_t len) { - struct spi_mem_op write_op =3D SPINAND_WR_EN_DIS_1S_0_0_OP(true); + struct spi_mem_op write_op =3D SPINAND_WR_EN_1S_0_0_OP; struct spi_mem_op exec_op =3D SPINAND_PROG_EXEC_1S_1S_0_OP(0); u8 status; int ret; diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index ad2773f1f963..f7621b47b28f 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -26,8 +26,14 @@ SPI_MEM_OP_NO_DUMMY, \ SPI_MEM_OP_NO_DATA) =20 -#define SPINAND_WR_EN_DIS_1S_0_0_OP(enable) \ - SPI_MEM_OP(SPI_MEM_OP_CMD((enable) ? 0x06 : 0x04, 1), \ +#define SPINAND_WR_EN_1S_0_0_OP \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x06, 1), \ + SPI_MEM_OP_NO_ADDR, \ + SPI_MEM_OP_NO_DUMMY, \ + SPI_MEM_OP_NO_DATA) + +#define SPINAND_WR_DIS_1S_0_0_OP \ + SPI_MEM_OP(SPI_MEM_OP_CMD(0x04, 1), \ SPI_MEM_OP_NO_ADDR, \ SPI_MEM_OP_NO_DUMMY, \ SPI_MEM_OP_NO_DATA) --=20 2.51.1