From nobody Mon Feb 9 11:47:11 2026 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A754F350A2F for ; Fri, 9 Jan 2026 08:38:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767947928; cv=none; b=SM+N+Neclk+WIkmPft7ndbPrdX1sTVjfTh9cB4BOGDe/W3c8MHDzgjULnERIczuTtmJ8gnAsJ3NZkleIXnZPxs0oI91ORlxzycMWWsk2tD8j7wXLR86lebI6Q4Z69FQbC8Ygr7IuFCjS4mdLY5zCzEeaUO60MLMhlkzd6LnMw3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767947928; c=relaxed/simple; bh=nr38tge6MqeHJlzuWU/dTgRarW9sJohtVyW5AG7QXdA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UAsdkDkLa5oGLxiPTJTZ55ezZ/5h2HmtSidZ/EJQgjA0laO1rY2D7xJh5lKeRkLD+QtOgV8W5EYlrV9PktRqWwN3/sWsamaMEjSWYaoOhLqQULY/lD76i5zHgattanwkAOLsZFpjLewugwMUvCwX4/q3s79RoREuJyP3Dcqqw7M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DAk5EXHm; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DAk5EXHm" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6505cac9879so6838108a12.1 for ; Fri, 09 Jan 2026 00:38:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767947922; x=1768552722; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8lFceD8j3Zv7X2wI+TtTpu4Ty19M2h0l6eOvE19hymA=; b=DAk5EXHmBaqOnHT7pSVktU/K0lMvp3NJPmiInk+XpMQS2loeKbNDnM4CTKvFAbVuWg YBye0v7Aszn5xii/3jPgSg7v/Ct6m/6u7L+t6JuwlIoNVK2J/Kmujp+MTfUKlUjvKzKa D4nkRf4pis4MNbR7Kq+PdgAKKSaU/XiWfsKr30HYoq2jWj9esC1KXk+fKuzqHbn553UA 4wykFQ8ZUqaCcsaOxW6cnOom1/q/Pxm6wUMZUjNLXxPOkForpRnbb3OahbBO6Xk+cN5k eva+wGCVWA/FxDqnGIBrQFrXYI2mczZ2w4IgANUfU53+ZdBpkgI0PelYbMsXKgP+/LAu gKOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767947922; x=1768552722; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8lFceD8j3Zv7X2wI+TtTpu4Ty19M2h0l6eOvE19hymA=; b=M3vuSxx6tqZaQk/wDy3Ki9mKx7/y1Eqc4n8kIMtXMEUNvLnWgsQ9eBlTMy4jJu0v6L bzDAd5AQcvAUnLoqauCP27jZxLOK8QVzwjxWEL/juoRB7ljPJMScpe7lx512n7e2q/MA OC9R4lGxjWMexh8I3lKW3LlQBaJcNzHKtesiTNZCojZkq80gxXV6EtMbM3krTLSWGEJI MxUDmL30vTWvO3IeLKhraNZH+ijq+/qKus9h8rN3eqYIs1+BMFzpdVTnStySKfMs1Z8k X6JdhJPY5avRVKqtl0ORBrnK+J1/q4JcoMt6SU7CpnCTKMU6K8IUIO89CItdzEgfyS4n gsWQ== X-Forwarded-Encrypted: i=1; AJvYcCV4RnrZTcwgFBYOrRa2Lx4tGwC8k/ZvEozZrmHdFOaQg41LwBv0NyTq7XnLkNCdSMaE0uRP5XCCdMaWZSM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8DnIWKS6rAG63nEL6sONKWyTh8dNgL9W6roExe7THDNWuksdI Kk8AS201UXCfTEwfgjmIwnw/s1Ku2YAUpYPaLtgObQpK3//YkSIER4lFkPSVfB88kXM= X-Gm-Gg: AY/fxX6dNGi0ndmFArt3OhpSmzy3JYOmmCGG0xGrbmhU+3+89LfkB6wta/LFzY9xpXQ fGamlwHsnXojS2fLX76QaaUnJgaKHggoI2LVBYQ/hIXTKfE72gcosE57qvHCtXGTvDOIIThfk9d cgfG8Os/fYgJJil0e4XRGhIDipjJbEhmOYRdN+dBZuhd3pgZ8mHaA5hkJhJyi+yaAvM6U5rvNVa QX19aGK6Ii0PBNv7B1N+kgG6YKP0bkV4TWlIV+ZGONtP8mxNjJvStXZl+3LKLqEHS8flHMoWwJM nr03Gj1gkq4/vcIG77hCOAuYWIgJTWfz4KKetgWO0OfKAbCY7U3Fpv2a3Lc6gLj07s20yMOVbtY tqI9GKy+s9ZRcIuU1zSp82Z5XUJNwc+dlOFrHckqzG8trOoi1owi7x6tzmFRJTaqvv2p40whATD PxJPOslwal1v8R3MmxR5tgiLT/zK1icngECE5HeXnC3mpWOUqNntR/U6+rzvlJSDbVyZ/tFgeOj YVHtA== X-Google-Smtp-Source: AGHT+IE7DpaQM4d4JyducO1kEDtDGv7S4l8cnvssbW1JcE2kqCS/LpOWl5VzU06EIFNtBM5WjZYZHA== X-Received: by 2002:a05:6402:358c:b0:64d:16ba:b1c4 with SMTP id 4fb4d7f45d1cf-65097e46b58mr8229865a12.19.1767947922464; Fri, 09 Jan 2026 00:38:42 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507be658b3sm9472950a12.18.2026.01.09.00.38.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jan 2026 00:38:42 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Fri, 09 Jan 2026 08:38:42 +0000 Subject: [PATCH v2 6/8] regulator: core: don't ignore errors from event forwarding setup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260109-regulators-defer-v2-6-1a25dc968e60@linaro.org> References: <20260109-regulators-defer-v2-0-1a25dc968e60@linaro.org> In-Reply-To: <20260109-regulators-defer-v2-0-1a25dc968e60@linaro.org> To: Liam Girdwood , Mark Brown , Javier Martinez Canillas , Jon Hunter , Dmitry Baryshkov , Oleksij Rempel Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , kernel-team@android.com, linux-kernel@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 Receiving and forwarding critical supply events seems like they're important information and we shouldn't ignore errors occurring during registration for such events. With this change the supply is unset on event registration failure, allowing us to potentially retry another time. Fixes: 433e294c3c5b ("regulator: core: forward undervoltage events downstre= am by default") Signed-off-by: Andr=C3=A9 Draszik --- drivers/regulator/core.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index fd8da369c0529da12d6e80d90032e07bed414316..86dbee3ffda0b950619db8b52d6= c6eab8be31a53 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2273,10 +2273,21 @@ static int regulator_resolve_supply(struct regulato= r_dev *rdev) * under-voltage. */ ret =3D register_regulator_event_forwarding(rdev); - if (ret < 0) + if (ret < 0) { + struct regulator *supply; + rdev_warn(rdev, "Failed to register event forwarding: %pe\n", ERR_PTR(ret)); =20 + supply =3D rdev->supply; + rdev->supply =3D NULL; + + regulator_unlock_two(rdev, supply->rdev, &ww_ctx); + + regulator_put(supply); + goto out; + } + regulator_unlock_two(rdev, r, &ww_ctx); =20 /* rdev->supply was created in set_supply() */ --=20 2.52.0.457.g6b5491de43-goog