From nobody Mon Feb 9 05:52:37 2026 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55F3C4A33F6 for ; Thu, 8 Jan 2026 10:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767869745; cv=none; b=opMq0wicye9WiAnJx5JdHAXuo0HC3H7qdcZJkONRd8xGZMieaTJXL/G8UtwhttZh+Y2bG4AKxGT83ialF9gRl1FFlMxks4tvq13yWM2qYkvQVlgp06NiVOO0ADVJ9yLcCCG534HGH7xaNkvQv8EB+o/YN5v24Fn122TJjpe91b8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767869745; c=relaxed/simple; bh=DV84cblgSvgDHoRnGhuCakTlxXy7Np5FGsejaAsaLN4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bJD8WYgG6sKGETcFyamq6ruIiocKc9gNQP8KnsbGZ0xzaFsD5DU85Zv7kNQuZ8hxWSCE1GmL2sEGWv9l8wtOk3+BaueNBcpXd/BYkT67KVW93NVVWcb6cej9HsvuTNsd6AVLJlgfef3Ej89vAjaqyDmJ3M0wHhk8OsxTF2EL8Vg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WN20REZw; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WN20REZw" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-382fb275271so17391021fa.0 for ; Thu, 08 Jan 2026 02:55:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767869733; x=1768474533; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5sUiL3ZOTvWLPoCWsXBg+OCgQvCg2mmrzNsfm9RAwNM=; b=WN20REZwAJr7M4l5nFRbuZT/zoj35rBBWPeeTKIVnr8L9yL2dwkH5VUeGh91uMMhoo wsZeDnx79TA7NxISu+bXrI9VNwbAYrrg5ms3CGJbRXK/om1lMhg6Q6aAsY69zjF2GILk HWD2WkQjIsi4bsPJqEkME/hYOSHJGIoJ68MdNowEJ/Dyxw6jFg+Q0Cm8aMvcrdxkbDsh Jg4pfUaYGVyOh+CpYUIx6EmPMfMx1Yk1jALrZaLinE9LPiaF2m2inMVcbIK5cf9Um2Pn aJvMn79Fb7+6y8y/bjQ4Clmp9/V89z31SyCPzFcqhyk3X9I/Jf6xxueUF0a9O6BhKabO k6tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767869733; x=1768474533; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5sUiL3ZOTvWLPoCWsXBg+OCgQvCg2mmrzNsfm9RAwNM=; b=sFjBZ/QQCN/bjYCCw0x69tcZjIldBfMJZu/Pl9mplrAB/FF9rJjGR6IcAaoddfSLvM sBu8/BWqRMbpIouPyv2gjAgzLUvzekOqBIfSRowYEndQH31x1oF/a0A6TWk4QPOTLxaE jBoIxPCNuLgz+T8r0bY/PjSBQsCEL6rqKiipGISL+FQYn5o9HPjg2/wnxcbKEgHLqWzw SS3IO4JATRvKHn6LN7KWc+0ihbj6IkFAqoBsIOBfijz4EaMKEbYUbhI8O9sV1sma/oFq pCvODL7nIXdVWp4cIOgH6cFVPksOgeJXZmbjTM+egy/2PGG6jrQ1hdQdhhmQJ3ElN3Jh HY3Q== X-Gm-Message-State: AOJu0YxSAaYzqWGRZEERSbb79yky2/60+FYPbqMjyEZLY4jjHDrsw0Cd XPb/PSmsXGRu6PjlgTPhgkbk/8uD+/n7wi7fzf1gjrSoPPlZLRdMxXk= X-Gm-Gg: AY/fxX5wUKrnX3zkv3jn87J9hKCGwe+dKcfPhe5N4NRulhQrs+D+BuaMwqIE3qCVzc/ V1aP90wGFNyKdrJBQ75KArT7dDRgle3lMgwUEdCJIZDoCexfvrr+NVU0Zv4r4+voTkPsMpJ/V+O aiehCNH/y7Tu1EdGL/EPhf0sPR8CiNErnJUAMFBiGvJOAMTAcPBZEuuzep6BuzQq17HSgBAw0AI fsJe/fVkR/QaE8zvz7TyWqMBd5orsk70DMRng/8e4x9qgXf5TqaUrQ+tQlltB9ThVbkWQriYe1w cLYbwgQVXgRyN5AFEwT+NTR+HmI0parMZP40T8SehkQ+AmguyNWfGi+NHtMHtCRUZpB0KFtQDTG 6cwEIPF2f2GBXBHMnsXpll8R1r0JqaZ5fS+4howyFVrd6JvYjRG53KZISZVU2a6kIIjZfbqvh0N IUQXqW9Yl/tKxE X-Google-Smtp-Source: AGHT+IE10WeHaFif4GLS1V4eLQCMtBm97EubYvN3+uEqsnenwr1ztGbx5UM3ZPRSVXYnX6mtXhRVqA== X-Received: by 2002:a05:651c:31ce:b0:36d:4996:1c26 with SMTP id 38308e7fff4ca-382ff678f41mr15546491fa.11.1767869732381; Thu, 08 Jan 2026 02:55:32 -0800 (PST) Received: from DESKTOP-BKIPFGN ([45.43.86.16]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-382fc959db1sm10044751fa.2.2026.01.08.02.55.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 02:55:31 -0800 (PST) From: Kery Qi To: bpf@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Kery Qi Subject: [PATCH bpf] xsk: fix init race causing NPD/UAF in xsk_create() Date: Thu, 8 Jan 2026 18:53:44 +0800 Message-ID: <20260108105343.1694-2-qikeyu2017@gmail.com> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" xsk_init() registers the PF_XDP socket family before xsk_net_ops. This exposes .create =3D xsk_create() to user space while per-netns state (net->xdp.lock/list) is still uninitialized. A task with CAP_NET_RAW can trigger this during boot/module load by calling socket(PF_XDP/AF_XDP, SOCK_RAW, 0) concurrently with xsk_init(), leading to NULL deref, list/lock corruption or use-after-free. Register the pernet subsystem (and prerequisites) first and only then sock_register() PF_XDP. Update the error unwind to match the new order. Similar to CVE-2024-26793 (GTP init ordering bug). Fixes: c0c77d8fb787 ("xsk: add user memory registration support sockopt") Signed-off-by: Kery Qi --- net/xdp/xsk.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c index f093c3453f64..63b48e4b8b65 100644 --- a/net/xdp/xsk.c +++ b/net/xdp/xsk.c @@ -1922,10 +1922,6 @@ static int __init xsk_init(void) if (err) goto out; =20 - err =3D sock_register(&xsk_family_ops); - if (err) - goto out_proto; - err =3D register_pernet_subsys(&xsk_net_ops); if (err) goto out_sk; @@ -1942,16 +1938,20 @@ static int __init xsk_init(void) goto out_unreg_notif; } =20 + err =3D sock_register(&xsk_family_ops); + if (err) + goto out_proto; + return 0; =20 out_unreg_notif: unregister_netdevice_notifier(&xsk_netdev_notifier); out_pernet: unregister_pernet_subsys(&xsk_net_ops); -out_sk: - sock_unregister(PF_XDP); out_proto: proto_unregister(&xsk_proto); +out_sk: + sock_unregister(PF_XDP); out: return err; } --=20 2.34.1