From nobody Tue Feb 10 15:45:04 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9C4338737E for ; Thu, 8 Jan 2026 10:36:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767868603; cv=none; b=R81bMLhIqjAZpy7pIwAm3r+M/83DBCKAqIAuzZe8Ly4mseB02QkZbsxA8Gj/HXq2l1DrC80PYgwz0QNPbjI0lnCacNAygE0feqKmvEG5YhD+gsAJH+ZO1yhUbwFsxea36hFKhjaDf1sqnGOoqaPqpX6+/9oGh86+VM4c57C1oRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767868603; c=relaxed/simple; bh=spUFrQpAHUSihVIbrTd6aDb/HQEXMQYbUxekF5wDPZI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bAhicfoT8CAoSf2C7xG//K0P3VKwWWWhmYfqOVHBW5nUT1xpONfTTdOVGIGSfOpD2QXnIUKZAydyvpw0cAkZPiJ/DBuJirjLQIAaxUbw8pMwXJa+wl+uGUHLzJXRAw5Cqm4VV8STaForLLaayyx+12qKxI1Fl1LUcuQHpHhMtl8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=YuFPcOpN; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="YuFPcOpN" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42fb0fc5aa4so2222054f8f.1 for ; Thu, 08 Jan 2026 02:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1767868593; x=1768473393; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o7PLTkw/HbTkvBtEU+lXi+/ObfFOUjX/JmNK1olicNI=; b=YuFPcOpNeyae46NGGeFsfiFNhZrPb5qRP9WlE/O4oGxcGR8aR7ERqVxRLjt6lzVa9r +E//QSn4VStD4CCJ1CzvPoDDIM8623B27W1pGRcRM4rjVSsR2H6BrGKTXZoGHml/vlXB 5+dezXY8ifJe/UBXFwhR2htCu913IGqhxGrtlVvcahBjQXH6aPOYpiE8hIT9Rcf8gkYq CXLi9CxDntOaa+m8IDVsf0Zoj8/XvhXk2PirJRdO2kWJs8Z76BJ39Ypz5uWureCXn7Ba f5OaqLKa9ZPOu9Jink9fCjv4uK8eKzcQ8VhuJ10esIuSelm/Lu2hm8tCwhSQASTAmLkq dM/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767868593; x=1768473393; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=o7PLTkw/HbTkvBtEU+lXi+/ObfFOUjX/JmNK1olicNI=; b=dyCqzh1RKm0eb6cgZcsUQ/ux/W1n8h+Cg3CzPYyH2MpyrIHjCY6EbWv4hstqe4Fq84 pcFQB7TEek+ixVhfPYirhwifyUlrc3WpvXDV5UKhV0avvNuS4Kc5JD1B9KPzmbhPlxqX wOKh3dwlDwgtt2xUgyxLMYyv2Nz7NyJaf7clz7PhYsU/vGSkp45UHc4CaGnXOmZppf+z CdEYTroZ5n3HGWGwSFm9QpqjSEIPwjHAc+2zKfsXOqTJrI94eheNaivSgHuFgGgNmPnF 5ARbuFXwycXIzR9nKNRogKpHRtWIuj1IJkywP/9WTVMCw+CLVA7jRgFxgPh8CnTDDenM BFXg== X-Forwarded-Encrypted: i=1; AJvYcCVkQDVcVkxluDZQ/YLajYgntqGJXF9V2AGdLAiUhSgXPayGz6voU3PNl3gRikLEt0xk4T0ugxWQgfkzi7A=@vger.kernel.org X-Gm-Message-State: AOJu0YxOBxwKo8Voq2+joocC5BTjbc8JkzjfL/QPS7DAzNJtZ3GstVUd 2xFiF6JqkQYonAPYiErwRqfNFYDawmBSZH7+R+YQOtO19Nq3htQOOkax2PVrHwoLZ8k= X-Gm-Gg: AY/fxX6JlPAh2tAYfvwrL2a9gPp9njx0yMBu2s0NKojHhpyXZDN/s42fkWBTStxpwY8 NcVcTSRZo7AhvJU2yuH8C19ShVzrS+0mTgS23ctDlAXBzzl/8h5Mx485QOi/B0BEDATMxnF+WxE Ct7TKlRCBh7F8wFwh5Q441CcqbBUaLbHO9k+w744CbR2cKUTkO5Iqj5OIgTtG7w9pWpm0dugxNe NEl6d/aMR6npkAGem3qA6jcIGfBpXBUsuGOQ3W24ugMM6ffF2S2h23M4Fbxb6bE2mH8R4SJC54d WR92o9tm4f1Q7gBdvhakW8iLz8Ct4PjYxnLDgGx+oORratnogRioED4qWQ3Zpknqv3ClB7JqHC3 DIsRZGBuuUWC59qNn4hr+6PybgVdehzDQpSFDAQeS7l+MkCJgxVWh94zKPOmJfGMZ6mFixsT+FW q/liYxDWWvSk3PQHq1LRAyfnDsdQsrDMw4JTTpa0k= X-Google-Smtp-Source: AGHT+IF0e1OZBhaJwQ+s5DlVX+WY1KnxeqJ91c95V464aKTYpKJlrDgGrA3vXH3o0akj7eFchMyu+A== X-Received: by 2002:a05:6000:25c6:b0:42b:4267:83e3 with SMTP id ffacd0b85a97d-432c374f5femr7993687f8f.5.1767868592727; Thu, 08 Jan 2026 02:36:32 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee243sm15399033f8f.31.2026.01.08.02.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 02:36:32 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, fabrizio.castro.jz@renesas.com, geert+renesas@glider.be, prabhakar.mahadev-lad.rj@bp.renesas.com, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 8/8] dmaengine: sh: rz-dmac: Add device_{pause,resume}() callbacks Date: Thu, 8 Jan 2026 12:36:20 +0200 Message-ID: <20260108103620.3482147-9-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260108103620.3482147-1-claudiu.beznea.uj@bp.renesas.com> References: <20260108103620.3482147-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Add support for device_{pause, resume}() callbacks. These are required by the RZ/G2L SCIFA driver. Signed-off-by: Claudiu Beznea --- Changes in v7: - use guard() instead of scoped_guard() - in rz_dmac_device_pause() checked the channel is enabled before suspending it to avoid read poll timeouts - added a comment in rz_dmac_device_resume() Changes in v6: - set CHCTRL_SETSUS for pause and CHCTRL_CLRSUS for resume - dropped read-modify-update approach for CHCTRL updates as the HW returns zero when reading CHCTRL - moved the read_poll_timeout_atomic() under spin lock to ensure avoid any races b/w pause and resume functionalities Changes in v5: - used suspend capability of the controller to pause/resume the transfers drivers/dma/sh/rz-dmac.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 44f0f72cbcf1..de95139c18a0 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -135,10 +135,12 @@ struct rz_dmac { #define CHANNEL_8_15_COMMON_BASE 0x0700 =20 #define CHSTAT_ER BIT(4) +#define CHSTAT_SUS BIT(3) #define CHSTAT_EN BIT(0) =20 #define CHCTRL_CLRINTMSK BIT(17) #define CHCTRL_CLRSUS BIT(9) +#define CHCTRL_SETSUS BIT(8) #define CHCTRL_CLRTC BIT(6) #define CHCTRL_CLREND BIT(5) #define CHCTRL_CLRRQ BIT(4) @@ -827,6 +829,38 @@ static enum dma_status rz_dmac_tx_status(struct dma_ch= an *chan, return status; } =20 +static int rz_dmac_device_pause(struct dma_chan *chan) +{ + struct rz_dmac_chan *channel =3D to_rz_dmac_chan(chan); + u32 val; + + guard(spinlock_irqsave)(&channel->vc.lock); + + val =3D rz_dmac_ch_readl(channel, CHSTAT, 1); + if (!(val & CHSTAT_EN)) + return 0; + + rz_dmac_ch_writel(channel, CHCTRL_SETSUS, CHCTRL, 1); + return read_poll_timeout_atomic(rz_dmac_ch_readl, val, + (val & CHSTAT_SUS), 1, 1024, + false, channel, CHSTAT, 1); +} + +static int rz_dmac_device_resume(struct dma_chan *chan) +{ + struct rz_dmac_chan *channel =3D to_rz_dmac_chan(chan); + u32 val; + + guard(spinlock_irqsave)(&channel->vc.lock); + + /* Do not check CHSTAT_SUS but rely on HW capabilities. */ + + rz_dmac_ch_writel(channel, CHCTRL_CLRSUS, CHCTRL, 1); + return read_poll_timeout_atomic(rz_dmac_ch_readl, val, + !(val & CHSTAT_SUS), 1, 1024, + false, channel, CHSTAT, 1); +} + /* * -----------------------------------------------------------------------= ------ * IRQ handling @@ -1165,6 +1199,8 @@ static int rz_dmac_probe(struct platform_device *pdev) engine->device_terminate_all =3D rz_dmac_terminate_all; engine->device_issue_pending =3D rz_dmac_issue_pending; engine->device_synchronize =3D rz_dmac_device_synchronize; + engine->device_pause =3D rz_dmac_device_pause; + engine->device_resume =3D rz_dmac_device_resume; =20 engine->copy_align =3D DMAENGINE_ALIGN_1_BYTE; dma_set_max_seg_size(engine->dev, U32_MAX); --=20 2.43.0