From nobody Tue Feb 10 20:48:45 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DD144BB0AB for ; Thu, 8 Jan 2026 10:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767868600; cv=none; b=NvsZhukJ2XdD4nB06On6uj7q/hlQSVKEj4EI+LNYUgpdpWq0E69xmQgGEcQWkVVi6+quRIL1ZZxtJyNgBZ80yNAavIdIlDltGhcEj/7gf+yk+ux0AX6+/Mb49Hw3w0G8y4nMhRET/94T1dEzA2tp4HkwVkbDpY+MBTA//OLZAtE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767868600; c=relaxed/simple; bh=6WsUDBB7QB7beHKPFRpBEY1bDN8cUp493GVUrOWSTok=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aCEHEoWf54D6SAjBkGNxoawh0NopBdKQ2HIiKx/2H/cU18CSCCFyyr3FDp+toDjwdjNIYWDk1Z2pfwnudTOFvN5QZCItpB4IER/dWYJiXakB5+Mi6D/FG7+QR0wkldZ8ZHR3CFXCNGu+2Ap8uAahyTJgogdLYMzxF0ZM7djzrM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=F4WK8N55; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="F4WK8N55" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-42fb6ce71c7so2312285f8f.1 for ; Thu, 08 Jan 2026 02:36:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1767868589; x=1768473389; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e1SXKH3uUM3QnZfl6aZyV1ZJSZCTqIp00wyVEztqcnA=; b=F4WK8N55OHopne6Nm39snqKl9wIVf98Zy23Kptoef6q5194Pyvnyd5YiOy1E1Bwl3u 9trMbOvQ3+fAlEH5gZxpi9Yp1IsMGKh6dM6+xyWge8yqtxqrC7iqeToJtrpt9FwfZJ0f lus8D+JpTeitHjrjZrdnXsMJ/gEqTg6Xljsk8TaC0MMsExcLjSM8LmJXj92ITgqrQ57w 3Vqj2lV+w/krWrIcShj/O2AnftXBT9doPBDQ+d/leWhypNlp2gSw4cA0dNHrOlC5znb6 cmR24xMCKe8ikD1+u/WEOLyltDs8RTnvoXWMFvVbbhawlDybf0KWER40ZEvLwQMP1gaK o4Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767868589; x=1768473389; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e1SXKH3uUM3QnZfl6aZyV1ZJSZCTqIp00wyVEztqcnA=; b=SbRYhy70MlZJd7UfnBx1dwi3jOJQEQMNHHmmg+gLi8I0oc1QbGOxH6JgArEhAFSXgN 1eaKYHdWZePypMPJ866jd9FptWydXrSoPIW1yl1LJ3e6ewW2YbCACxcZRW17HT97yS18 9yuvM0CrXAYxBfhZeSh5QLrDjtWsinOoKOaS6V1mI8UjoXgBBhKUzVmO9RSW9rrZOjFc bKOZASZ6Ti7LRoYTJIkpZXXQ7UP9cqouYnVKR9lUmlt3IIGVRVilHb6O9j1/8azjWFw7 ttym786TywQv7+Kl9D0jALBs3gCakdp1kCHxO+HHOpxDAKBIeP01K4655Y6iFT5XBYuX azTQ== X-Forwarded-Encrypted: i=1; AJvYcCWFApqlPW6LXaFZGmPt/Tq0hFkL7SWsLhA9vRvJEQ4/Ch1l5a+YKEAS7rFgRFbTYjsMNRIH3Gsv4tSZv1M=@vger.kernel.org X-Gm-Message-State: AOJu0YxeHwTnN/7scSL6UFvRQbHDh3t9UXBPX5Efgrf1a/V7uo6Y3wmo POVU0JmuKqIkDdyiLrTB8kFFNVR7yUx3YFU1JFf+mzhPex/8X7krqnnzp+PWeriFMjw= X-Gm-Gg: AY/fxX7pe5i4jj+xl9kzJDDqGUR4dHu2J/Rop9vsf8e0BF8mNOGcV3pi/xS73PbFncB ghi1imch1FHQnv+urcJgCRG1McI9eR384GcGnJHCdCF9NRH+eJVS/54GKypNwOjKKexbqZr4CZR K/FF4+C1iJ5XbqM/45nPAKUXMPonU41uTJbd67NMmDlcwBhgQbYGhVyO1ZOSbqMsHnBN6TPULnL h9HZC/8yX4wZb2UlmH7jJMjAY/Y3YUZeaWQQk8RHpi6T9M1QmJt3YZIUzl61CiS1flKYNRXLpih 8uCM0l1VVZm2ndiYZimr2Z45FAKFShQkpDUgZaihVf+ePYpwnF3DiPeI3Tfrc5td0LOLckqGhe5 +4Ga44GTr2YIg0GCEAALVCI4aF+7968tYl4UaRZ3FH8XKEiyZW6F4Zle65YB7WlRau6vQtklK4y +LbkGgEr2H6KXyHFpOhM0uMEhBYSOyZKTSqD3oxQU= X-Google-Smtp-Source: AGHT+IHsxCiYx8rmqp77oAdTH6pZgI1q5pv2nheYrLqEiaVk/RQ4pqEz3b62xkFaX7spNJWohof1hQ== X-Received: by 2002:a05:6000:2909:b0:431:84:33e with SMTP id ffacd0b85a97d-432c37d3641mr7597423f8f.50.1767868588683; Thu, 08 Jan 2026 02:36:28 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee243sm15399033f8f.31.2026.01.08.02.36.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 02:36:28 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, fabrizio.castro.jz@renesas.com, geert+renesas@glider.be, prabhakar.mahadev-lad.rj@bp.renesas.com, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 5/8] dmaengine: sh: rz-dmac: Drop unnecessary local_irq_save() call Date: Thu, 8 Jan 2026 12:36:17 +0200 Message-ID: <20260108103620.3482147-6-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260108103620.3482147-1-claudiu.beznea.uj@bp.renesas.com> References: <20260108103620.3482147-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea rz_dmac_enable_hw() calls local_irq_save()/local_irq_restore(), but this is not needed because the callers of rz_dmac_enable_hw() already protect the critical section using spin_lock_irqsave()/spin_lock_irqrestore(). Remove the local_irq_save()/local_irq_restore() calls. Signed-off-by: Claudiu Beznea --- Changes in v7: - none Changes in v6: - none Changes in v5: - none, this patch is new drivers/dma/sh/rz-dmac.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index a2e16b52efe8..72ec42fedac6 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -267,15 +267,12 @@ static void rz_dmac_enable_hw(struct rz_dmac_chan *ch= annel) { struct dma_chan *chan =3D &channel->vc.chan; struct rz_dmac *dmac =3D to_rz_dmac(chan->device); - unsigned long flags; u32 nxla; u32 chctrl; u32 chstat; =20 dev_dbg(dmac->dev, "%s channel %d\n", __func__, channel->index); =20 - local_irq_save(flags); - rz_dmac_lmdesc_recycle(channel); =20 nxla =3D channel->lmdesc.base_dma + @@ -290,8 +287,6 @@ static void rz_dmac_enable_hw(struct rz_dmac_chan *chan= nel) rz_dmac_ch_writel(channel, CHCTRL_SWRST, CHCTRL, 1); rz_dmac_ch_writel(channel, chctrl, CHCTRL, 1); } - - local_irq_restore(flags); } =20 static void rz_dmac_disable_hw(struct rz_dmac_chan *channel) --=20 2.43.0