From nobody Tue Feb 10 10:18:32 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D74FD4B9E54 for ; Thu, 8 Jan 2026 10:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767868589; cv=none; b=sXT9esoZZTi3Z/PiXPHAqiT4mEiEcyMJNNd2PkwE9madJRIQl/a9d9LxINuSNoHrDms5vDWxbyUZ9k+q0wM0ptQXOCg/+6pq4omO4DE2O/F5O1gb20x2MEFq4QorrwuWILnXss9v4o9d/BZtMdQGnt3n34PzweVX2G/KzTRR3AA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767868589; c=relaxed/simple; bh=JyEbq8Tn/Uo5/rzkdivZJn8DiJudAQoXSYyRKYcviZg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DlLAImLBFYteEQiHS1rU9JyXA49aPQJ10zGA7nDGj6doSxojftbBnIFHiWVzodCZcw6kWHTTMMy+qRIbrc51iqvAY8zk2O5/n7wF386fMIkgBTf4pZQsoMMEAs6DRRq5fySTlMPbZeWyhoe/aH8OUPd907zSSsL6MSKlfH+rSqo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=DR9o07p6; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="DR9o07p6" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so21047525e9.2 for ; Thu, 08 Jan 2026 02:36:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1767868584; x=1768473384; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tJKnYHH5iFZVhNa979c5sT22P1hY4dxyKYzImPI2Bi0=; b=DR9o07p64tbezMxLYgt9ijnbUpSDNT+02CyrkEiBtu9P3BLXV06RGmViY/nijp1YDY dZX4o8uOEBHtpv9zbHVR4Askt9wWTGMA+gte06xxBvmN7hAlU1DkjRgq/qxcNXLP21Sn ypuKN2vtQMgDxssyyUGc9yNAEnvlmHesiOk8Io6EzmkrmFUIkSeIfyvu0WKelQK2mjLG 49lxo2nEoabXROTamyscDWxCMcixIDA8nFzYtDhINBPyw4ZVhM5frKevD0tC+JXU12Fs +nyg/P4zP38jvs17m7UPBRSQwJTkp0BEn77Hp2ZgQabPMEYCpNvHJeGBfYIZAEUVgRDO 9j3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767868584; x=1768473384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tJKnYHH5iFZVhNa979c5sT22P1hY4dxyKYzImPI2Bi0=; b=UxHUg6mEnr8IibgV+d3vD7CWzBquYlY0QOmBUY0jTeDGLOZ1i3ILJz/ZFZVueA+4/9 9ZbZaviWU7c8+EHSXMcMaqQyygdfFFbO2sYo+hVOdnsotz66hL8HvB1/oXaa47aWNIOd Bk61AsAEJsUa3RiAyPEUiMgLIhJa/1TEjJgveEczSGgVNwW1GI+lJx79Nd10n2hyvjJV jkNMAlqEJLz+XC6ocfqp38LFKyGABcMI7GUcoXalpKZCel8WsT6G4wU8FeDA8TaFaaZ5 Zp7gFhWvSk5FG5BRfu9dacg799R9bvIjPXOalYybT8Rw7m5s98SKYkoVw8wjKg+GH+Zr XNGQ== X-Forwarded-Encrypted: i=1; AJvYcCWMnmlk4rPTrq5cN7KDcaxGuc5hotM1gmVj3K+sXbinKEoCJIaPpIVomA3w+SdrrZZealeJgXTZWDlyPQA=@vger.kernel.org X-Gm-Message-State: AOJu0YzhhOXOQpUGzc+WxTc2lGp5jT9UqgtfEr8Yx/iP21BmcIFZD1Gd MkD15c1ldJv/6e8GJGw+A/m8kOgTnb8fyKBw0MTQ2tJm0rNBQ6dc0vOa0B/4gNhL5eY= X-Gm-Gg: AY/fxX7ZilNf44oQ/4GH39gk/t+4asrUHPj3e+4B0DPWGKKPZmOzzjp8jas58EfdnQk K5PEyJR/Z8lm54Dk9GxEksHFdSmt/r4PRGjxR5oA/lGWxNR9IybVJxOLDGqe/E4AGIK1PAX9I7g xugFtI61eZd0PGT7/mK8t4w12SN2p6PtVIx+ol68fD/H+ErdHysB8tc48mp0aPswzZ/G9E8iaOj 6SiVRv67YqwYBURnIZr4u5g88DbCu6De7LA8UhJAwNT0QEjCUs0TpiCLue34dfr+ASsMMVYgFBh Vbxc3O36Rm0e9ShzpsDagPYVXfCupikDn3z46obPaA8QAiiKDgzTp8ZgO4UlEB7HtMX56dnvPdO NwVLVyYv0mxJRDBOt9lRKS6q9aI6tdXgIbU89moSFhn6YpVZ+/WozscFAnYfQKaGSX73rKfFXqh Nfo/nhjfoRomB1e7vhrTvvs8UfCH2zdrWusnwcyO4= X-Google-Smtp-Source: AGHT+IHIn4DooV1mtjazn7yQKWIVyIXO9iOYz2GWsNA8OQ/d9RWgsYlYP49zJM9rtUcU0rRpnde25A== X-Received: by 2002:a05:600c:4f0e:b0:470:fe3c:a3b7 with SMTP id 5b1f17b1804b1-47d84b1a3dfmr68260285e9.5.1767868583679; Thu, 08 Jan 2026 02:36:23 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee243sm15399033f8f.31.2026.01.08.02.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 02:36:23 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: vkoul@kernel.org, fabrizio.castro.jz@renesas.com, geert+renesas@glider.be, prabhakar.mahadev-lad.rj@bp.renesas.com, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 1/8] dmaengine: sh: rz-dmac: Protect the driver specific lists Date: Thu, 8 Jan 2026 12:36:13 +0200 Message-ID: <20260108103620.3482147-2-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260108103620.3482147-1-claudiu.beznea.uj@bp.renesas.com> References: <20260108103620.3482147-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The driver lists (ld_free, ld_queue) are used in rz_dmac_free_chan_resources(), rz_dmac_terminate_all(), rz_dmac_issue_pending(), and rz_dmac_irq_handler_thread(), all under the virtual channel lock. Take the same lock in rz_dmac_prep_slave_sg() and rz_dmac_prep_dma_memcpy() as well to avoid concurrency issues, since these functions also check whether the lists are empty and update or remove list entries. Fixes: 5000d37042a6 ("dmaengine: sh: Add DMAC driver for RZ/G2L SoC") Cc: stable@vger.kernel.org Signed-off-by: Claudiu Beznea --- Changes in v7: - none Changes in v6: - none Changes in v5: - none, this patch is new drivers/dma/sh/rz-dmac.c | 57 ++++++++++++++++++++++------------------ 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 9e5f088355e2..c8e3d9f77b8a 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -10,6 +10,7 @@ */ =20 #include +#include #include #include #include @@ -448,6 +449,7 @@ static int rz_dmac_alloc_chan_resources(struct dma_chan= *chan) if (!desc) break; =20 + /* No need to lock. This is called only for the 1st client. */ list_add_tail(&desc->node, &channel->ld_free); channel->descs_allocated++; } @@ -503,18 +505,21 @@ rz_dmac_prep_dma_memcpy(struct dma_chan *chan, dma_ad= dr_t dest, dma_addr_t src, dev_dbg(dmac->dev, "%s channel: %d src=3D0x%pad dst=3D0x%pad len=3D%zu\n", __func__, channel->index, &src, &dest, len); =20 - if (list_empty(&channel->ld_free)) - return NULL; + scoped_guard(spinlock_irqsave, &channel->vc.lock) { + if (list_empty(&channel->ld_free)) + return NULL; + + desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); =20 - desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); + desc->type =3D RZ_DMAC_DESC_MEMCPY; + desc->src =3D src; + desc->dest =3D dest; + desc->len =3D len; + desc->direction =3D DMA_MEM_TO_MEM; =20 - desc->type =3D RZ_DMAC_DESC_MEMCPY; - desc->src =3D src; - desc->dest =3D dest; - desc->len =3D len; - desc->direction =3D DMA_MEM_TO_MEM; + list_move_tail(channel->ld_free.next, &channel->ld_queue); + } =20 - list_move_tail(channel->ld_free.next, &channel->ld_queue); return vchan_tx_prep(&channel->vc, &desc->vd, flags); } =20 @@ -530,27 +535,29 @@ rz_dmac_prep_slave_sg(struct dma_chan *chan, struct s= catterlist *sgl, int dma_length =3D 0; int i =3D 0; =20 - if (list_empty(&channel->ld_free)) - return NULL; + scoped_guard(spinlock_irqsave, &channel->vc.lock) { + if (list_empty(&channel->ld_free)) + return NULL; =20 - desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); + desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); =20 - for_each_sg(sgl, sg, sg_len, i) { - dma_length +=3D sg_dma_len(sg); - } + for_each_sg(sgl, sg, sg_len, i) + dma_length +=3D sg_dma_len(sg); =20 - desc->type =3D RZ_DMAC_DESC_SLAVE_SG; - desc->sg =3D sgl; - desc->sgcount =3D sg_len; - desc->len =3D dma_length; - desc->direction =3D direction; + desc->type =3D RZ_DMAC_DESC_SLAVE_SG; + desc->sg =3D sgl; + desc->sgcount =3D sg_len; + desc->len =3D dma_length; + desc->direction =3D direction; =20 - if (direction =3D=3D DMA_DEV_TO_MEM) - desc->src =3D channel->src_per_address; - else - desc->dest =3D channel->dst_per_address; + if (direction =3D=3D DMA_DEV_TO_MEM) + desc->src =3D channel->src_per_address; + else + desc->dest =3D channel->dst_per_address; + + list_move_tail(channel->ld_free.next, &channel->ld_queue); + } =20 - list_move_tail(channel->ld_free.next, &channel->ld_queue); return vchan_tx_prep(&channel->vc, &desc->vd, flags); } =20 --=20 2.43.0