From nobody Mon Feb 9 10:28:48 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AA4241A03C for ; Thu, 8 Jan 2026 10:23:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767867809; cv=none; b=UpJJZsRKDMqkDZEhnK3DkJjq2sROxYTaLC0h8pn8jRTQLSn0AUICLVkGUUrmKyRw4eoJxlNhOtbxdTpVxxqMzSO5QLpag+09uRN3H7VUdU7nWcXZQjZt4tgo00g90KHKkiK0kXuPm/zv/7XCOZe14kUSLXsBVpN69wzlPe4u7Kw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767867809; c=relaxed/simple; bh=Ftr3IgGvbpnHB7xGwFYCub+vyYQHOzx6FOuUh7ewxCY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=o6WRYQKeqZqsId3hQB15vZEIAblKd/Dxa7bS22y2sZ+I6sEXZwpHzexuw7xxi1ny4IuJzW9D714ZK0AsqzUCoouK7hJ7a6rYFhei7BK4XSxzFpt1ExwOBKhVfugzMi0kTCFM/y6abp7WN7jX0KXLHTq2SKIDyAdcH4aCCeuaVoc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ax1AkfTl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=altKtsCl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ax1AkfTl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="altKtsCl" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6084FuCi3751454 for ; Thu, 8 Jan 2026 10:23:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=D2jE3DOpAX74BnaJpKPiQEbPatuIX3G9k07 QCxvKRBA=; b=Ax1AkfTlIFgO49TyjtU32o4Yjy6mFAghVHIeuX3Tjfp7OO8U+Pg FFD9GMn5IfDPueIMJwlUQpjpJtny85LnymtO5EW/Apq6eqKZWydwcJ+3s0ryAD4P BVFpoMlBqyrmVpvUmNb+er6eZLIHUgM5W0wbmmDl9aCyEdRDaIVjANDKMo6jz6j5 pcIEHMEht449jQw3RddHB3ODYX34JwIR41k4FrAaWB6s1DUiPIwL4p89QIRUuToH KzHQciv+Gty5AChzVBdBRnm6bo5Zpvdqd6rwDJlxKnuKXj0/YTtLsM3yWGoiQxbY /6DkdLWxwsgw63FbsIBvV2vIOZNIT+kuQlg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bhuxctva2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 08 Jan 2026 10:23:23 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b2e19c8558so705700885a.2 for ; Thu, 08 Jan 2026 02:23:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767867802; x=1768472602; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=D2jE3DOpAX74BnaJpKPiQEbPatuIX3G9k07QCxvKRBA=; b=altKtsCl8VPN7d6xkUalzRrEtvHF2rIjTUkO5GkyXbL0r/UwB0CSmQ1W6v+wehP5yI hiGUWg71quaTh4vMPxYyHdn8FFLLbOu6cumlBkLBs+edaPb2BgJr+MxW6ITK40T9zqFL D0c33ejfVpQhaIm719wIpTznQXQozW+NXS3osfZfo1odOMTbeXgWfKLQu3i/jMkqjmPq 4ZYvuLhm5qFUnEhrF/swlWfs71D3i3LpK6yZLahkEdV7xWN6l/kxH7+JyR/Phw9ZI3VT MJkwsMatKFEFnkpavSvc5Qfhnu+HRk2LiObjUGsAASCNuFUNj00rSnsLpOJAurZU93bl g+NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767867802; x=1768472602; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D2jE3DOpAX74BnaJpKPiQEbPatuIX3G9k07QCxvKRBA=; b=DmLQLCRM5AF1cMEldoAGfHB8uk6tMmImYD8RfkiPmPTrYnZgP3iiZN6Vo8ollWuUgm qx5pUquuyZ5Z+Qsa+xCU3ivwfS+bGTbYIMTlhZgaiFRKxJ5LAipe0QvmydaPk91vMSQt kfbwLssw1/kuRqQLdhOHx5Venh96xCUIKo5Hk9ExJaDGOtFduwztMKDoz2EYskmC/RS7 zPK5u4FvOnYFDTp+qWbMiDT3sk1TLTavieuXrOy3SwzsNm9lO0Lj0z9xcLLJv1HGnYGp 0UX7TQ8z242ha+6X7qeI7o3DeGfeyyzzU6aqm1dPUBzTrReL8h6t/bWpCQ7E67XnVSP/ NE5Q== X-Gm-Message-State: AOJu0YzSmpc1DUc32I7Ek4BbTD9ofBNNo6kPrN6w188KwsMvZM7cKTzy ssnzKL6L5NqAirRvpSKpzJcT7AEQhylH+ocogGnbiMxm8SmKhGsQjvro3bTjvvGGWpMBfDF+7jY z+ZnVdtFbbMgjw7vJaHXyEKVZxeZnCzvsiCtCkwqjmsDY3/6KlQztwiAPLolB6URQQfY= X-Gm-Gg: AY/fxX6/TAKTtscz3bObQSfiHUflGxgZlhUdvvKV/ZIJi4ev1A/rU6hVe4f5Db4YFao H8XqXaFb1jBvdVaOhNZk7DaXTGZJM+LQcq0AMVWDaKhE9rb+PN3X7G15OGylesTZgZwQVFRecCc gxCURJlckabMDFZSZ7H89pMiAGOVOZFPvs+leSQATmjCoksaTN8jzs1hlWQYyK8rKQn9F9WjwQs JIHBGvdLnbFr55ihiu0Tee9txXye+oL8ZVlPzMVJBX1/FpOTByeVSYUDr2nY0jk2+8DvLvV/dJd XtiHOG5LMO0FZJyBr2tyP5VhdZp7GPi5TpXBmiCNc4G9LqSpkt40ovJGyHZZG1bxVW+k77H/1Vs LfSj9iY1yMaJ/ic5YOCA6NPH5a2CakBOhiiD5lsE= X-Received: by 2002:a05:620a:390d:b0:8b2:74e5:b36 with SMTP id af79cd13be357-8c38940bbf7mr774853285a.68.1767867802157; Thu, 08 Jan 2026 02:23:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IG6bhWWJawZsOJcxowrutES32Z5Bx2kDL4bbATPF80TkLboG5Ysx189zsCeAz3aQsCgHhNmkQ== X-Received: by 2002:a05:620a:390d:b0:8b2:74e5:b36 with SMTP id af79cd13be357-8c38940bbf7mr774849985a.68.1767867801771; Thu, 08 Jan 2026 02:23:21 -0800 (PST) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:2dfa:dbd0:9cb3:22b1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f69e802sm147574825e9.8.2026.01.08.02.23.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 02:23:21 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Bartosz Golaszewski , Marek Szyprowski , Konrad Dybcio Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] gpiolib: fix lookup table matching Date: Thu, 8 Jan 2026 11:23:14 +0100 Message-ID: <20260108102314.18816-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA4MDA2OSBTYWx0ZWRfX16kzPJtLlNDb h08ZjouQ6ARMsWFfWMkPE0YWGAHf16UtH2GYi+9Z8GOYWK/ZkT4ywiFtOKn5F8/oQr4iydqTwX/ ryK6BlyD7EPEDjh+PZzh6QG7G4Iv6MxzUPMW4mNXyDR1+BipBHo8QBERRHGLerXI0Z3edTUMrnR E9sOBllJqwcChaXwZ4SmnoYyqtyoTZKnjOOvn2yuc4eoDgn+4QszjW8BNJh8XrLIKz79ZLCnzMc uXH9P3Xtwxos2mp11baghz2xittrqa7JWh+UC4jzcOfuTfYReYfhJp1dYdQ5S/G0dtU/c6770rh BdFAJznAAuK8wOq2Xuw6R/eNm/j0LauEZGnJ5GRJLBa5995rOR2RM/FOqWF2xLF2F4GGL68HddT 0BoPQb707NVe2enkH2ZuLDueRLjmAfTGPr8RvcsTYK9UKKC6egYMQYyxdxE+JZqjGJ6kCWkiKnn ouz6bPCF9K4CH7Y51Og== X-Proofpoint-ORIG-GUID: AGkojJsFLsUXaLYwRTXrdxR3uFGMfqCB X-Authority-Analysis: v=2.4 cv=SPdPlevH c=1 sm=1 tr=0 ts=695f859b cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=hD80L64hAAAA:8 a=EUspDBNiAAAA:8 a=aiDJYg_SX6YcQUpIuH8A:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: AGkojJsFLsUXaLYwRTXrdxR3uFGMfqCB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-08_02,2026-01-07_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601080069 Content-Type: text/plain; charset="utf-8" If on any iteration in gpiod_find(), gpio_desc_table_match() returns NULL (which is normal and expected), we never reinitialize desc back to ERR_PTR(-ENOENT) and if we don't find a match later on, we will return NULL causing a NULL-pointer dereference in users not expecting it. Don't initialize desc, but return ERR_PTR(-ENOENT) explicitly at the end of the function. Fixes: 9700b0fccf38 ("gpiolib: allow multiple lookup tables per consumer") Reported-by: Marek Szyprowski Closes: https://lore.kernel.org/all/00107523-7737-4b92-a785-14ce4e93b8cb@sa= msung.com/ Signed-off-by: Bartosz Golaszewski Tested-by: Marek Szyprowski Tested-by: Val Packett --- drivers/gpio/gpiolib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index fc382f43f9fc..0a14085f3871 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -4602,8 +4602,8 @@ static struct gpio_desc *gpio_desc_table_match(struct= device *dev, const char *c static struct gpio_desc *gpiod_find(struct device *dev, const char *con_id, unsigned int idx, unsigned long *flags) { - struct gpio_desc *desc =3D ERR_PTR(-ENOENT); struct gpiod_lookup_table *table; + struct gpio_desc *desc; =20 guard(mutex)(&gpio_lookup_lock); =20 @@ -4619,7 +4619,7 @@ static struct gpio_desc *gpiod_find(struct device *de= v, const char *con_id, return desc; } =20 - return desc; + return ERR_PTR(-ENOENT); } =20 static int platform_gpio_count(struct device *dev, const char *con_id) --=20 2.47.3