From nobody Sun Feb 8 05:41:55 2026 Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59E173B530A for ; Thu, 8 Jan 2026 09:38:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767865105; cv=none; b=QdM72W8Lnml+Zur1bm5doy7VC/H87YWUhvrSyEouPvqHVqVn+w3UPe3GvH7vLXp+dXPSB3Mk9VMOQ5nqPAN+cpN48Hz0Mg9GzEEI9WqmbZbsr1xv6sMnJJbeLDLoeUIFeRp5t4K+OMwkfypPfwXnzdti6UyXW6Xib+5JL87voe8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767865105; c=relaxed/simple; bh=HX04hRgY5dPP4tcUYLt5iDhQs2uyNrZOdgvMUCZNlTE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ssfL4PM+Zlk5dcXU4p9EUAJHnwJXxtxBV6uqqlUjlpi4BSl8tSyKRQFBcm033b1vmM5yKTZQMSgpIk86KGaf0KzifbaGtifFVaibGvpCDEknsuyt4ahaawIKkG5LfO+3muc0D+Vc/EQGEyXeoonf8C85ttBwlwjOgjaj7dh0cWs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ajsAjMzq; arc=none smtp.client-ip=91.218.175.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ajsAjMzq" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1767865086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=STlfevbMbQor4NiPveZvT1ORT1Sj+wqlqeXBGtUeNNA=; b=ajsAjMzqb3m3ALRiJpDvlBKs3dSaSw+Khp0M/8Xu7MtwgO2Gqj+YhNQNZkgkiNM4Km8+3Y ogYDsxtSoRnJ1gLcHt8D7Dr9gNlpEc167/KW8vMjmjveEMAuDJ9caS04N7mdwcnclRoGqH 99cZvG70LtmPaZb4StlJgNNxwUBBleE= From: Matthew Schwartz To: Shenghao Ding , Baojun Xu , tiwai@suse.de Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Antheas Kapenekakis , Matthew Schwartz , stable@vger.kernel.org Subject: [PATCH v2] ALSA: hda/tas2781: Skip UEFI calibration on ASUS ROG Xbox Ally X Date: Thu, 8 Jan 2026 01:36:50 -0800 Message-ID: <20260108093650.1142176-1-matthew.schwartz@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" There is currently an issue with UEFI calibration data parsing for some TAS devices, like the ASUS ROG Xbox Ally X (RC73XA), that causes audio quality issues such as gaps in playback. Until the issue is root caused and fixed, add a quirk to skip using the UEFI calibration data and fall back to using the calibration data provided by the DSP firmware, which restores full speaker functionality on affected devices. Cc: stable@vger.kernel.org # 6.18 Link: https://lore.kernel.org/all/160aef32646c4d5498cbfd624fd683cc@ti.com/ Closes: https://lore.kernel.org/all/0ba100d0-9b6f-4a3b-bffa-61abe1b46cd5@li= nux.dev/ Suggested-by: Baojun Xu Signed-off-by: Matthew Schwartz --- v1->v2: drop wrong Fixes tag, amend commit to clarify suspected root cause and workaround being used. --- sound/hda/codecs/side-codecs/tas2781_hda_i2c.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c b/sound/hda/cod= ecs/side-codecs/tas2781_hda_i2c.c index c8619995b1d7..ec3761050cab 100644 --- a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c +++ b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c @@ -60,6 +60,7 @@ struct tas2781_hda_i2c_priv { int (*save_calibration)(struct tas2781_hda *h); =20 int hda_chip_id; + bool skip_calibration; }; =20 static int tas2781_get_i2c_res(struct acpi_resource *ares, void *data) @@ -489,7 +490,8 @@ static void tasdevice_dspfw_init(void *context) /* If calibrated data occurs error, dsp will still works with default * calibrated data inside algo. */ - hda_priv->save_calibration(tas_hda); + if (!hda_priv->skip_calibration) + hda_priv->save_calibration(tas_hda); } =20 static void tasdev_fw_ready(const struct firmware *fmw, void *context) @@ -546,6 +548,7 @@ static int tas2781_hda_bind(struct device *dev, struct = device *master, void *master_data) { struct tas2781_hda *tas_hda =3D dev_get_drvdata(dev); + struct tas2781_hda_i2c_priv *hda_priv =3D tas_hda->hda_priv; struct hda_component_parent *parent =3D master_data; struct hda_component *comp; struct hda_codec *codec; @@ -571,6 +574,14 @@ static int tas2781_hda_bind(struct device *dev, struct= device *master, break; } =20 + /* + * Using ASUS ROG Xbox Ally X (RC73XA) UEFI calibration data + * causes audio dropouts during playback, use fallback data + * from DSP firmware as a workaround. + */ + if (codec->core.subsystem_id =3D=3D 0x10431384) + hda_priv->skip_calibration =3D true; + pm_runtime_get_sync(dev); =20 comp->dev =3D dev; --=20 2.52.0