From nobody Sun Feb 8 14:52:47 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B55E42E019 for ; Thu, 8 Jan 2026 09:36:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767864995; cv=none; b=q/wrEfEkD96bIisiWGImy9A3kLWDKEmCK3RXKPj3MJ6Ve6ulA211DodPIaRUT6ThzfkfZ6N0RWmfBIAxg4AzCyBPcOth/GdCYVbQMkZQoCXbYHal3KMEaJUOx+SJm1s3t1O0Ksr5pK3/ar3qHDLXBzq3yuzLA0n1FC1wTXBejQY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767864995; c=relaxed/simple; bh=z5vkkbGDVR6r6tL312e5eblDlnh/A3XrI22sJyNt0bE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HAHlAU2nifAp+4sbkfUTUWtcaCHR9sv47YrLrTHkYYbLah3c0cgHbinTue6xa+tPAVxV8SoYNzSKQKNtQS7m6Gt1PqymIlz+I9zPxUjk1TV7rTsmjJI6oORAXBMs7N/vttCmrrybs1UaMycTQcaxyoLmfaZsfOOK4fgcRlGPDhk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZBM4+8Qs; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZBM4+8Qs" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a0c20ee83dso29157375ad.2 for ; Thu, 08 Jan 2026 01:36:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767864983; x=1768469783; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=miqdi3JWBKoxNnDoIDRRY9WTssFbqfALy728r5SCWyA=; b=ZBM4+8Qs1lwBkzYtf/BgkSLN3ebPtIVWZQdIXILLD7Sr7sR40kVTC6tj0Dsy+bVi7k t8bUHMkaCMDg1RsOgxVdXV7voDZzYPnsEE8U/0xbvUZBg6Uu7fWaUdiPLjaIcjpKeVB6 OssJ7ef5JC32D8jXHMwGT/nVdqVQA8quUi7q4PO0SlRfH/aSxNAT86Lf4WDupnRl9ydY 7oI9SKjKUBNSI3tBY2Lddi7W2hpBVXCZr7DDbit8B2V4I2v23Y1sH4y0VUtemVGtmJtq dds64sjLqN5NTvzDDwazMpt+SUIHHSrhRhvfQtprn0fOp4uCK0ZNad9+1xgDRICv922f KNZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767864983; x=1768469783; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=miqdi3JWBKoxNnDoIDRRY9WTssFbqfALy728r5SCWyA=; b=vXb8/6ceKISayhQuqOmvP9g9ZxBzigq6QZNSD5pXFi6F07gtNF08s0hDk9+oV0+tBp sfwxP/0uXEHekfQlYQro2y4F7MFrKv4UDh8/CSqXi/ijhkezZ2+sIw2klst+4Zrq+xC5 dYbyA9fay0fgXs3prB+FKd0gux8SL4EUxdRVo33mpnrdURCgh/H+tY0plWhNE0y2PE6M h9dhAh+P2+FhWFqI7WEYXsYhuP9o/rw2DWfr9M9CG8PpMO5hobxgARxIyAPkaN3QXDSR L3kVCzdsOMDhssGsLMSgtKCeWD2MFLsy2Mr+cUFgecPbzghFOnAVPnpe+btW6JcAoj4U TrEQ== X-Forwarded-Encrypted: i=1; AJvYcCW3sk7i/A82yB2FNfCP3BkY+T+FWXOaaZGncGQnm3VMwY4joEK0BNTiRi30wuQ+RpDctpc1tG50NmxWoSQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyTnmKUk+XV+7SggUKKnZsMde3HQzxpiiUMEvypagsf1MpCCDiR 0Xo1QiP64wYor163XfcJyS5JC2+mKDc0CYDSKSxnvI4LBIGtVI1JuQRd X-Gm-Gg: AY/fxX7pJGBKjLiSOqkf3T1oSUv7/hypIfpCuWqNHd1X9Vhv9wrfiU5qJKlQzQpb4BT FYwqQqB/cUtHX5fohRNN/Ydcy+fLM36I5Iqr+1D/xwTWU5YrLRB+C4CIJ/WhjnCqoCeDawancDG sOjub1OVg0BNMRlI2cl4EJYrTFQcWCKPPV+bICsNKUriFymZt2C5sX4CbZJanFu1QKGGTS55uTe iZ0CM2dt6oNt9RuyAXhdha9MCp1wnd6kioWBuT9v8H+GCZ3dt3lHhMda1t96zLaLRWaL7dVgk9X VHL0N6AoiAduHbbMD+I0/+EFBYUeai51HSCC7ucKLejTzQIl5JGfs1VcIOvBb88kPkKejxTt24b ygM3ALhPC0z+FbGtIkZJLNWp8wczymm05lXkowz4YjiTJsFbN9WOGXwblHaeN4eQENzCSZ+Wqsh Y3pdjJyOYHHZ+qfq4nRNGBJa8= X-Google-Smtp-Source: AGHT+IHSReaBoY0payJlLNXxYuXOcysW/4kuuotsiPj+TOOyIlWaCgj/F8BpW7CjLFi/EpDUUEbMPg== X-Received: by 2002:a17:903:1b4c:b0:2a1:3cd9:a734 with SMTP id d9443c01a7336-2a3ee49cfc7mr47710045ad.43.1767864982383; Thu, 08 Jan 2026 01:36:22 -0800 (PST) Received: from NV-J4GCB44.nvidia.com ([103.74.125.162]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3f3115682sm37460985ad.55.2026.01.08.01.36.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 01:36:21 -0800 (PST) From: Jianyue Wu X-Google-Original-From: Jianyue Wu To: jianyuew@nvidia.com, hannes@cmpxchg.org Cc: Jianyue Wu , mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: optimize stat output for 11% sys time reduce Date: Thu, 8 Jan 2026 17:36:02 +0800 Message-ID: <20260108093610.212023-1-jianyuew@nvidia.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jianyue Wu Replace seq_printf/seq_buf_printf with lightweight helpers to avoid printf parsing in memcg stats output. Key changes: - Add memcg_seq_put_name_val() for seq_file "name value\n" formatting - Add memcg_seq_buf_put_name_val() for seq_buf "name value\n" formatting - Update __memory_events_show(), swap_events_show(), memory_stat_format(), memory_numa_stat_show(), and related helpers Performance: - 1M reads of memory.stat+memory.numa_stat - Before: real 0m9.663s, user 0m4.840s, sys 0m4.823s - After: real 0m9.051s, user 0m4.775s, sys 0m4.275s (~11.4% sys drop) Tests: - Script: for ((i=3D1; i<=3D1000000; i++)); do : > /dev/null < /sys/fs/cgroup/memory.stat : > /dev/null < /sys/fs/cgroup/memory.numa_stat done Signed-off-by: Jianyue Wu Signed-off-by: Jianyue Wu --- mm/memcontrol-v1.c | 97 ++++++++++++++++++++++++++-------------------- mm/memcontrol-v1.h | 34 ++++++++++++++++ mm/memcontrol.c | 87 ++++++++++++++++++++++------------------- 3 files changed, 137 insertions(+), 81 deletions(-) diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c index 6eed14bff742..400feb798aec 100644 --- a/mm/memcontrol-v1.c +++ b/mm/memcontrol-v1.c @@ -10,7 +10,7 @@ #include #include #include -#include +#include =20 #include "internal.h" #include "swap.h" @@ -1795,25 +1795,33 @@ static int memcg_numa_stat_show(struct seq_file *m,= void *v) mem_cgroup_flush_stats(memcg); =20 for (stat =3D stats; stat < stats + ARRAY_SIZE(stats); stat++) { - seq_printf(m, "%s=3D%lu", stat->name, - mem_cgroup_nr_lru_pages(memcg, stat->lru_mask, - false)); - for_each_node_state(nid, N_MEMORY) - seq_printf(m, " N%d=3D%lu", nid, - mem_cgroup_node_nr_lru_pages(memcg, nid, - stat->lru_mask, false)); + seq_puts(m, stat->name); + seq_put_decimal_ull(m, "=3D", + (u64)mem_cgroup_nr_lru_pages(memcg, stat->lru_mask, + false)); + for_each_node_state(nid, N_MEMORY) { + seq_put_decimal_ull(m, " N", nid); + seq_put_decimal_ull(m, "=3D", + (u64)mem_cgroup_node_nr_lru_pages(memcg, nid, + stat->lru_mask, false)); + } seq_putc(m, '\n'); } =20 for (stat =3D stats; stat < stats + ARRAY_SIZE(stats); stat++) { =20 - seq_printf(m, "hierarchical_%s=3D%lu", stat->name, - mem_cgroup_nr_lru_pages(memcg, stat->lru_mask, - true)); - for_each_node_state(nid, N_MEMORY) - seq_printf(m, " N%d=3D%lu", nid, - mem_cgroup_node_nr_lru_pages(memcg, nid, - stat->lru_mask, true)); + seq_puts(m, "hierarchical_"); + seq_puts(m, stat->name); + seq_put_decimal_ull(m, "=3D", + (u64)mem_cgroup_nr_lru_pages(memcg, stat->lru_mask, + true)); + for_each_node_state(nid, N_MEMORY) { + seq_put_decimal_ull(m, " N", nid); + seq_put_decimal_ull(m, "=3D", + (u64)mem_cgroup_node_nr_lru_pages(memcg, nid, + stat->lru_mask, + true)); + } seq_putc(m, '\n'); } =20 @@ -1879,17 +1887,17 @@ void memcg1_stat_format(struct mem_cgroup *memcg, s= truct seq_buf *s) unsigned long nr; =20 nr =3D memcg_page_state_local_output(memcg, memcg1_stats[i]); - seq_buf_printf(s, "%s %lu\n", memcg1_stat_names[i], nr); + memcg_seq_buf_put_name_val(s, memcg1_stat_names[i], (u64)nr); } =20 for (i =3D 0; i < ARRAY_SIZE(memcg1_events); i++) - seq_buf_printf(s, "%s %lu\n", vm_event_name(memcg1_events[i]), - memcg_events_local(memcg, memcg1_events[i])); + memcg_seq_buf_put_name_val(s, vm_event_name(memcg1_events[i]), + (u64)memcg_events_local(memcg, memcg1_events[i])); =20 for (i =3D 0; i < NR_LRU_LISTS; i++) - seq_buf_printf(s, "%s %lu\n", lru_list_name(i), - memcg_page_state_local(memcg, NR_LRU_BASE + i) * - PAGE_SIZE); + memcg_seq_buf_put_name_val(s, lru_list_name(i), + memcg_page_state_local(memcg, NR_LRU_BASE + i) * + PAGE_SIZE); =20 /* Hierarchical information */ memory =3D memsw =3D PAGE_COUNTER_MAX; @@ -1897,28 +1905,33 @@ void memcg1_stat_format(struct mem_cgroup *memcg, s= truct seq_buf *s) memory =3D min(memory, READ_ONCE(mi->memory.max)); memsw =3D min(memsw, READ_ONCE(mi->memsw.max)); } - seq_buf_printf(s, "hierarchical_memory_limit %llu\n", - (u64)memory * PAGE_SIZE); - seq_buf_printf(s, "hierarchical_memsw_limit %llu\n", - (u64)memsw * PAGE_SIZE); + memcg_seq_buf_put_name_val(s, "hierarchical_memory_limit", + (u64)memory * PAGE_SIZE); + memcg_seq_buf_put_name_val(s, "hierarchical_memsw_limit", + (u64)memsw * PAGE_SIZE); =20 for (i =3D 0; i < ARRAY_SIZE(memcg1_stats); i++) { unsigned long nr; =20 - nr =3D memcg_page_state_output(memcg, memcg1_stats[i]); - seq_buf_printf(s, "total_%s %llu\n", memcg1_stat_names[i], - (u64)nr); + nr =3D memcg_page_state_output(memcg, memcg1_stats[i]); + seq_buf_puts(s, "total_"); + memcg_seq_buf_put_name_val(s, memcg1_stat_names[i], + (u64)nr); } =20 - for (i =3D 0; i < ARRAY_SIZE(memcg1_events); i++) - seq_buf_printf(s, "total_%s %llu\n", - vm_event_name(memcg1_events[i]), - (u64)memcg_events(memcg, memcg1_events[i])); + for (i =3D 0; i < ARRAY_SIZE(memcg1_events); i++) { + seq_buf_puts(s, "total_"); + memcg_seq_buf_put_name_val(s, + vm_event_name(memcg1_events[i]), + (u64)memcg_events(memcg, memcg1_events[i])); + } =20 - for (i =3D 0; i < NR_LRU_LISTS; i++) - seq_buf_printf(s, "total_%s %llu\n", lru_list_name(i), - (u64)memcg_page_state(memcg, NR_LRU_BASE + i) * - PAGE_SIZE); + for (i =3D 0; i < NR_LRU_LISTS; i++) { + seq_buf_puts(s, "total_"); + memcg_seq_buf_put_name_val(s, lru_list_name(i), + (u64)memcg_page_state(memcg, NR_LRU_BASE + i) * + (PAGE_SIZE)); + } =20 #ifdef CONFIG_DEBUG_VM { @@ -1933,8 +1946,8 @@ void memcg1_stat_format(struct mem_cgroup *memcg, str= uct seq_buf *s) anon_cost +=3D mz->lruvec.anon_cost; file_cost +=3D mz->lruvec.file_cost; } - seq_buf_printf(s, "anon_cost %lu\n", anon_cost); - seq_buf_printf(s, "file_cost %lu\n", file_cost); + memcg_seq_buf_put_name_val(s, "anon_cost", (u64)anon_cost); + memcg_seq_buf_put_name_val(s, "file_cost", (u64)file_cost); } #endif } @@ -1969,10 +1982,10 @@ static int mem_cgroup_oom_control_read(struct seq_f= ile *sf, void *v) { struct mem_cgroup *memcg =3D mem_cgroup_from_seq(sf); =20 - seq_printf(sf, "oom_kill_disable %d\n", READ_ONCE(memcg->oom_kill_disable= )); - seq_printf(sf, "under_oom %d\n", (bool)memcg->under_oom); - seq_printf(sf, "oom_kill %lu\n", - atomic_long_read(&memcg->memory_events[MEMCG_OOM_KILL])); + memcg_seq_put_name_val(sf, "oom_kill_disable", READ_ONCE(memcg->oom_kill_= disable)); + memcg_seq_put_name_val(sf, "under_oom", (bool)memcg->under_oom); + memcg_seq_put_name_val(sf, "oom_kill", + (u64)atomic_long_read(&memcg->memory_events[MEMCG_OOM_KILL])); return 0; } =20 diff --git a/mm/memcontrol-v1.h b/mm/memcontrol-v1.h index 6358464bb416..a4ac2d869506 100644 --- a/mm/memcontrol-v1.h +++ b/mm/memcontrol-v1.h @@ -4,6 +4,9 @@ #define __MM_MEMCONTROL_V1_H =20 #include +#include +#include +#include =20 /* Cgroup v1 and v2 common declarations */ =20 @@ -33,6 +36,37 @@ int memory_stat_show(struct seq_file *m, void *v); void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n); struct mem_cgroup *mem_cgroup_id_get_online(struct mem_cgroup *memcg); =20 +/* Max 2^64 - 1 =3D 18446744073709551615 (20 digits) */ +#define MEMCG_DEC_U64_MAX_LEN 20 + +static inline void memcg_seq_put_name_val(struct seq_file *m, const char *= name, + u64 val) +{ + seq_puts(m, name); + /* need a space between name and value */ + seq_put_decimal_ull(m, " ", val); + seq_putc(m, '\n'); +} + +static inline void memcg_seq_buf_put_name_val(struct seq_buf *s, + const char *name, u64 val) +{ + char num_buf[MEMCG_DEC_U64_MAX_LEN]; + int num_len; + + num_len =3D num_to_str(num_buf, sizeof(num_buf), val, 0); + if (num_len <=3D 0) + return; + + if (seq_buf_puts(s, name)) + return; + if (seq_buf_putc(s, ' ')) + return; + if (seq_buf_putmem(s, num_buf, num_len)) + return; + seq_buf_putc(s, '\n'); +} + /* Cgroup v1-specific declarations */ #ifdef CONFIG_MEMCG_V1 =20 diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 86f43b7e5f71..62652a3c8681 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -42,6 +42,7 @@ #include #include #include +#include #include #include #include @@ -1485,26 +1486,26 @@ static void memcg_stat_format(struct mem_cgroup *me= mcg, struct seq_buf *s) continue; #endif size =3D memcg_page_state_output(memcg, memory_stats[i].idx); - seq_buf_printf(s, "%s %llu\n", memory_stats[i].name, size); + memcg_seq_buf_put_name_val(s, memory_stats[i].name, size); =20 if (unlikely(memory_stats[i].idx =3D=3D NR_SLAB_UNRECLAIMABLE_B)) { size +=3D memcg_page_state_output(memcg, NR_SLAB_RECLAIMABLE_B); - seq_buf_printf(s, "slab %llu\n", size); + memcg_seq_buf_put_name_val(s, "slab", size); } } =20 /* Accumulated memory events */ - seq_buf_printf(s, "pgscan %lu\n", - memcg_events(memcg, PGSCAN_KSWAPD) + - memcg_events(memcg, PGSCAN_DIRECT) + - memcg_events(memcg, PGSCAN_PROACTIVE) + - memcg_events(memcg, PGSCAN_KHUGEPAGED)); - seq_buf_printf(s, "pgsteal %lu\n", - memcg_events(memcg, PGSTEAL_KSWAPD) + - memcg_events(memcg, PGSTEAL_DIRECT) + - memcg_events(memcg, PGSTEAL_PROACTIVE) + - memcg_events(memcg, PGSTEAL_KHUGEPAGED)); + memcg_seq_buf_put_name_val(s, "pgscan", + memcg_events(memcg, PGSCAN_KSWAPD) + + memcg_events(memcg, PGSCAN_DIRECT) + + memcg_events(memcg, PGSCAN_PROACTIVE) + + memcg_events(memcg, PGSCAN_KHUGEPAGED)); + memcg_seq_buf_put_name_val(s, "pgsteal", + memcg_events(memcg, PGSTEAL_KSWAPD) + + memcg_events(memcg, PGSTEAL_DIRECT) + + memcg_events(memcg, PGSTEAL_PROACTIVE) + + memcg_events(memcg, PGSTEAL_KHUGEPAGED)); =20 for (i =3D 0; i < ARRAY_SIZE(memcg_vm_event_stat); i++) { #ifdef CONFIG_MEMCG_V1 @@ -1512,9 +1513,9 @@ static void memcg_stat_format(struct mem_cgroup *memc= g, struct seq_buf *s) memcg_vm_event_stat[i] =3D=3D PGPGOUT) continue; #endif - seq_buf_printf(s, "%s %lu\n", - vm_event_name(memcg_vm_event_stat[i]), - memcg_events(memcg, memcg_vm_event_stat[i])); + memcg_seq_buf_put_name_val(s, + vm_event_name(memcg_vm_event_stat[i]), + memcg_events(memcg, memcg_vm_event_stat[i])); } } =20 @@ -4218,10 +4219,12 @@ static void mem_cgroup_attach(struct cgroup_taskset= *tset) =20 static int seq_puts_memcg_tunable(struct seq_file *m, unsigned long value) { - if (value =3D=3D PAGE_COUNTER_MAX) + if (value =3D=3D PAGE_COUNTER_MAX) { seq_puts(m, "max\n"); - else - seq_printf(m, "%llu\n", (u64)value * PAGE_SIZE); + } else { + seq_put_decimal_ull(m, "", (u64)value * PAGE_SIZE); + seq_putc(m, '\n'); + } =20 return 0; } @@ -4247,7 +4250,8 @@ static int peak_show(struct seq_file *sf, void *v, st= ruct page_counter *pc) else peak =3D max(fd_peak, READ_ONCE(pc->local_watermark)); =20 - seq_printf(sf, "%llu\n", peak * PAGE_SIZE); + seq_put_decimal_ull(sf, "", peak * PAGE_SIZE); + seq_putc(sf, '\n'); return 0; } =20 @@ -4480,16 +4484,16 @@ static ssize_t memory_max_write(struct kernfs_open_= file *of, */ static void __memory_events_show(struct seq_file *m, atomic_long_t *events) { - seq_printf(m, "low %lu\n", atomic_long_read(&events[MEMCG_LOW])); - seq_printf(m, "high %lu\n", atomic_long_read(&events[MEMCG_HIGH])); - seq_printf(m, "max %lu\n", atomic_long_read(&events[MEMCG_MAX])); - seq_printf(m, "oom %lu\n", atomic_long_read(&events[MEMCG_OOM])); - seq_printf(m, "oom_kill %lu\n", - atomic_long_read(&events[MEMCG_OOM_KILL])); - seq_printf(m, "oom_group_kill %lu\n", - atomic_long_read(&events[MEMCG_OOM_GROUP_KILL])); - seq_printf(m, "sock_throttled %lu\n", - atomic_long_read(&events[MEMCG_SOCK_THROTTLED])); + memcg_seq_put_name_val(m, "low", atomic_long_read(&events[MEMCG_LOW])); + memcg_seq_put_name_val(m, "high", atomic_long_read(&events[MEMCG_HIGH])); + memcg_seq_put_name_val(m, "max", atomic_long_read(&events[MEMCG_MAX])); + memcg_seq_put_name_val(m, "oom", atomic_long_read(&events[MEMCG_OOM])); + memcg_seq_put_name_val(m, "oom_kill", + atomic_long_read(&events[MEMCG_OOM_KILL])); + memcg_seq_put_name_val(m, "oom_group_kill", + atomic_long_read(&events[MEMCG_OOM_GROUP_KILL])); + memcg_seq_put_name_val(m, "sock_throttled", + atomic_long_read(&events[MEMCG_SOCK_THROTTLED])); } =20 static int memory_events_show(struct seq_file *m, void *v) @@ -4544,7 +4548,7 @@ static int memory_numa_stat_show(struct seq_file *m, = void *v) if (memory_stats[i].idx >=3D NR_VM_NODE_STAT_ITEMS) continue; =20 - seq_printf(m, "%s", memory_stats[i].name); + seq_puts(m, memory_stats[i].name); for_each_node_state(nid, N_MEMORY) { u64 size; struct lruvec *lruvec; @@ -4552,7 +4556,10 @@ static int memory_numa_stat_show(struct seq_file *m,= void *v) lruvec =3D mem_cgroup_lruvec(memcg, NODE_DATA(nid)); size =3D lruvec_page_state_output(lruvec, memory_stats[i].idx); - seq_printf(m, " N%d=3D%llu", nid, size); + + seq_put_decimal_ull(m, " N", nid); + seq_putc(m, '=3D'); + seq_put_decimal_ull(m, "", size); } seq_putc(m, '\n'); } @@ -4565,7 +4572,8 @@ static int memory_oom_group_show(struct seq_file *m, = void *v) { struct mem_cgroup *memcg =3D mem_cgroup_from_seq(m); =20 - seq_printf(m, "%d\n", READ_ONCE(memcg->oom_group)); + seq_put_decimal_ll(m, "", READ_ONCE(memcg->oom_group)); + seq_putc(m, '\n'); =20 return 0; } @@ -5373,12 +5381,12 @@ static int swap_events_show(struct seq_file *m, voi= d *v) { struct mem_cgroup *memcg =3D mem_cgroup_from_seq(m); =20 - seq_printf(m, "high %lu\n", - atomic_long_read(&memcg->memory_events[MEMCG_SWAP_HIGH])); - seq_printf(m, "max %lu\n", - atomic_long_read(&memcg->memory_events[MEMCG_SWAP_MAX])); - seq_printf(m, "fail %lu\n", - atomic_long_read(&memcg->memory_events[MEMCG_SWAP_FAIL])); + memcg_seq_put_name_val(m, "high", + atomic_long_read(&memcg->memory_events[MEMCG_SWAP_HIGH])); + memcg_seq_put_name_val(m, "max", + atomic_long_read(&memcg->memory_events[MEMCG_SWAP_MAX])); + memcg_seq_put_name_val(m, "fail", + atomic_long_read(&memcg->memory_events[MEMCG_SWAP_FAIL])); =20 return 0; } @@ -5564,7 +5572,8 @@ static int zswap_writeback_show(struct seq_file *m, v= oid *v) { struct mem_cgroup *memcg =3D mem_cgroup_from_seq(m); =20 - seq_printf(m, "%d\n", READ_ONCE(memcg->zswap_writeback)); + seq_put_decimal_ll(m, "", READ_ONCE(memcg->zswap_writeback)); + seq_putc(m, '\n'); return 0; } =20 --=20 2.43.0