From nobody Sat Feb 7 10:44:45 2026 Received: from mail-qk1-f225.google.com (mail-qk1-f225.google.com [209.85.222.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0911342A828 for ; Thu, 8 Jan 2026 09:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767864020; cv=none; b=MmdiC1CIFfFzAVIs4wYL6T2gR2qio5uzLD0++A9X9dZVtA9jg5kWaTbRc4jiACox/wz7R+q12RGRoyMpgQUnjXR+e2CF3ZMVWIXNvs+oXPTONv1fFdv+inmPc+7qga7GEXXUqwJWsByMfpNFYz/clTJebPyrpBVvDU50mPmPCIY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767864020; c=relaxed/simple; bh=flmggBNU2hAB08i914C/deY3qRX3vSvGh6Sj4w2rzFg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rsy94ng/PlTepeRuykHFkjilDkVuQXLyjvXA1ihIZ1cfmqCXnuredAIQiTo/8GTsnj0ALx6450aUy8PrudL+L7DtXdTXHnyYRHlCVM8HGW3jnpjCiTQnzL3bUlQ9VboWVr6jQJiiszfZwEBysUpFB6qxzdXXGoi+08zuAQ22P+4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=Xz9NOVdi; arc=none smtp.client-ip=209.85.222.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="Xz9NOVdi" Received: by mail-qk1-f225.google.com with SMTP id af79cd13be357-8b6691baa33so46136485a.1 for ; Thu, 08 Jan 2026 01:20:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1767863997; x=1768468797; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MRGJRe3q+wC2wVKVj2Ep1iCX4dbPSkat0FX8kDkrXQw=; b=Xz9NOVdio8N5vlCIeelxt/+gpPfk4GskIpVNJI8ic8pEETiJyupVj9IT4vpWoe8Nim VrqcC01Yo9lc9Hn1lArx5LZ4Mt68i4aL4TqOD+mskl/fQ99Fc7YUINONG14NzHlwKaSM nxzI02XE6VDVgdg8wqU39NFNcCWzLkU+Xew7UAyvg2ftU3BElXuk0SAgJJ9djd7FPJsT Ac5o+mVU0pbpBvLbq173WZJQd9jR0VipcWnlntNLR3yTR8C3smt9oRbiJ2j6cEiMJ3DA rrnDHI50Y7K2opkrik0Tm/ttaanXU0Sk9UIqzu790N1aKC76pSBo74x+j5w3tzz/8WMC WHUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767863997; x=1768468797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MRGJRe3q+wC2wVKVj2Ep1iCX4dbPSkat0FX8kDkrXQw=; b=YU0Ry5FrmVkrvhpv/4JyzfOnVhHhS20S9psr2dvWm4g6oxb3vI+cm4DXambGlqdC4Y 63QW+FjtqhCBZC7IJAVEJzxdQfpDyEqZi0h0KCsqV8R88PfAflk+Tprr+6PIPOThSFCV jS/wLD4IhVtF9TigdsURhxlAO0vMiSQ8P8yZDRnk+y57Nr36MfxYQ4gU07UPGTY+VcT6 ukxRLfU2l+7GCml2bThLTAGTohe2S+qE3S6/Bfq54DH36HdhjqLShnqoyiwG4oeWOsrA 9XEf/HvMRWl06mz9g3ukIY5BhSK7aCYqcuhsczJjvK0eYT2mBa6kCE8mzXQuqyyB60+t wKfw== X-Forwarded-Encrypted: i=1; AJvYcCUB0E+CdwyaaYI4y15ipL4/NkW8b4FCc44k9ScPv5vwYXdebe2HzGNg7aiB+gx46sdkSpjbyzvIb2fHw90=@vger.kernel.org X-Gm-Message-State: AOJu0YyQOAuKx2DgBi7IAfajVl+V+KTC5g3oTQfXUYWcQKPbnOzfRnq5 ylTJIyXeRTzgV1gNm+kvH8GPEWvoHyEHSTZCheAwbTZV6eW4mKKs9PZlAIfMrv/SyvJo+cuSAtg I3OOsHqR1KqqpXe/vElfFuPjJHWGPGqH4InIuB5MzbooEeKbzpHzS X-Gm-Gg: AY/fxX7ZM7fptcT3ggOhHa89dt/FGwZiHpD0zv9Jwh9/PoXQbaldNV/xEoPi+0EtH4k JWKwqYeNXLz0DX6WVu+kkhyq8NuuQiRX+Dw0F6ukfn5t8Lf8cG8v0FrZ1O0fZwg3T+WsR4np9sd 3FikaS3QGAmNDimcatFvtiVtsEka9CPPZ+5UZl3BIiJkXhgBoBFtGY/6/Do8BoHkI+fVtHBtPjE xpDdt/iiR6EbwXjSvwBxra98NX4QbKARtqA/zRKzfJYAFvip0/sMFihBcOQ9aIz2D+psnrp4qEj fKAOEYaePuSG/DXeDRz391BA8GLoUaHri9X73UdrjPb+hVOjc25dIIbBK3KN7buZyt6hQSDQYp0 /gEE6dmq8dncH0BUNSV7+i5bXEkc= X-Google-Smtp-Source: AGHT+IFZEqHTD1jRd6BPZWZ92EgtYzPKA4eYdLHsiPbwryg/dB7+Hp2FHML2KxtaKefC9IyFoEQAGq0IYNyQ X-Received: by 2002:a05:6214:19c6:b0:890:6330:97b9 with SMTP id 6a1803df08f44-89084184f5dmr61349676d6.2.1767863997313; Thu, 08 Jan 2026 01:19:57 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-890770a55bcsm9018466d6.10.2026.01.08.01.19.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 01:19:57 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.6.120]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id C6236342243; Thu, 8 Jan 2026 02:19:55 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id C0460E42F2C; Thu, 8 Jan 2026 02:19:55 -0700 (MST) From: Caleb Sander Mateos To: Ming Lei , Jens Axboe , Shuah Khan Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Stanley Zhang , Uday Shankar , "Martin K . Petersen" , Caleb Sander Mateos Subject: [PATCH v4 05/19] ublk: split out ublk_copy_user_bvec() helper Date: Thu, 8 Jan 2026 02:19:33 -0700 Message-ID: <20260108091948.1099139-6-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260108091948.1099139-1-csander@purestorage.com> References: <20260108091948.1099139-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Factor a helper function ublk_copy_user_bvec() out of ublk_copy_user_pages(). It will be used for copying integrity data too. Signed-off-by: Caleb Sander Mateos Reviewed-by: Ming Lei --- drivers/block/ublk_drv.c | 52 +++++++++++++++++++++++----------------- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index 7310d8761d2b..22e82bbf50ce 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -1005,10 +1005,39 @@ static const struct block_device_operations ub_fops= =3D { .open =3D ublk_open, .free_disk =3D ublk_free_disk, .report_zones =3D ublk_report_zones, }; =20 +static bool ublk_copy_user_bvec(const struct bio_vec *bv, unsigned *offset, + struct iov_iter *uiter, int dir, size_t *done) +{ + unsigned len; + void *bv_buf; + size_t copied; + + if (*offset >=3D bv->bv_len) { + *offset -=3D bv->bv_len; + return true; + } + + len =3D bv->bv_len - *offset; + bv_buf =3D kmap_local_page(bv->bv_page) + bv->bv_offset + *offset; + if (dir =3D=3D ITER_DEST) + copied =3D copy_to_iter(bv_buf, len, uiter); + else + copied =3D copy_from_iter(bv_buf, len, uiter); + + kunmap_local(bv_buf); + + *done +=3D copied; + if (copied < len) + return false; + + *offset =3D 0; + return true; +} + /* * Copy data between request pages and io_iter, and 'offset' * is the start point of linear offset of request. */ static size_t ublk_copy_user_pages(const struct request *req, @@ -1017,33 +1046,12 @@ static size_t ublk_copy_user_pages(const struct req= uest *req, struct req_iterator iter; struct bio_vec bv; size_t done =3D 0; =20 rq_for_each_segment(bv, req, iter) { - unsigned len; - void *bv_buf; - size_t copied; - - if (offset >=3D bv.bv_len) { - offset -=3D bv.bv_len; - continue; - } - - len =3D bv.bv_len - offset; - bv_buf =3D kmap_local_page(bv.bv_page) + bv.bv_offset + offset; - if (dir =3D=3D ITER_DEST) - copied =3D copy_to_iter(bv_buf, len, uiter); - else - copied =3D copy_from_iter(bv_buf, len, uiter); - - kunmap_local(bv_buf); - - done +=3D copied; - if (copied < len) + if (!ublk_copy_user_bvec(&bv, &offset, uiter, dir, &done)) break; - - offset =3D 0; } return done; } =20 static inline bool ublk_need_map_req(const struct request *req) --=20 2.45.2