From nobody Sun Feb 8 15:58:35 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E12D3559D4 for ; Thu, 8 Jan 2026 07:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767858460; cv=none; b=CM5iJwRueJwpN2mX5RcbLjpzgXOV2QdmgpO7MdsGilrI03Z/FZWr0hyUpq6AMwnqQFRaGFCYt6lYEqykGsvraW/2XjfgwJ++mrxYrvg4ptadQH6lP0nDxt1U18JhoSGdq+uLcuPGuS0wt7V2EAM+Mk9b+8CmoZpTzNdexVMPUDM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767858460; c=relaxed/simple; bh=pjqGZESGTGoGprtHkjpWOSvXZMoYBeFwItuBJ4BskTY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=htERHXpros//+xMWR8gwskcalsAGN+5Vn7c5BrrVfofhXSTpKsH/UXm8FFXTBjgnxzALJRkOhn7dmmgCHyThfBBNSo8DynLHzuzWWFgrx5o8BnsgmRc7vahOv4wr//sHzkcyKdCagxDgrx5ND21xj8YgmS3V4HTqZ4bNGioKA5I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AuUfoxNv; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AuUfoxNv" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-34c565b888dso2539826a91.0 for ; Wed, 07 Jan 2026 23:46:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767858411; x=1768463211; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ds65/lrnQXHTKJWbSZYiXDQtY+u+BmtO58VCo2Iv+7Q=; b=AuUfoxNvJVTD2klVNyUj/iSgO9eOu8J3M/xQbzXVX2U1LBB2PHCeGsAsW2YxLqT9be qf9NItB/mEXwwQ9KIp1LyFyFLpeLCa4obkW8NxP8S66KGtfjBd7XP8sun6HH3Lzv9H6f wSBUOFDlAQNa6Z9tIJD21fSExwrSr04FQ8GmH1Za+SxKXPRMGxwqYTD//5FJI2BzJ8A7 slBQt2owjnUfrac0wVmgrCsUOgfcUR2RVDgLq8OSB5m2xQeIc3mYLuYhP/9DCN7ZoN2+ xwg7V0mZUUAt6+C7Hcv5n0BBb/pDPTLqoxTybrdk1nzd+S5Bn7CLcBx6FbpLB69LLXDP QA4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767858411; x=1768463211; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ds65/lrnQXHTKJWbSZYiXDQtY+u+BmtO58VCo2Iv+7Q=; b=chE20RxAvsTfSchUkHSw9Tl/YihYmJJhgQljEp/zwHQnyZWRIonvopl3IclltyCjAH uLfXNp9fS9JFI/SMzjOMbxEP59ljvlTF55cSzWEKt0SzrS2vSXwHQQaZ4T/1MOC85ZRm qQhLG/veS6pQclDtxZQPcMSUhDqvBzSka5skAZ6w7tkpk/jgc53XuJ2S9cRrZr4toKEk CXiMkb2x1xI9Ainb5HBcHtwJJM+gSh7wLiGcdQLU6I+6coWlkLZTLxnkNlpyRKaHSHIg vS7jy6I/3wHbuqFr4LgjCSNaLtZ1n9KwpEFr3M7klr6FpZMioJEOUlfrhKdV/CM5AjTF hQ1A== X-Gm-Message-State: AOJu0YwkDwhW/ndZMOeUgefvzVxPA0KgNmjaq/DH73p1+rg+Vaor9g/i lZi8NrwisIFBq2fFfPvGya92aH5xYLpin1C7wDwqboAl3Z20HZOjCmaoJsE6p/3XwvLH8dM= X-Gm-Gg: AY/fxX66nXJg/mEHZ2Fx/cloQKG9QZ3/Kb/SAJWS0+chy3d0El7Jmkk7A8fObfBPlXu 0cvq9CPfwOWetX+OBQAoKwp7i9d7kT8wLgelyWF+O95Hckab3PSBU6JNBoy/BMJYMYzSLsz3PrD 2MNpc4ArOgg90zkHKAi6ma/ES5aYGr0TjY5+p5zbPhRfeRQfs/gklr1u5Oyb/yaBNXbg1lgFOgH xooHtRXEp0Jm9vWj88iPlxCVbaz3yQXLQAaCqqCNvMQaWcGxp4ngTNTNgDd39MfayD2e2IWQ/Ji Pdn7G3AUctCaSoNqNj8BI8ReSb63NysWWnc4ATqZ5I8JOzsveHGoIAzRjZz4DNO/HvFY+ATZWjG 0gqDBVNGWxQDElLMWOTfj50Sx/WSyKrgDXzto+iY9Nlc8+OJePsUK7CAEnLDYIhEO/bG3pq1euv zyyqtEYmsAct9xV3HitLhRJJgYF+H+C7AITzZ9pLpYyNmD8z8BfFpFRlPuMtk2JkNgj6YNcfAx8 POxgiFb X-Google-Smtp-Source: AGHT+IGX6WAl+EhbKaH21mwVE7m1v3Z06z6E6Hr2/tR05hsuVSQ/Rzt3WnElJFHyqsaS1D1xmDOSHw== X-Received: by 2002:a17:90b:3b8f:b0:339:d1f0:c740 with SMTP id 98e67ed59e1d1-34f68b83b12mr4763043a91.1.1767858411103; Wed, 07 Jan 2026 23:46:51 -0800 (PST) Received: from DESKTOP-BKIPFGN (ec2-54-169-177-146.ap-southeast-1.compute.amazonaws.com. [54.169.177.146]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f5f7c4118sm6958880a91.7.2026.01.07.23.46.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 23:46:50 -0800 (PST) From: Kery Qi To: magnus.karlsson@intel.com Cc: linux-kernel@vger.kernel.org, Kery Qi Subject: [PATCH] xsk: fix init race causing NPD/UAF in xsk_create() Date: Thu, 8 Jan 2026 15:46:42 +0800 Message-ID: <20260108074643.1606-1-qikeyu2017@gmail.com> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" xsk_init() registers the PF_XDP socket family before xsk_net_ops. This exposes .create =3D xsk_create() to user space while per-netns state (net->xdp.lock/list) is still uninitialized. A task with CAP_NET_RAW can trigger this during boot/module load by calling socket(PF_XDP/AF_XDP, SOCK_RAW, 0) concurrently with xsk_init(), leading to NULL deref, list/lock corruption or use-after-free. Register the pernet subsystem (and prerequisites) first and only then sock_register() PF_XDP. Update the error unwind to match the new order. Similar to CVE-2024-26793 (GTP init ordering bug). Signed-off-by: Kery Qi --- net/xdp/xsk.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c index f093c3453f64..63b48e4b8b65 100644 --- a/net/xdp/xsk.c +++ b/net/xdp/xsk.c @@ -1922,10 +1922,6 @@ static int __init xsk_init(void) if (err) goto out; =20 - err =3D sock_register(&xsk_family_ops); - if (err) - goto out_proto; - err =3D register_pernet_subsys(&xsk_net_ops); if (err) goto out_sk; @@ -1942,16 +1938,20 @@ static int __init xsk_init(void) goto out_unreg_notif; } =20 + err =3D sock_register(&xsk_family_ops); + if (err) + goto out_proto; + return 0; =20 out_unreg_notif: unregister_netdevice_notifier(&xsk_netdev_notifier); out_pernet: unregister_pernet_subsys(&xsk_net_ops); -out_sk: - sock_unregister(PF_XDP); out_proto: proto_unregister(&xsk_proto); +out_sk: + sock_unregister(PF_XDP); out: return err; } --=20 2.34.1