From nobody Mon Feb 9 12:24:55 2026 Received: from mail-oi1-f227.google.com (mail-oi1-f227.google.com [209.85.167.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A4F6320383 for ; Thu, 8 Jan 2026 06:43:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767854616; cv=none; b=p0JHpl8xA+mSexLKu7OMN5mMhl6p5aa6pfURFxLbFZMQptYxWTNzAR5w6kcEjarv4Fno/h81pUYEtWAJHthIE2LJmtd7GeK7eCI4L/W/g64fEFV9ZhAsJQQK91pwrA3CE+H5+dwuDFNmRAaSC9hNI9HDHgfSbS37XE+UUUmgd50= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767854616; c=relaxed/simple; bh=5mic/q6vuxQbS8YXyfZUjqQArn9vFbNhUdp2DnF4O0M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iCUuBMlq5FKwx9IcUuBqbMdOUrxa/b9aXwdmf3T5FhMoI/5t3gYPtj0cCiFP8lSZBmfQrbf8gmMP3JYUE9ebOxV+AYeCe6bnv/av0RBZp6KVcINdczhJo4O6R8JwWgJlN6nf62mjdzDJx1D6JdqPhoCxvPD222riS2io1uYSaXQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=X/qFFU1e; arc=none smtp.client-ip=209.85.167.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="X/qFFU1e" Received: by mail-oi1-f227.google.com with SMTP id 5614622812f47-459a516592eso1852116b6e.1 for ; Wed, 07 Jan 2026 22:43:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767854609; x=1768459409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RXr5VPevjUOPqn3fRQwqWW7ZEAc2kKpuQcOkyGsfGno=; b=He23iY4HPYwYCVGH05VKOsltzd927PskipVtFO8qy1F0L+KMqKmsUK/RcBOQvQBZ6Q +zQ2vPT/YUATUduLb10kd+oKGRiNoApO3FtI9XzfHDo4I1QMzB+kQrLPzj6MS3xW+cC+ tnFzuXSYmz9QGNfYC84UJZhvtx5II30mxAuf76ndRioElvyQSGWPcQ+5+oO31cbVnAkg NXMoZOaaC+wB3IKBUPrjkyLNoUjxgF6QR9YthiGIp0643qJKExRzHTtBu9QA1Sn41Tkr 2qfCurxk6t3/S7Sh80BDTzn0BiaXKIjl20MhFxIYWIniTi/EwCw1XZLHEGcjbJsRFDZz sXxQ== X-Forwarded-Encrypted: i=1; AJvYcCVqixJeVgietcDct9RgWkRBJi3mn49OwJd9GHrNj9grF58YiLDNiTiJG7twPSGxwtKqdqsW3CFxKfmbOXM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyul0+ffdXSRnhfwZ/3ekewMTNYPlIbSK/IdzohZ6JnM35H1xat jFrFt4MnkIJLrjad+OPh3J0/5DWRt/8Y5Ow9u+UzERXfjoU0lWKDzHMEMYcUcfuS7f3oIPU3rL8 XHlZnBAGVwiXsvZhopQBLDxjY4LAlu4Ph45esNL1pzMdRC6xF81afTQy+LUMALDOzW/WlWGTj4F eoP/Pyqnen7YTlrKt8m5hRjuW0ZZZIXxxycr/o2Hp0RQ5sfVDpuMyFeSUCugYqnoiZXxiF9oqOd aGKDwbksZLjuaMHNlHZNlBDsQ== X-Gm-Gg: AY/fxX7GOPNbMdKYXSbnFZzqHxNs79+zt3tt2ZuR1TMjTeaUshizidpYc5qi2u9D8o3 lN3jPYYbR8+UfwqJxs4btlsuffpLgoKZWELLgoMHZuge37r7pZs/BNxAFHs3DC05BobqNCOKpsM X1woRFrzvWbIzYGx9eBXJ5PYYDuNYDIafjbSFgQEeen5Xc+IE3RWtMx4BOuIhY2a+/8HdKgfgqY VoeMegQBsgwcPi+UBR1QuKf0O9RiKN1Zm71cWQEbftsET/poXX669l+tFwdsWvjyZ9Lqc1aoeko Z2OntpFoLFF2FbKzDbEp/0UkiA4XbEJda+bbENJXiEQ7YRPtqFVlk3qm4kl3wptHqWAIiU+yhNP 3Nb1Nf+BsQV0/pc0g7PqgBKkI6hAvALhNxt2rAWS4ikJveKmkdNcbzjWI7y28fB3gN1i2V+R+ft AVRptMULMmV4BZcsaoctm9J/8tiR+0s01d5RQ6ZANeEoCLtQ== X-Google-Smtp-Source: AGHT+IGVWdMl4uH/oX/VExHIF7nGitAXDgNYdP2pfkllZih0ymEyB8cGqHJIAVcFb3X4gEkdhkzlScpnnWid X-Received: by 2002:a05:6808:2445:b0:450:d1ba:151b with SMTP id 5614622812f47-45a6bd4c3f9mr2013425b6e.29.1767854609113; Wed, 07 Jan 2026 22:43:29 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-1.dlp.protect.broadcom.com. [144.49.247.1]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-3ffa50f6dc7sm822445fac.18.2026.01.07.22.43.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Jan 2026 22:43:29 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-122008d48e5so332615c88.1 for ; Wed, 07 Jan 2026 22:43:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1767854607; x=1768459407; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RXr5VPevjUOPqn3fRQwqWW7ZEAc2kKpuQcOkyGsfGno=; b=X/qFFU1epwDz+O9K6wN8ilUkSsPuGpAF0QNELYXjzcmCMmYJ0BeXEYZcbiN4Rj4YS0 c6jZoYmOVQEBFm0QMrgRlIlYn/C+RRHxMkqDcwX3lh0LaFEXJFhECxuJl7XhZweBKBU6 hMNRZGQG+QBXgNIKdLYl4hAvCiuFE08Uo7Wr0= X-Forwarded-Encrypted: i=1; AJvYcCUDxDrEwzjC4qkYsQovU6MXsLwaOEZcJwqfn8wM/VL2SDTlPIWHw6xFJXp7Ay0cOlorKj3C131rLEIaHQQ=@vger.kernel.org X-Received: by 2002:a05:7022:6889:b0:11b:9386:a38b with SMTP id a92af1059eb24-121f8b9cf51mr4645218c88.46.1767854607340; Wed, 07 Jan 2026 22:43:27 -0800 (PST) X-Received: by 2002:a05:7022:6889:b0:11b:9386:a38b with SMTP id a92af1059eb24-121f8b9cf51mr4645201c88.46.1767854606766; Wed, 07 Jan 2026 22:43:26 -0800 (PST) Received: from shivania.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-121f243421esm13193731c88.2.2026.01.07.22.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 22:43:26 -0800 (PST) From: Shivani Agarwal To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: lduncan@suse.com, cleech@redhat.com, michael.christie@oracle.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vamsi-krishna.brahmajosyula@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Shivani Agarwal Subject: [PATCH 1/2 v5.10] scsi: iscsi: Move pool freeing Date: Wed, 7 Jan 2026 22:22:21 -0800 Message-Id: <20260108062222.670715-2-shivani.agarwal@broadcom.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260108062222.670715-1-shivani.agarwal@broadcom.com> References: <20260108062222.670715-1-shivani.agarwal@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Mike Christie [ Upstream commit a1f3486b3b095ed2259d7a1fc021a8b6e72a5365 ] This doesn't fix any bugs, but it makes more sense to free the pool after we have removed the session. At that time we know nothing is touching any of the session fields, because all devices have been removed and scans are stopped. Link: https://lore.kernel.org/r/20210525181821.7617-19-michael.christie@ora= cle.com Reviewed-by: Lee Duncan Signed-off-by: Mike Christie Signed-off-by: Martin K. Petersen [Shivani: Modified to apply on 5.10.y] Signed-off-by: Shivani Agarwal --- drivers/scsi/libiscsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index bad5730bf7ab..59da5cc280a4 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -2902,10 +2902,9 @@ void iscsi_session_teardown(struct iscsi_cls_session= *cls_session) struct module *owner =3D cls_session->transport->owner; struct Scsi_Host *shost =3D session->host; =20 - iscsi_pool_free(&session->cmdpool); - iscsi_remove_session(cls_session); =20 + iscsi_pool_free(&session->cmdpool); kfree(session->password); kfree(session->password_in); kfree(session->username); --=20 2.43.7