From nobody Sun Feb 8 00:34:49 2026 Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 598902874FF for ; Thu, 8 Jan 2026 04:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.86 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767845493; cv=none; b=mFaeqvee0BLf1gEO5f6e/Me/5Ywh+v1RUpstCghctmts6jEfx947VVD95/7/M/VfZCHkuUFxeeM63jrLW75tozOcd45yfn1ZBzaTb3IxizaCPGzm5f/b6DG+hjdk28OuWbpjDHCUBRLEy8v6f/Gn+vZmpS5KOpx2aF60XbqP1pQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767845493; c=relaxed/simple; bh=7MJnK/vhBFc0F/YEOveXLLzvnwUl/A43fwWw8xjwrDE=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=RZhMALHkU3V99D3PJQJO+4VI9sbNEPvlAG9Gmy+wgesq2tKBo65gw6MXC2lqDPM2qNe04YbwUC3OfdPyqzWAjrUjrkW3aRCH3sBCo3xC+hRtA5zDRkzB5B2gT3HAnHRlMBkyLPZQc+PbeDOf3uyeQLOQvb5m1RqWLfP4oGIdVZM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=yACcWxr7; arc=none smtp.client-ip=91.207.212.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="yACcWxr7" Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6084B5a82834324; Thu, 8 Jan 2026 04:11:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=dk201812; bh=XNBM+2BM64axn3wd5Y05TDD ja4vEtb8RxR+cfIqA3sI=; b=yACcWxr766j2gTOxjm6hO7uRQlumTLYuR8ZP79Q HmuYEoty4qlxQ/F7xwTdd2cb5drzSE9hAspxJXkb0E8CAZgfflR8DjOwqyqrodj1 /C0JQnXNbvaUTOT6PTGl9jASdzX2yrl7fjoZbJmTVwvHUQWcXJfTSnBXxtdfbKfB MhsLnqcab01eucunA1FkoOSRwM6VFNzYZmiMRb01kDx74+PA7cWBr51+StAW/uOU G3prbWEGHV5B06bfO6FDhUUR5HFNWH+5dHf2VYEaDwbI52cutLT9HTDkrzsbMH70 75OZEPXj8Wx/zVYYZgah99cpXyDIaAZDSbUxzPgyT95hsJA== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 4bet8sav9p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Jan 2026 04:11:05 +0000 (GMT) Received: from NP-G-BRAJESH.pu.imgtec.org (172.25.128.95) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 8 Jan 2026 04:11:01 +0000 From: Brajesh Gupta To: , , , , , , , , CC: , Subject: [PATCH] drm/imagination: Wait for FW trace update command completion Date: Thu, 8 Jan 2026 04:09:36 +0000 Message-ID: <20260108040936.129769-1-brajesh.gupta@imgtec.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA4MDAyNCBTYWx0ZWRfX0+Z5vitpi1PS CdA6QGEI7Yp+JFttvRjeop6HyOZ/vUis+tuIkpWJnTnvdNYIh60hzglrcrAQsCH69lxKqO/nEBZ /tp5zQYmOntPpijRhXI4Vc26gXBvwDgXiSq+gOT2jmvdBknp7Kbu8Ovv/wOpUG2MUG6OHn58/Gh f13y55VysAeP/Mm1I4Eqy6PefB0Qq5M1tToU2ShP5SscQeoAVkPK+Ax+WfXDKiZQCau++RgjGni CZEzG8lxhW5IkAS/O7ZtqpMZaMcentKAn09NN4WmHPtSMKxlBp0G3XFg4YYL9Un7MCNquIVhsPT PCc4/MShQoY9tqKOoKq0pfvVTLjI1LpigCEzWnpxDm7uFq1uhi5c2r1e2vMshFHyMmpTBrIsFDP 8y+3EkVySbHbn0YSVaO0L9ro5kSaCXVN3rvvQom9fHDOgE0Ouk88ox6G/6se6Opo6vzNxJE2xL5 k+ZVNnq2hMEyvgCVf+g== X-Proofpoint-ORIG-GUID: 4oWDftSg7GuQBk7bNMBs8AzoBXqiDn_3 X-Authority-Analysis: v=2.4 cv=LPFrgZW9 c=1 sm=1 tr=0 ts=695f2e59 cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=pAaLEEKUjL4A:10 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=r_1tXGB3AAAA:8 a=3oOJLAxtiLN628aBsBcA:9 a=t8nPyN_e6usw4ciXM-Pk:22 X-Proofpoint-GUID: 4oWDftSg7GuQBk7bNMBs8AzoBXqiDn_3 Content-Type: text/plain; charset="utf-8" Possibility of no FW trace available after update in the fw_trace_mask due to asynchronous mode of command consumption in the FW. To ensure FW trace is available after update, wait for FW trace log update command completion from the FW. Fixes: cc1aeedb98ad ("drm/imagination: Implement firmware infrastructure an= d META FW support") Signed-off-by: Brajesh Gupta Reviewed-by: Matt Coster --- drivers/gpu/drm/imagination/pvr_fw_trace.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c b/drivers/gpu/drm/i= magination/pvr_fw_trace.c index 8a56952f6730..99d681413eff 100644 --- a/drivers/gpu/drm/imagination/pvr_fw_trace.c +++ b/drivers/gpu/drm/imagination/pvr_fw_trace.c @@ -137,6 +137,7 @@ update_logtype(struct pvr_device *pvr_dev, u32 group_ma= sk) struct rogue_fwif_kccb_cmd cmd; int idx; int err; + int slot; =20 if (group_mask) fw_trace->tracebuf_ctrl->log_type =3D ROGUE_FWIF_LOG_TYPE_TRACE | group_= mask; @@ -154,8 +155,13 @@ update_logtype(struct pvr_device *pvr_dev, u32 group_m= ask) cmd.cmd_type =3D ROGUE_FWIF_KCCB_CMD_LOGTYPE_UPDATE; cmd.kccb_flags =3D 0; =20 - err =3D pvr_kccb_send_cmd(pvr_dev, &cmd, NULL); + err =3D pvr_kccb_send_cmd(pvr_dev, &cmd, &slot); + if (err) + goto err_drm_dev_exit; + + err =3D pvr_kccb_wait_for_completion(pvr_dev, slot, HZ, NULL); =20 +err_drm_dev_exit: drm_dev_exit(idx); =20 err_up_read: --=20 2.43.0