From nobody Sun Feb 8 23:04:14 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E79D285C80 for ; Thu, 8 Jan 2026 03:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767842246; cv=none; b=qeot4MufhlVcEwLd/J0m+ELeALRWwu57rItDrFNzpoy3ZfUuoveJaTMOhRGwqU7b7qBBqLb6HDcjBuJxDvIV0QQ3LPbb8m6gfabI1yUIHPNeMLzN6hXanynAy+DFUsxaPFQVWXHgUWXuYm20OO7/moTw7B2iLcmoA//mX/lpwKU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767842246; c=relaxed/simple; bh=HSH2cDhcqa8hihNqzM0cmWjWRa6J9Mh9nklD8GnTVc8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=k7dZWxzO2N8vqO6sCqG/1KiQFlENXsMmKz/ljCEa3wH2wf2g1qygAFaWV/zM8WkLJ8h2PNiXsqVIQCHvLiHv7kjR4zMDKFSgK6+h9ky2pYAa7RJlqUqQTJ1S29qOAXti8v6lRQjg5Jat04LQS7YRXIzjy20pVXSnjFZV43kS2rE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lhFRc36Y; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lhFRc36Y" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a099233e8dso21193165ad.3 for ; Wed, 07 Jan 2026 19:17:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767842244; x=1768447044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CdiOPkebuRw2iRYJsvN/KjHUwH4DMOaF+wqFYzZkeeI=; b=lhFRc36YaOEhMJZpF06mTmuwayWrtFDDX6byf3UYkjBw3lEqrhU/BH7gRrSsJxe3qS 9AtTQWmXzV3EivzR8cvzQQ5iNXvScIuNOb56+r7UGWs7vq2578gvvkGZaFdV6rmRQP7J Id0xV3BO0+NBpOv/MNlGYGGmSqZwfnfkJWf5sq+uAPXnOAWJ/As0hkP8XalEyn/oue8e m5NXmK7CUum4P0aPxYUVVePEKLlam7hpLyLcT2tRiF160bTBF2Kzz1GBoeU74yHwlZTI ETSgzxZwertf1PW9+Dq7LdpdsxTKTzFJuqFLHhlLykYrE4CUQx9W98WUdfUaXumpCb3y O0Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767842244; x=1768447044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CdiOPkebuRw2iRYJsvN/KjHUwH4DMOaF+wqFYzZkeeI=; b=JwDr/VJ4NclQXpJlQrsjZdQ5gTkUs0T9tpd/kvqVkSFddofb4uY7vTwzZYQTc8S5Xw LwDZPeNz/3ZXHOvD3XWerSFlLrIb81u3WfenXqE4kND8+Avyl7bokTUwBv0WgN/EZsZJ VvChmBe7x1tNR3/8e7iaSbYF0IIf9FJ8ELslV8RBEbh9705mnAM10+5HHofXoDQByrLJ brQ/Jq7AbcIr/Dv7gZXDj+71dG13jTakwpFuqBJ7GfUIyvWiMupXLUP8q+CuwiYqUNjD AciyexypPrN25awnO9bILq9taICYD6PPPLS/YUk3J48p0/KBe8JzcUVwkSpA8EC3Ey3H FH6g== X-Forwarded-Encrypted: i=1; AJvYcCWpjgaysS/M2Rr7ezqAs2FDiWN2wOPYbH9pVoOLJ7CdE9RISc0PXSJiKRLKh7k5gHAAzMKVJjy0SJrSJAk=@vger.kernel.org X-Gm-Message-State: AOJu0YxUoVvGtTZQfIcRLAEBJgPeI/0ivK9PQ/49Lfw+E3sQuzJbm/j9 dw7vmLgTTSy5nSH7132IQdHQk153q+/YNNvIrSyZFcim4skcKeGZqKQJ X-Gm-Gg: AY/fxX6WPeh9bIsaZ1GuBA9od+AKJYZEWdQxZmwGSuv+sYVDhwi+c8+ipY4aHIgoALS XTfBAIqJkrZ/v9tjYm7Fc8xs7fJoCgXJBoiUkVMfrd60iAllDRKq5AJKs9lvn1V73WyPkKPR9H1 PvBGtq+PIemDwK+xOWgYfqlkPqKkC06XjTo7pG0doVroDm+L8ZEsrOpg6QyDnS3U3sVrW4Mgl3m 2JnhsWN3VnJsIBOL1Zir+1pTJLjXZmCoFBtO8v/ORAzBpYsjuB+e8wbXMXWsA+1d4U/9YlFnonJ vjibE5UcaEKBGFeNn/3B0CLvnzgEosaF6DljnDikyRs6VscaWAXjrFIe71YSvwd4fe5Pz4G5sZ5 eoNaqUQZ5COh4qb2AGGR07hiyTOFWVExhed7Ay6CswMLgiI2OwTrJahWKVtaHGsphfL/2G+SZti RvHCDnGIlFIVzPteqUXpeknI3DTd8= X-Google-Smtp-Source: AGHT+IFHwpnuvrFOHyCGVuhHu+rmSokA2SwaPRlM6b2SPtuMKwHghdpOZ5xiMR48M1E38yqC4qytXw== X-Received: by 2002:a17:903:228a:b0:2a0:9a07:f8be with SMTP id d9443c01a7336-2a3ee436040mr42072775ad.22.1767842244426; Wed, 07 Jan 2026 19:17:24 -0800 (PST) Received: from pengdl-pc.mioffice.cn ([43.224.245.249]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c5de655bsm6134860b3a.60.2026.01.07.19.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 19:17:23 -0800 (PST) From: Donglin Peng To: ast@kernel.org, andrii.nakryiko@gmail.com, eddyz87@gmail.com Cc: zhangxiaoqin@xiaomi.com, ihor.solodrai@linux.dev, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Donglin Peng , Alan Maguire Subject: [PATCH bpf-next v11 11/11] btf: Refactor the code by calling str_is_empty Date: Thu, 8 Jan 2026 11:16:45 +0800 Message-Id: <20260108031645.1350069-12-dolinux.peng@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260108031645.1350069-1-dolinux.peng@gmail.com> References: <20260108031645.1350069-1-dolinux.peng@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Donglin Peng Calling the str_is_empty function to clarify the code and no functional changes are introduced. Cc: Eduard Zingerman Cc: Alexei Starovoitov Cc: Andrii Nakryiko Cc: Alan Maguire Cc: Ihor Solodrai Cc: Xiaoqin Zhang Signed-off-by: Donglin Peng Acked-by: Eduard Zingerman --- tools/lib/bpf/btf.c | 34 +++++++++++++++++----------------- tools/lib/bpf/libbpf.c | 4 ++-- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c index 9e8911755a79..a10019338ca4 100644 --- a/tools/lib/bpf/btf.c +++ b/tools/lib/bpf/btf.c @@ -2128,7 +2128,7 @@ int btf__add_int(struct btf *btf, const char *name, s= ize_t byte_sz, int encoding int sz, name_off; =20 /* non-empty name */ - if (!name || !name[0]) + if (str_is_empty(name)) return libbpf_err(-EINVAL); /* byte_sz must be power of 2 */ if (!byte_sz || (byte_sz & (byte_sz - 1)) || byte_sz > 16) @@ -2176,7 +2176,7 @@ int btf__add_float(struct btf *btf, const char *name,= size_t byte_sz) int sz, name_off; =20 /* non-empty name */ - if (!name || !name[0]) + if (str_is_empty(name)) return libbpf_err(-EINVAL); =20 /* byte_sz must be one of the explicitly allowed values */ @@ -2231,7 +2231,7 @@ static int btf_add_ref_kind(struct btf *btf, int kind= , const char *name, int ref if (!t) return libbpf_err(-ENOMEM); =20 - if (name && name[0]) { + if (!str_is_empty(name)) { name_off =3D btf__add_str(btf, name); if (name_off < 0) return name_off; @@ -2308,7 +2308,7 @@ static int btf_add_composite(struct btf *btf, int kin= d, const char *name, __u32 if (!t) return libbpf_err(-ENOMEM); =20 - if (name && name[0]) { + if (!str_is_empty(name)) { name_off =3D btf__add_str(btf, name); if (name_off < 0) return name_off; @@ -2409,7 +2409,7 @@ int btf__add_field(struct btf *btf, const char *name,= int type_id, if (!m) return libbpf_err(-ENOMEM); =20 - if (name && name[0]) { + if (!str_is_empty(name)) { name_off =3D btf__add_str(btf, name); if (name_off < 0) return name_off; @@ -2447,7 +2447,7 @@ static int btf_add_enum_common(struct btf *btf, const= char *name, __u32 byte_sz, if (!t) return libbpf_err(-ENOMEM); =20 - if (name && name[0]) { + if (!str_is_empty(name)) { name_off =3D btf__add_str(btf, name); if (name_off < 0) return name_off; @@ -2505,7 +2505,7 @@ int btf__add_enum_value(struct btf *btf, const char *= name, __s64 value) return libbpf_err(-EINVAL); =20 /* non-empty name */ - if (!name || !name[0]) + if (str_is_empty(name)) return libbpf_err(-EINVAL); if (value < INT_MIN || value > UINT_MAX) return libbpf_err(-E2BIG); @@ -2582,7 +2582,7 @@ int btf__add_enum64_value(struct btf *btf, const char= *name, __u64 value) return libbpf_err(-EINVAL); =20 /* non-empty name */ - if (!name || !name[0]) + if (str_is_empty(name)) return libbpf_err(-EINVAL); =20 /* decompose and invalidate raw data */ @@ -2622,7 +2622,7 @@ int btf__add_enum64_value(struct btf *btf, const char= *name, __u64 value) */ int btf__add_fwd(struct btf *btf, const char *name, enum btf_fwd_kind fwd_= kind) { - if (!name || !name[0]) + if (str_is_empty(name)) return libbpf_err(-EINVAL); =20 switch (fwd_kind) { @@ -2658,7 +2658,7 @@ int btf__add_fwd(struct btf *btf, const char *name, e= num btf_fwd_kind fwd_kind) */ int btf__add_typedef(struct btf *btf, const char *name, int ref_type_id) { - if (!name || !name[0]) + if (str_is_empty(name)) return libbpf_err(-EINVAL); =20 return btf_add_ref_kind(btf, BTF_KIND_TYPEDEF, name, ref_type_id, 0); @@ -2710,7 +2710,7 @@ int btf__add_restrict(struct btf *btf, int ref_type_i= d) */ int btf__add_type_tag(struct btf *btf, const char *value, int ref_type_id) { - if (!value || !value[0]) + if (str_is_empty(value)) return libbpf_err(-EINVAL); =20 return btf_add_ref_kind(btf, BTF_KIND_TYPE_TAG, value, ref_type_id, 0); @@ -2727,7 +2727,7 @@ int btf__add_type_tag(struct btf *btf, const char *va= lue, int ref_type_id) */ int btf__add_type_attr(struct btf *btf, const char *value, int ref_type_id) { - if (!value || !value[0]) + if (str_is_empty(value)) return libbpf_err(-EINVAL); =20 return btf_add_ref_kind(btf, BTF_KIND_TYPE_TAG, value, ref_type_id, 1); @@ -2746,7 +2746,7 @@ int btf__add_func(struct btf *btf, const char *name, { int id; =20 - if (!name || !name[0]) + if (str_is_empty(name)) return libbpf_err(-EINVAL); if (linkage !=3D BTF_FUNC_STATIC && linkage !=3D BTF_FUNC_GLOBAL && linkage !=3D BTF_FUNC_EXTERN) @@ -2832,7 +2832,7 @@ int btf__add_func_param(struct btf *btf, const char *= name, int type_id) if (!p) return libbpf_err(-ENOMEM); =20 - if (name && name[0]) { + if (!str_is_empty(name)) { name_off =3D btf__add_str(btf, name); if (name_off < 0) return name_off; @@ -2867,7 +2867,7 @@ int btf__add_var(struct btf *btf, const char *name, i= nt linkage, int type_id) int sz, name_off; =20 /* non-empty name */ - if (!name || !name[0]) + if (str_is_empty(name)) return libbpf_err(-EINVAL); if (linkage !=3D BTF_VAR_STATIC && linkage !=3D BTF_VAR_GLOBAL_ALLOCATED = && linkage !=3D BTF_VAR_GLOBAL_EXTERN) @@ -2916,7 +2916,7 @@ int btf__add_datasec(struct btf *btf, const char *nam= e, __u32 byte_sz) int sz, name_off; =20 /* non-empty name */ - if (!name || !name[0]) + if (str_is_empty(name)) return libbpf_err(-EINVAL); =20 if (btf_ensure_modifiable(btf)) @@ -2993,7 +2993,7 @@ static int btf_add_decl_tag(struct btf *btf, const ch= ar *value, int ref_type_id, struct btf_type *t; int sz, value_off; =20 - if (!value || !value[0] || component_idx < -1) + if (str_is_empty(value) || component_idx < -1) return libbpf_err(-EINVAL); =20 if (validate_type_id(ref_type_id)) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 1a52d818a76c..96c6db972855 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c @@ -2904,7 +2904,7 @@ static int bpf_object__init_user_btf_map(struct bpf_o= bject *obj, var_extra =3D btf_var(var); map_name =3D btf__name_by_offset(obj->btf, var->name_off); =20 - if (map_name =3D=3D NULL || map_name[0] =3D=3D '\0') { + if (str_is_empty(map_name)) { pr_warn("map #%d: empty name.\n", var_idx); return -EINVAL; } @@ -4281,7 +4281,7 @@ static int bpf_object__collect_externs(struct bpf_obj= ect *obj) if (!sym_is_extern(sym)) continue; ext_name =3D elf_sym_str(obj, sym->st_name); - if (!ext_name || !ext_name[0]) + if (str_is_empty(ext_name)) continue; =20 ext =3D obj->externs; --=20 2.34.1