From nobody Mon Feb 9 08:56:17 2026 Received: from mail-yw1-f194.google.com (mail-yw1-f194.google.com [209.85.128.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87D5F26F471 for ; Thu, 8 Jan 2026 02:25:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767839130; cv=none; b=QHh8z1cdYjNIZJY5VbaCpq6MptZIP+X/DVzWmoQn9uwONNv3DGPFhAP6JLpDnbVsqYuU5vmHupVpn17+WgOBsqqRWS9mpp+VQ5dxR8r0k5W/GRRYLGdNf6wEK+TlJCOMQyuQOpRjb+UznTzMHBX6YZfkz2UbOYLBCSCS+JSwC8Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767839130; c=relaxed/simple; bh=VhBBi66SFeKXbV7OJrrw4WoyPdDGNe3BKHOh9sdreXY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KHzE/Cbsjvghsf8xiStEE3gZjGnBNPiJfcDgHtteyGAtfGTSOkoE3ERVHd6NF1FDznyP/+6BC+bCfzWryaxzDvhoGjMc+X7y4MXUc1fUH/3QnIobqEEB0QdcDydrT813pL5mFIt7TkVKPITsB+aFZzYndaNp35x6s2OBDzznNwo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EnXpZC+t; arc=none smtp.client-ip=209.85.128.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EnXpZC+t" Received: by mail-yw1-f194.google.com with SMTP id 00721157ae682-78fc520433aso30480617b3.1 for ; Wed, 07 Jan 2026 18:25:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767839127; x=1768443927; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rjkgpIcKhjQZAa0EelYk21O9foZl8TfKrOJc4gFivFo=; b=EnXpZC+tZWVJVIn6TyUS+mZD4Xyrsdah7+b/PL/ss/eaCKfyEu6HOnhT+K5mM5vf9C gdFjmSs5/y6GJiPwqp1RK1gSN8oYsYaH0RIHcQDZNexcR9bz93F3UXuGUWhqNnVPTZZN GAQapJeE8z7QmX3YHyvvxhzL+YeupiocPTav3KKvMmtpOznLdi2GFjq2kXEFATl6/eaE SjZ6xhY8D3+Q9YzX/DLmnJy272MX8cWoxqpIiQnXHdPLZnPVEg81ygk3Cn4VuDp6VUR8 0KJQOtEX969+POO9qIXckycUMFHk3JHy0OyyLc/P61Wum073pH0wv6DtsumYOCchEnUi KuMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767839127; x=1768443927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rjkgpIcKhjQZAa0EelYk21O9foZl8TfKrOJc4gFivFo=; b=X27NndOOKvjvznK9gvoVUIyX+FoVrDI93h51T5bAK4iCul2h23noidn2gntRwVqMq6 Ds2MwxstMtQP30aZqkbPcHKzKo/mmNCb1vwJOYhDiU0gJjjjKINJtKHXto5HIOw+bLp1 VvhgAVD2UPTwJdzyNnGjx2myHx1Lsknt44COLfZr6d7HuJBLSTeT8BLsJ9fHki4yLktY 3TvVe4OHNsFtplkijcf1hseoyFH1NuJNpJHrBPhQ7YMHRskmuyQ5Z5M9O7zF/wsNdxEU q0bq6k3CnvZ+CeuGhUxejWYiKsyFf8gRyjY4k//6cL8BJM1+b+kGCwiXqvPm0ys/PbDa L14w== X-Forwarded-Encrypted: i=1; AJvYcCU5m2j1S85+XV0YEKfhOCx+y9YNUbLJqYRQzYe2Jqm1VmC/cSk1eqNxqOnFf4y0LvzP94D00uwqlg8TC+0=@vger.kernel.org X-Gm-Message-State: AOJu0YxPaca0LgrbSpCYeizbTgMsM3gAeyyKGqieRrQA/Q/VKhCnyKip EajxnRlSq/ZE0uDUHQkxk3mFFzWdNFJN6Ik+cRr+XFJ56VqVUb7lw1ZB X-Gm-Gg: AY/fxX5CV/zGpuiWh+hoJFCHFXdMa3rV3euk4myUmu7KxjLfwFgSF6OYZ8HZLHfDkbC y6vjMZZm6tJlJL2RwBB3NUHLru+EA+JKmt4wcBCr8rewajsBygFH1JMXCGFd80euzCsKsLG3cRd k6gQJcoplHs7IdJPW3u393meWdLy92Tf9TPCE7pagYkaNKiH7a9tfUE7ZtaZkGTWkdSbkn0thqY qf2N8G+5Q4MZEN6jJHlkImq9NKctBQ8v0rf5z6CujxlE9xQkbKhZjpU0s/prkRTMh9EhRY8VG2k hZ+FtK8C9AFIVXPMIe4XDukg9dBUznCTDbiiHU6RHhFB/LeYebNYPTHNWVsRIB1Si8o6gBUv6MM 9PJKRB6v96F+5D4o7LzNZJeh//6CoX4HhNB6h0+/EN9zJ7jMQxT812ZkXuE4FFYebcVtH2IyIYa oKcQvK58Y= X-Google-Smtp-Source: AGHT+IF6oe+CNyD8YMJskeioT2pg3/Psy/o0qTkXNquKhbC5SDD6nywKNBGuaI6KxZg9JJ5rrEbQ8Q== X-Received: by 2002:a05:690c:64c4:b0:78d:6f35:bdb9 with SMTP id 00721157ae682-790b58250d6mr40899167b3.51.1767839127164; Wed, 07 Jan 2026 18:25:27 -0800 (PST) Received: from 7940hx ([23.94.188.235]) by smtp.gmail.com with ESMTPSA id 00721157ae682-790aa57deacsm24855027b3.20.2026.01.07.18.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 18:25:26 -0800 (PST) From: Menglong Dong X-Google-Original-From: Menglong Dong To: ast@kernel.org, andrii@kernel.org Cc: daniel@iogearbox.net, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, davem@davemloft.net, dsahern@kernel.org, tglx@linutronix.de, mingo@redhat.com, jiang.biao@linux.dev, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next v8 02/11] bpf: use last 8-bits for the nr_args in trampoline Date: Thu, 8 Jan 2026 10:24:41 +0800 Message-ID: <20260108022450.88086-3-dongml2@chinatelecom.cn> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260108022450.88086-1-dongml2@chinatelecom.cn> References: <20260108022450.88086-1-dongml2@chinatelecom.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For now, ctx[-1] is used to store the nr_args in the trampoline. However, 1-byte is enough to store such information. Therefore, we use only the last byte of ctx[-1] to store the nr_args, and reserve the rest for other usages. Signed-off-by: Menglong Dong --- v8: - fix the missed get_func_arg_cnt --- kernel/bpf/verifier.c | 35 +++++++++++++++++++---------------- kernel/trace/bpf_trace.c | 6 +++--- 2 files changed, 22 insertions(+), 19 deletions(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 774c9b0aafa3..bfff3f84fd91 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -23277,15 +23277,16 @@ static int do_misc_fixups(struct bpf_verifier_env= *env) insn->imm =3D=3D BPF_FUNC_get_func_arg) { /* Load nr_args from ctx - 8 */ insn_buf[0] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); - insn_buf[1] =3D BPF_JMP32_REG(BPF_JGE, BPF_REG_2, BPF_REG_0, 6); - insn_buf[2] =3D BPF_ALU64_IMM(BPF_LSH, BPF_REG_2, 3); - insn_buf[3] =3D BPF_ALU64_REG(BPF_ADD, BPF_REG_2, BPF_REG_1); - insn_buf[4] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_2, 0); - insn_buf[5] =3D BPF_STX_MEM(BPF_DW, BPF_REG_3, BPF_REG_0, 0); - insn_buf[6] =3D BPF_MOV64_IMM(BPF_REG_0, 0); - insn_buf[7] =3D BPF_JMP_A(1); - insn_buf[8] =3D BPF_MOV64_IMM(BPF_REG_0, -EINVAL); - cnt =3D 9; + insn_buf[1] =3D BPF_ALU64_IMM(BPF_AND, BPF_REG_0, 0xFF); + insn_buf[2] =3D BPF_JMP32_REG(BPF_JGE, BPF_REG_2, BPF_REG_0, 6); + insn_buf[3] =3D BPF_ALU64_IMM(BPF_LSH, BPF_REG_2, 3); + insn_buf[4] =3D BPF_ALU64_REG(BPF_ADD, BPF_REG_2, BPF_REG_1); + insn_buf[5] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_2, 0); + insn_buf[6] =3D BPF_STX_MEM(BPF_DW, BPF_REG_3, BPF_REG_0, 0); + insn_buf[7] =3D BPF_MOV64_IMM(BPF_REG_0, 0); + insn_buf[8] =3D BPF_JMP_A(1); + insn_buf[9] =3D BPF_MOV64_IMM(BPF_REG_0, -EINVAL); + cnt =3D 10; =20 new_prog =3D bpf_patch_insn_data(env, i + delta, insn_buf, cnt); if (!new_prog) @@ -23305,12 +23306,13 @@ static int do_misc_fixups(struct bpf_verifier_env= *env) eatype =3D=3D BPF_MODIFY_RETURN) { /* Load nr_args from ctx - 8 */ insn_buf[0] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); - insn_buf[1] =3D BPF_ALU64_IMM(BPF_LSH, BPF_REG_0, 3); - insn_buf[2] =3D BPF_ALU64_REG(BPF_ADD, BPF_REG_0, BPF_REG_1); - insn_buf[3] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_3, BPF_REG_0, 0); - insn_buf[4] =3D BPF_STX_MEM(BPF_DW, BPF_REG_2, BPF_REG_3, 0); - insn_buf[5] =3D BPF_MOV64_IMM(BPF_REG_0, 0); - cnt =3D 6; + insn_buf[1] =3D BPF_ALU64_IMM(BPF_AND, BPF_REG_0, 0xFF); + insn_buf[2] =3D BPF_ALU64_IMM(BPF_LSH, BPF_REG_0, 3); + insn_buf[3] =3D BPF_ALU64_REG(BPF_ADD, BPF_REG_0, BPF_REG_1); + insn_buf[4] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_3, BPF_REG_0, 0); + insn_buf[5] =3D BPF_STX_MEM(BPF_DW, BPF_REG_2, BPF_REG_3, 0); + insn_buf[6] =3D BPF_MOV64_IMM(BPF_REG_0, 0); + cnt =3D 7; } else { insn_buf[0] =3D BPF_MOV64_IMM(BPF_REG_0, -EOPNOTSUPP); cnt =3D 1; @@ -23331,8 +23333,9 @@ static int do_misc_fixups(struct bpf_verifier_env *= env) insn->imm =3D=3D BPF_FUNC_get_func_arg_cnt) { /* Load nr_args from ctx - 8 */ insn_buf[0] =3D BPF_LDX_MEM(BPF_DW, BPF_REG_0, BPF_REG_1, -8); + insn_buf[1] =3D BPF_ALU64_IMM(BPF_AND, BPF_REG_0, 0xFF); =20 - new_prog =3D bpf_patch_insn_data(env, i + delta, insn_buf, 1); + new_prog =3D bpf_patch_insn_data(env, i + delta, insn_buf, 2); if (!new_prog) return -ENOMEM; =20 diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 6e076485bf70..5f621f0403f8 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -1194,7 +1194,7 @@ const struct bpf_func_proto bpf_get_branch_snapshot_p= roto =3D { BPF_CALL_3(get_func_arg, void *, ctx, u32, n, u64 *, value) { /* This helper call is inlined by verifier. */ - u64 nr_args =3D ((u64 *)ctx)[-1]; + u64 nr_args =3D ((u64 *)ctx)[-1] & 0xFF; =20 if ((u64) n >=3D nr_args) return -EINVAL; @@ -1214,7 +1214,7 @@ static const struct bpf_func_proto bpf_get_func_arg_p= roto =3D { BPF_CALL_2(get_func_ret, void *, ctx, u64 *, value) { /* This helper call is inlined by verifier. */ - u64 nr_args =3D ((u64 *)ctx)[-1]; + u64 nr_args =3D ((u64 *)ctx)[-1] & 0xFF; =20 *value =3D ((u64 *)ctx)[nr_args]; return 0; @@ -1231,7 +1231,7 @@ static const struct bpf_func_proto bpf_get_func_ret_p= roto =3D { BPF_CALL_1(get_func_arg_cnt, void *, ctx) { /* This helper call is inlined by verifier. */ - return ((u64 *)ctx)[-1]; + return ((u64 *)ctx)[-1] & 0xFF; } =20 static const struct bpf_func_proto bpf_get_func_arg_cnt_proto =3D { --=20 2.52.0