From nobody Sun Feb 8 07:58:26 2026 Received: from canpmsgout02.his.huawei.com (canpmsgout02.his.huawei.com [113.46.200.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50C22221DAC; Thu, 8 Jan 2026 01:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.217 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767836080; cv=none; b=XaPXnz6BjSLiVXL2hGVgwH+nZ3LnUcdHZaUFeaBYzL5bTVkoZSBQU6bWYCc1ZJgvBtNYBc6oQLVjDNn8x+Kk3XE2pICVl7H8U6pCTaeQ1xpGCgVpwDEVDm6kryYyRxrl4jlbKob2GmcWr1LxWTP7a9bj1jkEDu6NbD3FNjq6d70= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767836080; c=relaxed/simple; bh=lHTvFXYZIzQLTkbk1gikqRp1FcuQNH2Pq1L64DE4OC4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MylYMAazgGiMudyP6gY//UAkJQ/06lu2FCI8wvP97qnYtAd7f247OuNZqPuLcEKiAEGopR6ycE403m4piRaKMtre3mzJ9COetuQzeGZvGf6TeXy2SvzMeLlOJlZuUvYf1nEn8gg0X9yJegqjsp4U/NL+IjbjdYYgSX3jRyygYhU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=G2U+uf3e; arc=none smtp.client-ip=113.46.200.217 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="G2U+uf3e" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=4qORrS6UZxVvILfwa9yv4XwWt8ZAlaWo+8PvTeZI4Xk=; b=G2U+uf3ezkKLYTGp2zEXopsRiLY0wtazUCB4ZuxPtaW807q+wza4EwB/n2Zjln0vYw+MFRALN Ke69NKzV4gMEqdF3OQgHwU3D0jLKAn/jv4YIvWhw13h1usGGm6OJMy9R/mfFtpwOXLmlQ1PH/Vb EzdlzKHXj/gipJTCKJQT4TM= Received: from mail.maildlp.com (unknown [172.19.162.197]) by canpmsgout02.his.huawei.com (SkyGuard) with ESMTPS id 4dmnRN4jSMzcZyR; Thu, 8 Jan 2026 09:30:56 +0800 (CST) Received: from kwepemr500012.china.huawei.com (unknown [7.202.195.23]) by mail.maildlp.com (Postfix) with ESMTPS id AC84F40363; Thu, 8 Jan 2026 09:34:29 +0800 (CST) Received: from localhost.localdomain (10.50.85.180) by kwepemr500012.china.huawei.com (7.202.195.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 8 Jan 2026 09:34:29 +0800 From: Ziming Du To: CC: , , , Subject: [PATCH v3 1/3] PCI/sysfs: Fix null pointer dereference during hotplug Date: Thu, 8 Jan 2026 09:59:42 +0800 Message-ID: <20260108015944.3520719-2-duziming2@huawei.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260108015944.3520719-1-duziming2@huawei.com> References: <20260108015944.3520719-1-duziming2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemr500012.china.huawei.com (7.202.195.23) Content-Type: text/plain; charset="utf-8" During the concurrent process of creating and rescanning in VF, the resource files for the same pci_dev may be created twice. The second creation attempt fails, resulting the res_attr in pci_dev to kfree(), but the pointer is not set to NULL. This will subsequently lead to dereferencing a null pointer when removing the device. When we perform the following operation: echo $sriov_totalvfs > /sys/class/net/"$pfname"/device/sriov_numvfs & sleep 0.5 echo 1 > /sys/bus/pci/rescan pci_remove "$pfname" system will crash as follows: Unable to handle kernel NULL pointer dereference at virtual address 00000= 00000000000 Call trace: __pi_strlen+0x14/0x150 kernfs_find_ns+0x54/0x120 kernfs_remove_by_name_ns+0x58/0xf0 sysfs_remove_bin_file+0x24/0x38 pci_remove_resource_files+0x44/0x90 pci_remove_sysfs_dev_files+0x28/0x40 pci_stop_bus_device+0xb8/0x118 pci_stop_and_remove_bus_device+0x20/0x40 pci_iov_remove_virtfn+0xb8/0x138 sriov_disable+0xbc/0x190 pci_disable_sriov+0x30/0x48 hinic_pci_sriov_disable+0x54/0x138 [hinic] hinic_remove+0x140/0x290 [hinic] pci_device_remove+0x4c/0xf8 device_remove+0x54/0x90 device_release_driver_internal+0x1d4/0x238 device_release_driver+0x20/0x38 pci_stop_bus_device+0xa8/0x118 pci_stop_and_remove_bus_device_locked+0x28/0x50 remove_store+0x128/0x208 Fix this by set the pointer to NULL after releasing 'res_attr' immediately. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Ziming Du --- drivers/pci/pci-sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index c2df915ad2d2..7e697b82c5e1 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -1222,12 +1222,14 @@ static void pci_remove_resource_files(struct pci_de= v *pdev) if (res_attr) { sysfs_remove_bin_file(&pdev->dev.kobj, res_attr); kfree(res_attr); + pdev->res_attr[i] =3D NULL; } =20 res_attr =3D pdev->res_attr_wc[i]; if (res_attr) { sysfs_remove_bin_file(&pdev->dev.kobj, res_attr); kfree(res_attr); + pdev->res_attr_wc[i] =3D NULL; } } } --=20 2.43.0 From nobody Sun Feb 8 07:58:26 2026 Received: from canpmsgout06.his.huawei.com (canpmsgout06.his.huawei.com [113.46.200.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5275C4F881; Thu, 8 Jan 2026 01:34:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.221 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767836075; cv=none; b=URpSfFHu6+MGOyLq5DtetcPKRqLqX7GPghbFb8pIyO4cbG8uVH+2eQEl3rMQFVUEiuCu2DqKSWQFh1mZuuy1x/zc9032upivkLWqN1up8nV3R4/m3ivt1xdNwi9P2OYaVp3FP5zb+SWdz3zLX7/B/kBUtB/FJ+8SegfWMwngp/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767836075; c=relaxed/simple; bh=WiQKRscTa3+3cW9ZmWM2gU4aRssj7qEoKyUkDxRRqr8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZB0Kfqj/608fyKpMGOTirDwdn1swibJOV17qtmJAvK/pbp4hNPqmHEbQxQtYrSQx4/1viIgCvh+h4H5FxbSZOpnDHBcSqf10IbvNpcqh7ac+rTBax2O+DmbOJeC9p1nOfnNbTz0afEfrNWbRPiTp+wMPy2/4QzMIikDSKWI//oA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=Vt+0NzpD; arc=none smtp.client-ip=113.46.200.221 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="Vt+0NzpD" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=N3npRfVhXRQF8DIOX87CwtMMwO0dhfCdVq9cgBpW9FE=; b=Vt+0NzpDL7Y/7N2epSYTxQpp/8zdFqf3Rr9DgvaI6vky8H71gt1HFRd9f2JS/86RIfhYy5dHT yF7K0fQUrnzlx5zgejbTmHbuVaQsHdB2BVLkDYeEDt42S7gdbIHFOiwpKp18G4AlPsslqlDzmG3 51VCn08gwR7fHf4xz4n9RBs= Received: from mail.maildlp.com (unknown [172.19.162.144]) by canpmsgout06.his.huawei.com (SkyGuard) with ESMTPS id 4dmnRj6b5BzRhRS; Thu, 8 Jan 2026 09:31:13 +0800 (CST) Received: from kwepemr500012.china.huawei.com (unknown [7.202.195.23]) by mail.maildlp.com (Postfix) with ESMTPS id 0180040538; Thu, 8 Jan 2026 09:34:30 +0800 (CST) Received: from localhost.localdomain (10.50.85.180) by kwepemr500012.china.huawei.com (7.202.195.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 8 Jan 2026 09:34:29 +0800 From: Ziming Du To: CC: , , , Subject: [PATCH v3 2/3] PCI: Prevent overflow in proc_bus_pci_write() Date: Thu, 8 Jan 2026 09:59:43 +0800 Message-ID: <20260108015944.3520719-3-duziming2@huawei.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260108015944.3520719-1-duziming2@huawei.com> References: <20260108015944.3520719-1-duziming2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemr500012.china.huawei.com (7.202.195.23) Content-Type: text/plain; charset="utf-8" From: Yongqiang Liu When the value of *ppos over the INT_MAX, the pos is over set to a negative value which will be passed to get_user() or pci_user_write_config_dword(). Unexpected behavior such as a soft lockup will happen as follows: watchdog: BUG: soft lockup - CPU#0 stuck for 130s! [syz.3.109:3444] RIP: 0010:_raw_spin_unlock_irq+0x17/0x30 Call Trace: pci_user_write_config_dword+0x126/0x1f0 proc_bus_pci_write+0x273/0x470 proc_reg_write+0x1b6/0x280 do_iter_write+0x48e/0x790 vfs_writev+0x125/0x4a0 __x64_sys_pwritev+0x1e2/0x2a0 do_syscall_64+0x59/0x110 entry_SYSCALL_64_after_hwframe+0x78/0xe2 Fix this by using unsigned int for the pos. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Yongqiang Liu Signed-off-by: Ziming Du Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/pci/proc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c index 9348a0fb8084..2d51b26edbe7 100644 --- a/drivers/pci/proc.c +++ b/drivers/pci/proc.c @@ -113,10 +113,14 @@ static ssize_t proc_bus_pci_write(struct file *file, = const char __user *buf, { struct inode *ino =3D file_inode(file); struct pci_dev *dev =3D pde_data(ino); - int pos =3D *ppos; + int pos; int size =3D dev->cfg_size; int cnt, ret; =20 + if (*ppos > INT_MAX) + return -EINVAL; + pos =3D *ppos; + ret =3D security_locked_down(LOCKDOWN_PCI_ACCESS); if (ret) return ret; --=20 2.43.0 From nobody Sun Feb 8 07:58:26 2026 Received: from canpmsgout12.his.huawei.com (canpmsgout12.his.huawei.com [113.46.200.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE30B228CB8; Thu, 8 Jan 2026 01:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767836082; cv=none; b=JB96ybT8DbyGH1ULClzxNWj5RNOECbrwtKshmQxZ+TinkNgM3JGimMYcUAPGFZmc+4MhTPpxwfH8ZJED3FBgwMo1QE1eL9NKUdUbmQDk/n26r6FGAdaotoItzzzq2XUr7j7IWMKXHejeI8jEyhPMQFfLgvchU4S0zRvSI1OMv5M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767836082; c=relaxed/simple; bh=KOkz3kBXR1AOxj5d2DWLCyUG8LTzFoNgD0ueSEz5crM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RXOs71oKR2BOJkzzgV1Q5Hkk3U1BBeTKw7WVinBN9QQw0kJAiQ2+R+a50yDn+zMFfFALJKt33Dk1yXzUVFIyVZY8L+RSpJHOzushS7I9zIpCQ31dVoTOx2uH0J1eG2pPNcyJyVclBLbTFkVwJ9UF20YC4bM6WOr4u+1mjVLDXeo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=MGUri89d; arc=none smtp.client-ip=113.46.200.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="MGUri89d" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=VJtMqKEIPPguPZMN5Ybem/NDDQKThnVR4N7EDyWD6oQ=; b=MGUri89dIU7W+g2XFhY0h9bRNF1uWRSfJR8nmlmHTNNlpsEuM1UH0qc8F+w5F3qBYyw2xzbuD oaS/dn/F3FtANWIRGpXVasXO5pCjioAcx91KRnqcByC9CHKvDkr+BVHSFtdq2iwElFWujfKLrFJ 2AgZ+yykdHHMlBOMFyXsR5k= Received: from mail.maildlp.com (unknown [172.19.163.200]) by canpmsgout12.his.huawei.com (SkyGuard) with ESMTPS id 4dmnRy38Z6znTX0; Thu, 8 Jan 2026 09:31:26 +0800 (CST) Received: from kwepemr500012.china.huawei.com (unknown [7.202.195.23]) by mail.maildlp.com (Postfix) with ESMTPS id 522594055B; Thu, 8 Jan 2026 09:34:30 +0800 (CST) Received: from localhost.localdomain (10.50.85.180) by kwepemr500012.china.huawei.com (7.202.195.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 8 Jan 2026 09:34:29 +0800 From: Ziming Du To: CC: , , , Subject: [PATCH v3 3/3] PCI/sysfs: Prohibit unaligned access to I/O port on non-x86 Date: Thu, 8 Jan 2026 09:59:44 +0800 Message-ID: <20260108015944.3520719-4-duziming2@huawei.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260108015944.3520719-1-duziming2@huawei.com> References: <20260108015944.3520719-1-duziming2@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemr500012.china.huawei.com (7.202.195.23) Content-Type: text/plain; charset="utf-8" From: Yongqiang Liu Unaligned access is harmful for non-x86 archs such as arm64. When we use pwrite or pread to access the I/O port resources with unaligned offset, system will crash as follows: Unable to handle kernel paging request at virtual address fffffbfffe8010c1 Internal error: Oops: 0000000096000061 [#1] SMP Call trace: _outw include/asm-generic/io.h:594 [inline] logic_outw+0x54/0x218 lib/logic_pio.c:305 pci_resource_io drivers/pci/pci-sysfs.c:1157 [inline] pci_write_resource_io drivers/pci/pci-sysfs.c:1191 [inline] pci_write_resource_io+0x208/0x260 drivers/pci/pci-sysfs.c:1181 sysfs_kf_bin_write+0x188/0x210 fs/sysfs/file.c:158 kernfs_fop_write_iter+0x2e8/0x4b0 fs/kernfs/file.c:338 vfs_write+0x7bc/0xac8 fs/read_write.c:586 ksys_write+0x12c/0x270 fs/read_write.c:639 __arm64_sys_write+0x78/0xb8 fs/read_write.c:648 Powerpc seems affected as well, so prohibit the unaligned access on non-x86 archs. Fixes: 8633328be242 ("PCI: Allow read/write access to sysfs I/O port resour= ces") Signed-off-by: Yongqiang Liu Signed-off-by: Ziming Du --- drivers/pci/pci-sysfs.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 7e697b82c5e1..11d8b7ec4263 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -31,6 +31,7 @@ #include #include #include +#include #include "pci.h" =20 #ifndef ARCH_PCI_DEV_GROUPS @@ -1166,12 +1167,20 @@ static ssize_t pci_resource_io(struct file *filp, s= truct kobject *kobj, *(u8 *)buf =3D inb(port); return 1; case 2: + #if !defined(CONFIG_X86) + if (!IS_ALIGNED(port, count)) + return -EFAULT; + #endif if (write) outw(*(u16 *)buf, port); else *(u16 *)buf =3D inw(port); return 2; case 4: + #if !defined(CONFIG_X86) + if (!IS_ALIGNED(port, count)) + return -EFAULT; + #endif if (write) outl(*(u32 *)buf, port); else --=20 2.43.0