From nobody Sun Feb 8 16:32:02 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DFE41DB356 for ; Thu, 8 Jan 2026 00:43:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767833007; cv=none; b=BzgBCn4L0Z1QqCXvFWsb6Pf82FD6OSUWtWO1Ew6gJueMLwsTK6I5wKWHuZFdVVl/nr1TFqSsJZDLK8LzW3qJ2d4crcKXH+dre9Ad0AzNVGeE9dmzEpcCxLtm0A27dNU5vcWpxmOT6wEtn8Envw/uSu2VjO4pgCnxrGZNAoHXG94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767833007; c=relaxed/simple; bh=mHd5/FDiQ86yScP8/xKWBTcg+ow54G9KDtNwccSg1Uk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fok2FxulQ8c9wemVgqOphIDqgycf3+ra5w7Ed6BfPt9ydpGjZTKIGbESuCDTnV+Io6ipcWZ7WYpqjFQTsDNKQER5lvFeefdQwVkrQAqIiswjMO8LE35AaXtRgXJlEgJwZsmXAS6CszhvpJC5kTbzCQ4PFTCLH18oWWDVaKKUEzg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=du4J1+jI; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="du4J1+jI" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a12ebe4b74so28124095ad.0 for ; Wed, 07 Jan 2026 16:43:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767833006; x=1768437806; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qykhmziqocBs83eOMsCXS+riegj3dQCRKqwsythsgqI=; b=du4J1+jIknx8EyqHTRi0ncr9q3iul358A+qkdtHPGmY1T87z72tODfL9wrBdHUXx3C 6vuBhcM3Eq9jzPvkGRqLTgzj9nJR4Ck9GpH1MDShirsStyiZgjvPxqOmWWEcihXzA3ya G3xJOG63lFSptgDN9M3vmG9TwwEzK6LGbaIeqt8oEfUsT1qn9rSvyk4YjZuFvwM0l1Tk uCzU4zgb1nEaccdShko7q2gsBct0GScnzi2lYI7BnnvW2aXSSuZeNI2J16jHezg+h9hn aJmEPMJUo6Edq92re9YyLELdWkHL6I1Srjq5tqvpj+Xc4WAwUWl2AtktLr4QmXtrFkZ/ hk3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767833006; x=1768437806; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qykhmziqocBs83eOMsCXS+riegj3dQCRKqwsythsgqI=; b=w8YtmlVaGb2gH9QinjYzEEL608yEFCMt5i0yYKqlDOAGqwwyzbXcH+xIueIG8uqMOX D5A3aLKh8o6unztmMnAWefXnJpMrwkH3H+M0Tf0GvZ1Vz6tRIQymBhCqjxu4hljngZYr 9+q1LU179caMt0bAESu1wIr8h7w2NV3JGNwTtUJ+3yDWVpDUdl4QWLQyl4k3vUHu9bdD IDDZx+sLA41ad66Fl7SXTaYSmOdFvgTTXTMDHJCI0agjFciOxv83gV7mWQJV3yciu7A+ x6h6yMt2/EHywHTMnAUBgiKLhEZxmesY2jqvoIas5yI0FRhoixwIskUGztgOoYj7n2yo 2KUg== X-Forwarded-Encrypted: i=1; AJvYcCXN5SOVQVASgqjA34yhPFl3PkjK1CEIv/cYOS/f0boNZpj+AjB5Qpz+HbYHCiieFv04tEYBFQGp7JLYktk=@vger.kernel.org X-Gm-Message-State: AOJu0YykufvFcs5D2EKvDOXYCTZJE8/xOOEi+Z/rRUOaGphNCePi8HgI q2dW8p1NPLxUmIHZw2siMtGOZbsVHLFm1+Z3pKgtUj0Gy7pOBY+lJYTK X-Gm-Gg: AY/fxX7tJmntDLFEpBddoKk/GIqBg19dBtqDvP0MaeMMHcEDCFptS32P2DMJQdRH+oK HeKMLBCyDAAYQ/y7b2HkPawrM1+K5BvY3WSqWgbtTLVGxdHGanAvgqTId3F93BIO5TGB8UmJfkx gJx/Bmi5jkTRhCKU63R4Q7L6fNQRmk3f/v6LAO4OH+rkYCooU4i5tXAKgjQDaubMw/YIgWWCIAk FgxarZAzDIs2gUHZskQLdwA1oCkGA2BlgsSjyQRx7g1ufqhYdNnyhoxtVIV6//ODTfuQh2WpKXI KgJWXSl5mt8qvmnsgVoKxngxbxnIRVc9gYc85g8vhtApvl9vGugmAvl9PGTj6OgJwVJURS8rVlp W8LDGLlDGVyIpB1H83z+N19xGzKftIpyvyml/p7BvqncXD88VpTMcU1Kel79fkPP15XzB+J09ZA TnTBA+TkOi7yMgyy0bXh3Y+ioGzShx+D/34Xe9OChjuus6EP6E+qvu8A== X-Google-Smtp-Source: AGHT+IExI20PPQrc2gAMhaAb+xN+DaUa+vqsuFXYJDYlwqt9scGkXOXGekbyt2CGFVkragmqd33jTQ== X-Received: by 2002:a17:903:38c8:b0:269:b6c8:4a4b with SMTP id d9443c01a7336-2a3ee41358cmr41763815ad.6.1767833005702; Wed, 07 Jan 2026 16:43:25 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cc88d8sm60198435ad.80.2026.01.07.16.43.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 16:43:25 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org, Dan Carpenter , David Laight Subject: [PATCH net-next v4 1/2] net: dsa: yt921x: Fix MIB overflow wraparound routine Date: Thu, 8 Jan 2026 08:43:05 +0800 Message-ID: <20260108004309.4087448-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260108004309.4087448-1-mmyangfl@gmail.com> References: <20260108004309.4087448-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reported by the following Smatch static checker warning: drivers/net/dsa/yt921x.c:702 yt921x_read_mib() warn: was expecting a 64 bit value instead of '(~0)' Fixes: 186623f4aa72 ("net: dsa: yt921x: Add support for Motorcomm YT921x") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/netdev/aPsjYKQMzpY0nSXm@stanley.mountain/ Suggested-by: David Laight Signed-off-by: David Yang --- drivers/net/dsa/yt921x.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c index 0b3df732c0d1..5e4e8093ba16 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/yt921x.c @@ -682,21 +682,22 @@ static int yt921x_read_mib(struct yt921x_priv *priv, = int port) const struct yt921x_mib_desc *desc =3D &yt921x_mib_descs[i]; u32 reg =3D YT921X_MIBn_DATA0(port) + desc->offset; u64 *valp =3D &((u64 *)mib)[i]; - u64 val =3D *valp; u32 val0; - u32 val1; + u64 val; =20 res =3D yt921x_reg_read(priv, reg, &val0); if (res) break; =20 if (desc->size <=3D 1) { - if (val < (u32)val) - /* overflow */ - val +=3D (u64)U32_MAX + 1; - val &=3D ~U32_MAX; - val |=3D val0; + u64 old_val =3D *valp; + + val =3D (old_val & ~(u64)U32_MAX) | val0; + if (val < old_val) + val +=3D 1ull << 32; } else { + u32 val1; + res =3D yt921x_reg_read(priv, reg + 4, &val1); if (res) break; --=20 2.51.0