From nobody Mon Feb 9 15:11:27 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D76C0335566 for ; Thu, 8 Jan 2026 21:17:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907052; cv=none; b=oD+xIxu1o302fiLu6SeBlGlOab7IvnpqisMNO3wnEunZojgqc9qipXishSaZSGtpgWdBCykfHxUJyenczK51U3/LhsPZ9DeeDNuc9xK7JuxipyLG5pN9I04JmTkhzxE7BtcIWZ2l1bMwrj4gkISE7iSW+0y623WBfwBpSo/o+Iw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907052; c=relaxed/simple; bh=umRDO+6LfN/287FxKKSUjyAEnGgbqrwJmKxDM5IJEb0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sGTcTooFoMAUSDYhxU2HTXtwVsR8Xnqj5L3D9O6U8Gy/77knTDYjZgLSLcwjP6Al25yaeMzYmVqyO/Un2RpesoZQsPSUVVYpMiIduAuoICOSLUoJav+nN9jCa+i1aM5zdYONOTEA1F/dQG6+GLFdxMk6I8QQCQIYnVONtt5UbhM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UKV83+e1; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Hpx34d36; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UKV83+e1"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hpx34d36" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nbe/XApWaL18q7zl45yn83syExfCEwt8uiod4ciQGmg=; b=UKV83+e175buGFTK2k7UuYhQ6JR4ekrH/L4BG3d318hJkwABXq5RIT3kyUU6K55YxBg9vx Z2ukEJeMYhJdlfdmGJm2VxXyDQSmBgt7qO/VXXS7Z67F5L0iD/N0JPJgaQD26OmMmieA0T cgM7edkO/ulMRiWU4u8Xkt6uwrKcL08= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-358-kekmwgHoMjqx0v1E121-mQ-1; Thu, 08 Jan 2026 16:17:22 -0500 X-MC-Unique: kekmwgHoMjqx0v1E121-mQ-1 X-Mimecast-MFC-AGG-ID: kekmwgHoMjqx0v1E121-mQ_1767907042 Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5ed0ec20724so2889857137.2 for ; Thu, 08 Jan 2026 13:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907042; x=1768511842; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nbe/XApWaL18q7zl45yn83syExfCEwt8uiod4ciQGmg=; b=Hpx34d36BMQtdTJP3jdsuAgrOupkSOL3kdRClqW6iwjD5Aep3DdV8z6nXakM9u5VNj 3n8BQINQAcCST4JVRwwmXzIC1lOmehylfv129hrJCVUwiQlhOH5WytPu4rfz0Afp3w6v 0Y2p5cShNWdmWcO9GbUW1jm0522Yr47+BrbzfuCGFE1/q9/UBiYkxzQR7OWgb+sb/N/M IWyCiI8kidkuVU97dX+FT2yt5LrBEJAluChZbY2fOB2bAXMrDwbDa+q5D3Y/XWwbC2Gi rXxzC9m8ToBVPJaFNg9tVGqRX/LApf1xKHrSEzdIujtjlAB2tHxzv/lkM2SiKRoYkD2j 7gOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907042; x=1768511842; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nbe/XApWaL18q7zl45yn83syExfCEwt8uiod4ciQGmg=; b=EuEe6bswQN7+Yc0F7fbfcjfA2RuC98k8GItIMWoJMVlQ5unW9zu0SJrbYUDFjhWE7Z lYRPvBon1/ohtbUR5wlwCQcJ7BpKf39UrLoW48SBzFz6G6X56rq71tkemx/YZUiNf9oP yxQsD1fjEKhTrBXzt3cJXZts4T27+c5YalsyiwlOn5/epUp8rA/eCYdXSgJFzCEqo7dp 8Nvf/DprzxPtqClFE2/OnV0VvBvC2EAtYbNd0F/HgZ9Lj7yrtWWJRygjvcWmEXNawyKG PHNRR/rI1Un6WQPvWG4xTHiyARDPzIUFPIZO2AmfHh9PywVZtKGzVoYdMy7Iq37aPggn qTmQ== X-Forwarded-Encrypted: i=1; AJvYcCUWr/ScwqBGlrlMuUUUpMTjlFTwJBEMnKENGKGDQmVIj7Rcs26kwRdkXQTiuDZ5DA26H5dL9PWHwYgBHBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwETcRGP4G2Txg0NCx4IPbd0iVyYwqE6znPaz+KGQfIhYY/yKEr pWyhxn+OG9uOMaw2FGRjt4OClJPY4RDjgMONuZjOXnyBbsPa6GRfSaegorpeR73Zq/uIQHJqdH3 UGWIrWBFBiDSAP+0JIvSFQzecd/q/FrjOncjlHqrKfARH710TOTZFn6tiYJQd/ihOLg== X-Gm-Gg: AY/fxX59bPevvdwhSmKU4WF7m4mE10OjlcQYa4TBkveKL8iwfyYpBq8+tFEhkeyJqTv SVDReGJ72RkCsEkcjW+Nef7hYtDLiOP+CkVUPeKaOpvnsfyhMcNztd/L+VivN3+rVjLTncebeX8 2hS15KlWjbNu8vnLMR4Rag367as9dNZwt4a6wIkrXMsOdF4r93SrixSwl5zgxwLmdU6tSKrK2QX PC0Tl/Ablgls76vSInNDbbG0RLx+1KAwgiBYr0FcDYaKomr/j3pd9j5//BsTiWjAoK467zNK+IH UYRc5a/UrRZBQzi9kmeqWNtlL3sq5UaGlqcWGXhZNay8UT/Gf0/wrs+W5oDRP0vT1c1TSUHWak7 DpuVDvw2m+qoupfM= X-Received: by 2002:a05:6102:2b8c:b0:5df:bd66:7b76 with SMTP id ada2fe7eead31-5ecb5cc3249mr3338016137.17.1767907041720; Thu, 08 Jan 2026 13:17:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1x2+oN44SwRZMn0neR813HW1d3t12U7Ab+i+v/CBEKCDCYY1jODx5EVkgCHegnuNvRsKGvg== X-Received: by 2002:a05:6102:2b8c:b0:5df:bd66:7b76 with SMTP id ada2fe7eead31-5ecb5cc3249mr3338010137.17.1767907041324; Thu, 08 Jan 2026 13:17:21 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:17:20 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:21 -0500 Subject: [PATCH 03/27] rtc: ac100: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-3-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Alexandre Belloni , linux-rtc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3747; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=umRDO+6LfN/287FxKKSUjyAEnGgbqrwJmKxDM5IJEb0=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5LaFZDw2enhddVtjCv8tt2nNjHNUwns4+26Fpf4M1 Vvt2DK3o5SFQYyLQVZMkWVJrlFBROoq23t3NFlg5rAygQxh4OIUgIl81mdk+MBgZfzn+rtk206e ieGnNpXUFXfJRe2ZNqXnn/jmGq/9ngz/A745NDB/ZIqY4Ze9653w6RrBIOs0F71FG86mKx7ZqBD OCwA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Signed-off-by: Brian Masney --- To: Alexandre Belloni Cc: linux-rtc@vger.kernel.org --- drivers/rtc/rtc-ac100.c | 75 +++++++++++++++++++++++++--------------------= ---- 1 file changed, 38 insertions(+), 37 deletions(-) diff --git a/drivers/rtc/rtc-ac100.c b/drivers/rtc/rtc-ac100.c index 33626311fa781b5ce90dcc472f948dc933bbc897..16aca4431da8c029e6195d8a3c9= fe75fa95d0bc0 100644 --- a/drivers/rtc/rtc-ac100.c +++ b/drivers/rtc/rtc-ac100.c @@ -140,42 +140,16 @@ static unsigned long ac100_clkout_recalc_rate(struct = clk_hw *hw, AC100_CLKOUT_DIV_WIDTH); } =20 -static long ac100_clkout_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long prate) -{ - unsigned long best_rate =3D 0, tmp_rate, tmp_prate; - int i; - - if (prate =3D=3D AC100_RTC_32K_RATE) - return divider_round_rate(hw, rate, &prate, NULL, - AC100_CLKOUT_DIV_WIDTH, - CLK_DIVIDER_POWER_OF_TWO); - - for (i =3D 0; ac100_clkout_prediv[i].div; i++) { - tmp_prate =3D DIV_ROUND_UP(prate, ac100_clkout_prediv[i].val); - tmp_rate =3D divider_round_rate(hw, rate, &tmp_prate, NULL, - AC100_CLKOUT_DIV_WIDTH, - CLK_DIVIDER_POWER_OF_TWO); - - if (tmp_rate > rate) - continue; - if (rate - tmp_rate < best_rate - tmp_rate) - best_rate =3D tmp_rate; - } - - return best_rate; -} - static int ac100_clkout_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { - struct clk_hw *best_parent; + int i, ret, num_parents =3D clk_hw_get_num_parents(hw); + struct clk_hw *best_parent =3D NULL; unsigned long best =3D 0; - int i, num_parents =3D clk_hw_get_num_parents(hw); =20 for (i =3D 0; i < num_parents; i++) { struct clk_hw *parent =3D clk_hw_get_parent_by_index(hw, i); - unsigned long tmp, prate; + unsigned long prate; =20 /* * The clock has two parents, one is a fixed clock which is @@ -199,13 +173,40 @@ static int ac100_clkout_determine_rate(struct clk_hw = *hw, =20 prate =3D clk_hw_get_rate(parent); =20 - tmp =3D ac100_clkout_round_rate(hw, req->rate, prate); - - if (tmp > req->rate) - continue; - if (req->rate - tmp < req->rate - best) { - best =3D tmp; - best_parent =3D parent; + if (prate =3D=3D AC100_RTC_32K_RATE) { + struct clk_rate_request div_req =3D *req; + + div_req.best_parent_rate =3D prate; + + ret =3D divider_determine_rate(hw, &div_req, NULL, + AC100_CLKOUT_DIV_WIDTH, + CLK_DIVIDER_POWER_OF_TWO); + if (ret !=3D 0 || div_req.rate > req->rate) + continue; + else if (req->rate - div_req.rate < req->rate - best) { + best =3D div_req.rate; + best_parent =3D parent; + } + } else { + int j; + + for (j =3D 0; ac100_clkout_prediv[j].div; j++) { + struct clk_rate_request div_req =3D *req; + unsigned long tmp_prate; + + tmp_prate =3D DIV_ROUND_UP(prate, ac100_clkout_prediv[j].div); + div_req.best_parent_rate =3D tmp_prate; + + ret =3D divider_determine_rate(hw, &div_req, NULL, + AC100_CLKOUT_DIV_WIDTH, + CLK_DIVIDER_POWER_OF_TWO); + if (ret !=3D 0 || div_req.rate > req->rate) + continue; + else if (req->rate - div_req.rate < req->rate - best) { + best =3D div_req.rate; + best_parent =3D parent; + } + } } } =20 @@ -213,7 +214,7 @@ static int ac100_clkout_determine_rate(struct clk_hw *h= w, return -EINVAL; =20 req->best_parent_hw =3D best_parent; - req->best_parent_rate =3D best; + req->best_parent_rate =3D clk_hw_get_rate(best_parent); req->rate =3D best; =20 return 0; --=20 2.52.0