From nobody Mon Feb 9 16:02:25 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D1A833A715 for ; Thu, 8 Jan 2026 21:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907142; cv=none; b=Rx8+WnYkEBclMxwtQgrkk5HA3ddbkJ4vvmpnvzrqz1aQOjzMJJyWJo0dj+GhsPl4CbvE8UxYGPLEDzruntBY4oXN6xk7aLm/JpJTXZYWh4WdfirKsWpX2mADaq1SQGkNAlwrJF9ERqRXiih73A+l4PdUrUwRgWg3apR+WwJSsHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907142; c=relaxed/simple; bh=1zGr1VEhUSEgUAAiV8B/qL6RDaMkiVVGUfjryyBP0yI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AtruLHLbammxR2S3NV7lbclmyiupJjqgtkd5iE42YsAXh7HqVehJwjbzyal1kj07zFdP0mB/AyHqIFlByCilfRLnEGUNUlm0kvH8NmbyTMJAtQhSld5uXXRrkgZ5Eb9hI7+KdPhhcwgizOaFpz3aE1myKwx/d2ILRTcrLla2V94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BsaKeO/f; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Hq4PoVi6; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BsaKeO/f"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hq4PoVi6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5QDz5yJgmx0439uD0ntmtxod09pLPWy27GZMDx1s30w=; b=BsaKeO/fPuxKFrU0HG/h38eFXzTzyue14DhNE9+ivU4OeNx9D+6HHGjqIVLfh6mwIyJdqf Yf9d9R6q2+XEKBj5XYYqyCv2+Dh5csbH6rObjQbyteqjo+7UlQVLC9VSASZR+FY4hfqVtw M+aYkcshd6MEa5YcCVvLiKX6tGdZ26w= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-HnznzkeYO8i2I82ai-NisQ-1; Thu, 08 Jan 2026 16:18:55 -0500 X-MC-Unique: HnznzkeYO8i2I82ai-NisQ-1 X-Mimecast-MFC-AGG-ID: HnznzkeYO8i2I82ai-NisQ_1767907135 Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5ed0b7ed42eso1164022137.1 for ; Thu, 08 Jan 2026 13:18:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907135; x=1768511935; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5QDz5yJgmx0439uD0ntmtxod09pLPWy27GZMDx1s30w=; b=Hq4PoVi6MJTKBidfilsyYBTgbiz78dZ0gjD9cuxcNlxk5ggc3oulaklAwHLPxydUMy 87mypWKjZMLKs3eMTc78ZAzF93KeesPlQuJUwwc6ttm4YBrJXij5Rl5WL6m7srFzTvC8 8UbCwhlnn6aut6OHu+wh9XzRTR2tx5EAXRXsUzYJwypsrBQafKej07ucReYtjrI2cG79 ApCZxwz/6wC0+AA8tF+laS46E2f9oXTDsJFuJ0Dan2F33xsNpaZjmRvKB1XLOqNxXw5j 8L3IHXdsEtF3tUUDuGY4KYl27QRrM0awBb/Ki4gob0rgL7XMywL46BoaPdat3XlueMil +vhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907135; x=1768511935; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5QDz5yJgmx0439uD0ntmtxod09pLPWy27GZMDx1s30w=; b=jgq/Iftkj8ekpUgsYG1EUR/0JKWNHOmFLmYbGK/vpbFV4P1ZlLM/k5mL4t4u0Nse9t aBr22k/SktRk23U1enOWYwW0qy0fFDmvR3V6OSGcdJJm7bFxAfscaAQGwcTpQ2jjVj4g 5/E7XozM3yU57R4eQV6W2L8NnG5u6te8xwey+feFuyQsVCF/gcLtWK8YnVIie3BYDm5R R2Dy2c0hbyxpdU6shykoJ5OBNkEbivuoZ1IJB7d+yBgtr9gS680zsc8ouuG9KmgUvOJE 6ZXUXDF14c6IMYesUGiag0bvW095AXxNsbgdJ18hYfYYnLDeGRvGKmy36rVsX2j1AxK2 qGlA== X-Forwarded-Encrypted: i=1; AJvYcCWU+hpmfEevHuK4/7wIhOPYzmpEIYQcETbteRraq8D2QhlCSxXgFIHGpHvwQmhs9E6A7GL4aaOkklbVIVo=@vger.kernel.org X-Gm-Message-State: AOJu0YxOiv8+53cMSBGDBpElR+SETjV9R3fMRxcjBm4YP3IBP0C5bDdM Iyu0eXmNlKzdGZZz9pq72K+W/mu0IV6d/J5GsDa+XM5WyHtzCsQc9Qo+WZNjlbxO2iLPNDUr7VJ KM8Go6Lxr9yAyv5fjKaZpeeEaqT3D2OyWmfpdF31jeUBL38W3G/+v4hdB1zRXPwypOw== X-Gm-Gg: AY/fxX7vRvRfCY+aW4pHsYKu86RuuN6PRXT1Ym5msHUEJ4V+e/MYi5PgJ9ELcV5+f4f eUSFg6icQCQoWECSmVa83qz7FcAbvX7lYncfKhdv1HOI5vVxB1GN552hxMV3FNf4bRPqUeZNJfQ GKTQlMOXuretjez+5JcUXUo1TZx5sKAZ/cjDyj543gqePFDGrOk7Jk3V28ok2XhGptV/7i2XpWb xKy9kH9BtNufQ0/G97tFhNgBxRy7f2kOZZtMYOsS9xsI+BWUYZ18zTOIGzVcISkm4A7N4CtoZgR cBqE0k4WZs4qqCD7tDTuOt1tSy086OPTmNv7TtKZF+MN4QmRoIhLo/WkIY7VfrU2+ezItGXBtsD HkjypjdNMCR2/ASU= X-Received: by 2002:a05:6102:2b8c:b0:5ec:848d:2eb3 with SMTP id ada2fe7eead31-5ecb560294amr3157837137.19.1767907135131; Thu, 08 Jan 2026 13:18:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+wVo31RtnFWHlhbf1gwVuy01FPzefAIXV8pM4OiwoVNvycs5UB0kClvVq2bdd3YZxuh0SVQ== X-Received: by 2002:a05:6102:2b8c:b0:5ec:848d:2eb3 with SMTP id ada2fe7eead31-5ecb560294amr3157824137.19.1767907134612; Thu, 08 Jan 2026 13:18:54 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:54 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:38 -0500 Subject: [PATCH 20/27] clk: stm32: stm32-core: convert from divider_round_rate_parent() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-20-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2480; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=1zGr1VEhUSEgUAAiV8B/qL6RDaMkiVVGUfjryyBP0yI=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5HZ+rVz4cq5P358Ldj9m7J33rWhF42pTTu5vx/bOq vD+uDptd0cpC4MYF4OsmCLLklyjgojUVbb37miywMxhZQIZwsDFKQATCT/H8Fc20NW1ctEMhvb1 eUtmWJ9753w9LOauSY9OqHpK5FGLq08Y/jvaJGQWz50Y9HLBob45cZedTKY73G51alpxMHDtvcU MsWwA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate_parent() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: cd1cb38836c0 ("clk: stm32: stm32-core: convert from round_rate() to = determine_rate()") Signed-off-by: Brian Masney --- To: Maxime Coquelin To: Alexandre Torgue Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org --- drivers/clk/stm32/clk-stm32-core.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/clk/stm32/clk-stm32-core.c b/drivers/clk/stm32/clk-stm= 32-core.c index b95b9c591fda7d900d523f50c8bd449398aba49f..e921c25a929c303a2e189bf8766= 67178a123eae1 100644 --- a/drivers/clk/stm32/clk-stm32-core.c +++ b/drivers/clk/stm32/clk-stm32-core.c @@ -375,13 +375,8 @@ static int clk_stm32_divider_determine_rate(struct clk= _hw *hw, divider->flags, val); } =20 - req->rate =3D divider_round_rate_parent(hw, clk_hw_get_parent(hw), - req->rate, - &req->best_parent_rate, - divider->table, - divider->width, divider->flags); - - return 0; + return divider_determine_rate(hw, req, divider->table, divider->width, + divider->flags); } =20 static unsigned long clk_stm32_divider_recalc_rate(struct clk_hw *hw, @@ -438,7 +433,6 @@ static int clk_stm32_composite_determine_rate(struct cl= k_hw *hw, { struct clk_stm32_composite *composite =3D to_clk_stm32_composite(hw); const struct stm32_div_cfg *divider; - long rate; =20 if (composite->div_id =3D=3D NO_STM32_DIV) return 0; @@ -457,14 +451,8 @@ static int clk_stm32_composite_determine_rate(struct c= lk_hw *hw, val); } =20 - rate =3D divider_round_rate_parent(hw, clk_hw_get_parent(hw), - req->rate, &req->best_parent_rate, - divider->table, divider->width, divider->flags); - if (rate < 0) - return rate; - - req->rate =3D rate; - return 0; + return divider_determine_rate(hw, req, divider->table, divider->width, + divider->flags); } =20 static u8 clk_stm32_composite_get_parent(struct clk_hw *hw) --=20 2.52.0