From nobody Mon Feb 9 16:02:27 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9105D33A032 for ; Thu, 8 Jan 2026 21:18:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907139; cv=none; b=LYPF9WCmOGdJoBjMe+dDekBEJ5//dCIcaQEcpBjCMGlkdSN7/RUGxSRF2633xPkzkmLP5VsArOs0f7Mhmx/eYIk8szYqDLfWbEQ6T9JDMA+7yhb5ks8q3nLbnnpT9GGREwFBUQxBJV4QthcCS8qk/EnSsp/8VztBdLIDDgMkmIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907139; c=relaxed/simple; bh=HZjZ3HcnfJ6Gv1Fz5dnPy/7RL1U8mVqJINJWM79xQHk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rBSgskX64sZ6aZKg1h3v/j5dOWqbIQa8F0eKfEfsmzrIzP9ibEm4/UlZ1CR0rV8i08++Gb/B3gVYpDx+sHgZxdiPoQHhr71U49X/eDN7+c+6HlktFkbxvP5ko5OfJJ36Fsv7bHJz5cfiv29VTVI2Uot7xd4YoVlNUVUsGkY86is= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Oguv7V+F; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nU1F+p/y; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Oguv7V+F"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nU1F+p/y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5VJzg69xakfxW3VOCyLK7wumPwPeLQPf6YPBQqS8knU=; b=Oguv7V+FD4iSnLKWr/XklF6EmEZCH2ap2WbSX62j9azrP0RRRXxoYWPI7++lU/itFKxWTG SqS0LsZGk9RgSGQNccedXo4ruyOAPR8pAnIXApLInVCUYmgN2SvmfX7UA8EoOneFkKV9FI OebKws3tOCGckfov5+vpVaUqQlLlCNY= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-474-QYyD5rmBNPyBz6I3BaiCqA-1; Thu, 08 Jan 2026 16:18:49 -0500 X-MC-Unique: QYyD5rmBNPyBz6I3BaiCqA-1 X-Mimecast-MFC-AGG-ID: QYyD5rmBNPyBz6I3BaiCqA_1767907129 Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-93f568048ccso3911797241.2 for ; Thu, 08 Jan 2026 13:18:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907129; x=1768511929; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5VJzg69xakfxW3VOCyLK7wumPwPeLQPf6YPBQqS8knU=; b=nU1F+p/y73bgp8MsrU3ClW47XRunrquSBp2IITIDobTtgdO11RH5m5VLa2pAPIEh6r X3QjzaR1L+WiHF6iYedekEBAf+sYIRQJgIgHl+d6HJSsZ1nkUG6DMAFzHtpb6gn69XyD JMBQ9KGBrBkmZkmHPkd7xS9NEpxb+sjWyb3TysgGca2pl2J0bsjbgeVnorVYG6pHkx+N tNO1RfdxQBjn0xSwzw25COW9Dz4povKp1ITolDD8201ui19Sx1yAjpWm0MZY+EEFrLxy Fwq2Ga+aptRX588Mz9wjnrnBd9UStCHNmGOfBFMwHVaBZdaS6hRUI1EHQM1/AKvTsPNw bVcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907129; x=1768511929; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5VJzg69xakfxW3VOCyLK7wumPwPeLQPf6YPBQqS8knU=; b=HXQ0pzIgvqln66G8RZ+39J6IDE5fUJQjC8nvZez1SNjNlI7tIKPPSYqQUJmVgi9JYq rwuVSaHmoSy5TlXR1+X5/CAzgD4IKuRlsHqrVE1sXG4YQVdyR6K1hGbY0cWZ7oPCp0dq oXYzraWTWbH8AWkPt2Q/pcLkIkQE1UnI59WH2O6ntNwD1FQG8OukuvGOXAuDat9omlQ3 fZRMTF1zMXXnIL5vj1/XcjV/i3bqW3FfHCQHq+G6QTJzVOfMGBobcwlR51bLDlvv7bQF ewEUtJA9LggYgbLUoztcxYmcIDcN/zlrnBUY0bxBOfeg8rTh9fyVEB6P1Dtw1M6xe7Bu 1dxg== X-Forwarded-Encrypted: i=1; AJvYcCXKKhB+bYgvhvO3Ab3R/XM7k+ext+yy2pRNL3UNNPwtJPP35x0R7zaQnelZSm61htWMIYn3ZtpNbjiz6HI=@vger.kernel.org X-Gm-Message-State: AOJu0YyVnX85E5dvZfxJFhU3dkPUy9lgn1mburnIMAmtV/diyW3SPrzi hdQnVVBaFZPXKkInq9WLPe++yCpdPQ5+rwaG9HEUr1rsMIavoHU/TEo0WjTxosBJu58lQoDeFax hO/iBtsGwzmhtdMxcSsduys9LvSm/vpdf+WiwVzVpOTJkMuqVlOvaS8TpIQQJsBR745l2+L7lIg == X-Gm-Gg: AY/fxX4qp1xogmtO7nIfITC7e9Qmp+2ovCcPeE3x1N3WrHFguhWonJb8MhVnBkZOe79 nCBDaibx1mkjM3QCzuzMHI+5mhuYIC5eCVp5x0Zr+tmnaHWDszsgBwviQhADykhA4k52o8A4Rn4 BnIZB8Mbr0Ao/JMqJ/QiWTgJumF8y1DCVJedSIWRYuGIjG3bWZNH1UCWK3sCGyfRZw4dUbvJ9aD pzL5kSAY3GyXEspbJEJwjE04YxELqQzaGm5eENjMMaTq50SMKRLOov+6IWU3NIT3x0foHiljxMm +7q9xx0lQ5a9aHiVUGYMsjdx2228Ff33XbSorfGP585qirePY5DWNcpNUdyVYXT2bHwsc26q6e8 PUqUZk5EOzZAI91Y= X-Received: by 2002:a67:e105:0:b0:5ed:f26:5615 with SMTP id ada2fe7eead31-5ed0f265843mr1992105137.18.1767907128951; Thu, 08 Jan 2026 13:18:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFLX2O0KlmxzrMSo3tby5b/YZN082iMeszi4qbktrWtgNvTKagIIyv7NxGpAo9E2TfU0DUiFg== X-Received: by 2002:a67:e105:0:b0:5ed:f26:5615 with SMTP id ada2fe7eead31-5ed0f265843mr1992095137.18.1767907128511; Thu, 08 Jan 2026 13:18:48 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:48 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:37 -0500 Subject: [PATCH 19/27] clk: stm32: stm32-core: convert from divider_ro_round_rate() to divider_ro_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-19-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2367; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=HZjZ3HcnfJ6Gv1Fz5dnPy/7RL1U8mVqJINJWM79xQHk=; b=kA0DAAoWt9LdJ11+wIcByyZiAGlgHrmgM6LOwEM19Z0uuBjchVDfhpfoJgJDmN/xDONnYVJb0 4h1BAAWCgAdFiEEpG0ycFhlqj3e3CkEt9LdJ11+wIcFAmlgHrkACgkQt9LdJ11+wIfnBwD/WXtd f9bkMoE+hr+2zc6UAhat71CaYeY1QhFMrePNhoUBAOsjGZioUPoLJfrsd/8VSuM/9DruUEUcARU bPxSu5FkJ X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_ro_round_rate() function is now deprecated, so let's migrate to divider_ro_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: cd1cb38836c0 ("clk: stm32: stm32-core: convert from round_rate() to = determine_rate()") Signed-off-by: Brian Masney --- To: Maxime Coquelin To: Alexandre Torgue Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org --- drivers/clk/stm32/clk-stm32-core.c | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/clk/stm32/clk-stm32-core.c b/drivers/clk/stm32/clk-stm= 32-core.c index 72825b9c36a4d3b8ba3f7615b9026c09ffaf88d1..b95b9c591fda7d900d523f50c8b= d449398aba49f 100644 --- a/drivers/clk/stm32/clk-stm32-core.c +++ b/drivers/clk/stm32/clk-stm32-core.c @@ -369,13 +369,10 @@ static int clk_stm32_divider_determine_rate(struct cl= k_hw *hw, val =3D readl(div->base + divider->offset) >> divider->shift; val &=3D clk_div_mask(divider->width); =20 - req->rate =3D divider_ro_round_rate(hw, req->rate, - &req->best_parent_rate, - divider->table, - divider->width, - divider->flags, val); - - return 0; + return divider_ro_determine_rate(hw, req, + divider->table, + divider->width, + divider->flags, val); } =20 req->rate =3D divider_round_rate_parent(hw, clk_hw_get_parent(hw), @@ -455,14 +452,9 @@ static int clk_stm32_composite_determine_rate(struct c= lk_hw *hw, val =3D readl(composite->base + divider->offset) >> divider->shift; val &=3D clk_div_mask(divider->width); =20 - rate =3D divider_ro_round_rate(hw, req->rate, &req->best_parent_rate, - divider->table, divider->width, divider->flags, - val); - if (rate < 0) - return rate; - - req->rate =3D rate; - return 0; + return divider_ro_determine_rate(hw, req, divider->table, + divider->width, divider->flags, + val); } =20 rate =3D divider_round_rate_parent(hw, clk_hw_get_parent(hw), --=20 2.52.0