From nobody Mon Feb 9 19:05:54 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9A0B338939 for ; Thu, 8 Jan 2026 21:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907124; cv=none; b=bbk5riIZRqrGbiT1ZUQ5xlahlhvvMxMaHcevEw+AMh5C7/csAhR47n2vf3iZfYOk8npkYsxPDY6kUi0d3qejdqeLuRsRpskmu8DwP/S8vpOVS4j+9htaz39Z2radI6hmTW4UDR8S9Qu2YPK5N29MJMLPMprL32zOTOLPKF75kc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907124; c=relaxed/simple; bh=Ge9eXc7hiD/dbOFdwq4ZbwJA1t1aWqrp8YuWJZaaqt8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mq40Eu0lMf4eK0MEvmJiVOoHPqqIbAIk9B5Eohm1Q8xx8hnLi0NyzmG5U8uKNlw9+Rck4GS7GWUoWsdXbQGG9dqUBjM1xJbSMC3zx8WjYWNtF+UrXJEpoCrAwhjkeYp8jyFionC4HtpluZKMdgF2BSHww2SC19C78k96ImdsRFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=evQSZQ/i; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=dk7JtmFF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="evQSZQ/i"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="dk7JtmFF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/fdI4HNVMXpScbiOdWnmJAMr7E0Pkfpku5YlZKipJgA=; b=evQSZQ/iESK9ecNgYaOQz9zcD16Yms+nToPRahPorISktxNc6YhHeAm3H49xi8POvtW6wG lGewxBnjDT125hw+SSRTgl7ETaUV2t6EAHNmULQ5ZxrEh6sTr8x4gu4zbzsMhSoIUdubYd ejY/CvqyZRRJSLj3iu+NQWZKpVh0mU8= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-QewEtVmHNeurHiudeTUiyg-1; Thu, 08 Jan 2026 16:18:37 -0500 X-MC-Unique: QewEtVmHNeurHiudeTUiyg-1 X-Mimecast-MFC-AGG-ID: QewEtVmHNeurHiudeTUiyg_1767907117 Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-93723fdb00fso8141954241.2 for ; Thu, 08 Jan 2026 13:18:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907117; x=1768511917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/fdI4HNVMXpScbiOdWnmJAMr7E0Pkfpku5YlZKipJgA=; b=dk7JtmFFP5awEj8IFFBjujaWbIiRuSFy3fmnM6Wshq62Nc27/dSO0DwnrfappX5Wbr nkW3oB5p4UXxhuAEMtyk8rtX2VDmhsCd18daZFwaViS0bUOvrUzDVV8PlXp9VjNOekk2 MkrLrzp+ruhfhswFMOjh21t1iEdME8nVruw4NSefQN8X/5qukTJIbAD1cFhrLcY4LxjF qAEZcf5CvtU/uJ4+u11lzgtJC1+D1JuiN1hqIpW24H+Xtx7O+lBqdNpKAGxrTyJXYASU Y+J3SPEFfTxEq/YCHP869OtOyQtu/AtEMdlKj9ceeKJ3f0GMcYlTDws/Qm3XwIb+UzPI oaCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907117; x=1768511917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/fdI4HNVMXpScbiOdWnmJAMr7E0Pkfpku5YlZKipJgA=; b=Sr3rUnsU5hdAZKVuue0hcA16K/yfAZBrUjFQMdPr2YJdyAHT3R4bG2XkWrsdgIxLmM 5QDKtwOE8faXjctrKOfLmDEsQUxxjwoWjaridDqTIEV8JM4t+61AVLHJmTmhAAFEa8XY JmvGy7rD1cgaql/zZzI8LGWBxleWjv+eBj+GFQvajIDGQlspuegsLsd555hAOXDHDbwa PWaGFU4ARkWxd1ZWI4RPncLI2UWhYeIQsn6MCRSDzH8r8EmtvRgkPabCv13QImqtGiD3 fdauGYHVtVQYekmCelZqsYGPrtW3NOJ0WhW5nyjBakHr9sH3XCOticG4vsu9vrz6RTJ0 5Zmg== X-Forwarded-Encrypted: i=1; AJvYcCXbDWu+8//FtKUbEnbpKWq1Lia3RAMYwy24J8cMU9w8z50QrcGtzUOPA8OzkHNR0ZKcW2qTunDNtdfM3tk=@vger.kernel.org X-Gm-Message-State: AOJu0YzSRggwPMz+pYuTD09TDiJKENKYW0aF69LLZdlXV03rmY3jcKEh rTUr3gJWSMthl9LGQpvSVS3aNQ/TNu+rdhhCfdIBVpnWhnC0uwnkWFykva8EXxV/H+R35riLHqi PtlpY1AVYez2TvtuWMzqxjNtnFOnnvOT8LglT+moANUGz+7a3+vtEqf0K8QU/al6ziw== X-Gm-Gg: AY/fxX5sfMBKsX1foAztFnZJLX11E6QlC4rU5tDIkdrHVgjn0RvveoXv9jPHhE25vVg b3VcCo8sRXawa4FDZhfrznBqgJFVXIO0XhwsiTCTlK7RVR2kG0ooyUc/oWONml/rj9hEHCWCTY9 sdwosSyG5bhicsMC+Yi2rB1hMx3hhl3Qf3yT+2U8NZ9d98SWAyVNljUkvJ/Pv+HBlwqIsMYzZKC L8hENJS9j8uOwpF7fb8HWIHnBQyjVFsjKbTtI7Mo+fhvDP43/XGQ2sirWJbAxq54eUmf5W3j/nJ wQp27hEmfoPTm2saqif3xykCK1wue1bhtrhI19IjYbiZkIuGvquuhLkNOxNKqIImz+boa6g8Bwe KHmym1PbbOC01Uq4= X-Received: by 2002:a05:6102:161f:b0:5db:ce49:5c71 with SMTP id ada2fe7eead31-5ecb687fccdmr3306763137.18.1767907117138; Thu, 08 Jan 2026 13:18:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqkSY3g2BRFtVH/hTwOCP8SDHCsAmoUI/QIHDt4YAq9tFbNnfPKjO/MN6CStqRG69amOeAKQ== X-Received: by 2002:a05:6102:161f:b0:5db:ce49:5c71 with SMTP id ada2fe7eead31-5ecb687fccdmr3306747137.18.1767907116769; Thu, 08 Jan 2026 13:18:36 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:36 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:35 -0500 Subject: [PATCH 17/27] clk: sophgo: sg2042-clkgen: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-17-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Chen Wang , Inochi Amaoto , sophgo@lists.linux.dev X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2276; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=Ge9eXc7hiD/dbOFdwq4ZbwJA1t1aWqrp8YuWJZaaqt8=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5HaYum9WmXVj6rbsy2f4dzpsW9yyZHPyW24TnwdtH 9OOCC5m7ihlYRDjYpAVU2RZkmtUEJG6yvbeHU0WmDmsTCBDGLg4BWAiFecY/te7KlaaCBU3MLco CP6oUzgTsVrRaPqa01/lfQzZLs5LV2P4p/smNuhbq3RQ/K9CF/ncXdfal2aUnT3y8Ijd1or3m5/ PZgQA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Note that this commit also removes a debugging message that's not really needed. Fixes: 9a3b6993613d ("clk: sophgo: sg2042-clkgen: convert from round_rate()= to determine_rate()") Signed-off-by: Brian Masney --- To: Chen Wang To: Inochi Amaoto Cc: sophgo@lists.linux.dev --- drivers/clk/sophgo/clk-sg2042-clkgen.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/clk/sophgo/clk-sg2042-clkgen.c b/drivers/clk/sophgo/cl= k-sg2042-clkgen.c index 683661b71787c9e5428b168502f6fbb30ea9f7da..9725ac4e050a4e6afd3fd50241f= bd2fc105a31ca 100644 --- a/drivers/clk/sophgo/clk-sg2042-clkgen.c +++ b/drivers/clk/sophgo/clk-sg2042-clkgen.c @@ -180,7 +180,6 @@ static int sg2042_clk_divider_determine_rate(struct clk= _hw *hw, struct clk_rate_request *req) { struct sg2042_divider_clock *divider =3D to_sg2042_clk_divider(hw); - unsigned long ret_rate; u32 bestdiv; =20 /* if read only, just return current value */ @@ -191,17 +190,13 @@ static int sg2042_clk_divider_determine_rate(struct c= lk_hw *hw, bestdiv =3D readl(divider->reg) >> divider->shift; bestdiv &=3D clk_div_mask(divider->width); } - ret_rate =3D DIV_ROUND_UP_ULL((u64)req->best_parent_rate, bestdiv); - } else { - ret_rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, N= ULL, - divider->width, divider->div_flags); - } + req->rate =3D DIV_ROUND_UP_ULL((u64)req->best_parent_rate, bestdiv); =20 - pr_debug("--> %s: divider_round_rate: val =3D %ld\n", - clk_hw_get_name(hw), ret_rate); - req->rate =3D ret_rate; + return 0; + } =20 - return 0; + return divider_determine_rate(hw, req, NULL, divider->width, + divider->div_flags); } =20 static int sg2042_clk_divider_set_rate(struct clk_hw *hw, --=20 2.52.0