From nobody Mon Feb 9 16:19:52 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B40233A706 for ; Thu, 8 Jan 2026 21:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907109; cv=none; b=S4fotA/1YtHi8q7aj2FsgIjVo9JUpCqiT1towscFDyy/YjLThrlM7oWZzPIboIZqC7ei4k3S4wLvVzbH/y9JfVpp47Y9XUE2ELbDTqXTR2Y5t20wBXBK8Ney+NzW0Fqh7q8R4mNFTid3GoIagXPhOsDpCt4mHAh43q7YV6dL79Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907109; c=relaxed/simple; bh=BryXrBazGKNoFl01TDX32keP0bZwmkKqb3aOoVN6Cjw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BmORxL+ky6KU3TMaj7VRPKiTjFHqFGeDmFlvXzcQkqVNgEQVXPzBxrf6Xh+1JrAvTB4+dkA7lzHixpuIMhoVRehYCTVK42quw9EisJVdTcygvD+F6y9djS+bl2st8lx1WR5YfcxTK1O8ihq+ui2E7CovfngopN8Fc62AzK83sQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=K1F2jZpb; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=A5Y3LLcE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K1F2jZpb"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="A5Y3LLcE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H/qg4+psJobyRC37Ow7jCN1m26LSNdI85IDj7JMoxUw=; b=K1F2jZpbWPGsrk3nAq+VCOneORmlLI4CUvro/Ir59vJ4pmILaEvYsmfGg8pMnAXH8MjvRx IIKQ70mGHT3VSrgivgn/kPBJqCPhwCvjknhDZ+euqMd4wRmBf7czJboHs0dBfzwri1m8PX /YocQBxxsYEd6ukiSr+DHYLiM40yY98= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-Vby7DcXWMMSpdDX-EBIW6A-1; Thu, 08 Jan 2026 16:18:20 -0500 X-MC-Unique: Vby7DcXWMMSpdDX-EBIW6A-1 X-Mimecast-MFC-AGG-ID: Vby7DcXWMMSpdDX-EBIW6A_1767907100 Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-94125ded3dbso8225540241.2 for ; Thu, 08 Jan 2026 13:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907100; x=1768511900; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=H/qg4+psJobyRC37Ow7jCN1m26LSNdI85IDj7JMoxUw=; b=A5Y3LLcEKBo8/88MiR/X64CHJc0Nq3ezz3ktt0AP9HDP1akNQg7Le1Y26k+J0sQIke +cYUzucKGrDca3n1+V84+K0LkBaIkvLQpXgbyfJCLnJTL1hJ34nPwugr1E9MnzQIQ2Sf PEKvftSzSPvxQHOcMbvCsUKGDSax/btsUPDQ6MKhPgu/F/FAPQqsCbP1hRtyQCadap2V oumZBuqNHPfotmUHbdINpCDYuT24S8WhEhHdNqnDFNe+4AA9xlgIJS535dqQ/kda5shg E7kYMCgbwXcb+3eJ105dweZ3Bu41HB6JH5sZrs24rr6EdqGI8Jj172gnOPfHRAx2mZiQ 3Nkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907100; x=1768511900; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=H/qg4+psJobyRC37Ow7jCN1m26LSNdI85IDj7JMoxUw=; b=trb3hrtyWaqxyt6bbrAwXx2w87o2vrs7SJZF7oLcyeGbj9WU1EVosmIgEltTEuL5Jc JhE/K/bUwr33MMfpNzjQ0vOvF2oMlDJlYdmIf+jGfGtYfug4Nu0yiQFC3s241gket+mO dLp8l2/8aVZ2Ee9O+4qrj5bqtLIgLy86N37TpMjlI0p4t3kYGxQ3TWRCiii/P2NJsUtq SLjMF/29K6H2/azmtIeR8ig2QOEavi3h3PcFQsn2+mImuxf0UIBH2yoCwNOe1Wf28QEE GhShIdo4ZbCxLjc2dJfvamm21bYtFAia+fVC18ijcXBOKkisQy65wC/zQb+ugMpl/W9w eczg== X-Forwarded-Encrypted: i=1; AJvYcCWFOcrTXHtwM+ddrBwcEKUiNJRZt4nnIv35fd1SBnKWg1Lk59m6T06QC2mGwz92S8WRKeS/WdguySDDyOA=@vger.kernel.org X-Gm-Message-State: AOJu0YwM+X04+MH/JmGo/ZmWPMMCcxvLqrE+2g8fxD6EIJxDWEqdMW5U Nn3VP3NSKFWFsxmIF79Y6EimCuZL9y2+p33+k3DE9N8p6VCFFgUf5SEVbhJWYLrbk9C53PbQOMi n/t3izakAscIYSeOj39VoeNd4uHxgOySAm5D8qyk7aBIosPNFCTyDLAZHqb+BlyZcaG4p1/eRZw == X-Gm-Gg: AY/fxX7WrNaqrhjAgEFdhkbL9zzmEjyjn0q0gCdC4zg78lrKFo5XEGP9hpqGnQH2TfN s79CwD9NxHTjSgjvGlg8sFP6blM5g40bosv9bxSZ1N4MJJtSI+nVOxRamGKrXkzlfvm9O0Xwn/p K1uFuQ51LUa9ZdZgu0i8+PRih11048UydvFfv6P0tSGSL2XY/PkqiQCw7hcrt1S4FwPMo/D8T4j Vb0Cb90mozt8AEWesOpzpYm1h99gVhVYL61lz9TM1zykXe9HPF12f76zqTr02oHqQrY2+oI0TjM ZUnZJWOgpfLBawNgKD9Zm8tarp9zW4XKjuwgwduu4WhsBLzwSsHzIe3Xs/vtlFs8HHh36RNjWzK i+GbUl4S/JTyGzYo= X-Received: by 2002:a05:6102:2d07:b0:5db:e0fe:985c with SMTP id ada2fe7eead31-5ecb6853a90mr2981778137.10.1767907099670; Thu, 08 Jan 2026 13:18:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGeIK3vJESvdFK2LZdGsxL/Aj0lfkI8WxHqP14EuDMLA2/se9dutUiwsxhVFozUz0NuzGHQXA== X-Received: by 2002:a05:6102:2d07:b0:5db:e0fe:985c with SMTP id ada2fe7eead31-5ecb6853a90mr2981772137.10.1767907099246; Thu, 08 Jan 2026 13:18:19 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:18 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:32 -0500 Subject: [PATCH 14/27] clk: qcom: alpha-pll: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-14-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Bjorn Andersson , linux-arm-msm@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2529; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=BryXrBazGKNoFl01TDX32keP0bZwmkKqb3aOoVN6Cjw=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5HZknJGs+KEXnBLBtvTUvuaOoJspXgLnrhuuOMSbU 3hlx5ubHaUsDGJcDLJiiixLco0KIlJX2d67o8kCM4eVCWQIAxenAExEyIaR4fWv0MsCIgdZTz2e EObx/iWTfuKfmKvH9E/s8dWW5DzgsJ/hN9u2j9tqnD6ny3s0ca+om3PS1Vx4stGxtSIhTcenxBm e4QAA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 0e56e3369b60 ("clk: qcom: alpha-pll: convert from round_rate() to de= termine_rate()") Signed-off-by: Brian Masney Reviewed-by: Abel Vesa Reviewed-by: Konrad Dybcio --- To: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org --- drivers/clk/qcom/clk-alpha-pll.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-= pll.c index 6aeba40358c11e44c5f39d15f149d62149393cd3..a84e8bee6534629bf578af6d259= 2ea998f6c9090 100644 --- a/drivers/clk/qcom/clk-alpha-pll.c +++ b/drivers/clk/qcom/clk-alpha-pll.c @@ -1257,11 +1257,8 @@ static int clk_alpha_pll_postdiv_determine_rate(stru= ct clk_hw *hw, else table =3D clk_alpha_div_table; =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - table, pll->width, - CLK_DIVIDER_POWER_OF_TWO); - - return 0; + return divider_determine_rate(hw, req, table, pll->width, + CLK_DIVIDER_POWER_OF_TWO); } =20 static int clk_alpha_pll_postdiv_ro_determine_rate(struct clk_hw *hw, @@ -1617,11 +1614,8 @@ static int clk_trion_pll_postdiv_determine_rate(stru= ct clk_hw *hw, { struct clk_alpha_pll_postdiv *pll =3D to_clk_alpha_pll_postdiv(hw); =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - pll->post_div_table, - pll->width, CLK_DIVIDER_ROUND_CLOSEST); - - return 0; + return divider_determine_rate(hw, req, pll->post_div_table, pll->width, + CLK_DIVIDER_ROUND_CLOSEST); }; =20 static int @@ -1657,11 +1651,8 @@ static int clk_alpha_pll_postdiv_fabia_determine_rat= e(struct clk_hw *hw, { struct clk_alpha_pll_postdiv *pll =3D to_clk_alpha_pll_postdiv(hw); =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - pll->post_div_table, - pll->width, CLK_DIVIDER_ROUND_CLOSEST); - - return 0; + return divider_determine_rate(hw, req, pll->post_div_table, pll->width, + CLK_DIVIDER_ROUND_CLOSEST); } =20 static int clk_alpha_pll_postdiv_fabia_set_rate(struct clk_hw *hw, --=20 2.52.0