From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7170C3358B2 for ; Thu, 8 Jan 2026 21:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907043; cv=none; b=silfsiNw12Zz3cF/fhzWlUVblKkL7mJmgfnsyFMNylHtU6nXBS2ZLxZC0beVimyi3ju+2rSpFtuALLYLhNK6/+mjjr44Bmio/asx3LHAmtozmsdC3WOhaSXGOP3E1ic9yKOMrVslhVeIm61VTdjemq6EA2MeGMuIe75udJ57t4Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907043; c=relaxed/simple; bh=vDAetoqqs6cXCl7bwwNO4+syHzby9vdv3IeOGAXMg98=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Z5H0PSuj+3kpzjHKZX9pXYds5w2BaL9pmPqPCqQgxHBKIeRSjLp9p9bfmC43wFoD4OY6PJ0+4APGHWx5la/fsW2UPKx+xSoQ+9qNPTA6wGpIbYaXEVZyJW/VrfRDUwb3EAIVLlAOrhrEIyga4ZTML8NQz5DLKutEaVOORiqZCxo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SH81vGns; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=tpOH+Ioi; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SH81vGns"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="tpOH+Ioi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XN7FseKUHh/NOjCMySF93+tmLbyPj2jDN7x2b6v0jTM=; b=SH81vGnsdQ5vRGby83uCvi5xbyuJ5rd8SHd0KmWr+IzNE/BJG2evv7WFN0oOF+DSVY7PAE 2VZcW8ZKAovNeLCfsiRc5psFweMXyUhRDvmj/nYbHGkvIEeVB6qzFxpPT8XMQSkFVG+WWk rQpwMwuw6j0+Hql2c3wA5laEoAMyu/U= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-hSCpkSVkOu645qIvsIE94w-1; Thu, 08 Jan 2026 16:17:11 -0500 X-MC-Unique: hSCpkSVkOu645qIvsIE94w-1 X-Mimecast-MFC-AGG-ID: hSCpkSVkOu645qIvsIE94w_1767907030 Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-5eea3cd5a1bso422254137.1 for ; Thu, 08 Jan 2026 13:17:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907030; x=1768511830; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XN7FseKUHh/NOjCMySF93+tmLbyPj2jDN7x2b6v0jTM=; b=tpOH+Ioi8THhRv2MiLe9NX8GuomkPO0/ifap3YJbSIMwMj97J7VCaSFrgcrQpPbWkC INeHvMUNdIQaQg6s8EP79z7reUG0hvFC+5KAvKtb0LwkIqYLhEiDVPBzaMljkNR0LWiy NIwWYg8/j8nQhSxrkKveIiBjJt252G4EvGrjB2UuTSOtGclo7A848Qkx9CY4oeQGSgAb kbEn4J07clLflHk4nnKBzPQGu7EDjevroNIgsteH7mDRuVU8wZELkEZWnHvOo5Ewrh5u ain5gf6tSLr1RRrykY6IW0aapGKQJcAuXsG/Uceevgx8GK3CfkcGy5yPKfGRTcHRRgFv FtWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907030; x=1768511830; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XN7FseKUHh/NOjCMySF93+tmLbyPj2jDN7x2b6v0jTM=; b=QF6h0cvqHq+euAp9u4Km5HF2Z9hUJK1M8W2/ewSlHEvf4w5JxqmsPoXil4XKa0Tv3D zyCwueWJ7OI6785xpmKfO54uKeW1EisZbKQKJCz58QXpeMJEGFpQcIsU6yRaCtcb4R2k SxN/zRBn8291EK/80ZGs170v5JRRcyTnk0WEvwzZDpJfs3Z3SLmThKs2Ttiur34CdMJr uP9168d3zupD2QC1n43tJIvdlIe7S70qE1I+x09Fmknd7rr0L40NccT16EYrJC1cxvCY fDPG+Mn4pec76WblfR8x6MpEYN8R+ixbjnLLtIpi0hr1a7fd9AxMRGFqVj7cUhR5XhzT hD3Q== X-Forwarded-Encrypted: i=1; AJvYcCWTvsV5+G5TUWjDoQcXwuNkjyJ0vmGS2YAugXhe32CvNfteUEiG73QBxc97R4TtQ0WAjryQibb/7VDuDOk=@vger.kernel.org X-Gm-Message-State: AOJu0YxW9sYzFDm5RrNdAboAIZ6yvxCxdikxS1euOaJY8ifvDi0ZPVol UzdXnkpQqF/VfJgEjC2jWakzz13EcoLU+EFhFQJHjveDmgPiJAf+9SeRq0njDQxd5ts2WDueKjo urUCz9tOYOME780fFSwgGD4oIGsGeDr7TfOwx8srqSKn89mRiff33jdg4zpAksqacEg== X-Gm-Gg: AY/fxX58USFFa+K6dnpUj04BeKCfzWYhkhg7Bbc50tHnGxqOzTlwoCtj4+EcINUDHc0 0pv5ktUNreF7jupNe7G5srwQ4UwycjST9KqVEByRKuIxwkTsDFEChXNGfhsm7BVMeCBue0JHMxk DPCt5nCeHR88j9CmcqMs0HgIKng0DMO938jnMqjkMvRvaqmaIOnTMiVuoOZAI5ZpV1BLAb/is+y 4uoyVbBHL6J2S4sr5Z5aPzQrgsHupjvIVSjAWnRdL8mC2xHbhaFbTUAwvtvskfD3O2as50t5bof 1V0K1Ol32UGJdAyjYaO2DMDS6UiwarcIiy69v9KhGTZKDYFz2QntayW9Or9eTO+L12dilmfyH99 HpDhssiJpr+7kWDs= X-Received: by 2002:a05:6102:3a0e:b0:5db:e0e6:1b47 with SMTP id ada2fe7eead31-5ecb687e38dmr2866212137.19.1767907030343; Thu, 08 Jan 2026 13:17:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFAuo8P1DVVYLEUFmVagZkpaMAOpF5fYSBa0FJUBbxBObMth/Sozaer46fZbr04KdGAsepD+g== X-Received: by 2002:a05:6102:3a0e:b0:5db:e0e6:1b47 with SMTP id ada2fe7eead31-5ecb687e38dmr2866203137.19.1767907029839; Thu, 08 Jan 2026 13:17:09 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:17:09 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:19 -0500 Subject: [PATCH 01/27] clk: sophgo: cv18xx-ip: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-1-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Chen Wang , Inochi Amaoto , sophgo@lists.linux.dev X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=10331; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=vDAetoqqs6cXCl7bwwNO4+syHzby9vdv3IeOGAXMg98=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5LaaVEnvkj5atqHg3IzVzbXxV6+EspR37K3jPvw0a nXaK/WzHaUsDGJcDLJiiixLco0KIlJX2d67o8kCM4eVCWQIAxenAEzkERsjw5H7TTetW69lqOfd ed94M5n9zoRlsU0eJ0P3rvogdSLDS4HhJ+PZ5Cmlm68ynBJ5v9jEfV6eHd+5hUc31HuuiwmY83a WOCMA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Also go ahead and convert all of the driver from round rate type to determine rate that accepts a 'struct clk_rate_request' to simplify the overall driver code. Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- To: Chen Wang To: Inochi Amaoto Cc: sophgo@lists.linux.dev --- drivers/clk/sophgo/clk-cv18xx-ip.c | 154 ++++++++++++++++++++-------------= ---- 1 file changed, 85 insertions(+), 69 deletions(-) diff --git a/drivers/clk/sophgo/clk-cv18xx-ip.c b/drivers/clk/sophgo/clk-cv= 18xx-ip.c index c2b58faf0938b7d537dc3a81aef59c549b9c9c79..e936e315400393662a24e0d0189= f7f74e01fa586 100644 --- a/drivers/clk/sophgo/clk-cv18xx-ip.c +++ b/drivers/clk/sophgo/clk-cv18xx-ip.c @@ -152,28 +152,27 @@ static u32 div_helper_get_clockdiv(struct cv1800_clk_= common *common, return clockdiv; } =20 -static u32 div_helper_round_rate(struct cv1800_clk_regfield *div, - struct clk_hw *hw, struct clk_hw *parent, - unsigned long rate, unsigned long *prate) +static int div_helper_determine_rate(struct cv1800_clk_regfield *div, + struct clk_hw *hw, + struct clk_rate_request *req) { if (div->width =3D=3D 0) { if (div->initval <=3D 0) - return DIV_ROUND_UP_ULL(*prate, 1); + req->rate =3D DIV_ROUND_UP_ULL(req->best_parent_rate, 1); else - return DIV_ROUND_UP_ULL(*prate, div->initval); + req->rate =3D DIV_ROUND_UP_ULL(req->best_parent_rate, div->initval); + + return 0; } =20 - return divider_round_rate_parent(hw, parent, rate, prate, NULL, - div->width, div->flags); + return divider_determine_rate(hw, req, NULL, div->width, div->flags); } =20 -static long div_round_rate(struct clk_hw *parent, unsigned long *parent_ra= te, - unsigned long rate, int id, void *data) +static int do_div_determine_rate(struct clk_rate_request *req, int id, voi= d *data) { struct cv1800_clk_div *div =3D data; =20 - return div_helper_round_rate(&div->div, &div->common.hw, parent, - rate, parent_rate); + return div_helper_determine_rate(&div->div, &div->common.hw, req); } =20 static bool div_is_better_rate(struct cv1800_clk_common *common, @@ -188,53 +187,60 @@ static bool div_is_better_rate(struct cv1800_clk_comm= on *common, =20 static int mux_helper_determine_rate(struct cv1800_clk_common *common, struct clk_rate_request *req, - long (*round)(struct clk_hw *, - unsigned long *, - unsigned long, - int, - void *), + int (*round)(struct clk_rate_request *, + int, + void *), void *data) { unsigned long best_parent_rate =3D 0, best_rate =3D 0; struct clk_hw *best_parent, *hw =3D &common->hw; unsigned int i; + int ret; =20 if (clk_hw_get_flags(hw) & CLK_SET_RATE_NO_REPARENT) { - unsigned long adj_parent_rate; + struct clk_rate_request tmp_req =3D *req; =20 best_parent =3D clk_hw_get_parent(hw); - best_parent_rate =3D clk_hw_get_rate(best_parent); + tmp_req.best_parent_hw =3D best_parent; + tmp_req.best_parent_rate =3D clk_hw_get_rate(best_parent); =20 - best_rate =3D round(best_parent, &adj_parent_rate, - req->rate, -1, data); + ret =3D round(&tmp_req, -1, data); + if (ret) + return ret; + + best_parent_rate =3D tmp_req.best_parent_rate; + best_rate =3D tmp_req.rate; =20 goto find; } =20 for (i =3D 0; i < clk_hw_get_num_parents(hw); i++) { - unsigned long tmp_rate, parent_rate; + struct clk_rate_request tmp_req =3D *req; struct clk_hw *parent; =20 parent =3D clk_hw_get_parent_by_index(hw, i); if (!parent) continue; =20 - parent_rate =3D clk_hw_get_rate(parent); + tmp_req.best_parent_hw =3D parent; + tmp_req.best_parent_rate =3D clk_hw_get_rate(parent); =20 - tmp_rate =3D round(parent, &parent_rate, req->rate, i, data); + ret =3D round(&tmp_req, i, data); + if (ret) + continue; =20 - if (tmp_rate =3D=3D req->rate) { + if (tmp_req.rate =3D=3D req->rate) { best_parent =3D parent; - best_parent_rate =3D parent_rate; - best_rate =3D tmp_rate; + best_parent_rate =3D tmp_req.best_parent_rate; + best_rate =3D tmp_req.rate; goto find; } =20 if (div_is_better_rate(common, req->rate, - tmp_rate, best_rate)) { + tmp_req.rate, best_rate)) { best_parent =3D parent; - best_parent_rate =3D parent_rate; - best_rate =3D tmp_rate; + best_parent_rate =3D tmp_req.best_parent_rate; + best_rate =3D tmp_req.rate; } } =20 @@ -254,7 +260,7 @@ static int div_determine_rate(struct clk_hw *hw, struct cv1800_clk_div *div =3D hw_to_cv1800_clk_div(hw); =20 return mux_helper_determine_rate(&div->common, req, - div_round_rate, div); + do_div_determine_rate, div); } =20 static unsigned long div_recalc_rate(struct clk_hw *hw, @@ -301,24 +307,28 @@ hw_to_cv1800_clk_bypass_div(struct clk_hw *hw) return container_of(div, struct cv1800_clk_bypass_div, div); } =20 -static long bypass_div_round_rate(struct clk_hw *parent, - unsigned long *parent_rate, - unsigned long rate, int id, void *data) +static int do_bypass_div_determine_rate(struct clk_rate_request *req, int = id, + void *data) { struct cv1800_clk_bypass_div *div =3D data; =20 if (id =3D=3D -1) { - if (cv1800_clk_checkbit(&div->div.common, &div->bypass)) - return *parent_rate; - else - return div_round_rate(parent, parent_rate, rate, - -1, &div->div); + if (cv1800_clk_checkbit(&div->div.common, &div->bypass)) { + req->rate =3D req->best_parent_rate; + + return 0; + } + + return do_div_determine_rate(req, -1, &div->div); } =20 - if (id =3D=3D 0) - return *parent_rate; + if (id =3D=3D 0) { + req->rate =3D req->best_parent_rate; + + return 0; + } =20 - return div_round_rate(parent, parent_rate, rate, id - 1, &div->div); + return do_div_determine_rate(req, id - 1, &div->div); } =20 static int bypass_div_determine_rate(struct clk_hw *hw, @@ -327,7 +337,7 @@ static int bypass_div_determine_rate(struct clk_hw *hw, struct cv1800_clk_bypass_div *div =3D hw_to_cv1800_clk_bypass_div(hw); =20 return mux_helper_determine_rate(&div->div.common, req, - bypass_div_round_rate, div); + do_bypass_div_determine_rate, div); } =20 static unsigned long bypass_div_recalc_rate(struct clk_hw *hw, @@ -414,13 +424,11 @@ static int mux_is_enabled(struct clk_hw *hw) return cv1800_clk_checkbit(&mux->common, &mux->gate); } =20 -static long mux_round_rate(struct clk_hw *parent, unsigned long *parent_ra= te, - unsigned long rate, int id, void *data) +static int do_mux_determine_rate(struct clk_rate_request *req, int id, voi= d *data) { struct cv1800_clk_mux *mux =3D data; =20 - return div_helper_round_rate(&mux->div, &mux->common.hw, parent, - rate, parent_rate); + return div_helper_determine_rate(&mux->div, &mux->common.hw, req); } =20 static int mux_determine_rate(struct clk_hw *hw, @@ -429,7 +437,7 @@ static int mux_determine_rate(struct clk_hw *hw, struct cv1800_clk_mux *mux =3D hw_to_cv1800_clk_mux(hw); =20 return mux_helper_determine_rate(&mux->common, req, - mux_round_rate, mux); + do_mux_determine_rate, mux); } =20 static unsigned long mux_recalc_rate(struct clk_hw *hw, @@ -512,24 +520,28 @@ hw_to_cv1800_clk_bypass_mux(struct clk_hw *hw) return container_of(mux, struct cv1800_clk_bypass_mux, mux); } =20 -static long bypass_mux_round_rate(struct clk_hw *parent, - unsigned long *parent_rate, - unsigned long rate, int id, void *data) +static int do_bypass_mux_determine_rate(struct clk_rate_request *req, int = id, + void *data) { struct cv1800_clk_bypass_mux *mux =3D data; =20 if (id =3D=3D -1) { - if (cv1800_clk_checkbit(&mux->mux.common, &mux->bypass)) - return *parent_rate; - else - return mux_round_rate(parent, parent_rate, rate, - -1, &mux->mux); + if (cv1800_clk_checkbit(&mux->mux.common, &mux->bypass)) { + req->rate =3D req->best_parent_rate; + + return 0; + } + + return do_mux_determine_rate(req, -1, &mux->mux); } =20 - if (id =3D=3D 0) - return *parent_rate; + if (id =3D=3D 0) { + req->rate =3D req->best_parent_rate; + + return 0; + } =20 - return mux_round_rate(parent, parent_rate, rate, id - 1, &mux->mux); + return do_mux_determine_rate(req, id - 1, &mux->mux); } =20 static int bypass_mux_determine_rate(struct clk_hw *hw, @@ -538,7 +550,7 @@ static int bypass_mux_determine_rate(struct clk_hw *hw, struct cv1800_clk_bypass_mux *mux =3D hw_to_cv1800_clk_bypass_mux(hw); =20 return mux_helper_determine_rate(&mux->mux.common, req, - bypass_mux_round_rate, mux); + do_bypass_mux_determine_rate, mux); } =20 static unsigned long bypass_mux_recalc_rate(struct clk_hw *hw, @@ -639,27 +651,31 @@ static int mmux_is_enabled(struct clk_hw *hw) return cv1800_clk_checkbit(&mmux->common, &mmux->gate); } =20 -static long mmux_round_rate(struct clk_hw *parent, unsigned long *parent_r= ate, - unsigned long rate, int id, void *data) +static int do_mmux_determine_rate(struct clk_rate_request *req, int id, vo= id *data) { struct cv1800_clk_mmux *mmux =3D data; s8 div_id; =20 if (id =3D=3D -1) { - if (cv1800_clk_checkbit(&mmux->common, &mmux->bypass)) - return *parent_rate; + if (cv1800_clk_checkbit(&mmux->common, &mmux->bypass)) { + req->rate =3D req->best_parent_rate; + + return 0; + } =20 id =3D mmux_get_parent_id(mmux); } =20 div_id =3D mmux->parent2sel[id]; =20 - if (div_id < 0) - return *parent_rate; + if (div_id < 0) { + req->rate =3D req->best_parent_rate; + + return 0; + } =20 - return div_helper_round_rate(&mmux->div[div_id], - &mmux->common.hw, parent, - rate, parent_rate); + return div_helper_determine_rate(&mmux->div[div_id], &mmux->common.hw, + req); } =20 static int mmux_determine_rate(struct clk_hw *hw, @@ -668,7 +684,7 @@ static int mmux_determine_rate(struct clk_hw *hw, struct cv1800_clk_mmux *mmux =3D hw_to_cv1800_clk_mmux(hw); =20 return mux_helper_determine_rate(&mmux->common, req, - mmux_round_rate, mmux); + do_mmux_determine_rate, mmux); } =20 static unsigned long mmux_recalc_rate(struct clk_hw *hw, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0606F33437B for ; Thu, 8 Jan 2026 21:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907049; cv=none; b=GcZpYn0VVXDsqodmIUSGK+O3Sb/5QjR29oXG3xxqnxR3FPdDnVtpn8ZfSLMPC8+GK3BmmyUu8uZtWbk/BLyeUTs0oablUgmy8zXV1nelNLvlIRi7OxM88dPyAbIlsnZ0NEkt+PwmMKx4UdGJT2mTsGMkysCpTBwyGnly55qAMbc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907049; c=relaxed/simple; bh=3zRP30fGHCdFEy8G2kANYis3hdN+Sxu8ZaRLGWZxIhQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oDsJT4ux3s1WPLJB0oSJbY1CiXMH7TvzhkTaZQ7KeN41qk6GpXP7F/vCQ6JAsw9Y4YhPqYJm159sl+qpjPGfAcgSkOgkcih7HqenG90sgxcQ9iGYa8OufgkWTRh3DKbS/NYvZVWsJVOO8IRRXq+pn2aaVeqCLlUGmLBjgzxD6VY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SVQ38/+6; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=ckOz3j0Z; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SVQ38/+6"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="ckOz3j0Z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=raRHT5WnuULt1ZgYEopiIagMqGInX7Y1nhkVtkDwgRw=; b=SVQ38/+65sRBFHI67JVqctYlcR2qzOi9lvtkPY6x+E0lZDQPM6/Fl3oLn1kj9iRDmzeqw+ Xo/WoAgiybseVhTYkWs0wYhA/dHKzwxi/S/FFhmuL8jaXiQABl9/uiEIcv3qPJfNlRXZ4Y o7SuG/6bZoqXcgOsYt7PrxeCx3M8UQA= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-232-Nf6siaTdMRCnPYTQPgNLgQ-1; Thu, 08 Jan 2026 16:17:17 -0500 X-MC-Unique: Nf6siaTdMRCnPYTQPgNLgQ-1 X-Mimecast-MFC-AGG-ID: Nf6siaTdMRCnPYTQPgNLgQ_1767907037 Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-5eede4bf7beso362103137.2 for ; Thu, 08 Jan 2026 13:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907037; x=1768511837; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=raRHT5WnuULt1ZgYEopiIagMqGInX7Y1nhkVtkDwgRw=; b=ckOz3j0ZXjgqNve3qsE00viyFbaz6WJECLZIrXa2caxLfNedo8QPAMknWfXehN4zA7 PVil+1VEghj5V6G8fnPWknFMhgQ0y8m2CFV4Dtbr+TPNI9fb58Z+jc0yL1LLjTbPjtSa 60s1QgGZ9/Egm9cmGwRUDlh/ikwuvsLGmslEqqwKvxpuG0BOKlO0NqEprZTiqdHZ7niC z2rL8pgcMSm6Bq0DWNUnY7XwzgmyRvh2audw8vjktJpqevIpFE7GZbsiTuCTQrA6fON4 kWqS4XiRfc1wrOUbZMfITK+3c294d5XgshC/U3LgdMQ/KQyRxjtDOwqheWqCG/DE/VKL K/7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907037; x=1768511837; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=raRHT5WnuULt1ZgYEopiIagMqGInX7Y1nhkVtkDwgRw=; b=WM7gA2STQi67L8YcsVg9FfZErJ6fEQriH0JJ0a+p4wOPUTKkbuPW/30ejE0ODHlUty f211VovVakMyGG6oHp3khcJqiwdxHVfco0rs6qeiU43wNYk/FBz93PAbddx8RhWYLuvi EQuUHOMKeuI2LS1JMSkp/iaypaieUfWfPoCyMNmUF0MMXx8SGGSjtH6FD5hw/82L6AHq +8kYN/z0Zws/qHqseE/S2O+b9KGw5TqyX42qpeQbGHC3KI+CulM9zgM/TEL3ocIruB1Q TddB5PxLPx1INl1yW5AFyBPVFH6ntwYOSvY/R2hlRtGP1LrxUVvcvAUgIdCW6WikvId6 j7qA== X-Forwarded-Encrypted: i=1; AJvYcCX96c5H2XeRj000/6wFb/j9m/GIJ8SfISZXn6/ZKc6JoUm+m9c3BGL6L98HK+oECCz+ELNoiFL6FMRTUuc=@vger.kernel.org X-Gm-Message-State: AOJu0YxYnMJTUSsqi1VbwbAsSUZdAR50p0G6gJlrqoCik8yY1CMCxaRj kbV+T/zFGJBA5/z063HS3I7khnJTwNoa+0iJZPWkdx+4mVLJXmcs0AbjH6RGTcWjoEP5VOIrGUX 3dh2bfUhSdSaB04yLwRr1qI6YixHsXj3sM7kDzg5A/jEaMCAj+/GLfzCb2/nBkqUBow== X-Gm-Gg: AY/fxX6Abt1fQ73isY1/tHtsgwu1/nwwWoA+wvXTmjSyCw0UFlX5P7PcoGVhFhpkR1E g2JZyZuua0Ae3txgClt0a3lOBf+zhV0Pbmn8XCPmzm0PDD0Li7Ys90+QKNDvZ1hFHFijzJZSlBY F4PpKvcVcivaQ5pJlKuQy61GkwDotfNUMhxHMV5fWvEfmuyloCs9tYPR/7Fi/mgAcOKREP4+EFG 0xSnlmk33EZtcLjqFjO3PUxnDhDVP9uKQ5M2MlDKJfZxcl/IQv8iBcU/WfQa6ZvR5Q6k4aaM5iH J3Iai3Zy6izRCskKegh9sfZ+Kv9qbkLQ9Kg3iZpua/toeXEKrxDPJv+8vGz20Z6sQOo0v3m+Nns rAtKWOTg5doMcHFs= X-Received: by 2002:a05:6102:cc8:b0:5db:e32d:a3f4 with SMTP id ada2fe7eead31-5ecb5cb9399mr3364024137.2.1767907036615; Thu, 08 Jan 2026 13:17:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmHji8qpki9wdGlac1NUaaS92iNEPZxoc6SlN6mMqQXlfbPB9E4nsCuXLG4wlMPy3zayxjlw== X-Received: by 2002:a05:6102:cc8:b0:5db:e32d:a3f4 with SMTP id ada2fe7eead31-5ecb5cb9399mr3364013137.2.1767907036197; Thu, 08 Jan 2026 13:17:16 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:17:15 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:20 -0500 Subject: [PATCH 02/27] clk: sunxi-ng: convert from divider_round_rate_parent() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-2-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Chen-Yu Tsai , Maxime Ripard , Jernej Skrabec , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=13075; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=3zRP30fGHCdFEy8G2kANYis3hdN+Sxu8ZaRLGWZxIhQ=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5LaunTJPPLi89OIZoffbVshMiGn9+XnXM251xXLJE /VCFlHMHaUsDGJcDLJiiixLco0KIlJX2d67o8kCM4eVCWQIAxenAEykp4rhn1KLNevdFQ1ueZsL b6V67jtq9CXhQnKU02uegOcyV98ziDEyfJeJYlAK/+86p2D78837fnptT2GXyd0eoCf0K/l90T1 TPgA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate_parent() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Also go ahead and convert all of the driver from round rate type to determine rate that accepts a 'struct clk_rate_request' to simplify the overall driver code. Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! Acked-by: Chen-Yu Tsai --- To: Chen-Yu Tsai To: Maxime Ripard To: Jernej Skrabec To: Samuel Holland Cc: linux-arm-kernel@lists.infradead.org Cc: linux-sunxi@lists.linux.dev --- drivers/clk/sunxi-ng/ccu_div.c | 25 ++++++++++----------- drivers/clk/sunxi-ng/ccu_mp.c | 26 +++++++++++----------- drivers/clk/sunxi-ng/ccu_mult.c | 16 +++++++------- drivers/clk/sunxi-ng/ccu_mux.c | 49 +++++++++++++++++++++++++------------= ---- drivers/clk/sunxi-ng/ccu_mux.h | 8 +++---- drivers/clk/sunxi-ng/ccu_nkm.c | 25 +++++++++++---------- 6 files changed, 79 insertions(+), 70 deletions(-) diff --git a/drivers/clk/sunxi-ng/ccu_div.c b/drivers/clk/sunxi-ng/ccu_div.c index 916d6da6d8a3b29240e086eaebbbc620346eef91..62d680ccb524b39d54f0e908c79= 736f0619f1b4b 100644 --- a/drivers/clk/sunxi-ng/ccu_div.c +++ b/drivers/clk/sunxi-ng/ccu_div.c @@ -10,26 +10,25 @@ #include "ccu_gate.h" #include "ccu_div.h" =20 -static unsigned long ccu_div_round_rate(struct ccu_mux_internal *mux, - struct clk_hw *parent, - unsigned long *parent_rate, - unsigned long rate, - void *data) +static int ccu_div_determine_rate_helper(struct ccu_mux_internal *mux, + struct clk_rate_request *req, + void *data) { struct ccu_div *cd =3D data; + int ret; =20 if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate *=3D cd->fixed_post_div; + req->rate *=3D cd->fixed_post_div; =20 - rate =3D divider_round_rate_parent(&cd->common.hw, parent, - rate, parent_rate, - cd->div.table, cd->div.width, - cd->div.flags); + ret =3D divider_determine_rate(&cd->common.hw, req, cd->div.table, + cd->div.width, cd->div.flags); + if (ret) + return ret; =20 if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate /=3D cd->fixed_post_div; + req->rate /=3D cd->fixed_post_div; =20 - return rate; + return 0; } =20 static void ccu_div_disable(struct clk_hw *hw) @@ -82,7 +81,7 @@ static int ccu_div_determine_rate(struct clk_hw *hw, struct ccu_div *cd =3D hw_to_ccu_div(hw); =20 return ccu_mux_helper_determine_rate(&cd->common, &cd->mux, - req, ccu_div_round_rate, cd); + req, ccu_div_determine_rate_helper, cd); } =20 static int ccu_div_set_rate(struct clk_hw *hw, unsigned long rate, diff --git a/drivers/clk/sunxi-ng/ccu_mp.c b/drivers/clk/sunxi-ng/ccu_mp.c index 4221b1888b38da22c16c90796abe6ffab9dc6291..7cdb0eedc69b53aacc8bfb54e30= 9f2013821377b 100644 --- a/drivers/clk/sunxi-ng/ccu_mp.c +++ b/drivers/clk/sunxi-ng/ccu_mp.c @@ -103,11 +103,9 @@ static unsigned long ccu_mp_find_best_with_parent_adj(= struct clk_hw *hw, return best_rate; } =20 -static unsigned long ccu_mp_round_rate(struct ccu_mux_internal *mux, - struct clk_hw *hw, - unsigned long *parent_rate, - unsigned long rate, - void *data) +static int ccu_mp_determine_rate_helper(struct ccu_mux_internal *mux, + struct clk_rate_request *req, + void *data) { struct ccu_mp *cmp =3D data; unsigned int max_m, max_p; @@ -115,7 +113,7 @@ static unsigned long ccu_mp_round_rate(struct ccu_mux_i= nternal *mux, bool shift =3D true; =20 if (cmp->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate *=3D cmp->fixed_post_div; + req->rate *=3D cmp->fixed_post_div; =20 if (cmp->common.features & CCU_FEATURE_DUAL_DIV) shift =3D false; @@ -127,17 +125,19 @@ static unsigned long ccu_mp_round_rate(struct ccu_mux= _internal *mux, max_p =3D cmp->p.max ?: 1 << cmp->p.width; =20 if (!clk_hw_can_set_rate_parent(&cmp->common.hw)) { - rate =3D ccu_mp_find_best(*parent_rate, rate, max_m, max_p, shift, - &m, &p); + req->rate =3D ccu_mp_find_best(req->best_parent_rate, req->rate, + max_m, max_p, shift, &m, &p); } else { - rate =3D ccu_mp_find_best_with_parent_adj(hw, parent_rate, rate, - max_m, max_p, shift); + req->rate =3D ccu_mp_find_best_with_parent_adj(req->best_parent_hw, + &req->best_parent_rate, + req->rate, max_m, max_p, + shift); } =20 if (cmp->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate /=3D cmp->fixed_post_div; + req->rate /=3D cmp->fixed_post_div; =20 - return rate; + return 0; } =20 static void ccu_mp_disable(struct clk_hw *hw) @@ -201,7 +201,7 @@ static int ccu_mp_determine_rate(struct clk_hw *hw, struct ccu_mp *cmp =3D hw_to_ccu_mp(hw); =20 return ccu_mux_helper_determine_rate(&cmp->common, &cmp->mux, - req, ccu_mp_round_rate, cmp); + req, ccu_mp_determine_rate_helper, cmp); } =20 static int ccu_mp_set_rate(struct clk_hw *hw, unsigned long rate, diff --git a/drivers/clk/sunxi-ng/ccu_mult.c b/drivers/clk/sunxi-ng/ccu_mul= t.c index 8d5720f3dec1d4eb34bf22166277fdf5a270da42..3fc81e7de6e93d3b8efa1debe08= 566860617c166 100644 --- a/drivers/clk/sunxi-ng/ccu_mult.c +++ b/drivers/clk/sunxi-ng/ccu_mult.c @@ -29,11 +29,9 @@ static void ccu_mult_find_best(unsigned long parent, uns= igned long rate, mult->mult =3D _mult; } =20 -static unsigned long ccu_mult_round_rate(struct ccu_mux_internal *mux, - struct clk_hw *parent, - unsigned long *parent_rate, - unsigned long rate, - void *data) +static int ccu_mult_determine_rate_helper(struct ccu_mux_internal *mux, + struct clk_rate_request *req, + void *data) { struct ccu_mult *cm =3D data; struct _ccu_mult _cm; @@ -45,9 +43,11 @@ static unsigned long ccu_mult_round_rate(struct ccu_mux_= internal *mux, else _cm.max =3D (1 << cm->mult.width) + cm->mult.offset - 1; =20 - ccu_mult_find_best(*parent_rate, rate, &_cm); + ccu_mult_find_best(req->best_parent_rate, req->rate, &_cm); =20 - return *parent_rate * _cm.mult; + req->rate =3D req->best_parent_rate * _cm.mult; + + return 0; } =20 static void ccu_mult_disable(struct clk_hw *hw) @@ -97,7 +97,7 @@ static int ccu_mult_determine_rate(struct clk_hw *hw, struct ccu_mult *cm =3D hw_to_ccu_mult(hw); =20 return ccu_mux_helper_determine_rate(&cm->common, &cm->mux, - req, ccu_mult_round_rate, cm); + req, ccu_mult_determine_rate_helper, cm); } =20 static int ccu_mult_set_rate(struct clk_hw *hw, unsigned long rate, diff --git a/drivers/clk/sunxi-ng/ccu_mux.c b/drivers/clk/sunxi-ng/ccu_mux.c index 74f9e98a5d355d6a26b1655c25e9e48da1f6f10d..766f27cff748edca73ccee610ce= 1e814600e6404 100644 --- a/drivers/clk/sunxi-ng/ccu_mux.c +++ b/drivers/clk/sunxi-ng/ccu_mux.c @@ -79,41 +79,46 @@ static unsigned long ccu_mux_helper_unapply_prediv(stru= ct ccu_common *common, int ccu_mux_helper_determine_rate(struct ccu_common *common, struct ccu_mux_internal *cm, struct clk_rate_request *req, - unsigned long (*round)(struct ccu_mux_internal *, - struct clk_hw *, - unsigned long *, - unsigned long, - void *), + int (*round)(struct ccu_mux_internal *, + struct clk_rate_request *, + void *), void *data) { unsigned long best_parent_rate =3D 0, best_rate =3D 0; struct clk_hw *best_parent, *hw =3D &common->hw; unsigned int i; + int ret; =20 if (clk_hw_get_flags(hw) & CLK_SET_RATE_NO_REPARENT) { - unsigned long adj_parent_rate; + struct clk_rate_request adj_req =3D *req; =20 best_parent =3D clk_hw_get_parent(hw); best_parent_rate =3D clk_hw_get_rate(best_parent); - adj_parent_rate =3D ccu_mux_helper_apply_prediv(common, cm, -1, - best_parent_rate); =20 - best_rate =3D round(cm, best_parent, &adj_parent_rate, - req->rate, data); + adj_req.best_parent_hw =3D best_parent; + adj_req.best_parent_rate =3D ccu_mux_helper_apply_prediv(common, cm, -1, + best_parent_rate); + + ret =3D round(cm, &adj_req, data); + if (ret) + return ret; + + best_rate =3D adj_req.rate; =20 /* - * adj_parent_rate might have been modified by our clock. + * best_parent_rate might have been modified by our clock. * Unapply the pre-divider if there's one, and give * the actual frequency the parent needs to run at. */ best_parent_rate =3D ccu_mux_helper_unapply_prediv(common, cm, -1, - adj_parent_rate); + adj_req.best_parent_rate); =20 goto out; } =20 for (i =3D 0; i < clk_hw_get_num_parents(hw); i++) { - unsigned long tmp_rate, parent_rate; + struct clk_rate_request tmp_req =3D *req; + unsigned long parent_rate; struct clk_hw *parent; =20 parent =3D clk_hw_get_parent_by_index(hw, i); @@ -123,7 +128,12 @@ int ccu_mux_helper_determine_rate(struct ccu_common *c= ommon, parent_rate =3D ccu_mux_helper_apply_prediv(common, cm, i, clk_hw_get_rate(parent)); =20 - tmp_rate =3D round(cm, parent, &parent_rate, req->rate, data); + tmp_req.best_parent_hw =3D parent; + tmp_req.best_parent_rate =3D parent_rate; + + ret =3D round(cm, &tmp_req, data); + if (ret) + continue; =20 /* * parent_rate might have been modified by our clock. @@ -131,16 +141,17 @@ int ccu_mux_helper_determine_rate(struct ccu_common *= common, * the actual frequency the parent needs to run at. */ parent_rate =3D ccu_mux_helper_unapply_prediv(common, cm, i, - parent_rate); - if (tmp_rate =3D=3D req->rate) { + tmp_req.best_parent_rate); + + if (tmp_req.rate =3D=3D req->rate) { best_parent =3D parent; best_parent_rate =3D parent_rate; - best_rate =3D tmp_rate; + best_rate =3D tmp_req.rate; goto out; } =20 - if (ccu_is_better_rate(common, req->rate, tmp_rate, best_rate)) { - best_rate =3D tmp_rate; + if (ccu_is_better_rate(common, req->rate, tmp_req.rate, best_rate)) { + best_rate =3D tmp_req.rate; best_parent_rate =3D parent_rate; best_parent =3D parent; } diff --git a/drivers/clk/sunxi-ng/ccu_mux.h b/drivers/clk/sunxi-ng/ccu_mux.h index eb1172ebbd94b5e3515f618390a4753c7eb5be4d..c94a4bde5d01604ac2b317babd4= 368151d0d08ab 100644 --- a/drivers/clk/sunxi-ng/ccu_mux.h +++ b/drivers/clk/sunxi-ng/ccu_mux.h @@ -137,11 +137,9 @@ unsigned long ccu_mux_helper_apply_prediv(struct ccu_c= ommon *common, int ccu_mux_helper_determine_rate(struct ccu_common *common, struct ccu_mux_internal *cm, struct clk_rate_request *req, - unsigned long (*round)(struct ccu_mux_internal *, - struct clk_hw *, - unsigned long *, - unsigned long, - void *), + int (*round)(struct ccu_mux_internal *, + struct clk_rate_request *, + void *), void *data); u8 ccu_mux_helper_get_parent(struct ccu_common *common, struct ccu_mux_internal *cm); diff --git a/drivers/clk/sunxi-ng/ccu_nkm.c b/drivers/clk/sunxi-ng/ccu_nkm.c index 784eec9ac9979b22e8f384e0abbb5c1a381ae953..401fbb752479b787092c53dfd87= 0692e9eb70dba 100644 --- a/drivers/clk/sunxi-ng/ccu_nkm.c +++ b/drivers/clk/sunxi-ng/ccu_nkm.c @@ -162,11 +162,9 @@ static unsigned long ccu_nkm_recalc_rate(struct clk_hw= *hw, return rate; } =20 -static unsigned long ccu_nkm_round_rate(struct ccu_mux_internal *mux, - struct clk_hw *parent_hw, - unsigned long *parent_rate, - unsigned long rate, - void *data) +static int ccu_nkm_determine_rate_helper(struct ccu_mux_internal *mux, + struct clk_rate_request *req, + void *data) { struct ccu_nkm *nkm =3D data; struct _ccu_nkm _nkm; @@ -179,18 +177,21 @@ static unsigned long ccu_nkm_round_rate(struct ccu_mu= x_internal *mux, _nkm.max_m =3D nkm->m.max ?: 1 << nkm->m.width; =20 if (nkm->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate *=3D nkm->fixed_post_div; + req->rate *=3D nkm->fixed_post_div; =20 if (!clk_hw_can_set_rate_parent(&nkm->common.hw)) - rate =3D ccu_nkm_find_best(*parent_rate, rate, &_nkm, &nkm->common); + req->rate =3D ccu_nkm_find_best(req->best_parent_rate, req->rate, + &_nkm, &nkm->common); else - rate =3D ccu_nkm_find_best_with_parent_adj(&nkm->common, parent_hw, pare= nt_rate, rate, - &_nkm); + req->rate =3D ccu_nkm_find_best_with_parent_adj(&nkm->common, + req->best_parent_hw, + &req->best_parent_rate, + req->rate, &_nkm); =20 if (nkm->common.features & CCU_FEATURE_FIXED_POSTDIV) - rate /=3D nkm->fixed_post_div; + req->rate /=3D nkm->fixed_post_div; =20 - return rate; + return 0; } =20 static int ccu_nkm_determine_rate(struct clk_hw *hw, @@ -199,7 +200,7 @@ static int ccu_nkm_determine_rate(struct clk_hw *hw, struct ccu_nkm *nkm =3D hw_to_ccu_nkm(hw); =20 return ccu_mux_helper_determine_rate(&nkm->common, &nkm->mux, - req, ccu_nkm_round_rate, nkm); + req, ccu_nkm_determine_rate_helper, nkm); } =20 static int ccu_nkm_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D76C0335566 for ; Thu, 8 Jan 2026 21:17:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907052; cv=none; b=oD+xIxu1o302fiLu6SeBlGlOab7IvnpqisMNO3wnEunZojgqc9qipXishSaZSGtpgWdBCykfHxUJyenczK51U3/LhsPZ9DeeDNuc9xK7JuxipyLG5pN9I04JmTkhzxE7BtcIWZ2l1bMwrj4gkISE7iSW+0y623WBfwBpSo/o+Iw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907052; c=relaxed/simple; bh=umRDO+6LfN/287FxKKSUjyAEnGgbqrwJmKxDM5IJEb0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sGTcTooFoMAUSDYhxU2HTXtwVsR8Xnqj5L3D9O6U8Gy/77knTDYjZgLSLcwjP6Al25yaeMzYmVqyO/Un2RpesoZQsPSUVVYpMiIduAuoICOSLUoJav+nN9jCa+i1aM5zdYONOTEA1F/dQG6+GLFdxMk6I8QQCQIYnVONtt5UbhM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UKV83+e1; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Hpx34d36; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UKV83+e1"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hpx34d36" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nbe/XApWaL18q7zl45yn83syExfCEwt8uiod4ciQGmg=; b=UKV83+e175buGFTK2k7UuYhQ6JR4ekrH/L4BG3d318hJkwABXq5RIT3kyUU6K55YxBg9vx Z2ukEJeMYhJdlfdmGJm2VxXyDQSmBgt7qO/VXXS7Z67F5L0iD/N0JPJgaQD26OmMmieA0T cgM7edkO/ulMRiWU4u8Xkt6uwrKcL08= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-358-kekmwgHoMjqx0v1E121-mQ-1; Thu, 08 Jan 2026 16:17:22 -0500 X-MC-Unique: kekmwgHoMjqx0v1E121-mQ-1 X-Mimecast-MFC-AGG-ID: kekmwgHoMjqx0v1E121-mQ_1767907042 Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5ed0ec20724so2889857137.2 for ; Thu, 08 Jan 2026 13:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907042; x=1768511842; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nbe/XApWaL18q7zl45yn83syExfCEwt8uiod4ciQGmg=; b=Hpx34d36BMQtdTJP3jdsuAgrOupkSOL3kdRClqW6iwjD5Aep3DdV8z6nXakM9u5VNj 3n8BQINQAcCST4JVRwwmXzIC1lOmehylfv129hrJCVUwiQlhOH5WytPu4rfz0Afp3w6v 0Y2p5cShNWdmWcO9GbUW1jm0522Yr47+BrbzfuCGFE1/q9/UBiYkxzQR7OWgb+sb/N/M IWyCiI8kidkuVU97dX+FT2yt5LrBEJAluChZbY2fOB2bAXMrDwbDa+q5D3Y/XWwbC2Gi rXxzC9m8ToBVPJaFNg9tVGqRX/LApf1xKHrSEzdIujtjlAB2tHxzv/lkM2SiKRoYkD2j 7gOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907042; x=1768511842; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nbe/XApWaL18q7zl45yn83syExfCEwt8uiod4ciQGmg=; b=EuEe6bswQN7+Yc0F7fbfcjfA2RuC98k8GItIMWoJMVlQ5unW9zu0SJrbYUDFjhWE7Z lYRPvBon1/ohtbUR5wlwCQcJ7BpKf39UrLoW48SBzFz6G6X56rq71tkemx/YZUiNf9oP yxQsD1fjEKhTrBXzt3cJXZts4T27+c5YalsyiwlOn5/epUp8rA/eCYdXSgJFzCEqo7dp 8Nvf/DprzxPtqClFE2/OnV0VvBvC2EAtYbNd0F/HgZ9Lj7yrtWWJRygjvcWmEXNawyKG PHNRR/rI1Un6WQPvWG4xTHiyARDPzIUFPIZO2AmfHh9PywVZtKGzVoYdMy7Iq37aPggn qTmQ== X-Forwarded-Encrypted: i=1; AJvYcCUWr/ScwqBGlrlMuUUUpMTjlFTwJBEMnKENGKGDQmVIj7Rcs26kwRdkXQTiuDZ5DA26H5dL9PWHwYgBHBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwETcRGP4G2Txg0NCx4IPbd0iVyYwqE6znPaz+KGQfIhYY/yKEr pWyhxn+OG9uOMaw2FGRjt4OClJPY4RDjgMONuZjOXnyBbsPa6GRfSaegorpeR73Zq/uIQHJqdH3 UGWIrWBFBiDSAP+0JIvSFQzecd/q/FrjOncjlHqrKfARH710TOTZFn6tiYJQd/ihOLg== X-Gm-Gg: AY/fxX59bPevvdwhSmKU4WF7m4mE10OjlcQYa4TBkveKL8iwfyYpBq8+tFEhkeyJqTv SVDReGJ72RkCsEkcjW+Nef7hYtDLiOP+CkVUPeKaOpvnsfyhMcNztd/L+VivN3+rVjLTncebeX8 2hS15KlWjbNu8vnLMR4Rag367as9dNZwt4a6wIkrXMsOdF4r93SrixSwl5zgxwLmdU6tSKrK2QX PC0Tl/Ablgls76vSInNDbbG0RLx+1KAwgiBYr0FcDYaKomr/j3pd9j5//BsTiWjAoK467zNK+IH UYRc5a/UrRZBQzi9kmeqWNtlL3sq5UaGlqcWGXhZNay8UT/Gf0/wrs+W5oDRP0vT1c1TSUHWak7 DpuVDvw2m+qoupfM= X-Received: by 2002:a05:6102:2b8c:b0:5df:bd66:7b76 with SMTP id ada2fe7eead31-5ecb5cc3249mr3338016137.17.1767907041720; Thu, 08 Jan 2026 13:17:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1x2+oN44SwRZMn0neR813HW1d3t12U7Ab+i+v/CBEKCDCYY1jODx5EVkgCHegnuNvRsKGvg== X-Received: by 2002:a05:6102:2b8c:b0:5df:bd66:7b76 with SMTP id ada2fe7eead31-5ecb5cc3249mr3338010137.17.1767907041324; Thu, 08 Jan 2026 13:17:21 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:17:20 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:21 -0500 Subject: [PATCH 03/27] rtc: ac100: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-3-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Alexandre Belloni , linux-rtc@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3747; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=umRDO+6LfN/287FxKKSUjyAEnGgbqrwJmKxDM5IJEb0=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5LaFZDw2enhddVtjCv8tt2nNjHNUwns4+26Fpf4M1 Vvt2DK3o5SFQYyLQVZMkWVJrlFBROoq23t3NFlg5rAygQxh4OIUgIl81mdk+MBgZfzn+rtk206e ieGnNpXUFXfJRe2ZNqXnn/jmGq/9ngz/A745NDB/ZIqY4Ze9653w6RrBIOs0F71FG86mKx7ZqBD OCwA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- To: Alexandre Belloni Cc: linux-rtc@vger.kernel.org --- drivers/rtc/rtc-ac100.c | 75 +++++++++++++++++++++++++--------------------= ---- 1 file changed, 38 insertions(+), 37 deletions(-) diff --git a/drivers/rtc/rtc-ac100.c b/drivers/rtc/rtc-ac100.c index 33626311fa781b5ce90dcc472f948dc933bbc897..16aca4431da8c029e6195d8a3c9= fe75fa95d0bc0 100644 --- a/drivers/rtc/rtc-ac100.c +++ b/drivers/rtc/rtc-ac100.c @@ -140,42 +140,16 @@ static unsigned long ac100_clkout_recalc_rate(struct = clk_hw *hw, AC100_CLKOUT_DIV_WIDTH); } =20 -static long ac100_clkout_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long prate) -{ - unsigned long best_rate =3D 0, tmp_rate, tmp_prate; - int i; - - if (prate =3D=3D AC100_RTC_32K_RATE) - return divider_round_rate(hw, rate, &prate, NULL, - AC100_CLKOUT_DIV_WIDTH, - CLK_DIVIDER_POWER_OF_TWO); - - for (i =3D 0; ac100_clkout_prediv[i].div; i++) { - tmp_prate =3D DIV_ROUND_UP(prate, ac100_clkout_prediv[i].val); - tmp_rate =3D divider_round_rate(hw, rate, &tmp_prate, NULL, - AC100_CLKOUT_DIV_WIDTH, - CLK_DIVIDER_POWER_OF_TWO); - - if (tmp_rate > rate) - continue; - if (rate - tmp_rate < best_rate - tmp_rate) - best_rate =3D tmp_rate; - } - - return best_rate; -} - static int ac100_clkout_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { - struct clk_hw *best_parent; + int i, ret, num_parents =3D clk_hw_get_num_parents(hw); + struct clk_hw *best_parent =3D NULL; unsigned long best =3D 0; - int i, num_parents =3D clk_hw_get_num_parents(hw); =20 for (i =3D 0; i < num_parents; i++) { struct clk_hw *parent =3D clk_hw_get_parent_by_index(hw, i); - unsigned long tmp, prate; + unsigned long prate; =20 /* * The clock has two parents, one is a fixed clock which is @@ -199,13 +173,40 @@ static int ac100_clkout_determine_rate(struct clk_hw = *hw, =20 prate =3D clk_hw_get_rate(parent); =20 - tmp =3D ac100_clkout_round_rate(hw, req->rate, prate); - - if (tmp > req->rate) - continue; - if (req->rate - tmp < req->rate - best) { - best =3D tmp; - best_parent =3D parent; + if (prate =3D=3D AC100_RTC_32K_RATE) { + struct clk_rate_request div_req =3D *req; + + div_req.best_parent_rate =3D prate; + + ret =3D divider_determine_rate(hw, &div_req, NULL, + AC100_CLKOUT_DIV_WIDTH, + CLK_DIVIDER_POWER_OF_TWO); + if (ret !=3D 0 || div_req.rate > req->rate) + continue; + else if (req->rate - div_req.rate < req->rate - best) { + best =3D div_req.rate; + best_parent =3D parent; + } + } else { + int j; + + for (j =3D 0; ac100_clkout_prediv[j].div; j++) { + struct clk_rate_request div_req =3D *req; + unsigned long tmp_prate; + + tmp_prate =3D DIV_ROUND_UP(prate, ac100_clkout_prediv[j].div); + div_req.best_parent_rate =3D tmp_prate; + + ret =3D divider_determine_rate(hw, &div_req, NULL, + AC100_CLKOUT_DIV_WIDTH, + CLK_DIVIDER_POWER_OF_TWO); + if (ret !=3D 0 || div_req.rate > req->rate) + continue; + else if (req->rate - div_req.rate < req->rate - best) { + best =3D div_req.rate; + best_parent =3D parent; + } + } } } =20 @@ -213,7 +214,7 @@ static int ac100_clkout_determine_rate(struct clk_hw *h= w, return -EINVAL; =20 req->best_parent_hw =3D best_parent; - req->best_parent_rate =3D best; + req->best_parent_rate =3D clk_hw_get_rate(best_parent); req->rate =3D best; =20 return 0; --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 803F733556E for ; Thu, 8 Jan 2026 21:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907058; cv=none; b=dGdLSUDtTwv/0bYSvAbljIElHYlcCdrh7t9x6ufdMkoWrbABKBGGejcYPsCbGAWu5rXq8KPqoSLkLyGN/i7egO3vSfEI5nSIbo2uHMELUIbgKhQZ6B2RS3OZs+Tec/zbjIG8B7/5GgHIddd71WDj3+ipPup19j0/MOzTDD2crjY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907058; c=relaxed/simple; bh=oUlYy3bQgFH6fzS/3MtHKlbPpAXM91oV6I4JsmoLqZM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BvosKOfj1zCQshkQRXBHnsO3Fkrq9a5bNbLajgDa8/kM5mk6BKzwUlr3hIZaI/DjY3Zcq4bmBK0pY5o1pomySnWmNBK7Da95lgzOzmWIFA7HfmYef8H1Pkh6rowuSq3gLTOm7sIxhgrH9QRFORaRHGD4kxLfER/93maXcP3f3W0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=K+ua/yj3; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ytb4iEKH; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K+ua/yj3"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ytb4iEKH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RBYDw4jtntgqBTWPIcvzRYHJL2SPvYBI1QtaKE/TrD8=; b=K+ua/yj3mn2Kj+7zNGoueuTGbHJYNYkkaj63tXibTnOnChiJvq3rjeI1FlgflN709VMnkS QDtYy5ptG+KZG2xS13dwiDRxgfQspyoqsIRQgcwPqB75E9C82/b3ZnKhiAHFgiAHHN+iSE sc37cABLXk1kmpcr8uGvNEr8KiMi0So= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-fvIjmPwIOz6qhPqG3oYlhQ-1; Thu, 08 Jan 2026 16:17:28 -0500 X-MC-Unique: fvIjmPwIOz6qhPqG3oYlhQ-1 X-Mimecast-MFC-AGG-ID: fvIjmPwIOz6qhPqG3oYlhQ_1767907047 Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-5ecbf2b9b2dso4611431137.2 for ; Thu, 08 Jan 2026 13:17:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907047; x=1768511847; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RBYDw4jtntgqBTWPIcvzRYHJL2SPvYBI1QtaKE/TrD8=; b=Ytb4iEKHg6bm4ufuNIsqga4YnH9UOTZR9DUz0xwDZLF1aBsqeSJ20JqvZ6ceFLSi/q D1Z0f+ZYahLydpKDT+2MeVbvTpiVPuTFL+/ova5i1RnRYY6wsNbiJg1KKU6JmcDT06pI GpcW7tBnbIk4M40PWLnHorzaRi9tpKYFjISV6KyCFx6d39kwF56c5VjhshKMobgnwDVE HWDH/lSr86ecr8ez2Jvdr/2JSqG3Obv4Errdjf2rcQ3I7NXuAPYIRd41K2yObUXizMD7 iF3BmoKGnGCD9g+f3SeLXfspOqDkm8BM90HLQbbdRb/dRL1+RfoBFe+qVu5NPjx7ZSqZ HOwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907047; x=1768511847; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=RBYDw4jtntgqBTWPIcvzRYHJL2SPvYBI1QtaKE/TrD8=; b=IValXtdaTV/7r1Sj5z9iwThTL+RPzb45fDP++KxIUL0ZPeu+WhN3NmHwOZiWNwkK/D ZehyWtP+Fzw91gFaV7sRdchSDhU4cFc3F6Gzu7WLhtwu5IuNZDRggXv/g+ilfO/Fdixr F47EZuHN+rjnmNPzi91dGjvByuxNd79ko0ybvMSgwTY2nnY16R5Hfk8qUim1jC7td4aA TnzNVbYubNxFtHIHEVZmSAmPj3gpm5b376l6ghaAq2eFcT0nfwEsB0eUBSzmrUg+6OMS EVR+9MqMiCMl5JLcE1cOhZ0Sv1KcClBmOy0xLwIFZ3+n1YpuRIzclig7MIrd+B9DP4l6 8q1A== X-Forwarded-Encrypted: i=1; AJvYcCUpm4SQQajwHFmkY7i/bGMf8IIwOdm8avoNjUVb98djtowlpbPbvQArtX8C1+rvmdB7cr7FZegd1M+qakY=@vger.kernel.org X-Gm-Message-State: AOJu0YzQ2aGeqDr6f+DPk57Exbv2qeCrGBfkI81uRC4Q5GUxL5PfbZKp j33r6v7FDjD+g+vtGCnhzt7DcnbDn7p3747B6pLxPwCt2CmdfsBYU/XS62ZyzOb1sD5ArkhZ2Mm xwBTJsAouEwpNzk7nb1Xy2A7FWxu4ophVkXTZMVcKgn78gWpNnfL3UNdGh0ToTSkn9Q== X-Gm-Gg: AY/fxX7I45Kcrhm6Z6CorvM+EB3KAg+hqR2luaQZYp2tOrYEjyQjJrrQqu8UfGcDcKB RbudTG8WGBXxMIDWv4S3GqtJ+Y4MSpV20Q6i3cTKENg2XacJZGdJsUW/G7VzMF8qZfOReLnDK97 ts7XrnnWEwAhRcPoIX7KRq1Sv3fPkH658y/0yztPwhFMSjtFrCKeOHuYeZq2Q+Jj8VWeDvDIbwX yYs9xaylOAoQGDtcPT6/MV3fjTj85Ly8X7A4jh8FTzIfDKsGappO8zO5CofxQ0GMesASxKAPc2g 2Z6RGl0xEAquAaQE+XnlUPrgCUQmgPzDHPqGnL2FxHczHGHLCr5kDZBR4zvwWZdO735Xbc+5joM woQhtmeu2j9wvk3E= X-Received: by 2002:a05:6102:f85:b0:5df:c33d:6e54 with SMTP id ada2fe7eead31-5ecb1e6f41fmr2971659137.3.1767907047318; Thu, 08 Jan 2026 13:17:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNwWf0onPsPTub4yUrXc/8gn5GVOhb2j2Ehx3Pvq6hJSQ86k2qUyrPeRzAHK7SxONIWAACBA== X-Received: by 2002:a05:6102:f85:b0:5df:c33d:6e54 with SMTP id ada2fe7eead31-5ecb1e6f41fmr2971651137.3.1767907046907; Thu, 08 Jan 2026 13:17:26 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.17.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:17:26 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:22 -0500 Subject: [PATCH 04/27] clk: actions: owl-composite: convert from owl_divider_helper_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-4-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1444; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=oUlYy3bQgFH6fzS/3MtHKlbPpAXM91oV6I4JsmoLqZM=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5LZNVbC3CrDOT217EXJqI9Ne4XMhQefWP1OYu2P7r MOLjcQqO0pZGMS4GGTFFFmW5BoVRKSusr13R5MFZg4rE8gQBi5OAZjI5BuMDJObVXpuGXl57amS l2BSj1vwJku5kld2uajlBmXJAIXsSEaGqXyCzj4/7VU/RbYxez003Hx3jkx+V8L/Ls+Vc//tyCt nBwA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 owl_divider_helper_round_rate() is just a wrapper for divider_round_rate(), which is deprecated. Let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! Acked-by: Manivannan Sadhasivam --- To: "Andreas F=C3=A4rber" To: Manivannan Sadhasivam Cc: linux-arm-kernel@lists.infradead.org Cc: linux-actions@lists.infradead.org --- drivers/clk/actions/owl-composite.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/clk/actions/owl-composite.c b/drivers/clk/actions/owl-= composite.c index 00b74f8bc4375a8f42e9b54c7bf1affe91e1074a..9540444307d6c960af200ec13e7= c60abd47ffc85 100644 --- a/drivers/clk/actions/owl-composite.c +++ b/drivers/clk/actions/owl-composite.c @@ -57,15 +57,10 @@ static int owl_comp_div_determine_rate(struct clk_hw *h= w, struct clk_rate_request *req) { struct owl_composite *comp =3D hw_to_owl_comp(hw); - long rate; - - rate =3D owl_divider_helper_round_rate(&comp->common, &comp->rate.div_hw, - req->rate, &req->best_parent_rate); - if (rate < 0) - return rate; + struct owl_divider_hw *div =3D &comp->rate.div_hw; =20 - req->rate =3D rate; - return 0; + return divider_determine_rate(&comp->common.hw, req, div->table, + div->width, div->div_flags); } =20 static unsigned long owl_comp_div_recalc_rate(struct clk_hw *hw, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17EC9334C2C for ; Thu, 8 Jan 2026 21:17:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907062; cv=none; b=uueF27X6RwaKZQFi6eod2qhelQ0I/1IGzoWe6j0fiCfcbtJ08ut3Zch+FWDAoZR1UovFXTjrAeCP5zG/QGBG/OoO/BFlPpicvnpUH7zC394l3EH4X+mXBOCcZULB8idecRF9Z8xekW8Lig01hEm6vTMhqmfgTa2UtE04n6R8jU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907062; c=relaxed/simple; bh=nzjUX2UpZ2i1eeMykuusgP1Jrs5n5Ls+16scH6BzdF0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EhThBPHepalAPXBjAyRDNjRIdqtSRRpzBmI2xCJr2Lk6bHF11g1jgMPo22T9LUbHARS2v5enXEIz3Tx8uKy3njguP7dcqrgk3U8zNQpdbDFYiSULglCpUxjHB1TXRcAymcFQR0VEZDfH8Ybn6fY72CgKK963VaiiDu1903RgH40= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=c2Fwscpu; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=B36QCKt5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="c2Fwscpu"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="B36QCKt5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=isTuYgACeBQ4FzUudAdIXG1/HC4FrJOsqYZ+hDA0p/A=; b=c2FwscpuNuJGFmM5NLVsLtmD0THAI9mWxqUh8T/6XUbSo9BYjCFpe2bA35TWrMFl8sU2yh lL2Auwho9/WBTcHVamFfASJ+0TalmuyUL5hJreTVqSDrHD7/W8GV8IMhpSDnQTvoKLc0MQ RJghBkZP4ERDs4xrBxVQmXwOeIYGxzs= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-29-gXPbOGWXO1ibm8YQrMUyUw-1; Thu, 08 Jan 2026 16:17:34 -0500 X-MC-Unique: gXPbOGWXO1ibm8YQrMUyUw-1 X-Mimecast-MFC-AGG-ID: gXPbOGWXO1ibm8YQrMUyUw_1767907054 Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5ec38a3265aso6064419137.1 for ; Thu, 08 Jan 2026 13:17:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907054; x=1768511854; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=isTuYgACeBQ4FzUudAdIXG1/HC4FrJOsqYZ+hDA0p/A=; b=B36QCKt5iuO3wa8TinpF6Cm8pVuPBQmK7ibIwQGrejBYLCR6+Kk1TXhLxGffHOS8j/ Sxl1rJnbj6xw6mQrC4OzAoGFS8E6nPddIgpEdPchxyHsH64UMVwcYi4m8+b7NTdr5RIb MeOoN808InWuZqQtGWLp07rYWbOFrki+id8LvNKJkUbbg0pSuQIz2Qx9+cvJhO2/WLo4 95CqBN2olE/JaWfc9qK15YJbJqYGJipAvlh4i3ql48kdo8HGB/ppGYdBOQsepdbsvZSz ff6q0/GrD6l6sAGtC+jQiiRixskBajQFNLA6/6jfh0T2l6DEvgPVvJUzlmS5adsi/6hD uJAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907054; x=1768511854; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=isTuYgACeBQ4FzUudAdIXG1/HC4FrJOsqYZ+hDA0p/A=; b=Y8vRiplSL19mjWeH5lIrbX3QPnnAH2przys9FepQolSiA5EocS4ze8VJcopKIKFnqH qYF6PFhPU9TPM1T/eSFQD7zksmavTuywkKAZaVoSXo66oLldQWk8lG3JR2zdoNMCk/Dl ucYU+uPGozXyL4two9cnLxvOIPqDnKPlLPUYM9RQmzSVhvFJLBWnhpX3V6nT+YjQT5PA KPCXSy1fzLO8fNPjnxpy1DVQvBDKTqs/V5pKQwloAveVJ6Pwy0PuJdpTvKFZoYiTGPc7 cqgkZVjMZ5MXEd9+ApevwZDgVlrOETz2AvOaEYqJBHzPypHojYj5lybSJaQAjbGODJB0 fFHw== X-Forwarded-Encrypted: i=1; AJvYcCUIl4b3kcmg9msHUT/biGwC5oBD9nj/uZ7sVdqjwCZZCxzO5CQ0fpenN6kK6auhdmeF7/X6BehCnvKXgOA=@vger.kernel.org X-Gm-Message-State: AOJu0YyQdnqlAOYaClO5yLZIgKXScp/2GXOWrTjI3YYj9ZwAaC/fump5 M7uF0ISUip2xZTgzwbU93vVMjwZEuJMqnn4Y6XLwiLmvPeGDgZkkAKVTuu0sScjk7TKdMY6VTzC BeldUYBpGtQ4OIqUMZxT44kTK3LlchWjkXauZP7kN2lwEssD2qqW/EeKXeb8jmHCmSg== X-Gm-Gg: AY/fxX6dvQMzwGSmIGhctPpxrG04O+1RSNjaswzAp5T0Atl1DLE53fqYzIFWBjkkgSu +1CEg2axp30P4hDUJSRsZrZjg3VQkPKlCsINmn2MfRz+0NgnGqI0CfYYqnn2mFjXqnj/FYeQ3jZ Xuadqh5gGXtD2i32VNaNvI7ZEBrhat85n54w+tqcFaxanmzHCs2BP95fbOcaMCVZXz81/AekPn6 aiCooCEEPnLvAmjAKYmgNOvwgG5KHf0PSiCOtXEMMKrgITsEfw8wnhFdLEB1aub6yyiK0xg9Axp Ldfwwfw1QFD8Cf3kI1T2N2GegM+kk2+n7IrKl16zko1qoRKIr3vD5U1EfDr39qUQWheu8S1MNyb IVPUsI6dwPT1amLM= X-Received: by 2002:a05:6102:604a:b0:5ee:9f71:a17c with SMTP id ada2fe7eead31-5ee9f71a37bmr1208260137.14.1767907053815; Thu, 08 Jan 2026 13:17:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IG4oKtCzCZndKrddm3vS5yqzMlQVx1nyfHkPTEyP4m4LPypluHrmg5ASUY2ZnBplJ4DMuaw1A== X-Received: by 2002:a05:6102:604a:b0:5ee:9f71:a17c with SMTP id ada2fe7eead31-5ee9f71a37bmr1208245137.14.1767907053507; Thu, 08 Jan 2026 13:17:33 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.17.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:17:32 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:23 -0500 Subject: [PATCH 05/27] clk: actions: owl-divider: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-5-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , =?utf-8?q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2917; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=nzjUX2UpZ2i1eeMykuusgP1Jrs5n5Ls+16scH6BzdF0=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5LapmYZvChNsD23gXmzdcGBl0oKn5atL5O7JN19sP HJYIeVARykLgxgXg6yYIsuSXKOCiNRVtvfuaLLAzGFlAhnCwMUpABM5sYfhr8DqkoLHH7hmVTYV e5QlzFNaMi+pt4z/9w2ekzceXr6YYMnwz3zzo7IbEk4KAQ95bE4KXOZLct3+0a6Nj2v1C6ccoQ4 7NgA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Additionally, owl_divider_helper_round_rate() is no longer used, so let's drop that from the header file as well. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 1b04e12a8bcc ("clk: actions: owl-divider: convert from round_rate() = to determine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! Acked-by: Manivannan Sadhasivam --- To: "Andreas F=C3=A4rber" To: Manivannan Sadhasivam Cc: linux-arm-kernel@lists.infradead.org Cc: linux-actions@lists.infradead.org --- drivers/clk/actions/owl-divider.c | 17 ++--------------- drivers/clk/actions/owl-divider.h | 5 ----- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/clk/actions/owl-divider.c b/drivers/clk/actions/owl-di= vider.c index 118f1393c6780f287d26736b2547a8b43751655a..316ace80e87e3b1c22a4011e725= 644cf37668e5e 100644 --- a/drivers/clk/actions/owl-divider.c +++ b/drivers/clk/actions/owl-divider.c @@ -13,26 +13,13 @@ =20 #include "owl-divider.h" =20 -long owl_divider_helper_round_rate(struct owl_clk_common *common, - const struct owl_divider_hw *div_hw, - unsigned long rate, - unsigned long *parent_rate) -{ - return divider_round_rate(&common->hw, rate, parent_rate, - div_hw->table, div_hw->width, - div_hw->div_flags); -} - static int owl_divider_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { struct owl_divider *div =3D hw_to_owl_divider(hw); =20 - req->rate =3D owl_divider_helper_round_rate(&div->common, &div->div_hw, - req->rate, - &req->best_parent_rate); - - return 0; + return divider_determine_rate(hw, req, div->div_hw.table, + div->div_hw.width, div->div_hw.div_flags); } =20 unsigned long owl_divider_helper_recalc_rate(struct owl_clk_common *common, diff --git a/drivers/clk/actions/owl-divider.h b/drivers/clk/actions/owl-di= vider.h index d76f58782c52885a66c96e8bf13b0dea3ba51efd..1d3bb4e5898a3ccf729894533ae= 194ac4c34b6e3 100644 --- a/drivers/clk/actions/owl-divider.h +++ b/drivers/clk/actions/owl-divider.h @@ -56,11 +56,6 @@ static inline struct owl_divider *hw_to_owl_divider(stru= ct clk_hw *hw) return container_of(common, struct owl_divider, common); } =20 -long owl_divider_helper_round_rate(struct owl_clk_common *common, - const struct owl_divider_hw *div_hw, - unsigned long rate, - unsigned long *parent_rate); - unsigned long owl_divider_helper_recalc_rate(struct owl_clk_common *common, const struct owl_divider_hw *div_hw, unsigned long parent_rate); --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB334332ED1 for ; Thu, 8 Jan 2026 21:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907066; cv=none; b=HEiHjiFpsj5UY1OYkep9p4zrONt2Hd1J/QxatfvNR9ixCcSYfU5JNebjnfhvZPbY1pVw/JXVDXojqmeUXd0SaA0MpUlsJtRNEM6VlYY9+CSB/5syGw21/FkV90OSJ+mfc6O60DcbWUPjhgkwjbmn1xFR+D/7dBGCY7Uh0T8+wD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907066; c=relaxed/simple; bh=ezyZCBz7BY8t8FxF4YFrSSzgfQvODsPKF5EJi4+BluE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uKHPIWcnVY3hkLWvawz7nbpkCDMKa2WtOR51L6qdHT2GfqZF20Lveu3rL1kGll7cDgpULbs6DWnO2pGdgLpeRM6l4mLsP2psfoE18PPH5Ldyzuz/ipTen86Q8os+dRslbc1cHU3Pg/48vmXClohpPN67CklBAv46GApurBBiC1g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZNJFBylx; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=VNNolNQM; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZNJFBylx"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="VNNolNQM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D5cIhvc8dQLYctZYfUjuPlu8cNI3Cxecf0YI2Axf+TE=; b=ZNJFBylxn3QfaRXqG+D08ysAxsJJSLkNl7Q0OYww6/ao3vopa055b59KOwejhYJu5wF8My aW/T0OOvt7yk+K/+Xg9d4GghU9JDLDnAANgXvSdFDRI4x9qA4koWowtDAHgo9Pe8WgM8Hz x18m95KRRtoTpQ0R1emw6P872nf5zD8= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-3C59JpYUPtKdxqMTycgQmg-1; Thu, 08 Jan 2026 16:17:39 -0500 X-MC-Unique: 3C59JpYUPtKdxqMTycgQmg-1 X-Mimecast-MFC-AGG-ID: 3C59JpYUPtKdxqMTycgQmg_1767907059 Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-94120e0acbdso3870980241.1 for ; Thu, 08 Jan 2026 13:17:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907059; x=1768511859; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=D5cIhvc8dQLYctZYfUjuPlu8cNI3Cxecf0YI2Axf+TE=; b=VNNolNQM/rvJbSwWpTIwO2aSIl2zecp3eVgjqZXD0DKanY2b24EkmKBN7Ea+eIzvIt Hvvy+l4yJRMkWD9y91mjiPl7uK6Th3l3/a/CtGu+Ry/6z4673+x7hoL3HYv04vjBJrhK yhgkVBnr1mnLJAFq2DU2t03oL9DHzNydBY9ZZ2yzukpTq3cGPX6WO7UvESHyBTEeFmct RZVePQhtXIrHXJ7YRstAWvlt/Bm8n3vo9wmYHqR9us+fs2EL8Cak3jAj32J0kI2c87yB 1w+jhzrPfZfBl6CnV+izPXDr85VK75CR+Nf6H0ErkWgD335oLYnBB6ha9mnmbtdGUgRf kmBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907059; x=1768511859; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=D5cIhvc8dQLYctZYfUjuPlu8cNI3Cxecf0YI2Axf+TE=; b=LBAWGstZRf/HbMi1TcAmK5a39RfFciVAfuxDz0tRIHzfMFsG7A4StRFypU7lPHeShd qT1F3FhlNBZUPt2Plvu54rz521g/JJ0Xw+xO6/aEIFRcrZEkLfI9l6IgrE6I892nhXPe VrsRrjTbr/hHa9V0BOBuxavrKK+dmRtG9H4bWBtcYKWjv3Eh6x2YvBzqRCoksKfPMWdv wNwYzS0Gc2j/r7ESm4DnY8uiH2XnMpoPfsYJF4sG8XWsN9NkYT8JMVOZ8IBziwbVZnrl epD3VZZAJP8rFnjc5iwvVtej+Fw7dtLZa2DFV+aC2jOWFOwuIb94giMOzyLS+E10+Zq2 /06g== X-Forwarded-Encrypted: i=1; AJvYcCVZhMPwWN7FZ4+J1PeJk19s25eEwwfFSKIj45jDYbNqOmAnniDPgsPe3xNTwq5fDnWthUEA+2jUf3U3YuU=@vger.kernel.org X-Gm-Message-State: AOJu0YyEc58fWWFQzjrxLyTgt+b3HfA37bkNFyKCeYKhOS5gJ9G+VtYp dPfrgOF1V9UIzGjcmhqTcPThosWN7kqRFhQk3t4DbcrysxEbvXbfWABazwG0uBNehAqb/uL7nXl Crx+aheX/vNnqDBPE7+2piu/Lc7t3z7XX+QM+ypfMJ+E65mtcsXUOBynCOqylO4IsCQ== X-Gm-Gg: AY/fxX7U53+G04nD+WelRH/WpXK+nsVB2NIKb2kueEaWoDIgKb5m+R7Ej35DRvBNnoL bUHvkF+1KAZFKipEesYuWKNXaDkQO7RlbeHXhLdxcvlMrjD7XSMCfrqdlE8YguHxrwKmripPfwa AythkJRPo/DuuKQ0Bjj4Mh+fUMWrO91lAV6XQ0GRkWBaASiSCn3ER6joZuob0nev9P/6O8hGQkR zrQo4BKZnelnoDJIU2SfMWNI3PnUgfvR8uraChrISzrArbUa29h8dxthxastAtBxH/avwfF5JXU MRwp4EkjbWToQao+BF/2BGIFugaBKmGFysPyF6HLrywiVM781/K2N4E36gRBMlHl25DFtKY1U7F GwzIOf8MI+w2uHNg= X-Received: by 2002:a05:6102:4a84:b0:5dd:b28a:2e7 with SMTP id ada2fe7eead31-5ecb06087f2mr2463941137.0.1767907059167; Thu, 08 Jan 2026 13:17:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFevT6XpqiDw3gC3iSZKj1S68mskdqd8KLh1Xh266/vYweAbfuv8F4ugSPmroYppR3BxoB4zw== X-Received: by 2002:a05:6102:4a84:b0:5dd:b28a:2e7 with SMTP id ada2fe7eead31-5ecb06087f2mr2463933137.0.1767907058653; Thu, 08 Jan 2026 13:17:38 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:17:37 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:24 -0500 Subject: [PATCH 06/27] clk: bm1880: convert from divider_ro_round_rate() to divider_ro_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-6-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Manivannan Sadhasivam , linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1508; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=ezyZCBz7BY8t8FxF4YFrSSzgfQvODsPKF5EJi4+BluE=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5LZNOKPG16VUEnn81U/VWLG4RcoK2v5JAkZRG78V6 B/MlsnrKGVhEONikBVTZFmSa1QQkbrK9t4dTRaYOaxMIEMYuDgFYCJbzjIy9LvtvBGpMGPnhpVT feuFfI2KuvhvKL2yO5qdw/pl6uWui4wMMybKCE0RTCsvjvfmLhbm37/SxXh7R9LmRz9tMx/FLsz gBQA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_ro_round_rate() function is now deprecated, so let's migrate to divider_ro_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: cf1d95fa0c64 ("clk: bm1880: convert from divider_round_rate() to div= ider_determine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! Acked-by: Manivannan Sadhasivam --- To: Manivannan Sadhasivam Cc: linux-arm-kernel@lists.infradead.org --- drivers/clk/clk-bm1880.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/clk/clk-bm1880.c b/drivers/clk/clk-bm1880.c index dac190bc6e19a6dd4be413ea52d41f74934a1aa9..536df8e828eab83fbd381213513= 9c703aa7a1ce3 100644 --- a/drivers/clk/clk-bm1880.c +++ b/drivers/clk/clk-bm1880.c @@ -621,12 +621,8 @@ static int bm1880_clk_div_determine_rate(struct clk_hw= *hw, val =3D readl(reg_addr) >> div->shift; val &=3D clk_div_mask(div->width); =20 - req->rate =3D divider_ro_round_rate(hw, req->rate, - &req->best_parent_rate, - div->table, - div->width, div->flags, val); - - return 0; + return divider_ro_determine_rate(hw, req, div->table, + div->width, div->flags, val); } =20 req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C61A3321BE for ; Thu, 8 Jan 2026 21:17:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907073; cv=none; b=f7WX/6VVAx8jfsNN7f8zHkJBLrpWk9T98qS27LCu51bpNC09rl9ypcstWQiLeDdF7NNEee6kpZy8kfeBstmvd7l6zq7DpF2ickhsy6R8q5fWGFlMHiDt/CJ+s6SBh4qAOzPh6j/wB7MOEtmu2Bfoe1yJySqxYt+aemebJ814jO0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907073; c=relaxed/simple; bh=RuQmue0KXVswNj/US68xhO/UINGh1ZD+21QN33aw3ys=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ukY7e8kSRwviVPYD5NvzpcraaKtcFngq7imiBIfOXCb/kijWHrYMwycdCqStfNQ5XKOMBXyxKJiVNwqBjbLJ7KuCJAx/9uXlMJ+J03gXQeTVJaFXW1AnVsfS1Okit6OWG4yOFaue3q0tZBLYBSmQFqcpi+FaCH7KO3oHDGzA0LE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DgiDLy0+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qTmpcf9a; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DgiDLy0+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qTmpcf9a" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XKs6oAZCQbgcF6rh1H1z28GAjZqxIUJQTytIqgMl/jk=; b=DgiDLy0++lVHR1d32P57svO4/4bvGHoqbC/vlVspBLpQKOjMSz++5uddnTstGrfCZIFOl9 5nNwbKZepOJSJDjejLc40DC4Da5ENbXsjh2J30xLfCMTepLyxRjLMpQvhb50QuQf4BIqNL IDlJKii74G7Z5so3OE38uPrjVRWbnaU= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-NoGHw15kMfuFJl1JZb7epQ-1; Thu, 08 Jan 2026 16:17:44 -0500 X-MC-Unique: NoGHw15kMfuFJl1JZb7epQ-1 X-Mimecast-MFC-AGG-ID: NoGHw15kMfuFJl1JZb7epQ_1767907064 Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5eea57b8dfbso1007209137.0 for ; Thu, 08 Jan 2026 13:17:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907064; x=1768511864; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XKs6oAZCQbgcF6rh1H1z28GAjZqxIUJQTytIqgMl/jk=; b=qTmpcf9apO5FKDUJ921mGSKESaEG6uIiqE/Afvv12AM8Q62CzDp3KD80RsnVRkKvs5 NLGiFPHE8p2teBSDXBl/agyFrBc7hOJskiJ5CXQUCRDwdYwIb8Qvc0JfEnLyHvNaNoVE 7sc8TBYzEH82e2aP/um1c0J6gXmOCJzufyKqqI0xnHh4yy/IPcs9aUNIBeKQICQe9XwQ 7rYhq1Wv1JKQanqIpMzOhlxrRJ9PKwfKkTQh35aY8ssT7hM9eul9I+Vi636mvvVyQi/w EOBriY9Qn3E/UTufcoiT0X8QB/hwOmibIbN570F+0BkutcEExnphlt55NsQUWkwS2xJi C+cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907064; x=1768511864; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=XKs6oAZCQbgcF6rh1H1z28GAjZqxIUJQTytIqgMl/jk=; b=DRitRDGkAJfjLmOdlwXxLJLzlYWznpB+YqeSb/2nibSID1WoVoKPz1XTCYsQ9Ze/tv ZmxgmRL88Lko6WXCdkr0XhCoOgnmnChfDj8Czpa+ZH1SyGuV/v9EoQp0HhEvI46Cc+LN 4ejAsKNAX6c5A/TOtPPvIvUgYn1irCNRspcMN9SBrU8flvVNVHalXksowj3s6JZm3oOt 4Z4BursO0us4t/zUDcZKngwDMJV445S6Evgx4EjcL2pPrThQ/yHoQMA9Ewiq9+/PARuK mJnlKtI0UuvHMj2lv9SZ+2oVQq8JeBD+0h8vkx3aK+f5DhAHCgRQSw4BHXyugPUKrS3e RUIw== X-Forwarded-Encrypted: i=1; AJvYcCV8+Z+grCZCK98VykQmCvncSrBUen+s+FL2R2cItjhvSQ2Ippks9nuSooWQpOJxsK1J9ppT95SbTnHTBwE=@vger.kernel.org X-Gm-Message-State: AOJu0YyZ/lDoelEymX1iLjA26jhXMdaaIQYn4kqOKlaM91IGRr935Vjk hWFI9FUhl7jWxBXd+11ty0eIe9Otj6YamygzRmDNHAOoIQbHWJSP9AKYVGaa1CxRd7HD33kjktl pi8kBWnHpVmeuP2XyhcRtHIlPkGJK3g7s24tVB/O3uvmehXkeFRHzmo9+k+jIuVG06Q== X-Gm-Gg: AY/fxX6OT4+iboQXkPfiYq+XY424227O/LaW/HA7fpoHA8z3PZIYKAlT70wPMsxIMTV vTvDmM6eZsSIoH7ZhGlFTw/57azvycEVTfA3ksvczqqNDK1iXZGrErIBnHSkn/E7vXP57EE86au Wl0hTRiW41R1fIIxkb/3lS2Xfl9cxhweVybcYB7PEOOFUiqNU2s3OkqSt8nW/T0IJnUCXxzUSZr +/Ti0ix+l5fN0QQZJSkGV1BHqUEvRMlgvkvSkghhYV2Kc9YXnWqZZ7Tpx/Zzdk4AiVWLdF6t1TA 9ddf97P1RUATLZSjCmhXRTtG0uoDOZQtOOAuNTSdX7nYJ1rl3hdvzWQY5J+25p09UgZbvBPXNSE MgjtoAKiuwGpummo= X-Received: by 2002:a05:6102:14aa:b0:5ef:23a3:205d with SMTP id ada2fe7eead31-5ef23a3214dmr142761137.31.1767907063648; Thu, 08 Jan 2026 13:17:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFyfz4L8JiCndo8FBpm0+M+LRB6QOmq1jfaaNaZ6SC4zPZtZ4JarI/3vVLEaOtB78YN6DHpow== X-Received: by 2002:a05:6102:14aa:b0:5ef:23a3:205d with SMTP id ada2fe7eead31-5ef23a3214dmr142751137.31.1767907063199; Thu, 08 Jan 2026 13:17:43 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:17:42 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:25 -0500 Subject: [PATCH 07/27] clk: bm1880: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-7-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Manivannan Sadhasivam , linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1405; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=RuQmue0KXVswNj/US68xhO/UINGh1ZD+21QN33aw3ys=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5LbNl/tnocy/bzOTXuBUpW/VnydbLT+UemmHiefCO SYGx9ezdpSyMIhxMciKKbIsyTUqiEhdZXvvjiYLzBxWJpAhDFycAjCRzFcM//RYak4qdxV+3Lfn akG04B6eoMV8k9I47ms6uJyM6zpVeZ3hf4jaCeeJX5MrqsLmPuF4MFmHYWbDx9U8Z1rintjkFcY VMQMA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 64613d7fb42f ("clk: bm1880: convert from round_rate() to determine_r= ate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! Acked-by: Manivannan Sadhasivam --- To: Manivannan Sadhasivam Cc: linux-arm-kernel@lists.infradead.org --- drivers/clk/clk-bm1880.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/clk/clk-bm1880.c b/drivers/clk/clk-bm1880.c index 536df8e828eab83fbd3812135139c703aa7a1ce3..1bdceb36fa87e8250c10a7fc079= 1379e1533bb38 100644 --- a/drivers/clk/clk-bm1880.c +++ b/drivers/clk/clk-bm1880.c @@ -625,10 +625,7 @@ static int bm1880_clk_div_determine_rate(struct clk_hw= *hw, div->width, div->flags, val); } =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - div->table, div->width, div->flags); - - return 0; + return divider_determine_rate(hw, req, div->table, div->width, div->flags= ); } =20 static int bm1880_clk_div_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 992D93358B7 for ; Thu, 8 Jan 2026 21:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907077; cv=none; b=idRY7TDLbhwyu7peXi8DV9L9XItVJlWmGVFzzoB7YXDQu78Qy+R4H9HPzmxi8PhkznYixaevadyI8SmlwNZ/9OxSG2fD59iFmPQN0/kggcJ44u0eGueSOLUSxlZREdT4inMltCiHxYUdGxe4cvfuckgfQdGhLtnoVTGtz/3Y3Og= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907077; c=relaxed/simple; bh=MSrM/TUkLRXq2tgdjfiD3zxWVyaNpQZ9j3nooJ7JcDg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h7cs2elRw/z0QndkGnTRXlg838wJVRAvk3+XUQAEpdCdMpCdcBVRpWVy23X+6u3lc2NaSKECaWSG6bC5uJ1VdwAQ45f3Pg3pQrvDAzWdtnT8/nXMylHiKM3nzXO8JVZ1Kw/ils2T75A0Bm1R/XYA0bIJoqu5Eui6kcmNlNMwoMI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=I25jlAzH; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Klydh5X2; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I25jlAzH"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Klydh5X2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nPAHExQLV/4v4yRgHXdthFlMDNsbV8sNQaYipBs9fv4=; b=I25jlAzH40uSfsMzhzy13W3xrFWJfkE+9mVHRLQ6qTHCx5ieygMkwALGnZUbq9bGP9cLc5 x6mOoiM0gUDzAznpM98+jNKDCuOAdpfRtWaaVOcNGTFPCI5yYO9zaPWgSCMxQXucP7M5PV O1HJuOreZGlBPEOsfB2CEkfe7cm5lsg= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-262-WfcQ1gGbNTK5eGngnG5nnQ-1; Thu, 08 Jan 2026 16:17:49 -0500 X-MC-Unique: WfcQ1gGbNTK5eGngnG5nnQ-1 X-Mimecast-MFC-AGG-ID: WfcQ1gGbNTK5eGngnG5nnQ_1767907069 Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5eea57b8dfbso1007330137.0 for ; Thu, 08 Jan 2026 13:17:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907069; x=1768511869; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nPAHExQLV/4v4yRgHXdthFlMDNsbV8sNQaYipBs9fv4=; b=Klydh5X2V3RSqXalw0A+bq/7RZNoIZBDQXi0jujVvGAYL3JbB7IaHV4wZS4kVfd7Yg vjUhddBvnFB4/+E+h3/93b3dp2mKkc7lnOq/ecYBfjn5EORhblsIvnWGvmuKA0M9TaXs FPAffkjjXexFxro6cU+iGA2Qra8hYa7jHL8NWbNt7memE14Lk5fcRc0+EEYnmevnaqjq DcLKfjUtpPXl+GfEQSY0zYvdtwKBQRxuKXBW8cyjfhjhPqlM63Baep8e11/DpBkR7HH1 2kO9QZHzRbNCeQIw5lSrXJ5y8NgD19O/0XaQqLQGeE9NuGzR03W5mCS/QnxUi4DiPZA4 4K6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907069; x=1768511869; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nPAHExQLV/4v4yRgHXdthFlMDNsbV8sNQaYipBs9fv4=; b=EXk3heElhi1EHGIZ0uShZDOI7JqMY/EumTl/SSp2PkWjpX8FRb0GyWFl79B4NdIfg2 heenqyDqufKRH2DTFmgwJI+UU2nhyEp/4TwW0IrG1hFWZeJiVT3vA6/41tdswKra5pwf fqPNHhEM5W2yYGR45DDpfRvBHgCcJc5I1mQfqQ4FEZNd6smEgzXErj5a8nTrZ0oAHLfq ntLsvA1ILgSKIk3NVrpGAIvHLxm/16r4Pi6ov0jZF4bWQSRYb32l/bKxtWjS6jRDNNW0 dpG2nlbUZLlPkeUyvuBeiXJYC0Nkov+UIXaFFZ7OAZquzrMCS+IWf7k16imlVjubRhud yysw== X-Forwarded-Encrypted: i=1; AJvYcCUeqlQ2IU3OZ3cnaw5mukq54MRhNwIFmwB6ZbrXgc1htkS/bcS/y/qWA2uw9/7Tza2Z3jOacsKcRvfgYJ4=@vger.kernel.org X-Gm-Message-State: AOJu0YwKCJYGVsh3G6k/9RzUECsz/dApS+OHMGGhtFIyTwqFfrVrH3A+ lXXNhckm3zrhwRym0GrL0+qVcsdHs6V6Br4Zdogvi+fT8SvxgZ/dcaiVFIYQEc0sqpcHrCozOjO GsM/R46EDfZxF5VIXF5JusKShz7dyQDmWaEHLbqUFrdWjRTl8QSihbbB8XqlG5q/cRL3CDgXLBA == X-Gm-Gg: AY/fxX7sXCbIZ/AQETZkumRYpT/blIKYwDs8jrHH2XIHOAl6fQnvIXhfs6lAj98fPRz +Z7URrXMzSProyOmYyNwywGPWdIqbmI7+PmJNWwtmedA1lUs61Xph26zM/wN03kvRGEYrpT/0H/ 9T5DolG6WmB12AxN5MiBi83agtWPzG2Lhczp8g2cJhXREHbxx8Qgf/L+3Ddhi6nIZ9vgEZrhb8a ndNO+qoEs26X71k2/zfYNANT0pKyS5xrd31dhFrFuzzR8X1lWEx6ToYyDhGSByLjqouCVK1yYIN n4LK9KguaMrtWy7vxyF8kTc0rC8FRVFhDvK63qYQtNVzrsuCv7rCVSeuoYxB6ToRYMqRWzp2SSz 2wtxpKJFf3c+E6zo= X-Received: by 2002:a05:6102:f9b:b0:5ef:255a:22f1 with SMTP id ada2fe7eead31-5ef255a26b5mr4216137.17.1767907068758; Thu, 08 Jan 2026 13:17:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IGlGk9ZbVlxkIYtgYDBpCvSZPviZ16FulSoSKc78mQPR/dAm/bzhqYSgmaCvA38MGyAJAjZIg== X-Received: by 2002:a05:6102:f9b:b0:5ef:255a:22f1 with SMTP id ada2fe7eead31-5ef255a26b5mr4197137.17.1767907067559; Thu, 08 Jan 2026 13:17:47 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:17:47 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:26 -0500 Subject: [PATCH 08/27] clk: hisilicon: clkdivider-hi6220: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-8-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1486; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=MSrM/TUkLRXq2tgdjfiD3zxWVyaNpQZ9j3nooJ7JcDg=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5Lb/mO2V8rTljGn2vGNzZ9y+F7DowET31Yt+MPC9e /PRdEf/sY5SFgYxLgZZMUWWJblGBRGpq2zv3dFkgZnDygQyhIGLUwAmcpGHkeHK+XAz9QZvyTd9 Xp1/N3t4zv8i9MVpIs9L3WuKp3/IVqQy/K/ovszv3iuSvF7LepvBSfuP368Gt98VzZ7hNFlM1yW zjAkA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 619a6210f398 ("clk: hisilicon: clkdivider-hi6220: convert from round= _rate() to determine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- drivers/clk/hisilicon/clkdivider-hi6220.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/hisilicon/clkdivider-hi6220.c b/drivers/clk/hisili= con/clkdivider-hi6220.c index 6bae18a84cb6c0e19dd00762613fd9051849fdd0..fd7ceb92d6515757f79cd0496ce= 4a8ae7220f321 100644 --- a/drivers/clk/hisilicon/clkdivider-hi6220.c +++ b/drivers/clk/hisilicon/clkdivider-hi6220.c @@ -60,10 +60,8 @@ static int hi6220_clkdiv_determine_rate(struct clk_hw *h= w, { struct hi6220_clk_divider *dclk =3D to_hi6220_clk_divider(hw); =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, d= clk->table, - dclk->width, CLK_DIVIDER_ROUND_CLOSEST); - - return 0; + return divider_determine_rate(hw, req, dclk->table, dclk->width, + CLK_DIVIDER_ROUND_CLOSEST); } =20 static int hi6220_clkdiv_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56A4B335544 for ; Thu, 8 Jan 2026 21:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907081; cv=none; b=rp5tGkAkuZifQW4nDMI17hjpT3HMZUt5thpc/GAAOEqJ7Kc1YuWSaT3Lqb6I2p0fj1LJvMvjUy8JYD9ONIKgy1IkqSqmx7boihb3jFFa9x4Bs7nDL1ZQdzkh688lhm/5Gm1des+8M2Ja04tZWPxjzaWbmFIOTMu0ZFITXagu/AU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907081; c=relaxed/simple; bh=POUeZsY+F8+kUE271cgqQ9Np90bcd9LYX6PjbgvcBJw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FZmkt65sTTYncKiHy4kgU3AzVJM4epBAEMbkBS/ze6Aq8nVcGkMEU+yAmEOGiCvpXbEcUgL/kQ519Aq5ApnfSiFGm2kf+gQIUn7zKAiL+G8NPPXO9fy2Z3sio2lhtQCqF8uTK/floAqoyfQjYui/Wh/2pUSHoYzQdhzdmDdnyxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=h8iWPAh5; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nGdaMu/2; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h8iWPAh5"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nGdaMu/2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kJHSitOCa2lb+eZDZlB0ZfwPqPo8SqKK/IbMApuY5hc=; b=h8iWPAh5BxNSxTYRWupC8Iln77wCyT1k/aJovXvK4MW4xcokQtZ2nlJAlHJxhv9qOHqV89 5LWaCl9lUAyUIsHKdtuA/4MFQ2MDNugINFbEQcXKDNX7q1KqH5vB05G6oxhAcqDgPq8bxx wd3a1p+to36DGsWhJe7qB22Jw2NQJOg= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-LVM4zI01NBqtZBfyZitwwQ-1; Thu, 08 Jan 2026 16:17:55 -0500 X-MC-Unique: LVM4zI01NBqtZBfyZitwwQ-1 X-Mimecast-MFC-AGG-ID: LVM4zI01NBqtZBfyZitwwQ_1767907074 Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-5ec8781f59cso1852398137.3 for ; Thu, 08 Jan 2026 13:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907074; x=1768511874; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kJHSitOCa2lb+eZDZlB0ZfwPqPo8SqKK/IbMApuY5hc=; b=nGdaMu/2kyrJ8qKYTxq78OIEBrMW0AgXRRyopMPkMnsJbUCS6LK/RXkbLFYKO9vZQj 3gckx3KfPW1wLkQqJ9Ar79hmU3FUwcimQRDAUgsTojiu2pE7vN9SMxmZhRQBB4FfQpiy TcGYAWQY0++v1uAo8tEooWftdEqngkcDaoIYkQQw++vG5bQsGSu0lg84hfI87xr0LbmE Zzq418YKSGxR6SCkmJyiNyS5b1kYogECUsLIE/o9DrqyGEDuTXAG8Y1nT5z8mlKO16xP /HZb2DmuXGCMN6nC6lwCW0/+xMn2FSXqgyLmvRVDIgE7gqQozcBg60fs0E5xUdDp5lQb IV2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907074; x=1768511874; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kJHSitOCa2lb+eZDZlB0ZfwPqPo8SqKK/IbMApuY5hc=; b=jvSAJYzZxSokpqsgJDHS+WFlfBIuE1fN0wUaykrJGMk2KTVip+fn0RT4riZLSQpz5Y 3QXTZReV7oLDvBH4NUd45pbIDAq9YTy5X8LWm42BqcEqtb7fL7fhgSvJBwHyMITFKgtT ALODU7txgQ8KY07bY0XdaUkmE/h531/w2h+wIwEmWD07WwNKXc+ENaCaNhBof4+Gj+zR dM2P1PbtJfojozdVxikgyz0MrWmUbzpXbRhdRmDWYgOK+FAEtrmsx5u1rXrFB7xpx18p 6Tx8mypnczIAtqWkZnSafhSYiKDxhRpzY79e4QwF8qi3JfAnzpTOlZskzl7aAXd+38Mn geFQ== X-Forwarded-Encrypted: i=1; AJvYcCUnwhUTBuD7AOPYddBnIDxS03CFrkALuh0KJfPynZHa9+GUpqgtQqMvzrwYEvlDlOGCcAmSRlXB1+NxWik=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2SLT2GGKaOGdNsYGZUCrhP3d0XbpGq8A2+uHhRde4VhRXpeVv hgLloCJFRZjPmHSCOnI9JyYJDEIbWub1nWFYB1+Y6TTaWDNtiev9WUF8S44Qq11Pi65w9Yg/4bH 0xoNj8DgcuGIcr7IkhBCb0M5cIyzFPah/b7RzohcCmIpKgvVc405BMaXxQBeqtw21IA== X-Gm-Gg: AY/fxX4qmsKL7EccQKmptWYtZ+eDxpierG3JXQVQBOjbsEiQde+n9TUycK1rwDDaoaa 3377iDenicRDg4/uQ4SJJM5jNHyQW4qbVB+6PCe374ttE9kEfRgD0840sfjr2BOrmOkB9uOH++s B5h9wnV9JrIBYA4jGREQSky4Wrd/ScDPKPI924VxCK9Q2nJqHZAX7REFMulFzdPa+VyoDlU2L/g F7Kz2YE3aqw5zmOdQIgDh+SaGRlTqqThF6Zp4pFDtJcvxUmvEe2HGJhfgv8SECmUw5ZmN6i13dB uE9mMdhYQKvFmdTacaN9JZFEWHIpysp+KEZbK0ZCKzWMEbRyGUXEI86PBq+cD/ZyoXxQYUonmwY zJNboF4bgVuVNKBI= X-Received: by 2002:a05:6102:38ca:b0:5db:f352:afc0 with SMTP id ada2fe7eead31-5ecb1e72945mr2984431137.2.1767907072892; Thu, 08 Jan 2026 13:17:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8lwBGoZzalWApFS6fBt0yhs9PqwqWvGlooSRhdR5zfpfZTC31pKCqamm2uqiTNXnx/ioL4Q== X-Received: by 2002:a05:6102:38ca:b0:5db:f352:afc0 with SMTP id ada2fe7eead31-5ecb1e72945mr2984416137.2.1767907072569; Thu, 08 Jan 2026 13:17:52 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:17:51 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:27 -0500 Subject: [PATCH 09/27] clk: loongson1: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-9-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Keguang Zhang , linux-mips@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1454; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=POUeZsY+F8+kUE271cgqQ9Np90bcd9LYX6PjbgvcBJw=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5LYHN79l2mZlWP1eiTViw4Ffutcmduqz/1K/Y61xg F8n5L1lRykLgxgXg6yYIsuSXKOCiNRVtvfuaLLAzGFlAhnCwMUpABNZ4sfwT1n/t8Kspn/BRVU7 7qxqL3ExZ2mqzJCLlr+ruXvP9skd4Qz/bNpEnLodlkwyLqjufyw1RS4xw3lR4du3G9bM/2G0/v8 KPgA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: bb40a2ef4fc9 ("clk: loongson1: convert from round_rate() to determin= e_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! Reviewed-by: Keguang Zhang Tested-by: Keguang Zhang # on LS1B & LS1C --- To: Keguang Zhang Cc: linux-mips@vger.kernel.org --- drivers/clk/clk-loongson1.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/clk/clk-loongson1.c b/drivers/clk/clk-loongson1.c index f9f060d08a5fae3291a9408c6dc93531b435609f..1674181a1107dc4f30e78ee410a= 55a49b6d0b4b5 100644 --- a/drivers/clk/clk-loongson1.c +++ b/drivers/clk/clk-loongson1.c @@ -99,10 +99,7 @@ static int ls1x_divider_determine_rate(struct clk_hw *hw, struct ls1x_clk *ls1x_clk =3D to_ls1x_clk(hw); const struct ls1x_clk_div_data *d =3D ls1x_clk->data; =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - d->table, d->width, d->flags); - - return 0; + return divider_determine_rate(hw, req, d->table, d->width, d->flags); } =20 static int ls1x_divider_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED8933382E5 for ; Thu, 8 Jan 2026 21:18:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907087; cv=none; b=H6gPoY4EFgjTjHdp9G1WmZeNGIqJtUzFxgFEPQ15mSXOszAj4xJ84RxGxBOCloLT+ITMzsOV5LfgA37i3NykTtAkp4a5I+Oj4qS6KEFIaIWXciwTaN8/A/oF5WUKY98drLRrEiJPEDflrEI3+gJ+qltOcrxpI78WIjKNiqeTHKk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907087; c=relaxed/simple; bh=K0FQ99DF6G2l9smIVVgE4dnwkD9e+LTmW0IKTcacQ4A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iQRXq6uu9CLpRbwN8jc9KfhIIlxrmrm0j1inOg1Bm6yt0878KIxr/SaBs8u4tLIN6JoUrB040RcaprqJze3up5gaL5ZLTvA8V8TVuN9t+x4leanj1GDct8HG8074tQpNaXkcYH2ty14ftXdi4dpvEypgqyr0cXuSR5OkG2YmaYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=aq4ezG0o; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=cumOQd2Y; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aq4ezG0o"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="cumOQd2Y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TemeuWi2wCTioypOE3JNNIJOW8KjtfzrrE2QX3Yv0/c=; b=aq4ezG0oOk2AxnuxzBQrn2SvTodvaPh8O/TUdttZC4fKkLzQz4AFMpU40IaAfzrxj8LM/R YgEiCOMkPLdNgU7MLwb4KR1iChDNOUTS5vWRuCivLLOYfygfNQ0hb5JAkE6APDv6vbbPub rG8fHDEQ7nOMniujhDYYGMLR1+nTztw= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-k-yT1JBtM4apvULGMRTv5A-1; Thu, 08 Jan 2026 16:17:58 -0500 X-MC-Unique: k-yT1JBtM4apvULGMRTv5A-1 X-Mimecast-MFC-AGG-ID: k-yT1JBtM4apvULGMRTv5A_1767907078 Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-9411b2335f4so4199989241.3 for ; Thu, 08 Jan 2026 13:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907078; x=1768511878; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TemeuWi2wCTioypOE3JNNIJOW8KjtfzrrE2QX3Yv0/c=; b=cumOQd2Ye830JmzYPhVRuyd2hejz3QZ6z0XmO4ei79mWY6SLQDjwN4WLDhYoaF5pcq ctCsDpF5RZLd4HpfzUpV++23RnuP8vOWXaVXSMgYhPQ07M/juQtQdgY95GqmXmD7FUgz /+R+4nLvtlbW/goJj+7zFIWo3qaRL0rahoUth1cwHo0guuK2CFXkcL8TkwkWAQVC8MV5 /scd8ZhwVllV/w89JUO5iIXwhhSd7HgeSOY9L0AMcLOxs8Y7fYttsRS07dH2zjXwE2ba tfggtNQ0bDVh9Urfkkg53uPTmQlB0liOn5flafwDNVDYyC4Pi0Csj4CwuB4Wpv35fCk1 xOGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907078; x=1768511878; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TemeuWi2wCTioypOE3JNNIJOW8KjtfzrrE2QX3Yv0/c=; b=uzEX5YIxJ/WrMA2RvqjgP9N37IuFhrPKxi4KKgMGFG5b6DuCrWjApRErLleAs+oOMm ld1SZAwNLTqibS8F0nBFmsXW3JkIRUnfbLtj9gyPPvlD+IB1841NyIIk+EdjxEvPdShO b7BfUtw6vPHPmY1sJdFqn8/7f3i3wFAxDc195EQ4sYwmDxqiWCRPK2M5cvUGD26YEP7O CBDmmHNlB9c+gibsOh78WL1szEhY3CHQ8omqQkETf/nLi4UW7RfRn1QC3ThSh+nV1LjQ jFuGBll5whBa94NxM9uIxOtgTdiVx5ju2HxgmKxvddc1NH+INUg/1Du4D/BS/5LuN6D+ Dydw== X-Forwarded-Encrypted: i=1; AJvYcCULXAl2DZYxoXQfTtdkPHSCv8p9r8zYctHg3DQBP6nsuwwPEifxKP5nYZV+PPWvBlUGbks1tsYS4NjH76w=@vger.kernel.org X-Gm-Message-State: AOJu0Yxum4cvTVO5IegQeiykSvGgszPrOXwQnBoqZqxzpb8ks2QcEChW YiIenbgv5Zs5Drk8VIoZFjATZq9LhQo/cR6b/psV/DXg6OfAmvkf3AR1SDA+8AUdUKhpYyw9sue F2b/Lqc72oijPUUGAAgrd8GK9dWK97V1cY5YM6DtfOywiNoJkQwQQPrcLFcTShAnuOQ== X-Gm-Gg: AY/fxX6vLsV5JxpT7xh7W3Ym2DHrQOuRidQjSe5RQ5fMXrg9Er/I6+3hysB4nKxMT9k 4nQQa+q1XldaGq9OpKwcAiYG/nZ5thdqTDdr83yDdpHBWqHHLzg2KA3IpusV3R+cvd7FAtSMede Hig1wBv1BuHk5HRCWnFyDVTyvOgxyHcm4DQKloXtSRqTXF1r2g96t2PG+eJq3aSji9jmOMwuUHr pS9xIT3MdkqdioZTERURGWNjJKV7aDL5z3ZnR2QPIVp60bnPfrkyN25mIPPtqFy5FeDACSdee/O kOihsvrE/YPInXhILJNEE0IIvJIgM2s+zyBt1QoNhqu+Ot4IWDYps9vpdUOqsBFTjXxpDJKICvY tpupUe6J7z05lwYY= X-Received: by 2002:a05:6102:5048:b0:5db:e77e:7828 with SMTP id ada2fe7eead31-5ecb687b373mr3139783137.16.1767907078173; Thu, 08 Jan 2026 13:17:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IHedDwn3URCaGkSiOZuFLs9y04mybp6etKanr4h3QJEAdm0N8i2NP17eLN1PW6ZVp8OknusUg== X-Received: by 2002:a05:6102:5048:b0:5db:e77e:7828 with SMTP id ada2fe7eead31-5ecb687b373mr3139768137.16.1767907077681; Thu, 08 Jan 2026 13:17:57 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:17:57 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:28 -0500 Subject: [PATCH 10/27] clk: milbeaut: convert from divider_ro_round_rate() to divider_ro_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-10-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Taichi Sugaya , Takao Orito , linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1629; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=K0FQ99DF6G2l9smIVVgE4dnwkD9e+LTmW0IKTcacQ4A=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5LYLpZoFf969VuziTr0HNSu8/TiOuTtmmn8+/lmri WGzhrZRRykLgxgXg6yYIsuSXKOCiNRVtvfuaLLAzGFlAhnCwMUpABM5/JOR4f36uesTb501K1ES f/j/mABriXHF4nk+k2wehFR5rc7a6M7w38/60aErvD8luKQWMS3P3zDr/xet5RUJLAVeha45nCq V7AA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_ro_round_rate() function is now deprecated, so let's migrate to divider_ro_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: fe67c682f91c ("clk: milbeaut: convert from divider_round_rate() to d= ivider_determine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- To: Taichi Sugaya To: Takao Orito Cc: linux-arm-kernel@lists.infradead.org --- drivers/clk/clk-milbeaut.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/clk/clk-milbeaut.c b/drivers/clk/clk-milbeaut.c index b4f9b7143eaa658a7f2a14ff3cc9d91d8aa071c6..4e3790b7fc9064484c20a068d03= 15b8fc8241290 100644 --- a/drivers/clk/clk-milbeaut.c +++ b/drivers/clk/clk-milbeaut.c @@ -398,13 +398,9 @@ static int m10v_clk_divider_determine_rate(struct clk_= hw *hw, val =3D readl(divider->reg) >> divider->shift; val &=3D clk_div_mask(divider->width); =20 - req->rate =3D divider_ro_round_rate(hw, req->rate, - &req->best_parent_rate, - divider->table, - divider->width, - divider->flags, val); - - return 0; + return divider_ro_determine_rate(hw, req, divider->table, + divider->width, divider->flags, + val); } =20 req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA921338582 for ; Thu, 8 Jan 2026 21:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907089; cv=none; b=jS3cL9U5GTt3r5djLMlVcMRzfrGR8TO8NsQU+IafYTb/LWLhZ9V8hwSdfesC1292+IruRCAnJbZT7l4RzrIAz7cDycb+VWtTUXKmTe7/eV/dhT86a0ppMu106XNyF09mtca8AliiO9tUznCKamgYpmYljdipNyDfO+iSkL1dyEc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907089; c=relaxed/simple; bh=pxUCYfGPS2BABWCqUrnX6hbF+k2ODFPNH4frKluoHeQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iLAwuxD0F7TH4rgakPf6geuW71qyaAnczklZSBt1Fm+HfES2b5+F0PQtP39WNSjVmRlUt6O6kNDj9Un5YmO5wdQtnegJ33n8chJVHWsY52SUJEau5UfeO/ZsrCxW3tdbfchgllaeGY28E4MbkQ0k6PJeSlD1ET/OO07ePbj9cNI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b5XJjDrz; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=WQYArvmu; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b5XJjDrz"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="WQYArvmu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dkyJM/6LevJUQ1i5Iqw9MT8CT6XbKwep0aKDZWoCl08=; b=b5XJjDrzCncn1kFCpP23+ssBn/zMcDM5nteWMm0W5DFVpD8MqsKqj0PiABxgoUGV1HALA4 i6a/cMd7F5bFnss3XrqfKEofmDEdas44wxpf+GxY717V141XrdZI/WPSZ46SDdhaWZRzBb E98X+DipCCiQ4rK7nc/mcRte6V0wwEs= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-edeAJQGlNbGl_mzZPcjyxg-1; Thu, 08 Jan 2026 16:18:04 -0500 X-MC-Unique: edeAJQGlNbGl_mzZPcjyxg-1 X-Mimecast-MFC-AGG-ID: edeAJQGlNbGl_mzZPcjyxg_1767907084 Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-9413e5ee4b9so9742311241.1 for ; Thu, 08 Jan 2026 13:18:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907084; x=1768511884; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dkyJM/6LevJUQ1i5Iqw9MT8CT6XbKwep0aKDZWoCl08=; b=WQYArvmulmLSU+WAF1dj8GfRgY50dWPN/1prvxue6sqhECl3LXlpZ0icNx80BmhnYx ohVr46j2KVgPW8xjBo7gFvLlxdVOOPJd5LO9s0iiUKEyrg4yzOPkHLFO4sAKUd28MMj0 kfDZxI5h40/J8FKXLR/QMr7kyB+/C5e+tT3rlnd9vTTqsO3HcQMEueGc8Nn+KDQTGga7 NO6X4LqlaRe3d+UQgM++tMAQJ/TTIe8VbuqkRoQCT3W/lj1dzmItxzVxT4ggE6dUux8s lmtIARkwOtcm6WvqTr84ZRFpp8wzWOosfLmQvodDE9xcRJL0MOwH6L9DQ0dDRA5xhRVO fvEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907084; x=1768511884; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dkyJM/6LevJUQ1i5Iqw9MT8CT6XbKwep0aKDZWoCl08=; b=QiWVG6nOcEmaImH7LjynmHhTMyVKEkxN7qaquztBSM7UlzcvAHWQVI4pHyqvqa+MkA hc1Pqjv2G1wTN1WB3cuBsvonIe6UUPmncLDQw+At4UTuXGPUQDP/pnDgKut7kz6Q3cOX /oKsMZ0q/HwTCyN4D7U70zoDwycYh0IrwpxiDi/LqXZ7ahFQeP/gq7odZmjhOl0oEAOI XKuYQ0gFzR9mEK6fDVGMq4SAbQSlxLBQMn8Oj0uoV7RsC19PmsqpLNHTvPWhlP56X0P4 Mm2YaoIocfy1Os/MPIKCvSiWZjzPoUIKNH+EK2m4qUSaGkFu37iPLDlCdzIkO8f9z9rI 0wdQ== X-Forwarded-Encrypted: i=1; AJvYcCWNPnMigUeazrd2GM16Z3yAJ8JPpWl2qmTUTX1xS9UkSuSU6UxR+Q+nJGnSPRUwvNlIjxc+f1DZWmtcQ1I=@vger.kernel.org X-Gm-Message-State: AOJu0YzK1egNSHXgwIr44jM+IHy/4D7YL3GAPttKSfZWPq0vofx+Obiz /xIfq823Y54+hsoiveL2+MBXb/Hs6Z7hLvP0Wen+NnZG42N+7GfLp6LNIw/w7Yv8mCv3+OrtlTL RWunT8dGt9zuKuy4BAOoMbz85b4siSLec5YN6/XsOsGlQJoXGMDYPKmP0H/2jPEz1Tg== X-Gm-Gg: AY/fxX7iIITWNUUXCNqkTokM3Sfw0eiCy/6FlASgCZ8hEO0dWMj+36Qqz8WQ1S2MVuq jeGrFBSl9nxyiPyqT6aPCW8ST1zdixcWMbn35SB6Elcvbun94MZfEhrZJ6UUQfP3Oj1nntvDLUH lCiJ8PU3RpWKmhpmPjNY0RLtOOWfohynm9u6P2tO4MTxfXpKKtTmsJftmcqqDf0+Nq5IUxAwOfK BVGJ4nGPF+Onu9wbDYCHPOIlfnN03jmguJ88h4h1KkMFobJT/rEm4VZ8W0O3x/KBtNVS5hiyfYn 7H4HpAa7dsZHTP8Wf/JNwwNi5Chp7rnFKbwdySUqc3L2ZPAncmWmDnqgvLJqV2Rk4MtUz2h+ZC6 CAKB7r4Yzzy1VIaA= X-Received: by 2002:a05:6102:3e11:b0:5ed:b56:67b9 with SMTP id ada2fe7eead31-5ed0b566b64mr2961643137.8.1767907083652; Thu, 08 Jan 2026 13:18:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGTv5o/bKs6U/aYrJPkks/nMjbsF6EcT0xne2zBDiFaW0gV4z/6X5DCa53LH7to2F0UqpecWw== X-Received: by 2002:a05:6102:3e11:b0:5ed:b56:67b9 with SMTP id ada2fe7eead31-5ed0b566b64mr2961637137.8.1767907083283; Thu, 08 Jan 2026 13:18:03 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:02 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:29 -0500 Subject: [PATCH 11/27] clk: milbeaut: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-11-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Taichi Sugaya , Takao Orito , linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1470; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=pxUCYfGPS2BABWCqUrnX6hbF+k2ODFPNH4frKluoHeQ=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5La/f7qD8a7AgxkHd7gskGtfzVX2SSDR/Z/Wd9Em5 2t7LnqzdJSyMIhxMciKKbIsyTUqiEhdZXvvjiYLzBxWJpAhDFycAjARfzFGhqUaF22Xrtn94lDT 51UL2Fr6Ze//YNqZo+18xLV3rlmwTRgjw5L+pzPiOCQ2rTeq3vU0bcGrtuv6na9mTXWacuf0JJM fcdwA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 7b45988fcf78 ("clk: milbeaut: convert from round_rate() to determine= _rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- To: Taichi Sugaya To: Takao Orito Cc: linux-arm-kernel@lists.infradead.org --- drivers/clk/clk-milbeaut.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/clk/clk-milbeaut.c b/drivers/clk/clk-milbeaut.c index 4e3790b7fc9064484c20a068d0315b8fc8241290..45389db652e04e3c30c2a64da63= b047b7922b8de 100644 --- a/drivers/clk/clk-milbeaut.c +++ b/drivers/clk/clk-milbeaut.c @@ -403,10 +403,7 @@ static int m10v_clk_divider_determine_rate(struct clk_= hw *hw, val); } =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - divider->table, divider->width, divider->flags); - - return 0; + return divider_determine_rate(hw, req, divider->table, divider->width, di= vider->flags); } =20 static int m10v_clk_divider_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32623338918 for ; Thu, 8 Jan 2026 21:18:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907097; cv=none; b=TEx9BnDyhJiS/zd4vokPS5r2/dEFcbXiqC66+3wxQrKnWvwQUGq5ReIf6j/Y/9diJt8b69tJwAriGuhOk661OTWnZB4xKJ4p6BMrATl6YPlslSmwkKc4dtFirrKHypPa4kMYiBxW/4ovZYDoAtOxFQGRumkzdiDgXcFiMwZI5cw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907097; c=relaxed/simple; bh=ScZkcyRUl2Y7Rb30HqkG8nPcPdnar+WJX8LbQ/gUKqg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ru2S5UZtejdx4/5JSc31sSkafl1S1TMw5RkJwtLb8tgvKDLJAJ1uWrGnOQgBSL8EfwIqEsxSgH+reOdREuoJ2OTOAbyPaBLzfg7LrSWytJDimvQ5du8Vw4kVj+eMzIXSl+HAfSbNWmxbuIvFs8t2PHIQWIKSCa1gfgoc8JLL+C0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=i+3pvOOa; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=K+bUT0NQ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i+3pvOOa"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="K+bUT0NQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hr9znpRqAwXoXpH6toRVbeWwS5EY58tJLVv5ADu2gnQ=; b=i+3pvOOasRWvPPl5e8VAaXI/xeQzvpqJk5VyIyzgDKdpqUY9Rwrp8yYQ0i+pJ+x4aGnfdu nG6EyjFmQaAB2xaudPYS/18K3wHBgQbOTx+w8ahRPUD8GiE0QBVg1wkol7m9RXN8WIZz50 PTrf1kdWqKuWwuW/qjtEVQoJpQcqF9o= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-k5ruOIMtMFOF1fmtqwVNbA-1; Thu, 08 Jan 2026 16:18:09 -0500 X-MC-Unique: k5ruOIMtMFOF1fmtqwVNbA-1 X-Mimecast-MFC-AGG-ID: k5ruOIMtMFOF1fmtqwVNbA_1767907089 Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-94125ded3dbso8225302241.2 for ; Thu, 08 Jan 2026 13:18:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907089; x=1768511889; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Hr9znpRqAwXoXpH6toRVbeWwS5EY58tJLVv5ADu2gnQ=; b=K+bUT0NQKPuPPoofT6FlivjG3K1nxYDLAL1tRB0ZzSvu4veSM7+w3n7iKvxVsWSPSg 4EJpYEwIxEt5etAg9e0pIkvfrvakseE6kzdgnwNSNRC611OQ5c81dLtZ6t9FwZ6uTj6d Bu29WGbqlgPk+RF01iAvhOAv5Uyo3hsPN4cfMnTEYg9+dmwB2RhIfnZgABErYMZE+chd 3VB4kd+9TJ8UZOMJf9md7xYRK9G7u3TPGaoTL16Kyfb8V6mzj7xPphSp1TuOG/WS8ii6 ORXvHqDeAE12dCBB+ah6FHoorqt1vlIpQY/JeBqO+R5lz7gGqlArn130MeLXs1ha9NE5 M5Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907089; x=1768511889; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Hr9znpRqAwXoXpH6toRVbeWwS5EY58tJLVv5ADu2gnQ=; b=Ejff28tjUU0aqvBdR96aWehwL6ZMVXht49Yds166/3WRQWHOaoshNNxiSOSVK2p3+K y+QEJGrhS4/T3xfkeiG3P28OtdJj735z7i3C3wJGmlUZq53oryacIQjAke4oQR1fWMXY INgNhleSogtWj97RtnNUa4oo/zPiznPf6dzEokgxEHiLAFdbgAEbmXsqc23ZSy/8qVni WZOZEt9juKtn1jHrDvf0rI2osRGVJajQ058twFdGH4qUaQXGD9ydvV5zV8Pd2Q1J6tM3 ZrcpesMrDL1CrK4UIYZ0nmpadPhC6dynfTunmcnlzwQ3fBsUPezJpsv5vWk7G7qdFB0o sA4Q== X-Forwarded-Encrypted: i=1; AJvYcCXezUHmNHp/jb0YYiBDehI0CyRWnCO26S911F0XaNVGu/6JaEDt3JRKZgAf1dCQQBKzRJChlQUcHc/iOXI=@vger.kernel.org X-Gm-Message-State: AOJu0YwknL2JSaEtlbgV094DWfnyGX3zsVmWiHunYbTa43gHAg9weYnN 7nyHhNsgByO3dJE8fwEc/LTMlNyTtguhgYpc6Hmrx2zr6F+H6PtKiRodnJJSMMFPhUMRr17dpkW nEqHmCnuzLhqRvq1zdMCl0snQDNAe8S4ADmQFIxFx2agdnrWQKFM7gMquUGqllf5y2Q== X-Gm-Gg: AY/fxX70PJTdr96WbbhSyR6sHog9dgvLIpemZ3rSb7T+NYJPFF/6KIo+b8EV5r6zkAl 9TjC+pdu8j6d6ombfhd9v0TQQDR+bVlfJfLz8h6FbXItJFb97GcN7GZzMhHVRvOu0l/8E6cCNyW 6w/nmZwxmBgaIV2d+0O3m/O+Ssx7JhLxQZFR4QssBPKQUX3XrVTRY6gkxxNT0sUqmjOUjZfuBPk jbOwraSI3f6Hv+BM8e5Iu9KZPowKbuiHzym8XVBZsP22CphG2kxN7L8gFOTWR5aw0N5RSerKsb6 m1ZlAxi+czNYBMI8reiHwmPosQHGdHt3UOJL8poaaWhFlO9hEJw1zd/9QM3HuAkjQtQXbaY++kJ ZlY4NfpVX9LiJVbw= X-Received: by 2002:a05:6102:3e1b:b0:5df:c33d:6e3f with SMTP id ada2fe7eead31-5ecb1eae0c9mr3157000137.13.1767907088895; Thu, 08 Jan 2026 13:18:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IGrFEWux3oAL8sPgl8CrCD/X6cmoXF0fYkFPC+I12DUKPNl0o48fSIl672itmPsVsuxbfr0jg== X-Received: by 2002:a05:6102:3e1b:b0:5df:c33d:6e3f with SMTP id ada2fe7eead31-5ecb1eae0c9mr3156987137.13.1767907088454; Thu, 08 Jan 2026 13:18:08 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:07 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:30 -0500 Subject: [PATCH 12/27] clk: nuvoton: ma35d1-divider: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-12-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Jacky Huang , Shan-Chun Hung , linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1647; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=ScZkcyRUl2Y7Rb30HqkG8nPcPdnar+WJX8LbQ/gUKqg=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5Lbf3OB6+cyD27nlncs8X1045u/rkfl/Sq8S958n6 9dW2eUd7ihlYRDjYpAVU2RZkmtUEJG6yvbeHU0WmDmsTCBDGLg4BWAiz6IY/he0Ke4yieY9asQd yLzgsuDcEoHf86+7hV3sP271e3Ob7F5Ght6Fa3cL1+ja33fKlyjTm1qfeim7xSU/c2ngzT4h5+O 3eAE= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 215f8aa095a1 ("clk: nuvoton: ma35d1-divider: convert from round_rate= () to determine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- To: Jacky Huang To: Shan-Chun Hung Cc: linux-arm-kernel@lists.infradead.org --- drivers/clk/nuvoton/clk-ma35d1-divider.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-divider.c b/drivers/clk/nuvoton= /clk-ma35d1-divider.c index e39f53d5bf4578c628d34b05233c8e8da317c4d4..e992e7c30341977bd4baaad8b24= e17039252f90c 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-divider.c +++ b/drivers/clk/nuvoton/clk-ma35d1-divider.c @@ -44,11 +44,8 @@ static int ma35d1_clkdiv_determine_rate(struct clk_hw *h= w, { struct ma35d1_adc_clk_div *dclk =3D to_ma35d1_adc_clk_div(hw); =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - dclk->table, dclk->width, - CLK_DIVIDER_ROUND_CLOSEST); - - return 0; + return divider_determine_rate(hw, req, dclk->table, dclk->width, + CLK_DIVIDER_ROUND_CLOSEST); } =20 static int ma35d1_clkdiv_set_rate(struct clk_hw *hw, unsigned long rate, u= nsigned long parent_rate) --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 546133382D5 for ; Thu, 8 Jan 2026 21:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907102; cv=none; b=m1so5iA8QkO5y6YEtRADyOtWTtM13sn+nHO2VAyah3mJj/S1X8Tt4q0nL+9eMoMZ4EJnAezDTsvapWhaLop3IgH1b6EoaJyu+PrsdJ22UDCMh1BwtvnhlLoYF5XWF+M/Ph1dO1BwzAw293p5Z8JADHq1cPsvNyC6BWwhLGIwpYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907102; c=relaxed/simple; bh=7HOzNeGSRizgZeFkVaCLBp3lcLY0zAl5xQHRspPP9B8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iRlchzU8Byjpql89qKMRqdFHQVWKb6XIwC/zDqlw808jGYUiMTYDQCdgbMMe14h7D9HPbAssi5+/1eTitJsM8wf4vpCO0zmPU42tJzhy7cOJE1FcjVsoZSsTXIjP2r1tQQc61uZaUh4q87lFiUPeHH9+1/whC/myMvz3IunS4go= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=auOyC47B; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KSTVCXgV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="auOyC47B"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KSTVCXgV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=siOywqRVhauF6+2pNczXHVdhiBY3N5/g/CIcxw4d/Ec=; b=auOyC47BAQiFb7FuH1xeX4EBc2qV5gAvVS9J0QabJIpKy7ygEir5u6KOjos/J/InUfWz71 5VThCFogL2nQRJpo27bdZ3ar6jCbn6v7xu/ggpYH2udJZqsMLT0u/pWXo/Muf4x7x704gW DwuOV1GMKZppcLBsVP+cp9g9WHDN8S4= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-TtaabWn2N1aWmWfg7bo5MQ-1; Thu, 08 Jan 2026 16:18:15 -0500 X-MC-Unique: TtaabWn2N1aWmWfg7bo5MQ-1 X-Mimecast-MFC-AGG-ID: TtaabWn2N1aWmWfg7bo5MQ_1767907095 Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5eeadb7940fso235906137.3 for ; Thu, 08 Jan 2026 13:18:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907095; x=1768511895; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=siOywqRVhauF6+2pNczXHVdhiBY3N5/g/CIcxw4d/Ec=; b=KSTVCXgVrurCKPg5WcvFYbfPBVWJxckSuOsqEeC4VthHaMR/2Yy+jrOuB3+1i+WwPW KQ5YH1yKwO/DctNkJGWFDIwOsHGXLqXm1xPu7uhgyE/Lz9fOpcOORSDufCaeqvWHD/WD tIwwe7oJqpXFefKRKqsABlzWjTL1C4DegKaOHYxtBCKcoxsdCxClWRHy9KK6VbisdlqC hNf6Xk/lkJmBEo7UMmyiqN2bM4zT83+Jjh8pHeQ7WnvJXQ5I8SYCKBf5fsEQGNprCvqe snJXRdVMUmmpnk9fwpjeWv8ip6A61f3PkI0Lhm4nR0SB99PBvGK52ZrJN24JBpItyfWn wS5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907095; x=1768511895; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=siOywqRVhauF6+2pNczXHVdhiBY3N5/g/CIcxw4d/Ec=; b=mwifQw6bD1AiGeB88N627l4nWWaj4dxo9WCrZfKnEDZF7q3AtErrFEQgmry31qqQcg 4pYWDkIpEG7Pe1C2qkcFBbY2PmtAxM0CgmlSr4bVT1PDQ2wlCcQt+jolLqbcRrR/gPOn GpxRDWcy2a1TmwfyjUgGI98muU2hrEDzH2dp2R5SvzwEW4diTXt02DnNhA1jmsu1EqWn cK+OxVWCukSxdJ5TvJJ45kze7yu3r63pNiWxjcPF1n5Q3rCzBxGCFgR/mcX/RtP2bvut t+9TLveM41YHXEpqZSzcQN2IOSOk9TxS4sdBL2b/6mlbLwDbyGPTmihEIkkgerB5Vg61 3bkg== X-Forwarded-Encrypted: i=1; AJvYcCXmYnD8SVFp3oFXwf6E+fNFAeNrzHQrGwBM5J5rUp5Pq7CafGCy5nEkBlIK7J7Dlg3BT05RBgxPBM4mI0g=@vger.kernel.org X-Gm-Message-State: AOJu0YzBA8C7Fxd0h3ho0Rwv9mVtJH3r3+dDGLOJzqeKMje8S2Mwiash s6QGp/mlcOezLZ9slOM/D3mM37ewqIAEF1d6ViUwub3Shc7s2fiDBUx2L7Gjk5+X3SV5wpSL66H VDqSPL6fBeP/JLBy2Lrf8RZx8G+OxpTWBrRnFL0PiD0ghH/XkaA0aEC2clj4kXtoXYQ== X-Gm-Gg: AY/fxX7941YrlLNMam5mHqVTauSQkvWamhq7oli7jjDnyUsVvENPxi4wVJ79CpGpj8d L3UUWNp5bs9a84huvOyMCZzhzlg7sMlBIkKNKB5S9y63YDTuzVMQsaOjvIp1amCBZNTzjOYjUMA ZUbsCNzZiOmL4SRoOO/dvnXfZs8j/lYsVeCrVJEmIG6ZWKFGeW4vSBlHaKkrPCrTilkmxO3vYrh fQP9sRUoqjxpvqCO5b9kZr+OUQKXF1dJkK5TAiTv8lpTPUOqBpehF9nJAp6A0DSnAVb5GstEQeV WFi0obxPYgljEysNy9FSganRvk9Z4wktTx8hB7e9oB1mwH8ksbMhfBgTs2Jqk6X5TzMbQ8I/Ux3 7jA7C1l7+ozwzDSM= X-Received: by 2002:a05:6102:2b90:b0:5db:ebb4:fde3 with SMTP id ada2fe7eead31-5ecb6875afamr3022772137.16.1767907094764; Thu, 08 Jan 2026 13:18:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IFi7pmFryhw0KW5QeCDQ/EVRIv8eiyPnJcDCTHIYHaP0Lu8xIO3tTA2mJwSeqtxfokatvgQWw== X-Received: by 2002:a05:6102:2b90:b0:5db:ebb4:fde3 with SMTP id ada2fe7eead31-5ecb6875afamr3022759137.16.1767907094229; Thu, 08 Jan 2026 13:18:14 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:13 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:31 -0500 Subject: [PATCH 13/27] clk: nxp: lpc32xx: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-13-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Vladimir Zapolskiy , Piotr Wojtaszczyk , linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1492; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=7HOzNeGSRizgZeFkVaCLBp3lcLY0zAl5xQHRspPP9B8=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5HZ4Cx5blLbRy2D+HbH0rDTjV57vL/nFHeNb/8hvi d3CKpf1HaUsDGJcDLJiiixLco0KIlJX2d67o8kCM4eVCWQIAxenAExEtYrhrwjT44OVfnfMT7N3 aJt2ruH5U2LEOjnNy2Ci/yarG2zLeRkZVvRejDyU/55nqpbJYvvDVQ85osViLA6/vJ9zQltoldN 8fgA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 0879768df240 ("clk: nxp: lpc32xx: convert from round_rate() to deter= mine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! Reviewed-by: Vladimir Zapolskiy Tested-by: Vladimir Zapolskiy --- To: Vladimir Zapolskiy To: Piotr Wojtaszczyk Cc: linux-arm-kernel@lists.infradead.org --- drivers/clk/nxp/clk-lpc32xx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c index 23f980cf6a2b59ee1c93a2519fe5188d251fa12f..ae2fa5341a2e4fbe5f2d3ef9a6c= f9e9d75180d59 100644 --- a/drivers/clk/nxp/clk-lpc32xx.c +++ b/drivers/clk/nxp/clk-lpc32xx.c @@ -975,10 +975,8 @@ static int clk_divider_determine_rate(struct clk_hw *h= w, return 0; } =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - divider->table, divider->width, divider->flags); - - return 0; + return divider_determine_rate(hw, req, divider->table, divider->width, + divider->flags); } =20 static int clk_divider_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B40233A706 for ; Thu, 8 Jan 2026 21:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907109; cv=none; b=S4fotA/1YtHi8q7aj2FsgIjVo9JUpCqiT1towscFDyy/YjLThrlM7oWZzPIboIZqC7ei4k3S4wLvVzbH/y9JfVpp47Y9XUE2ELbDTqXTR2Y5t20wBXBK8Ney+NzW0Fqh7q8R4mNFTid3GoIagXPhOsDpCt4mHAh43q7YV6dL79Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907109; c=relaxed/simple; bh=BryXrBazGKNoFl01TDX32keP0bZwmkKqb3aOoVN6Cjw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BmORxL+ky6KU3TMaj7VRPKiTjFHqFGeDmFlvXzcQkqVNgEQVXPzBxrf6Xh+1JrAvTB4+dkA7lzHixpuIMhoVRehYCTVK42quw9EisJVdTcygvD+F6y9djS+bl2st8lx1WR5YfcxTK1O8ihq+ui2E7CovfngopN8Fc62AzK83sQo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=K1F2jZpb; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=A5Y3LLcE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K1F2jZpb"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="A5Y3LLcE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H/qg4+psJobyRC37Ow7jCN1m26LSNdI85IDj7JMoxUw=; b=K1F2jZpbWPGsrk3nAq+VCOneORmlLI4CUvro/Ir59vJ4pmILaEvYsmfGg8pMnAXH8MjvRx IIKQ70mGHT3VSrgivgn/kPBJqCPhwCvjknhDZ+euqMd4wRmBf7czJboHs0dBfzwri1m8PX /YocQBxxsYEd6ukiSr+DHYLiM40yY98= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-Vby7DcXWMMSpdDX-EBIW6A-1; Thu, 08 Jan 2026 16:18:20 -0500 X-MC-Unique: Vby7DcXWMMSpdDX-EBIW6A-1 X-Mimecast-MFC-AGG-ID: Vby7DcXWMMSpdDX-EBIW6A_1767907100 Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-94125ded3dbso8225540241.2 for ; Thu, 08 Jan 2026 13:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907100; x=1768511900; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=H/qg4+psJobyRC37Ow7jCN1m26LSNdI85IDj7JMoxUw=; b=A5Y3LLcEKBo8/88MiR/X64CHJc0Nq3ezz3ktt0AP9HDP1akNQg7Le1Y26k+J0sQIke +cYUzucKGrDca3n1+V84+K0LkBaIkvLQpXgbyfJCLnJTL1hJ34nPwugr1E9MnzQIQ2Sf PEKvftSzSPvxQHOcMbvCsUKGDSax/btsUPDQ6MKhPgu/F/FAPQqsCbP1hRtyQCadap2V oumZBuqNHPfotmUHbdINpCDYuT24S8WhEhHdNqnDFNe+4AA9xlgIJS535dqQ/kda5shg E7kYMCgbwXcb+3eJ105dweZ3Bu41HB6JH5sZrs24rr6EdqGI8Jj172gnOPfHRAx2mZiQ 3Nkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907100; x=1768511900; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=H/qg4+psJobyRC37Ow7jCN1m26LSNdI85IDj7JMoxUw=; b=trb3hrtyWaqxyt6bbrAwXx2w87o2vrs7SJZF7oLcyeGbj9WU1EVosmIgEltTEuL5Jc JhE/K/bUwr33MMfpNzjQ0vOvF2oMlDJlYdmIf+jGfGtYfug4Nu0yiQFC3s241gket+mO dLp8l2/8aVZ2Ee9O+4qrj5bqtLIgLy86N37TpMjlI0p4t3kYGxQ3TWRCiii/P2NJsUtq SLjMF/29K6H2/azmtIeR8ig2QOEavi3h3PcFQsn2+mImuxf0UIBH2yoCwNOe1Wf28QEE GhShIdo4ZbCxLjc2dJfvamm21bYtFAia+fVC18ijcXBOKkisQy65wC/zQb+ugMpl/W9w eczg== X-Forwarded-Encrypted: i=1; AJvYcCWFOcrTXHtwM+ddrBwcEKUiNJRZt4nnIv35fd1SBnKWg1Lk59m6T06QC2mGwz92S8WRKeS/WdguySDDyOA=@vger.kernel.org X-Gm-Message-State: AOJu0YwM+X04+MH/JmGo/ZmWPMMCcxvLqrE+2g8fxD6EIJxDWEqdMW5U Nn3VP3NSKFWFsxmIF79Y6EimCuZL9y2+p33+k3DE9N8p6VCFFgUf5SEVbhJWYLrbk9C53PbQOMi n/t3izakAscIYSeOj39VoeNd4uHxgOySAm5D8qyk7aBIosPNFCTyDLAZHqb+BlyZcaG4p1/eRZw == X-Gm-Gg: AY/fxX7WrNaqrhjAgEFdhkbL9zzmEjyjn0q0gCdC4zg78lrKFo5XEGP9hpqGnQH2TfN s79CwD9NxHTjSgjvGlg8sFP6blM5g40bosv9bxSZ1N4MJJtSI+nVOxRamGKrXkzlfvm9O0Xwn/p K1uFuQ51LUa9ZdZgu0i8+PRih11048UydvFfv6P0tSGSL2XY/PkqiQCw7hcrt1S4FwPMo/D8T4j Vb0Cb90mozt8AEWesOpzpYm1h99gVhVYL61lz9TM1zykXe9HPF12f76zqTr02oHqQrY2+oI0TjM ZUnZJWOgpfLBawNgKD9Zm8tarp9zW4XKjuwgwduu4WhsBLzwSsHzIe3Xs/vtlFs8HHh36RNjWzK i+GbUl4S/JTyGzYo= X-Received: by 2002:a05:6102:2d07:b0:5db:e0fe:985c with SMTP id ada2fe7eead31-5ecb6853a90mr2981778137.10.1767907099670; Thu, 08 Jan 2026 13:18:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGeIK3vJESvdFK2LZdGsxL/Aj0lfkI8WxHqP14EuDMLA2/se9dutUiwsxhVFozUz0NuzGHQXA== X-Received: by 2002:a05:6102:2d07:b0:5db:e0fe:985c with SMTP id ada2fe7eead31-5ecb6853a90mr2981772137.10.1767907099246; Thu, 08 Jan 2026 13:18:19 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:18 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:32 -0500 Subject: [PATCH 14/27] clk: qcom: alpha-pll: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-14-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Bjorn Andersson , linux-arm-msm@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2529; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=BryXrBazGKNoFl01TDX32keP0bZwmkKqb3aOoVN6Cjw=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5HZknJGs+KEXnBLBtvTUvuaOoJspXgLnrhuuOMSbU 3hlx5ubHaUsDGJcDLJiiixLco0KIlJX2d67o8kCM4eVCWQIAxenAExEyIaR4fWv0MsCIgdZTz2e EObx/iWTfuKfmKvH9E/s8dWW5DzgsJ/hN9u2j9tqnD6ny3s0ca+om3PS1Vx4stGxtSIhTcenxBm e4QAA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 0e56e3369b60 ("clk: qcom: alpha-pll: convert from round_rate() to de= termine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! Reviewed-by: Abel Vesa Reviewed-by: Konrad Dybcio --- To: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org --- drivers/clk/qcom/clk-alpha-pll.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-= pll.c index 6aeba40358c11e44c5f39d15f149d62149393cd3..a84e8bee6534629bf578af6d259= 2ea998f6c9090 100644 --- a/drivers/clk/qcom/clk-alpha-pll.c +++ b/drivers/clk/qcom/clk-alpha-pll.c @@ -1257,11 +1257,8 @@ static int clk_alpha_pll_postdiv_determine_rate(stru= ct clk_hw *hw, else table =3D clk_alpha_div_table; =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - table, pll->width, - CLK_DIVIDER_POWER_OF_TWO); - - return 0; + return divider_determine_rate(hw, req, table, pll->width, + CLK_DIVIDER_POWER_OF_TWO); } =20 static int clk_alpha_pll_postdiv_ro_determine_rate(struct clk_hw *hw, @@ -1617,11 +1614,8 @@ static int clk_trion_pll_postdiv_determine_rate(stru= ct clk_hw *hw, { struct clk_alpha_pll_postdiv *pll =3D to_clk_alpha_pll_postdiv(hw); =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - pll->post_div_table, - pll->width, CLK_DIVIDER_ROUND_CLOSEST); - - return 0; + return divider_determine_rate(hw, req, pll->post_div_table, pll->width, + CLK_DIVIDER_ROUND_CLOSEST); }; =20 static int @@ -1657,11 +1651,8 @@ static int clk_alpha_pll_postdiv_fabia_determine_rat= e(struct clk_hw *hw, { struct clk_alpha_pll_postdiv *pll =3D to_clk_alpha_pll_postdiv(hw); =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - pll->post_div_table, - pll->width, CLK_DIVIDER_ROUND_CLOSEST); - - return 0; + return divider_determine_rate(hw, req, pll->post_div_table, pll->width, + CLK_DIVIDER_ROUND_CLOSEST); } =20 static int clk_alpha_pll_postdiv_fabia_set_rate(struct clk_hw *hw, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4503333AD94 for ; Thu, 8 Jan 2026 21:18:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907115; cv=none; b=Sg56Dnd3XbqyVDTmEu4PJ+JYQi9v8IzPiyBhA14m0ZCHrWnppvLlxPRW4FMjWmaNWN8z71qkK2FxC0UCRr46sN8eYVUnSStLbo7wJiOig8G2yAlNici+PmHvkanpuA765as+LavZfIlRuim8Y9KAtZIk1Zuhgnxgat/VFaxZeu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907115; c=relaxed/simple; bh=du1Xe6+sJ/9FCDiGI+GnbfUkgLY8U1mL73/oBpGj0IA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QLASOxku+CdW+YKwZ4BSI044OOe6bGOTJJT3IlvTd8zERwYTuZeFMLHKHTykf5qu2M5u6QrjU5wL4Havw87dIrWpx8yODv7W4MTnSq0yvUqFQQTc+QkkplJsg0HRVLfeDjf0RE6TTG1l16OoaxxTiPVSgCZi8/S0Hi4HzcBDVd4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gtlTBoya; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Vm9k8qj1; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gtlTBoya"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Vm9k8qj1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kyENCUC06yLwn97ZLVCAPwAscKa4jHnikLex8sZo8gQ=; b=gtlTBoya1hM2kfVZdddTVsQFzbLBpia3IDLiAv5h3HkLeZ8CTkRfpABerTJH7/pPk3APBp GeEkCfUYWQW2v9Fj9RpaURICBiKCHYNBHtU+un6d1stC8ao/eIkDXUkH+HBkrI8O0gFNH/ TjwBYASmCApqFBq7w0NrIQZgQyJfgBA= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-38-vQL8hi5nNRSEzzhUE7stjw-1; Thu, 08 Jan 2026 16:18:27 -0500 X-MC-Unique: vQL8hi5nNRSEzzhUE7stjw-1 X-Mimecast-MFC-AGG-ID: vQL8hi5nNRSEzzhUE7stjw_1767907106 Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-5eea3c9e00bso1071653137.2 for ; Thu, 08 Jan 2026 13:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907106; x=1768511906; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kyENCUC06yLwn97ZLVCAPwAscKa4jHnikLex8sZo8gQ=; b=Vm9k8qj1yzFFn2p1L0tyGsoJpXFxngpWSYs8ftaM7wfVbynpSlCsNIueseszDWq47j PzMCj/KsHd7ULcslRRDcI9hz9UEGVJ8e/wdiPYtGZu3AMIXv6edTGZr6p2DeYXlH2PvJ Q91UVGT7e9nLixm+zcN+M6yAL0ynYlC+TQYZMFdYJAVc7r62xLvj8qOB9QhYxfuHIQH5 a7WURTXZHH536IKrli6RKX/qBm45x9d48VAN0sn0PjySfOP564aQQ3rsyX/Uy5o0Cf0H E4Rnc+khbXz9b2SxyzNQXQ0bshnPk/4QXoAeIKe7OVjQoCy3BFDojx5EwUQogxb+hAIq m3Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907106; x=1768511906; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kyENCUC06yLwn97ZLVCAPwAscKa4jHnikLex8sZo8gQ=; b=RrVIVJTkn+2VUvyZc7muMfMQyXs0UGPRayE2sqgmyiVswbxlqSGGo90GCDQpkZIK16 28PWHWTAK8lVSHZUlaDJnu7kn6kFoEwNz8cCGrFzWDt/zl/hU/4sk0L3UIPTCyQMoBYM wXrUfw/cqJm6LYjzOhhUEx6vN/u9GFw/ALl6Y8zphcawDEOaRclLZEz7nA3F+p+RieIy +yFvVbZOBYOIwRRC1EsjczT5me2XiZBGX1cqGnU/m64vjKUokwEF10fshpYc+N+Q4tpM JGEWCd+69jPz88WxwsGHCoEiOSgLQkERkIBQQ3hjbVHnPkimWYahHPOReDZT+q/K/6fP Y9fw== X-Forwarded-Encrypted: i=1; AJvYcCVW4t/Q1GrsyLTeZsqvgowbiqi6mEBP1SfyaAjnaE6ysfip8kqHxSjLWSyHA3PfIiJ8k80nY0Y+9UQj45w=@vger.kernel.org X-Gm-Message-State: AOJu0YxEOJPPqgmU3luGStB6RjA7u6YpkYG9tF/s8JTfRvB4C2oGuOXH 25da5pWq9ny3a0EZmu5voJek9bylbgaQpY9+utN8wuKhUWDfphv4dB8pvyou/IPEbxBxezBQqu9 3C3cZ7NjKDv/g99Hxiqh86mJXySfZnQ9s0HJ9xo5fLPO42rnxkV2pzhv6NoMBNG23Wg== X-Gm-Gg: AY/fxX4mX/VGY3+rp2SfmzZKHIRFfbJPgX2kjr1YHwcVs/L3kqMctGbsYUtaoFUm7Fe rdaQgi4QCaQs3EQE79AAtixL4Jzkp9e5ZNaLqAUyouC2gC2uLJvkk5bjUM759thhspHHf35Eo8J ASxjDWkeR34sbUJXN+xtbhVUpfnt+gSy4/VAXuxNfZaFBgyHJV3u5nBMm1zgjsMu8SokfNsDpFf jL0QTbXojabXDPQpYTmzJQAU4J8Hg61uMbgSyHDu/YmuxjMUWyXyKCG0B6xg4C3E7jitHap2Ror 4Vz2f7KVf9v3IZbjZHwsBt3sNBNdNvZnOkMz3gu0JmMfC6QYRAyrkRKjsoy2viHbf63JOe34MK6 WZdVicG9gq6vET9k= X-Received: by 2002:a67:e716:0:b0:5de:8ce:3cb0 with SMTP id ada2fe7eead31-5ecb5cbb301mr3229157137.1.1767907106526; Thu, 08 Jan 2026 13:18:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEA0Kg6G5fUNtSpWfcuvqTzw14WB2ReMmWmnvR2nyyJ8lxMnn7KB1EFTL1i/rv/Ooq/958J5g== X-Received: by 2002:a67:e716:0:b0:5de:8ce:3cb0 with SMTP id ada2fe7eead31-5ecb5cbb301mr3229140137.1.1767907104694; Thu, 08 Jan 2026 13:18:24 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:24 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:33 -0500 Subject: [PATCH 15/27] clk: qcom: regmap-divider: convert from divider_ro_round_rate() to divider_ro_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-15-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Bjorn Andersson , linux-arm-msm@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1579; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=du1Xe6+sJ/9FCDiGI+GnbfUkgLY8U1mL73/oBpGj0IA=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5HY4BJo1e2jdZnjzY7pI7sN2ny8hr0SUK3mFTk49U 2zL6XS2o5SFQYyLQVZMkWVJrlFBROoq23t3NFlg5rAygQxh4OIUgInsncDwP3pZCM8Chy0Kuvee dUycGPbjzeq3OxRO1tqf/jrFbadbQhMjQ0fV5YNHT58ze6uuwNpQb/LoQGmFvURo9M2CBn+hNxG uzAA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_ro_round_rate() function is now deprecated, so let's migrate to divider_ro_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 859a7e020b23 ("clk: qcom: regmap-divider: convert from divider_round= _rate() to divider_determine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! Reviewed-by: Abel Vesa Reviewed-by: Konrad Dybcio --- To: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org --- drivers/clk/qcom/clk-regmap-divider.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/clk/qcom/clk-regmap-divider.c b/drivers/clk/qcom/clk-r= egmap-divider.c index 4f5395f0ab6d0ed8cebbb32cc231063932ba85a1..af9c01dd785372166122224e717= c119a2365f4e1 100644 --- a/drivers/clk/qcom/clk-regmap-divider.c +++ b/drivers/clk/qcom/clk-regmap-divider.c @@ -26,12 +26,8 @@ static int div_ro_determine_rate(struct clk_hw *hw, val >>=3D divider->shift; val &=3D BIT(divider->width) - 1; =20 - req->rate =3D divider_ro_round_rate(hw, req->rate, - &req->best_parent_rate, NULL, - divider->width, - CLK_DIVIDER_ROUND_CLOSEST, val); - - return 0; + return divider_ro_determine_rate(hw, req, NULL, divider->width, + CLK_DIVIDER_ROUND_CLOSEST, val); } =20 static int div_determine_rate(struct clk_hw *hw, struct clk_rate_request *= req) --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0AE33382F9 for ; Thu, 8 Jan 2026 21:18:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907121; cv=none; b=XOgGGM6qpHW5fc8Mj7ySztpDvmXvhjS4lEob+9UQWn/WtGpBgmZ7FBvklKcGTczWq+KqPNQT2ihfYjpTqwVJg1iyKdWhl7MlPbi253AbsMhQuVTRy9V78XrWA5jAsbRSGixdsknAqnuBiGLsLmKoM/UrZpVClixGkyBdCd8wxHM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907121; c=relaxed/simple; bh=jKoFCsEBXQYv3wszRGARIkmwQoIgPv/cscixawXTpW0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SevmYmW89OU535VUpMu7e75s4RApNduZjNInabCqxNjyj2wLT6CR6A8Rln/P+NDEoYiNb1AvBP5fTWW6+0uMDA+WBdIG9RM4RrprDvQxqQ6xURgIuBobjwA8YXXhVcoJZDRxT1Gz/fCHeL1m1RgBIpzQB6qq4b06dEof3lHwITw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eKLCYDZy; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=fGyJbHGM; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eKLCYDZy"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="fGyJbHGM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G319IdeSa6D2FCy2w1nMqWvaYhCLIz6HSe4OLMwnyMI=; b=eKLCYDZygPmnv+IAtmvJk0oKXKKVNMsh8qBaQ4g413Xj1TijpewlKQlxvDkUSiQB46SMu9 2gOgAaO+7CWy7Og/zFweEaNY1ccKV6MKmHHs2s5aOb4K2XvZbSe4hIInFBPs5fOEIxn5fA VLPyeSsPUnh+crUnkJOgAqi3sQuvVH4= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-184-li64EeaENHu5qIPzoaO6lA-1; Thu, 08 Jan 2026 16:18:31 -0500 X-MC-Unique: li64EeaENHu5qIPzoaO6lA-1 X-Mimecast-MFC-AGG-ID: li64EeaENHu5qIPzoaO6lA_1767907111 Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-93f39594413so3800347241.3 for ; Thu, 08 Jan 2026 13:18:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907111; x=1768511911; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=G319IdeSa6D2FCy2w1nMqWvaYhCLIz6HSe4OLMwnyMI=; b=fGyJbHGMmlZQFzeagyMJdCWUEXtXCpQJBtfJdDapbBWEpaC/iPCRWfrGg2/iyf99At 1WTX4WTztamFq0wvre51W9alO+dnXCr7E52McIV0ELAgG7RYHjzcqZssHOQ268PzT9Io mA+HDUgQPSGJ1Dzi+5E9wctOorbXi5fTJZeAVG4HIiMno+FV+azZR9x0NCmR0EHOAL12 2FmFPFjJS5qsJPGspvAlqqX9r5ffHdqj0RDHXHtPImj7azmaOSWDyekNxP/gi/ZtX2OG 3K9/neD4zcQvWg2i6cR13qs8j4JS9tp93TQkLcxZr4nbUBwOlsDoewmZqxGXm7cnRhjt Md7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907111; x=1768511911; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=G319IdeSa6D2FCy2w1nMqWvaYhCLIz6HSe4OLMwnyMI=; b=DAQkQ3ro8MyNu7D3ntVmvjmqImR+h77NUSMPnDhe1rMSfSKnOXcZvm1s+dPPs90gtd hOzL6f09qf3dwZs8Tb5VIHa4+MayhJX8tQzlNS0QvR+UDGXN4wM9uLdCa9jILXjg76nX qsFwRcQU9VWjsXUOKHc4HRDAdup3tqOzTRoB3+b2+dHvASQZozJJsel/GfJrPv1qXPUn I6XxRwRsYoDo+zCDWYLTwQIqdu3TZrr1ChvIkos4ZJ1hXpmCjWRTLQyD4PV9QKl/0/mZ F9B6c6XIDATzlyfpmYujWZlkrJDlsfZMQUYTiYD26hla5BuWmZzNedWvRKc7RwMkl9vq Rgyg== X-Forwarded-Encrypted: i=1; AJvYcCVhpTv2q3xrdYQ4p+Q4DAShQh4LLs2HdX2FHUkIvKayXoFkM7t8+EbdUnvdP3CzvPRCYDePWFQI9bmX89M=@vger.kernel.org X-Gm-Message-State: AOJu0YzMmp6O6qmu73KNVTPeBnSha5WTR/5WAvTznpTSsL6lZWuBAXQ0 8mLh/e0fZcj3C/9jN3q9lN8mjMqsOxUOlzQTRBdi3kubrDwn/xr14j9soxTV6SPLnCXQnZ3+Wdt yBCrV4wZtdcIYSpLMavvPn0Pk8erykymawoh8G7v0+AIB0cObiWW4kk0qc4WvwIvsxQ== X-Gm-Gg: AY/fxX4R74FYiOp/y8NOW5mXmQbJMdEo0VdwFlne5yt+4SMcCpe85sd2WSCLkpIxhaq YwQ2p0SMQD5vnUQQ17AGrgyx57H4TdMyAT3n98feY0BfwF943n5VJvV4qRURzxQF1NWYk4GS218 F5mZYVnPA8o3neAPxBOcQAaNMqlqqjjAYfVgHIIJucsV8j63xEGUQEZjBoAZIIFFTxJzDtXH2oR gGBJKq1nuyEszpRI5dg1aIKlVpdhGDt1DQ5upAv/dc+/+UQq3wcQJJTlZRi0T9xDPXmrs+N9guy 9PSGIg4z33Yxvw6ld7Zchllbnh3Ij4+tCjRuZFLbZ+ovl2ECPErCrdiWFYc/6M2AikcFmMUiv2/ +nxY4JtoZmZvcq7g= X-Received: by 2002:a05:6102:605c:b0:5ed:c98:37d6 with SMTP id ada2fe7eead31-5ed0c983b74mr2379683137.2.1767907111125; Thu, 08 Jan 2026 13:18:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IFQG9r/cfeCX4euCrFgcXsjUzjAkSa0Qn6QkdRAVCwULp0yuaXtFnMp4bzwiLqhiT0LgSUeTQ== X-Received: by 2002:a05:6102:605c:b0:5ed:c98:37d6 with SMTP id ada2fe7eead31-5ed0c983b74mr2379668137.2.1767907110607; Thu, 08 Jan 2026 13:18:30 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:30 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:34 -0500 Subject: [PATCH 16/27] clk: qcom: regmap-divider: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-16-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Bjorn Andersson , linux-arm-msm@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1569; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=jKoFCsEBXQYv3wszRGARIkmwQoIgPv/cscixawXTpW0=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5HbUHDGfOfna4u2eepsUzj3ScAxyq9zPfaPF0HHJU 7F1Mh9bOkpZGMS4GGTFFFmW5BoVRKSusr13R5MFZg4rE8gQBi5OAZjIcj9GhtUClxmE8ztenimK Lp2i/MFFUnSZ+bLL0jHF0/bKTt+gYMDIMHdhWgNXdo643aoNdk17ND8Jc0S9nhieKjir/fdri/Z jjAA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: b6f90511c165 ("clk: qcom: regmap-divider: convert from round_rate() = to determine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! Reviewed-by: Abel Vesa Reviewed-by: Konrad Dybcio --- To: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org --- drivers/clk/qcom/clk-regmap-divider.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/clk/qcom/clk-regmap-divider.c b/drivers/clk/qcom/clk-r= egmap-divider.c index af9c01dd785372166122224e717c119a2365f4e1..672e82caf2050446d14e64617a4= b90d0b09201a4 100644 --- a/drivers/clk/qcom/clk-regmap-divider.c +++ b/drivers/clk/qcom/clk-regmap-divider.c @@ -34,12 +34,8 @@ static int div_determine_rate(struct clk_hw *hw, struct = clk_rate_request *req) { struct clk_regmap_div *divider =3D to_clk_regmap_div(hw); =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - NULL, - divider->width, - CLK_DIVIDER_ROUND_CLOSEST); - - return 0; + return divider_determine_rate(hw, req, NULL, divider->width, + CLK_DIVIDER_ROUND_CLOSEST); } =20 static int div_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9A0B338939 for ; Thu, 8 Jan 2026 21:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907124; cv=none; b=bbk5riIZRqrGbiT1ZUQ5xlahlhvvMxMaHcevEw+AMh5C7/csAhR47n2vf3iZfYOk8npkYsxPDY6kUi0d3qejdqeLuRsRpskmu8DwP/S8vpOVS4j+9htaz39Z2radI6hmTW4UDR8S9Qu2YPK5N29MJMLPMprL32zOTOLPKF75kc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907124; c=relaxed/simple; bh=Ge9eXc7hiD/dbOFdwq4ZbwJA1t1aWqrp8YuWJZaaqt8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mq40Eu0lMf4eK0MEvmJiVOoHPqqIbAIk9B5Eohm1Q8xx8hnLi0NyzmG5U8uKNlw9+Rck4GS7GWUoWsdXbQGG9dqUBjM1xJbSMC3zx8WjYWNtF+UrXJEpoCrAwhjkeYp8jyFionC4HtpluZKMdgF2BSHww2SC19C78k96ImdsRFY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=evQSZQ/i; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=dk7JtmFF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="evQSZQ/i"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="dk7JtmFF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/fdI4HNVMXpScbiOdWnmJAMr7E0Pkfpku5YlZKipJgA=; b=evQSZQ/iESK9ecNgYaOQz9zcD16Yms+nToPRahPorISktxNc6YhHeAm3H49xi8POvtW6wG lGewxBnjDT125hw+SSRTgl7ETaUV2t6EAHNmULQ5ZxrEh6sTr8x4gu4zbzsMhSoIUdubYd ejY/CvqyZRRJSLj3iu+NQWZKpVh0mU8= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-QewEtVmHNeurHiudeTUiyg-1; Thu, 08 Jan 2026 16:18:37 -0500 X-MC-Unique: QewEtVmHNeurHiudeTUiyg-1 X-Mimecast-MFC-AGG-ID: QewEtVmHNeurHiudeTUiyg_1767907117 Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-93723fdb00fso8141954241.2 for ; Thu, 08 Jan 2026 13:18:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907117; x=1768511917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/fdI4HNVMXpScbiOdWnmJAMr7E0Pkfpku5YlZKipJgA=; b=dk7JtmFFP5awEj8IFFBjujaWbIiRuSFy3fmnM6Wshq62Nc27/dSO0DwnrfappX5Wbr nkW3oB5p4UXxhuAEMtyk8rtX2VDmhsCd18daZFwaViS0bUOvrUzDVV8PlXp9VjNOekk2 MkrLrzp+ruhfhswFMOjh21t1iEdME8nVruw4NSefQN8X/5qukTJIbAD1cFhrLcY4LxjF qAEZcf5CvtU/uJ4+u11lzgtJC1+D1JuiN1hqIpW24H+Xtx7O+lBqdNpKAGxrTyJXYASU Y+J3SPEFfTxEq/YCHP869OtOyQtu/AtEMdlKj9ceeKJ3f0GMcYlTDws/Qm3XwIb+UzPI oaCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907117; x=1768511917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/fdI4HNVMXpScbiOdWnmJAMr7E0Pkfpku5YlZKipJgA=; b=Sr3rUnsU5hdAZKVuue0hcA16K/yfAZBrUjFQMdPr2YJdyAHT3R4bG2XkWrsdgIxLmM 5QDKtwOE8faXjctrKOfLmDEsQUxxjwoWjaridDqTIEV8JM4t+61AVLHJmTmhAAFEa8XY JmvGy7rD1cgaql/zZzI8LGWBxleWjv+eBj+GFQvajIDGQlspuegsLsd555hAOXDHDbwa PWaGFU4ARkWxd1ZWI4RPncLI2UWhYeIQsn6MCRSDzH8r8EmtvRgkPabCv13QImqtGiD3 fdauGYHVtVQYekmCelZqsYGPrtW3NOJ0WhW5nyjBakHr9sH3XCOticG4vsu9vrz6RTJ0 5Zmg== X-Forwarded-Encrypted: i=1; AJvYcCXbDWu+8//FtKUbEnbpKWq1Lia3RAMYwy24J8cMU9w8z50QrcGtzUOPA8OzkHNR0ZKcW2qTunDNtdfM3tk=@vger.kernel.org X-Gm-Message-State: AOJu0YzSRggwPMz+pYuTD09TDiJKENKYW0aF69LLZdlXV03rmY3jcKEh rTUr3gJWSMthl9LGQpvSVS3aNQ/TNu+rdhhCfdIBVpnWhnC0uwnkWFykva8EXxV/H+R35riLHqi PtlpY1AVYez2TvtuWMzqxjNtnFOnnvOT8LglT+moANUGz+7a3+vtEqf0K8QU/al6ziw== X-Gm-Gg: AY/fxX5sfMBKsX1foAztFnZJLX11E6QlC4rU5tDIkdrHVgjn0RvveoXv9jPHhE25vVg b3VcCo8sRXawa4FDZhfrznBqgJFVXIO0XhwsiTCTlK7RVR2kG0ooyUc/oWONml/rj9hEHCWCTY9 sdwosSyG5bhicsMC+Yi2rB1hMx3hhl3Qf3yT+2U8NZ9d98SWAyVNljUkvJ/Pv+HBlwqIsMYzZKC L8hENJS9j8uOwpF7fb8HWIHnBQyjVFsjKbTtI7Mo+fhvDP43/XGQ2sirWJbAxq54eUmf5W3j/nJ wQp27hEmfoPTm2saqif3xykCK1wue1bhtrhI19IjYbiZkIuGvquuhLkNOxNKqIImz+boa6g8Bwe KHmym1PbbOC01Uq4= X-Received: by 2002:a05:6102:161f:b0:5db:ce49:5c71 with SMTP id ada2fe7eead31-5ecb687fccdmr3306763137.18.1767907117138; Thu, 08 Jan 2026 13:18:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqkSY3g2BRFtVH/hTwOCP8SDHCsAmoUI/QIHDt4YAq9tFbNnfPKjO/MN6CStqRG69amOeAKQ== X-Received: by 2002:a05:6102:161f:b0:5db:ce49:5c71 with SMTP id ada2fe7eead31-5ecb687fccdmr3306747137.18.1767907116769; Thu, 08 Jan 2026 13:18:36 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:36 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:35 -0500 Subject: [PATCH 17/27] clk: sophgo: sg2042-clkgen: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-17-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Chen Wang , Inochi Amaoto , sophgo@lists.linux.dev X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2276; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=Ge9eXc7hiD/dbOFdwq4ZbwJA1t1aWqrp8YuWJZaaqt8=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5HaYum9WmXVj6rbsy2f4dzpsW9yyZHPyW24TnwdtH 9OOCC5m7ihlYRDjYpAVU2RZkmtUEJG6yvbeHU0WmDmsTCBDGLg4BWAiFecY/te7KlaaCBU3MLco CP6oUzgTsVrRaPqa01/lfQzZLs5LV2P4p/smNuhbq3RQ/K9CF/ncXdfal2aUnT3y8Ijd1or3m5/ PZgQA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Note that this commit also removes a debugging message that's not really needed. Fixes: 9a3b6993613d ("clk: sophgo: sg2042-clkgen: convert from round_rate()= to determine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- To: Chen Wang To: Inochi Amaoto Cc: sophgo@lists.linux.dev --- drivers/clk/sophgo/clk-sg2042-clkgen.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/clk/sophgo/clk-sg2042-clkgen.c b/drivers/clk/sophgo/cl= k-sg2042-clkgen.c index 683661b71787c9e5428b168502f6fbb30ea9f7da..9725ac4e050a4e6afd3fd50241f= bd2fc105a31ca 100644 --- a/drivers/clk/sophgo/clk-sg2042-clkgen.c +++ b/drivers/clk/sophgo/clk-sg2042-clkgen.c @@ -180,7 +180,6 @@ static int sg2042_clk_divider_determine_rate(struct clk= _hw *hw, struct clk_rate_request *req) { struct sg2042_divider_clock *divider =3D to_sg2042_clk_divider(hw); - unsigned long ret_rate; u32 bestdiv; =20 /* if read only, just return current value */ @@ -191,17 +190,13 @@ static int sg2042_clk_divider_determine_rate(struct c= lk_hw *hw, bestdiv =3D readl(divider->reg) >> divider->shift; bestdiv &=3D clk_div_mask(divider->width); } - ret_rate =3D DIV_ROUND_UP_ULL((u64)req->best_parent_rate, bestdiv); - } else { - ret_rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, N= ULL, - divider->width, divider->div_flags); - } + req->rate =3D DIV_ROUND_UP_ULL((u64)req->best_parent_rate, bestdiv); =20 - pr_debug("--> %s: divider_round_rate: val =3D %ld\n", - clk_hw_get_name(hw), ret_rate); - req->rate =3D ret_rate; + return 0; + } =20 - return 0; + return divider_determine_rate(hw, req, NULL, divider->width, + divider->div_flags); } =20 static int sg2042_clk_divider_set_rate(struct clk_hw *hw, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DF973385B9 for ; Thu, 8 Jan 2026 21:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907131; cv=none; b=V3GaKr1RZymEC7HCzDD94wmZL5+/TSFJq7IXf1NDS1CLHHHSbEdIrM6WEnE/dbch8/js7W4zZ7ILOruMaeDfazVCL5Po3qedc8V4qluvm1k2t7UTmEJzd3PY3nWXI1GYhYZqazHnWQ99GCvhMwpT/5S5YHsg6uz/HY5B7OCwX3w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907131; c=relaxed/simple; bh=TysRYy/gQQgM0GLhGA74IOLE9yMBw459UASltWTRaQY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dvSHPp7PZOqk1iRc26vhyWI1QUjGNX/eJSfIrgaLANNpjfUUX2yhqyzJiDHabttwMND4la2QyZItM/QfHdWh+TXwUXgYM/57aVGfOEf8BOhhmqy4vmRLdF0OkZ08ignd0xG0ZOUy5aKxPUajZGnCEJnMPjK2H6Q7AvhCXNdcAx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QnTSnocm; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CxNy90dG; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QnTSnocm"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CxNy90dG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YavRr7tD53+Iqm/m2cy93MkIpaPScRdMDSAkvnUvvOk=; b=QnTSnocmWW97Bnv2O8TnkimyWsatOTywhxnAHHmTyB0RLrBoN1r18lOv2/KnWxdI4TbP8P UPOt914eLh61HFlFd31mCXd8ncZxTC/e1XcpzNlC1H/W1VyCayGCg/FO3a0Dxu+0+imdck qMOAIkPjEADXrMSOstbBd6efvJ0jPrg= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-UcM45DcSN1OLt1wlXx1r_g-1; Thu, 08 Jan 2026 16:18:43 -0500 X-MC-Unique: UcM45DcSN1OLt1wlXx1r_g-1 X-Mimecast-MFC-AGG-ID: UcM45DcSN1OLt1wlXx1r_g_1767907123 Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-93f5d18f105so3727138241.0 for ; Thu, 08 Jan 2026 13:18:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907123; x=1768511923; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YavRr7tD53+Iqm/m2cy93MkIpaPScRdMDSAkvnUvvOk=; b=CxNy90dGXmlIXoD9/3Y4n65whvGlt5j5jGPXmpuqPbZ7uCl4tUF2ZMnfcSnMwwMDAB fzj/LFRnJpxLejJSxeHd67GOPHlSt0i/DKom3hJ6wyxaPSLTvMRPUQTmlK707j/IjKle gFGL0jUOBGOku8zo4iVYbhLO2SgOVAX87q9es6HvMYEVnVmALJk1EuPsbYXFjUGHR4qT tkZnMvD2TPJMv55NMllOt1Dlm7aNhnUUnJqkekQK422Yy7OipVKKknkDsS5ACBmxWguV gyKOaUhX1HQMVcpj34QNDVY1YY18+ThxHIte7ZoSWZGdTl3+kVx5uAxhq/c2CR/wXvsm cF6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907123; x=1768511923; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YavRr7tD53+Iqm/m2cy93MkIpaPScRdMDSAkvnUvvOk=; b=UU0dRwHxboLuqYEIxXYBp/jAdi5WAx8ScDWGef0f60xSDZPQruq49w4QuWWcTTJ237 RvktBOhd/dEVvx4PcmtX6QMMlfVdd6qXd6YHYxT1VyeR8XEjvuOvvGY0ja8vndLmHEZx gbvt6Dh4SIunR+R6c+ZJ66n40ig27lnOrodlUyzL+UyvUqBZ5hGn/saAubk21P+vcWVN 4qBzv4qb0Ikxgl/973hQQ3apqQgStxrt4FFda72LQqaouJW7ej/CdGBFNJA+zIMEzghL vo9YbTLx9+rMcTrwd5ce7iSjNqvneYflR9jC3keDPdz/SdjoaiwUjHx9BEke3kYaAzZ9 0kXA== X-Forwarded-Encrypted: i=1; AJvYcCWFrywkqy3JUTrbMzOH9VMTU0gbpazlmHnu2f5rZ2Uh/BZz7x6mnavLgZWWPw5MMTa3o0BjEqfsk8NOwpQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxnAzdsUgQ5fbggHvn5GvlvVUxbSegzB4j2Up69qXdMfqpAFNyS IvNA/2UYDaob0m4fUP/YBxpfqhIoXpAltewtdcSlVnM6ICSDMzANcepKajRaYfFQU6VRgAEDy5J 7p2thfTsN8QmxJKtut3CY2lMfe44C/jJnoTC4LJbMICqVhVm/p9KMab2xnplmyHCa+g== X-Gm-Gg: AY/fxX6d92REdGNTyiPDfH8C1WyULz4w7GfwBJt+5/mFIe890Ji4OIqv17deKjZ5268 sAVGKcXC19TDFHLJpAPYhyhevRQzARuCgIsnAuEpTh+J4xaFIXpiqrDDEgCm7solgpdio0EA0aU lUxIpFggepGlyp5UgXjVzB1YsKH54aaTeGdtkls9vqEyAjdipp81qkan/vBaJuYna6dCylzJoj+ 8hcSeC5/SQdwY7J6zgiRYOw3rCKE3AJP7+TF4qywofeOcwB/dSCNSEKQcNZVPwYGqq+FaN2iVmE fG09tT+Us6hF9bjFEAnTdR6xhjpK4qdZpFtwbEkzfr+4BIPCvoSj0YOd8T3eLbumYWIg8D79Sln xA6FFTeLLrNm46ps= X-Received: by 2002:a05:6102:809d:b0:5db:f031:84c7 with SMTP id ada2fe7eead31-5ecb6976443mr2887999137.30.1767907122838; Thu, 08 Jan 2026 13:18:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IESRZY+xwGXEjtYBUr8nTePjn6rv0uzLYHmgbgzlphN/KzO+D2ZKj8n9L0dI2Lz7EbGBVfpNw== X-Received: by 2002:a05:6102:809d:b0:5db:f031:84c7 with SMTP id ada2fe7eead31-5ecb6976443mr2887990137.30.1767907122345; Thu, 08 Jan 2026 13:18:42 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:41 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:36 -0500 Subject: [PATCH 18/27] clk: sprd: div: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-18-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Orson Zhai , Baolin Wang , Chunyan Zhang X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1451; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=TysRYy/gQQgM0GLhGA74IOLE9yMBw459UASltWTRaQY=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5Hau6wvYNc2o2Hvub69jOZzR60od1va0R04yseALP 3BOUz+ho5SFQYyLQVZMkWVJrlFBROoq23t3NFlg5rAygQxh4OIUgIkkWTAyTHXZWLiMefGki02R dY9stz4UbNp9ycGjseL/p/PG9w/xSDMyzJortZujY3+Gv+CpPtNfRR88lybP435rKzA3qYdnX+Y aZgA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: deb4740a5ff8 ("clk: sprd: div: convert from round_rate() to determin= e_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- To: Orson Zhai To: Baolin Wang Cc: Chunyan Zhang --- drivers/clk/sprd/div.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/clk/sprd/div.c b/drivers/clk/sprd/div.c index 013423881968002d29c4e9536e7cd7b944779196..cd57163a7204c0b21ac081bfda3= ab57cab28fbc4 100644 --- a/drivers/clk/sprd/div.c +++ b/drivers/clk/sprd/div.c @@ -14,11 +14,7 @@ static int sprd_div_determine_rate(struct clk_hw *hw, { struct sprd_div *cd =3D hw_to_sprd_div(hw); =20 - req->rate =3D divider_round_rate(&cd->common.hw, req->rate, - &req->best_parent_rate, - NULL, cd->div.width, 0); - - return 0; + return divider_determine_rate(&cd->common.hw, req, NULL, cd->div.width, 0= ); } =20 unsigned long sprd_div_helper_recalc_rate(struct sprd_clk_common *common, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9105D33A032 for ; Thu, 8 Jan 2026 21:18:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907139; cv=none; b=LYPF9WCmOGdJoBjMe+dDekBEJ5//dCIcaQEcpBjCMGlkdSN7/RUGxSRF2633xPkzkmLP5VsArOs0f7Mhmx/eYIk8szYqDLfWbEQ6T9JDMA+7yhb5ks8q3nLbnnpT9GGREwFBUQxBJV4QthcCS8qk/EnSsp/8VztBdLIDDgMkmIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907139; c=relaxed/simple; bh=HZjZ3HcnfJ6Gv1Fz5dnPy/7RL1U8mVqJINJWM79xQHk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rBSgskX64sZ6aZKg1h3v/j5dOWqbIQa8F0eKfEfsmzrIzP9ibEm4/UlZ1CR0rV8i08++Gb/B3gVYpDx+sHgZxdiPoQHhr71U49X/eDN7+c+6HlktFkbxvP5ko5OfJJ36Fsv7bHJz5cfiv29VTVI2Uot7xd4YoVlNUVUsGkY86is= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Oguv7V+F; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nU1F+p/y; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Oguv7V+F"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nU1F+p/y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5VJzg69xakfxW3VOCyLK7wumPwPeLQPf6YPBQqS8knU=; b=Oguv7V+FD4iSnLKWr/XklF6EmEZCH2ap2WbSX62j9azrP0RRRXxoYWPI7++lU/itFKxWTG SqS0LsZGk9RgSGQNccedXo4ruyOAPR8pAnIXApLInVCUYmgN2SvmfX7UA8EoOneFkKV9FI OebKws3tOCGckfov5+vpVaUqQlLlCNY= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-474-QYyD5rmBNPyBz6I3BaiCqA-1; Thu, 08 Jan 2026 16:18:49 -0500 X-MC-Unique: QYyD5rmBNPyBz6I3BaiCqA-1 X-Mimecast-MFC-AGG-ID: QYyD5rmBNPyBz6I3BaiCqA_1767907129 Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-93f568048ccso3911797241.2 for ; Thu, 08 Jan 2026 13:18:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907129; x=1768511929; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5VJzg69xakfxW3VOCyLK7wumPwPeLQPf6YPBQqS8knU=; b=nU1F+p/y73bgp8MsrU3ClW47XRunrquSBp2IITIDobTtgdO11RH5m5VLa2pAPIEh6r X3QjzaR1L+WiHF6iYedekEBAf+sYIRQJgIgHl+d6HJSsZ1nkUG6DMAFzHtpb6gn69XyD JMBQ9KGBrBkmZkmHPkd7xS9NEpxb+sjWyb3TysgGca2pl2J0bsjbgeVnorVYG6pHkx+N tNO1RfdxQBjn0xSwzw25COW9Dz4povKp1ITolDD8201ui19Sx1yAjpWm0MZY+EEFrLxy Fwq2Ga+aptRX588Mz9wjnrnBd9UStCHNmGOfBFMwHVaBZdaS6hRUI1EHQM1/AKvTsPNw bVcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907129; x=1768511929; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5VJzg69xakfxW3VOCyLK7wumPwPeLQPf6YPBQqS8knU=; b=HXQ0pzIgvqln66G8RZ+39J6IDE5fUJQjC8nvZez1SNjNlI7tIKPPSYqQUJmVgi9JYq rwuVSaHmoSy5TlXR1+X5/CAzgD4IKuRlsHqrVE1sXG4YQVdyR6K1hGbY0cWZ7oPCp0dq oXYzraWTWbH8AWkPt2Q/pcLkIkQE1UnI59WH2O6ntNwD1FQG8OukuvGOXAuDat9omlQ3 fZRMTF1zMXXnIL5vj1/XcjV/i3bqW3FfHCQHq+G6QTJzVOfMGBobcwlR51bLDlvv7bQF ewEUtJA9LggYgbLUoztcxYmcIDcN/zlrnBUY0bxBOfeg8rTh9fyVEB6P1Dtw1M6xe7Bu 1dxg== X-Forwarded-Encrypted: i=1; AJvYcCXKKhB+bYgvhvO3Ab3R/XM7k+ext+yy2pRNL3UNNPwtJPP35x0R7zaQnelZSm61htWMIYn3ZtpNbjiz6HI=@vger.kernel.org X-Gm-Message-State: AOJu0YyVnX85E5dvZfxJFhU3dkPUy9lgn1mburnIMAmtV/diyW3SPrzi hdQnVVBaFZPXKkInq9WLPe++yCpdPQ5+rwaG9HEUr1rsMIavoHU/TEo0WjTxosBJu58lQoDeFax hO/iBtsGwzmhtdMxcSsduys9LvSm/vpdf+WiwVzVpOTJkMuqVlOvaS8TpIQQJsBR745l2+L7lIg == X-Gm-Gg: AY/fxX4qp1xogmtO7nIfITC7e9Qmp+2ovCcPeE3x1N3WrHFguhWonJb8MhVnBkZOe79 nCBDaibx1mkjM3QCzuzMHI+5mhuYIC5eCVp5x0Zr+tmnaHWDszsgBwviQhADykhA4k52o8A4Rn4 BnIZB8Mbr0Ao/JMqJ/QiWTgJumF8y1DCVJedSIWRYuGIjG3bWZNH1UCWK3sCGyfRZw4dUbvJ9aD pzL5kSAY3GyXEspbJEJwjE04YxELqQzaGm5eENjMMaTq50SMKRLOov+6IWU3NIT3x0foHiljxMm +7q9xx0lQ5a9aHiVUGYMsjdx2228Ff33XbSorfGP585qirePY5DWNcpNUdyVYXT2bHwsc26q6e8 PUqUZk5EOzZAI91Y= X-Received: by 2002:a67:e105:0:b0:5ed:f26:5615 with SMTP id ada2fe7eead31-5ed0f265843mr1992105137.18.1767907128951; Thu, 08 Jan 2026 13:18:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFLX2O0KlmxzrMSo3tby5b/YZN082iMeszi4qbktrWtgNvTKagIIyv7NxGpAo9E2TfU0DUiFg== X-Received: by 2002:a67:e105:0:b0:5ed:f26:5615 with SMTP id ada2fe7eead31-5ed0f265843mr1992095137.18.1767907128511; Thu, 08 Jan 2026 13:18:48 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:48 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:37 -0500 Subject: [PATCH 19/27] clk: stm32: stm32-core: convert from divider_ro_round_rate() to divider_ro_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-19-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2367; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=HZjZ3HcnfJ6Gv1Fz5dnPy/7RL1U8mVqJINJWM79xQHk=; b=kA0DAAoWt9LdJ11+wIcByyZiAGlgHrmgM6LOwEM19Z0uuBjchVDfhpfoJgJDmN/xDONnYVJb0 4h1BAAWCgAdFiEEpG0ycFhlqj3e3CkEt9LdJ11+wIcFAmlgHrkACgkQt9LdJ11+wIfnBwD/WXtd f9bkMoE+hr+2zc6UAhat71CaYeY1QhFMrePNhoUBAOsjGZioUPoLJfrsd/8VSuM/9DruUEUcARU bPxSu5FkJ X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_ro_round_rate() function is now deprecated, so let's migrate to divider_ro_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: cd1cb38836c0 ("clk: stm32: stm32-core: convert from round_rate() to = determine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- To: Maxime Coquelin To: Alexandre Torgue Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org --- drivers/clk/stm32/clk-stm32-core.c | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/clk/stm32/clk-stm32-core.c b/drivers/clk/stm32/clk-stm= 32-core.c index 72825b9c36a4d3b8ba3f7615b9026c09ffaf88d1..b95b9c591fda7d900d523f50c8b= d449398aba49f 100644 --- a/drivers/clk/stm32/clk-stm32-core.c +++ b/drivers/clk/stm32/clk-stm32-core.c @@ -369,13 +369,10 @@ static int clk_stm32_divider_determine_rate(struct cl= k_hw *hw, val =3D readl(div->base + divider->offset) >> divider->shift; val &=3D clk_div_mask(divider->width); =20 - req->rate =3D divider_ro_round_rate(hw, req->rate, - &req->best_parent_rate, - divider->table, - divider->width, - divider->flags, val); - - return 0; + return divider_ro_determine_rate(hw, req, + divider->table, + divider->width, + divider->flags, val); } =20 req->rate =3D divider_round_rate_parent(hw, clk_hw_get_parent(hw), @@ -455,14 +452,9 @@ static int clk_stm32_composite_determine_rate(struct c= lk_hw *hw, val =3D readl(composite->base + divider->offset) >> divider->shift; val &=3D clk_div_mask(divider->width); =20 - rate =3D divider_ro_round_rate(hw, req->rate, &req->best_parent_rate, - divider->table, divider->width, divider->flags, - val); - if (rate < 0) - return rate; - - req->rate =3D rate; - return 0; + return divider_ro_determine_rate(hw, req, divider->table, + divider->width, divider->flags, + val); } =20 rate =3D divider_round_rate_parent(hw, clk_hw_get_parent(hw), --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D1A833A715 for ; Thu, 8 Jan 2026 21:18:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907142; cv=none; b=Rx8+WnYkEBclMxwtQgrkk5HA3ddbkJ4vvmpnvzrqz1aQOjzMJJyWJo0dj+GhsPl4CbvE8UxYGPLEDzruntBY4oXN6xk7aLm/JpJTXZYWh4WdfirKsWpX2mADaq1SQGkNAlwrJF9ERqRXiih73A+l4PdUrUwRgWg3apR+WwJSsHU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907142; c=relaxed/simple; bh=1zGr1VEhUSEgUAAiV8B/qL6RDaMkiVVGUfjryyBP0yI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AtruLHLbammxR2S3NV7lbclmyiupJjqgtkd5iE42YsAXh7HqVehJwjbzyal1kj07zFdP0mB/AyHqIFlByCilfRLnEGUNUlm0kvH8NmbyTMJAtQhSld5uXXRrkgZ5Eb9hI7+KdPhhcwgizOaFpz3aE1myKwx/d2ILRTcrLla2V94= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BsaKeO/f; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Hq4PoVi6; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BsaKeO/f"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hq4PoVi6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5QDz5yJgmx0439uD0ntmtxod09pLPWy27GZMDx1s30w=; b=BsaKeO/fPuxKFrU0HG/h38eFXzTzyue14DhNE9+ivU4OeNx9D+6HHGjqIVLfh6mwIyJdqf Yf9d9R6q2+XEKBj5XYYqyCv2+Dh5csbH6rObjQbyteqjo+7UlQVLC9VSASZR+FY4hfqVtw M+aYkcshd6MEa5YcCVvLiKX6tGdZ26w= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-HnznzkeYO8i2I82ai-NisQ-1; Thu, 08 Jan 2026 16:18:55 -0500 X-MC-Unique: HnznzkeYO8i2I82ai-NisQ-1 X-Mimecast-MFC-AGG-ID: HnznzkeYO8i2I82ai-NisQ_1767907135 Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5ed0b7ed42eso1164022137.1 for ; Thu, 08 Jan 2026 13:18:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907135; x=1768511935; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5QDz5yJgmx0439uD0ntmtxod09pLPWy27GZMDx1s30w=; b=Hq4PoVi6MJTKBidfilsyYBTgbiz78dZ0gjD9cuxcNlxk5ggc3oulaklAwHLPxydUMy 87mypWKjZMLKs3eMTc78ZAzF93KeesPlQuJUwwc6ttm4YBrJXij5Rl5WL6m7srFzTvC8 8UbCwhlnn6aut6OHu+wh9XzRTR2tx5EAXRXsUzYJwypsrBQafKej07ucReYtjrI2cG79 ApCZxwz/6wC0+AA8tF+laS46E2f9oXTDsJFuJ0Dan2F33xsNpaZjmRvKB1XLOqNxXw5j 8L3IHXdsEtF3tUUDuGY4KYl27QRrM0awBb/Ki4gob0rgL7XMywL46BoaPdat3XlueMil +vhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907135; x=1768511935; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5QDz5yJgmx0439uD0ntmtxod09pLPWy27GZMDx1s30w=; b=jgq/Iftkj8ekpUgsYG1EUR/0JKWNHOmFLmYbGK/vpbFV4P1ZlLM/k5mL4t4u0Nse9t aBr22k/SktRk23U1enOWYwW0qy0fFDmvR3V6OSGcdJJm7bFxAfscaAQGwcTpQ2jjVj4g 5/E7XozM3yU57R4eQV6W2L8NnG5u6te8xwey+feFuyQsVCF/gcLtWK8YnVIie3BYDm5R R2Dy2c0hbyxpdU6shykoJ5OBNkEbivuoZ1IJB7d+yBgtr9gS680zsc8ouuG9KmgUvOJE 6ZXUXDF14c6IMYesUGiag0bvW095AXxNsbgdJ18hYfYYnLDeGRvGKmy36rVsX2j1AxK2 qGlA== X-Forwarded-Encrypted: i=1; AJvYcCWU+hpmfEevHuK4/7wIhOPYzmpEIYQcETbteRraq8D2QhlCSxXgFIHGpHvwQmhs9E6A7GL4aaOkklbVIVo=@vger.kernel.org X-Gm-Message-State: AOJu0YxOiv8+53cMSBGDBpElR+SETjV9R3fMRxcjBm4YP3IBP0C5bDdM Iyu0eXmNlKzdGZZz9pq72K+W/mu0IV6d/J5GsDa+XM5WyHtzCsQc9Qo+WZNjlbxO2iLPNDUr7VJ KM8Go6Lxr9yAyv5fjKaZpeeEaqT3D2OyWmfpdF31jeUBL38W3G/+v4hdB1zRXPwypOw== X-Gm-Gg: AY/fxX7vRvRfCY+aW4pHsYKu86RuuN6PRXT1Ym5msHUEJ4V+e/MYi5PgJ9ELcV5+f4f eUSFg6icQCQoWECSmVa83qz7FcAbvX7lYncfKhdv1HOI5vVxB1GN552hxMV3FNf4bRPqUeZNJfQ GKTQlMOXuretjez+5JcUXUo1TZx5sKAZ/cjDyj543gqePFDGrOk7Jk3V28ok2XhGptV/7i2XpWb xKy9kH9BtNufQ0/G97tFhNgBxRy7f2kOZZtMYOsS9xsI+BWUYZ18zTOIGzVcISkm4A7N4CtoZgR cBqE0k4WZs4qqCD7tDTuOt1tSy086OPTmNv7TtKZF+MN4QmRoIhLo/WkIY7VfrU2+ezItGXBtsD HkjypjdNMCR2/ASU= X-Received: by 2002:a05:6102:2b8c:b0:5ec:848d:2eb3 with SMTP id ada2fe7eead31-5ecb560294amr3157837137.19.1767907135131; Thu, 08 Jan 2026 13:18:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+wVo31RtnFWHlhbf1gwVuy01FPzefAIXV8pM4OiwoVNvycs5UB0kClvVq2bdd3YZxuh0SVQ== X-Received: by 2002:a05:6102:2b8c:b0:5ec:848d:2eb3 with SMTP id ada2fe7eead31-5ecb560294amr3157824137.19.1767907134612; Thu, 08 Jan 2026 13:18:54 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:54 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:38 -0500 Subject: [PATCH 20/27] clk: stm32: stm32-core: convert from divider_round_rate_parent() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-20-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2480; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=1zGr1VEhUSEgUAAiV8B/qL6RDaMkiVVGUfjryyBP0yI=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5HZ+rVz4cq5P358Ldj9m7J33rWhF42pTTu5vx/bOq vD+uDptd0cpC4MYF4OsmCLLklyjgojUVbb37miywMxhZQIZwsDFKQATCT/H8Fc20NW1ctEMhvb1 eUtmWJ9753w9LOauSY9OqHpK5FGLq08Y/jvaJGQWz50Y9HLBob45cZedTKY73G51alpxMHDtvcU MsWwA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate_parent() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: cd1cb38836c0 ("clk: stm32: stm32-core: convert from round_rate() to = determine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- To: Maxime Coquelin To: Alexandre Torgue Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org --- drivers/clk/stm32/clk-stm32-core.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/clk/stm32/clk-stm32-core.c b/drivers/clk/stm32/clk-stm= 32-core.c index b95b9c591fda7d900d523f50c8bd449398aba49f..e921c25a929c303a2e189bf8766= 67178a123eae1 100644 --- a/drivers/clk/stm32/clk-stm32-core.c +++ b/drivers/clk/stm32/clk-stm32-core.c @@ -375,13 +375,8 @@ static int clk_stm32_divider_determine_rate(struct clk= _hw *hw, divider->flags, val); } =20 - req->rate =3D divider_round_rate_parent(hw, clk_hw_get_parent(hw), - req->rate, - &req->best_parent_rate, - divider->table, - divider->width, divider->flags); - - return 0; + return divider_determine_rate(hw, req, divider->table, divider->width, + divider->flags); } =20 static unsigned long clk_stm32_divider_recalc_rate(struct clk_hw *hw, @@ -438,7 +433,6 @@ static int clk_stm32_composite_determine_rate(struct cl= k_hw *hw, { struct clk_stm32_composite *composite =3D to_clk_stm32_composite(hw); const struct stm32_div_cfg *divider; - long rate; =20 if (composite->div_id =3D=3D NO_STM32_DIV) return 0; @@ -457,14 +451,8 @@ static int clk_stm32_composite_determine_rate(struct c= lk_hw *hw, val); } =20 - rate =3D divider_round_rate_parent(hw, clk_hw_get_parent(hw), - req->rate, &req->best_parent_rate, - divider->table, divider->width, divider->flags); - if (rate < 0) - return rate; - - req->rate =3D rate; - return 0; + return divider_determine_rate(hw, req, divider->table, divider->width, + divider->flags); } =20 static u8 clk_stm32_composite_get_parent(struct clk_hw *hw) --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BA4633BBB2 for ; Thu, 8 Jan 2026 21:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907149; cv=none; b=psoeEO9lY0ZzUuXRLEEy/Ok0WmgXu//pLScSgIBW1BzpNvdfJwUnT19Ka5OuPwsJZz9gpcEaT/sal1HJsktODMsIISnXnpYBleebxBgaqwpRfkN56i3cTqykSm+BoCXGNePPnolZEUPJB6PIW2fxi0gS5dNUhc86Vb3nnoYv0mo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907149; c=relaxed/simple; bh=v7XIJHZpMR0cQbSpuTH2cUTubvW0Ol+ykoAl9JRLUp4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oCgITVrn3YU8yGwtY8rjCF7kX4SbTNRurtYHB2LVjt9CJuEd0ObRx4xHKIIMkXZ8TulBmQmThbmwVFvf+khG/G0bztr8O0T8BOIzs8mC717xEJ3iHu39ykViTYeE0ONCtdtZV3+JMfm6t3vyeenVQrPmYpGxJ1vbo78kq/BdZrA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZpEKTQw6; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qAyVcxY1; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZpEKTQw6"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qAyVcxY1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xwMF/YzgsDLcFOqF60EJZjUvJRR28RQS8hRys022L+0=; b=ZpEKTQw6IUpgWwqkmI62UHVQatDlNyWsdYNx3jVILquY9WAc8ZDU7CG4udVDK+BURPIfwQ mEkXN0yQWvzd/KwgMw7EOoi6dpcWbMZfWB8pItM3mHoTtVLvIjXP1epb1IrvyVDP51xHnv H3j8yCA7oTgDjxl5lJrzw3vMz+lpHT4= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-Z7MxMTwkP-Cl_VwEY_Iv-Q-1; Thu, 08 Jan 2026 16:19:00 -0500 X-MC-Unique: Z7MxMTwkP-Cl_VwEY_Iv-Q-1 X-Mimecast-MFC-AGG-ID: Z7MxMTwkP-Cl_VwEY_Iv-Q_1767907139 Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-93f5fe52b10so8184750241.1 for ; Thu, 08 Jan 2026 13:18:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907139; x=1768511939; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xwMF/YzgsDLcFOqF60EJZjUvJRR28RQS8hRys022L+0=; b=qAyVcxY1Bh9Smo0JBTq/8x7NIg0PRUbGB/fA1X8U3ZNpSlhsMuT1I3Ulh9RYx4Vrn1 Uz6QfUlYO9IDaJnBEVVnopHJKGSG0bmWSfk/Jp/r3lk6cl4WTHPiDswLCmlOVJSu6X0X PwlplOO7gxmcXIgp0ES36O/27KQT3LFtA15PIiUjMILak/srAgSryyZa5NzoDKLwnRHV 7haDU2M/8HA5ReUcrTgqIIM/52A5oOBfgF1lRxEaGdJzFdUxMoUedyvpaBsZrAMtwsa1 pXUyKAoATP391IgJIrY65MKOIFhAJSf6V+iQ+7NepYM3QUK5fsYF4CW1jfRp5DSZQcIE 7+kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907139; x=1768511939; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xwMF/YzgsDLcFOqF60EJZjUvJRR28RQS8hRys022L+0=; b=i/LKCzviKJ3vnjX0BH27oBk26cC5s7ZVhvfO2nMY0MFzHURrSe0rSUtMNxrQlz8UCB DzjHIJw3iyJChfQ4ugXtFXVB0//qycQYHXDNz2oTKFHOj6tsZmU9JI2MBLO1rylkIqL6 AsWPYkd4RPcQdBP8tJ2Fq3bhWTcEVAMkHcbJBDOyUkd8pS6artrT8cnLx/rNjTTpQ+y7 sqWdfgfURF2tQXPgU8wZOvT7x4PIDiEdFjLANAfZFx61btALU+Xqrl6Y/bDZYX6o9dnV QlFCYWc2zc5IXn1xCvIOgMhcq4ASKgmZ6DVkLoa8HIrBZJXyroAfheRGtxqVOsyXaa6m mq0Q== X-Forwarded-Encrypted: i=1; AJvYcCVmJpmrkiUcZciOLhrCLeGTuXky/BvNY4n3IhZJaC8UUHNqC6S1aHx+xK5oNcOBG38EqJADARnzJESznFI=@vger.kernel.org X-Gm-Message-State: AOJu0YzSMd8wUbHLH//JZPOyOhGV2o03l0+3gWco3omvNFB64IHvNn7n d4R7SeB6CSxNIQJM4u3G7XzKphJ6m/D2x+w24hztOCRsvF7TtvsJQOsX7JVDvcYti6PHqT83uFE qtWKCFCYMRutSgI4StvWPQhCc1cWdH1BqmqkZ1iaMs6VxI064kjzFyYe6uAx18u+Vog== X-Gm-Gg: AY/fxX4oVcEx7fSlee58NyyDBQiQ8avIyFXNg3bqfjA3so0twTiXPhz6uf2HFiD2lHh 3MSCoUh7Jdj6hzzhSK5T75P9lqZifAFKY+N6vELrRN0AdHjOKZYteuxzBETK1wx5lHLBP/F6lGI Bzk81zRp+yi1HOKq8w6oSVKo+P8RIuBs2IcUxsFvU4oeHsnWRaqElVqrSP74isehTvbq5V9xBkd VTJjjTAgUlHmQ2ctDzXGE4GD/ksohIF/fagEw0iu3u/W7oBUd/jGqed8On60cuLWbimxH2cq09E iv98D0GQl081gtIGMgbLBzfik3rK9DNqC/VM7eHWMH6q/+2YYLoMXBq+Ke22FWTg/XvC2NymWxa n5+rbPevDmA6HutU= X-Received: by 2002:a67:e104:0:b0:5ee:9e4d:75bf with SMTP id ada2fe7eead31-5ee9e4d770emr1519416137.2.1767907139440; Thu, 08 Jan 2026 13:18:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHU2lyFtxNP3zRs5RK4fjm4OFMGg8gxCBxy7hDmOZfwcrt+e+WuuI0PExneoxtBtYYq/QW4lw== X-Received: by 2002:a67:e104:0:b0:5ee:9e4d:75bf with SMTP id ada2fe7eead31-5ee9e4d770emr1519410137.2.1767907139148; Thu, 08 Jan 2026 13:18:59 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:18:58 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:39 -0500 Subject: [PATCH 21/27] clk: versaclock3: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-21-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1360; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=v7XIJHZpMR0cQbSpuTH2cUTubvW0Ol+ykoAl9JRLUp4=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5Hb+9/inenCV+6t/N30dSgNvPgtxdo2XOtipE3D2w frFB3fLd5SyMIhxMciKKbIsyTUqiEhdZXvvjiYLzBxWJpAhDFycAjAR+wmMDL2tWjl2S0qM5t+p EZkv6rFEdOJSh45HUkyb1qR/2K8nMpfhNxu/Bvu0bYrrls1f3vp+6hyBQnk3pXUKU079tNNo63s iygAA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 9e3372b2ebac ("clk: versaclock3: convert from round_rate() to determ= ine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- drivers/clk/clk-versaclock3.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-versaclock3.c b/drivers/clk/clk-versaclock3.c index 1849863dbd673f3b133b9a295dc608ea43931de6..27b6cf70f3ae1bff1264933d8ba= c4ccc65481a1c 100644 --- a/drivers/clk/clk-versaclock3.c +++ b/drivers/clk/clk-versaclock3.c @@ -523,11 +523,8 @@ static int vc3_div_determine_rate(struct clk_hw *hw, return 0; } =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - div_data->table, - div_data->width, div_data->flags); - - return 0; + return divider_determine_rate(hw, req, div_data->table, div_data->width, + div_data->flags); } =20 static int vc3_div_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14F6B337BBB for ; Thu, 8 Jan 2026 21:19:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907152; cv=none; b=IUfwiltKjwE8ahMlNHB6ZBBMutdnYb8pLlRuvDvyPc174eUxO5MxQ7F+VfFaEi43n3wk0fw81S0UpfFpsqpg3/QCq8pz0+Wy9W+zlJMNkQcZuwrVbHzlRgPD/2E4juUFx9RnmoFafcUE0elbPlK0sPq1QUjxiQnG8lfRuCNWIJo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907152; c=relaxed/simple; bh=mIU6ziQ0sv9Zix1Fh9fnfQrda1ivwOVmFtHvMRm5XPE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JXbKQx/AoILAyoFZjau70vIwzbSt3mpd52vQhuOemSSZU/Lz6I5nzd8KodQrfTMwfA5dp6EFSNwEK+qmWgOzJ9Wym/XAiqkASywc4x0Cb7kHbWNS3LyljQVc6Z3sWoGhpPN8kJAJLX6G2poe9+JcowzjYj99AExhLP6Rg2ff25I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Sh2mqj29; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=hgLyvdf1; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Sh2mqj29"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="hgLyvdf1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v4c2YEEJer+Zfzb55LpmjpAdfmYfGR4hEXOdQAY4IDY=; b=Sh2mqj291Ck5/lCMtVtne3X9KNN277yz+swUICX8383bq1jfG3hHFCjATkCQgqIC7ydTvK DcDZNjzzByTh+xNYlunI+95klLehqb6UrKXp7xhpQFAhKC9KHqAocqagVUPjB0/kbtSSUU GtPd79kPVUSw8mjdpyJuq9/sTyRnklY= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-bK_4uZSpMaOc4ioqH9ph2g-1; Thu, 08 Jan 2026 16:19:03 -0500 X-MC-Unique: bK_4uZSpMaOc4ioqH9ph2g-1 X-Mimecast-MFC-AGG-ID: bK_4uZSpMaOc4ioqH9ph2g_1767907143 Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-5ee99a57fe6so722883137.2 for ; Thu, 08 Jan 2026 13:19:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907143; x=1768511943; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=v4c2YEEJer+Zfzb55LpmjpAdfmYfGR4hEXOdQAY4IDY=; b=hgLyvdf1Q3be3dE1XuyM3MHZraQeDYUi/sX3Rt5QpRDoXmb2QT9TUQFKWNW8iTazMw W6GBuz7ESKBuAQ2PJErL9ygqzSb/3mQNDHeZPgY/lqN1jYOPuuMvWY06bhl6bAq5ZbQN O+yFLxY6r85Ro/NfTqP9PnyrVBA1NXqPVYaTh/r/ZizJd+ydCB0MFxr+bpI4nKUKr9PA gzrKINubcTJW1ruenFqDfFTFJ6l5VQ+iprH9T/iCdcKR6JUTu3wlMS7NmprRFrgPpXa5 9yEbPCPlSr0dP4WLUTrvItY79Tr1W9OaUaHpPmmEZYwVn9ooHFxnS8QrZXrWUPwwpI02 EHSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907143; x=1768511943; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=v4c2YEEJer+Zfzb55LpmjpAdfmYfGR4hEXOdQAY4IDY=; b=dYNPaWu1PnvUs2+GGk3LTTQIumfur91D/WmbUKBu8mzoP5EsF6AW1RuJi0s2eQ2ca2 ILOM4HooZ75CJn1Mmrm3smaK2jkvLs/ltokcRYLGbwx17cYOs1QYWiizaQoJZzxfSKo7 kso62vNjzumGpBALj7A2p6xEYlnskG/3r9imxKV685mNLFpQ5S1xWkeB7AetyZNpCJD+ zTlL16dewXrhN5+v7v2IC52mhbi4jPw6+qH1KMAmK0cwsJDQ3QT3g+2cGYqyuWyGTTe4 01eKX95Fz9gBr/ST6Nm+M2dKzRCism3cLg/ZnSFuXo1GKKgP8Jcc1FdlwVFeiYNw62Ns u59w== X-Forwarded-Encrypted: i=1; AJvYcCWZbOzaXHgzHE7y+xGgpxGJ6uhn/8XoOIxu5wT4Lr9rLredQ5yp3SO0RwZmiE7gK3lQn4eBXgCpqlV32Gs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywy0Z/ONPrGIKVW9Pm/DFCPV6O4yvS4JMnmGTTyzM91BcRHEr2y p+oyUVlSXHZ+rf1tKyYLmhRhfVcby2V9DNrtwLj40Cny8dGHRxzbuyXQSJbLmMRYkHlG+qzX00l dL7cZO4BTkYU+iZNAmW+Xuf40C90UkFNkKWfo8DLJRi0NiWXC9CyD3QmW/Aalu6aTWw== X-Gm-Gg: AY/fxX7TpIBoSnvvLHrqP36Tx2bGFGl2eNxkaRDglFD2o2um8u31bKKbLp4kqoRjR52 D6Vfjgp7xrG6Pj5dvecbXEd3Y9FaT57kbVbyGTfTcTiGx285atDyEQka57l9QEUsy7HaTBhI+ES Utrk0lLYGmCE8eOyl6b3lK8vseEHhVvVAcDob99uQsWX8SxskqNORXSKNWqX5uZo5MTWw+tUmUQ mdXKNXClBwDRolT1BtPnvbsnHxireLvcCkHESvL1nXsIviF2X+0Blic9penCwXwYvsAoX7oWmPD lRXZsYwIJn3y5yqCI/dPqkX/zF5lGMo70nJcOLeyhDNdK0JXl2ZPcmOnoLIX8TCPgyI3EFbkGO/ nRboWLLOal/zrn4s= X-Received: by 2002:a05:6102:3f02:b0:5dc:51c5:e3c7 with SMTP id ada2fe7eead31-5ecb692bd25mr2830883137.26.1767907143384; Thu, 08 Jan 2026 13:19:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+lV1dw9n8VVQIdj604XGIC7Kk1/RySzYFis3Jq6p5u65mYyh1jYUkHxYuUb8jxOd13J8DWA== X-Received: by 2002:a05:6102:3f02:b0:5dc:51c5:e3c7 with SMTP id ada2fe7eead31-5ecb692bd25mr2830878137.26.1767907143049; Thu, 08 Jan 2026 13:19:03 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.18.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:19:02 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:40 -0500 Subject: [PATCH 22/27] clk: x86: cgu: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-22-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1315; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=mIU6ziQ0sv9Zix1Fh9fnfQrda1ivwOVmFtHvMRm5XPE=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5Hbemvf5QPRx7+O6+nuVQ5Z/9PFMNZzA9q5F0ilv4 /5zB/0rO0pZGMS4GGTFFFmW5BoVRKSusr13R5MFZg4rE8gQBi5OAZhIFAPD/yKPU33dv/Qru/Y6 Ob9K5wgTf133T13E4GnDi7d2SvO6RBkZVnZe9F2rrpQkx75EqWVrZXhn45NVjxn671mdizkReN6 DDwA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: f7a6bed91a19 ("clk: x86: cgu: convert from round_rate() to determine= _rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- drivers/clk/x86/clk-cgu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/x86/clk-cgu.c b/drivers/clk/x86/clk-cgu.c index d099667355f8d80785b0f43097ad10c274dd61ea..92ee05d75af2b262d3e0e281c79= fa07b3be1574c 100644 --- a/drivers/clk/x86/clk-cgu.c +++ b/drivers/clk/x86/clk-cgu.c @@ -137,10 +137,8 @@ static int lgm_clk_divider_determine_rate(struct clk_h= w *hw, { struct lgm_clk_divider *divider =3D to_lgm_clk_divider(hw); =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, d= ivider->table, - divider->width, divider->flags); - - return 0; + return divider_determine_rate(hw, req, divider->table, divider->width, + divider->flags); } =20 static int --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEC57338F5B for ; Thu, 8 Jan 2026 21:19:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907158; cv=none; b=I+qHHEm24m0E8DRGfqCgb/ksOJm0oxXlJ3FtjAcw9ipbY2aweegUC5HrLRf1qkAFnd8FoJN34W1IPKMwJd0fxZRAd4K6SwtU0Ba3Xd3kR7U1AirP4ggLA1THu0psKgizJTTklmnzHu4jb31i+HT97A6Nw2H9lxjErj7b7br1hxg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907158; c=relaxed/simple; bh=obGg7UzQWRzDKZpy5Gk4sjLlNTrtDOG8AhKUHRKX6zk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f+K/g6GydhcTRVIkUm+D/+4tuGE2jOroV9m0xdWWgKFI88mC3QMTdPajRyPcpy4rxd0V9Qb7E8AHRw5uFvrWeQZVV1l0Mcn5OM8r8APAWXsG0xVbq0AG+Z8PBLfVWWZGtzlXlg8KCdqnpFM+a1f93nfTJBFluPBrB8eTWdJzu9g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XMlJqh7F; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Fe9z7U9K; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XMlJqh7F"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fe9z7U9K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pi8aTSDXEqFb0AtS29g5AANtZt1DyRnbPSfQSa91eEQ=; b=XMlJqh7F++h/N/E1fO24OBMUd57di/fRAyqphn2ENQoGwCRjIFQkNMHEB99B9k4UXwMqQr NhueAoCajq/reeLMSyMzqnqLncGb3Z+hlZyuDw+pAzIrymDg7YTRGWOOWCPh9LShwPUekh i4SS7blyb6l22WvxisfS1NhYIDgJD90= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-241-BlEGxtm_OaSovJY1ygoL3A-1; Thu, 08 Jan 2026 16:19:09 -0500 X-MC-Unique: BlEGxtm_OaSovJY1ygoL3A-1 X-Mimecast-MFC-AGG-ID: BlEGxtm_OaSovJY1ygoL3A_1767907148 Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-93f505dfb7eso8055326241.0 for ; Thu, 08 Jan 2026 13:19:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907148; x=1768511948; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pi8aTSDXEqFb0AtS29g5AANtZt1DyRnbPSfQSa91eEQ=; b=Fe9z7U9K6ioHwnfasvVHXkHjugnpG4qvbN0qNEVzJjaL8Si+V5sdfiypWHcsCBRWn5 eD5bBId94pokjHjtuAVPYg3vvC+n3Vj5e+z7iii5u1PXf5UsrHfyX7QOw4cIeK4xL3pr efON6eiCyNieJmNQLJsKdnDCBvoTYWLmfd5JDPFuFL/QSs7rlXEpa851P3J1ZqZXi/GM 8iekdBD8DNAZC/ssYDTH+imUCQw34BrCKVn38TU41wvKVikn8+7TSe/zSBYY8km79Usn +sEIt9LRDU21mJNCKYdnPz5fq6LsjlXstel5UkboGcc6Ku/rwl8KjLmJ9KoDPMGHV2Mk mDZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907148; x=1768511948; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=pi8aTSDXEqFb0AtS29g5AANtZt1DyRnbPSfQSa91eEQ=; b=p4N1zJEFdzZyv8q3CrVcFOFY2UEP6q8P73yVv78zyIIcwProkqQyHop1t/eDqxO28n oONsOOxICBZfFp2PsTSQ0q8hMfWeeYCqb6OF6wCU7owHEF7h12vUCf7nB9UKRNetUNuA 5U1uzLX3LxzToBJi8HqnbC1oYNDtD3hL0fJZQ3eel7ufsqlkMgT9pssI2/gMuVLyq4Fw +hwVQ1zlwSRWd+dOBfMGt6w2gsMYCmS6PiPf9HbPDFJgIEbW+Wc/lFYhl0Ok7irHcRaw DbFMjXENon+4XcFYHxkrAIzhiok7VLff0bvyWtMZ0rt0qNO/gk+ws5zrwpqOTNTi+V4g qlFg== X-Forwarded-Encrypted: i=1; AJvYcCUb7vFLAiAp0hGj3JE+227Tw+2s7s6hsEdeCDYcUc0jqYzcKUC4H0omHaFrRnRcEuzSdm2hBzIMMCXz63o=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3d/Z7zMXws9s5W+BWqvptqNHf4YoG7TXCGWksCbXYfFjA4yMR zOSwOMIgciC+ChrYdDnMU85//Nbcn/BtVMJ4emcMbLr00IdFy1hFxP+Qp0JBzSmNupDC7cpriby YbBivrhE5S5GsPkjMtAD+xYQ6aCVnO+AT2CFQ5iMm8slK4BDMp1TcUoC+pT5W8CPUIg== X-Gm-Gg: AY/fxX6ETJg02AClEfAgYT+1eZDTbHehnVsjpFrnwkqQN/CVPW7N59r09jtJW9b9/xf nfIjSIrPFotL/O7Gv2wYRd2gJVzyUDHdQfMeLlEc9xK0f+09tlLWWxk4gTFE5G+v8Z7Q6y64N1F rK/8wi/o+pr6bhVyANOgOkIujGeq2rlyHjLODZJ+kklxd/3pnlxwVC1p6evu5ImGqG491gsrI+k fg53X6eBmBLbqYgvHv550evP4APnFUCEIwVIxew/T+Xc57BcbpU8ZCTZyop1hZBrI4RoacDp5IF 09mIK8Vp72PE1tjGYcXAE3rKzME+eyLsuYF2y7e9OZufVYk5uGPP2U3eM/j7779PYX9DoUMTjEn 7badzqKKSy6L21fk= X-Received: by 2002:a05:6102:419e:b0:5e5:6eee:8adb with SMTP id ada2fe7eead31-5ecb1e6f442mr2910875137.4.1767907148413; Thu, 08 Jan 2026 13:19:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IGjkDxe401WB7XCmqhdQfn1Yq9q/xtZIkqczooAI9hDDE/Fw/5ZqkXt9GSFjs3KqeCx/N8xaw== X-Received: by 2002:a05:6102:419e:b0:5e5:6eee:8adb with SMTP id ada2fe7eead31-5ecb1e6f442mr2910863137.4.1767907148014; Thu, 08 Jan 2026 13:19:08 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.19.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:19:07 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:41 -0500 Subject: [PATCH 23/27] clk: zynqmp: divider: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-23-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Michal Simek , linux-arm-kernel@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1468; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=obGg7UzQWRzDKZpy5Gk4sjLlNTrtDOG8AhKUHRKX6zk=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5Hb93Mva9tclyPhOy56Un696Q2YrvHruccon7rjkh C/bN+7811HKwiDGxSArpsiyJNeoICJ1le29O5osMHNYmUCGMHBxCsBEvhgxMswNc/g1N/iT6PZH G/5LGXkHrD8o0Xhj62/bnZklTBfNVxYxMrwInrTR6Ne1vN1MkkfTZpZNn1UrVOtnubLn/OVL9Vu PfeEDAA== X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 0f9cf96a01fd ("clk: zynqmp: divider: convert from round_rate() to de= termine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- To: Michal Simek Cc: linux-arm-kernel@lists.infradead.org --- drivers/clk/zynqmp/divider.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/zynqmp/divider.c b/drivers/clk/zynqmp/divider.c index c824eeacd8ebd4d670d78f1af2186e61008bdae2..de6f478d527d89881a9c0deb04e= 7bc0a5bf6ebba 100644 --- a/drivers/clk/zynqmp/divider.c +++ b/drivers/clk/zynqmp/divider.c @@ -151,8 +151,9 @@ static int zynqmp_clk_divider_determine_rate(struct clk= _hw *hw, =20 width =3D fls(divider->max_div); =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - NULL, width, divider->flags); + ret =3D divider_determine_rate(hw, req, NULL, width, divider->flags); + if (ret !=3D 0) + return ret; =20 if (divider->is_frac && (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) && (req->rate % req->best_parent_rate)) --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 306CE3382FC for ; Thu, 8 Jan 2026 21:19:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907166; cv=none; b=jOIpnam5+ZLl4QL4zrZRT0/mnJlMYwnZX9bYnzpNakWatarNXbGXqm7JavXdZ3IXPR3E60VMCubHlpG+O1YyEvSrcvcWuY3phacK/CyvX2qS64xNnOtKKWedGF7Uneip4zoe3tTUKmJt7Zde+gIyyGgOTegKjl9G2u8+ZQuBDq8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907166; c=relaxed/simple; bh=sZzvWmWZLBAg2O8T5kHMnq76Z89GPT7Dybdt2RJStY0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=N8DzTxTet76MEWwOD7I9yfJz6BqzSOS0+W8qLa77lq62zatrVrq4c37EkjFyj3/RM+cKC2WMkY5wSUZ+k8gFlv+El38Kojo5/6dmehtdvzhuK+42uzWTWc8HjFU6vMjlj/nI2qAsZ/BEUT5XexDU+hp47Mc6BR/porgtn+42zmw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ArUW+S0A; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=FvrdQ2l+; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ArUW+S0A"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="FvrdQ2l+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3iSY8oAi4l99NVbVblMxVH7Z37bTmCz2IXU4yciXqd0=; b=ArUW+S0A01e2gRafi4S8qWwTOL/9dZTVXhzWHLSgAwfTFLi3dKzxj1GT8CewnsKEiCo0lf QmwBqHAnB7m+HgbLa0xaQ4FS1Kb3DvrCKnqQzvFbdzj2fFy2RGaA4WEQBGf1v4D9L/+iLm A2FrXb0mRQE/jeTDTMr46MXiCjIIWrA= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-9mS9Zs99Niq7nopHA1WKCg-1; Thu, 08 Jan 2026 16:19:17 -0500 X-MC-Unique: 9mS9Zs99Niq7nopHA1WKCg-1 X-Mimecast-MFC-AGG-ID: 9mS9Zs99Niq7nopHA1WKCg_1767907157 Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-5ec8781f59cso1852789137.3 for ; Thu, 08 Jan 2026 13:19:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907157; x=1768511957; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3iSY8oAi4l99NVbVblMxVH7Z37bTmCz2IXU4yciXqd0=; b=FvrdQ2l+/qQk9eqw0ibjDksVpVJizL7ErXiOPWCtNZYs3v0u+sf4Ky7+9A3GpwTp8x xelrGuTl6Z36iZd7y8Gy9RZ573wpLlpuMjSs3LNbI48l2sbNgJVM2r3OyPnN0XZ6OXbt aCFAof3pKlnBQfzXCIALePBeISsJQKS1dtMlZwDZZ+SPz3n8jnFuRXfApeA5+vGPpE/C +AOq0c6v28wMdXGh1gzauNXuS3Ik7DaHrYILOTu7/+Z/1u2DlU8c+7PgrBc63f/Ys2qK KY+xuRZSVHasYduUTYRtWxADEpUhYsfMtGTmeG7utUqEQ7FZT99ZWFbm0/gT9kW9g1I2 4OFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907157; x=1768511957; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3iSY8oAi4l99NVbVblMxVH7Z37bTmCz2IXU4yciXqd0=; b=lqiIqO10QzXpIw74gGOckbPtzlzRKNyZi0SF0LJGmyGMWK8dF4pafgCV+22xNt4Zw2 ZCPw1p5pEQ1cRU6tC2mIsfRBhmPACSURvcD/vrjaH1iM1/gtJ2W9KTIA/8fozZv7tgNf Z7Y5Q5K9WI26Cu02aGCTjmPSkoyFcFP9JivnNZRPYCA8yrfhPbpQv4eOeejMX3p+aLx0 iDw3MbyHukp7qe/iDWP78H7jfydJGDewPCWLLByjVLWGkiAQv2RJZFMRuwWZftSe3Pow ZLvSosXw0e3L9vga2hFf6IUkrgxKjouUpBeqm6vKkuZBlRCRuxpIzPSp6q84d/LY4D22 sdxw== X-Forwarded-Encrypted: i=1; AJvYcCWO0JlQUKobA55ITjOjdzJJLwbWL/KaquW5t/CpVRyZlQmpLnBTmCj6BaAm6F2N6EHLitTLmhT4s0pB1aA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyv3G46oNfwJ2tb/qHp4Yl9bEtn7SP/9EthBWDDvOMJdBp5SUio gS3beff2sB9mL0/kux7pRjI79XYc2q4JtcJJ7PFpRP2Y0hvo3i5BkSHX7ekwzpYKSkx87RwD/tY CrWs8BEwQARmyflDZdAOQ6qk15f2hEuGy5MfCHAByftiEeQcXFbXYEKeeh4IhV/fx9g== X-Gm-Gg: AY/fxX5DEo807jlCqwcT3XuzLGX2qCM/FlsPqj0uWixitMxvaR6XuhH4hPgi4xbnnJK s54mBreWe76CItZC4E0vrBb4aATQnrMkm4RN5dP6NFhpnXDzoRvnbzrsNlTRgCQ1B58lkRhdvmt 6MtDzmJT+UOgDZSEMXBNiopOBk9m9gOcOXcsJGrWY309XyLXFpcfvCVUrsJ5eymA951x+hu1CfW vJLcT3tfsZoo9szdNl+3tiF+AneFaBddnzLW4fzXmO1fXozNSoZpSb6tqz1ktYuRW6p/EKpmYE9 jI+fjpODw1nlZw6HNS8sQc4HoEx4HGHAP1OW801crVhp7B/64UQUDHP/QLdYSjpg23RxVdE1MIS lx8Ds6sxM/VzoHUA= X-Received: by 2002:a05:6102:3a0f:b0:5dd:83de:badc with SMTP id ada2fe7eead31-5ecb690ac30mr2675964137.38.1767907157161; Thu, 08 Jan 2026 13:19:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IF0uRMIjA7XLKaSnU3wOhkRdxgxZI3Tqx0E2gNf3CGsOIh420QNoFs2vKVMT8dIcPxOmBSZqA== X-Received: by 2002:a05:6102:3a0f:b0:5dd:83de:badc with SMTP id ada2fe7eead31-5ecb690ac30mr2675959137.38.1767907156687; Thu, 08 Jan 2026 13:19:16 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.19.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:19:16 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:42 -0500 Subject: [PATCH 24/27] drm/msm/dsi_phy_14nm: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-24-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Rob Clark , Dmitry Baryshkov , David Airlie , Simona Vetter , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1932; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=sZzvWmWZLBAg2O8T5kHMnq76Z89GPT7Dybdt2RJStY0=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5Hb1v5vpP9/g2Zw1x0vb3l5Xs8vY4qIY9ZTV6M3/p vSpfvMlO0pZGMS4GGTFFFmW5BoVRKSusr13R5MFZg4rE8gQBi5OAZjIVyGG/znrI46vWXPXmZ1n evhLw6XT1O2//926j2222YecHWXuxbMZ/mm/r2e/wuzs0x9mvcteoup47ENm0fYpEwKEL07zVn7 mzAEA X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: cc41f29a6b04 ("drm/msm/dsi_phy_14nm: convert from round_rate() to de= termine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! Reviewed-by: Abel Vesa Reviewed-by: Konrad Dybcio --- To: Rob Clark To: Dmitry Baryshkov To: David Airlie To: Simona Vetter Cc: Abhinav Kumar Cc: Jessica Zhang Cc: Sean Paul Cc: Marijn Suijten Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/m= sm/dsi/phy/dsi_phy_14nm.c index fdefcbd9c2848a1c76414a41b811b29e5fed9ddc..a156c7e7cea83286e7ad47aa981= 8761670c68e89 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c @@ -628,12 +628,7 @@ static int dsi_pll_14nm_postdiv_determine_rate(struct = clk_hw *hw, =20 DBG("DSI%d PLL parent rate=3D%lu", pll_14nm->phy->id, req->rate); =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - NULL, - postdiv->width, - postdiv->flags); - - return 0; + return divider_determine_rate(hw, req, NULL, postdiv->width, postdiv->fla= gs); } =20 static int dsi_pll_14nm_postdiv_set_rate(struct clk_hw *hw, unsigned long = rate, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C0B133B6E8 for ; Thu, 8 Jan 2026 21:19:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907171; cv=none; b=cdXFUZ3YWvA82IMKmBa4UOz4yu9bmhMGf2I31O7YSHFEB8Qy20cGtg9rR3dF5XXCthN6Vl49hpwG546lj76z5q7wEicAZcd2lw6skCjpnxuj24pshRkro2p1lLs0ED0F2AId2Rme5QXPE5O6m92/HTUmdei5Iej6a/0iXl+HAvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907171; c=relaxed/simple; bh=LzaLThjuJjdtJh34gPTyvntKRADSiE+8sGiCKAXic3I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kXuKTLOF7IYCFcAqV1QiKkU/ZQKkPXKRW8OjKoUEILU7FLm2i6Yo/UNwcyyb4+onQE2lR37Lcr0clws5doDCH3brvUWgV8ZLvIYVmRTqBw8ivGGmBe87Q0E/tTWkxHo5BIIdHrun4TAPz1AB9oBWpFquuM4KDY+E1m88cFPLJKw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UurNP7BI; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=uM4HDx56; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UurNP7BI"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="uM4HDx56" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4peBw69PP8vhjHIr05jZ+uZJBqbGRcmM8VXQydrAoVw=; b=UurNP7BIrJVpDooRK41ypLBgkUB3QgY6ILc4rHtd+ZpNjG4jRVY4FIb7Ocgbkn13AYEhWl Jg/ao6iuX6GQ5OSKw/hkgCzoyzIoAg9PG1BryZG0VhtuGoaJ8JL20jWAzFm9m4oSp8t4/1 /it29sTvuFAqJOzuIV/c0Mx6EiSod9A= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-84-9S5hDmXCN0KBqngADgPMvg-1; Thu, 08 Jan 2026 16:19:23 -0500 X-MC-Unique: 9S5hDmXCN0KBqngADgPMvg-1 X-Mimecast-MFC-AGG-ID: 9S5hDmXCN0KBqngADgPMvg_1767907162 Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-5eea3639aa9so1313507137.3 for ; Thu, 08 Jan 2026 13:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907162; x=1768511962; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4peBw69PP8vhjHIr05jZ+uZJBqbGRcmM8VXQydrAoVw=; b=uM4HDx56JzCRwslbjYhoM8HBHSC8BqbLhnUHOxYhVcMOCQa9T9ejIS4CF+k7OnhTca Wi08vLIezmi+ZJcIsVYuoK/19tVhY2t1Ef1lJMawS0rBBFrN4Pfip+gmL3xFP7XqCRm/ fnhnCtEwgqTsJ5VL7+gvpgO3ExBJ/5NvHzfpW31dVNQf2OBwWMUKhx8DWB4+GfFFuX6U UAbC8vtOTzRovTPloO+QrMmReH5r4taaVLCOiKrcHGLJSCWnJzmbNz1DA33uFtPl3t+g CBFzoCpeEDswNCflp+RO9ljT6fTZ7coutoQpiNRbVzFRhbTtOofbfGcq2azoqAdYWmAZ Ib0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907162; x=1768511962; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4peBw69PP8vhjHIr05jZ+uZJBqbGRcmM8VXQydrAoVw=; b=Z8Qx3AVEcyBxwHQNQQycrKHnUYzQPd45jJr6DbmCB9SZBkI2hcsP2N4j4vniShN1H6 T7UEQPYBCxXubOplD8FT4gKBDvENC6mstHUKrTMedogxXu90fTWdlBWvJlkCKJNoWMUH AZX+HXeyKXg2qlOX6FgzEoIHQEfUhWQYaVOXg6VhOO6DuHeSPYPBIp194yPMLWGeMeZv i0PmH00swgHvQ1ShjahFsyAFZd6PfmnNMRUsRPfrhS+olkroyl8v3eEfk8Dfa1w/Xiyl wP3n/AYXM+OrAS2fCTNNwvfnZqkijqNslCAAvpJAiiFzAPoTGb55wkTTk1cSvE0KWZje FKYg== X-Forwarded-Encrypted: i=1; AJvYcCUrMT9su5Uh64YotVxNaAtMBSzMkYbAL+96B5vrLieBcurvTJx49m+zWJFHsjdDQCDZEuRn+8uSfuIPgTU=@vger.kernel.org X-Gm-Message-State: AOJu0YwLO9SZk31fbRQ3JXvPodKdA3n8cCq5gdYAXSAeBPWf7Xb2U6Xo VUxZ5MwwOz5dvh1eoUJc07btpJWEe4D/jYWze81qy/KLThpYa/xOF7FoNhdC00RGH7gmrnzppf2 koscnUY1ZHUfzrlYqr/C9POddoM6A6plO6mksWY5pCvnr8jmuk8in520bufFy28FzCw== X-Gm-Gg: AY/fxX7KbF+FJmU2mENqVt/qAqOntX8Dy2ztf9R+KtsDMr6xuotlt1JU4DCcULj+tkr fN3eJPZHLO13eBdIvVlCNMyXYxCqMblXNnzQk1gsffgIRAqehfOCFw/CQyOXjtO3Do/UBpIhaZS gfyls/5SuVEgn0FYvNzbnla3gFhhj0jWhwbRQ+wSH27Z3Qz+HNMPFTocHIu6dAy1Ysza2ThQtFG mypP3BcpGJFQEOrQDRRgLMxFRA2SJJmIoc/cJenUhWe1Ys5OAnc55PBrtrxkBiNZvY71rTvivmk rngZlCDOZHg6uVx/aIRFAw3IMTiSJc8HAXC9EcKyCPNhhonL+UVReL2yE5h8wA/2T4gNKx9Bx1f YTaoi8ZnDm+CsgxU= X-Received: by 2002:a05:6102:5706:b0:5db:f615:1821 with SMTP id ada2fe7eead31-5ecb1e9047emr2878925137.10.1767907162588; Thu, 08 Jan 2026 13:19:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IHX617rWwFP5JDkAG0NXCVTIRF1Gw7q7Tms3/TJs1fg+8kkPdf5GNQ0cmPYO2937oiV6debZw== X-Received: by 2002:a05:6102:5706:b0:5db:f615:1821 with SMTP id ada2fe7eead31-5ecb1e9047emr2878914137.10.1767907162238; Thu, 08 Jan 2026 13:19:22 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:19:21 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:43 -0500 Subject: [PATCH 25/27] phy: ti: phy-j721e-wiz: convert from divider_round_rate() to divider_determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-25-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney , Vinod Koul , Neil Armstrong , linux-phy@lists.infradead.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1452; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=LzaLThjuJjdtJh34gPTyvntKRADSiE+8sGiCKAXic3I=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5HZ5r61aU2PR98NOoZ3h1Pop1Z/a8v0V7hmw7A0xX q1wbgtjRykLgxgXg6yYIsuSXKOCiNRVtvfuaLLAzGFlAhnCwMUpABOZKs/w3y/iUmSjxwW9bLP6 OdvPy2x47fW2563qFwvl48qMd077qzP8D1ub9qLrLrODkPZ7g89r7B9cKWuZmDh76bPQfNkquW/ G/AA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate =3D divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 27287e3b52b5 ("phy: ti: phy-j721e-wiz: convert from round_rate() to = determine_rate()") Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! Acked-by: Vinod Koul --- To: Vinod Koul Cc: Neil Armstrong Cc: linux-phy@lists.infradead.org --- drivers/phy/ti/phy-j721e-wiz.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index 12a19bf2875c601c60ff5559e1554274ee215918..6e9ecb88dc8b7842745486ae8ad= 57f82563d6711 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/drivers/phy/ti/phy-j721e-wiz.c @@ -940,10 +940,7 @@ static int wiz_clk_div_determine_rate(struct clk_hw *h= w, { struct wiz_clk_divider *div =3D to_wiz_clk_div(hw); =20 - req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, - div->table, 2, 0x0); - - return 0; + return divider_determine_rate(hw, req, div->table, 2, 0x0); } =20 static int wiz_clk_div_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 327F633893D for ; Thu, 8 Jan 2026 21:19:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907173; cv=none; b=nXpuMCuuT0w6WaRPPg+mrIdciN1Op2kIgMlZJlVQFal/GtLjquZ0ZcgGRj9J5Onh1xZL3PG79rhind/DzSF/HCDJq72BSalA30XTMWOIRBbi5+80O77b/ypbaFE4gO7aKde/BMwJRtbiqGQjIq2dbk2sh0f45HFl6XO9rNam0TQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907173; c=relaxed/simple; bh=t4zM8uFO3UkM6b2fxrdGu4KeHudrxCPL9CXUAD5cYTg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZxOUBnSG+ynm21rgYS9jp4EoCfEhR6dWTg7SvCGlTT9M6TPHSB/cT21CY9jw+BdP5S9BUzW+njgwjcKcOWwMFhYXhbvLwVv3SulnuybsERJDAvJH/sPRXs4rtpznIPyIJv0SAZEwzcbKOyHBKWZAyTVivrycHri3OghArukjqio= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eTBWlP4E; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=mjmXoAcH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eTBWlP4E"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="mjmXoAcH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8XFWRNQY7I7tUqJ0Pt1aWTLNa81jETDo2Sqeshx+vWY=; b=eTBWlP4EAQUPiMjj78CaGXqFMA+I3EpiD/NZOqULJ1B8pMyLYknbAxScPUp1qnyj9Ok9Xa 2HmIvsgPZxu3z/CfMFRy9YhdVOCckupnfypD/qcOBhzxQOfssRBxotDMTV+7H7VdnXtkI1 mK7aM381oJZYRusaqzDJs4qyeKNh5mM= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-41-3d2xfSgFNA2hNU-7D1H3IQ-1; Thu, 08 Jan 2026 16:19:27 -0500 X-MC-Unique: 3d2xfSgFNA2hNU-7D1H3IQ-1 X-Mimecast-MFC-AGG-ID: 3d2xfSgFNA2hNU-7D1H3IQ_1767907167 Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-93f5d18f105so3727517241.0 for ; Thu, 08 Jan 2026 13:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907167; x=1768511967; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8XFWRNQY7I7tUqJ0Pt1aWTLNa81jETDo2Sqeshx+vWY=; b=mjmXoAcHXH4zEq/J3L94+yADPmqh4LF9gdxXbhq6951Fec3XCYrTH65LaFt4P9EqUA x6O3ZRoDdOW3S229eM6+DkPSQuRDte0QsZexVDHOSBjbOP7Xa0+eQ6Yqd9vww8Wsg68O bQy0T39zrJOfzvIYa8pnVUy0KTYAFRGKUU6x953CGbOQBo78TcxL4rUG/zyvAHq14aJf +Xf6YM0AMvRYNwaT8nLOdR//Aap1cJGv4xTXmRGZRcYySFmLtLJFJrxJmDffiMeHgfWM /H7csEJthTiDPB3lCsYaRTgr0wYUDVvCtOFqIUz1dYmsMlqgvOqog6jtdap7PEPqShB+ n1cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907167; x=1768511967; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=8XFWRNQY7I7tUqJ0Pt1aWTLNa81jETDo2Sqeshx+vWY=; b=jnMu62VSp6zMZtkmvS70gt05QaF0u/6DLN/tHu4YBHYcPqq+EvF5z2jNshvDR5JP4m AUyz+dQ1VC7wuZ5KuoCPvlt0T4tElaY05TRACd23mnNBW6TGyknIjodaeM/WjslQ6YUX 6hS2qNkPr3muVu/qlDNcVOUUa/a9a8KnyrKtuDAPYDsjwEejgBlfja7y5j/UruWmQTYp Ku1Z9eqal28KcUwyf03ClQv8mWio6rlDKfAjorniXuFx+5z516kiIOSrY3AEvj1xgzYD yZTwRTVir6RGBXoogMaqJnQn/5ScPEq9hZIj1Y6JmohrwFvo4+J+aA5FsCd40kQMQBbR A/Ng== X-Forwarded-Encrypted: i=1; AJvYcCUkuk9JalF96WFBclu7sQa/yzaoQRrKjajU7X2wKbbYhGy/gk76zeMFYVo1fnq9lsqO9yIJ+br05xaKMRM=@vger.kernel.org X-Gm-Message-State: AOJu0YwCBkk6Ftc339t4B6lFVFjE/34jEe8RHWThBvLUu0CiVHDiBZEZ ulzsGe6qajqsrrsSzFyNwotiCdNP6VPth/i1eL4lO26T454KLQibxm5E2i8oRoor5jeL4tK4DRp A+9cMTUMC+yITQ8EWAy1OZZAUtss176nLTXpPkqTI1+edJn6nDantwxivYxKvw0EarW0L6iC/SQ == X-Gm-Gg: AY/fxX47GZgPeq7DXYJDWQl3LcknZquJo7K0bibXjsrXgSE9cIhog+zEkJBqEQBn5MA HG2iuSX0djXcYSuveWZQqpyRpNpn3PnSESqjZU85EDRedASNFY0ZcBmqxT7Aa7lHBfmK1WLcq0P i9J2eDfod5F3SBVRZcdfXc48SGTqGyTwggddyPGWXAh7JGjkEmOhI3oIKo+tE1KhErfOHyjjS2K 2Tb7EvzLZe8/fRAMWKj+JUxdhI4fJOsELDDcZim5eoQicXG5pThm2gvMK+JorFVNdRFEJ+JKa1z yWPXplxF0GMBJy+1YOOA1cHhcshcfG0YNvSrmTSP52U2kLXOd3QLBsuyHXwTD8BU84E7Wn0xOTx /1mPZOJTPle/Gtd4= X-Received: by 2002:a67:e113:0:b0:5ec:c528:4df0 with SMTP id ada2fe7eead31-5ecc5284f85mr2719221137.34.1767907166739; Thu, 08 Jan 2026 13:19:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IGOrsvvufL5nGv9YAlp9TLDtBx6ki9n9l+q0ZIfj+0L81Pet9Ugf8yY/kN38alUABtcfu66ow== X-Received: by 2002:a67:e113:0:b0:5ec:c528:4df0 with SMTP id ada2fe7eead31-5ecc5284f85mr2719217137.34.1767907166381; Thu, 08 Jan 2026 13:19:26 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:19:25 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:44 -0500 Subject: [PATCH 26/27] clk: divider: remove divider_ro_round_rate_parent() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-26-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2855; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=t4zM8uFO3UkM6b2fxrdGu4KeHudrxCPL9CXUAD5cYTg=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5HZN8om3M/l1PUFwY1RC2E87z+8RItV+nVqrN1X/m 3jx2MrDHaUsDGJcDLJiiixLco0KIlJX2d67o8kCM4eVCWQIAxenAEykZTsjw/0vZjc/x1aKpOqy e1vPmMQSrGs31eFxxwqG3s8TFA+6PmNk+LXWs97TTPDgrI5ZbSaH2cMOzbhhXe35qKT1gvkUnRR fDgA= X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 There are no remaining users of divider_ro_round_rate_parent(), so let's go ahead and remove it. Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- drivers/clk/clk-divider.c | 22 ---------------------- include/linux/clk-provider.h | 15 --------------- 2 files changed, 37 deletions(-) diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index 2601b6155afb7391c6a0ffb91c58fa66cde98197..7e414017afa12c3838634ec030f= 960d8aa028b99 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -409,28 +409,6 @@ long divider_round_rate_parent(struct clk_hw *hw, stru= ct clk_hw *parent, } EXPORT_SYMBOL_GPL(divider_round_rate_parent); =20 -long divider_ro_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent, - unsigned long rate, unsigned long *prate, - const struct clk_div_table *table, u8 width, - unsigned long flags, unsigned int val) -{ - struct clk_rate_request req; - int ret; - - clk_hw_init_rate_request(hw, &req, rate); - req.best_parent_rate =3D *prate; - req.best_parent_hw =3D parent; - - ret =3D divider_ro_determine_rate(hw, &req, table, width, flags, val); - if (ret) - return ret; - - *prate =3D req.best_parent_rate; - - return req.rate; -} -EXPORT_SYMBOL_GPL(divider_ro_round_rate_parent); - static int clk_divider_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h index 630705a47129453c241f1b1755f2c2f2a7ed8f77..000f4063e0d10e6772f6d2af7fe= b0de7741e7255 100644 --- a/include/linux/clk-provider.h +++ b/include/linux/clk-provider.h @@ -743,10 +743,6 @@ long divider_round_rate_parent(struct clk_hw *hw, stru= ct clk_hw *parent, unsigned long rate, unsigned long *prate, const struct clk_div_table *table, u8 width, unsigned long flags); -long divider_ro_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent, - unsigned long rate, unsigned long *prate, - const struct clk_div_table *table, u8 width, - unsigned long flags, unsigned int val); int divider_determine_rate(struct clk_hw *hw, struct clk_rate_request *req, const struct clk_div_table *table, u8 width, unsigned long flags); @@ -1446,17 +1442,6 @@ static inline long divider_round_rate(struct clk_hw = *hw, unsigned long rate, rate, prate, table, width, flags); } =20 -static inline long divider_ro_round_rate(struct clk_hw *hw, unsigned long = rate, - unsigned long *prate, - const struct clk_div_table *table, - u8 width, unsigned long flags, - unsigned int val) -{ - return divider_ro_round_rate_parent(hw, clk_hw_get_parent(hw), - rate, prate, table, width, flags, - val); -} - /* * FIXME clock api without lock protection */ --=20 2.52.0 From nobody Sun Feb 8 15:54:03 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89174339856 for ; Thu, 8 Jan 2026 21:19:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907180; cv=none; b=u4k8CSpUZO1YFkh5ZCi+ppTeb2LzdZ2WAFGin3YzeqAfcM7iYYJQYN6yxIMCT6pS1u9/4nJKjMvH9/9ZqDKxe6DERvSrd5qC5IyPeWBHy9vOQ5Apv8A63/qsD9eFZz1xBUjWWMjVn/LweG7sJW2CtFnNfjCuBto1rUsoyDjcCyM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767907180; c=relaxed/simple; bh=7gS8R9ubIL8YOU5prWLYeLbasyiJ1ewi1xZXoJO78ak=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oDNYh8AUBNGZygGg1Td9STqeoKpHkzW+IBPHj+WZNU8AEj0SbHtzAP33ov8dVqYZQTDy/KXSRhsz1OKBKU30aXS+QFp1GUfBrvEnDZUpJZOSJVTBUym9mEXrxV5R9mJxPLMh6cn+3GUyXkI9Ptr1mEQq+Op6F3mGnMS6N1k+dks= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TPoVqyJP; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qv5NO9OE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TPoVqyJP"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qv5NO9OE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bgA35QJPt6bn7Cwt8Wzj2jn50koHv1JzEeGEjnq2gUU=; b=TPoVqyJP8fwAg5o1fZIF67/sOhNFOa50QzRkNB7CNvX6NUbmwXL1wKsUNo2c73cQUIB9Zp e5CbDKL7rlhwo+bD98/vOvMgpUOWkv0DiBO7ru7rag3oXJ0ws+Ots9frUcUUT6nIt/9HxF 9Q49lXKQ7W17dvEksAvRvumUYO3sG7g= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-pmPpynuCPc-hvueW8MFQhw-1; Thu, 08 Jan 2026 16:19:31 -0500 X-MC-Unique: pmPpynuCPc-hvueW8MFQhw-1 X-Mimecast-MFC-AGG-ID: pmPpynuCPc-hvueW8MFQhw_1767907171 Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-5ec87b2b4ddso1831282137.3 for ; Thu, 08 Jan 2026 13:19:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767907171; x=1768511971; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bgA35QJPt6bn7Cwt8Wzj2jn50koHv1JzEeGEjnq2gUU=; b=qv5NO9OEQEYkb74Tp1qGn+FXlLV2xTguTO3V0KkF7IRMbN9s4tK6G3sAjgTFiwL8pE o0aPrf9WQWiO3TwXTsE2/64q0oAEq/oAIhXAMoakYSJapemjXhbaLeO8meGWxVfmCmAK YoC03hl+9J8QSJVUUr/+c2TwI1dDOktzMOUyTXsGAYVEuHbM4ITsiMAHwWzcrX76ljIG 7meWclWDdoXUnMwH/GkfYD84gVFGxT+bm1iiGd7FB1yz6JskMfSgloBEondc85ZWVFzP KixSWCJ2D0/QPemNDUNsCjC56dEKc0PfkLMapjRwFzMTkY4WytQlsnA5ENIxvscoq6qp 30eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907171; x=1768511971; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bgA35QJPt6bn7Cwt8Wzj2jn50koHv1JzEeGEjnq2gUU=; b=gsImKcAN5CEZua3z6AOTuBUNUEOugdS+pCZnUDWnQjWgE4pO8FExgfMronriwJiF0+ Inhx0VPh2wJbtU0iBVK0ak5eok1U8YaclDmy6F5VtP5b5TpPwJ/DleGuHHl+CnxhY8Xz HNggoEEPZsvQYADWF9ING+quaIdPMois8CXDECf3bom32EuD+wW/Hu1eeWS8JhPxBBd1 wkMYleE/49SeWSIu9cFbq54saM1jSED3NXqh12GYOyXGOiKsx8m2HOgNiQk5qeV30Pti /VO7fzPIAO+xoOVCEEBnybPpVoxMVNc+FUT10h/Yd7z610GZW2UHN9YY6mPivnyBk8PZ D85w== X-Forwarded-Encrypted: i=1; AJvYcCVXFIJMNXAjTYqtl6ls76Hx3sBpCE1WMQ9sbnkXoqUjxPNviKaYiSjA5hrZStFuHBsEfBuqERIBgODqYQc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkaxi4ym+p1IBaqIZAV4hIOmReOB2q+1RBCNYEJ9ztJBgXapc0 fEmy33ocf0h37thr0pCOo46YYdgdcbekqdWeEqZ8bDxm5EbVLIY7h2egFLEKqR0vjLEAlaDttNL B9prdC3ZeW4aFYr5HWsEPs0PNmMK3tSjqwIAjO8AG+dZgkyL8GNm3a0/kJPrhGts+0A== X-Gm-Gg: AY/fxX5sFsoAY26qcd+GMAXsGE07cpeJTnNhuGXXl4ZwbsbRyeQeuM9NLu2PN7+jK5b Qh0H34it3PM3nN5Qk1EUZ5QlpwYuGLSjPvbPHORkIZ0e4l8lbSX1WG/9P4LYOezzbLz5F+rcnSp ehgbBKJumGBB8izenNZsUrnJBrURMMQMRpeWI8oTBVr8qRVpl4lArQIB6/GuTDu8vzHX1xzZ0UC 1OoAnBGVVC9VKQAgX77sdbevviepiFpCtJDarJ3hJXvJGDLFuHykxWnBPJmxmySrITQ9bB9itr0 npv8lNNwZCk/N0SwN14uU6U3bpxgX6EJ2pVlOgUmXvF8mzDyTJhN9CwrOE+kVR3u1zO0u1J2+1u 7501dAzfRKh5QeVg= X-Received: by 2002:a05:6102:952:b0:5ef:24aa:986f with SMTP id ada2fe7eead31-5ef24aaa8aemr42517137.2.1767907171065; Thu, 08 Jan 2026 13:19:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IHR8SU0cC6J7ZM6ORTAUjC6oyDRWxh5N7rfmic1Z80tAO+vimFrecGsZaskUobrNYaLX9pXEw== X-Received: by 2002:a05:6102:952:b0:5ef:24aa:986f with SMTP id ada2fe7eead31-5ef24aaa8aemr42510137.2.1767907170711; Thu, 08 Jan 2026 13:19:30 -0800 (PST) Received: from [10.30.226.224] ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec77064e86sm7623329137.7.2026.01.08.13.19.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:19:30 -0800 (PST) From: Brian Masney Date: Thu, 08 Jan 2026 16:16:45 -0500 Subject: [PATCH 27/27] clk: divider: remove divider_round_rate() and divider_round_rate_parent() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-clk-divider-round-rate-v1-27-535a3ed73bf3@redhat.com> References: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> In-Reply-To: <20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com> To: Michael Turquette , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2813; i=bmasney@redhat.com; s=20250903; h=from:subject:message-id; bh=7gS8R9ubIL8YOU5prWLYeLbasyiJ1ewi1xZXoJO78ak=; b=owGbwMvMwCW2/dJd9di6A+2Mp9WSGDIT5Hb58B//GHHWfp3R8+QtIk27eMQ+zz2hs6VFrSDP2 pNxNducjlIWBjEuBlkxRZYluUYFEamrbO/d0WSBmcPKBDKEgYtTACbCfYGRYRd/E+/ZHfFxSj0d Gda2HWIC9Tt+WLPJxM9+XF/IK+fpxvA/pPTY9AMiZYv/nDnyklXtWJpzfF66jrHAcrPZs1KKqyL 5AA== X-Developer-Key: i=bmasney@redhat.com; a=openpgp; fpr=A46D32705865AA3DDEDC2904B7D2DD275D7EC087 There are no remaining users of divider_round_rate() and divider_round_rate_parent(), so let's go ahead and remove them. Signed-off-by: Brian Masney Acked-by for Stephen. Thanks! --- drivers/clk/clk-divider.c | 22 ---------------------- include/linux/clk-provider.h | 13 ------------- 2 files changed, 35 deletions(-) diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index 7e414017afa12c3838634ec030f960d8aa028b99..8439784ba08572dcd970d5d4ce3= 857c6c145763e 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -387,28 +387,6 @@ int divider_ro_determine_rate(struct clk_hw *hw, struc= t clk_rate_request *req, } EXPORT_SYMBOL_GPL(divider_ro_determine_rate); =20 -long divider_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent, - unsigned long rate, unsigned long *prate, - const struct clk_div_table *table, - u8 width, unsigned long flags) -{ - struct clk_rate_request req; - int ret; - - clk_hw_init_rate_request(hw, &req, rate); - req.best_parent_rate =3D *prate; - req.best_parent_hw =3D parent; - - ret =3D divider_determine_rate(hw, &req, table, width, flags); - if (ret) - return ret; - - *prate =3D req.best_parent_rate; - - return req.rate; -} -EXPORT_SYMBOL_GPL(divider_round_rate_parent); - static int clk_divider_determine_rate(struct clk_hw *hw, struct clk_rate_request *req) { diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h index 000f4063e0d10e6772f6d2af7feb0de7741e7255..85f456be5f12ec46e86e5819643= fed3fe3790fcb 100644 --- a/include/linux/clk-provider.h +++ b/include/linux/clk-provider.h @@ -739,10 +739,6 @@ extern const struct clk_ops clk_divider_ro_ops; unsigned long divider_recalc_rate(struct clk_hw *hw, unsigned long parent_= rate, unsigned int val, const struct clk_div_table *table, unsigned long flags, unsigned long width); -long divider_round_rate_parent(struct clk_hw *hw, struct clk_hw *parent, - unsigned long rate, unsigned long *prate, - const struct clk_div_table *table, - u8 width, unsigned long flags); int divider_determine_rate(struct clk_hw *hw, struct clk_rate_request *req, const struct clk_div_table *table, u8 width, unsigned long flags); @@ -1433,15 +1429,6 @@ static inline void __clk_hw_set_clk(struct clk_hw *d= st, struct clk_hw *src) dst->core =3D src->core; } =20 -static inline long divider_round_rate(struct clk_hw *hw, unsigned long rat= e, - unsigned long *prate, - const struct clk_div_table *table, - u8 width, unsigned long flags) -{ - return divider_round_rate_parent(hw, clk_hw_get_parent(hw), - rate, prate, table, width, flags); -} - /* * FIXME clock api without lock protection */ --=20 2.52.0