From nobody Sun Feb 8 05:59:54 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 801A2334C32; Thu, 8 Jan 2026 19:12:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767899539; cv=none; b=kWke/M0kAztyNGpNE1ivAxOvC0vAwK6SOvnY5wXCjCENIik60H6vfP93p8Ef2uvNy/IubKyFM7vhFLYdcS0xWWY9XRrNhiKe7I2qUcXM/+XO5v8UD9RZAe8G98xyK0gDyT3NWcKwRWF+hvRKkA12zw7wAZj3hwqXx+6ciLmXMRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767899539; c=relaxed/simple; bh=z58YjI9naACNod9LOsx9aXafudrnXjr+TBbt5HgVpuw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=o2EIKn9wieWdrkei4l4yWusIMmaZ0lLBTPvlq4st6I4OA1QNkWHPb8axpejU/ylTvRjHjGG+JFIHoKZA8qdRNocCm7x3GktskO7ugKRfNgVkUDQ0263+sk5mklcr4492U7ULYh9gg1I1scvGSkHwJhJeNPiiAV/zO6zUk96YG1A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P4IlBCPx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P4IlBCPx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA272C19422; Thu, 8 Jan 2026 19:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767899539; bh=z58YjI9naACNod9LOsx9aXafudrnXjr+TBbt5HgVpuw=; h=From:Date:Subject:To:Cc:From; b=P4IlBCPxK+RgWYdPuBKzOhldC9QrcojKaimIn1KA1HarklnzxHE/qtfcVYeOvl1hv gbiDS2rs0jD24ganiJOAn5KNo0fBXnVzeOt8QY3hfewRpXgdRQfrocCYmuIeIxSkRo cPtI+u2lhjN3/uSkJmb5HN3hhY8/CeSUg77CXYnkqMDaR7N0dOnOUfkj+scnGDJ4YC CAN580zxHSuUeIfkDdxTMiFcDeGqESvvfQCIKvC8xaee0ch2Ufk6EH3Dq8ZkM2YVKW B+kqSViwLtdfut3lny7UTEGOmqe7H0eQ2IzN51hFvKL5FvHjSXuzw6w69FC5WE6o9h MDfsCVaIG5eSQ== From: Sven Peter Date: Thu, 08 Jan 2026 20:12:06 +0100 Subject: [PATCH next] phy: apple: atc: Reset USB2 PHY during probe as well Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260108-atcphy-coldboot-fix-v1-1-01c41c6e84f2@kernel.org> X-B4-Tracking: v=1; b=H4sIAIYBYGkC/x2MQQqDMBAAvyJ77sIaYyz9SulBk7UulESSICmSv xs8zsDMCYmjcIJXd0LkQ5IE36B/dGC32X8ZxTUGRcpQTxPO2e7bH234uSWEjKsUpKcZldOkBz1 BK/fITd/XN3guGT61XhGkcgtrAAAA X-Change-ID: 20260107-atcphy-coldboot-fix-08652d404347 To: Janne Grunau , Neal Gompa , Vinod Koul , Neil Armstrong Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, James Calligeros , Sven Peter X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1444; i=sven@kernel.org; h=from:subject:message-id; bh=z58YjI9naACNod9LOsx9aXafudrnXjr+TBbt5HgVpuw=; b=owGbwMvMwCXmIlirolUq95LxtFoSQ2YCY9+UzFuyso9/fGfdmF0iU8AsMPePwHd1n0exE1qV9 Vcvkz3dUcrCIMbFICumyLJ9v73pk4dvBJduuvQeZg4rE8gQBi5OAZhIuQbDf/+JjxUvnNc+tGxt 1h3ZrzPFiltui8u2Md4+x/ZUc92lg/aMDLN8PO92z9xZt+FspcbhGcabT5ksLjlxi3PTvWmaHU6 Ne1gA X-Developer-Key: i=sven@kernel.org; a=openpgp; fpr=A1E3E34A2B3C820DBC4955E5993B08092F131F93 Now that the upstream Type-C PHY code is getting broader test coverage we got reports of USB devices plugged in during boot or those plugged in for the first time after boot occasionally not working correctly. This is partially caused by the USB2 parts of the PHY being left in an unknown state by the previous boot stages. We reset all other parts during probe but forgot about the USB2 PHY so let's fix that and actually reset and power off the USB2 PHY as well. Reported-by: James Calligeros Reported-by: Janne Grunau Fixes: 8e98ca1e74db ("phy: apple: Add Apple Type-C PHY") Signed-off-by: Sven Peter Reviewed-by: Janne Grunau Tested-by: Janne Grunau --- drivers/phy/apple/atc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/apple/atc.c b/drivers/phy/apple/atc.c index c8a58ee64b7aad3205df51cf16ae778471ad2c5d..ab0b40b72533f1b3878b646b598= 20c730239e85c 100644 --- a/drivers/phy/apple/atc.c +++ b/drivers/phy/apple/atc.c @@ -2227,6 +2227,7 @@ static int atcphy_probe_finalize(struct apple_atcphy = *atcphy) _atcphy_dwc3_reset_assert(atcphy); =20 /* Reset atcphy to clear any state potentially left by the bootloader */ + atcphy_usb2_power_off(atcphy); atcphy_power_off(atcphy); atcphy_setup_pipehandler(atcphy); =20 --- base-commit: add66a6673bc4aacd0ef0f3c4a51271501770b17 change-id: 20260107-atcphy-coldboot-fix-08652d404347 Best regards, --=20 Sven Peter