From nobody Sat Feb 7 21:04:59 2026 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E56172D641C for ; Wed, 7 Jan 2026 21:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767819736; cv=none; b=jLFk8jiV1q/iB4TkfF0RmE0cW2vGkbq0PqE90v6cEjyfhwzUQ0QUsL78vJSxRq1tDyj0hVYE/uRBw1HsJ8NSsx82mRvCXPYPgsLoK3jNCR0od49V37iKWiQyHhlyctyQD9L90kDh7hYPtXVYVtYDnpcgfw58rF//KgsoUZipSwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767819736; c=relaxed/simple; bh=OToRqjvmUYJ/hQ/uywMC5tHsYvK3gXP3yNUZuoCsk/k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N50pf0P10t5953hSpHRbw1iPAUEcNEFYDVUJ6INs3AGBn5xwuXyBtxLlXOqFE8TIKYYPqBByWVnahUbAWf5KzZQ/s0ymMn+i6yJoXzD78o5QGXoh4gYFc5SstPShNebJ1FaQorZZwTjUxXKK9Zr0XQUbPsVnUW5Malas/xxHaz0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J53VGxvM; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J53VGxvM" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2b05fe2bf14so2530482eec.1 for ; Wed, 07 Jan 2026 13:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767819732; x=1768424532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=StC5RRMJpz+kQrLWAhYbYP3HFYIHTdt3vEQL2gvPaOI=; b=J53VGxvMIZxqirtQX3wYHg+/odvWOpaJHAskxJ3YBshcYnKwwF3R4WbljGmaRUg+Qs /xM/QUDAH2e4UOswRlUSenqeRQHu9du25kCP8hgxpxODXi+BCkpSLQ6SqFg425Uc3h/h FvT75zjj1BcV2WJ0n3YOWALK11q/QXQXdrkarHvM9KjaW+OmVv4BSNpY3JzubrEcPwbc myhm6x5d3G3GaVDNxgHulCWD37Uh0mcDQFfjgC47Giq4JtqmVCyNjFKHe4zio9wqD/lm TS3qlJpzAhkku6vYjEHjy3j9CKPkdJ0Bo0iu34g73a5cVVd1STbIUpHtOub7fNjfbiEo VeIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767819732; x=1768424532; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=StC5RRMJpz+kQrLWAhYbYP3HFYIHTdt3vEQL2gvPaOI=; b=hD05sqygNQM65JouFz40qHrzSeFRnRl9ZHb24q/sVe3tg8fHRdQbm+w9Xj+8D5NigZ A/qsDQ2noLTtlgYjiUxlr1J1qmE54/MRwqO5ESSgcLgdVklGSaoCWXTzl+076QO+aeRt dfOh8CsQEq0XkWk+lWTtbvR/xytueWEsKbzkGLHmaTnOXMYYXKVFVJ/qLekA4urGPK8K 2pYgCACEhDMhyh+HuARkkrtVqUN2aXfMN2KD853/k5wyU87XeOp3V1+eHrhupvid8dil RO8wVozdFwzsckR4Ror/7n7+rdJ9T+03qQsrdoeZQ5fc7BJ6tGmn6bLUPWlAG7Jz7+o+ nowg== X-Forwarded-Encrypted: i=1; AJvYcCUowapa/itRr/EB4yhM4bFlYVpSc7KagV/MWNlaWWLwSPy7DPIpQ+zao/WN5KA3NWT+7TkfR3pqT+hm4uM=@vger.kernel.org X-Gm-Message-State: AOJu0YwZLJqO3TkidEZb90Jw8wZgAq0NGtRPdPLi70bySRFf125q0cPx 66RXtuovMLOaqX0hDydoWEQXlx/JDG9KHaQ54AVd3EWP2LT6E6dcYPx9 X-Gm-Gg: AY/fxX5qRXjdpfOd0lbiuOT9YXFlPvxCugm97LHnxb7DvQz+jrh6uRX5YQ1ZVY6S5/6 GpRRDU2VF8Ncn96IXBkXCT3gIl7tMGNguWdt6RCEpZeQ9njzRbcddtR4LP1P4waHdSxTqK/LYoe CLxetQDNAFmBfffOGh5yU+9vFD2p/dAAmrglDkFb4YZv6p1BTSon24PIN1RE/5xU7aMZrrAUxFn bsIMmEs4ZO0oTnNWOrvpyKzM9/4tv8f4Qgy+e5rAfmGB+NCKOTQ/R1X3Wj6alMieyX8EaNnXsTi FPM6b8+AKTx2AMoYqFUQDBPrUAqYcu42vlJMenVJqOFCis1Zu5bfsB+A6MLx785fDxDKNoq/2Mo 5DKAgH+9jP+xfX6s7MJ5ibEIntG2gg/jxFbThls+wINSkQbSR2SLcx1iqJnmWUBQQGPHL6xb3/B jIm0l9sN3cAjlr8+Vnah1CnFVaTTCTUD85eKHi44c+6piZ4xEzHl++g7wCj/Vt X-Google-Smtp-Source: AGHT+IHsusTxGdP1PS4z/IoCh9itAIP1JdP4x5wJw6BXtiBXvisAnQNe01ae9GbbYPWzAyzvMWqFZw== X-Received: by 2002:a05:7301:e2b:b0:2ae:5ffa:8daa with SMTP id 5a478bee46e88-2b17d200bc3mr2817972eec.5.1767819731857; Wed, 07 Jan 2026 13:02:11 -0800 (PST) Received: from celestia.turtle.lan (static-23-234-115-121.cust.tzulo.com. [23.234.115.121]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b170673b2esm7730320eec.6.2026.01.07.13.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 13:02:11 -0800 (PST) From: Sam Edwards X-Google-Original-From: Sam Edwards To: Xiubo Li , Ilya Dryomov Cc: Viacheslav Dubeyko , Christian Brauner , Milind Changire , Jeff Layton , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Sam Edwards , stable@vger.kernel.org Subject: [PATCH v2 3/6] ceph: Free page array when ceph_submit_write fails Date: Wed, 7 Jan 2026 13:01:36 -0800 Message-ID: <20260107210139.40554-4-CFSworks@gmail.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260107210139.40554-1-CFSworks@gmail.com> References: <20260107210139.40554-1-CFSworks@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If `locked_pages` is zero, the page array must not be allocated: ceph_process_folio_batch() uses `locked_pages` to decide when to allocate `pages`, and redundant allocations trigger ceph_allocate_page_array()'s BUG_ON(), resulting in a worker oops (and writeback stall) or even a kernel panic. Consequently, the main loop in ceph_writepages_start() assumes that the lifetime of `pages` is confined to a single iteration. The ceph_submit_write() function claims ownership of the page array on success. But failures only redirty/unlock the pages and fail to free the array, making the failure case in ceph_submit_write() fatal. Free the page array (and reset locked_pages) in ceph_submit_write()'s error-handling 'if' block so that the caller's invariant (that the array does not outlive the iteration) is maintained unconditionally, making failures in ceph_submit_write() recoverable as originally intended. Fixes: 1551ec61dc55 ("ceph: introduce ceph_submit_write() method") Cc: stable@vger.kernel.org Signed-off-by: Sam Edwards --- fs/ceph/addr.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 2b722916fb9b..467aa7242b49 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -1466,6 +1466,14 @@ int ceph_submit_write(struct address_space *mapping, unlock_page(page); } =20 + if (ceph_wbc->from_pool) { + mempool_free(ceph_wbc->pages, ceph_wb_pagevec_pool); + ceph_wbc->from_pool =3D false; + } else + kfree(ceph_wbc->pages); + ceph_wbc->pages =3D NULL; + ceph_wbc->locked_pages =3D 0; + ceph_osdc_put_request(req); return -EIO; } --=20 2.51.2