From nobody Sat Feb 7 13:45:52 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FF5D36C5BB for ; Wed, 7 Jan 2026 16:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767802943; cv=none; b=mF8vjrzNZpOJ/nVRFtCYfA6rA7MrCBUGPVyn9qbu2dtyJxgGtK/wEnXOLR9bpTu7e42C7LtISR8wxxdKOGU49jG+8NHfEQzaQJU7H13ayS271YmjxPIn0YvKSuAGd92pn9xDx6UCfuhIbeD3xN7HaCoSKv2FtqUaXQSqOy9drRw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767802943; c=relaxed/simple; bh=5uDuzdaGZDqTQQsaMEcbH0uAxnGPy2WST8SiuA871qE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oy1PQzsx8Z6+33l+wp67VplnaY61iwb1GfeeFkOU5guNToRE18FU78OE0CZT76ZmbzWZhhq3Gzw9Boacte+5okB7G00qf9x4ZqR/7Cto08C6PuD/azDV+KLWJPeC7r//C0dzGIebG9ncyKR9BiGbV/GSnmKLoxR/SLtLwM73wPQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XHSYaEQK; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XHSYaEQK" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-7aae5f2633dso1836772b3a.3 for ; Wed, 07 Jan 2026 08:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767802934; x=1768407734; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YQ+EeA1ktJF0ZEOawgXF1Px2uLqOjG9efcAgHGpbdJ0=; b=XHSYaEQKQONZNXOKbQB6iY2ZlTQu5ph3pdPxP2jRFUFdF441NknIdxL0TKMXEgUUi5 xTToFvTIsUnTTdpvp4mUbtDzD6YS0UXjMu2RX233uwG9ttWDuzawQw5vDeruZ/kFFjJl lXKuGXNN7A/GQe+k7ePDVZUsYhdAz0OE175nYKIqr9YJ+vGh0C5FpO+5gdzVOuADy+6M 13Q/XUGN/abLmUCx9E4XuMoumH0pT/lulzF8DgWB3fIn99hLXjCNZG+7UBjQAdQHCCh7 zdaADy+h8YgpAEFoFql71Lq+0pww7KVenAi2r0vGtrXm7XmuR+YwrNqX9e5CsNap/Oi9 Nz9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767802934; x=1768407734; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YQ+EeA1ktJF0ZEOawgXF1Px2uLqOjG9efcAgHGpbdJ0=; b=I0xOgG5bqdgjYyQ8tBTkgOfanJLcsv1WD5Hp8/WW3Cilrqa1xNhiXoVypEPP8aQnkB JMlufbH950EWSgZmen8HcPo6w9yL6Q4AdXLyscvevescVThq1D1D20h/lMeOxcxl3Kq0 zUuEhozspPn8X5+Fn2nuxUUIsH/LhGTA72f/8AhLwjDOY55a6TouC8ShHBK+VHfssC5u kAulvjtIpUgNU0NdYIvkYrhfK6SzHiDbzLOV0sIyJnDnO3/7oT75AWb2YNE7KG0Uxe9v aWB74g2jVk8d/R97l4NpJSrGOLVKLgNeJ0jtzFM0RzqncWDQQJj5NYMsnbJI8kR4QkM2 zhdQ== X-Gm-Message-State: AOJu0Ywj89cYcxcnzSAafQDy6k6H9S90S9+SKvlWd0b9rWnK1K8uah6K rjNqzIg0yPf6AiqkkMuY2W1aAuRIHGK5ArBtTS+sUX+sqArL8NYjHw8= X-Gm-Gg: AY/fxX4LaGGnv4WAoQHn/r44+GPZzbTgRHjqRWxPkaiyyAhPP2QSUEKwlXcboTWkL/8 UqPj8kXeaAe6XeezcyOQ5CZrih29eTFYFJ/A0n2UqqKf4x8BiY6/tgXsaaqhcLNuBmN1DE0e9uK ftULejL7Gkoe/gc7IhqyjiL0QdgUr5CWEQJS8+Vsj/PiNJKaq+v/fDp5ogirrVi+yyATaTnWC9c Cz9YR7gk32QXJKgI7IPnlFMxnFg0VIRrFib2pL2NWmQ7nfbRuLgO88Xd1x2qkLE61ujARhaeJ0s fJln2co24e4djm/wwg65rCpxDbItSzKBKGHD3ehZLlbvn2d4eyWaxQt+S0by86x447lVPs4FIfD cPWETenmhaQO2f8Ii06z34R/vbPuKHWH39PdMcRgdhDRMddo9jCxx38RtVcggRHuKr6fw2Fs4s0 suJRv1J7MF67wfwIIBlRFZZSB+xyoeVaiwj2YeunKAnTleD8hUe7QEOuvu5BhmPGIKXBYDWtdgh UPIK2CY X-Google-Smtp-Source: AGHT+IEnaBvIbcZAtZZ/QOK9xBNuHMiiKrDZb1bP8xfgrDKTSUGW2q7+K9kABDcOsLY9M8xrlEowFg== X-Received: by 2002:a05:6a00:400e:b0:7e8:450c:61c1 with SMTP id d2e1a72fcca58-81b80ac599fmr2588063b3a.49.1767802933954; Wed, 07 Jan 2026 08:22:13 -0800 (PST) Received: from DESKTOP-BKIPFGN (ec2-54-169-177-146.ap-southeast-1.compute.amazonaws.com. [54.169.177.146]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819c59e83bcsm5400282b3a.56.2026.01.07.08.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 08:22:13 -0800 (PST) From: Kery Qi To: tariqt@nvidia.com Cc: linux-kernel@vger.kernel.org, Kery Qi Subject: [PATCH] mlx4: Fix out of bounds access in __mlx4_register_mac() Date: Thu, 8 Jan 2026 00:21:26 +0800 Message-ID: <20260107162126.1564-1-qikeyu2017@gmail.com> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" __mlx4_register_mac() searches for a free MAC table slot using `free =3D -1`. If the requested MAC is not found and there is no free entry (all refs[] are non-zero), the scan may finish with `free` still -1, yet the code later uses it as an array index (entries/refs/is_dup), causing an out-of-bounds access. Fix this by checking `free < 0` after the scan (and mf-bond slot selection) and returning an error before touching the arrays. This matches the same bug pattern fixed by CVE-2010-5332 in mlx4_register_mac()/mlx4_register_vlan(). Signed-off-by: Kery Qi --- drivers/net/ethernet/mellanox/mlx4/port.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c b/drivers/net/ethern= et/mellanox/mlx4/port.c index e3d0b13c1610..ff1cce138357 100644 --- a/drivers/net/ethernet/mellanox/mlx4/port.c +++ b/drivers/net/ethernet/mellanox/mlx4/port.c @@ -267,6 +267,11 @@ int __mlx4_register_mac(struct mlx4_dev *dev, u8 port,= u64 mac) if (need_mf_bond && can_mf_bond) free =3D free_for_dup; =20 + if (free < 0) { + err =3D -ENOMEM; + goto out; + } + mlx4_dbg(dev, "Free MAC index is %d\n", free); =20 if (table->total =3D=3D table->max) { --=20 2.34.1