From nobody Sat Feb 7 15:09:58 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6303F38B99A for ; Wed, 7 Jan 2026 15:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800562; cv=none; b=TSqR26PIkFmjKy51nbUA2oC9AwbIv2EhN/HWZ21paIoL3qA+n7qxvrWLcGcnJiPXiC3XwHHhB/AnV8yyYDLaz6/+UPnAKHTYb+smN5wz2ZD2UqEqAJCWc/8LPXYsaT+YSfsiK8u1fh2x1Ih3Z2h89otePQymwr2so3R/Md0DS5g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800562; c=relaxed/simple; bh=nS6pktisk1hD3TU7J6j1xKmwIjoYqBmyrao11F/mGbc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GkP0fEvtGCX78asGMC7UUqhACRu90ZwR0b1d+FRpKRUcHQqvC/fG1+a2sWNueKU2xQdaomIxjgzjQFtdEU1JDkstYmcDkXP9gHlmmwF08HH+qAg3RsRqOHNSls0zzpQYXTIyp8ESSGO4ZjL6giNMM8ooXP9395ycMF+YSZ8GUnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mhaW/JjJ; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mhaW/JjJ" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47d3ffb0f44so14771135e9.3 for ; Wed, 07 Jan 2026 07:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767800560; x=1768405360; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q1iAxTFSQoTWeJxaL1NW0AepzE1fhDVEkVj9Fn+hGno=; b=mhaW/JjJEgncpb2EtHM6aUrI1FsbJDSFMB6o2JpLx8PRr1PdmgSMMEwY4K4K7tpnmE RZ+4YGdZjXP1PfnZSGRXfGIICRLF8gXsKcNACWAxwa6tO6vOL5ya32QYvbte3CJVGd4l IBdJoUQ9HJyo8WqPiGXZax58XleGnfE2/o80CVaWK2rbZud+s52QjY2miM6r+s8q3wIP AZres6aL+i81e9mu929JmZVl7X097EGc78kreDY4UhcUksaxYxF78ZDw93UXoQ5GNNn2 uL/hAmWKEsqXL2WkdL3BgT1/ZsIT4mgUlWn6wSahqgIXvxCk1LM9nblOF1MO+0MN5Lqk hqGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767800560; x=1768405360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q1iAxTFSQoTWeJxaL1NW0AepzE1fhDVEkVj9Fn+hGno=; b=TF+FiaeZLri58RwKFk6eaNAO9OsRYVAuK762ZhYY2cPzrMmCBx4IKqE1e0FmaV7FGV 4YoK0womJYLJG+1t/44jA434WmBV/G/X3csSxYJX+dZnqGM833xAQr7oRLrfmdPYyq+Y E+wDnMyVrmrDLvAahCaZ1NXg0wa6ttio0MUkClbF0FOCRk06sgRivCK8CRa7A6252LjM UbTI5rD9Iq98ZUsYJPfvHh5rk3WECIaoEo4LVko8wDB2Fe3usrZLg3ZnyO1/zNIpY0/F SHsUNjD93c/JZaL+Td8TlLSIsENhc9ja8UDiP1qOpKkamqVjuWc7JISrA2Z2EpPGWVwg OhhQ== X-Forwarded-Encrypted: i=1; AJvYcCVGOygKFE32cRT7Z1Ui+Ec6MuCtk/1gvf32aZngwqQeGaxVfFg1jOwtHJ7YofIjQ2n8ORFZH51nEP1C5Bk=@vger.kernel.org X-Gm-Message-State: AOJu0YwEiXbcYMKpLWehpY9Z88UhqvxUAFyhOwzxNScM9GyKfboYjHwo 4gkaAxkjNBz5d1P3B3RFzW33XniIwqS72vmTH/HZ6aQZM6inpW5IyeVA X-Gm-Gg: AY/fxX6r2PGZNmr9LGb6dhMODQUiCZGjhFINHsAkOazRCJPjRuX48QytPIZhiLu54uZ kBFCJitMUP4U81lkYwtf+SG8fEEaKbV2dGnsGcD3Z6QqYgIp4btQIqn4aU1hdbY6bJP70JWhIq4 EBNls2V9H1PQkz50zijuxPxtvyBxahpeJ5RmRnqEeE3aFVrCO5AdSmCQnvTJdMs1GMaO/rJ0KCy Wt9QHUYmrj6lacgFnIHCwWFddJYN2fmwrKOKKnoapGTDjXXfMbRVEGj4n3cB++NYlIeKIpw+Tjg +P68Ec/r2yhPAF5DzYCJc4aV2IbXd74Er7ACzlLgqjLHdmjyrBRSkMwo6K6bgWCF9SCIGVVEHe+ Hb3Z6KAWvfrYv1+Sdd2PX8C0THV4GqVLU62Q9EmwuC11udi80CCr+Vp6M+wlrGhWK1gWaV/Wglb P8jHIPdtSrD47nXsdMkGZWeV8Xmj2Mg+Suxgls62A= X-Google-Smtp-Source: AGHT+IHh42IGnipWJP03g++e9iDVeFqh1L0/fP1w53Z7LZVenjO5qsb70T0wsEsiWCzhWLqMbCV5Qw== X-Received: by 2002:a05:600c:3556:b0:477:6374:6347 with SMTP id 5b1f17b1804b1-47d84b3bb18mr35807725e9.22.1767800559530; Wed, 07 Jan 2026 07:42:39 -0800 (PST) Received: from ionutnechita-arz2022.local ([2a02:2f0e:ca09:7000:33fc:5cce:3767:6b22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee243sm10897704f8f.31.2026.01.07.07.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:42:38 -0800 (PST) From: "Ionut Nechita (Sunlight Linux)" To: benato.denis96@gmail.com, jikos@kernel.org, bentiss@kernel.org Cc: ionut_n2001@yahoo.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, sunlightlinux@gmail.com, superm1@kernel.org Subject: [PATCH v5 1/4] HID: asus: Replace magic number with HID_UP_ASUSVENDOR constant Date: Wed, 7 Jan 2026 17:42:18 +0200 Message-ID: <20260107154219.164514-4-sunlightlinux@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107154219.164514-2-sunlightlinux@gmail.com> References: <20260107154219.164514-2-sunlightlinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ionut Nechita Use the existing HID_UP_ASUSVENDOR constant instead of the magic number 0xff310000 for better code clarity and maintainability. Reviewed-by: Denis Benato Reviewed-by: Mario Limonciello (AMD) Signed-off-by: Ionut Nechita --- drivers/hid/hid-asus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 472bca54642b9..eb14b9d13823b 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -317,7 +317,7 @@ static int asus_e1239t_event(struct asus_drvdata *drvda= t, u8 *data, int size) static int asus_event(struct hid_device *hdev, struct hid_field *field, struct hid_usage *usage, __s32 value) { - if ((usage->hid & HID_USAGE_PAGE) =3D=3D 0xff310000 && + if ((usage->hid & HID_USAGE_PAGE) =3D=3D HID_UP_ASUSVENDOR && (usage->hid & HID_USAGE) !=3D 0x00 && (usage->hid & HID_USAGE) !=3D 0xff && !usage->type) { hid_warn(hdev, "Unmapped Asus vendor usagepage code 0x%02x\n", --=20 2.52.0