From nobody Sun Feb 8 01:30:22 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CA0438B9B5 for ; Wed, 7 Jan 2026 15:43:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800593; cv=none; b=BtAPlmUzHuDRhdyQJGPut+3UEfs9T9m4qdgWIkfeeKFyPXqe9VEDYSJOouyQFp7R+NKPWoXXQZD3lnmRIJ+tGdKzkj5TVz037DFQNYaOp4cjM0PvwDqdy3w/Yz+hkYJ8Cr2pJK5QSbMkRubCjtYXKlJYmT9vwNnWlcpPhirLfvU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800593; c=relaxed/simple; bh=Ufj9J+ZlCwFGFrNBtdLhRA4Pm49DeqcyMm4VMAOYlm4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oTtfDtrCkezFLjlcHJI8P7M5dpG1O8N3MeI4f23kLKn9MpAjbmjaadrOw+yC0RVe6cPzRjrmMGcj1csh2NyDvE/R+vP9aReIvR6OmPtCe2BrigXRZFV2F9GhXG9vi4ZA7mYn9zEUTNp8xcUl/N+p5d3NPcN/M/HzHaL8hhmP8jc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RnPclQV+; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RnPclQV+" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-477619f8ae5so18165895e9.3 for ; Wed, 07 Jan 2026 07:43:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767800589; x=1768405389; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LWcjT0u5z34/kb7Qe+H5E0kwqGCVYd2l01+VUnZbj/8=; b=RnPclQV+q9GbTwR26TJyKkssnz52u5hEgZN7hqPkUYJKkJ3LKjZOVZcg0EV+FijjOY CcAEHrthtU+GgWWs/pjH9zTWxMnljv3gI5L2NdrNBox93p0g3NYkNsThC5zaJuyyir5+ Pl6AnUdPPLgh48r6KBqlNry4Bd8Dj7REODbNn62SJcIGhPSpa14KCJYGMt80UsvGaRRy ctN212puQxsnr+Xg/casU1OAHxXIH/vxr5PAuotFCI0jZa2BIoT/5cIbsuc0Gwxfj38Q 27OL6OAnweYekrioBOugJSC+HhuRYF7IrTQE1Mj5O+zzm5F72LfbcQsGQiPqMZ5BBmyW p32g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767800589; x=1768405389; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LWcjT0u5z34/kb7Qe+H5E0kwqGCVYd2l01+VUnZbj/8=; b=YZv6lzC+vLruk5AyeYxEvbA1NFP2RgluXsBHd/lVXfD7q5LwBm2QyjZeAeaAhSVR6q 0rn1tXW/liiKXxfYvtXatcHItdTxK1nqAZYdm1c1PzegsgX/WdJkOCnVLpouWdOyWgRf S9/YfsI18Mgh7cLnQb8yzrEd2UZIkrLjLVUkq82xnDaqptWshwFz0HJmR7lk1UZRUHos ik35kh5RjA7ujqqjrXcGC6gtNrR5Fu1tLjtsVgHTLch/F7IAGlmV11JP6fHcjMsLiCOa 5tCMC2FtI2fctIDnpXFTPh364Bjf1xsbC5oUG+1vdUwwuXJsJ2HQoqx1S4IQ50Q09Xl3 bKhQ== X-Forwarded-Encrypted: i=1; AJvYcCWWJBLtHff5IY+cJuujzJRp10N+29VTDIzV/Rc43EKDtxmtfYNr1VuTalQEMO0canVSB/0Sq9pFTyRKcQ4=@vger.kernel.org X-Gm-Message-State: AOJu0YxDmk0pxGBFHppdO6DMObWidfAZdqoSRuOgtllfp2ODZGREZ2/8 fTRP5ld2NlKhfuxbWct3iXG/7gqdthMKrgi9C811od2EJyNphR5OZiuO X-Gm-Gg: AY/fxX6qKZuC82KWKaCADfi2ZlI/ux+CYHka/wVdYXUJIyhZKIINaVAD0awuPvyat80 laLElT8VcqHavmAORDUC0o/gaINVQsEUSOtJvdZb/8n7hbTR5pBHILS37elW2kgWBAMmXUR9dPN 5pPPRoTYh6jtTEji5HF1vf/FpMKp2LlZWcGeNjeCjsTW8DBCGYecApL2ZuOh0WsgRleaakDD4hi P/1lNSJJ5OMccd+jeukIJpsY4polFS5gaKJvO7c50rx70XCcNQU41x3MAqSo5NGpzxM+XP4heX+ YUyalK70KuPXgTADc01GQMoDvNrCW0EMqU6dqGAUi6uxHgtdyj4zkFBR6Q8I5zhNxyioFwMsW6i FRIUiIatGo0JwqMdiqlbQRHVcb9nEoSTTcqiPg5mEYQu6spVRxCstZ45+7KvV0PJvitVO6bPqqZ Gy2XEt/bQ5FrXLP0akbrJbvkr+dMdM+7Altdkodmk= X-Google-Smtp-Source: AGHT+IFpf2LzcsxARVLcwohJ3nsYKzlej0OLE5M0q63SVWJgq05KEyIXF6Z5wAEIb8+uglN38BG8iA== X-Received: by 2002:a5d:5f54:0:b0:431:c60:c5ed with SMTP id ffacd0b85a97d-432c36282admr3814141f8f.13.1767800589326; Wed, 07 Jan 2026 07:43:09 -0800 (PST) Received: from ionutnechita-arz2022.local ([2a02:2f0e:ca09:7000:33fc:5cce:3767:6b22]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ee243sm10897704f8f.31.2026.01.07.07.43.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:43:08 -0800 (PST) From: "Ionut Nechita (Sunlight Linux)" To: benato.denis96@gmail.com, jikos@kernel.org, bentiss@kernel.org Cc: ionut_n2001@yahoo.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, sunlightlinux@gmail.com, superm1@kernel.org Subject: [PATCH v5 4/4] HID: asus: Implement Fn+F5 fan control key handler Date: Wed, 7 Jan 2026 17:42:24 +0200 Message-ID: <20260107154219.164514-10-sunlightlinux@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260107154219.164514-2-sunlightlinux@gmail.com> References: <20260107154219.164514-2-sunlightlinux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Ionut Nechita On Asus ROG laptops, the Fn+F5 key (HID code 0xae) is used to cycle through fan modes. This key press needs to be forwarded to the asus-wmi driver to actually change the fan mode. Add ASUS_FAN_CTRL_KEY_CODE define and implement the handler in asus_raw_event() to send WMI events when this key is pressed. When asus-wmi successfully handles the event, it is blocked from reaching userspace. If asus-wmi is unavailable or fails, the event is passed to userspace via evdev, allowing userspace implementations of fan control. Tested on Asus ROG G14/G15 series laptops. Reviewed-by: Denis Benato Reviewed-by: Mario Limonciello (AMD) Signed-off-by: Ionut Nechita --- drivers/hid/hid-asus.c | 35 ++++++++++++++++++++++++++++++----- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 6fcd3213857cf..06f32a39c0cf7 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -65,6 +65,9 @@ MODULE_DESCRIPTION("Asus HID Keyboard and TouchPad"); #define ASUS_SPURIOUS_CODE_0X8A 0x8a #define ASUS_SPURIOUS_CODE_0X9E 0x9e =20 +/* Special key codes */ +#define ASUS_FAN_CTRL_KEY_CODE 0xae + #define SUPPORT_KBD_BACKLIGHT BIT(0) =20 #define MAX_TOUCH_MAJOR 8 @@ -379,12 +382,34 @@ static int asus_raw_event(struct hid_device *hdev, if (report->id =3D=3D FEATURE_KBD_LED_REPORT_ID1 || report->id =3D=3D FEA= TURE_KBD_LED_REPORT_ID2) return -1; if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) { - /* - * ASUS ROG laptops send these codes during normal operation - * with no discernable reason. Filter them out to avoid - * unmapped warning messages. - */ if (report->id =3D=3D FEATURE_KBD_REPORT_ID) { + /* + * Fn+F5 fan control key - try to send WMI event to toggle fan mode. + * If successful, block the event from reaching userspace. + * If asus-wmi is unavailable or the call fails, let the event + * pass to userspace so it can implement its own fan control. + */ + if (data[1] =3D=3D ASUS_FAN_CTRL_KEY_CODE) { + int ret =3D asus_wmi_send_event(drvdata, ASUS_FAN_CTRL_KEY_CODE); + + if (ret =3D=3D 0) { + /* Successfully handled by asus-wmi, block event */ + return -1; + } + + /* + * Warn if asus-wmi failed (but not if it's unavailable). + * Let the event reach userspace in all failure cases. + */ + if (ret !=3D -ENODEV) + hid_warn(hdev, "Failed to notify asus-wmi: %d\n", ret); + } + + /* + * ASUS ROG laptops send these codes during normal operation + * with no discernable reason. Filter them out to avoid + * unmapped warning messages. + */ if (data[1] =3D=3D ASUS_SPURIOUS_CODE_0XEA || data[1] =3D=3D ASUS_SPURIOUS_CODE_0XEC || data[1] =3D=3D ASUS_SPURIOUS_CODE_0X02 || --=20 2.52.0