From nobody Mon Feb 9 10:12:50 2026 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1668B3AA1AF for ; Wed, 7 Jan 2026 15:33:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800038; cv=none; b=YQrWqDADJpRx9MBzApokmZKpztM16YStwL3BlCCzEayrvKTDyOC6vl0yplTnQEdta4SY+z75er4m6MyRKvAc5RsB3Z0KwVAx8QFqAzurlNExMKXoHMpTt0wEhxTj6JwXH5xjfLn9ujddAen63kv/OlToBy4a8yype6DluIqRDMY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800038; c=relaxed/simple; bh=/zbQHEHtq57A2Q6JHU6gAg/bO8p74zRbMnNSIB3dT5M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z1jjxAYCtnbGubDpuvoZz/exPmC6gJ3Jol4FH2ejTDIXRoqoIXjQlQeFFP+4lPVtpgyP18N0mJ5nqy2yCAdT+AYwahquF2dLQHTy/UP+gH1TbECSou3nAD6IQ2WztvxaRE8jdwMoWF0TKpb8kiM1KoUDBR3gzebCoKMRDk6lKro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=Groves.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lt5Lfk3l; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=Groves.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lt5Lfk3l" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-44fe903c1d6so619664b6e.0 for ; Wed, 07 Jan 2026 07:33:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767800034; x=1768404834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=5ATdgisM3Tik/NiyOwZFhtzJ8q/T+7QdescJPqQtpWw=; b=lt5Lfk3lcoB8+ss+HcELQvjRr1WblEz5sVwhQy11HLnS8reSuHpu0lTxPLH+rM+JeV VCrxplhNlRYnGmkPBk5t2OCtFD8QuOYBC3nCIMFMYCLWBC7u2L8m/Z5WXVcYs2OiGWQ4 jCeMHvlgM2J4ou0Hv4pkcYCUIE5lcvatGoStX+xMLk8dcL4jzq0TXM2RCVMaeEssfJGe RWoQkyat8cKsyzvQOEZTK1qLBo6gSLWNki5iOgEDxQyuhgsycQYgygg6A3yPgi1+jIEb Wv2vTHskl7GeXZBFWG26D9CKMogBltlOXc6LkbgDYdhtTLzC/AtlDn30DvSdrZz5MeHL pJbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767800034; x=1768404834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5ATdgisM3Tik/NiyOwZFhtzJ8q/T+7QdescJPqQtpWw=; b=bRLHxbIb/dOLxQBwaCzHguXjA2xrI+cack/Uf0d7qHKHoRoJLR1axLVndYhDFInFtp Qm2ZSDj+fuGF8E61cH5tIfCNB68aLPA7/Pw8h0mYs8ixmzhm8acuWxPPzjUf5u3RBxXj 6efY5kR3xKjnJ5XVi1zXPRRpRFg/Si6Aqk1v5FHJcNkxU+nz/4kNjZCAxwWX5eaookp8 3ynAfckBfnf41KxJ7itBF8c6Pk/tuDge9p7xaDmjv5C3RwOcrIov4bLips+uDAsbWzbh SBVbIecV1SFyZOemsv+eef2slAIK7n4sQIopdn/N8t6vco1cjV/NxrUzxiR0OjGYsik5 eyfA== X-Forwarded-Encrypted: i=1; AJvYcCXCHci9GCTmBvjc1V2qkzyxs11B322TRYmUclXkUJGR3arC9fPs2tJqjRbq9iO3UAUBpc1sq5+l9G6mRGA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1AVuInFDqOHNbshamjgL1J+I3sFUW4r46l1zwnLmrRGbrFiPG 6kTHC45ip9hi5N+w+3WzJJ9F/QMIQhhhE+VrL326Hv/ERDMVaUagbBNC X-Gm-Gg: AY/fxX7yf4CrAAxEqm3fjuaKKJGsHCGKDsJKu8wWkKdHpw5YwuoK9KT/UAKtYHj/Ss7 3qkIFBYXyK2lYhm3wk4twbb93IUWFdSo1Tme3BoUtTVG4PWNEJ6ubZ+R2VjF/iwu6KtGenbc31m 8cv3AwZrtfX6JeOS7HbGw6uV9xrHtcrGsuMcT/TWOsWT+pT5yM2JjSAydxlXJ1BQ4h40EY83Vhc 8WZBuolY5zEgTgBBENffZt2xoSMq+0vv1Ko2ZtLaynwoeeFo0oauyYNqziM4WRVH5K3ghkG4BHH OJuzoU8YW7B/bVM+OnC6ihA321klf32rbgdDeWESKGEZBW4RStSnVFe46wjeItV6KA5i+Lgp4Jk pffTD23X2sQL/AZWPwIGCx7bgyOYUfhytfELx86BxyDrQXH7FZJ7QqsSQhhITnu5+YpvcYArwon 5JjteH9O0RnXyetFmmtQTjF4cVuIoA2zkdR+xqvYAUiEW7DjY0Xgkx5zM= X-Google-Smtp-Source: AGHT+IHve8YogzpLKDi2h5kk3r5qd0JvNPCUalMGA+1cdHL4kOqm5K/1cEfDtLFJl4ZqKfKbsphkmg== X-Received: by 2002:a05:6808:179e:b0:450:bbed:7a75 with SMTP id 5614622812f47-45a6bde282cmr1183058b6e.28.1767800033754; Wed, 07 Jan 2026 07:33:53 -0800 (PST) Received: from localhost.localdomain ([2603:8080:1500:3d89:a917:5124:7300:7cef]) by smtp.gmail.com with ESMTPSA id 5614622812f47-45a5e2f1de5sm2398106b6e.22.2026.01.07.07.33.51 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 07 Jan 2026 07:33:53 -0800 (PST) Sender: John Groves From: John Groves X-Google-Original-From: John Groves To: John Groves , Miklos Szeredi , Dan Williams , Bernd Schubert , Alison Schofield Cc: John Groves , Jonathan Corbet , Vishal Verma , Dave Jiang , Matthew Wilcox , Jan Kara , Alexander Viro , David Hildenbrand , Christian Brauner , "Darrick J . Wong" , Randy Dunlap , Jeff Layton , Amir Goldstein , Jonathan Cameron , Stefan Hajnoczi , Joanne Koong , Josef Bacik , Bagas Sanjaya , Chen Linxuan , James Morse , Fuad Tabba , Sean Christopherson , Shivank Garg , Ackerley Tng , Gregory Price , Aravind Ramesh , Ajay Joshi , venkataravis@micron.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, John Groves Subject: [PATCH V3 04/21] dax: Add dax_operations for use by fs-dax on fsdev dax Date: Wed, 7 Jan 2026 09:33:13 -0600 Message-ID: <20260107153332.64727-5-john@groves.net> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260107153332.64727-1-john@groves.net> References: <20260107153244.64703-1-john@groves.net> <20260107153332.64727-1-john@groves.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: John Groves * These methods are based on pmem_dax_ops from drivers/nvdimm/pmem.c * fsdev_dax_direct_access() returns the hpa, pfn and kva. The kva was newly stored as dev_dax->virt_addr by dev_dax_probe(). * The hpa/pfn are used for mmap (dax_iomap_fault()), and the kva is used for read/write (dax_iomap_rw()) * fsdev_dax_recovery_write() and dev_dax_zero_page_range() have not been tested yet. I'm looking for suggestions as to how to test those. * dax-private.h: add dev_dax->cached_size, which fsdev needs to remember. The dev_dax size cannot change while a driver is bound (dev_dax_resize returns -EBUSY if dev->driver is set). Caching the size at probe time allows fsdev's direct_access path can use it without acquiring dax_dev_rwsem (which isn't exported anyway). Signed-off-by: John Groves --- drivers/dax/dax-private.h | 1 + drivers/dax/fsdev.c | 80 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 81 insertions(+) diff --git a/drivers/dax/dax-private.h b/drivers/dax/dax-private.h index 1bb1631af485..fbd8348cc71c 100644 --- a/drivers/dax/dax-private.h +++ b/drivers/dax/dax-private.h @@ -85,6 +85,7 @@ struct dev_dax { struct dax_region *region; struct dax_device *dax_dev; void *virt_addr; + u64 cached_size; unsigned int align; int target_node; bool dyn_id; diff --git a/drivers/dax/fsdev.c b/drivers/dax/fsdev.c index c5c660b193e5..9e2f83aa2584 100644 --- a/drivers/dax/fsdev.c +++ b/drivers/dax/fsdev.c @@ -27,6 +27,81 @@ * - No mmap support - all access is through fs-dax/iomap */ =20 +static void fsdev_write_dax(void *pmem_addr, struct page *page, + unsigned int off, unsigned int len) +{ + while (len) { + void *mem =3D kmap_local_page(page); + unsigned int chunk =3D min_t(unsigned int, len, PAGE_SIZE - off); + + memcpy_flushcache(pmem_addr, mem + off, chunk); + kunmap_local(mem); + len -=3D chunk; + off =3D 0; + page++; + pmem_addr +=3D chunk; + } +} + +static long __fsdev_dax_direct_access(struct dax_device *dax_dev, pgoff_t = pgoff, + long nr_pages, enum dax_access_mode mode, void **kaddr, + unsigned long *pfn) +{ + struct dev_dax *dev_dax =3D dax_get_private(dax_dev); + size_t size =3D nr_pages << PAGE_SHIFT; + size_t offset =3D pgoff << PAGE_SHIFT; + void *virt_addr =3D dev_dax->virt_addr + offset; + phys_addr_t phys; + unsigned long local_pfn; + + WARN_ON(!dev_dax->virt_addr); + + phys =3D dax_pgoff_to_phys(dev_dax, pgoff, nr_pages << PAGE_SHIFT); + + if (kaddr) + *kaddr =3D virt_addr; + + local_pfn =3D PHYS_PFN(phys); + if (pfn) + *pfn =3D local_pfn; + + /* + * Use cached_size which was computed at probe time. The size cannot + * change while the driver is bound (resize returns -EBUSY). + */ + return PHYS_PFN(min_t(size_t, size, dev_dax->cached_size - offset)); +} + +static int fsdev_dax_zero_page_range(struct dax_device *dax_dev, + pgoff_t pgoff, size_t nr_pages) +{ + void *kaddr; + + WARN_ONCE(nr_pages > 1, "%s: nr_pages > 1\n", __func__); + __fsdev_dax_direct_access(dax_dev, pgoff, 1, DAX_ACCESS, &kaddr, NULL); + fsdev_write_dax(kaddr, ZERO_PAGE(0), 0, PAGE_SIZE); + return 0; +} + +static long fsdev_dax_direct_access(struct dax_device *dax_dev, + pgoff_t pgoff, long nr_pages, enum dax_access_mode mode, + void **kaddr, unsigned long *pfn) +{ + return __fsdev_dax_direct_access(dax_dev, pgoff, nr_pages, mode, + kaddr, pfn); +} + +static size_t fsdev_dax_recovery_write(struct dax_device *dax_dev, pgoff_t= pgoff, + void *addr, size_t bytes, struct iov_iter *i) +{ + return _copy_from_iter_flushcache(addr, bytes, i); +} + +static const struct dax_operations dev_dax_ops =3D { + .direct_access =3D fsdev_dax_direct_access, + .zero_page_range =3D fsdev_dax_zero_page_range, + .recovery_write =3D fsdev_dax_recovery_write, +}; =20 static void fsdev_cdev_del(void *cdev) { @@ -197,6 +272,11 @@ static int fsdev_dax_probe(struct dev_dax *dev_dax) } } =20 + /* Cache size now; it cannot change while driver is bound */ + dev_dax->cached_size =3D 0; + for (i =3D 0; i < dev_dax->nr_range; i++) + dev_dax->cached_size +=3D range_len(&dev_dax->ranges[i].range); + /* * FS-DAX compatible mode: Use MEMORY_DEVICE_FS_DAX type and * do NOT set vmemmap_shift. This leaves folios at order-0, --=20 2.49.0