From nobody Sat Feb 7 22:55:23 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AE7C34C9B5 for ; Wed, 7 Jan 2026 15:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767799350; cv=none; b=BY27wkf5elugJospYXG7XmqyKUAHtUcKYbCGwVJVZ8Af6JIZjW+UMM5mlmvSvR9b5iV2fX4tAcAYBCr9IJedr1sTi7R1ekh0/LkBgZnaacohM6hy7zkDjRN7j/vZY2WGOXRHECYxc4x7OPVEQVbO8QVNFuB6aVfyGamy7ZIwYoI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767799350; c=relaxed/simple; bh=h4u0BF0yZlzLqWNRxTYSOOkUN04hvFd3ewRMm1bOYeQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=o4+bK1jKQ1yR0s3niPMCF5SzeZ5+4Y0aV1HnOn01TPT6g3CnK5q+5+2jCLQzz6uU8sH8kND9urzV5m4/ramGs8T3LFnONicKN9KHoO51wuSKiwawA6KGMdFdVPmRy8qEgeJq2VFVsVPb/grSsdlrBcNIYYFsghechCZl7lwM9v4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SF8svssp; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SF8svssp" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2a07f8dd9cdso17664585ad.1 for ; Wed, 07 Jan 2026 07:22:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767799348; x=1768404148; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sdxCSj7IxYx4mdmyx7Q1b6kpadssGE7RLHdUQIibz6M=; b=SF8svsspyO9X7plqokGFI0Pw0P9AAREgi1p1AJr6Bt0zHc0OyND0VgON+QVf2cLnoY tPHPrmb1BTHiERPisjETcznIU+b18ScZfVUnWoNMm29CaUpo7k6n6gZbWFmMcC4CDtuj MI2M3Dilbk+2L143V8gEwdRk68i0QkO9EQ4mdiRSLd937KLjM3jLezbm/7NoTfp+q43b a9xr/kxWsQA3tyjACyPysN1+WOQhMbbojZ+qN2fpZeKzueNZY/bOnPWa2s3gw4KL7AIo M/gH+XUcSFU7w6rPpZ+z6xKVeBERVruhcNW3FncqDuEh2u6dEH7o/It4+TBIZh2ZyTm3 +BBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767799348; x=1768404148; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sdxCSj7IxYx4mdmyx7Q1b6kpadssGE7RLHdUQIibz6M=; b=AouBKl+YYhaxQnwYA2Btmd1niWFIXeH1cZaaVbejQ/onGLKeWg2mlUEPHZ/A1xFdwt l8F1D0xRa4Bjk68TSQACWB4XJVyts1PN0JZhHnoETceCgtbjIe3FrVaVRPEK/+3NcDs+ 6dMNEXCf1vxOAA/DIUNaSF22j1CXTNJEP1kKPiwqB1oOcHKq1clc7ImhLT9vDwvozszK 9tBufYZRdoLUzcK64cIl1l5FTf3+BdY+Y96edzccQGFcXkExEBnz+R8Dy/6bc6G5WIr2 KiuwlpXneQblY9yDCAriLUIV21rLmI1ZibUQ8f6tpFvCQLs1HRZxZZZDJafrUT5gKidr X6fA== X-Gm-Message-State: AOJu0YzSqCwOjHcc0juqANHyWgQrB1KZNGsLTVBv0K8PIXk2Lt8aya9R +aZas9O5g/UciMpBcJKDz6Y6P6+JgT2S2ZqcOxhR2QOVEzi5tciEdf4= X-Gm-Gg: AY/fxX4O2+blsfSFIqWZq+89xAZKkfNMozVrLLMZfA4ilJw67ySaPfwm56z0gG8RHhU Bsm7IUYNabDW1WuOvT1aEpsNUFyJgxC9DBbaHw5Z3R2dDjMB/Rh2PT7E1RGLbcdMF8VOE//WGxQ n7FHsQlBCMoS16RmReGDltsEIiohtkomTpI2TCL6o4blrPK8G8EK7WK0kseaRnx/17S+7RxnNUn VQdpNmLMb6s45oTlhp5hBTz5vpT7CkBdeLwc3EkbkvAqM3rUmpOuS5bzcBDD5paTx3InfkTjJa2 DXnE938TBvmWi4/PR34e53Ej5pIhuW2qk8gNhGApabQhRN0JhRN8nbjL1OagYDPX9ML6LVMIfTi U9ZRGzICkVq3PH9tQuxTFU1mwl+OzNhrIF3WM6E2ugje92ogJargM/meUe/SkIEacldkzIknRg7 qGCeJ+fMjQKrr1qHkrSGxqQlwRv8E6gWsPBPho/nJJf/makgpDuGqnXxorWYVH5k9Txqt0KBmeg BlAgwhv X-Google-Smtp-Source: AGHT+IE/VHabcQpTgDz+j9mE/p9A7Pi04kv3yVRw7CUuTmCqstblQLh4MVKrPf2XkxA4TVuG733qiw== X-Received: by 2002:a17:902:f682:b0:2a0:a33f:3049 with SMTP id d9443c01a7336-2a3ee40e4a6mr24689995ad.4.1767799348225; Wed, 07 Jan 2026 07:22:28 -0800 (PST) Received: from DESKTOP-BKIPFGN (ec2-54-169-177-146.ap-southeast-1.compute.amazonaws.com. [54.169.177.146]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cb2b4dsm55212575ad.54.2026.01.07.07.22.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 07:22:27 -0800 (PST) From: Kery Qi To: lgirdwood@gmail.com Cc: linux-kernel@vger.kernel.org, Kery Qi Subject: [PATCH] ASoC: rockchip: max98090: Fix reference leak in snd_rk_mc_probe Date: Wed, 7 Jan 2026 23:22:13 +0800 Message-ID: <20260107152213.1500-1-qikeyu2017@gmail.com> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The snd_rk_mc_probe() function calls of_parse_phandle() to acquire device nodes for "rockchip,i2s-controller", "rockchip,audio-codec", and "rockchip,hdmi-codec". These functions return device nodes with incremented reference counts. However, in several error paths (e.g., when rk_parse_headset_from_of(), snd_soc_of_parse_card_name(), or devm_snd_soc_register_card() fails), the function returns directly without releasing the acquired nodes, leading to reference leaks. This patch adds the missing of_node_put() calls in the error handling paths. It also cleans up the of_node pointers in the dai_link structure to prevent potential use-after-free issues. Signed-off-by: Kery Qi --- sound/soc/rockchip/rockchip_max98090.c | 27 +++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip/ro= ckchip_max98090.c index 075d0990a126..cd9305a5af72 100644 --- a/sound/soc/rockchip/rockchip_max98090.c +++ b/sound/soc/rockchip/rockchip_max98090.c @@ -414,6 +414,8 @@ static int snd_rk_mc_probe(struct platform_device *pdev) card->dai_link[0].platforms->of_node =3D np_cpu; } else { dev_err(dev, "At least one of codecs should be specified\n"); + if (np_cpu) + of_node_put(np_cpu); return -EINVAL; } =20 @@ -423,7 +425,7 @@ static int snd_rk_mc_probe(struct platform_device *pdev) if (np_audio) { ret =3D rk_parse_headset_from_of(dev, np); if (ret) - return ret; + goto err_put_nodes; } =20 /* Parse card name. */ @@ -431,7 +433,7 @@ static int snd_rk_mc_probe(struct platform_device *pdev) if (ret) { dev_err(&pdev->dev, "Soc parse card name failed %d\n", ret); - return ret; + goto err_put_nodes; } =20 /* register the soc card */ @@ -439,10 +441,29 @@ static int snd_rk_mc_probe(struct platform_device *pd= ev) if (ret) { dev_err(&pdev->dev, "Soc register card failed %d\n", ret); - return ret; + goto err_put_nodes; } =20 return ret; + +err_put_nodes: + for (int i =3D 0; i < card->num_links; i++) { + if (card->dai_link[i].codecs->of_node) + card->dai_link[i].codecs->of_node =3D NULL; + if (card->dai_link[i].cpus->of_node) + card->dai_link[i].cpus->of_node =3D NULL; + if (card->dai_link[i].platforms->of_node) + card->dai_link[i].platforms->of_node =3D NULL; + } + + if (np_audio) + of_node_put(np_audio); + if (np_hdmi) + of_node_put(np_hdmi); + if (np_cpu) + of_node_put(np_cpu); + + return ret; } =20 static const struct of_device_id rockchip_max98090_of_match[] =3D { --=20 2.34.1